github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing flaky runSoon test (#142652)

Browse source 
* Unskipping test

* Unskipping test

* Adding retries

* Cleanup
This commit is contained in:
Ying Mao 2022-10-05 08:26:32 -04:00 • committed by GitHub
parent 34deabc6bb
commit f644fde9a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/run_soon.ts
View file

@ -18,8 +18,7 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
const es = getService('es');
const esArchiver = getService('esArchiver');
// Failing: See https://github.com/elastic/kibana/issues/142564
describe.skip('runSoon', () => {
describe('runSoon', () => {
const objectRemover = new ObjectRemover(supertest);
before(async () => {
@ -36,7 +35,7 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
it('should successfully run rule where scheduled task id is different than rule id', async () => {
await retry.try(async () => {
// Sometimes the rule may already be running. Try until it isn't
// Sometimes the rule may already be running, which returns a 200. Try until it isn't
const response = await supertest
.post(`${getUrlPrefix(``)}/internal/alerting/rule/${LOADED_RULE_ID}/_run_soon`)
.set('kbn-xsrf', 'foo');
@ -53,10 +52,13 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
expect(response.status).to.eql(200);
objectRemover.add('default', response.body.id, 'rule', 'alerting');
const runSoonResponse = await supertest
.post(`${getUrlPrefix(``)}/internal/alerting/rule/${response.body.id}/_run_soon`)
.set('kbn-xsrf', 'foo');
expect(runSoonResponse.status).to.eql(204);
await retry.try(async () => {
// Sometimes the rule may already be running, which returns a 200. Try until it isn't
const runSoonResponse = await supertest
.post(`${getUrlPrefix(``)}/internal/alerting/rule/${response.body.id}/_run_soon`)
.set('kbn-xsrf', 'foo');
expect(runSoonResponse.status).to.eql(204);
});
});
it('should return message when task does not exist for rule', async () => {