Commit graph

12 commits

Author SHA1 Message Date
Joe Fleming
01cf8ff3a5 add architecture styleguide (#10094)
* add architecture styleguide

* be clearer about application architecture

* define as plugin architecture

and downplay the webpack alias and shims that are available

* fix typo, simplify server description
2017-02-06 15:37:00 -07:00
jasper
0c96c39e51 Explain rationale of HTML bracket formatting in HTML style guide. (#9631)
Backports PR #9629

**Commit 1:**
Explain rationale of HTML bracket formatting in HTML style guide.

* Original sha: a041d5f460
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T20:14:34Z
2016-12-23 12:18:01 -08:00
jasper
9eea6a5769 Fix markdown typo in CSS style guide. (#9409)
Backports PR #9408

**Commit 1:**
Fix markdown typo in CSS style guide.

* Original sha: 618eb469c9
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-07T21:17:17Z
2016-12-07 13:20:28 -08:00
jasper
76175e6b30 Use data-id attribute to select loading message, instead of CSS class… (#9271)
Backports PR #9248

**Commit 1:**
Use data-id attribute to select loading message, instead of CSS class since that creates a brittle coupling between JS and CSS.
- Formalize this rule in the CSS style guide.

* Original sha: d5747639cc
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-29T17:28:48Z

**Commit 2:**
Use uniquely and semantically named data attribute instead of data-id.

* Original sha: 0b426286f5
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-29T20:24:54Z
2016-11-30 08:13:04 -07:00
jasper
df4ba65067 Add preprocessor-related rules to CSS style guide. (#8942)
Backports PR #8921

**Commit 1:**
Add preprocessor-related rules to CSS style guide.

* Original sha: 1ec69e2d4e
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-01T17:56:47Z
2016-11-02 10:45:13 -07:00
jasper
e9671530ba Current styleguide conventions with modern JS (#8929)
Backports PR #7435

**Commit 1:**
Current styleguide conventions with modern JS

The existing styleguide was in great need of a rewrite as it did not
reflect the conventions we're using in the codebase or even the best
practices that we follow. In some cases, the guidance it provided was
outright contrary to our current practices.

* Original sha: 13e501bcf9
* Authored by Court Ewing <court@epixa.com> on 2016-06-12T14:03:13Z
2016-11-01 21:23:39 -04:00
Elastic Jasper
9dcc32a506 Backport PR #8859
---------

**Commit 1:**
Add BEM references to CSS style guide.

* Original sha: bbf948ed1a
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-10-27T19:09:03Z
2016-10-27 15:12:46 -04:00
Elastic Jasper
239f7b2402 Backport PR #8857
---------

**Commit 1:**
Fix CSS style guide state class naming convention to be camel case.

* Original sha: bc1b49b88e
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-10-27T18:54:40Z
2016-10-27 14:59:58 -04:00
CJ Cenizal
2c5e2bff3c Update CSS style guide with new state class format. Change examples to use component name instead of namespace. 2016-07-26 16:12:37 -07:00
CJ Cenizal
4cc4252230 Change HTML style guide. Specify that the opening tag's closing bracket goes on its own line. 2016-06-27 09:32:00 -07:00
CJ Cenizal
81fb346a8c Update API and HTML style guides.
- 80-character line limit in HTML.
2016-06-09 15:32:03 -07:00
CJ Cenizal
9d8776b199 Add style_guides dir, extracted sections from STYLEGUIDE.md.
- css_style_guidee.md
- js_style_guide.md
- html_style_guide.md
- api_style_guide.md
2016-06-09 08:13:35 -07:00