Commit graph

106 commits

Author SHA1 Message Date
Nathan Reese
cf12d4b70e
fix flaky input controls functional test (#31970) (#32013) 2019-02-26 06:58:42 -07:00
Stacey Gammon
c650e35e98
Fix dashboard to refresh visualizations when the refresh button is clicked (#27353) (#27458)
* Fix dashboard to refresh visualizations when the refresh button is clicked

* Suggestions

* Fix tests

* Catch bug with a new test to ensure saved searches update when query in url is modified

* Add a test that would have caught the initial problem

* Final fixes that should get ci passing and the bug fixed

* Move requestReload out of _pushFiltersToState

* Fix comparison
2018-12-18 20:25:51 -05:00
Peter Pisljar
2167c5b161
allow disabling gpu in tests (#26684) (#26869) 2018-12-10 09:14:30 +01:00
Spencer
b51987b9eb
[6.x] Wrap leadfoot elements (#26406) (#26748)
* Wrap leadfoot elements (#26406)

* [ftr] wrap all elements so we can swap out leadfoot without disturbing tests

* save

* [visualize/pie_chart] fix chart legend locator

* [services/leadfoot_element_wrapper] add getTagName function

* [services/browser] adjust moveMouseTo function

* [leadfoot/element] remove old args, document new ones

* [leadfootElementWrapper] add getSpecAttribute() method
2018-12-06 10:58:48 -08:00
Spencer
3abe125f57
[6.x] [ftr] wrap remote in browser service (#26394) (#26444)
Backports the following commits to 6.x:
 - [ftr] wrap remote in browser service  (#26394)
2018-11-29 16:11:36 -08:00
Caroline Horn
2c4fd9b475
TSVB less to sass - and some UI work (#24250) (#25653)
Fixes #16483, Fixes #20115, Fixes #17852, Fixes #16768, Fixes #14348, Fixes #17842, closes #15580, closes #14938
2018-11-14 13:26:19 -05:00
Stacey Gammon
4d4c159bf1
[Flaky test fix] Turn back on data_shared_attributes test (#25156) (#25554)
* Turn back on data_shared_attributes test and run 20x

* Add some clean up

* Be more determinism, less refactoring.

* Go back to a single test run
2018-11-12 20:20:40 -05:00
liza-mae
dca4772e84
Update clickOptionalAddNewButton method used in createIndexPattern (#25414) (#25427) 2018-11-08 16:51:37 -07:00
Lee Drengenberg
d012b6a015
Fix context test timing (#24949) (#25289)
* Add sleeps so tests will pass

* removed a space in a comment

* replaced some sleeps with waiting for loading indicator

* Removed context page object calls from filter_bar and doc_table services
2018-11-08 13:06:52 -06:00
Tim Roes
a2ccf779ba
Fix courier issues causing showMetricsOnAllLevels to break (#24488) (#24530)
* Fix courier tabify caching issue

* Better code style

* Change to named lodash import

* Fix missing DSL parameters on hierarchical query

* Add functional test for hierarchical agg configs
2018-10-24 23:58:36 +02:00
Matt Bargar
ccfb4482f6
[6.x] Euify and Reactify Query Bar Component (#23704) (#24420)
Implements query bar portion of https://elastic.github.io/eui/#/layout/header. Filter bar will come in another PR.

Fixes #14086

Re-implements our query bar component in React using some EUI components. Existing typeahead and suggestion styles were copied over 1:1 for now after talking with Dave about it. In this PR I focused on reaching feature parity with the existing query bar. Some additional work would be needed before we could move this into EUI as a generic component that could be consumed by other plugins.

Still needs some new tests and I suspect some old tests will need to be updated, but other than that this PR is functionally complete and ready for reviews.
2018-10-23 17:26:34 -04:00
Stacey Gammon
0f61756fce
Extend the timeout used to check if something exists. (#24140) (#24234) 2018-10-19 16:09:24 -04:00
Caroline Horn
7bdfd93e36
Vis types LESS to SASS (#23513) (#24153)
Backport - Also fixes #23969
2018-10-18 18:47:43 -04:00
Stacey Gammon
4cdfc9a526
Tests: Wait for dashboard save button to be enabled before clicking. (#23539) (#23838)
* Fixes #21446

An attempt to fix the above by making sure the click only happens when the button is enabled.

* Fix wrong function name

* Fix mistakes
2018-10-04 17:22:29 -04:00
Nathan Reese
f750ab71c1
Convert Discover open top nav to EUI flyout (#22971) (#23376)
* move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular

* implement flyout open saved searches

* remove old open stuff

* add jest test for OpenSearchPanel and simplify panel title

* fix functional tests

* fix _lab_mode functional test
2018-09-20 15:05:17 -06:00
Stacey Gammon
3983f30d38
Bring back most of the filtering tests, only bypass the known current issues (#22787) (#22996)
* Bring back most of the filtering tests, only bypass the known current issues.

* Clean up after the test suite run so it can be run multiple times in a row.

* goal and guage issues were because of a bad cache
2018-09-13 12:37:29 -04:00
Stacey Gammon
5a65d1e8ea
Capture browser logs on test failure (#22670) (#22983)
* Capture browser logs

* spit out in logs, simulate failure to test

* remove leftover code

* simulate failure

* Remove forced failure
2018-09-13 07:28:02 -04:00
Spencer
0161da81b2
[6.x] Migrate base path APIs and UiSettings client to new platform (#22694) (#22848)
Backports the following commits to 6.x:
 - Migrate base path APIs and UiSettings client to new platform  (#22694)
2018-09-08 03:42:10 -07:00
Stacey Gammon
2fed0dc349
Investigate flaky override colors dashboard test (#22726) (#22825)
* Run 30x

* attempt a fix

* go back to a single run
2018-09-07 14:52:17 -04:00
Tim Roes
9f37b1fe51
Add functional tests for visualize loader API (#22595) (#22649)
* Initial visualize loader functional tests

* Extend plugin test README

* Add temporary tz work around

* Switch to Australia/North timezone

* Add filtering tests

* Add all tests

* Remove unneeded uiExports

* Improve explanation

* Add saved object test, add retry
2018-09-04 15:09:57 +02:00
Marco Vettorello
6b504ed8af
Fix possible flakiness of saveVisualization action (#22356) (#22546)
* Updated saveVisualization to wait for toast instead of global indicator

* Fix RBAC tests.

The saveVisualization now fails directly if the visualization is not correctly saved.

* Change editor to use toast for errors

* Change saveVisualization method to new saveVisualizationExpectSuccess

For RBAC tests used also saveVisualizationExpectFail

* Fix wrong exists method call

* Fix missing exist function
2018-09-03 14:14:31 +02:00
Lee Drengenberg
3f3397ace5
Fix flaky dashboard color legend (#22341) (#22545)
* Rebuild modulePath correctly if on Windows

* Adding 1 second sleep to fix flaky test

* Wait to find a gear in the visualization after clicking Edit

* Revert "Wait to find a gear in the visualization after clicking Edit"

This reverts commit 8dac3fbd63.

* use waitForRenderComplete and change that to 1s timeout

* Use sleep until TagCloud data-render-complete is fixed

* Different getIsInEditMode courtesy of @chrisdavies

* combine switchToEditMode into one method
2018-08-30 12:41:25 -05:00
Lee Drengenberg
1b408edcb0
Speed up dashboard add panel (#22278) (#22339)
* Rebuild modulePath correctly if on Windows

* Change how we find dashboard add panel is loaded

* Add and use find.byClassName instead of remote

* cleanup a comment
2018-08-27 09:36:33 -05:00
Spencer
138f45698c
[accessibility] implement no-animation mode, auto enable for functional tests (#21629) (#22203) 2018-08-22 14:53:58 -07:00
liza-mae
00c0478c74
Emit error if api is not stopped and exit code is greater than zero (#22224) (#22257) 2018-08-22 12:26:59 -06:00
liza-mae
ef00f13d2c
Add option to run chrome headless. (#21972) (#22086)
* Add opton to run chrome headless. Mainly for windows tests which can't use xvfb.

* Update from review comments

Make environment variable Boolean, remove single quotes from keys, remove window size.
2018-08-20 15:19:35 -06:00
Marco Vettorello
6b4c015530
[test] Fix wrong waiting on toast message (#22131) (#22153) 2018-08-17 22:36:11 +02:00
Matt Bargar
cbd8910511 Fix available fields option toggle (#21730) (#21757)
a36b87a#diff-aff92ff718af4b68d02f030d8a438754 added an ng-if around the available fields button element. ng-if creates a child scope. The ng-click on the button directly modifies scope state. As a result, when the ng-if was added, that ng-click began modifying the ng-if's child scope instead of the parent scope.

The best solution would be to update the discFieldChooser directive to use the controllerAs property so its scope variables are namespaced. However, this is a bit risky because I'd need to make sure to update every single scope variable reference in the template, and it's a relatively large template. Since we'd like to backport this to 6.4 I've taken the less risky route of adding $parent to the scope reference inside the ng-if block.
2018-08-08 13:04:25 -07:00
Stacey Gammon
19546cb54e
Make visualization.waitForRender more generic and put in an embeddable class (#21688) (#21749)
* Make visualization.waitForRender more generic and put in an embeddable class.

* embeddable -> renderable

* missed a reference
2018-08-07 22:23:47 -04:00
Tim Roes
e49fe24835
Improve filterBar.addFilter performance (#21560) (#21694)
* use SavedObjectsClientProvider to provide SavedObjectLoader with an angular wrapped saved object client

* Improve filterBar.addFilter performance

* Add better documentation

* Ease logic of addFilter and add better docs

* Fix old addFilter calls
2018-08-06 19:57:57 +02:00
Peter Pisljar
edc48a636d
fixes pinned filters in visualize and dashboard (#21463) (#21632) 2018-08-03 11:45:20 +02:00
Peter Pisljar
b3fe4cfb44
fixing embedded mode in visualize (#21468) (#21522) 2018-08-01 11:27:13 +02:00
Nathan Reese
d02879d2c2
Move EuiComboBox functional test utility functions into own service (#21219) (#21451)
* Move EuiComboBox utility functions into its own service

* remove old functions from visualize page object

* use waitForDeletedByClassName instead of retry and exists to ensure no longer loading

* wait for options loading when getting options list
2018-07-30 18:24:10 -06:00
Bill McConaghy
b4790ea924
better fix for flaky management settings test (#21171) (#21368)
* better fix for flaky management settings test

* implementing better click strategy for toggleAdvancedSettingCheckbox

* converting all of settings page to use preferred styles for clicks and finds

* PR feedback

* fixing issue with missing method

* fixing issue with missing method

* adding missing method

* fixing test

* fixing test issue
2018-07-27 17:29:21 -04:00
Tim Roes
053a8e0a27
Wait for visualizations to render in tests (#21258) (#21357)
* Wait for visualizations to render

* Use Visualize.waitForRender on dashboard

* Enable previously flaky dashboard tests again

* Add data-loading for initial render

* Remove unnecessary timeout
2018-07-27 21:56:52 +02:00
CJ Cenizal
fbb042ecb1
Verify that we've navigated to Settings by checking the title. (#21245) (#21321)
* Fail the consuming test if navigation to settings is unsuccessful.
* Add testSubjects.existOrFail helper.
2018-07-27 11:59:23 -07:00
Stacey Gammon
1e803e7fe5
Fix refreshed dashboard losing time range (#20858) (#21264)
* Add test that would have caught the bug

* Initialize global state with current time range

* Fix issue with failing tests - need to remove added "t" parameter to the url in the new tests

* remove unneccessary extra call

* Fix tests that failed due to globally added time in new tests

* Update home page test to not care about any state.
2018-07-26 10:29:13 -04:00
Lee Drengenberg
ae966b57e6
Add method to wait for loading to complete in Add Panel table (#21109) (#21246)
* Add method to wait for loading to complete in Add Panel table

* remove extra retry loop
2018-07-25 18:45:09 -05:00
Bill McConaghy
6c5d885c38
Reactify users roles (#20739) (#21028)
* partial progress on reactifying users

* progress on EUIfication of users screen

* removing Angular stuff

* adding data-test-subj="passwordConfirmationInput"

* removing data-test-subj="userFormEmailInput" refs from tests

* fixing selector for role assignment

* some functional test fixes

* fixing some functional tests

* fixing last functional test

* removing stray console log

* fixing warnings

* attempting to fix flaky test

* trying again to fix flaky test

* PR feedback

* PR feedback

* fixing issue where form tried to submit

* adding sleep to allow user to load

* Design edits

Mainly adding wrapper EUI page elements, but also shifted around form elements.

* Fixed console error and added responsive prop to table

* addressing PR feedback

* A few more PR feedback

- Fixed alignment of table
- Removed the tooltip from the lock icon and placed the description inline.
- Changed delete button to an empty button

* addressing more PR feedback

* adding email field back in

* adding back username validation

* restoring original error message

* fixing dumb null error
2018-07-20 10:15:32 -04:00
Lee Drengenberg
885eb1039e
refactor login page check, turn off telemetry (#17435) (#20722)
* refactor login page check, turn off telemetry

* significant refactor of navigateTo

* replace slashes with _ in test failure output html files

* re-do out of date PR
2018-07-12 11:57:47 -05:00
CJ Cenizal
c6be289f21
Fix misspellings (#19981) (#20284) 2018-06-27 20:50:06 -07:00
CJ Cenizal
0da5bacd28
Adding firefox to test suite (#17195) (#20282)
* Created general driver to accept an argument select the driver to run.

* Added environment variable for driver, changed package.json to use custim leadfoot, and made changes to browserdriver to use any driver.

* Made changes per PR.

* Fixed all nits.
2018-06-27 19:46:35 -07:00
Tim Roes
9ba0689dcd
[6.x] Replace spy panels by Inspector (#16387) | Fix one inspector test (#20072) (#20076)
* Replace spy panels by Inspector (#16387)

* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips

* Fix test that doesn't exist on master

* Fix one inspector test (#20072)

* Remove file that came accidentally back due to merging

* Fix accidental merge paste

* Fix 6.4 test failures
2018-06-21 11:45:13 +02:00
Tim Roes
508df9e67e
Update EUI to 0.0.53 (#20005) (#20042)
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
2018-06-19 18:57:42 +02:00
Stacey Gammon
40e24f0bbb
Update dashboard snapshot tests (#19420) (#19562)
* update snapshot tests

* Update time ranges

* Add sleeps, adjust time, update snapshots

* Skip TSVB until the issue with vertical line placement and x-axis timestamps is fixed

* fix expectations of time range with saved search creation

* remove debug line
2018-05-30 16:47:55 -04:00
Spencer
4f29b323bf
Backport/19383/6.x (#19487)
* [eslint][tslint] require Apache 2.0 license headers

(cherry picked from commit 337fea30b9)

* [kbn-eslint-plugin-license-header] don't try to fix files with hashbangs

(cherry picked from commit db79f1501e)

* [eslint][tslint] autofix license headers
2018-05-28 20:24:23 -07:00
Stacey Gammon
225f541abb
Pluggable panel actions (#18877) (#19415)
* Allow pluggable panel actions

* Need to register it as being used in kibana

* Some cleanup

* update snapshots to match new EUI versions, set time range

* Use newer panelActions service

* add missing await

* More clean up and fixes

* bring back window reload

* Show actions in view mode too

* delete now unused files

* Use toggle action to determin if context menu is open

* Fix tests that assume the toggle is hidden in view mode.

* Add some debug logs

* Fix up assumptions

* Previous failing test was legit - we don't want to show remove option when panel is expanded

* Embeddable can be empty before the panel is loaded

* Should look for either visualize or discover page

* Address code comments

* address code review comments

* whoops, get rid of childPanelToOpenOnClick entirely
2018-05-24 16:41:05 -04:00
Nathan Reese
4a2ba0efc6
EUI dashboard add panel (#17374) (#19404)
* EUI add panel

* implement add functionallity

* style flyout so top nav is not covered

* add noItemsMessage

* add new visualization button

* remove angular add_panel template

* seperate search bar and table into its own component

* fix functional tests

* make slide out panel own focus to avoid weirdness of letting other buttons in nav from getting clicked and leaving slide out open

* remove deprecated method componentWillMount

* add jest test for DashboardAddPanel

* fix paging and replace EuiSearcBar with EuiFieldSearch

* fix functional tests

* fix dashboard filter bar functional test

* another functional test fix

* add more context to functional test failure message

* give search input a default value

* remove call to waitForRenderComplete to see if tests will pass

* fix dashboard filtering test

* updates from Stacey-Gammon review

* support filtering out lab visualizations

* add functional test for testing visualize:enableLabs with add panel

* add sorting by title to SavedObjectFinder componenet

* move add panel tabs to state

* clean up labs test differently
2018-05-24 12:53:49 -06:00
Tim Roes
4f0e1ab65b
Add missing test for #19221 (#19253) (#19307)
* Add tests

* Merge the two addFilter methods
2018-05-22 18:09:18 +02:00
Chris Roberson
8455bcdbba
[6.x] [Management] Saved objects to React/EUI! (#17426) (#19179)
* [Management] Saved objects to React/EUI! (#17426)

* Not working proto code

* More proto code

* Work in progress

* Just go back to non interactive searching, much easier

* This should be on the server

* Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)"

This reverts commit ef3339bd7a.

* Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)""

This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681.

* Use BasicTable properly

* Table improvements

* Small tweaks to the table

* Improvements

* Flyout mostly working

* Remove in memory table

* Getting close

* Tweaks

* Revamping server code, still need to support editing

* Progress

* Fix export

* Updates and passing functional tests

* Better links in relationships flyout

* Add skip import option

* Fixes around importing and removing unnecessary code

* Remove tags for now

* Tests for lib/

* Some fixes

* Ensure we clear index pattern cache

* Parity with master

* Revert any changes in package.json

* Reset any changes in this file

* Move the new argumen to the end to prevent test failures

* Fix functional tests

* Add relationship tests

* Fix tests

* API integration tests for relationships

* Ensure we're properly waiting for things to happen

* Fix test issue

* Wait for the table to finish loading instead of the whole page

* Tests for objects_table

* Componentry tests

* Ensure this is grabbing the right field

* Update snapshot

* Fixes with importing index patterns

* PR feedback

* PR feedback

* PR feedback

* Update snapshot

* PR feedback

* Update snapshot

* Respect the savedObjects:perPage config

* Updates from PR feedback

* More updates from PR feedback

* Make this more efficient

* Add debugging for functional test failures

* Wait longer

* Wrap each button accessor with a retry.try

* Try wrapping this in a retry.try

* Debug

* Lets make sure it is visible

* Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish

* Rewrite this per suggestions from stacey

* Update snapshots
2018-05-17 16:18:51 -04:00