Commit graph

24576 commits

Author SHA1 Message Date
Walter Rafelsberger
f665bc842d
[ML] Fix to not add configs with names which would result in nesting conflicts (#37212) (#37241)
Two group-by or aggregation names could result in conflicting nested fields which would return an error for pivot previews. For example, two names like responsetime and responsetime.avg are not allowed.

This PR fixes the issue by extending the tests whether a configuration is allowed to be added to the list of group-by and aggregation configurations. If a conflict is detected, a toast notification gets triggered and the configuration won't be added.
2019-05-28 19:23:35 +02:00
Walter Rafelsberger
76b3708bda
[ML] Fix access denied for data frames. (#37178) (#37238)
With insufficient privileges, a user would be redirected to the ML plugin's access-denied page which mentions the required user roles to access the pages. Since data frames introduces new user roles these messages were not correct.

This PR fixes it by redirecting to a specific access-denied page for data frames. To avoid to much refactoring as a fix, the page is a copy and port to React of the original one. In a follow up for 7.3, we should merge the two pages and it should have options to display required user roles given a certain context like anomaly detection or data frames.
2019-05-28 18:48:03 +02:00
Lisa Cawley
5aec6ff630 [DOCS] Facilitates content re-use in the monitoring configuration (#37123) 2019-05-28 08:54:36 -07:00
lcawl
414736552e [DOCS] Removes coming tags 2019-05-28 08:36:49 -07:00
Walter Rafelsberger
ae62b562b6
[ML] Data Frames: Fix to avoid queries for indices with more than 1024 fields. (#37183) (#37227)
- 7.0 introduced indices.query.bool.max_clause_count which defaults to 1024. This can break certain queries (e.g. simple_query) for indices which have more than 1024 fields (e.g. certain beats indices). The optional data frames query uses simple_query and could therefor break the source index preview as well the pivot preview and pivot job itself given these conditions.
- Originally the default query (* used for simple_query) was always applied for source index previews and pivot previews. A new check isDefaultQuery() will now allow a) the source index preview to use a more efficient match_all query and b) avoid adding the query to the pivot config. This avoids triggering the max_clause_count when no optional query is set.
- If an index has more than 1024 fields, the input form for an optional query will be hidden. A helper text explains the reasoning. This avoids triggering max_clause_count related errors from within the UI. A user can still copy a UI created config to the clipboard and add an optional query in Kibana dev console.
- Additionally, this PR adds a fix to format date fields in the source index preview table using moment-timezone and formatHumanReadableDateTimeSeconds to display dates with the correct timezone.
2019-05-28 17:30:21 +02:00
Dmitry Lemeshko
4406bf3ff6
TSVB: functional test for color picker, preview disable and series clone (#37186) (#37223)
* [visualize/_tsvb_chart] test for color picker, changing  preview and cloning series
2019-05-28 17:16:51 +02:00
Garrett Spong
dce1c3335b
[SIEM] Fix for removal of first filter clearing remaining filters (#37135) (#37145)
## Summary

As outlined in https://github.com/elastic/ingest-dev/issues/419, clearing the first filter within the Timeline Query Builder would result in all the remaining `and`'d filters being cleared as well. This PR fixes that issues, and adds testing to catch a future regressions.

Before:
![filter_query_clear_bug](https://user-images.githubusercontent.com/2946766/58357586-a26f9200-7e38-11e9-8c5e-11bbdfcabfef.gif)


After:
![filter_clear_fix](https://user-images.githubusercontent.com/2946766/58357436-05145e00-7e38-11e9-8a51-b90481afb9b9.gif)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) 
  - IE11 needs this fix to be applicable: https://github.com/elastic/ingest-dev/issues/263
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-05-28 08:47:27 -06:00
Oliver Gupte
8f00b58d7c
Closes #36992 by fixing path params bug by checking if serviceName even (#37062) (#37203)
exists in the current pathname
2019-05-28 03:04:06 -04:00
lcawl
006c6518d1 [DOCS] Updates 7.1.1 release notes 2019-05-27 15:00:34 -07:00
Catherine Liu
db0f4d2e38
Fixes check for existing min/max value in axisConfig (#37119) (#37149) 2019-05-27 10:11:07 -07:00
Catherine Liu
0b9aeb58cd
[Canvas] Expose shortcuts in tooltips (#36482) (#37147)
* Added shortcuts to tooltips

        * Added stories and tests

        * Added snapshots

        * Updated copy

        * Updated snapshots

        * Pulled out OS in KeyboardShortcutsDoc

        * Updated snapshot
2019-05-27 10:10:39 -07:00
Mengwei Ding
677b102f7d
[Code] Reset the default search scope (#37014) (#37169) 2019-05-26 22:16:14 -07:00
Mengwei Ding
f71384e9f9
[Code] improve project status polling management (#36841) (#37171)
* [Code] improve project status polling management

* [Code] Use make repository status polling cancellable

* change back to 1000ms polling interval

* deduplicate repository status polling runner before run
2019-05-26 18:04:10 -07:00
Walter Rafelsberger
35050f513b
[ML] Data Frames: Fixes aggregation item overflow. (#37068) (#37165)
Fixes an issue where long field names would overflow the aggregation item of the pivot config list. This fix was already done for the group-by-items, now brought over to aggregations too.
2019-05-26 12:04:12 +02:00
Walter Rafelsberger
64e1f5a4ba
[ML] Data Frames: Fix calendar_interval for date histograms. (#36905) (#37157)
Fixes the use of calendar_interval instead of interval for date histograms.
2019-05-25 18:47:51 +02:00
Søren Louv-Jansen
4f837c214c
[APM] Add useMemo and minor feedback for environment filters (#36970) (#37153)
* [APM] Add useMemo and minor feedback for environment filters

* Fix types

* Rename to `loadEnvironmentsFilter`

# Conflicts:
#	x-pack/plugins/apm/server/new-platform/plugin.ts
#	x-pack/plugins/apm/server/routes/services.ts
2019-05-25 17:32:54 +02:00
WangQianliang
61b93b938c
[Code] fix query string key conflict (#36620) (#37060)
* fix code query string key conflict

* fix code go to definition url
2019-05-25 09:17:50 +08:00
WangQianliang
bd19868e00
feature(code/frontend): breadcrumb links to code root and project root (#34252) (#37059) 2019-05-25 09:17:40 +08:00
WangQianliang
981b9f18e6
fix code file tree highlight style (#36859) (#37057) 2019-05-25 09:17:27 +08:00
WangQianliang
b79546e21f
fix(code/frontend): should show file tree if file not exists (#36106) (#37056) 2019-05-25 09:11:41 +08:00
spalger
c1fd907b09 disable failing test
(cherry picked from commit d7d392ef32)
2019-05-24 16:20:07 -07:00
lcawl
63734affaf [DOCS] Adds placeholder for 7.1.1 release notes 2019-05-24 16:00:44 -07:00
Spencer
90db3f4923
[siem/ui] avoid importing server code in ui (#37103) (#37110)
* [siem/ui] avoid importing server code in ui

* covert a couple extra imports
2019-05-24 15:09:04 -07:00
Chris Roberson
6f29f2c85c
Remove improper usage (#37099) (#37126) 2019-05-24 17:18:14 -04:00
Melissa Alvarez
9489db2576
[ML] Anomaly explorer query bar - ensure anomalies table results retained after refresh (#37041) (#37112)
* Don't specify influencers if overall cell selected

* use swimlane type overall constant
2019-05-24 15:02:03 -04:00
WangQianliang
da44e5e456 disable explore_repository and history functional tests (#36865) (#37058)
fix code functional test click file tree item
2019-05-24 09:46:53 -07:00
Walter Rafelsberger
93c333cc17
[ML] Data Frames: Fix (error) messages, data field aggs, date picker check. (#36972) (#37093)
- Layout and message fixes for displaying error messages for the pivot preview in `ml/public/data_frame/components/define_pivot/pivot_preview.tsx
- Fixes list of available date field aggregations.
- Fix to make sure datepicker is always disabled for pivot wizard.
- Fixes incomplete job delete confirm modal message.
2019-05-24 18:04:55 +02:00
stevedodson
5250bab872 [ML] Improve anomalies in Kibana sample data (#36982) (#37091)
* [ML] Sample ML jobs: Updates to make anomalies clearer

Minor updates to web logs data and ML job
definitions to make anomalous activity more
distinct.

* [ML] Sample ML jobs: Further updates to jobs and data

Adding missing files from previous commit and
changing job naming (removing weblog_* prefix etc.)

* [ML] Resolving PR review comments.

* [ML] Improve anomalies in Kibana sample data

Minor fixes:
- Rename job group to `kibana_sample_data` throughout
- Fix index pattern link in `sample_data_sets.ts`
- Fix log.json.gz count test
2019-05-24 16:42:12 +01:00
Chris Roberson
b0b1c574fb
[Monitoring] Fix 500 error from /api/stats (#36986) (#37083)
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
2019-05-24 11:03:02 -04:00
Chris Roberson
e874a8e287
Once the buffer has any events, the collector is always ready (#36995) (#37081) 2019-05-24 11:00:39 -04:00
Alexey Antonov
d710b06714
[TSVB] Rollup Search - override index pattern functionality is not working with Rollup search (#36641) (#37078) 2019-05-24 16:58:31 +03:00
Xavier Mouligneau
ed5fe5fea3 [SIEM] Remove imports from server folder (#37037) (#37050)
* remove import from server folder

* the other way around too
2019-05-24 12:24:25 +02:00
Alexey Antonov
87a3946439
[TSVB] Fix Rollup Search with auto interval for Rollup Jobs in calendar intervals (#36081) (#37067)
* auto interval

* [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals

* [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals

* fix issue

* fix broken tests

* fix pr comments

* fix pr comments
2019-05-24 13:21:48 +03:00
Walter Rafelsberger
b18554edf8
[ML] Data Frames: Fix saved search (#36894) (#36988)
- Fixes the use of Kibana saved searches for the data frame wizard. Previously users would end up on a blank page when choosing a saved search.
- Additionally, this fixes UI inconsistencies for the pivot creation form and summary page.
2019-05-24 09:27:56 +02:00
dave.snider@gmail.com
265b570dcf
eui 10.4.2 (#37032) 2019-05-23 16:33:47 -07:00
Xavier Mouligneau
74d7b622f1
[SIEM] Persistence of a Timeline (#36662) (#37008)
* persistence of a timeline

s Please enter the commit message for your changes. Lines starting

* fix unit testing + add functionality in the setting of timeline

* fix ciGroup5

* fix duplicate timeline

* fix merge issue

* fix test

* review I

* cleanup merge

* add kql from savedObject to kql bar

* add operator from Dataprovider to saveObject
2019-05-23 18:44:20 -04:00
Nathan Reese
0f10714350
[Maps] update docs for proxyElasticMapsServiceInMaps configuration (#36914) (#37028)
* [Maps] update docs for proxyElasticMapsServiceInMaps configuration

* Update docs/setup/settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
2019-05-23 16:33:43 -06:00
Joe Fleming
657e0dad41
[7.2] Feat: Filter groups (#34889) (#37019)
* feat: add group arg to filters function

multi-arg so multiple groups can be used, and the value is always an array

test: add setFilter tests

* chore: replace getGlobalFilterExpression with getGlobalFilters

* feat: add group arg to filters function

* feat: add grouping to filter functions

timefilter, exacttly, dropdownControl, and timefilterControl

* chore: add resolved config filter sync helper

* feat: add filterGroup to filter expressions

and keep the values in sync with expression via helper function

* feat: add basic group input to sidebar

* feat: add getGlobalFilterGroups selector, with tests

* chore: remove unused argForm resolve values

* feat: pass filter groups into argTypes

added via FunctionForm, which renders the associated argType

* feat: add filterGroup arg type

use it for the timepicker and dropdown UIs

* fix: tweak filter group name and help text

* fix: remove aliases from filter functions

it breaks the filter lookup code, and the value is almost always set from the UI control anyway

* fix: sort global filter groups

* feat: include filters function groups

when collecting filter groups, also include groups in expressions

* mostly copy changes

* feat: add ungrouped arg to filters

* chore: types and translations

* chore: address nit feedback
2019-05-23 13:56:50 -07:00
Mengwei Ding
33a6f45201
[7.2] Improve the functional test of code (#35869) (#37010)
* Improve the functional test of code (#35869)

* [Code] enable integration test

* [Code] Improve functional test

* [Code] skip explore-repository functional test for code (#36926)

* skip failing tests

(cherry picked from commit 2320ed9216)

* disable flaky test #36495 (#36497)
2019-05-23 13:49:11 -07:00
Frank Hassanabad
facc874cfa
Temporary fix for the docs build (#36878) (#37025)
The SIEM guide doesn't exist yet on the website, and there's code in
the docs build that checks for 404s.
2019-05-23 14:33:05 -06:00
Felix Stürmer
e92604d84c
[7.2] [Infra + Logs UI] Fix autocomplete overflow in Safari browser (#36820) (#37012)
Backports the following commits to 7.2:
 - [Infra + Logs UI] Fix autocomplete overflow in Safari browser  (#36820)
2019-05-23 15:35:36 -04:00
Garrett Spong
5d4807f4ab
[SIEM] Bugfix for Events Table query timestamp regression (#36952) (#36994)
## Summary

There was a regression that resulted in the `timestamp` field not being returned as part of the Events Table query. This PR fixes that and adds an api integration test that will catch this in the future.

Before Fix:
![image](https://user-images.githubusercontent.com/2946766/58217994-8518b780-7cc2-11e9-8abd-5c54c6d5c67d.png)

After Fix:
![image](https://user-images.githubusercontent.com/2946766/58218059-c3ae7200-7cc2-11e9-9427-b9c16c9be0e0.png)




### Checklist
~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-05-23 12:59:51 -06:00
Garrett Spong
c1304cfe68
[SIEM] Add Timestamp to Events Table (#36743) (#36925)
## Summary

This PR updates the `Events` table displayed on the `Host` and `Host Details` page as follows:
* Adds `Timestamp` as first column
* Removes `Event Category` column
* Increases `Message` column width, truncates long values, and moved column to last position

Relevant issues:
https://github.com/elastic/ingest-dev/issues/443

Updated Events Table:
![image](https://user-images.githubusercontent.com/2946766/58067684-71971080-7b4b-11e9-8751-e57b71cc43e6.png)


Previous Events Table:
![image](https://user-images.githubusercontent.com/2946766/58067629-372d7380-7b4b-11e9-854d-357766d1cb91.png)

### Checklist
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-05-23 12:59:37 -06:00
Jen Huang
5298adaf78
[SR] Instrument Snapshot Repositories with UI metrics (#36736) (#36933)
* Instrument Snapshot Repositories with UI metrics:
  * Repository list load
  * Repository create
  * Repository update
  * Repository delete, single
  * Repository delete, many
  * Repository show detail panel click
  * Repository detail panel verify repository button click
  * Snapshot list load
  * Snapshot show detail panel click
  * Snapshot detail panel summary tab click
  * Snapshot detail panel failed indices tab click
* Change detail panel click to link, add footer to snapshot details for close button
2019-05-23 11:38:02 -07:00
Larry Gregory
25ea8d4ae3
[7.2] Feature Controls - Documentation (#35656) (#36975)
* update spaces images

* add Spaces FC section

* Updates for kibana authorization section

* update plugin development guide

* start adding docs

* remove unused description field from Feature Registry interface

* Update role management API documentation

* Apply suggestions from code review

Thanks, Gail!

Co-Authored-By: legrego <lgregorydev@gmail.com>

* Update docs/api/role-management/put.asciidoc

* update kibana privileges section intro

* relocate link to Role Management API

* update PUT role docs to align with ES

* indicate that base and feature privileges cannot be used at the same time

* restructure kibana privileges section

* add UI and API examples to Kibana Privileges section

* Apply suggestions from code review

Co-Authored-By: legrego <lgregorydev@gmail.com>

* address PR feedback

* Apply suggestions from code review

Co-Authored-By: legrego <lgregorydev@gmail.com>

* Apply suggestions from code review

Co-Authored-By: legrego <lgregorydev@gmail.com>

* address pr feedback

* Update docs/api/role-management/put.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/security/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* address PR feedback

* fix merge from master

* Update docs/spaces/managing-spaces.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
2019-05-23 14:21:44 -04:00
Tudor Golubenco
212478c0b5
Add more tutorials for Filebeat modules (SIEM) (#36768) (#36930)
* iptables/ubiquiti
* cisco asa
* envoyproxy
2019-05-23 20:13:46 +02:00
Tudor Golubenco
150b8ef389
[7.2] [SIEM] Update links (#36754) (#36935)
* [SIEM] Update links (#36754)

* Documentation URL
* Forums URL
* Replaced blogs and videos with a single link to the product page, for now

* Fix translation
2019-05-23 20:12:49 +02:00
Andrew Cholakian
a6a39f834c
[Uptime] Fix accidentally introduced double URL column (#36844) (#36997)
This came with a merge conflict by mistake
2019-05-23 12:57:07 -05:00
Alexey Antonov
ea7faad921
[TSVB] Gauge/Top N/Metric panels show wrong data (#36502) (#36969)
Fix: #36501
2019-05-23 20:36:54 +03:00
Alexey Antonov
4f7fc12f6b
TSVB wrong default date field on default index-pattern (#36519) (#36981)
Fix: #36264
2019-05-23 20:36:13 +03:00