Pengcheng Xu
41cd02c806
Correctly compute and render java langserver downloading url ( #37460 ) ( #37604 )
2019-05-31 13:51:58 +08:00
Mengwei Ding
c594a21a37
[Code] fix repository item tab issue ( #37579 ) ( #37599 )
2019-05-30 22:31:13 -07:00
Nick Peihl
db84dee455
Skip tilemap zoom warning functional test on cloud ( #37570 ) ( #37586 )
2019-05-30 22:11:08 -07:00
Fuyao Zhao
ebd900251a
[Code] suppress error log if language server is not installed ( #37541 ) ( #37551 )
2019-05-30 21:03:13 -07:00
Xavier Mouligneau
b80e0eceb2
[SIEM] Fix duplicate in the droppable filter in the timeline ( #37537 ) ( #37593 )
...
* Fix duplicate in the droppable filter in the timeline
* able to query empty string and null value in the timeline
2019-05-30 23:24:10 -04:00
Yulong
400d661b92
[Code] refactor launcher code, add unit tests ( #36863 ) ( #37591 )
2019-05-31 11:07:16 +08:00
Catherine Liu
fe7aa09898
[Canvas] Fixes i18n errors ( #37565 ) ( #37590 )
...
* Fixed i18n errors
* Added canvas path to .i18nrc.json
2019-05-30 19:11:59 -07:00
Xavier Mouligneau
5581ca05db
fix type of pinned event saved object, it can be null if you do not have x-pack security ( #37515 ) ( #37561 )
2019-05-30 19:13:06 -04:00
Clint Andrew Hall
3459279749
[Canvas] Fix errant type in location Function ( #37302 ) ( #37543 )
2019-05-30 17:30:08 -05:00
Robert Monfera
54ec8b7685
[Canvas] Don't render error triangle on group created by cloning a page ( #37497 ) ( #37567 )
...
* Dispatch on node id convention as we don't carry around the node type information
* place groups previously misplaced into its proper array
* don't render (always invisible) groups, which are free of own contents
2019-05-31 00:11:08 +02:00
Frank Hassanabad
fcdea6a416
[SIEM] Add missing i18n keys ( #37400 ) ( #37549 )
...
* Added missing i18n keys
* Added linter rule to catch mistakes
* Updated code and tests and other areas to work with new linter rule
* Changed linter rule to be an error now
* Fixed other i18n keys
* Added spacer and removed the that the linter did not like
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-05-30 16:08:39 -06:00
Justin Kambic
08555cc6e3
Add a function to the time picker page object to set a commonly-used timespan option. ( #37374 ) ( #37504 )
2019-05-30 18:01:56 -04:00
Jen Huang
4c72c7c93c
[SR] Add callout for managed repository and prevent deletion from UI ( #36947 ) ( #37536 )
...
* Check repository plugins using callWithInternalUser instead
* Add information about whether repository is managed (by Cloud)
* Adjust warning copy, add warning Save button styling, and remove button tooltips
* Add same tooltip to trash can icon
* Fix prop
2019-05-30 14:49:57 -07:00
Lisa Cawley
a93057262f
[DOCS] Disable Metricbeat system module ( #37198 )
2019-05-30 12:53:55 -07:00
Søren Louv-Jansen
2215c019a3
[APM] Fix issue with missing agentName on metrics page ( #37210 ) ( #37501 )
2019-05-30 18:31:21 +02:00
Nathan Reese
a30dc7dae2
[Maps] updated scaled property values when there are no results ( #37121 ) ( #37474 )
2019-05-30 07:33:39 -06:00
Xavier Mouligneau
932b84cb7e
[SIEM] Escape Query Bug ( #37390 ) ( #37445 )
...
* Fix Escape query bug on timeline query
* just realized with andrewG that updateColumns action is not called as before and also some attribute is not saved anymore in the columns attributes
* cleanup
2019-05-30 06:36:41 -04:00
WangQianliang
04b6edc317
fix(code/frontend): repo not exists error page ( #36093 ) ( #37463 )
...
fix(code/frontend): repo not exists error page
2019-05-30 16:41:22 +08:00
Spencer
bcf419fb7c
[7.2] Pin dependencies ( #37404 ) ( #37452 )
...
* Pin dependencies (#37404 )
* Pin dependencies
* [eslint] ignore large files that take a long time to parse
* [eslint-plugin-import] force `querystring` to be considered a core module
* [eslint-plugin-import] auto-fix import order issues
* Pin dependencies (#37454 )
(cherry picked from commit b2340d5cae
2019-05-30 00:04:34 -07:00
Mengwei Ding
097bf8596e
[Code] Improve git url parsing for github repo url with branches/refs ( #37397 ) ( #37427 )
2019-05-29 22:18:24 -07:00
Mengwei Ding
b533ab9298
[Code] Make file and repository typeahead query case insensitive ( #37399 ) ( #37429 )
2019-05-29 22:17:05 -07:00
Spencer
0a3d209b13
set branch in package.json to 7.2 ( #37446 )
...
* set branch in package.json to 7.2
* upgrade elasticsearch.js
2019-05-29 20:48:26 -07:00
Fuyao Zhao
f895bcab3d
[Code] add util scripts to run tests/checks ( #37365 ) ( #37425 )
2019-05-29 19:06:57 -07:00
Nathan Reese
347abe8abc
[Maps] only sync layer list state to mapbox once ( #37133 ) ( #37440 )
...
* [Maps] only sync layer list state to mapbox once
* clean up getDerivedStateFromProps logic
2019-05-29 19:34:05 -06:00
Frank Hassanabad
57918d5b2d
[SIEM] Fixed timeline Epoch for zeek to not render in Epoch ( #37290 ) ( #37432 )
...
## Summary
* Added a few functions to test for Epoch and correct things where they can
* Added unit tests where there were none
* Added unit test that exercises the failure (TDD)
* Fixed the unit test and ensured the other unit tests still run
* https://github.com/elastic/ingest-dev/issues/280
Before fix:
<img width="1272" alt="broken" src="https://user-images.githubusercontent.com/1151048/58518929-89375000-816e-11e9-858b-21daefc8b19c.png ">
After fix:
<img width="1091" alt="Screen Shot 2019-05-28 at 5 29 09 PM" src="https://user-images.githubusercontent.com/1151048/58518937-8d636d80-816e-11e9-9ba8-dfd3fd054416.png ">
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-05-29 18:45:49 -06:00
Joe Fleming
fdf128e10e
[7.2] Fix: ensure filter group always shows up in the sidebar ( #37419 ) ( #37435 )
...
* fix: ensure filter group always shows up in the sidebar
fixes #36950
* fix: verify argValue exists before adding to the choices list
Co-Authored-By: Catherine Liu <catherineqliu@outlook.com>
2019-05-29 16:28:44 -07:00
Fuyao Zhao
57591310d5
[Code] change suggested clone url ( #37354 ) ( #37410 )
2019-05-29 16:06:49 -07:00
Joe Fleming
7253136e08
[7.2] Fix: handle null argument values ( #37411 ) ( #37416 )
...
typeof null === 'object', so add an explicit check for null
2019-05-29 14:53:52 -07:00
Chris Koehnke
9c80725d98
Remove directory from dockerfiles target ( #37258 ) ( #37372 )
...
* Remove directory from dockerfiles target
Produce a docker build context tarball without a top-level directory to
match the expected format for downstream automation.
This will produce:
```
$ tar -tzf target/kibana-8.0.0-docker-build-context.tar.gz
Dockerfile
bin/
config/
bin/kibana-docker
config/kibana.yml
```
Instead of:
```
$ tar -tzf target/kibana-8.0.0-docker-build-context.tar.gz
kibana-8.0.0-docker-build-context/Dockerfile
kibana-8.0.0-docker-build-context/bin/
kibana-8.0.0-docker-build-context/config/
kibana-8.0.0-docker-build-context/bin/kibana-docker
kibana-8.0.0-docker-build-context/config/kibana.yml
```
* Use options object for root directory config
2019-05-29 22:33:43 +01:00
Michael Marcialis
9be76abb62
[7.2] [SIEM] Update Empty Page Messages ( #37251 ) ( #37384 )
...
* [SIEM] Update Empty Page Messages (#37251 )
* update EmptyPage comp and text on all pages
* change proptype from `string` to `IconType`
* update tests and snapshots
* remove translation imports
* restore `align-self` styles for IE11 centering
* proper apostrophe and string in single quotes, per frank
* update host and ip details
* DRYing up host and network empty page message
* fix localization
* fixing localization again
* fix localizations again again
2019-05-29 17:03:25 -04:00
Xavier Mouligneau
49f9edc11a
[SIEM] fix data provider query when the field is a timestamp ( #37281 ) ( #37364 )
...
* fix dataprovider query when the filed is a timestamp
* review II
* review III
2019-05-29 15:41:22 -04:00
Spencer
ca3c566846
[7.2] [checks-reporter] reenable ( #37280 ) ( #37357 )
2019-05-29 11:53:41 -07:00
Joe Fleming
fd938ee766
[7.2] [Canvas] Fixes Workpad prop typo ( #37351 ) ( #37353 )
2019-05-29 09:42:31 -07:00
Ahmad Bamieh
782ed5c7e8
[Docs] i18n docs add japanese ( #37233 ) ( #37329 )
2019-05-29 19:01:53 +03:00
Ahmad Bamieh
7494d66320
[i18n] Updated japanese translations ( #37333 )
...
* integrate translations
* run i18n_check
2019-05-29 19:01:46 +03:00
Matthias Wilhelm
4d69339d0e
Remove duplicate fields of rollup based index patterns ( #37221 ) ( #37308 )
...
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by #28762
2019-05-29 13:14:45 +02:00
Dmitry Lemeshko
bbbb33fc27
[visualize/_shared_item] skip test due to #37130 ( #37131 ) ( #37279 )
2019-05-29 11:45:46 +02:00
chongzhe
1f8bc11512
[Code] change Typescript to TypeScript in UI ( #37270 ) ( #37298 )
2019-05-28 23:58:29 -07:00
Ioannis Kakavas
8234b566bc
Adjust validation for OIDC endpoint ( #37304 )
...
This change adjusts validation of query parameters in the
/api/security/v1/oidc endpoint. It was discovered during manual
testing that Google's OP is sending extra parameters than the ones
identified in https://tools.ietf.org/html/rfc6749#section-4.1.2
which is refernced by
https://openid.net/specs/openid-connect-core-1_0.html#AuthResponse
(for instance auth_user and session_state). The existing validation
rules only allowed the expected query parameters but this
means that Kibana wouldn't be able to complete OpenID Connect
authentication with Google acting as the OP.
As dictated in the standard (RFC6749), "The client MUST ignore
unrecognized response parameters." so we should allow but discard
any extra parameters we do not recognize and not throw an error.
Furthermore, it adds stricter validation for the issuer and all
pararameters of type URI when these are present.
2019-05-29 09:30:58 +03:00
Mengwei Ding
5a66d9b225
[Code] Reenable lsp_indexer mocha tests and incooporate language filter test cases ( #37266 ) ( #37296 )
2019-05-28 19:29:15 -07:00
Joe Fleming
11cdfa16fe
[7.2] Fix: Fullscreen sizing on old workpads ( #37289 ) ( #37292 )
...
* fix: provide css value for workpads
old workpads were missing this value, this fixes scaling in fullscreen mode
* fix: make workpadCss a required prop
this will cause warnings in the future if the value is missing. also remove the unused css prop.
2019-05-28 16:52:51 -07:00
Andrew Goldstein
ee5278cace
[SIEM] Fixes timeline notes overflowing the modal ( #37134 ) ( #37245 )
...
Beginning in Chrome 74 (see elastic/eui#1902 ), the timeline notes modal can overflow in some browsers, per the _Before_ gif below.
This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below:
https://github.com/elastic/ingest-dev/issues/442
2019-05-28 16:45:15 -06:00
Xavier Mouligneau
53b47d5d7e
fix persistence of timeline when you pinned or add a note to an event ( #37248 ) ( #37263 )
2019-05-28 17:51:46 -04:00
Joe Fleming
4a2f90fece
[7.2] Feat: Autoplay pages in fullscreen ( #35981 ) ( #37275 )
...
* feat: add autoplay redux boilerplate
WIP auto-play settings
* feat: add page cycle settings
* feat: add cycle toggle hotkey
* chore: add tooltip text to settings icon
* settings layout
* fix: handle invalid input for custom interval
* chore: address nit
2019-05-28 14:30:19 -07:00
Frank Hassanabad
f196aaf261
[SIEM] Fix state issues to avoid potential React update issues ( #37261 ) ( #37273 )
...
Fixed prevState issues with React setState
* This will avoid subtle bugs with the react update renderer
* Enabled one lint rule from warn to error
* Turned off the other linter issue as it has an open ticket against it.
* https://github.com/elastic/ingest-dev/issues/468
Summarize your PR. If it involves visual changes include a screenshot or gif.
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-05-28 15:00:25 -06:00
Melissa Alvarez
28ca9c2557
return false for each jobId if it does not exist ( #37116 ) ( #37243 )
2019-05-28 16:44:52 -04:00
Frank Hassanabad
f26d323caa
[SIEM] Fixed unescaped HTML entity issue ( #37257 ) ( #37265 )
...
* Turned on linter rule to be an error
* Removed the extra character
* https://github.com/elastic/ingest-dev/issues/467
Removes the extra `}` character seen after line 84 below in the screen shot:
<img width="368" alt="Screen Shot 2019-05-28 at 9 39 28 AM" src="https://user-images.githubusercontent.com/1151048/58498271-f4672f00-813a-11e9-8b80-2326db363bb0.png ">
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-05-28 14:39:29 -06:00
Brandon Kobel
ddb14cbdfa
[docs][skip ci] Infrastructure and Logs read only access ( #35566 ) ( #37232 )
...
* Adding a read only access section to the infrastructure docs
* Adjusting where the infrastructure read only access section is and
adding the logs readonly access section
* Fixing grammar
2019-05-28 16:29:25 -04:00
Melissa Alvarez
256b4c21c3
[ML] Prevent overflow of large metric values in data visualizer/file data visualizer cards ( #36932 ) ( #37268 )
...
* filedataviz cards - abbrev long numeric values
* add directive for index dataviz values
* Add arg to indicate format. update tests
* truncate with ellipsis
* use eui ellipsis truncation
* increase card content height
* ensure truncation for firefox and safari
2019-05-28 16:25:46 -04:00
spalger
7da631e095
update yarn.lock file
2019-05-28 10:45:50 -07:00
