WangQianliang
47b545d443
[Code] Fix code explore repository functional test ( #36157 ) ( #38259 )
...
* Revert "Revert "[Code] set loading false if do not need fetch tree (#36083 )""
This reverts commit 6a013cb82e
2019-06-06 16:13:41 -07:00
Nathan Reese
4e500d982c
merge conflicts ( #38316 )
2019-06-06 17:10:20 -06:00
Chris Cowan
0419047178
[Infra UI] Fixes #37999 - Reset error when IP address changes to valid entry ( #38022 ) ( #38318 )
...
* [Infra UI] Fixes #37999 - Reset error when IP address changes to something valid
* movnig the setError above try/catch
2019-06-06 15:32:31 -07:00
Mengwei Ding
8c7c74aed8
[Code] Improve the document search highlights for non-english query ( #38154 ) ( #38189 )
2019-06-06 15:27:58 -07:00
spalger
ef94824a16
[ci] disable firefox tests
...
(cherry picked from commit c655a11ece
2019-06-06 14:29:51 -07:00
Fuyao Zhao
fba1cc91d6
[Code]: remove hard code node heapsize ( #38304 ) ( #38323 )
2019-06-06 14:14:18 -07:00
Steph Milovic
45c6f6e002
[SIEM] Additional Overview Network & Hosts metrics ( #38005 ) ( #38276 )
...
[SIEM] Additional Overview Network & Hosts metrics (#38005 )
2019-06-06 14:21:50 -06:00
Vadim Dalecky
f1c13c9b17
fix: 🐛 stop showing spinner only on error ( #38289 ) ( #38291 )
2019-06-06 13:05:49 -07:00
Justin Kambic
0e82b89564
[Uptime] [Bug] Disable integration links for apps that are not present ( #37284 ) ( #38286 )
...
* Add tests and checks for disabled/enabled integration link.
* Add empty state if all integrations are unavailable.
* Fix broken type.
2019-06-06 15:43:12 -04:00
Justin Kambic
c78e4fc197
Remove deprecated feature from elasticsearch queries. ( #37995 ) ( #38288 )
2019-06-06 15:41:21 -04:00
Fuyao Zhao
cb54ea8bfd
[Code]: unassociate html with typescript langserver ( #38150 ) ( #38174 )
2019-06-06 11:07:50 -07:00
Michael Marcialis
58df103f38
[SIEM] Beta badge on overview page ( #38161 ) ( #38193 )
...
* add beta badge to overview header
* update test
* updates snapshot
2019-06-06 13:21:46 -04:00
Justin Kambic
ee463870ec
Remove "common" options from SDP that have a 0ms difference between end and start time. ( #37395 ) ( #38267 )
2019-06-06 13:07:55 -04:00
Jen Huang
240d9a2067
Fix i18n issues ( #38169 ) ( #38191 )
2019-06-06 10:06:54 -07:00
Oliver Gupte
35afc0d1bd
[APM] Moves the APM index creation from server startup ( #37965 ) ( #38235 )
...
* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.
* [APM] provide more meaninful status codes in the default error handler
2019-06-06 07:35:26 -07:00
WangQianliang
d592f54910
fix(code/frontend): improve regexp that matches the container of a symbol ( #37856 ) ( #38089 )
2019-06-06 22:24:18 +08:00
Wylie Conlon
77dd34b1b2
Fix discover not using an index pattern when 2 are created ( #38053 ) ( #38163 )
2019-06-06 10:00:42 -04:00
Xavier Mouligneau
7d3cf7bc02
fix math ( #38132 ) ( #38252 )
...
* fix math
* add unit test
* review I
2019-06-06 09:41:10 -04:00
Frank Hassanabad
391231b419
[SIEM] Changes out event.severity for message in timeline and fixes sorting bug ( #38158 ) ( #38228 )
...
## Summary
* Change out event.severity for message in timeline
* Fixed critical crash where you should not be able to sort on timeline columns that are not aggregatable
* https://github.com/elastic/ingest-dev/issues/513
* https://github.com/elastic/ingest-dev/issues/496
Error toaster fixes:
<img width="348" alt="Screen Shot 2019-06-05 at 1 59 01 PM" src="https://user-images.githubusercontent.com/1151048/58986428-97065a00-879a-11e9-8ff9-003ac29f6d9e.png ">
What the timeline looks like with severity replaced with message:
<img width="883" alt="Screen Shot 2019-06-05 at 1 55 19 PM" src="https://user-images.githubusercontent.com/1151048/58986459-a71e3980-879a-11e9-8144-f16f055bd53d.png ">
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-06-06 07:26:16 -06:00
Garrett Spong
ad3620eed3
[SIEM] Removing draggability from message field ( #38166 ) ( #38230 )
...
## Summary
Currently, searching the `message` field within Timeline will not function properly, so in effort to prevent the user from searching with it, this PR removes the areas where `message` is draggable, which includes:
* Host Events Table
* Host Details Events Table
* Timeline Renderers
* Timeline Event Details
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
2019-06-06 06:52:36 -06:00
Corey Robertson
46d781e616
Move shimming of workpad CSS to only happen on fetch ( #38117 ) ( #38157 )
2019-06-06 08:13:18 -04:00
Andrew Goldstein
5746d01ae0
## [SIEM] Disables Timeline Provider Mutations While Loading Data ( #38185 ) ( #38232 )
...
## Summary
* Fix: disables dropping a new data provider provider on the timeline, deleting an existing data provider, or choosing an action from the data provider context menu while the timeline is loading data to prevent draggable errors, like the one pictured in the screenshot below:
* Fix: the timeline settings icon appears too close to the `Refresh` button:
### Before (Chrome)
### After (Chrome)
<img width="1679" alt="timeline-gear-after-chrome" src="https://user-images.githubusercontent.com/4459398/58997064-1ce4ce00-87b8-11e9-9ffb-0f412e0018ad.png ">
### After (Firefox)
<img width="1672" alt="timeline-gear-after-firefox" src="https://user-images.githubusercontent.com/4459398/58997113-4f8ec680-87b8-11e9-9b52-dc8a13d51361.png ">
### After (Safari)
<img width="1680" alt="timeline-gear-after-safari" src="https://user-images.githubusercontent.com/4459398/58997169-911f7180-87b8-11e9-8186-0ff31e41ad53.png ">
### After (IE 11)
<img width="1354" alt="timeline-gear-after-ie11" src="https://user-images.githubusercontent.com/4459398/58997306-40f4df00-87b9-11e9-844d-b12c7e16f7cb.png ">
* Fix: the `Open Timeline` modal is showing bulk-delete actions
### Before (Chrome)
### After (Chrome)
<img width="1008" alt="open-timeline-after" src="https://user-images.githubusercontent.com/4459398/58997381-9af5a480-87b9-11e9-9909-2d68bd5ff2c3.png ">
* Fix: action icons on the `Timelines` page and `Open Timelines` modal are not aligned with the counts
### Before (Chrome)
<img width="1552" alt="all-timelines-before" src="https://user-images.githubusercontent.com/4459398/58997554-659d8680-87ba-11e9-868c-d92ad72f44b8.png ">
### After (Chrome)
<img width="1550" alt="all-timelines-after" src="https://user-images.githubusercontent.com/4459398/58997656-d8a6fd00-87ba-11e9-9038-c0ca464f8c4d.png ">
* Fix: Changed the title text of the fields browser from `Select Fields` to `Customize Columns`
### Before (Chrome)
<img width="910" alt="fields-browser-before" src="https://user-images.githubusercontent.com/4459398/58997616-a4334100-87ba-11e9-9cd8-02ed9d265bf2.png ">
### After (Chrome)
<img width="910" alt="fields-browser-after" src="https://user-images.githubusercontent.com/4459398/58997691-fa07e900-87ba-11e9-8cd9-6412d2cef8f0.png ">
https://github.com/elastic/ingest-dev/issues/471
2019-06-06 02:19:59 -06:00
Yulong
e20d5b88ce
[Code] improve setup guide ( #38218 ) ( #38226 )
2019-06-06 16:12:13 +08:00
Clint Andrew Hall
5170349676
Fix formatdate not allowing strings ( #37301 ) ( #37557 )
...
* Fix formatdate not allowing strings
* Addressing Feedback
2019-06-06 00:09:00 -05:00
Yulong
80038e3c8e
[Code] fix another path problem on windows ( #38072 ) ( #38215 )
2019-06-06 12:16:35 +08:00
Jason Rhodes
ff466b5d02
[Logs UI] Fixes date picker grid display bug ( #36646 ) ( #38111 )
...
* Fixes display of date picker and streaming button grid
* Removes unused dependency that somehow slipped through the commit hook linter >.<
* Changes streaming button to empty style to de-emphasize a bit
* Updates streaming message to match standard case
* Updates yarn.lock for new core-js version that auto updated during bootstrap
* Removes unnecessary import
2019-06-05 23:17:40 -04:00
Nick Peihl
87b4d491d3
Fix sample data functional test ( #38184 ) ( #38195 )
2019-06-05 18:21:41 -07:00
Matt Apperson
7170757d49
[7.2] [BeatsCM] Move API to new return format ( #31660 ) ( #38040 )
...
* [BeatsCM] Move API to new return format (#31660 )
* add and assign types
* move error management to the lib vs each route. More DRY and easier to test
* move more endpoints to the new format
* fix result for not-yet-pages beats list
* refine more endpoints
* move more routes to new format
* UI now propperly connected to the API
* uodate tests and documenting testing in readme
# Conflicts:
# x-pack/plugins/beats_management/server/rest_api/beats/configuration.ts
* fix linting errors
2019-06-05 19:38:52 -04:00
Luke Elmers
b5e8e9fae9
Fix broken filtering on metric visualizations. ( #38029 ) ( #38144 )
2019-06-05 16:09:42 -06:00
Fuyao Zhao
4670868247
[Code]: Use more robust way to handle url ( #38060 ) ( #38067 )
2019-06-05 10:49:52 -07:00
Nick Peihl
c94fe45783
Use production EMS manifest ( #38050 ) ( #38122 )
2019-06-05 09:39:44 -07:00
Dmitry Lemeshko
d57546ce67
functional tests/firefox wait for loading after page refresh ( #38082 ) ( #38119 )
2019-06-05 18:36:40 +02:00
Ryan Keairns
f6298c65f7
default shape aspect ratio to false ( #38030 ) ( #38115 )
2019-06-05 11:22:30 -05:00
WangQianliang
d87dbc0755
fix(code/frontend): catch structure generating error in saga ( #37957 ) ( #38085 )
2019-06-05 08:24:05 -07:00
WangQianliang
fddc33105c
fix(code/frontend): should not polling status if import repo not succeed ( #37955 ) ( #38087 )
2019-06-05 08:22:47 -07:00
Mike Côté
ad9145b7b0
Fix URLs from displaying too long in saved objects management UI ( #37987 ) ( #38109 )
...
* Fix URLs from displaying too long
* Add encodeURIComponent
2019-06-05 11:20:41 -04:00
James Gowdy
5f17cd6da3
[ML] Fix for constant polling of deleting job tasks ( #38013 ) ( #38104 )
...
* [ML] Fix for constant polling of deleting job tasks
* fixing comment
2019-06-05 15:39:27 +01:00
Mike Côté
a68d4d31f6
Update import saved objects API docs to use curl examples ( #37997 ) ( #38099 )
...
* Remove copy as curl
* Update import docs to use curl examples
2019-06-05 09:41:07 -04:00
Mike Côté
8157d5b655
Fix export saved objects API docs ( #37991 ) ( #38097 )
2019-06-05 09:40:55 -04:00
Pengcheng Xu
616e0f2004
[Code] fix url and encoding for java langserver on Windows ( #38064 ) ( #38070 )
2019-06-05 15:50:57 +08:00
James Gowdy
50b73f5e34
[ML] Fixing data frame permission redirect ( #37867 ) ( #37893 )
2019-06-05 08:37:02 +01:00
Mengwei Ding
38cc629ad4
[Code] use empty placeholder when search filters returns empty results ( #38006 ) ( #38056 )
2019-06-04 18:26:28 -07:00
Garrett Spong
3b150af756
[7.2] [SIEM] Fix bytes formatting ( #37545 ) ( #37701 )
...
* [SIEM] Fix bytes formatting (#37545 )
## Summary
This PR is for https://github.com/elastic/ingest-dev/issues/326 , and fixes how bytes are formatted across the app to be consistent with what is configured in Kibana Advanced Settings
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
### Fix Includes:
#### Network Top Talkers Table:
#### Network Top DNS Table:
#### IP Details Domains Table:
#### Timeline Netflow Renderer:
* Backporting update of enzyme-adapter-react-16 devDependency to fix failing tests
2019-06-04 18:35:00 -06:00
Michael Marcialis
bc5d6e59b4
[SIEM] Host Details Page Updates ( #37769 ) ( #38028 )
...
* toggle to exclude host ID links on host details pg
* first attempt at hiding host column
* switch to conditionally splicing array of columns
* exclude dest from auth table on host details pg
* minor overview style touchups
* rm some extranous EuiFlexGroup; more need removal
* snapshots update
* Revert "snapshots update"
This reverts commit bdd6b8e316#503
* simplify if condition, per steph
* update tests, per steph
* simplify `hostIdRenderer` per xavier
* update snapshots
* fix/improve unit tests, per xavier
* Revert "update snapshots"
This reverts commit dc0f79606b
2019-06-04 20:02:35 -04:00
Mengwei Ding
1c342e3ad6
[Code] Filter out binary files for indexer ( #37945 ) ( #38049 )
2019-06-04 16:45:44 -07:00
Mengwei Ding
0d334d982e
[Code] update percentage ( #38003 ) ( #38047 )
2019-06-04 16:45:02 -07:00
Brandon Kobel
990657c72b
Fixing isMigrated bug, when migrations failed we incorrectly ignored it. ( #37674 ) ( #38042 )
...
Prior to this change, when migrations failed (for example when a
.kibana_1 index already exists and no alias does) the awaitMigration
promise would resolve incorrectly. This allowed subsequent plugins,
including Spaces, to proceed using the SavedObjectsClient/Repository
to create documents. This commonly caused a .kibana index to be created,
which would then block the creation of a .kibana alias, and everything
would grind to a halt.
2019-06-04 16:12:24 -07:00
Frank Hassanabad
5841467b6e
[SIEM] Authentication fixes for winlogbeat and ordering ( #37718 ) ( #38026 )
...
## Summary
* Enabled winlogbeat to work with workaround for authentication_failed (until that is fixed)
* Fixed ordering to be successes first, failures second
* https://github.com/elastic/ingest-dev/issues/491
* https://github.com/elastic/ingest-dev/issues/469
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2019-06-04 16:50:05 -06:00
Catherine Liu
0d19314d4e
[Canvas] Fixes broken elements in web logs sample data workpad ( #37931 ) ( #38035 )
...
* Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element
* Removed return characters at the beginning of expressions
2019-06-04 15:09:11 -07:00
Fuyao Zhao
c4c439ab35
[Code]: add ui.enabled flag and fix uneccessary usage of enabled flag ( #38018 ) ( #38032 )
2019-06-04 14:52:08 -07:00
