Commit graph

212 commits

Author SHA1 Message Date
Aaron Caldwell
94c4c86d0b
Fix map embeddable test (#34648) (#35609)
* Remove skip for testing on server. Unable to repro locally

* run kibana-ciGroup2 40 times per build

* Temporarily skip 'geo map' check

* Left out 'Rendering Test: ' in filter string

* Revert "run kibana-ciGroup2 40 times per build"

This reverts commit 103a5c9c6e.

* Review feedback. Remove 'Flaky' test ref
2019-04-25 12:51:31 -06:00
Vitali Haradkou
618d48b142
Ftr tsfy webelement wrapper (#35355) (#35484)
* tsfy webelement wrapper
2019-04-23 20:00:12 +03:00
Vitali Haradkou
20f8839056
[FTR] tsfy TestSubject (#35412) (#35455)
* migrate test_subjects service to typescript
2019-04-23 13:58:24 +03:00
Vitali Haradkou
43c9213fa3
[FTR] tsfy find & webdriver (#33494) (#35277)
* migrated find and browser services to typescript
2019-04-18 11:24:22 +03:00
Dmitry Lemeshko
6a9b9d41e2
update functional tests to support Firefox (#34635) (#35205) 2019-04-17 15:25:20 +02:00
Dmitry Lemeshko
9cfe1ee839
[7.x] bump chromedriver to 2.46.0 (#27302) (#35009)
* bump chromedriver to 2.46.0 (#27302)

* bump chromedriver up to 2.46.0

* print chromedriver version

* [services/web_element_wrapper] use js to clear input field

* add clearValueWithKeyboard

* fix clearing datePattern input

* fix scripted fileds preview tests

* [tests/infra] fix input clearing (#35028)
2019-04-13 12:51:32 +02:00
Vitali Haradkou
5ed3f9ff70
Revert [TSVB] markdown variables (#33324) (#34788) 2019-04-10 12:00:10 +03:00
Dmitry Lemeshko
d715511708
Functional tests: improve waiting in combobox service (#34707) (#34730)
* [services/lib/web_element_wrapper] set custom wait for findAll

* [services/remote] print browser name and version on init

* [services/combo_box] fix return statement

* fix lint error
2019-04-08 20:50:15 +02:00
dave.snider@gmail.com
c1bfe0ad13
Upgrade EUI to 9.8.0 (#34486) (#34504)
* upgrade eui to 9.8.0

* test selector updates
2019-04-03 18:35:01 -07:00
Nathan Reese
057251f6f9
merge conflicts (#34058) 2019-03-28 07:45:27 -06:00
Maryia Lapata
1e56476510
[Vis: Default editor] EUIficate agg-select (#31892) (#34049)
* EUIficate agg-select

* Improve validation; update TS

* Apply styles for helpLink

* Fix unit test

* Update functional tests

* Adjust comboBox service to chose the item where the text mates exactly

* Update vis page object

* Add default value for agg

* Move aggs grouping function to a separate file

* Use labelAppend prop for help link node

* Add watcher for aggType to manage to discard changes

* Add default value for agg type title

* Fix defining selected option when aggType is defined

* Fix validation issues

* Remove a bootstrap specific class

* Change css selector in test

* Update according to SASS guidelines

* Update functinal comboBox service

* Added check for undefined

* Add jsdoc for groupAggregationsBy function

* Add unit tests for groupAggregationsBy

* Move setValidity invocation to DefaultEditorAggSelect component

* Wrap setValidity into useEffect due to react warning when select is cleaned at the first time

* Move help link definition to select component
2019-03-28 15:43:14 +03:00
Vitali Haradkou
c1972bef15
[TSVB] markdown variables (#33324) (#33930)
* improve test coverage for TSVB markdown
* add new tests for change label, variable and rendering markdown table
2019-03-27 16:25:08 +03:00
Dmitry Lemeshko
0caf154568
FTR: fix 10 sec timeout in waitForDeleted (#33313) (#33894)
* use css selector instead of className, set implicit wait to 0

* set implicitWait to 2 sec

* set default implicitWait to WAIT_FOR_EXISTS_TIME

* set timeout to 1 sec, retry for query bar test

* sleep 5 sec waiting zoom is finished

* sleep is the only way to wait

* run x-pack-ciGroup3 20x times

* Revert "run x-pack-ciGroup3 20x times"

This reverts commit 55482de330.
2019-03-27 09:50:11 +01:00
Spencer
883ea31bd2
[@kbn/expect] "fork" expect.js into repo (#33761) (#33794)
* [@kbn/expect] "fork" expect.js into repo

* [eslint] autofix references to expect.js

* [tslint] autofix all expect.js imports

* now that expect.js is in strict mode, avoid reassigning fn.length
2019-03-25 13:13:21 -07:00
Spencer
f09e17e76c
[7.x] [eslint] merge custom rules into a single plugin (#33733) (#33758)
Backports the following commits to 7.x:
 - [eslint] merge custom rules into a single plugin  (#33733)
2019-03-22 18:53:45 -07:00
Peter Pisljar
a0a1b594c6
adding runPipeline tests (#27015) (#33637) 2019-03-21 08:36:39 +01:00
Dmitry Lemeshko
a4ed1c442c
Dashboard embeddable rendering tests: return names of failed visualisations (#32646) (#33488) 2019-03-19 11:52:01 +01:00
Caroline Horn
5f8e0fc800
Updates to K7 nav drawer and EUI to 9.4.0 (#32864) (#33260) 2019-03-14 14:53:06 -04:00
Tim Roes
358ab0da83
Use embeddable registry in add panel (#31400) (#32885)
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
2019-03-11 14:29:49 +01:00
Jason Rhodes
a1f8dcd900
Upgrades EUI to 9.x (#32009) (#32642)
* Fixed a simple argument bug and removed infra date picker EUI types

* Fixes for EUI date picker types

* eui_8.0.0

* fix type errors in query_bar

* Small changes for EUI types

* Updates EUI to 9.0.0 and removes @types/react-datepicker as it now ships with EUI

* Updates to EUI 9.0.1 and removes duplicate types in infra eui.d.ts

* ts-ignore applied to ongoing type error with styled components and EUI

* Changes EuiProgress props to avoid TS errors

* Updates EUI 9.0 snapshots

* Updates kibana root snapshots for EUI 9.0 upgrade

* Update detail_panel.test.js for EUI changes

* Updated functioanl and unit tests to properly inspect EuiTableRowCell rendered values

* Fix docs_level_security_roles.js func tests

* Update EUI to 9.0.2

* Fixed failing snapshot for EUI icon default prop
2019-03-07 13:17:48 -05:00
Spencer
71b1b60f70
[7.x] Typescript-ify FTR Remote (#32447) (#32564)
Backports the following commits to 7.x:
 - Typescript-ify FTR Remote  (#32447)
2019-03-06 09:02:52 -08:00
Dmitry Lemeshko
34123b08fa
Restore webdriver-based functional test runner driver (#31446) (#32554) 2019-03-06 16:37:19 +01:00
Nathan Reese
91dbe3eef9
merge conflicts (#32334) 2019-03-02 06:28:07 -07:00
Spencer
23d37cf7d9
[7.x] [eslint] require final newline (#32265) (#32268)
Backports the following commits to 7.x:
 - [eslint] require final newline  (#32265)
2019-02-28 19:10:43 -08:00
Spencer
ba82d027cd
[ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files (#31948) (#32250)
In https://github.com/elastic/kibana/pull/31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from https://github.com/elastic/kibana/pull/30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.
2019-02-28 14:26:32 -08:00
Nathan Reese
4f88cb4111
fix flaky input controls functional test (#31970) (#32010) 2019-02-26 06:58:53 -07:00
Spencer
90e6425f12
[7.x] [ftr/services/pipelineList] reduce calls to the browser to avoid flakiness (#31366) (#31372)
Backports the following commits to 7.x:
 - [ftr/services/pipelineList] reduce calls to the browser to avoid flakiness  (#31366)
2019-02-17 23:11:36 -08:00
Spencer
667109a86e
[ftr/elementWrapper] add findTestSubject/findTestSubjects helpers (#31364) (#31387) 2019-02-17 20:16:32 -08:00
Dmitry Lemeshko
f83d1815a0
use cheerio to parse table innerHtml in functional tests (#30640) (#31001)
* use cheerio to parse table innerHtml in functional tests

* rename function to parseDomContent

* test Bar charts by parsing Dom

* test X & Y axis data by parsing Dom

* get X Axis data for dashboard tests with Dom parsing
2019-02-13 22:42:04 +01:00
Stacey Gammon
2964c33090
extend timeouts to enable testing slow internet connections (#30862) (#30954) 2019-02-13 11:34:23 -05:00
Stacey Gammon
fa7dbe0372 [7.x] Stabilize dashboard render and filtering tests (#30419) (#30900)
Backports the following commits to 7.x:
 - Stabilize dashboard render and filtering tests   (#30419)
2019-02-12 16:52:53 -08:00
Nathan Reese
6ad036b187
Replace angular timepicker with EuiSuperDatePicker (#29204)
* replace kbnTimepicker directive with EuiSuperDatePicker

* remove kbnTimepicker directive

* remove bootstrap datepicker

* Embed timepicker in query bar (#29130)

* replace kbnTimepicker directive with EuiSuperDatePicker

* remove kbnTimepicker directive

* remove bootstrap datepicker

* embed timepicker in query bar

* flesh out date picker in query bar for maps app

* wire up refresh config

* fix bug with way update function called by watcher

* get maps application functional tests working with new timepicker

* update setAbsoluteRange for EuiSuperDatePicker

* replace setQuickTime with calls to setAbsoluteTime

* remove open time picker button in discover empty results view

* pass config values to super-date-picker directive

* remove getPrettyDuration

* clean up typescript lint problems

* some functional test fixes

* try something else to fix I18n problems

* fix some more functional tests

* update query_bar jest test

* remove unused method in kbn_global_timepicker

* do not import removed timepicker styles

* remove mode from time state

* remove mode from time_history interface

* fix problem with ui_settings_defaults

* fix failing TSVB functional test

* another round to test fixes

* more functional test changes

* fixes for failing tests

* add retry block to flaky tsvb test

* styles/bootstrap_dark.less

* fix functional tests

* call fetch event even when times are the same

* add retry around flaky tsvb test

* fix timefilter jest test, attempt to fix another flaky functional test

* revert emitting fetch outside of areTimePickerValsDifferent check

* clean up time mode code that is no longer needed in dashboard

* fix timefilter tests changed by timefilter emit revert
2019-02-05 20:45:31 -07:00
Nathan Reese
908b387236
[Maps] add saved objects for all sample data sets (#28797)
* [Maps] add saved objects for all sample data sets

* add functional tests that compare sample data maps to baseline images

* add check for layer loading in functional tests

* try something out in CI

* try map without EMS regions

* add weblogs test but hide region layer

* skip tests with EMS vector layers

* gis-map to map and ES_GEOHASH_GRID to ES_GEO_GRID

* add resolution property to ES_GEO_GRID source descriptor

* move alphaValue from style descriptor to layer descriptor and rename to alpha

* terms join label change 'group by' to 'of'

* ensure sample data sets work with no internet access

* get functional tests working with updated full screen snapshots

* delete gis folder left overs

* give time for visibility to toggle to fire

* make web logs screen comparision more forgiving

* wait for layers to load on full screen
2019-02-04 20:18:11 -07:00
Matt Bargar
8a83955650
Re-introduce new filter bar (#29752)
Fixes the build issues introduced in #25563 and re-introduces the new react/eui/typescript filter bar, essentially reverting the revert in #29662. I did have to resolve one merge conflict in query_bar.tsx, and re-deleted all of the old filter bar code where translation code had been added.
2019-01-31 18:36:26 -05:00
Ryan Keairns
bbc68b0000
[7.0] Adds new K7 side navigation (#28940)
* initial commit of K7 side nav

* [ui/persistedLog/recentlyAccessed] support observing history items

* [globalNav] use real recentlyAccessed and navLink data

* fixes header logo and mobile layout

* handle hidden links and no recents, use size vars

* handle hidden links and no recents, use size vars

* adds prop to wrap flyout link text

* fix menu scroll for IE

* [chrome/headerGlobalNav] fix typescript issues

* [chrome/headerGlobalNav] only ignore types that are actually missing

* update EUI to 6.6.0

* Revert "update EUI to 6.6.0"

This reverts commit 048cbf9157f8fc7410d4cf8e017b210c4548104e.

* [chrome] remove HeaderAppMenu component

* [ftr/services/appsMemnu] update for new style

* [ftr/discover] tweak size of discover tests and size-dependent assertions

* [chrome] disable offsets in embed mode

* [ftr/discover] try sticking with original screen width

* [ftr/discover] try to force screensize before checking axis labels

* [ftr/services/appMenu] ensure menu closed after clicking app

* uptime app icon, mobile header size removed

* [ftr/discover] make assertion resilient to minor changes in vis width

* [chrome] add types for nav apis

* [chrome/recentlyAccessed] display app icons when possible

* [ftr/discover] make a little wider so scroll doesn't interfer with vis width

* [ftr/services/globalNav] fix test subject
2019-01-31 10:13:40 -06:00
Matt Bargar
45b24afe83
Revert "Migrate filter bar to React, EUI, and Typescript (#25563)" (#29662)
This reverts commit 410c094547.
2019-01-30 17:00:42 -05:00
Matt Bargar
410c094547
Migrate filter bar to React, EUI, and Typescript (#25563)
Rewrites the filter bar in React, EUI, and Typescript. Updates the look and feel of the filter bar and makes it consistent with the rest of K7.
2019-01-30 15:48:31 -05:00
Dmitry Lemeshko
5b67941b5f
page_objects updates prior webDriver migration (#28941)
* page_objects updates prior webDriver migration

* [services/test_subjects] set default find timeout to timeouts.find

* remove redundant waitUntilLoadingHasFinished
2019-01-23 09:40:57 +01:00
Spencer
61ca36f15d
Switch to K7 design by default (#29009)
* [visualize] update breadcrumbs when updating visualization

* [ftr] auto-scroll elements passed the fixed header if necessary

* [uiSettings] enable the k7design by default

* [ftr/services/flyout] add ensureClosed() and ensureAllClosed()

* [ftr/services/globalNav] implement globalNav service

* [ftr/services/appsMenu] implement service for using app menu

* [ftr/services/userMenu] add service for using user menu

* [ftr/discover+visualize] update assertions that are based on the app width

* [ftr/monitoring] pass test subjects to new breadcrumbs

* [headerGlobalNav] don't offset the app container in embed mode

* update heights for slightly smaller header
2019-01-18 12:39:01 -08:00
Spencer
4d40ddff7a
Implement config for disabling welcome screen (#28888)
As suggested by @legrego in #28792, this PR adds a config flag to completely disable the welcome screen, which is enabled by the functional test runner to ensure that the welcome screen doesn't pop up.
2019-01-17 12:13:13 -08:00
Spencer
e355ec47aa
[ftr/element] custom scrollIntoView to support fixed header (#28727)
With https://github.com/elastic/kibana/pull/28503 we will be enabling the k7design by default, which adds a fixed header to the top of the page. This causes issues with the default "scroll into view" logic, as elements which are in the top overflow will be scrolled into view but then covered by the header.

My first attempt to solve this was adjusting the layout to only scroll the content below the header. This allowed the [standard scroll into view algorithm](https://drafts.csswg.org/cssom-view/#element-scrolling-members) to function as intended, but had a slightly worse UX on OSes like macOS, and @elastic/kibana-design ultimately pushed back because not allowing the body to scroll has other implications.

Instead I have implemented a `LeadfootElementWrapper#scrollIntoViewIfNecessary()` method which is automatically called before each `#click()` and `#moveMouseTo()` call. This new method scrolls the element into view when necessary, and then additionally adjusts the scroll position of the root scroll element by the necessary pixels if the top of the element is within `layout.fixedHeaderHeight` pixels.
2019-01-16 12:37:40 -08:00
Spencer
3bea7a31d5
[pageObjects/welcome] automatically disable on navigation (#28792)
* [pageObjects/welcome] automatically disable on navigation

* [pageObjects/welcome] disable on beforeTests to not slow down navigation

* [ftr/services/welcome] also disable welcome after logout

* [ftr/services/welcome] revist home after disabling welcome
2019-01-16 09:45:28 -08:00
Stacey Gammon
1078782106
Refactor, clean up, new inspector, pie chart services (#28509)
* Refactor, clean up, new inspector, pie chart services

* Move inspector service to top level, outside of visualizations folder

* Refactor some more instances of getTableData into expectTableData
2019-01-15 15:05:12 -05:00
Spencer
17c0cbd174
[pageObjects/header] use testSubjects.existOrFail (#28632)
* [ftr/services] convert exists() timeout arg to options object

* [ftr/testSubjects] add allowHidden option to exists() fns

* [pageObjects/header] use existsOfFail for globalLoadingIndicatorHidden
2019-01-14 12:19:40 -08:00
Spencer
bd39abffea
[ftr/services] move WAIT_FOR_EXISTS_TIME into config (#28630) 2019-01-14 10:07:00 -08:00
Dmitry Lemeshko
8357fccb47
wrap leadfoot/keys in browser, pressKeys on elementWrapper (#27720) 2019-01-14 17:15:03 +01:00
Brandon Kobel
1861be716a
Awaiting element.isEnabled for staleness checks (#28106)
The functional test runner's find service wasn't awaiting the promises
returned by element.isEnabled which was causing some of the staleness
checks to not succeed and potentially crash the process if it was the
very last test to be run.
2019-01-07 13:04:33 -08:00
Stacey Gammon
fd28ce3eae
Stabilize flaky visualize test (#27470)
* Stabilize flaky visualize test

- don’t wait for header unnecessarily.  - use clickWhenNotDisabled instead of click. - use an outer retry to account for stale elements from pie chart likely not editing render complete correctly

* More fixes

- fix interval selection so it doesn’t accidentally click Go.  - fix legit bug with non existent _source field being used in a test. - Don’t “click Go” when not needed.

* Clean up

- can’t run pie chart tests multiple times in a row.  - remove more unnecessary clickGos
2018-12-20 17:04:15 -05:00
Stacey Gammon
b2576f5a30
Fix dashboard to refresh visualizations when the refresh button is clicked (#27353)
* Fix dashboard to refresh visualizations when the refresh button is clicked

* Suggestions

* Fix tests

* Catch bug with a new test to ensure saved searches update when query in url is modified

* Add a test that would have caught the initial problem

* Final fixes that should get ci passing and the bug fixed

* Move requestReload out of _pushFiltersToState

* Fix comparison
2018-12-18 18:39:20 -05:00
Dmitry Lemeshko
f3be150155 Adjust functional tests / page objects for webdriver API compatibility (#27059)
* [visualise_page] improve searching of bucket element

* [discover_page] wait for visualisation loaded + dragAndDrop

* [services/browser] change dragAndDrop arguments

* fix dragAndDrop usage in dashboard test

* use clickByCssSelector
2018-12-18 15:01:32 -05:00