Commit graph

212 commits

Author SHA1 Message Date
Dmitry Lemeshko
331be3c384
[7.4] FTR: clear browser storage between test suites (#48683) (#49477)
* FTR: clear browser storage between test suites (#48683)

* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data

* remove files
2019-11-07 09:57:53 -05:00
Spencer
9f21652487
[7.4] FTR: fix "DevToolsActivePort file doesn't exist" error o… (#49835) 2019-10-31 08:52:00 -07:00
Spencer
a96d582aea
[7.4] standardize notice-comment usage (#48677) (#48816)
* standardize notice-comment usage

* regenerate notice.txt
2019-10-21 15:55:38 -07:00
Dmitry Lemeshko
03fcbe1ab8
Fix several recently failed functional tests (#47976) (#48105)
* small tweaks to make tests more stable

* fix empty list check, update more tests

* fix
2019-10-14 17:48:33 +02:00
Dmitry Lemeshko
b5654b4660
[services/remote] print Firefox console logs in stdout (#46700) (#47532)
* [services/remote] print Firefox console logs in stdout

* [ftr/firefox] setup a socket for firefox to write stdout to

* remove unused imports

* unsubscribe from polling logs on cleanup

* tear down more completely on cleanup
2019-10-08 09:00:39 +02:00
Dmitry Lemeshko
7e253b58a2
[functional/services] update webdriver lib and types (#47381) (#47446)
* [functional/services] refactor using new types

* [code/history] wrap forward navigation with browser service
2019-10-07 13:28:24 +02:00
Robert Oskamp
8019844732
[ML] Fix flaky setValue for some elements (#46693) (#47096)
Use setValue with clearing via keyboard
2019-10-02 15:33:15 +02:00
Dmitry Lemeshko
c4bace0f33
Fix tsvb chart test (#44657) (#46860)
* enable switch index patterns test

* run ciGroup6 20x times

* [page_objects/visual_builder_page] retry selecting index pattern

* Revert "run ciGroup6 20x times"

This reverts commit 2151ea9905.

* [services/combo_box] clear input in seperate function

* run ciGroup12 30x times

* update logging message

* Revert "run ciGroup12 30x times"

This reverts commit 08fac11139.
2019-09-28 09:06:01 +03:00
Spencer
a0fe3e1efc
[7.4] Fix disappearing screenshots in CI (#46382) (#46663) 2019-09-26 07:31:32 -07:00
Spencer
5cc48622af
[7.4] Update angular+jquery related packages (#46393) (#46633)
* Update angular related packages

* upgrade jQuery too

* don't delete screenshots in pipeline jobs

* use ng-change so that listener is triggered after ng-model is updated

* match @types/angular versions

* update yarn.lock

* fix test

$routeChangeSuccess is no longer broadcast when resolving a redirect route, so this test has been adjusted to validate that

# Conflicts:
#	package.json
#	x-pack/package.json
#	yarn.lock
2019-09-25 15:11:58 -07:00
Dmitry Lemeshko
5e1072e452
[test/functional/services] tsfy FailureDebugging, SavedQueryManagementComponent & Snapshots (#45682) (#45866)
* [test/functional/services] tsfy failure_debugging, snapshots, saved_query_management_component

* update renovate config

* fix path in snapshot service
2019-09-17 18:06:15 +02:00
Dmitry Lemeshko
583b568a2e
Change data-test-subj selector logic to support value with spaces (#43682) (#45506)
* update test-subj-selector

* update locators

* adjust whitespaces removal

* fix another locator

* fix ML test locators
2019-09-12 20:25:42 +02:00
Dmitry Lemeshko
cb681edb4c
Functional tests: convert more test/services to TS (#45176) (#45386)
* convert more test/services to TS

* Update test/functional/services/combo_box.ts

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

* Update test/functional/services/combo_box.ts

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

* Update test/functional/services/combo_box.ts

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

* fix lint error
2019-09-11 17:47:26 +02:00
Dmitry Lemeshko
c2aea564b7
FTR: fix WebDriver Actions calls (#44605) (#45000)
* [services/web_element_wrapper] add actions API methods

* fixes

* [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes

* small review changes

* dragAndDrop: add default values for offset
2019-09-06 17:39:49 +02:00
Dmitry Lemeshko
a5a834a3d9
[visualize/_tsvb_time_series] fix flaky test (#44505) (#44971) 2019-09-06 12:56:02 +02:00
Matt Bargar
ba7ceae114
Attempts to make saving of the current query more robust (#44797) (#44837) 2019-09-05 13:55:44 -04:00
Matt Bargar
9d5e1ed5c1
Save query form validation on blur (#43726) (#43827)
This PR changes the save query form to only validate its inputs on blur. Previously we validated on every change. This could lead to the errors flashing in the user's face before they're done typing a valid input. For example, we allow spaces in the name field, but not at the beginning or end of the name. So if a user typed this is a long name with spaces they would see the error pop up every time they type a space, only to have it disappear when they type the next letter.
2019-08-23 16:48:45 -04:00
Matt Bargar
b97a95b109
Implement saved queries and filters (#39140) (#43720)
Introduces "saved queries". Saved queries are a new saved object type similar to saved searches but more limited in scope. They allow users to store the the query string in the query bar and optionally the set of filters and timefilter in order to reload them anywhere a query is expected: Discover, Visualize, Dashboard, anywhere that uses our full SearchBar component.
2019-08-21 18:44:09 -04:00
Vadim Dalecky
a332eaa703
fix: 🐛 pass whole action context to isCompatible() method (#43457) (#43524)
* fix: 🐛 pass whole action context to isCompatible() method

* test: 💍 add function test for saved search filtering in pie

* test: 💍 move save search functional test in its own test suite
2019-08-19 15:43:30 +02:00
Spencer
91b40d2559
[7.x] [ftr/cheerio] improve cheerio types to include test subj… (#42541) 2019-08-02 15:50:17 -07:00
Dmitry Lemeshko
0e315ab053
FTR: fix testSubjects.missingOrFail (#42290) (#42321)
* [services/test_subject] fix missingOrFail

* [services/test_subjects] allowHidden option for missingOrFail

* [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
2019-07-31 11:16:51 +02:00
Daniil Suleiman
73ab20ed80
[Vis: Default editor] EUIficate pie chart options tab (#41901) (#42125)
* EUIficate pie chart options tab

* Fix tests

* Size titles down to xs

* Use FormattedMessage
2019-07-29 14:56:39 +03:00
Dmitry Lemeshko
2b4d037c06
Ftr/tsfy doc table (#41710) (#41952)
* [services/doc_table] tsfy service and use parse dom to get rows

* [services/doc_table] do not pass table element as argument

* [services/doc_table] update service to minimize StaleElementReference cases

* [services/doc_table] add missing access modifier

* [services/doc_table] change getHeaderFields and fix return types
2019-07-25 09:51:33 +02:00
Dmitry Lemeshko
b237a661a4
[service/remote] check env variable value (#41909) (#41950) 2019-07-25 09:29:29 +02:00
Zacqary Adam Xeper
2f31e58ee8
[Logs UI] Make column configurations reorderable (#41035) (#41697)
* [Logs UI] Make column configurations reorderable

* Improve typing aand memoize callback

* Guard against index bounds and rename reorderLogColumns

* Fix useCallback memoization

* Add functional test for reordering log columns

* Use browser.keys instead of Key in functional test
2019-07-23 09:56:51 -05:00
Greg Thompson
657d45df62
Upgrade EUI to 12.4.0 (#41577) (#41691)
* eui 12.4.0

* styled-components ts conflict

* update combobox test service to always open on open call

* Revert "update combobox test service to always open on open call"

This reverts commit 43074e6006.

* scroll combobox into view

* scroll before filter
2019-07-22 14:15:18 -05:00
Liza Katz
c3217640d2
Reactify Top Nav Menu (kbn_top_nav) (#40262) (#41637)
* kbn top nav in discover

* New top nav in dashboard and vis editor

* Stop using template feature of kbn top nav

* Changed console menu to new directive

* Use search bar in top nav in discover and maps
Support search bar with no filter bar (TS)

* Moved storage instantiation to angular directive

* Make index patterns optional (for timepicker only setup)

* Moved discover result count away from top nav

* Removed unused name attribute in top nav. Use app-name instead.
2019-07-21 16:26:50 +03:00
Dmitry Lemeshko
f03f3dd51b
[services/web_element_wrapper] update clearValue function to fix Firefox tests (#41117) (#41189)
* [services/web_element_wrapper] update clearValue function

* fix flaky test #40670
2019-07-16 00:05:33 +02:00
Dmitry Lemeshko
bea3c8b548
FTR: upgrade chromedriver to 75 (#40791) (#41051)
* ftr: update services to support chromedriver 75

* [services/webdriver] add browser logging

* update comment for W3C scrolling bug
2019-07-13 01:02:36 +02:00
Stacey Gammon
458de86dd8
Use embeddable v2 (#39126) (#41042)
* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
2019-07-12 16:28:29 -04:00
Dmitry Lemeshko
c4ec8aa859
WebElementWrapper: Retry WebDriver atomic calls (#40423) (#40982)
* [services/lib/web_element_wrapper] use Generics in replyCall

* [services/lib/web_element_wrapper] remove redundant return types

* [services/lib/web_element_wrapper/] set retryCall timeout to 200 ms

* [services/find] explcitly pass element to have locator===null by default

* use static method to create WebElementWrapper

* missed a couple uses

* move some values to constants

* remove some unnecessary type info
2019-07-12 15:13:23 +02:00
Thomas Neirynck
11d1bab138
[Maps] show dialog to save map when leaving app (#40215) (#40853) 2019-07-11 09:56:01 -04:00
Spencer
1591c25148
[7.x] [ts] upgrade to 3.5.3 (#40228) (#40795)
* [ts] upgrade to 3.5.3 (#40228)

* [ts] upgrade to 3.5.2

* [ts] run from cwd so that relative paths are correct

* move eslint-disable-line comment into jsx attribute

* autofix eslint violations

* avoid generic type, it's not necessary and problematic

* make elasticsearch.cluster optional, many instances don't have them

* remove invalid prop

* expand AllowUnknownProperties to cleanly handle arrays

* esfilter values can sometimes be an array of strings

* allow exception objects to have unknown properties

* define accumulator as a boolean

* fix return type

* return a 404 if beat isn't found after update

* use Object.values for better types

* define return type of get() call

* define value type for Set

* define return value of get()

* define State property type

* use less get(), so ts can infer types

* define Set item type

* map state type

* make default_operator optional, since it's not always defined

* remove seemingly unused prop

* define return type of get() fn

* define inner type for state

* don't define base types are objects with index signatues

* regenerate public api docs

* make indices privileges optional too

* remove unnecessary index-signature from Exception interface

* use variadic _arg instead

* [core/plugin] use Record<string, any> rather than {}

* replace a couple more instances of {}

* revert some unnecessary changes

* remove unused types

* [reporting] output, payload, and meta are required properties

* bump to latest patch version

# Conflicts:
#	x-pack/legacy/plugins/canvas/server/usage/custom_element_collector.ts
#	x-pack/legacy/plugins/canvas/server/usage/workpad_collector.ts

* define inner type for Set

* default `config.get()` to any instead of unknown
2019-07-10 15:22:35 -07:00
Dmitry Lemeshko
4cb5d4de17
[ftr] replace getProperty with getAttribute (#40358) (#40383)
* [ftr] replace getProperty with getAttribute

* fix failing tests

* [services/pipeline_editor] revert change
2019-07-05 09:21:41 +02:00
spalger
f663e18cb8 [7.x] [prettier] upgrade to 1.18.2 (#40229)
* [prettier] upgrade to 1.18.2

* autofix prettier violations

(cherry picked from commit a95ae8c037)
2019-07-03 13:00:44 -07:00
Spencer
cb2fe38d05
[7.x] [ftr/browser] poll for logs and stream them (#40098) (#40154) 2019-07-03 11:06:20 -07:00
Peter Pisljar
5341d11005
updating metricvis interpreter func arguments (#34532) (#39872) 2019-06-28 08:16:09 +02:00
Dmitry Lemeshko
aec6d9e0c9
Update functional tests to run faster and pass locally (#39557) (#39650)
* [shakespeare] adjust verification to pass in both headless/head runs

* [services/visualizations/pie_chart] speedup tests with timeout decrease

* [services/dashboard/expectations] speedup tests with timeout decrease
2019-06-26 10:26:40 +03:00
liza-mae
9ce96bc567
[WIP] FTR Percy changes (#36897) (#38996)
* [ftr/percy] integrate percy with functional test runner

* execute ftr within `percy exec`

* share PERCY_BIN and GRUNT_BIN vars in setup

* [license] whitelist `(Unlicense OR Apache-2.0)`

* [percy] include pr/parallel info in env

* echo the actual variable value

* destructure required modules

* [ci] calculate percy env in a script

* remove outdated eslint overrides

* oops, nonce should be the same for each build

* take snapshots in context tests

* add percy snapshots to some dashboard tests

* account for extra execution of PERCY_BIN

* remove usage of percy service

* rename service to `visualTesting`

* write a simple test

* switch left-over percy test to visualTesting

* set log level for percy agent

* trigger ci

* try using the system chrome install instead of downloading one

* fix export definition

* Don't skip chromium download

* Add Spencer's fix to point to chrome installation

* Attempting to split tests into own ci job and test files

* Renumber job

* Add tag to decorations file

* Try new files with existing CI job

* Try again to create a new CI job

* Fix eslint problem with space

* eslint updates

* fix console test

* make test names unique

* Update ci group names

* Try old name again

* save

* add separate visual_regression ci job

* add visual regression ci job

* add new job to jobs.yml

* update path to take_percy_snapshot script

* use fixed percy job total

* fix common services import

* move visual_create_and_add_embeddables to visual_regression project

* finish moving create_and_add_embeddables

* add x-pack visual regression job

* migrate dashboard_snapshots tests to visual_regression

* remove references to removed test files

* restore some unnecessary changes

* reimplement the login page tests

* yarn.lock update

* fix test

* remove old CI_GROUP 100 block

* update failed_tests trap

* reduce yarn.lock changes

* disable debug logging

* disable visual-regression tests for now, we can enable them in specific prs
2019-06-14 12:16:48 -06:00
Josh Dover
5c4e18778f
[7.x] Add addError function to toastNotifications (#32187) (#37739) 2019-06-03 17:06:47 -05:00
Spencer
7aea62aa61
[7.x] FTR: add support for Firefox browser (#32509) (#37750)
* skip and adjust functional tests for Firefox

* downgrade geckodriver to 0.22.0

* [ftr] add firefox specific config file

* remove hard coded firefox adjustments

* remove firefox specific screenshot directory

* run functional tests in firefox in x-pack

* pass the logger to readConfigFile()

* rename local var

* skip xpack firefox config

* run xpack firefox functional tests in separate command

* update report name for XPack firefox results

* adjust viz shared item test

* skip shared item test

* [test/feature_controls] increase timeout to 20 sec & use forceLogout

* FF timeout on TSVB, refresh page on failure for url navigation

* [feature_controls/visualize_security] increase timeout to 20 sec

* skip dev_tools_spaces tests on FF

* run all groups 3 times

* skip more func tests

* skip more tests

* skip all feature controls tests for Firefox

* revert back changes in feature controls tests

* rename xpack report for chrome

* skip tile map for FF, wait for render before saving

* Revert "run all groups 3 times"

This reverts commit 12b4f69627.

* revert refresh on login

* apply feedback
2019-05-31 17:18:31 -07:00
Vitali Haradkou
ffb93cbc23 [7.x] Tsfy screenshot service and comparepng internal lib (#37177) (#37195)
* Tsfy screenshot service and comparepng internal lib (#37177)

* fix issue with jimp library

* Revert "fix issue with jimp library"

This reverts commit 7f3cead5fb.
2019-05-29 11:46:53 -07:00
Maryia Lapata
b0e8e5e96b
[Vis: Default editor] EUIficate top_sort param editor (#36629) (#37322) 2019-05-29 14:22:15 +03:00
Vitali Haradkou
a93ffdbfed
[TSVB] markdown variables(revert fix) (#34067) (#37197)
* add markdown tests
2019-05-28 03:40:28 +03:00
Vitali Haradkou
656e704d3e
FTR tsfy combobox service (#35493) (#36747)
* migrate combobox to typescript
2019-05-21 12:28:36 +03:00
Matt Bargar
d6100f4f36
Extract QueryBarInput component from QueryBar (#35827) (#36383)
Solution for use cases that need a query bar without a submit button or date picker that still want KQL and autocomplete. Necessary for the KQL in TSVB and KQL in filters aggregation efforts.
2019-05-09 17:49:16 -05:00
Dmitry Lemeshko
12aa67edb2
adjust tests to pass on Firefox (#35597) (#36069)
* adjust tests to pass on Firefox

* update feature controls tests to pass on Firefox

* use xpath to search for index pattern
2019-05-04 09:31:26 +02:00
Daniil Suleiman
aba6d6233c
[Vis: Default editor] EUIficate time interval control (#34991) (#36006)
* EUIficate time interval control

* Update tests

* Remove empty option, update fix tests

* Bind vis to scope for react component only

* Combine two interval inputs into one EuiCombobox

* Add error message

* Add migration script; remove unused translations

* Update fuctional tests

* Update unit test

* Update tests; refactoring

* Use flow to invoke several functions

* Update test

* Refactoring

* Reset options when timeBase

* Add type for editorConfig prop

* Add placeholder

* Fix lint errors

* Call write after interval changing

* Fix code review comments

* Make replace for model name global

* Revert error catch

* Remove old dependency

* Add unit test for migration test

* Fix message

* Fix code review comments

* Update functional test
2019-05-03 12:03:42 +03:00
Dmitry Lemeshko
35a5a84e71
Update services to support functional tests in Firefox (#35648) (#35953)
* add Browsers enum & changes to support FF

* revert moveTo signature to Promise<void>
2019-05-02 18:13:01 +02:00
Brandon Kobel
7943f9895d
Feature Controls - Read only badges (#35252) (#35758)
* Adding readonly badge to the discover application

* Dashboard get a badge

* Visualize gets a badge

* Timelion gets a badge

* Canvas gets a badge

* Maps gets a badge

* Infra gets a badge

* Graph gets a badge

* Dev Tools gets a badge

* Index Patterns get badges

* Advanced Settings get badges

* Infra and i18n are super chill friends

* Using proper i18n prefix for xpack

* Adding badges to the uptime application

* APM gets a badge!

* Adding functional tests for the discover read-only badge

* Functional tests for everyone!

* Removing unused import

* Fixing chrome service mock

* Switching from ChromeBadge | null to ChromeBadge | undefined

* Fixing canvas badge assertst

* Fixing Logs ui capabilities

* More ChromeBrand | null to ChromeBrand | undefined related changes

* Using named badges

* Revert "Using named badges"

This reverts commit c0e341bee1.

* i18n'ing the uptime read-only badges

* Adding ChromeService tests for badges

* Starting to add tests for the legacy badge API

* Changing capitalization of "Read Only" to "Read only"

* Adjusting styles

* Adding $setupBadgeAutoClear tests

* Changing the badge tooltip

* Fixing timelion i18n prefix

* Changing where Canvas sets the breadcrumbs

* Using a read-only badge with an icon

* Update x-pack/plugins/canvas/public/angular/controllers/canvas.js

Co-Authored-By: kobelb <brandon.kobel@gmail.com>

* Update src/legacy/core_plugins/timelion/public/app.js

Co-Authored-By: kobelb <brandon.kobel@gmail.com>

* Changing discover's read-only verbiage

* Removing tests for code that moved to an untested part of Kibana

* Fixing issues introduced with the rebase

* Fixing priv ileges snapshot

* Adding back dropped docs

* Fixing plugin plugin doc

* Ensuring iconType is set as well

* Updating badge api, angular components moved

* graph to Graph

* Fixing linter

* Switching from aria-label to data-test-badge-label for testing

The tabIndex allows screenreaders to work properly

* Fixing eslint error

* Fixing more issues introduced by the merge from master

* APM updates badge in React hook

* Applying changes suggested by Aleh
2019-04-29 13:52:21 -07:00