Commit graph

173 commits

Author SHA1 Message Date
Xavier Mouligneau
c058d822bc
[8.0] [RAM] Fix bulk action for o11y for 7.17 (#126686) (#126854)
* [RAM] Fix bulk action for o11y for 7.17 (#126686)

* fix bulk action for o11y

* review I

* discuss it more with Devin

* clean up

(cherry picked from commit 8f277d4677)

* fix es client

* fix function
2022-03-04 08:43:23 -07:00
Kevin Qualters
0dbedb5434
[8.0] [Security Solution] Remove a data fetching hook from the add to timeline action component (#124331) (#125810)
* [Security Solution] Remove a data fetching hook from the add to timeline action component (#124331)

* Fetch alert ecs data in actions.tsx and not a hook in every table row

* Add error handling and tests for theshold timelines

* Fix bad merge

* Remove unused imports

* Actually remove unused file

* Remove usage of alertIds and dead code from cases

* Add basic sanity tests that ensure no extra network calls are being made

* Remove unused operator

* Remove unused imports

* Remove unused mock

(cherry picked from commit e312c36e4c)

# Conflicts:
#	x-pack/plugins/cases/public/components/case_view/case_view_page.tsx
#	x-pack/plugins/cases/public/components/user_actions/types.ts
#	x-pack/plugins/security_solution/public/cases/pages/index.tsx
#	x-pack/plugins/security_solution/public/timelines/components/side_panel/event_details/footer.tsx

* Fix types

* Fix failing tests
2022-02-16 15:01:38 -07:00
Kibana Machine
9d2091b3fd
[Security Solution] Use search strategy error in timeline (#125178) (#125423)
(cherry picked from commit 4fe96b799e)

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2022-02-11 12:56:01 -07:00
Sergi Massaneda
2a14252113
[SecuritySolution][Timeline] Clean removed runtime fields (#122976) (#123801)
* remove unexisting fields from timeline

* replicate clean logic in security timeline

* tests updated due to mocks changes

* solve action dipatches race condition

* tests fixed

* fix async dispatches

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7f7dbbb3cc)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/__snapshots__/alert_summary_view.test.tsx.snap
#	x-pack/plugins/security_solution/public/timelines/components/create_field_button/index.tsx
2022-01-26 05:25:51 -07:00
Kibana Machine
d551f02ca4
Fix success message to show correct language based on timelin… (#123258) (#123320)
* Fix success message to show correct language based on timeline type

* Fix translation problems

Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
(cherry picked from commit 91a35c20ce)

Co-authored-by: Kristof C <kpac.ja@gmail.com>
2022-01-18 17:50:03 -07:00
Kibana Machine
1939432623
[Security Solution] Add aliases, fix types, remove extra fields (#122880) (#123319)
* Add aliases, fix types, remove extra fields

* Update aliases version and update tests

* Update aliases version test

* Remove dangling references to fields

* Update test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 886ad6fdaf)

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
2022-01-18 17:25:39 -07:00
Kibana Machine
8f656e953a
[Timelines] Update fields metadata from beats 8.0 (#123014) (#123304)
* Move beats metadata script to timelines plugin

This is the plugin that consumes the artifacts of the script, not
security_solution.

* Remove unused beats metadata file

This file also exists in the timelines plugin, but only that one is
used.

* Update fields metadata from beats 8.0.0-rc1

This will serve as the data source for our metadata in kibana 8.0.

* Update indexFields unit tests following ECS update

8.0 introduced some textual changes to field descriptions.

* Revert "Move beats metadata script to timelines plugin"

This reverts commit cbc8e9db1a.

* Update script to modify the appropriate timelines file

This is the one used by IndexFields.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8c11be1154)

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2022-01-18 15:40:38 -07:00
Jan Monschke
07340b5f5f
fix: prevent hidden elements on last page of data grid (#122781)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-01-14 18:29:51 +01:00
Kevin Qualters
9d547ec18a
[8.0] [Security Solution] Make rule detail link work for both signal.rule.name and kibana.alert.rule.name (#122437) (#122959)
* [Security Solution] Make rule detail link work for both signal.rule.name and kibana.alert.rule.name (#122437)

* Make rule detail link work for both signal.rule.name and kibana.alert.rule.name

* Remove failing test

* Remove incorrect comment about possible bug

* PR feedback

* More cleanup/feedback

* Memoize hook usage

(cherry picked from commit 6c72063531)

# Conflicts:
#	x-pack/plugins/security_solution/public/detections/configurations/examples/observablity_alerts/render_cell_value.tsx
#	x-pack/plugins/security_solution/public/detections/configurations/examples/security_solution_rac/render_cell_value.tsx

* Lint

* Fix lint for real
2022-01-13 12:37:03 -07:00
Madison Caldwell
9e80a2f6c8
[Security Solution] Fixes threshold alert "Investigate in Timeline" functionality (#121256) (#122699)
* Add flattend parameters object and populate it in Security Solution

* Fix severity, risk_score, bugs, tests

* Add ALERT_RULE_PARAMETERS to package

* Skip tightly coupled test

* fix more tests

* Remove unused import

* Fix threat matching API test

* Continue overriding kibana.alert.rule.risk_score and severity for now

* Add ignore_above to ALERT_RULE_PARAMETERS

* Exploratory

* Not pretty

* more garbage

* debugging

* use expandDottedObject for alerts data in UI

* Remove kibana.alert.rule.risk_score and severity

* Fix tests related to risk_score and severity

* Make translation a template

* Can't use expression in template literal

* Remove commented line added by bad merge

* Fix linting

* Fix unflattening of UI data

* Fix mapping

* Remove console logs

* Fix imports

* Clean up, fix dupes

* Remaining test and type errors

* Remove comment

* Fix skip param

* Add backcompat for threshold timeline

* Fix linting

* Use indexNames for threshold timeline instead of data view

* Add tests for threshold timeline action

* Implement suggestion for simplified alertIds initialization

Co-authored-by: Marshall Main <marshall.main@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 27a9df79e7)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/utils/alerts.ts
#	x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.tsx
#	x-pack/plugins/security_solution/public/helpers.tsx
#	x-pack/plugins/security_solution/server/lib/detection_engine/rule_types/create_security_rule_type_wrapper.ts
2022-01-11 14:35:04 -07:00
Christos Nasikas
e23739e7d7
[Cases] Fix create case titles (#121876) (#121918)
# Conflicts:
#	x-pack/plugins/cases/public/components/all_cases/nav_buttons.tsx
#	x-pack/plugins/cases/public/components/create/index.tsx
2021-12-22 16:01:53 -07:00
Kibana Machine
f5add805e3
[SECURITY SOLUTION] Allow the application to create its own data view without using user privilege (#121109) (#121816)
* backend update to use unsecure so

* wip on UI

* fix UI to work with one dataview at the time

* by pass capabilities in data view factory

* fix sourcerer in timeline

* fix types

* fix unit test

* fix index field to work with security data view

* cypress + detection roles tests

* add unit test

* review I

* review II

* review III

* clean up after talking to Larry

* fix latets code

* working to be green

* by pass capabilities from data view API only use saved object kibana privilege

* fix lint

* add commnet per review

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2021-12-21 13:01:18 -07:00
Marshall Main
04014638b4
[Security Solution] Remove extra rule fields from kibana.alert.rule (#121135) (#121571)
* Remove kibana.alert.rule.risk_score and severity

* Fix tests related to risk_score and severity

* Make translation a template

* Can't use expression in template literal

* Remove commented line added by bad merge

* Fix linting

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/overview/__snapshots__/index.test.tsx.snap
#	x-pack/plugins/security_solution/public/common/components/event_details/overview/index.test.tsx
#	x-pack/plugins/security_solution/public/common/components/event_details/overview/index.tsx
#	x-pack/plugins/security_solution/public/detections/configurations/examples/observablity_alerts/render_cell_value.tsx
#	x-pack/plugins/security_solution/public/detections/configurations/examples/security_solution_rac/render_cell_value.tsx
#	x-pack/plugins/timelines/server/search_strategy/timeline/factory/events/all/constants.ts
2021-12-17 16:28:41 -07:00
Kibana Machine
357a6f186c
[RAC][Observability] Use flattened type for rule params in Observability (#120758) (#121503)
* add kibana.alert.rule.parameters as a flattened type

* temp

* rule_data_formatter

* fix bug in search strategy with flattend field type where prefix was wrong (kibana.alert.rule.parameters was ignored)

* fix inventory rule data formatters

* remove console log

* hack that prepends kibana.alerts.rule.parameters in the nested subfields

* import ALERT_RULE_PARAMETERS from kbn rule data utils

* remove console log

* format custom metric link

* remove ALERT_PARAMS from technical field names

* fix bug in timelines plugin to use dotField instead of prependField & fix failing tests

* remove console log and unused variable

* delete kibana.alert.rule.params from the mapping

* flatten kibana.alert.rule.parameters and add some unit tests

* fix rule_data_formatter

* handle scenario of having multiple items in an array (multiple conditions setup in the rule)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: mgiota <giota85@gmail.com>
2021-12-17 05:52:47 -07:00
Faisal Kanout
46b07f178b
[RAC] Show all alerts, not only "open" workflow status, and remove Workflow filter related logic and clean up the code (#120231) (#121281)
* Remove comments

* Remove workflow code from Alert page and make currentFilter in t grid optional

* Remove workflow props for AlertsTableTGridProps

* Remove unused import

* Remove workflow state from Alert page state container

* Update page state container

* Update tests

* Remove builk actions tests

* Remove bulk actions provider

* Remove does not render case options in the overflow menu test

* Resume permissions for cases test

* Fix does not render case options in the overflow menu test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/observability_functional/apps/observability/index.ts
2021-12-15 05:44:14 -07:00
Kibana Machine
87f7fd0027
[Security Solution] Add app id prop for navigateToApp (#121139) (#121147)
* Add app id prop for navigateToApp

* Add missing hook dependency

* Fix types

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
2021-12-13 18:22:47 -07:00
Kibana Machine
a755b42c2b
Fix wrong runtime field format on alert table (#120744) (#121080)
* Fix wrong runtime field format on alert table

* Fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
2021-12-13 08:18:07 -07:00
Steph Milovic
3ed46c25e1
resolve conflicts (#120633)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-12-07 23:40:15 -07:00
Khristinin Nikita
4b1ae0e99a
Add support for threat.feed.name (#120250) (#120584)
* Add support for threat.feed.name

* fix cy tests

* Remove provider field

* fix tests

* Provider to feed.name

* Fix tests

* Fix tests

* fix comments

* Fix i18n

* fix type

* Fix types

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-12-07 04:34:16 -07:00
Frank Hassanabad
dd0744ddd2
[Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (#120437) (#120569)
## Summary

See: https://github.com/elastic/kibana/issues/110903

This removes all the top level API `export *` spots from:
* `timeline` plugin within both the common and public section

This reduces the number of metrics and warning about undocumented functions.

I also add this text to timeline:

```
// Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase.
// If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
// than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.

// When you do have to add things here you might want to consider creating a package to share with
// other plugins instead as packages are easier to break down and you do not have to carry the cost of extra plugin weight on
// first download since the other plugins/areas of your code can directly pull from the package in their async imports.
// See: https://docs.elastic.dev/kibana-dev-docs/key-concepts/platform-intro#public-plugin-api
```

# Conflicts:
#	x-pack/plugins/timelines/public/components/actions/timeline/cases/add_to_case_action.tsx
2021-12-06 23:29:20 -07:00
Frank Hassanabad
a398d467b8
[8.0] [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the common section (#120559)
* [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the common section (#120310)

See: https://github.com/elastic/kibana/issues/110903, https://github.com/elastic/kibana/issues/120234

This removes as many top level API `export *` spots from:
* `cases` plugin within the common section

as we can. This reduces the number of metrics and warning about undocumented functions and reduces the page load size from `cases/common/index.ts`. Look at the metrics from the build below and you will see drop off numbers across the board for required API documentation to the page load size.

In the file `cases/common/index.ts` I now put the advice of:

```
// Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase.
// If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
// than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.

// When you do have to add things here you might want to consider creating a package such as kbn-cases-constants to share with
// other plugins instead as packages are easier to break down and you do not have to carry the cost of extra plugin weight on
// first download since the other plugins/areas of your code can directly pull from the package in their async imports.
// For example, constants below could eventually be in a "kbn-cases-constants" instead.
// See: https://docs.elastic.dev/kibana-dev-docs/key-concepts/platform-intro#public-plugin-api
```

Some of those that are exposed such as `throwErrors` might actually be small simple mistakes as `security_solution` is using it but it has a "copy" of the same utility within just its server section rather than within its common section. That can be done in a different cleanup PR and cases team can decide what to do moving forward with their API before or post 8.0.0 release.

For the metric increasing of:
| id | [before](f01106c100) | [after](f2e5d6a848) | diff |
| --- | --- | --- | --- |
| `cases` | 16 | 22 | +6 |

Running that suggestion:

```sh
node --max-old-space-size=6096 scripts/build_api_docs --plugin cases --stats exports
```

I see this:
<img width="1851" alt="Screen Shot 2021-12-03 at 9 30 45 AM" src="https://user-images.githubusercontent.com/1151048/144638952-43d50478-ea12-4ce1-8f73-585c735772b4.png">

I don't know if there is a way just yet to mark undocumented public API's but I don't feel concerned with it at the moment and if the case team wants to re-expose those or are going to support API's through documentation they can decide what to do. This PR is more about just removing as much as possible to start with and then go the other direction where the individual teams can decide what to expose and if the download weight is worth it or if it's just `export type` and holds no weight, etc...

* Updated staged files

* Fixed prettier issues
2021-12-06 18:54:44 -07:00
Faisal Kanout
f2e3762e91
[8.0][RAC] 19482 t grid fix always show checkboxes (#119608) (#120207)
* Add showCheckboxes prop

* Hide leading checkboxes from Alerts page and updates the tests.

* Skip tests

* Skip test

* Testing FLAKY tls alert

* Remove exclusive test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-12-02 06:53:31 -07:00
Zacqary Adam Xeper
6c987e5d8b
[RAC] Store Alerts View table state in localStorage (#118207) (#119678)
* [RAC] Store Alerts View table state in localStorage

* Use Redux store subscriber instead of callback

* Fix typecheck

* Fix bad merge

* Add tests

* Remove persisting selected rows

* Fix bad merge

* onTGridStateChange => onStateChange

* Remove non-null assertion

* Put non-null assertion back because typescript hates me, personally

* Fix checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-24 17:34:48 -07:00
Tiago Costa
beb041b24f
[8.0] chore(NA): splits types from code on @kbn/i18n (#119256) (#119649)
* chore(NA): splits types from code on @kbn/i18n (#119256)

* chore(NA): auto creation of the package.json for the new types pkg rule

* chore(NA): first alpha api extractor working version

* chore(NA): support kbn-analytics

* chore(NA): correctly read tsconfig files and deps from ts_config rule

* chore(NA): layed out pkg_npm_types tree artifact custom rule

* chore(NA): missing todos

* chore(NA): node modules link mapping

* chore(NA): fully working pkg_npm_types rule

* chore(NA): fix changes on new packages using elastic datemath pkgs

* docs(NA): remove todo

* docs(NA): last todo text correction

* chore(NA): removed commented lines

* fix(NA): include missing package version

* chore(NA): include license keys

* chore(NA): change mock types package into private

* chore(NA): disable validator on ts_project rule

* chore(NA): use the wrapper for ts_project

* commit using @elastic.co

* chore(NA): commit using @elastic.co

* chore(NA): split types from code on @kbn/i18n

* chore(NA): update yarn.lock file

* chore(NA): split @kbn/i18n and @kbn/i18n-react

* chore(NA): missing import fix

* chore(NA): fix jest project configs

* chore(NA): change imports on kbn i18n

* chore(NA): change imports on kbn i18n

* chore(NA): correct loader imports

* chore(NA): missnig i18nLoader export key

* chore(NA): fix type exports

* chore(NA): export type only

* chore(NA): export type only

* fix(NA): type exports

* chore(NA): missing @Kbn/i18n/react imports

* chore(NA): missing skip path for kbn-i18n-react

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	package.json
#	packages/BUILD.bazel
#	packages/kbn-monaco/BUILD.bazel
#	src/core/public/core_app/status/components/server_status.tsx
#	src/core/public/core_app/status/components/status_table.tsx
#	src/core/public/core_app/status/components/version_header.tsx
#	src/core/public/core_app/status/status_app.tsx
#	src/plugins/console/public/application/components/storage_quota_error.tsx
#	src/plugins/dashboard/public/application/listing/dashboard_listing.tsx
#	src/plugins/data_view_field_editor/public/components/field_editor/form_fields/script_field.tsx
#	src/plugins/dev_tools/public/application.tsx
#	src/plugins/discover/public/application/apps/context/context_app_route.tsx
#	src/plugins/discover/public/application/apps/doc/single_doc_route.tsx
#	src/plugins/discover/public/application/apps/main/components/doc_table/components/table_row_details.tsx
#	src/plugins/discover/public/application/apps/main/components/layout/discover_documents.tsx
#	src/plugins/discover/public/application/components/table/table_columns.tsx
#	src/plugins/discover/public/application/components/table/table_row_btn_filter_remove.tsx
#	src/plugins/discover/public/application/components/table/table_row_btn_toggle_column.tsx
#	src/plugins/index_pattern_editor/public/open_editor.tsx
#	src/plugins/interactive_setup/public/plugin.tsx
#	src/plugins/kibana_overview/public/application.tsx
#	src/plugins/kibana_react/public/util/to_mount_point.tsx
#	src/plugins/presentation_util/public/components/field_picker/field_search.tsx
#	src/plugins/vis_types/timeseries/public/timeseries_vis_renderer.tsx
#	src/plugins/vis_types/xy/public/vis_renderer.tsx
#	src/plugins/visualizations/public/wizard/show_new_vis.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create_from_csv/error_display.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create_from_csv/instructions.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create_from_csv/main.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create_from_csv/pipelines_csv_uploader.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create_from_csv/pipelines_preview.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/empty_list.tsx
#	x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx
#	x-pack/plugins/lens/public/indexpattern_datasource/utils.tsx
#	x-pack/plugins/lens/public/metric_visualization/visualization.tsx
#	x-pack/plugins/lens/public/pie_visualization/render_function.tsx
#	x-pack/plugins/maps/public/classes/sources/ems_tms_source/update_source_editor.js
#	x-pack/plugins/maps/public/classes/sources/es_search_source/util/scaling_documenation_popover.tsx
#	x-pack/plugins/security/public/authentication/access_agreement/access_agreement_page.tsx
#	x-pack/plugins/security/public/authentication/logged_out/logged_out_page.tsx
#	x-pack/plugins/security/public/authentication/login/login_page.tsx
#	x-pack/plugins/security/public/authentication/overwritten_session/overwritten_session_page.tsx
#	x-pack/plugins/security/public/management/users/users_management_app.tsx
#	x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
#	x-pack/plugins/spaces/public/space_selector/space_selector.tsx
#	yarn.lock

* chore(NA): missing @kbn/i18n/react imports
2021-11-24 12:19:43 -07:00
Kibana Machine
4a94a21812
[Security Solution][RAC][Cypress] Unskip some tests (#117596) (#119542)
* Reenable cypress tests for rules

* Indicator match is not yet passing

* Update refs

* Fix eql alert generation original_time and building_block_type

* Unskip a few more tests

* Update field names in jest tests

* Fix unit tests / cypress tests

* Have to keep this one skipped for now

* Fix some more tests?

* cleanup

* Fix translation

Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com>
2021-11-23 15:12:41 -07:00
Kibana Machine
b627dca3ba
[Security Solution] Restores the @timestamp column actions and fixes an @timestamp alignment issue (#118990) (#119184)
## [Security Solution] Restores the `@timestamp` column actions and fixes an `@timestamp` alignment issue

This PR fixes the `@timestamp` column issues described in https://github.com/elastic/kibana/issues/118989

The PR:

- Fixes an issue where the `Filter in`, `Filter out`, and `Investigate in timeline` actions were disabled in the `Security > Alerts` table, per the before / after screenshots below:

**Before**

![alerts-actions-before](https://user-images.githubusercontent.com/4459398/142335094-141fe435-eb9a-4920-a6d3-2c7673f31664.png)

_Above: The `Filter in`, `Filter out`, and `Investigate in timeline` actions were disabled for `@timestamp` in Security > Alerts_

**After**

![alerts-actions-after](https://user-images.githubusercontent.com/4459398/142302794-c2c3684b-92cc-483c-a02b-33f2624ddc79.png)

_Above: The `Filter in`, `Filter out`, and `Investigate in timeline` actions are enabled for `@timestamp` in Security > Alerts_

- Fixes a CSS issue where text truncation styles were causing the `@timestamp` column to be mis-aligned in Timeline, per the before / after screenshots below:

**Before**

![timestamp-alignment-before](https://user-images.githubusercontent.com/4459398/142334676-3a95bb9b-3be9-47c6-8828-efe5f8cbfe2c.png)

_Above: The `@timestamp` column in Timeline was vertically mis-aligned_

**After**

![timestamp-alignment-after](https://user-images.githubusercontent.com/4459398/142334495-c4997aa0-225e-4373-bee2-44b8ec05312b.png)

_Above: The `@timestamp` column in Timeline is correctly (vertically) aligned_

### No changes to the o11y alert actions

There are no changes to the actions shown in the `o11y` alerts table, per the before / after screenshots below:

![o11y-alerts-before](https://user-images.githubusercontent.com/4459398/142335532-5678c55c-b8a1-4122-accb-47e4f71e761f.png)

_Above: Before - the `@timestamp` field in the `o11y` alerts table does NOT have actions_

![o11y-alerts-after-no-change](https://user-images.githubusercontent.com/4459398/142321916-fd7ffbd6-c2db-4820-b055-b9f3fe546cc9.png)

_Above: After - the `@timestamp` field in the `o11y` alerts table (still) does NOT have actions_

### Field browser search input auto-focus

- Fixed an issue where the `Fields` browser search input was not auto-focused, per the screenshot above:

![fields-browser-auto-focused](https://user-images.githubusercontent.com/4459398/142300763-21d0fc50-e1c1-477b-be15-4f367e800af8.png)

_Above: The search input is auto-focused when the `Fields` browser is opened_

### Details

The fix that re-enables the `Filter in`, `Filter out`, and `Investigate in timeline` actions in the `Security > Alerts` required removing a recently-introduced `TODO` in `x-pack/plugins/timelines/public/components/t_grid/body/index.tsx`, which defined a common set of disabled actions for both the `o11y` and `Security` solutions.

The `TODO` was replaced by a `disabledCellActions` prop, which enables each solution to configure the disabled cell actions independently.

### Desk testing

While desk testing the `@timestamp` alignment issue:

> - Fixes a CSS issue where text truncation styles were causing the `@timestamp` column to be mis-aligned in Timeline

You may find it informative to locally edit `x-pack/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.tsx` to add the following styles:

```css
background-color: red;
```

and

```css
background-color: green;
```

to `ProviderContentWrapper`, as shown in the code below:

```typescript
export const ProviderContentWrapper = styled.span`
  > span.euiToolTipAnchor {
    background-color: red;
    display: block; /* allow EuiTooltip content to be truncatable */
  }

  > span.euiToolTipAnchor.eui-textTruncate {
    background-color: green;
    display: inline-block; /* do not override display when a tooltip is truncated via eui-textTruncate */
  }
`;
```

as illustrated by the `diff` below:

![background-colors](https://user-images.githubusercontent.com/4459398/142300526-c61f1de7-f695-4b96-99d9-428763405d99.png)

_Above: `background-color: green` and `background-color: red` styles added locally for desk testing_

With the (temporary) style changes above, the effect (and scope) of the new style is easily seen, as shown in the screenshot below:

![compare-styles](https://user-images.githubusercontent.com/4459398/142300502-dbc44572-6066-4cb1-a045-26a15086d02d.png)

_Above: The effect of the (green) style changes compared with the (red) unchanged styles_

When the new style introduced in this PR is commented-out for desk testing, as shown in the code below:

```typescript
export const ProviderContentWrapper = styled.span`
  > span.euiToolTipAnchor {
    background-color: red;
    display: block; /* allow EuiTooltip content to be truncatable */
  }

  /*
  > span.euiToolTipAnchor.eui-textTruncate {
    background-color: green;
    display: inline-block; /* do not override display when a tooltip is truncated via eui-textTruncate */
  }
  */
`;
```

the behavior of `@timestamp` reverts to the behavior prior to this PR, as shown in the screenshot below:

![reverted-fix](https://user-images.githubusercontent.com/4459398/142300380-095c4b58-0417-46c4-98b4-10387c4220b8.png)

_Above: The `@timestamp` column defaults to the old (red) unchanged behavior when the new style is commented-out for desk testing_

Co-authored-by: Andrew Goldstein <andrew-goldstein@users.noreply.github.com>
2021-11-19 10:11:18 -07:00
Kibana Machine
634d306acb
fix (#119065) (#119128)
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2021-11-18 22:29:55 -07:00
Pablo Machado
0c3a8659da
Add CreateFieldButton component to browser fields (#117627) (#119019)
Add user permission check to CreateFieldButton

Refetch data after creating field

Add global styles to make Overlay z-index higher than timeline z-index

Fix create runtime field loading state

Update alert table columns after adding a new runtime field

Updated documentation of 'overlays.openFlyout' public API

Add cypress test

Add CreateField button unit test
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.overlayflyoutopenoptions.md
#	src/core/public/public.api.md
#	x-pack/plugins/security_solution/public/common/components/events_viewer/index.tsx
2021-11-18 07:50:10 -07:00
Kibana Machine
15a577dae3
Removes plugins/data/public deprecations from timelines plugin (#118975) (#118985)
## Summary

This removes all the areas marked as deprecated from `.../src/plugins/data/public` with their `@kbn/es-query` equivalent or it uses the directly exported version from `.../src/plugins/data/public`. Anywhere else this adds the `import type {` where it can to encourage the build system to do more type erasures.

### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-11-17 20:46:05 -07:00
Kibana Machine
21f3957c3c
[kbn/rule-data-utils] add submodules and require public use them (#117963) (#118628)
* [kbn/rule-data-utils] add submodules and require public use them

* fix lint errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
2021-11-15 17:16:30 -07:00
Andrew Goldstein
6f17707bab
[8.0] [Security Solution] Adjusts the width of the Actions column and action icon buttons (#118454) (#118598)
* [Security Solution] Adjusts the width of the `Actions` column and action icon buttons (#118454)

## [Security Solution] Adjusts the width of the `Actions` column and action icon buttons

This PR adjusts the width of the `Actions` column, and normalizes the action icon button sizes throughout the Security Solution, per https://github.com/elastic/kibana/issues/115726

### Before / after screenshots

This section provides before / after screenshots for the following views:

- Alerts
- Alerts > Event rendered
- Rules > Details
- Rules > Details > Event rendered
- Host > Events
- Host > External alerts
- Network > External alerts
- Timeline > Query tab
- Timeline > Correlation tab
- Timeline > Pinned tab
- Observability > alerts (no change)

#### Alerts (before)

![01-security_alerts_before](https://user-images.githubusercontent.com/4459398/141429498-a6040f8b-5bfb-468e-aa1a-993caa7f179c.png)

#### Alerts (after)

![01a-security_alerts_after](https://user-images.githubusercontent.com/4459398/141429618-8ad313e1-fabc-424e-9e7d-c24240861c1d.png)

#### Alerts > Event rendered (before)

![02-security_alerts_event_rendered_before](https://user-images.githubusercontent.com/4459398/141430881-2bfeb57a-9881-47f1-99e4-cc7eadcfff69.png)

#### Alerts > Event rendered (after)

![02a-security_alerts_event_rendered_after](https://user-images.githubusercontent.com/4459398/141430976-88f8099a-81b1-4f1c-99a2-26f86218f909.png)

#### Rules > Details (before)

![03-security_rules_details_before](https://user-images.githubusercontent.com/4459398/141431149-a308f171-a170-4ce9-9616-77e5c08dc406.png)

#### Rules > Details (after)

![03a-security_rules_details_after](https://user-images.githubusercontent.com/4459398/141431221-06701540-97bb-400a-97bf-f2d22cd65caf.png)

#### Rules > Details > Event rendered (before)

![04-security_rule_details_event_rendered_before](https://user-images.githubusercontent.com/4459398/141431394-12b29689-41c8-44b6-b69f-7796f99c5424.png)

#### Rules > Details > Event rendered (after)

![04a-security_rule_details_event_rendered_after](https://user-images.githubusercontent.com/4459398/141431477-049804c0-1455-4216-a241-a44df5c9d398.png)

#### Host > Events (before)

![05-host_events_before](https://user-images.githubusercontent.com/4459398/141431858-31116980-47f7-4779-af26-3b3785638137.png)

#### Host > Events (after)

![05a-host_events_after](https://user-images.githubusercontent.com/4459398/141431956-664f86b9-2ad7-4281-bf82-8278fa23c755.png)

#### Host > External alerts (before)

![06-host_external_alerts_before](https://user-images.githubusercontent.com/4459398/141432103-8cc9c10e-4d2d-42ec-a62c-a1e5867bf2d8.png)

#### Host > External alerts (after)

![06a-host_external_alerts_after](https://user-images.githubusercontent.com/4459398/141432185-4d7e4007-dea9-47f3-af4b-1719f338a5ba.png)

#### Network > External alerts (before)

![07-network_external_alerts_before](https://user-images.githubusercontent.com/4459398/141432331-2bb5a714-f733-4c97-91dc-73ff76633daa.png)

#### Network > External alerts (after)

![07a-network_external_alerts_after](https://user-images.githubusercontent.com/4459398/141432428-b7b20450-db87-44ab-8014-cf4d6032dfe3.png)

#### Timeline > Query tab (before)

![08-timeline_query_tab_before](https://user-images.githubusercontent.com/4459398/141432638-e484813b-275d-4eff-aa38-1705f913ce59.png)

#### Timeline > Query tab (after)

![08a-timeline_query_tab_after](https://user-images.githubusercontent.com/4459398/141434461-1d36bba5-8fd1-484a-bacd-733aede95815.png)

#### Timeline > Correlation tab (before)

![09-timeline_correlation_tab_before](https://user-images.githubusercontent.com/4459398/141434637-33f05447-e3d3-4eac-b38a-3612945e8379.png)

#### Timeline > Correlation tab (after)

![09a-timeline_correlation_tab_after](https://user-images.githubusercontent.com/4459398/141434751-250fd26b-25fc-48cc-8a06-dbb17e53dce7.png)

#### Timeline > Pinned tab (before)

![10-timeline_pinned_tab_before](https://user-images.githubusercontent.com/4459398/141434893-3f2b3d17-7e4b-4e0c-9096-ab1ee57f096f.png)

#### Timeline > Pinned tab (after)

![10a-timeline_pinned_tab_after](https://user-images.githubusercontent.com/4459398/141435431-26eac065-bce4-4a25-99fd-095d447fb6f3.png)

#### Observability > alerts (before)

![11-observability_alerts_before](https://user-images.githubusercontent.com/4459398/141435607-da059e9c-af03-4a21-bb1b-e47d44d61dde.png)

#### Observability > alerts (after / no change)

![11a-observability_alerts_after_no_change](https://user-images.githubusercontent.com/4459398/141435696-52bcc5e1-6823-4b6a-b2da-32e3f8733dc8.png)

### Additional details

- Per [this comment](https://github.com/elastic/kibana/issues/115726#issuecomment-962077067) from @monina-n , the size of all action buttons have been normalized match the size off the `...` overflow button (`28 x 32` at the time of this writing) via the `EuiButtonIcon` `size` prop:

```
size="s"
```

- The horizontal alignment of the `Analyze event` icon was updated by the EUI team in the following PR: https://github.com/elastic/eui/pull/5365

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/events_viewer/index.tsx

* - removed createFieldComponent prop
2021-11-15 17:07:02 -07:00
Or Ouziel
835f2d8d45
[8.0] replace any with unknown in http client and types (#114265) (#118348)
* replace any with unknown in http client and types (#114265)

# Conflicts:
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_logic.ts
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview_logic.ts
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/suggestions_logic.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curation_suggestion/curation_suggestion_logic.ts
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_settings/curations_settings_logic.ts

* commit using @elastic.co

* remove unused file
2021-11-15 09:12:42 -07:00
Kibana Machine
1be554f2e5
110640 tests for alert bulk actions (#117264) (#118428)
* bulk actions test cases outline

* helpers to filter alerts per rule type (reason)

* add proper apm indices/privileges to observability functional tests

* cleanup

* add apm archive data

* add correct apm archive data, add helper to select checkbox per solution & cleanup

* enable more tests

* cleanup

* tests for bulk container

* more tests for bulk container

* fix eslint issues

* fix failing unit tests (use ~= for multiple space separated values)

* remove unused value

* fix typescript error with container.querySelector

* remove apm test archive data

* use getByTestId in the tests

* fix security cypress tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: mgiota <giota85@gmail.com>
2021-11-11 17:06:54 -05:00
Spencer
7595121751
[8.0] Remove direct usage of EUI theme vars (#116232) (#118228)
* Remove direct usage of EUI theme vars (#116232)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/discover/public/application/components/discover_grid/discover_grid_document_selection.tsx
#	x-pack/plugins/apm/ftr_e2e/cypress/integration/read_only_user/service_inventory/service_inventory.spec.ts
#	x-pack/plugins/apm/public/application/uxApp.tsx

* commit using @elastic.co
2021-11-10 16:26:34 -05:00
Steph Milovic
2828a22b76
[8.0] [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (#114806) (#117670)
* [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views  (#114806)

* fix type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-08 19:01:10 +00:00
Kibana Machine
57febcecfa
[Security Solution][Investigations] - Fix replace all on main (#117680) (#117848)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-11-08 15:07:41 +00:00
Kibana Machine
3deb3a9dc5
[Security Solution][Investigations] - Change context menu text and add test (#117673) (#117710)
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-11-05 19:30:49 +00:00
Kibana Machine
44fdcd67ad
[Cases] Fix cases navigation after attaching an alert to a case. (#117633) (#117675)
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2021-11-05 17:10:27 +00:00
Kibana Machine
3fd731d5fe
[Security Solution][Investigations] Fix filter out of empty values (#117422) (#117482)
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-11-05 16:55:57 +00:00
Jonathan Budzenski
57a764f057
Revert "[8.0] replace any with unknown in http client and types (#114265) (#117524)" (#117592)
This reverts commit 58f1af552e.
2021-11-04 15:18:29 -05:00
Or Ouziel
58f1af552e
[8.0] replace any with unknown in http client and types (#114265) (#117524)
* replace any with unknown in http client and types (#114265)

# Conflicts:
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/suggestions_logic.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curation_suggestion/curation_suggestion_logic.ts
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_settings/curations_settings_logic.ts
#	x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/resilient/api.ts

* commit using @elastic.co
2021-11-04 18:15:11 +00:00
Kibana Machine
e7761d0a03
[Security Solution][Investigations] - Default enable copy icon tooltip (#117412) (#117484)
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-11-04 13:39:47 +00:00
Kibana Machine
6075ef33d2
[Security Solution][Investigations] - Update timeline host and ip fields to be clickable (#117403) (#117480)
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2021-11-04 12:44:59 +00:00
Spencer
7d3d79e6a1
[8.0] [eslint] enable type-specific lint rules (#114184) (#117444)
* [eslint] enable type-specific lint rules (#114184)

* [eslint] enable type-specific lint rules

* autofix violations

* duplicate eslint-disable to new export statement

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/share/common/index.ts

* autofix more types

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-11-04 03:02:56 +00:00
Kibana Machine
e6f52d9467
[RAC][Timeline] - Add audit log to RBAC wrapped search strategy (#112040) (#117427)
### Summary

Went back to add audit logging to the alerts table search strategy used to query RAC alerts. This PR also includes tests for the logging.

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
2021-11-03 23:19:15 +00:00
Kibana Machine
36242b2348
[Security Solution][RAC][Cases] Fix RAC "add to case" functionality from alerts table (#116768) (#117426)
* Fix add to case functionality

* Use appropriate owner when attaching an alert to a case

* Use field name constants

* Gotta reskip the test

* Better error handling

* Fix type errors

* Fix tests

Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com>
2021-11-03 22:56:02 +00:00
Kibana Machine
52065a0439
[RAC] Updates Alerts table cell actions (#116446) (#117179)
* Adds Filter Out button to alert table cell flyout

* Adds translations

* Fixes capitalization of labels

* Removes unused declarations and imports

* Fixes and adds functional tests for Alerts table action buttons

* Addresses review comments

* Fixes Alert table cell actions functional tests

* Removes Filter out action for now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Claudio Procida <claudio.procida@gmail.com>
2021-11-02 18:42:53 +00:00
Madison Caldwell
117efdf87f
[RAC][Security Solution] Adds migration to new SecuritySolution rule types (#112113)
* Initial commit

* Properly handle signal history

* Fix #95258 - cardinality sort bug

* Init threshold rule

* Create working threshold rule

* Fix threshold signal generation

* Fix tests

* Update mappings

* ALERT_TYPE_ID => RULE_TYPE_ID

* Add tests

* Fix types

* Adds RAC rule type migration

* Fix threshold tests (remove outputIndex)

* Add threshold rule type to ruleTypeMappings

* Add kbn-securitysolution-rules package for sharing with alerting framework

* Fix type errors

* Fix find_rules tests

* First round of test fixes

* Fix issues from merge conflicts

* Use ruleDataClient getReader() for reading

* Fixes to 'generating_signals' tests

* Remove more refs to legacy schema

* Linting

* Quick type fix

* Bug fixes

* Add saved query rule type

* Linting

* Fix types

* Signal generation tests

* Test updates

* Update some more refs

* build_alert tests

* Cleanup

* Ref updates

* Revert "Ref updates"

This reverts commit 4d1473d6b0.

* Update status field

* Test fixes

* Another test

* Got a little too aggressive with search/replace

* let's see where we're at

* Fix

* Test fixes

* cleanup

* Fix cases API integration test config, flaky DE tests

* Move flattenWithPrefix to package / skip signal migration tests

* Fix unit tests

* Use new schema for bulk rule creation

* event: { kind } => event.kind

* Fix signal migration API tests

* Fix ml integration test

* Fix threat match integration tests

* Fix ML rule type tests and add correct producer to all rule types

* Update threat match API integration test

* Remove dupe properties

* Type fix

* Fix ML producer in functional test

* Fix generating_signals tests

* Remove usage of RuleDataClient-based execution log client

* Don't check output index version if rule registry enabled

* Fix bulk duplicate rule

* Fix duplicate rule test

* Fix readPrivileges and timestamp check logic

* Fixes for eql and exceptions tests... disable open_close_signals

* Type fixes / keyword test fixes

* Additional test fixes

* Unit test fixes + signal -> kibana.alert

* Test fixes for exceptions

* Fix read_resolve_rules test

* Various test fixes with marshallmain

* Sort search results

* Fix create_rules tests

* Disable writer cache for integration tests

* Disable writer cache for cases integration tests

* Fix types in rule_data_plugin_service

* Fix ordering in exceptions tests

* Remove rule_registry.enabled flag

* Fix signals migration tests

* Don't check signals index before creation

* Fix cypress config

* Fix type error

* create_migrations tests

* Skip flaky test

* Helpful comment

* Fixes from merge conflicts

* Pretend that signals index exists

* Fix type errors

* Skip flaky tests

* Fix threat matching test

* Clean up

* Reverting default ruleRegistry experimental flag (breaks unit tests)

* Reenable rule registry experimental feature by default

* Execute DE rule migration in 8.0

Co-authored-by: Marshall Main <marshall.main@elastic.co>
2021-10-26 16:56:40 -04:00
Mikhail Shustov
3c8fa527a7
[ES] Upgrade client to v8.0 (#113950)
* bump to a pre-8.0 version

* export KibanaClient from /lib sub-folder

* workaround the problem of the absence of estypes

* update es client usage in pacakges

* export estypes from another path

* import errors from root

* import errors from root 2

* update transport import

* update import path for /api/types

* update import path for /api/types

* import errors from top export

* use TransportResult instead if ApiResponse

* fix errors in client_config

* fix src/core/server/saved_objects/migrationsv2/actions/integration_tests/actions.test.ts

* use KibanaClient in mock. we dont export the original Client

* fix client mocks

* fix errors on SO

* fix remaining core errors

* update estype import path

* fix errors in data plugin

* fix data_views

* fix es_ui_shared

* fix errors in interactive_setup

* fix errors in ./test folder

* add @elastic/transport to the runtime deps

* fix errors in packages

* fix erros in src/core

* fix errors in test/

* fix an error in actions plugin

* woraround and fix errors in APM plugin

* fix errors in canvas

* fix errors in event_log

* fix errors in fleet

* fix errors in ILM

* fix errors in infra

* fix errors in ingest_pipeline

* fix errors in lens

* fix errors in license_management

* fix errors in licensing

* fix errors in logstash

* fix errors in ml

* fix errors in monitoring

* fix errors in observability

* fix errors in rule_registry

* fix errors in reporting

* fix errors in rule_registry

* fix errors in security

* fix errors in security_solution

* fix errors in snapshot_restore

* fix errors in transform

* fix errors in UA

* fix errors in uptime

* fix errors in x-pack/test

* fix eslint errors

* fix new errors

* use default HTTP Connection. Undici does not support agent config options keepAlive and maxSockets

* create does not accept require_alias option

* update deps

* use transport types exported from ES client package

* fix ErrorCause | string errors

* do not use enum

* fix errors in data plugin

* update x-pack code

* fix transport

* fix apm search request

* do not crash on reporting

* fix kbn-test build

* mute reporting error to start

* fix ftr build

* another attempt

* update import path

* address or mute new errors

* REMOVE me. pin transport version temporarily.

* remove deep imports from transport package

* fix jest crash

* fix product check tests

* remove unnecessary ts-expect-error

* fix a few failed unit tests

* bump to canary 24

* remove unnecessary ts-expect-error

* remove dependency on transport

* fix types in tests

* mute errors in xpack tests

* product check doesn;t  spam in logs anymore

* filterPath --> filter_path

* ignoreUnavailable --> ignore_unavailable

* ignoreUnavailable --> ignore_unavailable

* trackScores --> track_scores

* trackTotalHits --> track_total_hits

* fix es-arcives

* fix data plugin crashes

* fix watcher test utils

* rollback unnecessary changes

* fix another problem in es-archiver

* fix scroll. for whatever reason scroll fails when request scroll_id in body

* add meta: true in kbn-securitysolution-es-utils

* bump client to canary 25

* fix errors in accordance with the es client spec

* update securityscolution-es-utils

* unify scroll api in reporting and fix tests

* fix unit tests in watcher

* refactor APM to abort request with AbortController API

* fix missing es client calls in tests

* fix missing meta in detection engine FTR tests

* fix another bunch of errors in js tests

* fix wrong coercion

* remove test-grep pattern

* fix apm unit test

* rename terminateAfter to terminate_after in infra plugin

* rename terminateAfter to terminate_after in uptime plugin

* rename terminateAfter to terminate_after in apm plugin

* fix security roles FTR tests

* fix reference

* fix post_privilidges test

* fix post_privilidges

* bump client to 26

* add meta for index_management test helpers

* remove ts-expect-error caused by bad type in reason

* bump client to 27

* REMOVE me. workaround until fixed in the es client

* fix incorrect type casting

* swtich from camelCase params

* use `HttpConnection` for FTR-related clients

* bump client to 29

* Revert "REMOVE me. workaround until fixed in the es client"

This reverts commit c038850c09.

* fix new util

* revert repository changes

* do not crash if cannot store event_loop data

* fix new estypes imports

* fix more types

* fix security test types and add ts-ignore for custom ES client

* fix more estypes imports

* yet more ts violations

* line by line fixing is hard

* adapt `evaluateAlert` from infra as it's also used from FTR tests

* use convertToKibanaClient in FTR test instead of meta:true in plugin code

* migrate from deprecated API in fleet

* fix intergration tests

* fix fleet tests

* fix another fleet test

* fix more tests

* let's call it a day

* Removes custom header check on 404 responses, includes es client ProductNotSupportedError in EsUnavailableError conditional (#116029)

* Removes custom header check on 404 responses, includes es client ProductNotSupportedError in EsUnavailableError conditional

* Updates proxy response integration test

* disable APM until compatible with client v8

* skip async_search FTR test

* use kbnClient in integration tests

* bump version to 29

* bump to 30

* have configureClient return a KibanaClient instead of Client, remove resolved violations.

* bump to 31

* bump to 31

* Revert "bump to 31"

This reverts commit 5ac713e640.

* trigger stop to unusubscribe

* update generated docs

* remove obsolete test

* put "as" back

* cleanup

* skip test

* remove new type errors in apm package

* remove ErrorCause casting

* update a comment

* bump version to 32

* remove unnecessary ts-expect-error in apm code

* update comments

* update to client v33

* remove outdated type definition

* bump to 34 without params mutation

* unskip the test that should not fail anymore

* remove unnecessary ts-expect-error comments

* update to v35. body can be string

* move `sort` to body and use body friendly syntax

* fix a failing test. maps register the same SO that has been already registered by home

Co-authored-by: pgayvallet <pierre.gayvallet@gmail.com>
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
2021-10-26 14:08:22 +02:00
Kevin Qualters
031929b418
Update event view actions column width (#115809) 2021-10-20 14:47:28 -04:00