* if actions array is empty in the rule update payload, remove the actions whether migrating or not
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
This PR adds/updates module recognizer and setup tests for the `apm_transaction` module as well as a corresponding esArchive.
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
* move includes fields error below analysis table
* ensure analytics list refresh interval is respected
* check global state before overwriting timepicker interval setting
* ensure refreshInterval persists between tabs
* handle undefined globalState
* stabilize openMapView service method
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
* fix last breadcrumb item to only be text
* commit using @elastic.co
* cleaner
* tests are coming ;)
* used my brain to simplify it
* fix types
* fix/add jest test
* fix lint + jest tests for spaces
* fix accessibality
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
[Actionable Observability] Add links to navigate from alerts table and flyout to rule generate it
Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
* chore: rename test subjects to camel case
* chore: rename test subjects to camel case /2
* Updates expectations
* Restores files not in observability
* Fixes test subjects
* Fixes selector
* Fixes selector
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Claudio Procida <claudio.procida@elastic.co>
* waitUntilLoadingHasFinished() and wait for table caption to be set
* just formatting change to make eslint happy
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
* Remove unused code
* Fix threshold field refs
* Fix import
* UI fixes for Rules
* Threshold Cypress test fixes
* Type fixes
* Threshold signal test fixes
* Handle legacy schema optionally
* Fix threshold integration test
* More test fixes
Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com>
* [ML] APM Correlations: Fix usage in load balancing/HA setups. (#115145)
- The way we customized the use of search strategies caused issues with race conditions when multiple Kibana instances were used for load balancing. This PR migrates away from search strategies and uses regular APM API endpoints.
- The task that manages calling the sequence of queries to run the correlations analysis is now in a custom React hook (useFailedTransactionsCorrelations / useLatencyCorrelations) instead of a task on the Kibana server side. While they show up as new lines/files in the git diff, the code for the hooks is more or less a combination of the previous useSearchStrategy and the server side service files that managed queries and state.
- The consuming React UI components only needed minimal changes. The above mentioned hooks return the same data structure as the previously used useSearchStrategy. This also means functional UI tests didn't need any changes and should pass as is.
- API integration tests have been added for the individual new endpoints. The test files that were previously used for the search strategies are still there to simulate a full analysis run, the assertions for the resulting data have the same values, it's just the structure that had to be adapted.
- Previously all ES queries of the analysis were run sequentially. The new endpoints run ES queries in parallel where possible. Chunking is managed in the hooks on the client side.
- For now the endpoints use the standard current user's esClient. I tried to use the APM client, but it was missing a wrapper for the fieldCaps method and I ran into a problem when trying to construct a random_score query. Sticking to the esClient allowed to leave most of the functions that run the actual queries unchanged. If possible I'd like to pick this up in a follow up. All the endpoints still use withApmSpan() now though.
- The previous use of generators was also refactored away, as mentioned above, the queries are now run in parallel.
Because we might run up to hundreds of similar requests for correlation analysis, we don't want the analysis to fail if just a single query fails like we did in the previous search strategy based task. I created a util splitAllSettledPromises() to handle Promise.allSettled() and split the results and errors to make the handling easier. Better naming suggestions are welcome 😅 . A future improvement could be to not run individual queries but combine them into nested aggs or using msearch. That's out of scope for this PR though.
* [ML] Fix http client types.
* [Alerting UI] Actions menu with mute/unmute, disable/enable sould be available for the rules with requiresAppContext
* fixed test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Drop all empty kibana calls
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tre <wayne.seymour@elastic.co>
* [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (#114806)
* fix type
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This PR further stabilizes the custom URLs tests by adding additional retries to the `create*CustomUrl` service methods.
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
* Add Eui button with i18n
* Add localStorage flag to ack the experimental message
* Handle the UI feedback
* Update the init state of useState, remove useEffect hook
* Add data-attribute for testing
* Add functional tests
* Fix test value
* get back to original tests order for o11y
* Update tests
* Update localStoreg with JSON.parse to avoid confusion
* Fix check type
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Faisal Kanout <faisal@kanout.com>
* [ML] allocated models as a table
* [ML] handle fetching stats for stopped model
* [ML] change date formatter, enable check for start and stop action, change icon
* [ML] hide stats tab when not stats are available
* [ML] update state on action
* [ML] update memory breakdown message
* [ML] fix type
* [ML] fix functional test
* [ML] render nodes as links
* [ML] fix locator types
* [ML] support node name in the URL state
* [ML] update icon
* [ML] routing state with reason tooltip
* [ML] move experimental tag
* [ML] add state column, fix import
* [ML] update stats on aciton
* [ML] refresh by timer
* [ML] rename fetchStats callback
* [ML] replace with promise.all
* [ML] add deployment state const
Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Since we've enabled auto upgrades for some packages in 7.16, we need to
revert a previous change that only considered policy validation errors
non-fatal. Any error encountered during the dry-run/upgrade process
should be considered non-fatal so that users can still access the Fleet
UI if setup fails.
Fixes#116985
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
* [Discover] Add a retry in a value suggestion non timebased test
* Dismiss popover before Discover even loads
* Set local storage value in navigateToApp
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* remove use of pdf to png conversion checker in comparison test
* remove use of pdf-to-img use in compare images service
* remove pdf-to-img dep from kibana
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
