Commit graph

5017 commits

Author SHA1 Message Date
Kibana Machine
cfcae8b6ee
[ML] Functional tests - stabilize and re-enable feature importance tests (#117503) (#117625)
This PR re-activates and stabilizes the data frame analytics feature importance tests by reducing the job run time. It also scrolls the feature importance section into view during validation so in case of a failure the screenshot shows the relevant part of the screen.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-11-05 11:34:20 +00:00
Kibana Machine
66b6d2b406
[RAC] Disable the actions button if the user has inadequate privileges (#117488) (#117624)
Disable the actions button if the user has inadequate privileges

Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
2021-11-05 11:18:46 +00:00
Kibana Machine
2562763b08
[Stack Monitoring] Logstash Functional Tests (#116481) (#116815)
* logstash overview functional test

* logstash nodes listing functional tests

* node detail tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
2021-11-04 22:22:03 +00:00
Zacqary Adam Xeper
863063f3e3
[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (#116821) (#117573)
* [Logs UI][Metrics UI] Remove deprecated config fields from APIs

* Fix typecheck

* Fix typecheck

* Fix typecheck

* Fix jest

* Fix functional test

* Remove extraneous timeField args

* Typecheck fix

* Consolidate log file changes to ResolvedLogSourceConfiguration

* Fix merge

* Revert additional logs files

* Revert inventory models

* Revert log_analysis api

* Fix timefield reference in process list

* Restore logs page files, fix typecheck on mock

* Fix functional test

* Restore inventory models index

* Fix typecheck on getFilteredMetrics

* Look CI if you don't tell me all the type errors at once I can't fix them all

* Maybe this is the last typecheck fix who knows

* Restore reading timestamp field from data view

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-04 19:59:26 +00:00
Kibana Machine
d798b739d3
Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (#114917) (#117566)
* Unskipping test

* Commenting out fix and fixing another test

* Fixing functional test

* Fixing functional test agaaaiiinn

* Fixing the actual flake

* Splitting into two tests

* Maybe this time

Co-authored-by: ymao1 <ying.mao@elastic.co>
2021-11-04 19:06:29 +00:00
Kibana Machine
6cd0dc3886
[SECURITY] Flaky api keys grid (#116991) (#117560)
* fix flaky test + adding functional test

* review + remove more jest flaky test

* fix type

* fix review/confusion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2021-11-04 18:57:19 +00:00
Kibana Machine
ee2bd97618
[Security Solutions] Replaces console logging with the correct e2e logger in the e2e tests (#116872) (#117553)
## Summary

This replaces the `console.log` we have with `ToolingLog` which is what the e2e tests want to use. Right now they're producing a lot of `console.log` debugging information and noise which we don't want. Instead we want to use the standard tool logging that e2e has for the FTR tests.

The two most important files with changes are:
* x-pack/test/detection_engine_api_integration/utils.ts 
* x-pack/test/lists_api_integration/utils.ts

From there everything else is just a repeating pattern of:

```ts
const log = getService('log');
```

And then pushing the log into the utilities:

such as:

```ts
await deleteListsIndex(supertest, log);
```

For reviewers, if you want to, checkout this branch and just ensure I didn't miss a `console.log` statement within the e2e tests anywhere. Also double check I did the correct `log.debug` vs `log.error` or if you think I misinterpreted one, point it out. I use `log.debug` where I have retries and then I use `log.error` where I thought it would be most useful to call out a very probable or unexpected statement happening when the tests begin to go sideways or have issues.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-11-04 18:23:58 +00:00
Kibana Machine
de5904f314
unskip rollup (#116567) (#117545)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2021-11-04 17:39:14 +00:00
Robert Oskamp
7fde1b0438
[8.0] [ML] Functional tests - re-activate module test suite (#117519)
This PR re-enabled the ML modules API test suite.
2021-11-04 17:42:50 +01:00
Kibana Machine
8ee2ab6e53
[Fleet] Make integration names globally unique (#115212) (#117379)
* [Fleet] Make integration names globally unique

* Fix Jest tests

* Append (copy) to names of integration packages belonging to duplicated policy

* Update current policy maintaining its name

* Fix failing tests

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
2021-11-04 16:04:26 +00:00
Tiago Costa
cbd8bef70e
skip flaky suite (#117462) 2021-11-04 13:36:15 +00:00
Tiago Costa
e7ca0c2aa8
skip flaky suite (#117404, 117403) 2021-11-04 13:30:51 +00:00
Kibana Machine
8b3f6995a1
[APM] Use synthtrace for /internal/apm/services API tests (#117083) (#117486)
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
2021-11-04 12:48:48 +00:00
Kibana Machine
83075007b1
Fix flaky test (#117372) (#117473)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
2021-11-04 10:54:12 +00:00
Kibana Machine
a4d6d8cbf5
[Security Solution][Platform] - Update rule exported counts to include total object count (#116338) (#117463)
### Summary

Addresses #116330.

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
2021-11-04 05:51:02 +00:00
Kibana Machine
3e6fe7c332
Delete legacy URL aliases when objects are deleted or unshared (#117056) (#117461)
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
2021-11-04 04:42:45 +00:00
Kibana Machine
674f32e56e
[APM] Re-enable metric-based ui (#117021) (#117459)
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-11-04 03:44:01 +00:00
Spencer
7d3d79e6a1
[8.0] [eslint] enable type-specific lint rules (#114184) (#117444)
* [eslint] enable type-specific lint rules (#114184)

* [eslint] enable type-specific lint rules

* autofix violations

* duplicate eslint-disable to new export statement

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/share/common/index.ts

* autofix more types

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-11-04 03:02:56 +00:00
Tim Sullivan
fc96462343
[Reporting/Tests] Consolidate test archives, move kbn objects to kbn_archiver (#116528) (#117440)
* remove unused

* remove kibana objects from reporting es_archives

* import objects using kibanaServer for tests

* consolidate ecommerce_kibana_spaces

* self-review

* fix nanos test

* fix loading of reporting/ecommerce_kibana_spaces

* fix csv snapshots

* fix more csv tests

* archive rename

* consolidate canvas_disallowed_url archive

* clean up snapshots

* fix CSV tests

* polish

* remove unused

* Update x-pack/test/reporting_api_integration/reporting_and_security/network_policy.ts
2021-11-04 00:11:41 +00:00
Kibana Machine
e6f52d9467
[RAC][Timeline] - Add audit log to RBAC wrapped search strategy (#112040) (#117427)
### Summary

Went back to add audit logging to the alerts table search strategy used to query RAC alerts. This PR also includes tests for the logging.

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
2021-11-03 23:19:15 +00:00
Kibana Machine
36242b2348
[Security Solution][RAC][Cases] Fix RAC "add to case" functionality from alerts table (#116768) (#117426)
* Fix add to case functionality

* Use appropriate owner when attaching an alert to a case

* Use field name constants

* Gotta reskip the test

* Better error handling

* Fix type errors

* Fix tests

Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com>
2021-11-03 22:56:02 +00:00
Kibana Machine
be4500f744
[ML] Add tests for anomaly embeddables migrations (#116520) (#117429)
* [ML] Add tests for anomaly charts embeddable migrations

* [ML] Broaden tests for anomaly swimlane as well

* [ML] Fix function rename

* [ML] Update tests to use bulk api

* [ML] Remove override

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
2021-11-03 22:37:32 +00:00
spalger
a9144b98a5 skip flaky suite (#44575)
(cherry picked from commit 3d867400d8)
2021-11-03 19:42:06 +00:00
Kibana Machine
e474a5dbd1
[QA][X Pack] Swap es archiver for kbn archiver - advanced settings (#101842) (#117361)
Drop all empty kibana calls

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tre <wayne.seymour@elastic.co>
2021-11-03 17:48:21 +00:00
Kibana Machine
affd312c59
[QA][X Pack] Swap es archiver for kbn archiver - APM specs (#102102) (#117357)
Drop all empty kibana calls

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tre <wayne.seymour@elastic.co>
2021-11-03 17:46:54 +00:00
Kibana Machine
40703421d6
Migrate es_archives/lens/basic/ to kbnArchiver (#108120) (#117345)
Co-authored-by: Bhavya RM <bhavya@elastic.co>
2021-11-03 17:26:26 +00:00
Tiago Costa
999d00d19f
skip flaky suite (#83824) 2021-11-03 15:14:09 +00:00
Søren Louv-Jansen
aac519fee3
[8.0] Add API tests for dependencies metadata (#116648) | Add API tests for top dependencies (#116788) | [APM] Adding api tests for error group (#116771) | [APM] Synthtrace ES Client (#116770) | Revert "[APM] Adding api tests for error grou (#117257)
* Add API tests for dependencies metadata (#116648)

* Add API tests for dependencies metadata

* Rename metadata tests to event metadata

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>

* Add API tests for top dependencies (#116788)

* Add top dependencies API tests

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

* [APM] Adding api tests for error group (#116771)

* adding api tests for error group

* addresing pr changes

* [APM] Synthtrace ES Client (#116770)

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

* Revert "[APM] Adding api tests for error group (#116771)"

This reverts commit f2402cef37.

* [APM] Apm errors api tests (#116764)

* changes after review

* move file to errors folder

* [APM] Fixing synthtrace import location (#117017)

Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
2021-11-03 08:09:18 +00:00
Tim Sullivan
32cecc867e
[Reporting] Log TM health and drift stats prior to reporting tests (#117013) (#117247)
* [Reporting] Log TM health and drift stats prior to reporting tests

Closes https://github.com/elastic/kibana/issues/114946

* re-skip flaky test

* rename method
2021-11-03 01:33:06 +00:00
Kibana Machine
aadb238577
Fix reporting api tests for cloud (#116515) (#117231)
* Fix reporting api tests for cloud

* Add default value

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: liza-mae <liza-mae@users.noreply.github.com>
2021-11-02 22:31:23 +00:00
Tim Sullivan
3652661104
[Reporting] Stabilize ILM test for Cloud (#117003) (#117211)
Closes https://github.com/elastic/kibana/issues/109456
2021-11-02 21:20:52 +00:00
Kibana Machine
9b7cdd9920
[Maps] fix unable to pluck style meta from local data for geo_grid ve… (#117033) (#117154)
* [Maps] fix unable to pluck style meta from local data for geo_grid vector tiles for any property other then count

* use metric instead of field value to be more precise

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
2021-11-02 19:45:24 +00:00
Cauê Marcondes
3d548802ed
[APM] Error distribution chart comparison label and layout fix (#117004) (#117189)
* fixing bucket size when no data available

* fixing layout

* removing import

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 19:15:35 +00:00
Tyler Smalley
c2530426b8 skip flaky suite (#116058) 2021-11-02 12:01:34 -07:00
Kibana Machine
52065a0439
[RAC] Updates Alerts table cell actions (#116446) (#117179)
* Adds Filter Out button to alert table cell flyout

* Adds translations

* Fixes capitalization of labels

* Removes unused declarations and imports

* Fixes and adds functional tests for Alerts table action buttons

* Addresses review comments

* Fixes Alert table cell actions functional tests

* Removes Filter out action for now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Claudio Procida <claudio.procida@gmail.com>
2021-11-02 18:42:53 +00:00
Kibana Machine
190d5d544e
retry chart selection (#116580) (#117167)
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2021-11-02 18:17:20 +00:00
Kibana Machine
f97ade20c5
[8.0] [Fleet] cypress setup (#113106) (#117138)
* [Fleet] cypress setup (#113106)

* added cypress setup for fleet

* updated readme

* fixed types

* fix unused

* starting up fleet server in cypress

* added more fleet tests

* added package update test

* updated readme

* trying jenkins run

* trying jenkins run

* trying jenkins run

* fix types, cypress config

* example of mocked requests

* added getBySel

* fix test after refactor

* removed duplication

* fix tests

* added to buildkite

* updated tests

* starting agent with docker

* trying to fix ip address

* ifconfig

* ip address

* ip address

* ip address

* type fix

* remove extra logging

* fixed test

* fix buildkite

* cleanup

* cleanup

* using docker for fleet_server

* fix

* fix

* trying to fix

* update config

* test

* test

* test

* test

* revert changes

* test

* test

* static ip on linux

* docker version

* try again

* fixed review comments

* fixed types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

* using 8.0.0 docker image for backport

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: Julia Bardi <julia.bardi@elastic.co>
2021-11-02 17:40:17 +00:00
Kibana Machine
a6e53d80f5
[Security Solutions] end to end tests, adds more console logging, removes 200 expect statements (#116987) (#117141)
## Summary

e2e tests are still seeing flake with conflicts and it looks like it _might_ be with querying and not with inserting data. Hard to tell. This PR:

* Adds more console logging when the response is not a 200
* Removes the 200 expect statement and hopes for the best but should blow up if it's not 200 in a different way and we will get the console logging statements.
* Fixes one other flake with the matrix histogram having different counts. We have encountered this before and are applying the same fix which is to just have it check > 0.
* This does fix the timeouts seen where 1 in every 1k rule runs, a rule will not fire until _after_ the 5 minute mark. The timeouts were seen when running the flake runner.


Flake failures around `conflict`:
https://github.com/elastic/kibana/issues/116926
https://github.com/elastic/kibana/issues/116904
https://github.com/elastic/kibana/issues/116231

Not saying this is going to fix those yet, but it's the last 200 ok's we did an expect on, so it might if we are ignoring the conflict. If it fails again I am hopeful beyond hope that we get the body message and line number within the utilities to determine where/why we are getting these from time to time. It does look to fix the timeouts when a rule misfires and slows down the rate at which we continuously query for rule results.

Failure around matrix histogram (The error messages are slightly different on CI each time):
https://github.com/elastic/kibana/issues/97365

Ran this with the flake runner across groups 11 and 12 100 times each and did not see the conflict crop up:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/128
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/129

The 1 failure in each of those runs were due to something on startup that prevented it from running.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-11-02 16:28:13 +00:00
Kibana Machine
850dcc7212
[Global Nav] Moved Overview page/link to the accordion/Solution title (#114018) (#117137)
* [Global Nav] Moved Overview page/link to the accordion/Solution title
* Using Cloud logo for deployment link and fixing isActive state
* Change Deployment section to dark background
* Completely remove locking ability
* Change buttonElement if overview page exists
* Snaps from button/div
* PR Feedback:
  - Puts `Overview` links back for Observability and Security
  - Increases hit area and scopes underline of anchor tag within the accordion header
  - Uses `id`’s to find Overview pages instead of `title` text

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
2021-11-02 16:13:45 +00:00
Kibana Machine
90a4c0c9e9
[APM] Api tests for Error distribution api (#116674) (#116853)
* adding tests for error distribution

* addressing pr changes

* addressing pr comments

* fixing ts issues

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-11-02 15:13:48 +00:00
Tiago Costa
e9f97d75db
skip flaky suite (#116881) 2021-11-02 13:03:08 +00:00
Tiago Costa
0ecffd9a2d
skip flaky suite (#116070) 2021-11-02 12:54:20 +00:00
Kibana Machine
9a54b3305e
[Security Solution] Fixes upgrade tests (#116425) (#117094)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
2021-11-02 12:32:27 +00:00
Kibana Machine
2f1e61860b
Replace noHits variable (#116438) (#117085)
* Replace noHits variable

* fix types

* changes after review

Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
2021-11-02 12:14:47 +00:00
Yulia Čech
8037a1db32
[ILM] Fixed skipped a11y and functional tests (#116207) (#116618)
* [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API

* [ILM] Fixed functional test by creating a snapshot repository

* [ILM] Updated the params after es client update

* [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list

* [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 11:46:48 +01:00
Kibana Machine
0a46d03f8e
[load testing] add default package to simulation class (#116375) (#116595)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
2021-11-01 19:23:19 -06:00
Kibana Machine
a3abdebfa5
[Fleet] Use event.ingested where possible for data stream last activity (#116641) (#116977)
* use event.ingested for datastream last activity

* remove ms precision from datastream dates

* add timestamp check to test

* fix type error

* split test out to be less complex and more reliable 🤞

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
2021-11-01 18:24:53 +00:00
Cauê Marcondes
cd024b41b7
[APM] Errors api test: error_groups/main_statistics (#116337) (#116681)
* use apmApiClient

* refacroting

* fixing errors groups main statistics tests

* refactoring

* fixing error group detailed stats test

* fixing ts issue

* renaming empty archiver

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 16:37:36 +00:00
Kibana Machine
a7feb289c6
[Security Solution][Endpoint] Un-skip Policy Details FTR test suite and fix bug in Policy Details page when saving changes (#115662) (#116643)
* unskip test suite
* Fix functional tests and some refactoring
* Refactor Policy Details test and centralize getting of Agent Policy combined input for endpoint
* Change approach for checking policy data in fleet pages
* Change Policy Settings displayed in Fleet to a) show a loader while retrieving settings and b) show loading errors if any
* Close any visible toasts before clicking on the save button

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
2021-11-01 14:45:16 +00:00
Kibana Machine
5cb1b27526
[ML] Functional tests - remove monitor cluster privilege from test role (#116581) (#116604)
This PR removes the `monitor` cluster privilege from the `ft_ml_ui_extras` test role as it's no longer required by the categorization wizard and we want to stay close to the minimum set of required privileges for our test users.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-11-01 11:29:25 +01:00