### Summary
Refactoring general ui service (test helpers), to a kbn package.
- Optimize methods and drop some code duplication.
### Why
- Makes the service easily available from multiple code areas.
- This is a preparation to potentially moving tests to plugins /
packages, where they would no longer be able to import thing from test
or x-pack/test but only from a package.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
This PR introduces a number of changes and improvements to saved query
management:
- Add server side pagination (5 queries per page) and search
functionality to the "Load query" list, which improves UX and
performance by no longer requesting all queries at once.
- Redesign the "Load query" list to improve the UX and a11y, making it
possible for keyboard users to effectively navigate the list and
load/delete queries.
- Add an "Active" badge to the "Load query" list to indicate which list
entry represents the currently loaded query, and hoist the entry to the
top of the first page for better visibility when no search term exists.
- Deprecate the saved query `/_all` endpoint and update it to return
only the first 100 queries instead of loading them all into memory at
once.
- Add a new `titleKeyword` field to the saved query SO, which allows
sorting queries alphabetically by title when displaying them in the
"Load query" list.
- Improve the performance of the "has saved queries" check when Unified
Search is mounted to no longer request actual queries, and instead just
request the count.
- Update the saved query duplicate title check to no longer rely on
fetching all queries at once, and instead asynchronously check for
duplicates by title on save.
- Add server side duplicate title validation to the create and update
saved query endpoints.
- Various small fixes and cleanups throughout saved query management.
43328aea-0f7b-4b7a-a5fb-e33ed822f317
Resolves#172044.
Resolves#176427.
## Testing
To generate saved queries for testing, run the script below and replace
`{KIBANA_REQUEST_COOKIE}` with the cookie header value from an API
request of a Kibana user with an active session:
```shell
for i in {1..100}; do curl 'http://localhost:5601/internal/saved_query/_create' \
-H 'Accept: */*' \
-H 'Accept-Language: en-US,en;q=0.9,az;q=0.8,es;q=0.7' \
-H 'Cache-Control: no-cache' \
-H 'Connection: keep-alive' \
-H 'Content-Type: application/json' \
-H 'Cookie: {KIBANA_REQUEST_COOKIE}' \
-H 'elastic-api-version: 1' \
-H 'kbn-build-number: 9007199254740991' \
-H 'kbn-version: 8.13.0' \
-H 'x-elastic-internal-origin: Kibana' \
--data-raw '{"title":"query '"$(echo $(($i - 1)) | tr '[0-9]' '[a-j]')"'","description":"","query":{"query":"bytes > 500","language":"kuery"},"filters":[]}' \
--compressed; done
```
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
- Closes https://github.com/elastic/kibana/issues/168825
- Closes https://github.com/elastic/kibana/issues/171610
- Closes https://github.com/elastic/kibana/issues/167427
- Partially addresses https://github.com/elastic/kibana/issues/165192
## Summary
This PR moves the total hits counter closer to the grid, updates
histogram controls and introduces new panel toggle buttons for toggling
fields sidebar and histogram.
<img width="500" alt="Screenshot 2023-12-05 at 15 37 20"
src="5b9bd771-1052-4205-849f-18c21cc299b8">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 29"
src="e5941b27-c497-4d7e-b461-68b66931475a">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 37"
src="97abd32e-9ff2-4d9a-b7e7-b9d6d9cf64db">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 50"
src="10f2b4f4-ec37-41c3-b78b-78c64e14d655">
<img width="400" alt="Screenshot 2023-12-05 at 15 37 59"
src="ef2e28b2-f6ba-4ccb-aea4-3946ba2d5839">
<img width="300" alt="Screenshot 2023-12-05 at 15 38 05"
src="07901ede-0bcb-46a6-a398-4562189fd54f">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 38"
src="17830115-2111-4b8f-ae40-7b5875c06879">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 56"
src="975d475b-280b-495a-b7b7-31c7ade5f21e">
<img width="500" alt="Screenshot 2023-12-05 at 15 43 08"
src="38b6053a-e260-48d8-9591-3f3409df2876">
## Testing
When testing, please check collapsing/expanding the fields sidebar and
histogram. Also for ES|QL mode with suggestions, legacy table, no
results and error prompt, Field Statistics tab, data views without a
time field, light/dark themes.
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
## 📓 Summary
Closes#171716
To apply a new customization that allows consumers of the
`DiscoverContainer` to apply ad-hoc flyout tabs, this work refactors and
extends the current implementation of the `DocViewsRegistry` and
enhances the `flyout` extension point providing a new instance of the
base registry for customizations to be applied. Mainly, the changes
consist of:
### DocViewsRegistry
- Add a required `id` property when adding a `DocView`. Earlier the
identifier generation was purely based on the order on the list, with
this addition we now rely on unique strings for each doc view. This `id`
is also used to store and potentially remove the doc view.
- Move the sorting step when adding a new doc view. Previously the
sorting was performed on each retrieval, moving this operation at
insertion time we can only perform this once.
- Rename `addDocView` to `add`. In the context of the `DocViewsRegistry`
this name reflects better some native API names such as Set, Map etc.
- Add the `removeById` method. It will allow when necessary to remove
any doc view that matches the passed id.
- Add the `clone` method. Since we don't want to always mutate a
registry but we still want to use it as a base, we can clone it and
generate a new instance with this method. Used for generating a new
registry used by any customization profile.
- Removed filtering by the `shouldShow` property. Apart from not having
any consumer using this option, we agreed offline that is not ideal to
perform filtering on the doc views.
### UnifiedDocViewer plugin
- The `UnifiedDocViewer`component now accepts an optional
`docViewsRegistry` property. This can either be an instance of
`DocViewsRegistry` or a function that will provide a new copy of the
default registry created and exposed by the plugin.
This is important as we don't want consumers to update the base registry
but work on a clone that applies changes only for the current usage.
When passed, this registry will be used as a docViews source for the
`UnifiedDocViewer` component.
When instead is not passed, the source will be the default registry
instance.
- The plugin contract now exposes the whole registry instance instead of
the previous `addDocView ' method. This is necessary so that consumers
can clone this registry and work on the new instance using all the
features encapsulated in the `DocViewsRegistry` implementation, like in
the case described above.
### LogExplorer customization
- We moved the customization for the flyout content into a new doc view,
which is added to the Discover UnifiedDocViewer only for this app
through a new parameter on the `flyout` extension point, the
`docViewerRegistry` function which will be forwarded to the
UnifiedDocViewer component, following the logic described earlier in
this PR.
**Example**
```ts
customizations.set({
id: 'flyout',
docViewsRegistry: (registry) => {
registry.add({
id: 'doc_view_log_overview',
title: 'Overview',
order: 0,
component: (props) => {
return <FlyoutContent {...props} />;
},
});
return registry;
},
});
```
## 🎥 Demo
894234cc-02e1-4880-949e-720f99793823
---------
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Closes#154500.
Closes https://github.com/elastic/kibana/issues/114206.
This updates the UX around cloning dashboards. I removed the clone
confirm model, so cloning a dashboard is just a one click action now.
This aligns with how other apps like ML handle cloning. I've also made
the dashboard title breadcrumb a button in edit mode that opens the
dashboard settings flyout for better discoverability.
4f5ea117-a5e4-4ec5-9113-8b09fd8c84a1
I also changed the pattern for cloned dashboard title from `Dashboard
Title Copy` to `Dashboard Title (#)`.
<img width="1226" alt="Screenshot 2023-06-30 at 1 03 35 PM"
src="b50ba5c6-dc95-4aab-a320-b1a78b74c1b6">
- Closes https://github.com/elastic/kibana/issues/147885
- Closes https://github.com/elastic/kibana/issues/157109
## Summary
**Before:**
Unified Field List plugin has internal routes (wrappers for client code)
which exist only to run api functional tests against them:
- `/api/unified_field_list/existing_fields/{dataViewId}`
- `/api/unified_field_list/field_stats`
Client code does not call these routes directly. So there is no reason
in keeping and versioning them.
**After:**
- Internal routes are removed
- A new "Unified Field List Examples" page was created
http://localhost:5601/app/unifiedFieldListExamples
- API functional tests (which used the routes) were converted to
functional tests against this new example page
- Created a new `unifiedFieldList` page object which is used now in
functional tests (methods are extracted from existing `discover` page
object).
**For testing:**
Steps:
1. Run Kibana with examples: `yarn start --run-examples`
2. Install sample data
3. And navigate to Developer Examples > Unified Field List Examples
page.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Describe the feature:
Closes https://github.com/elastic/kibana/issues/144775
This PR allows users to create more than one filter at a time. It
enhances the query builder by enabling users to create multiple filters
simultaneously. It adds the capability to nest queries and use the
logical OR operator in filter pills.
<img width="981" alt="image"
src="https://user-images.githubusercontent.com/4016496/207942022-3256590d-00f6-45c8-b566-c184d5d18953.png">
## Tasks:
- [x] Add the ability to add/edit multiple filters in one form:
- [x] Replace the current implementation of adding and editing a filter
with a filtersBuilder - `Vis-Editor`;
- [x] Add combined filter support to Data plugin (mapAndFlattenFilters)
- `App-Services`;
- [x] Add the ability to update data in the Data plugin when updating
values in the filters builder - `App-Services`;
- [x] Add hide `Edit as Query DSL` in popover case the filter inside
FiltersBuilder is combinedFilter - `App-Services`;
- [x] Update filter badge to display nested filters:
- [x] Replace the current badge filter implementation with a new one -
`Vis-Editor`;
- [x] Clean up `FilterLabel` component after replace `FIlterBadge`
component - `Vis-Editor`;
- [x] When editing filters, those filters that belong to the same filter
group should be edited - `Vis-Editor`;
- [x] Update jest and functional tests with new functionality -
`Vis-Editor`;
- [x] Fix drag and drop behavior - `Vis-Editor`;
Co-authored-by: Lukas Olson <lukas@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com>
Co-authored-by: Andrea Del Rio <andrea.delrio@elastic.co>
* [Discover] Create unifiedHistogram plugin
* [Discover] Move discover resizable panels to unifiedHistogram
* [Discover] Replace DiscoverPanels with unifiedHistogram Panels
* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'
* [Discover] Fix types and limtis.yml for unifiedHistogram
* [Discover] Begin migrating layout and chart to unified_histogram
* [Discover] Update i18n keys from discover to unifiedHistogram
* [Discover] Update data-test-subj tags from discover to unifiedHistogram
* [Discover] Update classNames, ids, and scss to change discover to unifiedHistogram
* [Discover] Remove more references to discover from unifiedHistogram
* [Discover] Replace DiscoverServices with UnifiedHistogramServices
* [Discover] Replacing CHART_HIDDEN_KEY with chartHiddenKey prop
* [Discover] Add missing tsconfig references
* [Discover] Remove remaining references to discover from unifiedHistogram
* [Discover] Migrate HitsCounter to unifiedHistogram
* [Discover] Continue removing discover dependencies from unifiedHistogram
* [Discover] Replace SCSS with emotion
* [Discover] Changing PANELS_MODE to be internal
* [Discover] Clean up types
* [Discover] Clean up props and types
* [Discover] Update layout to use Chart component
* [Discover] Update discover_main_content
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* [Discover] Update discover_main_content to use UnifiedHistogramLayout, clean up unifiedHistogram implementation and props, add missing bundles
* [Discover] Fix missing styles in unifiedHistogram
* [Discover] Fix issue where mouse can get out of sync with the resize handle with the Discover resizable layout
* [Discover] Fix some Jest tests
* [Discover] Update discoverQueryHits to unifiedHistogramQueryHits in tests
* [Discover] Finish decoupling discover_main_content from unified histogram layout
* [Discover] Create useDiscoverHistogram hook and remove old histogram dependencies from Discover
* [Discover] Move functions to create chart data from discover to unifiedHistogram
* [Discover] Continue fixing broken Jest tests
* Revert unifiedHistogram.reloadSavedSearchButton removal
* [Discover] Add missing type export and a better suspense fallback
* [Discover] Make callback names consistent
* [Discover] Continue cleanup and add documentation to unifiedHistogram
* [Discover] Update genChartAggConfigs to take object
* [Discover] Update UnifiedHistogramHitsContext.number to total
* [Discover] Cleanup imports
* [Discover] Add support for hiding the entire top panel in the unified histogram by leaving all context props undefined
* [Discover] Fix broken discover_layout unit tests
* [Discover] Clean up naming in discover_main_content
* [Discover] Continue fixing Jest tests and adding new tests
* [Discover] Finish writing Jest tests
* [Discover] Fix conflicts with getVisualizeInformation and triggerVisualizeActions after merge
* [Discover] Fix hiding reset chart height button when default chart height
* [Discover] Update CODEOWNER file
* [Discover] Removed types for @link comments
* [Discover] Fix broken discover_layout.test.tsx file
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* [Discover] Fix flaky test regarding field actions in a flyout
* [Discover] Update a11y tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Added new a11y test for index management.
Fixed a11y violations in code in index management app in the code block element.
Added new test to a11y config to run in CI.
* Removed unused reference.
* Moved navigate to initial code block.
* Fixed all nits.
* ability to set human readable title of data view & ability to edit data view
* add readable data view title to discover
* fix for failing API test
* fix and add functional tests
* add missing lens support
* update snapshots after name change
* fix for broken test and type checks
* fix condition check
* remove description, rename readableTitle to name and fixes
* revert kibana.yaml change
* fixes for failed tests
* fixes for broken tests
* fix functional tests 2
* add confirm modal for edit
* update header to match figma
* fix data views with index pattern
* fix for badge breaking in test due to index change
* remove unused translations
* comment fixes and add name to sample data
* fix test for adding names to sample data
* some ui changes
* fix for failing tests for removing Actions
* comment fixes, change edit modal, fix breadcrumbs
* change copy and fix for failing tests
* change text to have unique key
* update jest snapshots
* fixes for unified_search and some ui changes
* add test fixes and disabled editing data view id when in edit mode
* fix for translation bug
* fix for failing tests
* review comment changes
* some nit fixes
* revert the operation change check
* fixed name not showing in dashboard with visualizations from different dataviews
* added a comment for the management breadcrumb
* [Unified search] Moves dataview picker to the search bar (#126560)
* [Unified search] Moves dataview picker to the search bar
* alter texts
* Remove unused file
* [ChangeDataView] Design cleanup
* Fix services mock failure
* Show newly created datavuew on the list
* Keep dataview picker in discover in mobile view
* Cleanup
* Cleanup translations
* Fix some discover FTs
* Fix management FTs
* More test fixes
* Added a dismissible tour
* Pulled the selectabl list into a new component
… for reuse
Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead.
*Didn’t do any test updates*
* Fix broken jest test
* Use the same picker component on Discover mobile view
* Apply some CI fixes
* Fix more functional tests
* More FTs fixes
* Close the tour popover for lens tests
* More FTs fixes
* Fix lens FTs
* Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons
* Better tour text and i18n
* Update copy
* No exclamation point
* Cleanup
* Fixes on discover tests
* Fixes on Lens Fts - create runtime fields
* Fixes on edit permission of add field in discover and some FTs fixes
* Further Fts fixes
* More FTs fixes
* Made tour opt-in with `showNewMenuTour`
* Refactor the OSS FTs to change less files
* Further cleanup on the FTs
* Remove unecessary action
* Fix dataview creation bug
* Add a unit test to the new component
* More fixes
* Fix OSS a11y tests
* Adds another unit test for Lens permissions
* Make a change to stabilize the tests
* Clear flyout prop as it is not used anymore
* Deisgn fixes for mobile view
* Address PR comments WIP
* Update the layrpanl dataview list when a new dataview is created
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* fix test
* Fix CI
* Fix i18n checks
* [Unified search] Redesign search bar (#126566)
* [Unified search] Redesign search bar
* Changes to the saved queries design
* Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
* [Security Solution] Removing overrides of `.globaQueryBar`
* Cleanup of `.globalQueryBar` styles and variants
* General layout fixes/adjustments
* More general layout fixes and better defaults
* Enable Clear all button if saved query is applied
* Clear should be enabled if searched query is applied but not the save as new
* fix some bugs on enabling and disabling the menu options
* [design] Working on Load Filter set menu
* Indicate selection even before the user clicks apply
* prettify the time text
* Add delete saved qquery confirmation modal
* Some cleaning up
* Fix the manage saved queries link
* Enable load filter set if saved query is created for the first time
* Some fixes on linting and on translations
* Clanup scss
* Make some fixes
* Fix navigatation unit test
* Fix translations check
* Fix rest jest tests
* Fix some functional tests
* Fix checks
* Fixes the appearance of the searchbar components depending on the flags
* Fix OSS tests
* Fixes on tests and query bar logic
* Fix the OSS ally tests
* Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
* Fix more tests
* Fix security solution test
* Undo tweaks for graph
* Better fix for Graph
- Emulate new look, not old
- Uses same context menu panel as the new one
- Provides the same button type (filter button)
* Fix checks and jest test
* Further fixes
* Fix language switcher test
* Hopefully fixes the rest of the solution tests
* Cleanup
* Fixes on maps filtering
* Fix Discover padding
* [Discover] Added New Field button to bottom of fields list
* Simple responsive behavior
* Quick filter updates
* CI fixes
* area-label fix
* 18n translate the add filed btn in discover
* Fix lens functional test
* fix functional tests
* Refactor and add unit test for the add filter button
* Add unit test to the saved management list component
* Stabilize lens test
* Second try to solve the flakiness
* Fix panels depending on the flags
* Fix jest tests
* Fix double menu when only the queryInput is on
* Add storybook for the different layouts of the unified search bar
* Fix ci checks
* Removee hooks comment
* Fix flakiness
* Fix problem with lens dataview change
* Fix checks
* Ensure that the query is submitted
* Fixes oon CI
* Fixes flakiness
* Fix checks CI
* Update texts
* Cleanup
* Fix unskipped funtional test
* Fix FT
* Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Fix eslint
* Fix checks
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Fix jest
* Fix jest tests
* Stabilize discover security tests
* [Unified search] Further enhancements (#129877)
* [Unified search] Redesign search bar
* Changes to the saved queries design
* Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
* [Security Solution] Removing overrides of `.globaQueryBar`
* Cleanup of `.globalQueryBar` styles and variants
* General layout fixes/adjustments
* More general layout fixes and better defaults
* Enable Clear all button if saved query is applied
* Clear should be enabled if searched query is applied but not the save as new
* fix some bugs on enabling and disabling the menu options
* [design] Working on Load Filter set menu
* Indicate selection even before the user clicks apply
* prettify the time text
* Add delete saved qquery confirmation modal
* Some cleaning up
* Fix the manage saved queries link
* Enable load filter set if saved query is created for the first time
* Some fixes on linting and on translations
* Clanup scss
* Make some fixes
* Fix navigatation unit test
* Fix translations check
* Fix rest jest tests
* Fix some functional tests
* Fix checks
* Fixes the appearance of the searchbar components depending on the flags
* Fix OSS tests
* Fixes on tests and query bar logic
* Fix the OSS ally tests
* Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
* Fix more tests
* Fix security solution test
* Undo tweaks for graph
* Better fix for Graph
- Emulate new look, not old
- Uses same context menu panel as the new one
- Provides the same button type (filter button)
* Fix checks and jest test
* Further fixes
* Fix language switcher test
* Hopefully fixes the rest of the solution tests
* Cleanup
* Fixes on maps filtering
* Fix Discover padding
* [Discover] Added New Field button to bottom of fields list
* Simple responsive behavior
* Quick filter updates
* CI fixes
* area-label fix
* 18n translate the add filed btn in discover
* Fix lens functional test
* fix functional tests
* Refactor and add unit test for the add filter button
* Add unit test to the saved management list component
* Stabilize lens test
* Second try to solve the flakiness
* Fix panels depending on the flags
* Fix jest tests
* Fix double menu when only the queryInput is on
* Add storybook for the different layouts of the unified search bar
* Fix ci checks
* Removee hooks comment
* Fix flakiness
* Fix problem with lens dataview change
* Fix checks
* Ensure that the query is submitted
* Fixes oon CI
* Fixes flakiness
* Fix checks CI
* Update texts
* Cleanup
* Fix unskipped funtional test
* Fix FT
* Fixes filter bar responsiveness
* Add filter button option to the main menu
* Filter form design pass
- Added tooltip around “Add filter” icon button
- Fixed padding
- Stubbed in “Add” vs “Edit” labels
* Query menu icon button tooltip
* ‘Update’ not ‘Edit’ button label
* Apply different strings for adding filter mode vs edit
* Hide Manage SO link if the user donesnt have the permissions
* Fix the wrapping of the badges and datepicker badge
* Minor props naming fix
* Fix checks
* Fix mobile
* Cleanup
* Fix checks
* Faux button group
* Changes on the search input placeholder
* Fix CI
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* Fix translations
* Fix security solution add filter bug
* Filter bar / items: Reduce to only necessary wrappers and styles
- Switch to Emotion for styling
- Rename `FilterBadgesWrapper` to `FilterItems`
- Move `FilterItems` and `FilterItem` so own folder `filter_item/`
# Conflicts:
# src/plugins/unified_search/public/filter_bar/filter_bar.tsx
# src/plugins/unified_search/public/filter_bar/filter_editor/lib/filter_label.tsx
# src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx
# src/plugins/unified_search/public/filter_bar/filter_item/filter_items.tsx
# src/plugins/unified_search/public/filter_bar/filter_view/index.tsx
# src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx
# src/plugins/unified_search/public/search_bar/search_bar.tsx
* Fix styles by removing styled-components
Also added prop `afterQueryBar` to signify that it needs the top margin
# Conflicts:
# packages/kbn-babel-preset/styled_components_files.js
* Refactor `SearchBar` and `QueryBarTopRow` a bit
- Added `showSubmitButton` to explicitely hide the submit button (defaults to true)
- SearchBar always renders the `QueryBarTopRow` which now fully controls visibility of the pieces
- Renamed class with new `uni` prefix
- Tried and failed to use Emotion
* Update usages
# Conflicts:
# x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx
* Fix a test
* Fix jest test
* Attaches filter menu when no add button and better dropdown styles
* Fix lint errors
* Clearing the query and filters of a saved query should unload the saved query
* Do not allow to update the loaded saved query if no filters or no query
* Fix Graph by creating reusable `KibanaFilterButtonGroup`
* Use EuiTheme for SearchBar styles
Updated `displayStyle` for Lens & Discover
* Fix displayStyle prop problem
* Correct alignment of data visualizer
* Super nit comment
* Data visualizer improvements
* Apply useMemo in editPermission cont in Discover
* Fix translations checks
* Fix translations checks
* Fix filter badge popover bug
* [Submit button] Changed to EuiSuperUpdateButton
- Quickly adds tooltip content and filled state for more prominence when dirty
- Fixed 18n
* Fix tests
* Align the position with the other tolltips and check that functional tests succeed
* Give some time to the tooltip to disappear
* Fix tests
* Fix CI checks
* Address PR comments
* Move constants outside render
* Apply PR comments
* Fix dataview picker glich
* lovercase emotion function
* Fix a11y problem on dataview picker
* Lowercase rest of emotion style functions
* Clean up
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Call setup on fleet start, remove API calls
* Fix unused import
* Revert removal of setup API call
* Restructor fleetSetupCompleted promise
* Add logging + handle setup failures
* Restructure logging to mix of debug/info
* Maybe fix failing tests
* Try fixing tests again
* Fix another dashboard test
* Re-add output logs after merge
* Log non-fatal errors during Fleet setup on boot
* Don't rely on fleetSetupCompleted to be called
* Fix failing test
* Track fleet setup status to avoid double calls
* Use IIFE in place of Promise ctor
* Remove unnecessary fleetSetupStatus value
* Move non-error logs into setupFleet method
* Remove unused formatNonFatalErrors import
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* test if 2s sleep fixes flakey test
* switch from sleep to retry.waitFor
* remove .only, add comments to config file about sample data add/remove
* refactor a11y tests for sample data load
* refactor a11y tests for sample data load
* cleanup comments
* cleanup comments
* fix eslint errors
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* test if 2s sleep fixes flakey test
* switch from sleep to retry.waitFor
* remove .only, add comments to config file about sample data add/remove
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Sample data] Use Lens in flights sample data
* Fix test issues
* Fix functional tests
* Fix a11y test names
* Fix tests again
* Fix test
* Update from comments
* Fix sizing from feedback
* Fix typo
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Now the new EuiDataGrid based document table is the default
* Columns can be sorted by drag and drop
* Column width can be changed by drag and drop
* There's a fullscreen mode
* There's document selection
* There's document navigation in the flyover of a expanded document
* Sorting is much more user friendly, less confusing and sort order can be changed by drag and drop
* Revert "Revert "Migrations v2: don't auto-create indices + FTR/esArchiver support (#85778)""
This reverts commit f97958043f.
* Fix flaky saved objects management test #89953
* If a clone target exists, wait for yellow, not green, index status
* Fix test after master merge
* Fix types
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
