# Backport
This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Fix project view breadcrumbs
(#196281)](https://github.com/elastic/kibana/pull/196281)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-10-16T07:05:49Z","message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset
Quality] Fix project view
breadcrumbs","number":196281,"url":"https://github.com/elastic/kibana/pull/196281","mergeCommit":{"message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196281","number":196281,"mergeCommit":{"message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0"}}]}]
BACKPORT-->
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Introduce Kibana Management Feature
(#194825)](https://github.com/elastic/kibana/pull/194825)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2024-10-15T09:40:09Z","message":"[Dataset
Quality] Introduce Kibana Management Feature (#194825)\n\ncloses
[#3874](https://github.com/elastic/observability-dev/issues/3874)\r\n\r\n\r\n##
📝 Summary\r\n\r\nThis PR adds new kibana privilege feature to control
access to `Data Set\r\nQuality` page under Stack Management's `Data`
section.\r\n\r\nHad to fix a lot of tests since the `kibana_admin` role
gets access by\r\ndefault to all kibana features one of which now is the
`Data Set\r\nQuality` page. At the same time this made the `Data`
section visible to\r\nany user with `kibana_admin` role.\r\n\r\n## 🎥
Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ce8c8110-f6f4-44b8-a4e7-5f2dd3deda66\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b93d3c224aeae33fa59482094c9927f0358c6ec8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","Team:ML","Team:EnterpriseSearch","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset
Quality] Introduce Kibana Management
Feature","number":194825,"url":"https://github.com/elastic/kibana/pull/194825","mergeCommit":{"message":"[Dataset
Quality] Introduce Kibana Management Feature (#194825)\n\ncloses
[#3874](https://github.com/elastic/observability-dev/issues/3874)\r\n\r\n\r\n##
📝 Summary\r\n\r\nThis PR adds new kibana privilege feature to control
access to `Data Set\r\nQuality` page under Stack Management's `Data`
section.\r\n\r\nHad to fix a lot of tests since the `kibana_admin` role
gets access by\r\ndefault to all kibana features one of which now is the
`Data Set\r\nQuality` page. At the same time this made the `Data`
section visible to\r\nany user with `kibana_admin` role.\r\n\r\n## 🎥
Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ce8c8110-f6f4-44b8-a4e7-5f2dd3deda66\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b93d3c224aeae33fa59482094c9927f0358c6ec8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194825","number":194825,"mergeCommit":{"message":"[Dataset
Quality] Introduce Kibana Management Feature (#194825)\n\ncloses
[#3874](https://github.com/elastic/observability-dev/issues/3874)\r\n\r\n\r\n##
📝 Summary\r\n\r\nThis PR adds new kibana privilege feature to control
access to `Data Set\r\nQuality` page under Stack Management's `Data`
section.\r\n\r\nHad to fix a lot of tests since the `kibana_admin` role
gets access by\r\ndefault to all kibana features one of which now is the
`Data Set\r\nQuality` page. At the same time this made the `Data`
section visible to\r\nany user with `kibana_admin` role.\r\n\r\n## 🎥
Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ce8c8110-f6f4-44b8-a4e7-5f2dd3deda66\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b93d3c224aeae33fa59482094c9927f0358c6ec8"}}]}]
BACKPORT-->
Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Implement _ignored root cause identification flow
(#192370)](https://github.com/elastic/kibana/pull/192370)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Achyut
Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2024-10-04T07:41:55Z","message":"[Dataset
Quality] Implement _ignored root cause identification flow
(#192370)\n\n## Summary\r\n\r\nCloses -
https://github.com/elastic/kibana/issues/192471\r\nCloses -
https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds
Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page
where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n##
Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API
modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test
this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for
serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout
192370`\r\n\r\n1. Start the FTR server using the command
below\r\n\r\n```\r\n yarn test:ftr:server --config
./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n
2. Go to the following path -
`x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n
3. Comment out the 2 `after` blocks present at Line - 54-56 and
414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n
```\r\nyarn test:ftr:runner --config
./x-pack/test/functional/apps/dataset_quality/config.ts --include
./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet
the test run and go green\r\n\r\n5. Navigate to
`http://localhost:5620/app/management/data/data_quality/`\r\nusername -
`test_user` and password - `changeme`\r\n\r\n6. Select the
`degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready
to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field
Limit and Ignore above isse\r\n\r\n\r\n\r\n##
Warning about not current quality issue\r\n\r\n\r\n\r\n##
Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which
becomes a blocker\r\nfor merging this
PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","release_note:feature","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature:Dataset
Health"],"title":"[Dataset Quality] Implement _ignored root cause
identification
flow","number":192370,"url":"https://github.com/elastic/kibana/pull/192370","mergeCommit":{"message":"[Dataset
Quality] Implement _ignored root cause identification flow
(#192370)\n\n## Summary\r\n\r\nCloses -
https://github.com/elastic/kibana/issues/192471\r\nCloses -
https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds
Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page
where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n##
Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API
modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test
this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for
serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout
192370`\r\n\r\n1. Start the FTR server using the command
below\r\n\r\n```\r\n yarn test:ftr:server --config
./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n
2. Go to the following path -
`x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n
3. Comment out the 2 `after` blocks present at Line - 54-56 and
414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n
```\r\nyarn test:ftr:runner --config
./x-pack/test/functional/apps/dataset_quality/config.ts --include
./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet
the test run and go green\r\n\r\n5. Navigate to
`http://localhost:5620/app/management/data/data_quality/`\r\nusername -
`test_user` and password - `changeme`\r\n\r\n6. Select the
`degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready
to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field
Limit and Ignore above isse\r\n\r\n\r\n\r\n##
Warning about not current quality issue\r\n\r\n\r\n\r\n##
Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which
becomes a blocker\r\nfor merging this
PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192370","number":192370,"mergeCommit":{"message":"[Dataset
Quality] Implement _ignored root cause identification flow
(#192370)\n\n## Summary\r\n\r\nCloses -
https://github.com/elastic/kibana/issues/192471\r\nCloses -
https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds
Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page
where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n##
Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API
modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test
this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for
serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout
192370`\r\n\r\n1. Start the FTR server using the command
below\r\n\r\n```\r\n yarn test:ftr:server --config
./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n
2. Go to the following path -
`x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n
3. Comment out the 2 `after` blocks present at Line - 54-56 and
414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n
```\r\nyarn test:ftr:runner --config
./x-pack/test/functional/apps/dataset_quality/config.ts --include
./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet
the test run and go green\r\n\r\n5. Navigate to
`http://localhost:5620/app/management/data/data_quality/`\r\nusername -
`test_user` and password - `changeme`\r\n\r\n6. Select the
`degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready
to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field
Limit and Ignore above isse\r\n\r\n\r\n\r\n##
Warning about not current quality issue\r\n\r\n\r\n\r\n##
Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which
becomes a blocker\r\nfor merging this
PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd"}}]}]
BACKPORT-->
Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
## Summary
Closes - https://github.com/elastic/kibana/issues/190328
Delivered as part of this PR
- [x] Added a new Degraded Field Flyout with a basic List of data point
for the degraded Field
- [x] A new endpoint to display possible values. This endpoint will
query to get the latest values, maximum 4
- [x] URL supports Flyout state
- [x] API Tests for the new endpoint
- [x] E2E tests for the flyout
## Screenshot
<img width="1903" alt="image"
src="https://github.com/user-attachments/assets/9bc20d15-d52b-4d1e-827f-ab1444e27128">
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes https://github.com/elastic/observability-dev/issues/3454.
This PR enables Dataset quality for being used for `traces` and
`metrics`.
### Changes
- Added `KNOWN_TYPES` array containing the types that we allow in
dataset quality page.
- `datasets`, `degradedDocs` and `nonAggregatableDatasets` are now
wrapped in an state. This allow us to retrigger the calls whenever we
need to do it (e.g. when changing timeframe), more importantly now
whenever we select a new type of dataset.
- The `invoke` `degradedDocs` is created dynamically depending on the
types present in `KNOWN_TYPES`.
- `GET /internal/dataset_quality/data_streams/stats` and `GET
/internal/dataset_quality/data_streams/non_aggregatable` now accept an
array of `DataStreamType`. This allow us to query the information for
multiple types of dataStreams at the same time.
- degradedDocs are stored now locally as a nested structure. This nested
structure allow us to update just the needed portion instead of updating
all datasets whenever a change occurs (e.g. a type is deselected).
- redirectLink now takes into account the datastream type, it only
redirects to logs explorer if it's enabled and the type of the
datastream is logs.
### 🎥 Demo
https://github.com/user-attachments/assets/082bd4e9-a8f8-4af9-a425-267adc3b30df
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
closes https://github.com/elastic/kibana/issues/184572
After the merge of the 1st
[PR](https://github.com/elastic/kibana/pull/189532) around Flyout
migration, this PR covers the remaining bits.
- [x] Adding same telemetry to the page which was present in the flyout
- [x] Create a Locator and use it in the Table to connect the main page
with Details page
- [x] Update locator in Unified Doc Viewer
- [x] Migrate all kind of tests which were present for flyout to the
page
- [x] Remove everything which was once called Dataset Quality Flyout.
- [x] Make build green - Yellow is also acceptable
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Relates to - https://github.com/elastic/kibana/issues/184572
Figma Design -
https://www.figma.com/design/8WVWLeVn8mvoUm0VGgbSbB/Data-set-quality-V2?node-id=3564-73485&t=KADTdNFiiOBJ7rOS-0
**NOTE: This PR is part of a multi series PRs. Hence expect it to not do
everything.**
### What are we going to do?
1. The content of the flyout, henceforth will be known as Dataset
Quality Details is being copied to a component with the same name.
2. This component can be initialised as page, like in Management app or
used as an individual component in a flyout in Unified Doc Viewer for
example. As scope of this PR, a page in Management app has been created
which will load this detailed component. A new route will be created
with breadcrumb.
3. This page will co-live with the Flyout for now, accessible only via
direct URL. In subsequent PR, when we remove the Flyout completely, we
will change the action in Dataset Quality to instead of opening a Flyout
to navigating to this new page.
### What's in this PR ?
1. As part of this change, i have created a complete new State Machine,
Controller for Dataset Quality Details component which is responsible
for replicating the Flyout.
2. A dedicated route registered under `/details` where this component
will live at the moment. Sample URL will look like this
`http://localhost:5601/pfd/app/management/data/data_quality/details?pageState=(dataStream:logs-synth.1-default,v:1)`
3. The individual components which currently load inside the flyout may
be duplicated for time being.
4. Validation when no data stream provided.
5. Breadcrumb for the Management page
### What's not in this PR
1. Tests needs to be migrated, they will be done as part of the Next PR
2. Telemetry for Flyout has been removed. It will be added as part of
next PR.
3. Existing Flyout code has not be removed. That needs to be removed and
the old state machine needs to be meticulously cleaned.
6. Swapping the Click to Open Flyout to Page needs to be done when the
above 3 are ready.
## Screenshot
### Good scenario
<img width="1482" alt="image"
src="https://github.com/user-attachments/assets/4409eb57-89d5-477c-a946-1b7a45df074c">
### When datastream does not exist
<img width="1527" alt="image"
src="https://github.com/user-attachments/assets/66d735aa-8f0f-4fb8-b57c-4d22cecad2c7">
### When invalid state is provided by the page, it redirects to parent
Dataset Quality Page
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This PR aims to improve `context.page_name` within stack telemetry.
After the changes we will start seeing information about dataset quality
in `application:management:data_quality` rather than just a generic
pageName such as `application:management`.
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/d172353a-824d-46f7-8d5e-7c564375827a">
## Summary
Fix https://github.com/elastic/kibana/issues/65999
Change the `features` plugin's contract type names to follow our naming
convensions and to avoid needing to rename them during imports
(and yeah, I'm triggering a review from 30 teams again for a type
rename, just for the fun of it)
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Closes - https://github.com/elastic/kibana/issues/172272
The PR adds the degraded Field Table in the Logs Flyout. The accordion
is kept closed by default. For demo purposes below screenshot will show
it expanded
This PR will also fix a very simply Flaky Test -
https://github.com/elastic/kibana/issues/186244
## Pending Items
- [x] Add Locator for Dataset Quality Page
- [x] Add tests
## Demo
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
I modified the [current dashboard in
staging](f240fff6-fac9-491b-81d1-ac39006c5c94?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15h,to:now)))
and now the metrics of Dataset quality are being reported.
<img width="2111" alt="image"
src="db073190-9a2b-43f1-a2ac-4ad61b740582">
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Add links to Dataset Quality in the following places:
1. "Data sets" link on Logs Explorer nav header (on both Serverless and
Stateful)
2. "Data Set Quality" side nav menu item under Stack Management -> Data
(Stateful)
3. "Data Set Quality" card under Management -> Data (Serverless)
On Logs Explorer - Stateful
On Logs Explorer - Serverless
Stack Management - Stateful
Stack Management - Serverless
---------
Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
The PR changes the app's title from "Datasets" to "Data Set Quality".
Note that the changed title "Data Set Quality" will also be used as a
side nav menu item under Stack Management (in followups). The PR also
adds an app description as suggested in the parent issue.
The link leads to Doc's ECS page: [Data Stream
Fields](https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html).
The PR also changes the breadcrumb and quick search entry to use "Data
Set Quality" instead of "Data quality" or "Logs data quality".
As per the [writing style
guidelines](https://brand.elastic.co/302f66895/p/194a3b-writing-style-guide/t/889c93),
any instance of "Dataest" is changed to either "Data Set" or "Data set".
Closes https://github.com/elastic/kibana/issues/183406
## 📝 Summary
This PR adds a basic locator to dataQuality plugin, where timeRange
filters can be shared
## 🎥 Demo
47dabe6f-fe89-4075-8688-1e53332cdd9a
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
As part of registering the new `Data quality` plugin in `Management >
Data` a new item was added to the global search.
<img width="1977" alt="image"
src="165cc75b-3727-4b1f-b625-ab81dfb8b58a">
This PR aims to improve the findability adding more keywords.
When moving dataset-quality instance from Observability Logs Explorer to
Stack Management > Data I left out triggering the flyout event whenever
flyout information is defined in the URL.
This PR contains a fix for the aforementioned and a change in the copy
of the DegradedDocs Improvements tooltip
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Relates to https://github.com/elastic/kibana/issues/183406.
## 📝 Summary
This PR creates a new plugin `data_quality` in order to register dataset
quality as a Stack management page under data section. For now there is
no reference to this new page in the sideNav in stateful or serverless.
In order to navigate to this new page you can use the url
`/app/management/data/data_quality`
Changes included in this PR:
- New plugin created
- Plugin registered in stack management, data section
- Dataset quality plugin is instantiated and the state is in sync with
URL
- Removed references to dataset quality in Logs explorer
## 🎥 Demo
501c9c47-4a1b-4f91-9be6-d022a821e88e
## 🙅🏼 Missing
- Dataset quality locator
- There are still references to logs explorer (table and flyout) that
will be handled in a follow up PR.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
