Commit graph

21368 commits

Author SHA1 Message Date
Pete Harverson
2462884636
[ML] Use EUI table getRowProps for anomalies table row mouseover (#19755) 2018-06-08 13:24:22 +01:00
Tim Sullivan
cbd319f92c
[Monitoring] Fix Node Advanced page (#19740)
* [Monitoring] Fix Node Advanced page

* fix metrics snapshot
2018-06-07 17:05:43 -07:00
Bill McConaghy
831b9f83fd
Console cleanup (#19654)
* refactoring to class style and moving components to own files

* making top level components fetch sensitive to HTTP verb

* fixing issue with _ endpoints getting mistaken as index names for autocomplete possibilities:wq:

* removing stray console log

* removing console log

* PR feedback

* accounting for _all in isNotAnIndexName
2018-06-06 12:00:05 -04:00
James Gowdy
aba92631a3
[ML] Removing unnecessary sr-only span (#19697) 2018-06-06 13:02:10 +01:00
Stacey Gammon
c639deba73
Move all reporting tests into their own folder and add chromium tests (#19330)
* Move all reporting tests into their own folder to allow for multiple kibana.yml configuration tests, including chromium

* Add debugging and try to skip other tests an jenkins to speed things up

* More debug output

* more logging (remove other line which failed on jenkins)

* Remove no sandbox flag, it doesn't help

* Add fix for socket hangup and clean up tests

* fix path to logstash_functional

* Extend timeout for chromium, add verbose logging, add better comment, conditionally output curl command

* fix path... again

* Ah, other functional tests still need access to reporting page object, put it back

* fix sp err

* Add debug logs for screenshot stitching for png.bitblt error

* Fix tests that don't pass logger to screenshotStitcher

* Fix logger being undefined

* Add more debug output

* png has data, too much info to spit out

* Add comment with link to issue for extra debug messages so they can be left in since so many passes

* Dont use spawnSync with curl, use http.request instead, more support for it

* Comment out chromium tests for now to avoid flakiness

* Wait... lets at least make sure the other fix worked (the http.request instead of spawnsync and curl)

* New http.request code doesn't seem to work on jenkins, timing out after 10 secs maybe

* go back to spawnsync to see if it's an issue with the rxjs code or the http.request code

* I think I figured it out...

* Comment out tests to avoid flaky png error in the screenshot stitcher

* Use a const for OSS archive path

* use path.resolve correctly.
2018-06-05 18:41:23 -04:00
Stacey Gammon
2a715b0034
updateUrl is on scope, not this. (#19687) 2018-06-05 18:40:40 -04:00
Tim Sullivan
1617da93dd
[X-Pack Usage API] use authentication from request headers (#19613)
* [X-Pack Usage API] use authentication from request headers

* add test for usage api no-auth

* whitespace / syntax nits

* reduce loc changed

* remove a weird looking comment
2018-06-05 10:38:02 -07:00
Justin Kambic
194e427bc8
Remove dirty prompt from Logstash Pipeline Management (#19649)
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue.

* Remove test for removed feature.
2018-06-05 12:30:11 -04:00
Søren Louv-Jansen
a4285916dd
[APM] Fix debug param issue (#19676)
* [APM] Fix debug param issue

* [APM] Fix _debug issue and add test
2018-06-05 17:56:01 +02:00
Brandon Kobel
c533ac91fe
SavedObjects service and client provider (#19349)
* Renaming client to service

* Implementing the SavedObjects service and client provider

* Making saved objects service lazy instantiated so the test server works

* Fixing import

* Fixing another import

* Fixing reporting's usage of the savedObjectsClientFactory

* No longer passing the callCluster function to the kbnTestServer

* Passing empty request...

* Fixing reporting

* Exposing server.savedObjects without a getter

This required me to remove the kbnTestServer.createServer() method and
change all usages to createServerWithCorePlugins since we're reading the
kibana.index, which is part of the core plugins, when configuring the
saved objects service which is attached to the server.

* Don't need to set kibana.index

* Changing more usages of kbnTestServer.createServer

* Revert "Changing more usages of kbnTestServer.createServer"

This reverts commit 464f73abb2.

* Partially reverting 17d36b3e9a

* Fixing headers

* Improving tests

* Addressing some peer review feedback

* Addressing more peer review feedback

* Adding server.log warning when the saved objects can't initialize

* Getting rid of the savedObjectsClientFactory

* Branches are for trees

* Fixing comment to be proper english

* Fixing fat-fingering method call

* Fixing other usages of getScopedSavedObjectsClient
2018-06-04 17:02:25 -04:00
Søren Louv-Jansen
a8fc3fc94a
[APM] Fix missing _debug validator (#19639) 2018-06-03 22:43:29 +02:00
Chris Roberson
9ce082b1f4
Disable the dirty prompt until #19594 is resolved (#19595) 2018-06-01 08:58:43 -04:00
Tim Sullivan
a801752e79
[Reporting/Usage] Check monitoring enabled before registering collector (#19581) 2018-05-31 15:18:02 -07:00
Søren Louv-Jansen
a1f345e446
[APM] Add debug option (#19587) 2018-05-31 16:55:41 +02:00
Stacey Gammon
8d1629a7a6
It's confusing to see the timestamp of started_at if the status says "completed" (#19551)
fixes https://github.com/elastic/kibana/issues/17912
2018-05-30 19:37:32 -04:00
Court Ewing
ac9ed89d6f
license: do not parse expiry date if it does not exist (#19565)
Basic licenses never expire, so they do not have an expiration date at
all according to the Elasticsearch API. When this happens, we should not
attempt to parse the date nor show the expiry date in the log.
2018-05-30 15:25:55 -04:00
Bill McConaghy
7dd14fa480
fixing basic license revert on Firefox (#19566) 2018-05-30 14:37:09 -04:00
Tim Sullivan
1b6c5b1c6c
[Monitoring] use defaulValue instead of filter to make pre-filled text input editable (#19462) 2018-05-29 16:30:43 -07:00
Tim Sullivan
6760a64c3d
[Monitoring/React] Logstash cluster status bars in react (#19433)
* [Monitoring/React] Logstash cluster status bars in react

* not have a prop named children

* simplify conditional metric

* fix functional tests
2018-05-29 14:36:32 -07:00
Justin Kambic
aec1904685
Provide events in & out per millisecond for Logstash pipelines (#19446)
* Port changes to dedicated branch to isolate PR.

* Rename variable in test to match function name.
2018-05-25 15:26:02 -04:00
Søren Louv-Jansen
b0f71308fb
[APM] Add kuery to APM (#18881) 2018-05-25 17:39:22 +02:00
Pete Harverson
ae5a34f4f9
[ML] Clear Anomaly Explorer if swimlane selection is empty (#19403)
* [ML] Clear Anomaly Explorer if swimlane selection is empty

* [ML] Remove unnecessary variable
2018-05-25 11:03:04 +01:00
Tim Sullivan
6eea4eae0f
[Monitoring] use react components for Kibana directives (#19379)
* kibana cluster status directive use react component

* fix some functional test failures
2018-05-24 18:05:51 -07:00
Tim Sullivan
ce61ae41a3
[Monitoring/Reporting Stats] Move hardcoded Reporting stats type collection out of monitoring plugin (#18894)
* [Monitoring/Telemetry collection] use `typeCollector.registerType` in Reporting

* a few cleanup changes
2018-05-24 11:14:27 -07:00
Pete Harverson
1365799a06
[ML] Convert anomalies table to EUI / React (#19352)
* [ML] Convert anomalies table to EUI / React

* [ML] Edits to EUI / React anomalies table after review
2018-05-24 15:49:00 +01:00
Casper Hübertz
1683909c3c
[APM] Errors Watcher assistant - Compressed form fields (#19204)
Adding `compressed` to the EuiFormRows for a more compressed looking form.
2018-05-24 10:58:24 +02:00
Søren Louv-Jansen
66739ffdd9
[APM] Upgrade to react-redux-request (#19338) 2018-05-24 02:45:49 +02:00
Tim Sullivan
d649f02c07
Monitoring/directives use react view elasticsearch (#19362)
* [Monitoring/React] Make Elasticsearch directives use React component internally

* fix more functional tests

* remove TODO

* lessen loc change
2018-05-23 16:57:37 -07:00
Tim Sullivan
77cfc94441
[Monitoring] Summary Status component data-test-subject wrap entire label/value container (#19289)
* [Monitoring] Summary Status component data-test-subject wrap entire label/value container

* update functional tests
2018-05-23 10:22:54 -07:00
Bill McConaghy
165fc67bd0
fixing issue in edit index settings caused by ace upgrade (#19311)
* fixing issue in edit index settings caused by ace upgrade

* fixing json mode
2018-05-22 19:32:05 -04:00
Chris Earle
f2ccf90880
Add Notification Service (#19236)
This adds a notification service to Kibana that can be used to send
asynchronous notifications, such as sending email and Slack messages,
which are intended to be configured via a combination of the
`kibana.yml` and Kibana keystore.

Once configured, the actions are automatically added to the notification
service and can be invoked via the server using the `notificationService`
singleton or HTTP to send it directly. See the included README for more
details.
2018-05-22 19:02:04 -04:00
dave.snider@gmail.com
51592c652a
Fix banner issue in ie11 (#19273)
* fix banner issue in ie11
2018-05-22 13:30:47 -07:00
Justin Kambic
b1527d85dc
[PipelineViewer] [Monitoring] Flatten Pipeline Statement Trees (#19084)
* Add flatten function and list class.

* Rename functions to be more descriptive.

* WIP moving flatten logic to classes.

* Finish moving flatten logic into classes, add tests.

* Simplify flattening, remove non-native dependency. Add more tests.

* Add defaults to simplify function call.

* Refactor two blocks into a function.

* Fixed broken test.

* Update classes based on PR feedback.

* Update module exports, remove obsolete file.
2018-05-22 15:48:39 -04:00
Joe Fleming
c6bf945f2f
Feat: expose reporting complete notifications (#19283)
This PR is a pretty small change to the Reporting job complete notification service. It converts the actual code to a simple object, instead of a class that needs to be instantiated. This makes the notification service a singleton, and also exports it so it can be used in non-Angular applications.

- Converts `reportingJobCompletionNotifications` factory to a singleton
- Exports the underlying jobCompletionNotifications
  - Allow use in non-angular plugins

Example use:

```js
import { jobCompletionNotifications } from 'plugins/reporting/services/job_completion_notifications';

createReportingJob() // pseudo code function that returns a reporting job id
.then(jobId => jobCompletionNotifications.add(jobId));
```
2018-05-22 12:47:49 -07:00
Aleh Zasypkin
0ab9703287
Upgrade sinon (v1.17.3 --> v5.0.7). (#19074) 2018-05-22 12:13:38 +02:00
James Gowdy
0263d886e4
[ML] Start datafeed from the module setup endpoint (#19254)
* [ML] Start datafeeds from the module setup endpoint

* changes based on review

* correcting use of filter
2018-05-22 10:37:21 +01:00
Tim Sullivan
744fc0b316
[XpackMain] Add _xpack/usage API (#19232)
* [XpackMain] Add _xpack/usage API

* add xpack usage http api integration test

* comment

* misc test describe fixes

* fix integration test

* fix reply called twice

* enable api test

* enable kibana collection for integration test to work

* throw error comment
2018-05-21 16:55:26 -07:00
Tim Sullivan
a7c3255665
Add some collector classes for objects that get registered in a CollectorSet (#19098)
* Add some collector classes for objects that get registered in a CollectorSet

* comment cleanup

* don't pass an inline-defined logger to collectorSet

* add a helper logger function so collector has access to logger at construction
2018-05-18 13:02:54 -07:00
Chris Roberson
5edf2c0beb
Ensure we account for cluster level settings when looking for configured actions (#19121) 2018-05-18 15:19:05 -04:00
Chris Roberson
a9bfcaab6a
Ensure disabling watcher does not break index management (#19137) 2018-05-18 11:49:50 -04:00
Justin Kambic
8425016e66
[Logstash] [PipelineViewer] Preserve all nested pipeline statements during graph conversion (#19101)
* Ensure all true/false statements are nested in IfStatements.

* Simplify nested vertex diffing.

* Rename get vertices function and test it.

* Update tests, add more tests.

* Update prompted by review feedback.

* Update tests - add required props to provided objects.

* Remove unneeded function/tests.

* PR Cleanup.
2018-05-18 09:32:52 -04:00
Pete Harverson
72f0f5918b
[ML] Don't show time series charts if metric field is script field (#19206) 2018-05-18 13:11:22 +01:00
James Gowdy
8b3052010f
[ML] Adding jsconfig file for better code navigation in vscode (#19203)
* [ML] Adding jsconfig file for better code navigation in vscode

* removing allowSyntheticDefaultImports as it is defaulted to true

* cleaning up paths
2018-05-18 12:52:18 +01:00
Walter Rafelsberger
e648269b95
[ML] Improve the field type icon's component structure. (#19200)
This fixes the component structure of the file type icon: The container component no longer needs to be wrapped inside a span element for the tooltip to work by using the recommendation to pass on the props to the first inner element (see elastic/eui#839). Also adapted a jest test which tests the hovering behavior and fails when the props are not passed on.
2018-05-18 10:59:27 +02:00
Walter Rafelsberger
72083c9b0c
[ML] Fixes jest tests for bucket span estimator button. (#19164)
Fixes jest tests for the bucket span estimator button. The tests were not correctly considering the way jest runs tests asynchronously. Now each test is self-contained within the test callback.
2018-05-17 14:04:18 +02:00
Walter Rafelsberger
69b857ca54
[ML] Migrate field-type-icon to EUI/React. (#19159)
Migrates the field-type-icon directive to use EUI/React. Instead of the angular/bootstrap tooltip attribute on the directive's tag, there's now an option tooltip-enabled which when true wraps the component inside EuiToolTip.
2018-05-17 13:21:39 +02:00
Walter Rafelsberger
a9d47320d5
[ML] Migrate bucket span estimator button to React/EUI. (#19045)
This migrates the bucket span estimator button to use React/EUI. The existing mlBucketSpanEstimator is refactored to use React without ngReact to have more detailed control in regards to the $scope being transformed to a trimmed down props object with only the information necessary for the React component. This also allows more control in regards to the $scope attributes being watched. Instead of custom styles and classes this now uses the options available for EuiButton. However, there were some minimal overrides necessary to the EUI styles to replicate the narrower height and padding to fit within the input element.
2018-05-17 09:26:01 +02:00
Walter Rafelsberger
13b97ac294
[ML] Migrate ml-info-icon to React/EUI (#19003)
This replaces the angular based tooltip used in the ml-info-icon directive with one based on React/EuiTooltip. It supports transclusion and rendering of angular template snippets inside the tooltip. Because the DOM structure of the EuiTooltips and the angular/bootstrap tooltips is quite different there is a bit more code involved to achieve this, but the result is that for this we don't have to change the markup in the original angular templates where ml-info-icon is used.
2018-05-17 09:21:39 +02:00
Chris Davies
2f9185df63
Fix #18838 incorrect 403 message when generating reports (#19054)
Fix #18838 incorrect 403 message when generating reports
2018-05-16 15:22:12 -04:00
Justin Kambic
748d152354
Add vertex reference to pipeline statement classes. (#19134) 2018-05-16 14:31:18 -04:00