github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-22 08:49:27 -04:00
Code Issues Projects Releases Packages Wiki Activity
68318 commits 433 branches 496 tags 22 GiB
Commit graph

5964 commits

Author SHA1 Message Date
Kibana Machine
385f33e9d4
[8.11] [Dashboard] Fix flaky sync_colors.tsx test (#172633) (#172692) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Dashboard] Fix flaky `sync_colors.tsx` test
(#172633)](https://github.com/elastic/kibana/pull/172633)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-06T14:55:13Z","message":"[Dashboard]
Fix flaky `sync_colors.tsx` test (#172633)\n\n## Summary\r\n\r\nIt is
possible for the `noDataPopover` to take more than the
`100ms`\r\ntimeout from `ensureHiddenNoDataPopover` (pictured below) to
appear - in\r\nthese cases, any tests that make use of the Lens page
object's\r\n`goToTimeRange` method will fail due to clicking the wrong
element (the\r\ntour step rather than the time
picker).\r\n\r\n\r\n![image](35de1215-6f9f-4a72-a0ab-e1a60f5bb80a)\r\n\r\n\r\nWhile
my initial thought was to simply increase the timeout for
the\r\n`noDataPopover` check, this isn't ideal - **a lot** of tests use
the\r\n`goToTimeRange` method and, by doing this, we would be slowing
down\r\n**every single one of them** even when the test wouldn't have
failed to\r\nbegin with! Instead, I've chosen to surround the important
parts of the\r\ncode in `goToTimeRange` with a `retry` - that way, if
the\r\n`noDataPopover` never shows up or it shows up comfortably within
the\r\n`100ms` timeout, the impact to the speed of a given test will
be\r\n**minimal**; however, if the no data popover shows up **outside**
of\r\nthis timeout, the retry will save the test from outright
failure.\r\n\r\n### [Flaky
Test\r\nRunner](1ac033d7-6cc1-4789-9a2b-6c7b8c34f67c)\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9e2d06512196ff6800a8441fc4605c258f206dd","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:critical","backport:prev-minor","v8.12.0","v8.13.0"],"number":172633,"url":"https://github.com/elastic/kibana/pull/172633","mergeCommit":{"message":"[Dashboard]
Fix flaky `sync_colors.tsx` test (#172633)\n\n## Summary\r\n\r\nIt is
possible for the `noDataPopover` to take more than the
`100ms`\r\ntimeout from `ensureHiddenNoDataPopover` (pictured below) to
appear - in\r\nthese cases, any tests that make use of the Lens page
object's\r\n`goToTimeRange` method will fail due to clicking the wrong
element (the\r\ntour step rather than the time
picker).\r\n\r\n\r\n![image](35de1215-6f9f-4a72-a0ab-e1a60f5bb80a)\r\n\r\n\r\nWhile
my initial thought was to simply increase the timeout for
the\r\n`noDataPopover` check, this isn't ideal - **a lot** of tests use
the\r\n`goToTimeRange` method and, by doing this, we would be slowing
down\r\n**every single one of them** even when the test wouldn't have
failed to\r\nbegin with! Instead, I've chosen to surround the important
parts of the\r\ncode in `goToTimeRange` with a `retry` - that way, if
the\r\n`noDataPopover` never shows up or it shows up comfortably within
the\r\n`100ms` timeout, the impact to the speed of a given test will
be\r\n**minimal**; however, if the no data popover shows up **outside**
of\r\nthis timeout, the retry will save the test from outright
failure.\r\n\r\n### [Flaky
Test\r\nRunner](1ac033d7-6cc1-4789-9a2b-6c7b8c34f67c)\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9e2d06512196ff6800a8441fc4605c258f206dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172633","number":172633,"mergeCommit":{"message":"[Dashboard]
Fix flaky `sync_colors.tsx` test (#172633)\n\n## Summary\r\n\r\nIt is
possible for the `noDataPopover` to take more than the
`100ms`\r\ntimeout from `ensureHiddenNoDataPopover` (pictured below) to
appear - in\r\nthese cases, any tests that make use of the Lens page
object's\r\n`goToTimeRange` method will fail due to clicking the wrong
element (the\r\ntour step rather than the time
picker).\r\n\r\n\r\n![image](35de1215-6f9f-4a72-a0ab-e1a60f5bb80a)\r\n\r\n\r\nWhile
my initial thought was to simply increase the timeout for
the\r\n`noDataPopover` check, this isn't ideal - **a lot** of tests use
the\r\n`goToTimeRange` method and, by doing this, we would be slowing
down\r\n**every single one of them** even when the test wouldn't have
failed to\r\nbegin with! Instead, I've chosen to surround the important
parts of the\r\ncode in `goToTimeRange` with a `retry` - that way, if
the\r\n`noDataPopover` never shows up or it shows up comfortably within
the\r\n`100ms` timeout, the impact to the speed of a given test will
be\r\n**minimal**; however, if the no data popover shows up **outside**
of\r\nthis timeout, the retry will save the test from outright
failure.\r\n\r\n### [Flaky
Test\r\nRunner](1ac033d7-6cc1-4789-9a2b-6c7b8c34f67c)\r\n\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9e2d06512196ff6800a8441fc4605c258f206dd"}},{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
 2023-12-06 09:05:10 -07:00
Kibana Machine
be9d20037d
[8.11] fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395) (#172403) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [fix Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
(#172395)](https://github.com/elastic/kibana/pull/172395)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-12-01T22:12:57Z","message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
(#172395)\n\nFixes
https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed
because combobox trying to select already selected tag. PR\r\nfixes test
by using combobox service to set element. Combobox service\r\nincludes
logic to only select value when not
selected.\r\n\r\n\r\n![image](e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27]
│ debg
Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg
Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait
timed out after 10003ms\r\n[00:07:38] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait
timed out after 10038ms\r\n[00:07:48] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait
timed out after 10054ms\r\n[00:07:59] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait
timed out after 10013ms\r\n[00:08:09] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait
timed out after 10038ms\r\n[00:08:20] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait
timed out after 10005ms\r\n[00:08:30] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait
timed out after 10034ms\r\n[00:08:41] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait
timed out after 10037ms\r\n[00:08:51] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait
timed out after 10007ms\r\n[00:09:02] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait
timed out after 10054ms\r\n[00:09:13] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait
timed out after 10037ms\r\n[00:09:23] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait
timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error:
retry.try timeout: TimeoutError: Waiting for element to be located
By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait
timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking
window screenshot
\"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34]
│ info Current URL is:
http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34]
│ info Saving page source to:
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34]
└- ✖ fail: saved objects tagging - functional tests dashboard
integration creating allows to select tags for a new
dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try
timeout: TimeoutError: Waiting for element to be located By(css
selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34]
│ Wait timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector
(find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click
(test_subjects.ts:164:5)\r\n[00:09:34] │ at
DashboardPageObject.selectDashboardTags
(dashboard_page.ts:560:7)\r\n[00:09:34] │ at
DashboardPageObject.enterDashboardTitleAndClickSave
(dashboard_page.ts:544:7)\r\n[00:09:34] │ at
dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt
(retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │
\r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.11.0","v8.12.0"],"number":172395,"url":"https://github.com/elastic/kibana/pull/172395","mergeCommit":{"message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
(#172395)\n\nFixes
https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed
because combobox trying to select already selected tag. PR\r\nfixes test
by using combobox service to set element. Combobox service\r\nincludes
logic to only select value when not
selected.\r\n\r\n\r\n![image](e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27]
│ debg
Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg
Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait
timed out after 10003ms\r\n[00:07:38] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait
timed out after 10038ms\r\n[00:07:48] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait
timed out after 10054ms\r\n[00:07:59] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait
timed out after 10013ms\r\n[00:08:09] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait
timed out after 10038ms\r\n[00:08:20] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait
timed out after 10005ms\r\n[00:08:30] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait
timed out after 10034ms\r\n[00:08:41] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait
timed out after 10037ms\r\n[00:08:51] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait
timed out after 10007ms\r\n[00:09:02] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait
timed out after 10054ms\r\n[00:09:13] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait
timed out after 10037ms\r\n[00:09:23] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait
timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error:
retry.try timeout: TimeoutError: Waiting for element to be located
By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait
timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking
window screenshot
\"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34]
│ info Current URL is:
http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34]
│ info Saving page source to:
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34]
└- ✖ fail: saved objects tagging - functional tests dashboard
integration creating allows to select tags for a new
dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try
timeout: TimeoutError: Waiting for element to be located By(css
selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34]
│ Wait timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector
(find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click
(test_subjects.ts:164:5)\r\n[00:09:34] │ at
DashboardPageObject.selectDashboardTags
(dashboard_page.ts:560:7)\r\n[00:09:34] │ at
DashboardPageObject.enterDashboardTitleAndClickSave
(dashboard_page.ts:544:7)\r\n[00:09:34] │ at
dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt
(retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │
\r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172395","number":172395,"mergeCommit":{"message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
(#172395)\n\nFixes
https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed
because combobox trying to select already selected tag. PR\r\nfixes test
by using combobox service to set element. Combobox service\r\nincludes
logic to only select value when not
selected.\r\n\r\n\r\n![image](e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27]
│ debg
Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]')
with timeout=10000\r\n[00:07:27] │ debg
TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg
Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:27] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait
timed out after 10003ms\r\n[00:07:38] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait
timed out after 10038ms\r\n[00:07:48] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait
timed out after 10054ms\r\n[00:07:59] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait
timed out after 10013ms\r\n[00:08:09] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait
timed out after 10038ms\r\n[00:08:20] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait
timed out after 10005ms\r\n[00:08:30] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait
timed out after 10034ms\r\n[00:08:41] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait
timed out after 10037ms\r\n[00:08:51] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait
timed out after 10007ms\r\n[00:09:02] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait
timed out after 10054ms\r\n[00:09:13] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait
timed out after 10037ms\r\n[00:09:23] │ debg
Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]')
with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting
for element to be located By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait
timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error:
retry.try timeout: TimeoutError: Waiting for element to be located
By(css selector,
[data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait
timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking
window screenshot
\"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34]
│ info Current URL is:
http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34]
│ info Saving page source to:
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved
objects tagging - functional tests dashboard integration creating allows
t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34]
└- ✖ fail: saved objects tagging - functional tests dashboard
integration creating allows to select tags for a new
dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try
timeout: TimeoutError: Waiting for element to be located By(css
selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34]
│ Wait timed out after 10042ms\r\n[00:09:34] │ at
/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34]
│ at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector
(find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click
(test_subjects.ts:164:5)\r\n[00:09:34] │ at
DashboardPageObject.selectDashboardTags
(dashboard_page.ts:560:7)\r\n[00:09:34] │ at
DashboardPageObject.enterDashboardTitleAndClickSave
(dashboard_page.ts:544:7)\r\n[00:09:34] │ at
dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt
(retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure
(retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess
(retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try
(retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard
(dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous>
(dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply
(wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │
\r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
 2023-12-01 16:14:47 -07:00
Kibana Machine
c25c3ab106
[8.11] FullStory: use debounce before updating Page Vars (#171450) (#171636) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [FullStory: use debounce before updating Page Vars
(#171450)](https://github.com/elastic/kibana/pull/171450)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-11-21T13:46:13Z","message":"FullStory:
use debounce before updating Page Vars
(#171450)","sha":"55aebfdd2e2576c4d78b2e409825ba11652125ca","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","telemetry","backport:prev-minor","v8.12.0"],"number":171450,"url":"https://github.com/elastic/kibana/pull/171450","mergeCommit":{"message":"FullStory:
use debounce before updating Page Vars
(#171450)","sha":"55aebfdd2e2576c4d78b2e409825ba11652125ca"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171450","number":171450,"mergeCommit":{"message":"FullStory:
use debounce before updating Page Vars
(#171450)","sha":"55aebfdd2e2576c4d78b2e409825ba11652125ca"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
 2023-11-21 08:27:51 -07:00
Kibana Machine
dc03884ae3
[8.11] [Dashboard Navigation] Fix reference extract method (#171360) (#171561) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Dashboard Navigation] Fix reference extract method
(#171360)](https://github.com/elastic/kibana/pull/171360)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-11-20T16:40:07Z","message":"[Dashboard
Navigation] Fix reference extract method (#171360)\n\nCloses
https://github.com/elastic/kibana/issues/164212\r\nCloses
https://github.com/elastic/kibana/issues/171328\r\n\r\n##
Summary\r\n\r\nIn `extractReferences`, the links in the `links` array
attribute is
[not\r\nextensible](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_define_property_object_not_extensible)\r\n-
this means that we cannot add or delete properties from
each\r\nindividual link directly. Instead, I've had to create a clone of
each\r\ndashboard link via the spread operator so that we aren't
modifying the\r\noriginal link directly.\r\n\r\n**How to Test**\r\n1.
Create a by-value Links panel\r\n2. Refresh the dashboard\r\n3. Save the
Links panel to the library via the panel action\r\n4. The panel should
be saved successfully **and** the panel title should\r\nbe
updated.\r\n\r\n[**Flaky
Test\r\nRunner**](b8949d44-697d-414a-9e98-14b0a6f67b31)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"49b52fe76e480c24673c8e1573346fb279ea965f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:high","backport:prev-minor","Project:Dashboard
Navigation","v8.12.0"],"number":171360,"url":"https://github.com/elastic/kibana/pull/171360","mergeCommit":{"message":"[Dashboard
Navigation] Fix reference extract method (#171360)\n\nCloses
https://github.com/elastic/kibana/issues/164212\r\nCloses
https://github.com/elastic/kibana/issues/171328\r\n\r\n##
Summary\r\n\r\nIn `extractReferences`, the links in the `links` array
attribute is
[not\r\nextensible](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_define_property_object_not_extensible)\r\n-
this means that we cannot add or delete properties from
each\r\nindividual link directly. Instead, I've had to create a clone of
each\r\ndashboard link via the spread operator so that we aren't
modifying the\r\noriginal link directly.\r\n\r\n**How to Test**\r\n1.
Create a by-value Links panel\r\n2. Refresh the dashboard\r\n3. Save the
Links panel to the library via the panel action\r\n4. The panel should
be saved successfully **and** the panel title should\r\nbe
updated.\r\n\r\n[**Flaky
Test\r\nRunner**](b8949d44-697d-414a-9e98-14b0a6f67b31)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"49b52fe76e480c24673c8e1573346fb279ea965f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171360","number":171360,"mergeCommit":{"message":"[Dashboard
Navigation] Fix reference extract method (#171360)\n\nCloses
https://github.com/elastic/kibana/issues/164212\r\nCloses
https://github.com/elastic/kibana/issues/171328\r\n\r\n##
Summary\r\n\r\nIn `extractReferences`, the links in the `links` array
attribute is
[not\r\nextensible](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_define_property_object_not_extensible)\r\n-
this means that we cannot add or delete properties from
each\r\nindividual link directly. Instead, I've had to create a clone of
each\r\ndashboard link via the spread operator so that we aren't
modifying the\r\noriginal link directly.\r\n\r\n**How to Test**\r\n1.
Create a by-value Links panel\r\n2. Refresh the dashboard\r\n3. Save the
Links panel to the library via the panel action\r\n4. The panel should
be saved successfully **and** the panel title should\r\nbe
updated.\r\n\r\n[**Flaky
Test\r\nRunner**](b8949d44-697d-414a-9e98-14b0a6f67b31)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"49b52fe76e480c24673c8e1573346fb279ea965f"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
 2023-11-20 10:58:19 -07:00
Kibana Machine
faef45f16e
[8.11] [Dashboard] Add Dashboard title to browser tab title (#171255) (#171454) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Dashboard] Add Dashboard title to browser tab title
(#171255)](https://github.com/elastic/kibana/pull/171255)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-11-16T23:23:22Z","message":"[Dashboard]
Add Dashboard title to browser tab title (#171255)\n\nCloses
https://github.com/elastic/kibana/issues/162800\r\n\r\n##
Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab
title, which was\r\naccidentally removed as part of the
[portable\r\ndashboards](https://github.com/elastic/kibana/pull/144332)
work. For\r\nexample, if I'm on the sample Logs dashboard, the title of
that\r\ndashboard will now be reflected in the tab title like it was
prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After
|\r\n|--------|--------|\r\n|\r\n![image](e82740a8-b4ef-488e-981a-57b5ef39948a)\r\n|\r\n\r\n\r\nThe
tab title should stay up-to-date with Dashboard title changes,
as\r\ndemonstrated in this
video:\r\n\r\n\r\n651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote
that this will **only apply** to dashboards in the dashboard app
-\r\ndashboards outside of the dashboard app should not change the
browser\r\ntab title, unless the consumer does this on their
own.\r\n\r\n### [Flaky
Test\r\nRunner](aec4100b-9e76-4154-b20b-a7054f7f46a1)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:high","backport:prev-minor","ci:cloud-deploy","v8.12.0"],"number":171255,"url":"https://github.com/elastic/kibana/pull/171255","mergeCommit":{"message":"[Dashboard]
Add Dashboard title to browser tab title (#171255)\n\nCloses
https://github.com/elastic/kibana/issues/162800\r\n\r\n##
Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab
title, which was\r\naccidentally removed as part of the
[portable\r\ndashboards](https://github.com/elastic/kibana/pull/144332)
work. For\r\nexample, if I'm on the sample Logs dashboard, the title of
that\r\ndashboard will now be reflected in the tab title like it was
prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After
|\r\n|--------|--------|\r\n|\r\n![image](e82740a8-b4ef-488e-981a-57b5ef39948a)\r\n|\r\n\r\n\r\nThe
tab title should stay up-to-date with Dashboard title changes,
as\r\ndemonstrated in this
video:\r\n\r\n\r\n651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote
that this will **only apply** to dashboards in the dashboard app
-\r\ndashboards outside of the dashboard app should not change the
browser\r\ntab title, unless the consumer does this on their
own.\r\n\r\n### [Flaky
Test\r\nRunner](aec4100b-9e76-4154-b20b-a7054f7f46a1)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171255","number":171255,"mergeCommit":{"message":"[Dashboard]
Add Dashboard title to browser tab title (#171255)\n\nCloses
https://github.com/elastic/kibana/issues/162800\r\n\r\n##
Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab
title, which was\r\naccidentally removed as part of the
[portable\r\ndashboards](https://github.com/elastic/kibana/pull/144332)
work. For\r\nexample, if I'm on the sample Logs dashboard, the title of
that\r\ndashboard will now be reflected in the tab title like it was
prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After
|\r\n|--------|--------|\r\n|\r\n![image](e82740a8-b4ef-488e-981a-57b5ef39948a)\r\n|\r\n\r\n\r\nThe
tab title should stay up-to-date with Dashboard title changes,
as\r\ndemonstrated in this
video:\r\n\r\n\r\n651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote
that this will **only apply** to dashboards in the dashboard app
-\r\ndashboards outside of the dashboard app should not change the
browser\r\ntab title, unless the consumer does this on their
own.\r\n\r\n### [Flaky
Test\r\nRunner](aec4100b-9e76-4154-b20b-a7054f7f46a1)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
 2023-11-16 17:33:13 -07:00
Kibana Machine
d550227582
[8.11] [Dashboard] Fix flaky pluggable actions test (#167926) (#170766) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Dashboard] Fix flaky pluggable actions test
(#167926)](https://github.com/elastic/kibana/pull/167926)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-10-04T17:21:02Z","message":"[Dashboard]
Fix flaky pluggable actions test (#167926)\n\nCloses
https://github.com/elastic/kibana/issues/136460\r\n\r\n##
Summary\r\n\r\nSimilar to https://github.com/elastic/kibana/pull/167836,
navigation\r\nthrough `header.clickDashboard()` was flaky in the
attached test because\r\nthe same `data-test-subj` was re-used for both
the application-specific\r\ntop navigation **and** the reusable
application listing page
component:\r\n\r\n\r\n8b6ba3d15f/packages/content-management/table_list_view/src/table_list_view.tsx (L91-L96)\r\n\r\nThis
meant that, when the referenced flaky test tried to navigation
from\r\nthe Visualization listing page to the dashboard app
in\r\n`clearSavedObjectsFromAppLinks` via the header page
object's\r\n`clickDashboard` method, it wasn't actually waiting to
navigate to the\r\ndashboard app because it detected the `top-nav` data
test subject from\r\nthe **visualization** listing page **and not** from
the dashboard app.\r\n\r\nTherefore, instead of navigating through the
`header` method, I switched\r\nto the new `navigateToAppFromAppsMenu`,
which relies on the URL to\r\nupdate to ensure navigation has occured
rather than the `top-nav` data\r\ntest subject. I also added logic to
close the flyout as part of the test\r\ncleanup, since it was remaining
open even after navigating to the\r\nVisualizations listing page, which
was getting in the way of the failure\r\nscreenshot.\r\n\r\n\r\n###
Flaky Test Runner\r\n\r\n- Without closing of
flyout:\r\n628f0da9-1e2a-45a9-b58b-dab92e345118)\r\n\r\n-
With closing of
flyout:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3336\r\n
\r\n\r\n![image](3456db1a-9cee-4db9-a28d-4c0d1520a5ec)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"4d1bd84309567bef2e5937e8d72faaa182414183","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:critical","backport:prev-minor","v8.11.0","v8.12.0"],"number":167926,"url":"https://github.com/elastic/kibana/pull/167926","mergeCommit":{"message":"[Dashboard]
Fix flaky pluggable actions test (#167926)\n\nCloses
https://github.com/elastic/kibana/issues/136460\r\n\r\n##
Summary\r\n\r\nSimilar to https://github.com/elastic/kibana/pull/167836,
navigation\r\nthrough `header.clickDashboard()` was flaky in the
attached test because\r\nthe same `data-test-subj` was re-used for both
the application-specific\r\ntop navigation **and** the reusable
application listing page
component:\r\n\r\n\r\n8b6ba3d15f/packages/content-management/table_list_view/src/table_list_view.tsx (L91-L96)\r\n\r\nThis
meant that, when the referenced flaky test tried to navigation
from\r\nthe Visualization listing page to the dashboard app
in\r\n`clearSavedObjectsFromAppLinks` via the header page
object's\r\n`clickDashboard` method, it wasn't actually waiting to
navigate to the\r\ndashboard app because it detected the `top-nav` data
test subject from\r\nthe **visualization** listing page **and not** from
the dashboard app.\r\n\r\nTherefore, instead of navigating through the
`header` method, I switched\r\nto the new `navigateToAppFromAppsMenu`,
which relies on the URL to\r\nupdate to ensure navigation has occured
rather than the `top-nav` data\r\ntest subject. I also added logic to
close the flyout as part of the test\r\ncleanup, since it was remaining
open even after navigating to the\r\nVisualizations listing page, which
was getting in the way of the failure\r\nscreenshot.\r\n\r\n\r\n###
Flaky Test Runner\r\n\r\n- Without closing of
flyout:\r\n628f0da9-1e2a-45a9-b58b-dab92e345118)\r\n\r\n-
With closing of
flyout:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3336\r\n
\r\n\r\n![image](3456db1a-9cee-4db9-a28d-4c0d1520a5ec)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"4d1bd84309567bef2e5937e8d72faaa182414183"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167926","number":167926,"mergeCommit":{"message":"[Dashboard]
Fix flaky pluggable actions test (#167926)\n\nCloses
https://github.com/elastic/kibana/issues/136460\r\n\r\n##
Summary\r\n\r\nSimilar to https://github.com/elastic/kibana/pull/167836,
navigation\r\nthrough `header.clickDashboard()` was flaky in the
attached test because\r\nthe same `data-test-subj` was re-used for both
the application-specific\r\ntop navigation **and** the reusable
application listing page
component:\r\n\r\n\r\n8b6ba3d15f/packages/content-management/table_list_view/src/table_list_view.tsx (L91-L96)\r\n\r\nThis
meant that, when the referenced flaky test tried to navigation
from\r\nthe Visualization listing page to the dashboard app
in\r\n`clearSavedObjectsFromAppLinks` via the header page
object's\r\n`clickDashboard` method, it wasn't actually waiting to
navigate to the\r\ndashboard app because it detected the `top-nav` data
test subject from\r\nthe **visualization** listing page **and not** from
the dashboard app.\r\n\r\nTherefore, instead of navigating through the
`header` method, I switched\r\nto the new `navigateToAppFromAppsMenu`,
which relies on the URL to\r\nupdate to ensure navigation has occured
rather than the `top-nav` data\r\ntest subject. I also added logic to
close the flyout as part of the test\r\ncleanup, since it was remaining
open even after navigating to the\r\nVisualizations listing page, which
was getting in the way of the failure\r\nscreenshot.\r\n\r\n\r\n###
Flaky Test Runner\r\n\r\n- Without closing of
flyout:\r\n628f0da9-1e2a-45a9-b58b-dab92e345118)\r\n\r\n-
With closing of
flyout:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3336\r\n
\r\n\r\n![image](3456db1a-9cee-4db9-a28d-4c0d1520a5ec)\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"4d1bd84309567bef2e5937e8d72faaa182414183"}},{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
 2023-11-07 10:28:21 -07:00
Kibana Machine
4e0fc5adaf
[8.11] [ES|QL] Fix error handling for ES|QL nested error messages (#170005) (#170606) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[ES|QL] Fix error handling for ES|QL nested error messages
(#170005)](https://github.com/elastic/kibana/pull/170005)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-11-01T13:30:24Z","message":"[ES|QL]
Fix error handling for ES|QL nested error messages (#170005)\n\n##
Summary\r\n\r\nFix #170004\r\n\r\nThis PR fixes the wrong behaviour with
message extraction from this type\r\nof ES|QL responses.\r\nTook also
the opportunity to improve the FTR side, with some monaco\r\nhandlers
for errors in the editor and some test cases for errors in\r\nES|QL
queries.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2643f504cd22c71b8f0a89c554c21313967a709e","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Team:DataDiscovery","backport:prev-minor","Feature:ES|QL","v8.12.0","v8.11.1"],"number":170005,"url":"https://github.com/elastic/kibana/pull/170005","mergeCommit":{"message":"[ES|QL]
Fix error handling for ES|QL nested error messages (#170005)\n\n##
Summary\r\n\r\nFix #170004\r\n\r\nThis PR fixes the wrong behaviour with
message extraction from this type\r\nof ES|QL responses.\r\nTook also
the opportunity to improve the FTR side, with some monaco\r\nhandlers
for errors in the editor and some test cases for errors in\r\nES|QL
queries.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2643f504cd22c71b8f0a89c554c21313967a709e"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170005","number":170005,"mergeCommit":{"message":"[ES|QL]
Fix error handling for ES|QL nested error messages (#170005)\n\n##
Summary\r\n\r\nFix #170004\r\n\r\nThis PR fixes the wrong behaviour with
message extraction from this type\r\nof ES|QL responses.\r\nTook also
the opportunity to improve the FTR side, with some monaco\r\nhandlers
for errors in the editor and some test cases for errors in\r\nES|QL
queries.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2643f504cd22c71b8f0a89c554c21313967a709e"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
 2023-11-06 02:33:02 -07:00
Kibana Machine
50926434e9
[8.11] [Discover] Revert data table row height to 3 by default (#169724) (#170187) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Discover] Revert data table row height to 3 by default
(#169724)](https://github.com/elastic/kibana/pull/169724)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-10-30T20:36:32Z","message":"[Discover]
Revert data table row height to 3 by default (#169724)\n\n##
Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the
default\r\nDiscover grid row height to \"auto\", and changes it back to
\"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.11.0","v8.12.0"],"number":169724,"url":"https://github.com/elastic/kibana/pull/169724","mergeCommit":{"message":"[Discover]
Revert data table row height to 3 by default (#169724)\n\n##
Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the
default\r\nDiscover grid row height to \"auto\", and changes it back to
\"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169724","number":169724,"mergeCommit":{"message":"[Discover]
Revert data table row height to 3 by default (#169724)\n\n##
Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the
default\r\nDiscover grid row height to \"auto\", and changes it back to
\"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05"}}]}]
BACKPORT-->

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
 2023-10-30 21:02:35 -07:00
Kibana Machine
c0bd22725d
[8.11] Address saved_object_tagging flakiness (#170114) (#170190) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Address saved_object_tagging flakiness
(#170114)](https://github.com/elastic/kibana/pull/170114)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-10-30T21:21:27Z","message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](https://github.com/elastic/kibana/pull/167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":170114,"url":"https://github.com/elastic/kibana/pull/170114","mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](https://github.com/elastic/kibana/pull/167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170114","number":170114,"mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](https://github.com/elastic/kibana/pull/167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
 2023-10-30 15:21:46 -07:00
Kibana Machine
daad91981c
[8.11] [esArchiver] restrict from modifying saved objects indexes (#169852) (#170065) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[esArchiver] restrict from modifying saved objects indexes
(#169852)](https://github.com/elastic/kibana/pull/169852)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-27T18:27:10Z","message":"[esArchiver]
restrict from modifying saved objects indexes (#169852)\n\n##
Summary\r\n\r\nRelated to #161882\r\n\r\nThe goal is to prevent FTR
tests from new esArchives that overrides SO\r\nindexes.\r\n\r\nThis PR
adds the existing archives that re-create Saved Objects indexes\r\ninto
temporary exception list, located
in\r\n`packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json`.\r\nWhenever
tests/archives are updated to not modify SO indexes, archive
is\r\nexpected to be removed from the list (progress can be tracked
in\r\n#169075, #168973, #168969, #168926 )\r\n\r\nLoad action has a
check if index is SO index and if the archive is in\r\nthe exception
list. This will throw error for the new archives, but\r\nstill work as
usual for the existing ones while teams updating
the\r\ntests.\r\n\r\nWhenever test is loading archive listed in the
exception list, the\r\nfollowing warning message is
logged:\r\n```\r\nwarn
x-pack/test/functional/es_archives/data/search_sessions overrides Saved
Objects index(es) and placed temporary in the exception list.\r\nPlease
fix the archive and remove it from
/Users/dmle/github/kibana/packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json.\r\nFor
more details see:
https://github.com/elastic/kibana/issues/161882\r\n```\r\n\r\nIf the
test loads a newly added archive that modifies a Saved Object\r\nindex
(e.g. `.kibana`), esArchiver will throw the error:\r\n```\r\n Error:
esArchiver doesn't support modifying the existing Saved Objects index:
'.kibana_1',\r\n please update its definition in
mappings.json\r\n```","sha":"669881095881b599262d8ba19bdf68207c86bfa0","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ES-ARCHIVER","v8.12.0","v8.11.1","v8.10.5"],"number":169852,"url":"https://github.com/elastic/kibana/pull/169852","mergeCommit":{"message":"[esArchiver]
restrict from modifying saved objects indexes (#169852)\n\n##
Summary\r\n\r\nRelated to #161882\r\n\r\nThe goal is to prevent FTR
tests from new esArchives that overrides SO\r\nindexes.\r\n\r\nThis PR
adds the existing archives that re-create Saved Objects indexes\r\ninto
temporary exception list, located
in\r\n`packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json`.\r\nWhenever
tests/archives are updated to not modify SO indexes, archive
is\r\nexpected to be removed from the list (progress can be tracked
in\r\n#169075, #168973, #168969, #168926 )\r\n\r\nLoad action has a
check if index is SO index and if the archive is in\r\nthe exception
list. This will throw error for the new archives, but\r\nstill work as
usual for the existing ones while teams updating
the\r\ntests.\r\n\r\nWhenever test is loading archive listed in the
exception list, the\r\nfollowing warning message is
logged:\r\n```\r\nwarn
x-pack/test/functional/es_archives/data/search_sessions overrides Saved
Objects index(es) and placed temporary in the exception list.\r\nPlease
fix the archive and remove it from
/Users/dmle/github/kibana/packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json.\r\nFor
more details see:
https://github.com/elastic/kibana/issues/161882\r\n```\r\n\r\nIf the
test loads a newly added archive that modifies a Saved Object\r\nindex
(e.g. `.kibana`), esArchiver will throw the error:\r\n```\r\n Error:
esArchiver doesn't support modifying the existing Saved Objects index:
'.kibana_1',\r\n please update its definition in
mappings.json\r\n```","sha":"669881095881b599262d8ba19bdf68207c86bfa0"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169852","number":169852,"mergeCommit":{"message":"[esArchiver]
restrict from modifying saved objects indexes (#169852)\n\n##
Summary\r\n\r\nRelated to #161882\r\n\r\nThe goal is to prevent FTR
tests from new esArchives that overrides SO\r\nindexes.\r\n\r\nThis PR
adds the existing archives that re-create Saved Objects indexes\r\ninto
temporary exception list, located
in\r\n`packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json`.\r\nWhenever
tests/archives are updated to not modify SO indexes, archive
is\r\nexpected to be removed from the list (progress can be tracked
in\r\n#169075, #168973, #168969, #168926 )\r\n\r\nLoad action has a
check if index is SO index and if the archive is in\r\nthe exception
list. This will throw error for the new archives, but\r\nstill work as
usual for the existing ones while teams updating
the\r\ntests.\r\n\r\nWhenever test is loading archive listed in the
exception list, the\r\nfollowing warning message is
logged:\r\n```\r\nwarn
x-pack/test/functional/es_archives/data/search_sessions overrides Saved
Objects index(es) and placed temporary in the exception list.\r\nPlease
fix the archive and remove it from
/Users/dmle/github/kibana/packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json.\r\nFor
more details see:
https://github.com/elastic/kibana/issues/161882\r\n```\r\n\r\nIf the
test loads a newly added archive that modifies a Saved Object\r\nindex
(e.g. `.kibana`), esArchiver will throw the error:\r\n```\r\n Error:
esArchiver doesn't support modifying the existing Saved Objects index:
'.kibana_1',\r\n please update its definition in
mappings.json\r\n```","sha":"669881095881b599262d8ba19bdf68207c86bfa0"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-10-27 12:57:09 -07:00
Davis McPhee
4fea4057c4
[8.11] [Unified Data Table] Fix elements with defined z-index overlapping grid in full screen mode (#168545) (#169949) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Unified Data Table] Fix elements with defined z-index overlapping
grid in full screen mode
(#168545)](https://github.com/elastic/kibana/pull/168545)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-10-26T01:34:32Z","message":"[Unified
Data Table] Fix elements with defined z-index overlapping grid in full
screen mode (#168545)\n\n## Summary\r\n\r\nThis PR fixes an issue where
elements with defined z-index values\r\noverlap the grid in full screen
mode.\r\n\r\nBefore:\r\n<img width=\"2007\"
alt=\"before\"\r\nsrc=\"49f5ad02-5c23-4e63-bf15-959ce1b822f0\">\r\n\r\nAfter:\r\n<img
width=\"2007\"
alt=\"after\"\r\nsrc=\"46d5ce0a-533a-4b7e-b9d0-be9ec75f2018\">\r\n\r\nFlaky
test run:\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3453\r\n\r\nFixes
#168331.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cc8e3e4f2e963e99dbcabc2258c0576d8a37a0e6","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","v8.11.0","Feature:UnifiedDataTable","v8.12.0"],"number":168545,"url":"https://github.com/elastic/kibana/pull/168545","mergeCommit":{"message":"[Unified
Data Table] Fix elements with defined z-index overlapping grid in full
screen mode (#168545)\n\n## Summary\r\n\r\nThis PR fixes an issue where
elements with defined z-index values\r\noverlap the grid in full screen
mode.\r\n\r\nBefore:\r\n<img width=\"2007\"
alt=\"before\"\r\nsrc=\"49f5ad02-5c23-4e63-bf15-959ce1b822f0\">\r\n\r\nAfter:\r\n<img
width=\"2007\"
alt=\"after\"\r\nsrc=\"46d5ce0a-533a-4b7e-b9d0-be9ec75f2018\">\r\n\r\nFlaky
test run:\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3453\r\n\r\nFixes
#168331.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cc8e3e4f2e963e99dbcabc2258c0576d8a37a0e6"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168545","number":168545,"mergeCommit":{"message":"[Unified
Data Table] Fix elements with defined z-index overlapping grid in full
screen mode (#168545)\n\n## Summary\r\n\r\nThis PR fixes an issue where
elements with defined z-index values\r\noverlap the grid in full screen
mode.\r\n\r\nBefore:\r\n<img width=\"2007\"
alt=\"before\"\r\nsrc=\"49f5ad02-5c23-4e63-bf15-959ce1b822f0\">\r\n\r\nAfter:\r\n<img
width=\"2007\"
alt=\"after\"\r\nsrc=\"46d5ce0a-533a-4b7e-b9d0-be9ec75f2018\">\r\n\r\nFlaky
test run:\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3453\r\n\r\nFixes
#168331.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cc8e3e4f2e963e99dbcabc2258c0576d8a37a0e6"}}]}]
BACKPORT-->
 2023-10-27 19:37:36 +02:00
Devon Thomson
71f15cee5a
[8.11] [Controls] Fix flaky time slider test (#169553) (#169968) 
# Backport

Fixes https://github.com/elastic/kibana/issues/169967

This will backport the following commits from `main` to `8.11`:
- [[Controls] Fix flaky time slider test
(#169553)](https://github.com/elastic/kibana/pull/169553)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-10-23T19:57:51Z","message":"[Controls]
Fix flaky time slider test (#169553)\n\nCloses
https://github.com/elastic/kibana/issues/169404\r\n\r\n##
Summary\r\n\r\nThe `Pin start` tooltip has a tendency to get in the way
of the\r\n`timeSlider-nextTimeWindow`
button:\r\n\r\n\r\n![image](dc4855ab-6c59-4003-83f1-de778f97b0f8)\r\n\r\nTo
prevent this, I've made it so that the popover is closed
**before**\r\nthe `next` button is pressed.\r\n\r\n\r\n### [Flaky
Test\r\nRunner](d339d256-dced-4bbd-b287-e04cd1268835)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eea3b1b8f46071eb2f154b07d3fd472a9ae09964","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:critical","backport:skip","v8.12.0"],"number":169553,"url":"https://github.com/elastic/kibana/pull/169553","mergeCommit":{"message":"[Controls]
Fix flaky time slider test (#169553)\n\nCloses
https://github.com/elastic/kibana/issues/169404\r\n\r\n##
Summary\r\n\r\nThe `Pin start` tooltip has a tendency to get in the way
of the\r\n`timeSlider-nextTimeWindow`
button:\r\n\r\n\r\n![image](dc4855ab-6c59-4003-83f1-de778f97b0f8)\r\n\r\nTo
prevent this, I've made it so that the popover is closed
**before**\r\nthe `next` button is pressed.\r\n\r\n\r\n### [Flaky
Test\r\nRunner](d339d256-dced-4bbd-b287-e04cd1268835)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eea3b1b8f46071eb2f154b07d3fd472a9ae09964"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169553","number":169553,"mergeCommit":{"message":"[Controls]
Fix flaky time slider test (#169553)\n\nCloses
https://github.com/elastic/kibana/issues/169404\r\n\r\n##
Summary\r\n\r\nThe `Pin start` tooltip has a tendency to get in the way
of the\r\n`timeSlider-nextTimeWindow`
button:\r\n\r\n\r\n![image](dc4855ab-6c59-4003-83f1-de778f97b0f8)\r\n\r\nTo
prevent this, I've made it so that the popover is closed
**before**\r\nthe `next` button is pressed.\r\n\r\n\r\n### [Flaky
Test\r\nRunner](d339d256-dced-4bbd-b287-e04cd1268835)\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eea3b1b8f46071eb2f154b07d3fd472a9ae09964"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
 2023-10-26 13:24:45 -06:00
Kibana Machine
028a9fd940
[8.11] [Discover] Fix Discover sidebar nav link global state syncing (#169905) (#169947) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Discover] Fix Discover sidebar nav link global state syncing
(#169905)](https://github.com/elastic/kibana/pull/169905)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-10-26T14:22:36Z","message":"[Discover]
Fix Discover sidebar nav link global state syncing (#169905)\n\n##
Summary\r\n\r\nThis PR fixes an issue where global state was not being
synced to the\r\nDiscover sidebar nav link when modifying it from other
applications,\r\nsuch as Lens.\r\n\r\nFixes #165899.\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"63db41ddae6885a6266fd9d89d0e41193c3d1b39","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.12.0"],"number":169905,"url":"https://github.com/elastic/kibana/pull/169905","mergeCommit":{"message":"[Discover]
Fix Discover sidebar nav link global state syncing (#169905)\n\n##
Summary\r\n\r\nThis PR fixes an issue where global state was not being
synced to the\r\nDiscover sidebar nav link when modifying it from other
applications,\r\nsuch as Lens.\r\n\r\nFixes #165899.\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"63db41ddae6885a6266fd9d89d0e41193c3d1b39"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169905","number":169905,"mergeCommit":{"message":"[Discover]
Fix Discover sidebar nav link global state syncing (#169905)\n\n##
Summary\r\n\r\nThis PR fixes an issue where global state was not being
synced to the\r\nDiscover sidebar nav link when modifying it from other
applications,\r\nsuch as Lens.\r\n\r\nFixes #165899.\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"63db41ddae6885a6266fd9d89d0e41193c3d1b39"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
 2023-10-26 09:15:08 -07:00
Kibana Machine
bfa39c7d4d
[8.11] Add a slight delay before selecting a visualization type (#169851) (#169917) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Add a slight delay before selecting a visualization type
(#169851)](https://github.com/elastic/kibana/pull/169851)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-10-26T09:50:04Z","message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":169851,"url":"https://github.com/elastic/kibana/pull/169851","mergeCommit":{"message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169851","number":169851,"mergeCommit":{"message":"Add
a slight delay before selecting a visualization type (#169851)\n\n##
Summary\r\n\r\nAttempt at fixing
https://github.com/elastic/kibana/issues/89958\r\n\r\nAs per my
[latest\r\ncomment](https://github.com/elastic/kibana/issues/89958#issuecomment-1779553320)\r\non
the issue, I believe that the test logic sometimes fails to
select\r\nthe appropriate visualisation type, in this case `Text` (aka
markdown).\r\n\r\nThe failure manifests [a couple of
steps\r\nlater](https://github.com/elastic/kibana/blob/main/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts#L155),\r\nas
this operation does not meet the expected \"before state\".\r\n\r\nThe
strategy of this fix consists in introducing an extra step,\r\nsearching
for the visualisation type, which should give the UI enough\r\ntime to
attach an event handler to the
control.","sha":"3d19006052a33b224b03c7fbda2ed408d9a43462"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
 2023-10-26 04:04:13 -07:00
Kibana Machine
809fc58ebd
[8.11] [Dashboard navigation] Fix flaky test (#167896) (#169573) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Dashboard navigation] Fix flaky test
(#167896)](https://github.com/elastic/kibana/pull/167896)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2023-10-23T19:28:04Z","message":"[Dashboard
navigation] Fix flaky test (#167896)\n\nFixes #167713 and
#169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not
ready (still loading) when the\r\ntest was trying to click on them. When
they finish loading the element\r\nwas stale, triggering the
StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the
Links embeddable when all of the child\r\ncomponents have finished
loading.\r\n\r\nIn a future PR, we should consider re-factoring such
that the async\r\ndashboard fetching happens in the LinksComponent and
the results are\r\npassed as props to the DashboardLinkComponents. This
would be more\r\nReact-like. I resisted making that change in this PR so
that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test
runner 🤞
\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.11.0","v8.12.0"],"number":167896,"url":"https://github.com/elastic/kibana/pull/167896","mergeCommit":{"message":"[Dashboard
navigation] Fix flaky test (#167896)\n\nFixes #167713 and
#169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not
ready (still loading) when the\r\ntest was trying to click on them. When
they finish loading the element\r\nwas stale, triggering the
StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the
Links embeddable when all of the child\r\ncomponents have finished
loading.\r\n\r\nIn a future PR, we should consider re-factoring such
that the async\r\ndashboard fetching happens in the LinksComponent and
the results are\r\npassed as props to the DashboardLinkComponents. This
would be more\r\nReact-like. I resisted making that change in this PR so
that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test
runner 🤞
\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167896","number":167896,"mergeCommit":{"message":"[Dashboard
navigation] Fix flaky test (#167896)\n\nFixes #167713 and
#169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not
ready (still loading) when the\r\ntest was trying to click on them. When
they finish loading the element\r\nwas stale, triggering the
StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the
Links embeddable when all of the child\r\ncomponents have finished
loading.\r\n\r\nIn a future PR, we should consider re-factoring such
that the async\r\ndashboard fetching happens in the LinksComponent and
the results are\r\npassed as props to the DashboardLinkComponents. This
would be more\r\nReact-like. I resisted making that change in this PR so
that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test
runner 🤞
\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833"}}]}]
BACKPORT-->

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
 2023-10-23 14:33:41 -07:00
Tiago Costa
9a37cd53fd
skip flaky suite (#166893) 2023-10-20 00:00:15 +01:00
Kibana Machine
4718dbf316
[8.11] [TSVB] Try to stabilize the test (#169254) (#169407) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[TSVB] Try to stabilize the test
(#169254)](https://github.com/elastic/kibana/pull/169254)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-10-19T14:24:57Z","message":"[TSVB]
Try to stabilize the test (#169254)\n\n## Summary\r\n\r\nHopefully
stabilizes this flakiness\r\n\r\nCloses
https://github.com/elastic/kibana/issues/167728\r\n\r\nRun 100
times:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3593","sha":"1fcdd3428ce6188e8456f0f4d14abe95487401b6","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","failed-test","release_note:skip","backport:prev-minor","v8.11.0","v8.12.0"],"number":169254,"url":"https://github.com/elastic/kibana/pull/169254","mergeCommit":{"message":"[TSVB]
Try to stabilize the test (#169254)\n\n## Summary\r\n\r\nHopefully
stabilizes this flakiness\r\n\r\nCloses
https://github.com/elastic/kibana/issues/167728\r\n\r\nRun 100
times:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3593","sha":"1fcdd3428ce6188e8456f0f4d14abe95487401b6"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169254","number":169254,"mergeCommit":{"message":"[TSVB]
Try to stabilize the test (#169254)\n\n## Summary\r\n\r\nHopefully
stabilizes this flakiness\r\n\r\nCloses
https://github.com/elastic/kibana/issues/167728\r\n\r\nRun 100
times:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3593","sha":"1fcdd3428ce6188e8456f0f4d14abe95487401b6"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
 2023-10-19 08:29:45 -07:00
Kibana Machine
56931545af
[8.11] unskips application leave confirm & application deep links tests (#168741) (#169395) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [unskips application leave confirm & application deep links tests
(#168741)](https://github.com/elastic/kibana/pull/168741)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-10-19T13:03:24Z","message":"unskips
application leave confirm & application deep links tests
(#168741)\n\nfix https://github.com/elastic/kibana/issues/166838\r\nfix
https://github.com/elastic/kibana/issues/166893\r\nfix
https://github.com/elastic/kibana/issues/75963\r\n\r\nI modified the
deep links tests because the side nav was overlaying the\r\nin-app
nav.\r\nWhile, theoretically, the side nav should work for the tests, it
tends\r\nto be flaky.\r\n\r\nI added logs for the url so that if these
tests do fail, we'll have a\r\nbit more data to go on for
debugging.\r\nThese tests pass on local test runs.\r\n\r\nlatest flaky
test runs
(50):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3604\r\n\r\n\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e811b624ff5e706a283949a406af31bf090e963c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Core","release_note:skip","v8.11.0","v8.12.0"],"number":168741,"url":"https://github.com/elastic/kibana/pull/168741","mergeCommit":{"message":"unskips
application leave confirm & application deep links tests
(#168741)\n\nfix https://github.com/elastic/kibana/issues/166838\r\nfix
https://github.com/elastic/kibana/issues/166893\r\nfix
https://github.com/elastic/kibana/issues/75963\r\n\r\nI modified the
deep links tests because the side nav was overlaying the\r\nin-app
nav.\r\nWhile, theoretically, the side nav should work for the tests, it
tends\r\nto be flaky.\r\n\r\nI added logs for the url so that if these
tests do fail, we'll have a\r\nbit more data to go on for
debugging.\r\nThese tests pass on local test runs.\r\n\r\nlatest flaky
test runs
(50):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3604\r\n\r\n\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e811b624ff5e706a283949a406af31bf090e963c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168741","number":168741,"mergeCommit":{"message":"unskips
application leave confirm & application deep links tests
(#168741)\n\nfix https://github.com/elastic/kibana/issues/166838\r\nfix
https://github.com/elastic/kibana/issues/166893\r\nfix
https://github.com/elastic/kibana/issues/75963\r\n\r\nI modified the
deep links tests because the side nav was overlaying the\r\nin-app
nav.\r\nWhile, theoretically, the side nav should work for the tests, it
tends\r\nto be flaky.\r\n\r\nI added logs for the url so that if these
tests do fail, we'll have a\r\nbit more data to go on for
debugging.\r\nThese tests pass on local test runs.\r\n\r\nlatest flaky
test runs
(50):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3604\r\n\r\n\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e811b624ff5e706a283949a406af31bf090e963c"}}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
 2023-10-19 07:26:17 -07:00
Kibana Machine
a87d94b096
[8.11] Re-word partial data message (#168883) (#168896) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Re-word partial data message
(#168883)](https://github.com/elastic/kibana/pull/168883)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-10-13T21:29:38Z","message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.11.0","v8.12.0"],"number":168883,"url":"https://github.com/elastic/kibana/pull/168883","mergeCommit":{"message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168883","number":168883,"mergeCommit":{"message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600"}}]}]
BACKPORT-->

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
 2023-10-13 15:50:38 -07:00
Kibana Machine
d07ab61a4b
[8.11] [Search] Unskip Search examples handling warnings test (#168367) (#168669) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Search] Unskip Search examples handling warnings test
(#168367)](https://github.com/elastic/kibana/pull/168367)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthias
Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2023-10-12T05:35:12Z","message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Search","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.12.0"],"number":168367,"url":"https://github.com/elastic/kibana/pull/168367","mergeCommit":{"message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168367","number":168367,"mergeCommit":{"message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}}]}]
BACKPORT-->

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
 2023-10-11 23:39:20 -07:00
Tiago Costa
76cd287364
skip flaky suite (#168648) 2023-10-11 19:49:46 +01:00
Tiago Costa
c17f5787ef
skip flaky suite (#163207) 2023-10-11 18:37:30 +01:00
Kibana Machine
f12738f365
[8.11] fix flaky test Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js (#168500) (#168615) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [fix flaky test Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js
(#168500)](https://github.com/elastic/kibana/pull/168500)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-10-11T14:31:06Z","message":"fix
flaky test Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js
(#168500)\n\nCloses
https://github.com/elastic/kibana/issues/168029\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3447\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f088e55fdde2066f2d5f4fa528d382112b6320f8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.11.0","v8.12.0"],"number":168500,"url":"https://github.com/elastic/kibana/pull/168500","mergeCommit":{"message":"fix
flaky test Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js
(#168500)\n\nCloses
https://github.com/elastic/kibana/issues/168029\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3447\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f088e55fdde2066f2d5f4fa528d382112b6320f8"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168500","number":168500,"mergeCommit":{"message":"fix
flaky test Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js
(#168500)\n\nCloses
https://github.com/elastic/kibana/issues/168029\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3447\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f088e55fdde2066f2d5f4fa528d382112b6320f8"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
 2023-10-11 08:50:05 -07:00
Kibana Machine
14e9682520
[8.11] [Event annotations] expand and stabilize listing page tests (#168139) (#168477) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Event annotations] expand and stabilize listing page tests
(#168139)](https://github.com/elastic/kibana/pull/168139)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2023-10-10T13:57:52Z","message":"[Event
annotations] expand and stabilize listing page tests (#168139)\n\n##
Summary\r\n\r\nFix #167434 (reenables embeddable test)\r\nFix
https://github.com/elastic/kibana/issues/168281\r\n\r\nFlaky test runner
(100
times):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3417\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3131bc228124e8641dca52508cffd91c14290564","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:prev-minor","v8.12.0"],"number":168139,"url":"https://github.com/elastic/kibana/pull/168139","mergeCommit":{"message":"[Event
annotations] expand and stabilize listing page tests (#168139)\n\n##
Summary\r\n\r\nFix #167434 (reenables embeddable test)\r\nFix
https://github.com/elastic/kibana/issues/168281\r\n\r\nFlaky test runner
(100
times):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3417\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3131bc228124e8641dca52508cffd91c14290564"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168139","number":168139,"mergeCommit":{"message":"[Event
annotations] expand and stabilize listing page tests (#168139)\n\n##
Summary\r\n\r\nFix #167434 (reenables embeddable test)\r\nFix
https://github.com/elastic/kibana/issues/168281\r\n\r\nFlaky test runner
(100
times):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3417\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3131bc228124e8641dca52508cffd91c14290564"}}]}]
BACKPORT-->

Co-authored-by: Drew Tate <drew.tate@elastic.co>
 2023-10-10 08:00:25 -07:00
Kibana Machine
de6dcb416d
[8.11] Fixes rendering service config keys test (#167937) (#168143) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Fixes rendering service config keys test
(#167937)](https://github.com/elastic/kibana/pull/167937)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T17:59:19Z","message":"Fixes
rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses
#157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests
by introducing a retry loop to get\r\ninjected metadata after
navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in
this test gets removed some time after navigation\r\n(e.g. to
`.../render/core`). It appears that occasionally this test\r\nfails to
read the tag before it is removed.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:all-open","v8.11.0","v8.12.0"],"number":167937,"url":"https://github.com/elastic/kibana/pull/167937","mergeCommit":{"message":"Fixes
rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses
#157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests
by introducing a retry loop to get\r\ninjected metadata after
navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in
this test gets removed some time after navigation\r\n(e.g. to
`.../render/core`). It appears that occasionally this test\r\nfails to
read the tag before it is removed.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167937","number":167937,"mergeCommit":{"message":"Fixes
rendering service config keys test (#167937)\n\nCloses #167142\r\nCloses
#157126\r\n\r\n## Summary\r\n\r\nFortifies the rendering service tests
by introducing a retry loop to get\r\ninjected metadata after
navigation. The `kbn-injected-metadata` tag that\r\nwe're relying on in
this test gets removed some time after navigation\r\n(e.g. to
`.../render/core`). It appears that occasionally this test\r\nfails to
read the tag before it is removed.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3363\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"335a751c00b2743d4e4adf53425f1fb45a54e883"}}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
 2023-10-05 12:12:05 -07:00
Kibana Machine
6518d71387
[8.11] [ftr] fix url check by excluding port (#168112) (#168128) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[ftr] fix url check by excluding port
(#168112)](https://github.com/elastic/kibana/pull/168112)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T16:28:46Z","message":"[ftr]
fix url check by excluding port (#168112)\n\n##
Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when
`actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless
Common UI - Management Data View Management disables scripted fields
Scripted fields tab is missing\r\n--\r\n  | │ Error: retry.try timeout:
Error: expected
https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks
both on MKI and local serverless
run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","v8.9.3","v8.12.0","v8.11.1"],"number":168112,"url":"https://github.com/elastic/kibana/pull/168112","mergeCommit":{"message":"[ftr]
fix url check by excluding port (#168112)\n\n##
Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when
`actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless
Common UI - Management Data View Management disables scripted fields
Scripted fields tab is missing\r\n--\r\n  | │ Error: retry.try timeout:
Error: expected
https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks
both on MKI and local serverless
run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.11"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168112","number":168112,"mergeCommit":{"message":"[ftr]
fix url check by excluding port (#168112)\n\n##
Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when
`actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless
Common UI - Management Data View Management disables scripted fields
Scripted fields tab is missing\r\n--\r\n  | │ Error: retry.try timeout:
Error: expected
https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks
both on MKI and local serverless
run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-10-05 10:44:26 -07:00
Kibana Machine
6e13c279d0
[8.11] [Discover] Fix flaky chart interval test (#167977) (#168060) 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Discover] Fix flaky chart interval test
(#167977)](https://github.com/elastic/kibana/pull/167977)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T07:38:09Z","message":"[Discover]
Fix flaky chart interval test (#167977)\n\n- Closes
https://github.com/elastic/kibana/issues/146223\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3317","sha":"a2a7f4254000f53d764b49c760a2ffbf93f73041","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.12.0"],"number":167977,"url":"https://github.com/elastic/kibana/pull/167977","mergeCommit":{"message":"[Discover]
Fix flaky chart interval test (#167977)\n\n- Closes
https://github.com/elastic/kibana/issues/146223\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3317","sha":"a2a7f4254000f53d764b49c760a2ffbf93f73041"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167977","number":167977,"mergeCommit":{"message":"[Discover]
Fix flaky chart interval test (#167977)\n\n- Closes
https://github.com/elastic/kibana/issues/146223\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3317","sha":"a2a7f4254000f53d764b49c760a2ffbf93f73041"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
 2023-10-05 05:16:36 -07:00
Nathan Reese
9e304027e5
unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group2/embeddable/add_to_dashboard·js (#167566) 
Closes https://github.com/elastic/kibana/issues/167320

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3278

Flakiness caused by https://github.com/elastic/kibana/pull/166991. Cause
of flakiness is not waiting for dashboard-picker to finish loading
options after setting the search value.

Flaky test highlights 3 other problems with
`SavedObjectSaveModalDashboard` component that are resolved in this PR:
1) Dashboard select not disabled when "New" or "None" is selected.
Regression from https://github.com/elastic/kibana/pull/166991
2) There is no form validation message giving visual feedback when users
click "Save" with "Existing" and no selected dashboard.
3) https://github.com/elastic/kibana/pull/166991 switched dashboard
selector from `EuiComboBox` to `EuiSelectable`. This changed the
behavior of selecting the same item. With the `EuiComboBox`
implemenation, selecting the same item retained the selection while
selecting the same item with the `EuiSelectable` implementation
unselected the item.

<img width="300" alt="Screenshot 2023-09-29 at 12 51 29 PM"
src="edd8d647-b8b6-4ecc-8f91-d1ad9e916a95">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2023-10-04 08:29:28 -06:00
Nathan Reese
8b89c940c2
Unskip flaky test functional/apps/dashboard/group2/dashboard_filter_bar·ts (#167825) 
Closes https://github.com/elastic/kibana/issues/167175

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3292

Test failing because actions buttons are not visible. Screen shot from
failed test shows cell did not get selected. PR adds retry around
getting action button logic to ensure cell is clicked again in the event
the action button is not found

Notice how cell is not selected in screen shot below.
<img width="500" alt="Screenshot 2023-10-03 at 10 57 23 AM"
src="51432ea8-1a75-4182-bb1c-49f87a3d1070">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-10-04 08:29:00 -06:00
Mykola Harmash
48be97bea2
[Infra UI] Add custom threshold alerts for serverless (#167639) 
Closes https://github.com/elastic/kibana/issues/166612

## Summary

- Adds a `customThresholdAlertsEnabled` feature flag
- Based on the feature flag shows an additional menu item in the alerts
dropdown
- Adds flyout component for rendering the custom alerts flyout

**Serverless**
<video
src="4fc79427-1e0c-4692-8525-b3b35e8a04e9"
controls="controls"></video>

**Traditional**

![Traditional](b2c16478-a40d-4312-a41e-5e34c98daa47)

## How to test

- Checkout locally and run in serverless mode (infra plugin on)
- Make sure you see the "Create custom threshold alert" menu item in the
"Alerts and rules" dropdown
- Click on the item and make sure you can create an alert
- Run Kibana in traditional mode and make sure the dropdown item is not
there
 2023-10-04 15:06:55 +02:00
Carlos Crespo
ede81cfdb0
[Infra UI] Disable Osquery in serverless (#167233) 
closes https://github.com/elastic/kibana/issues/163280

## Summary

Disables OSquery in serverless. 


<img width="1670" alt="image"
src="0ece0503-a5f3-46a1-a99b-29285088526c">

<img width="1670" alt="image"
src="5d20aaa4-7bdc-47e5-b9c2-469ecf62ab1f">


<img width="1670" alt="image"
src="97874aee-be98-4f0a-984a-562abbd4187d">

Osquery is now only used in the Asset Details flyout/full-page view. The
header component in the Asset Details now checks the feature flag object
to show/hide the OSquery tab.

### How to test

- Start a local es instance: `yarn es serverless --kill --clean
--license trial --ssl`
- Enable `infra` in the `serverless.oblt.dev.yml` file:
  - `xpack.infra.enabled: true`
- Start a local kibana instance: `yarn serverless-oblt --ssl` and see if
the side nav contains the Infrastructure item
- Navigate to `https://0.0.0.0:5601/ftw/app/metrics` and open the Asset
Details flyout from Inventory and Hosts View. Navigate to the details
view and check that Osquery tab isn't present.

- Confirm if OSquery tab is present in stateful.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2023-10-04 12:48:30 +02:00
Nathan Reese
f17b2ab8c0
unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group1/preserve_url·ts (#167836) 
closes https://github.com/elastic/kibana/issues/166900

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3295

Flaky test because `await appsMenu.clickLink('Dashboard', { category:
'kibana' });` is opening dashboard application. Looking at the screen
shot, kibana stays on home page. Looking at the logs, the context menu
is opened and Dashboard link is clicked. PR resolves flakiness by adding
retry around appsMenu.clickLink.

<img width="600" alt="Screenshot 2023-10-02 at 3 52 19 PM"
src="5f3535c0-94d2-48c4-8d9b-15c4433bfe81">

<img width="600" alt="Screenshot 2023-10-02 at 3 52 42 PM"
src="9fc890e2-9f98-4078-87a1-d5cec8cee0e6">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2023-10-03 17:01:37 -06:00
Tiago Costa
2daa9dc3a7
skip flaky suite (#167175) 2023-10-03 16:20:07 +01:00
Efe Gürkan YALAMAN
8d9e12a19b
[Enterprise Search] Update connector tiles (#167656) 
## Summary

- Update Integration Tiles
- Update Select Connector Tiles
- GitHub, OneDrive, Google Drive to native connectors

<img width="1427" alt="Screenshot 2023-09-29 at 16 38 08"
src="49607717-9c1d-4b73-8ae9-612c13641671">
<img width="1243" alt="Screenshot 2023-09-29 at 16 38 13"
src="f2ca0c1f-95ab-4f59-9baa-5fc59a42d5dc">
<img width="1317" alt="Screenshot 2023-09-29 at 16 38 25"
src="b8c758d5-f615-4ba7-805f-e944712b8777">
<img width="1366" alt="Screenshot 2023-09-29 at 16 38 44"
src="ca102329-e40c-4ebd-b7d4-6184b18bf0c2">
<img width="1452" alt="Screenshot 2023-09-29 at 16 38 51"
src="f6116d57-9a68-4538-8b92-7c296886c0bd">



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2023-10-03 14:33:13 +02:00
Tiago Costa
7fdd25184d
skip flaky suite (#98240) 2023-10-03 12:08:42 +01:00
Stratoula Kalafateli
105935ace5
[TSVB] Stabilize flaky TSVB test (#167848) 
## Summary

Closes https://github.com/elastic/kibana/issues/167791

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3282
Flaky runner (50 times)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
 2023-10-03 12:15:34 +03:00
Faisal Kanout
d28227ca6a
[AO] Set the Custom Threshold ONLY available on stateful as Tech Preview (#167782) 
## Summary
It fixes https://github.com/elastic/kibana/issues/167650
 2023-10-02 20:34:16 +03:00
Kibana Machine
6d343316a4 skip failing test suite (#167142) 2023-10-02 12:35:50 -04:00
renovate[bot]
b0a39cdeb7
Update dependency @elastic/charts to v60 (main) (#166799) 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
[`59.1.0` ->
`60.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/59.1.0/60.0.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@elastic%2fcharts/60.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@elastic%2fcharts/60.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@elastic%2fcharts/59.1.0/60.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@elastic%2fcharts/59.1.0/60.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&#8203;elastic/charts)</summary>

###
[`v60.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6000-2023-09-20)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v59.1.0...v60.0.0)

##### Bug Fixes

- **deps:** update dependency
[@&#8203;elastic/eui](https://togithub.com/elastic/eui) to ^88.2.0
([#&#8203;2161](https://togithub.com/elastic/elastic-charts/issues/2161))
([6609a19](6609a19231))
- **deps:** update dependency
[@&#8203;elastic/eui](https://togithub.com/elastic/eui) to ^88.3.0
([#&#8203;2163](https://togithub.com/elastic/elastic-charts/issues/2163))
([624f43a](624f43a0f8))
- **deps:** update dependency
[@&#8203;elastic/eui](https://togithub.com/elastic/eui) to v85
([#&#8203;2113](https://togithub.com/elastic/elastic-charts/issues/2113))
([1b3fa7c](1b3fa7c34a))
- **deps:** update dependency
[@&#8203;elastic/eui](https://togithub.com/elastic/eui) to v87
([#&#8203;2145](https://togithub.com/elastic/elastic-charts/issues/2145))
([312c32c](312c32cb71))
- **deps:** update dependency
[@&#8203;elastic/eui](https://togithub.com/elastic/eui) to v88
([#&#8203;2154](https://togithub.com/elastic/elastic-charts/issues/2154))
([4070da0](4070da0c1f))
- **tooltip:** rendering in react v18
([#&#8203;2169](https://togithub.com/elastic/elastic-charts/issues/2169))
([f30df54](f30df5444f))
- update font family
([#&#8203;2165](https://togithub.com/elastic/elastic-charts/issues/2165))
([be07b0c](be07b0c216))
- **waffle:** remove alpha artifacts
([#&#8203;2139](https://togithub.com/elastic/elastic-charts/issues/2139))
([8eb4ede](8eb4edecf8))
- Wait a tick before reporting render status
([#&#8203;2131](https://togithub.com/elastic/elastic-charts/issues/2131))
([fd2bca4](fd2bca4ee2))
- **xy:** disable legend extra on ordinal
([#&#8203;2114](https://togithub.com/elastic/elastic-charts/issues/2114))
([3ddfb18](3ddfb1816b))

##### Features

- add locale prop to Settings
([#&#8203;2164](https://togithub.com/elastic/elastic-charts/issues/2164))
([0bb3ab1](0bb3ab1f3a))

##### BREAKING CHANGES

- **xy:** when using the `ScaleType.Ordinal` for the X scale the legend
extra value, representing the last and current hovered value, will not
be shown.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/elastic/kibana).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Drew Tate <drew.tate@elastic.co>
 2023-10-02 11:42:24 -04:00
Kibana Machine
f0e00aef1e skip failing test suite (#167713) 2023-09-30 10:05:08 -04:00
Devon Thomson
8ffa8d8ee4
[Dashboard] Store view mode in local storage (#166523) 
Moves the Dashboard view mode from session storage to local storage. This means that users will only need to enter edit mode **once** if they are an editor, and any subsequent Dashboards they open will already be in edit mode.
 2023-09-29 19:46:18 -04:00
Kibana Machine
be98e218c0 skip failing test suite (#167661) 2023-09-29 13:45:14 -04:00
Hannah Mudge
9e8312f2e4
[Dashboard Navigation] Make links panel available under technical preview (#166896) 
## Summary
This PR wraps up the work the @elastic/kibana-presentation team has done
to finish the MVP of [Phase
1](https://github.com/elastic/kibana/issues/154354) of the `Link`
embeddable, which enables users to add panels to their dashboard that
contain links to other dashboards + external links - with respect to
dashboard links, we give the author control over which pieces of context
should be kept across dashboards so that things like filter pills,
queries, and time ranges are not lost. This marks a huge improvement in
dashboard navigation overall, which was previously only available via a
variety of different workarounds including (but not limited to):
- Creating (essentially) a `noop` dashboard-to-dashboard drilldown 
- Using markdown panels with hard Dashboard links, which are prone to
break across updates
- Avoiding navigation all together, which resulted in large,
slow-to-load dashboards.

As an added benefit, because these panels contain **references** to each
dashboard rather than hard links, (1) unlike markdown links, they should
not break after updates and (2) if a links panel is exported and
imported into another space or instance, all of the dashboards it links
to will also be imported.



1a86b713-47e7-4db9-8a04-29d41b13681a

> **Note**
> 🔉 The above video has audio! Turn on your sound for the best
experience.

### Note about this PR
- A majority of this work was done on a feature branch, with thorough
reviews from @andreadelrio on behalf of @elastic/kibana-design along the
way. Therefore, while feedback on the design is encouraged, any large
concerns brought up in this PR should be filed as separate issues and
addressed in follow-up PRs.
- This PR contains work for giving embeddables control over their own
panel size / default positioning on the dashboard. This was especially
important for the links panel, since we assume that (a) most links
panels would be located somewhere near the top of the dashboard and (b)
the horizontal links panel should have a different default "shape"
(longer than it is tall) than the vertical panel (taller than it is
long).
- This PR also contains work for caching dashboard saved objects, which
makes navigation much more seamless.

### Flaky Test Runner
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3251


![image](7616443e-0cb0-43ce-a1d0-41f8bee6cbfc)


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~ This will
be addressed in a follow up:
https://github.com/elastic/kibana/issues/166750
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios - ~Units tests
are added, functional tests are forthcoming~ Edit: All tests are in.
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
 2023-09-29 08:25:51 -06:00
Mykola Harmash
d0a0a1f9e6
[Infra IU] Disable Metrics Explorer for serverless (#167022) 
Closes #163282 

## Summary

This PR:
* Adds a `featureFlags.metricsExplorerEnabled` property to the Infra
plugin config to enable and disable Metrics Explorer depending on the
offering type
* Prevents `MetricsExplorerViewsService` initialization for serveless
based on the feature flag
* Prevents creating Metrics Explorer frontend routes when in serverless
* Prevents registration of the MetricsExplorerViews saved object when in
serverless
* Prevents initialization of the `metrics_explorer_views` API routes
when in serverless

**Trying to access Metrics Explorer in serverless**
<img width="1829" alt="CleanShot 2023-09-22 at 12 59 35@2x"
src="2b039925-0f0b-4c07-be29-bbe910de7a34">

**Trying to access views API**
<img width="1829" alt="CleanShot 2023-09-22 at 13 00 00@2x"
src="15269ec2-becd-4ee3-9b5e-d916df28a7b8">

**`infra/metrics_explorer` API still works as per ticket requirements**
<img width="1829" alt="CleanShot 2023-09-22 at 13 00 06@2x"
src="fb23f912-c6fd-46c8-9084-c17c51e5b064">


## How to test
* Checkout locally
* Enable Infra in `serverless.oblt.yml`: `xpack.infra.enabled: true`
* Run Kibana in serverless mode
* Try accessing `/app/metrics/explorer` route and make sure it's not
available
* Make sure other Infra routes (`/app/metrics/inventory` and
`/app/metrics/hosts`) still load as expected
* In Kibana dev console make sure you get 404 for `GET
kbn:/api/infra/metrics_explorer_views`
* Also check that you don't see `metrics-explorer-view` saved object in
the response for `GET
kbn:/api/kibana/management/saved_objects/_allowed_types`
* Run Kibana in non-serverless mode and make sure Metrics Explorer is
accessible and works as usual

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2023-09-29 11:27:19 +02:00
Jason Rhodes
859ae9e50d
[Asset Manager] Creates baseline public asset client for use in public plugins (#167191) 
Closes #167075 

## Summary

Adds a public asset client available in the `setup` lifecycle hook for
plugins that depend on this one. `getHosts` is the only method available
on this client for now.

TODO, before merge:
- [x] Add docs for the server client
- [x] Add docs for the public client
- [x] Remove REST docs from plugin docs, not needed
- [x] Add unit tests for public client


### Testing this PR

One way of testing this new client is to apply the attached
test-assets.patch file locally, adjust the date range in the getHosts
query that is added in the infra plugin, and then start Kibana and
navigate to the infra app. You should see print out in the browser
console.


[test-assets.patch](12718693/test-assets.patch)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-09-28 13:26:24 -07:00
Rudolf Meijering
239e50389f
Revert "[inspector] show request method, path, and querystring" (#167485) 
This reverts commit d61a5a0516 from
#166565

## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
 2023-09-28 14:27:14 +02:00
Marco Vettorello
b12a42261b
[Lens] Color mapping for categorical dimensions (#162389) 
## Summary

This PR introduces the new color mapping feature into Lens.

The color mapping feature is introduced as a standalone sharable
component available from `@kbn/coloring`. The
[README.md](ddd216457d/packages/kbn-coloring/src/shared_components/color_mapping/README.md)
file describes the components and the logic behind it.

The Color Mapping component is also connected to Lens and is available
in the following charts:
- XY (you can specify the mappings from a breakdown dimension
- Partition (you can specify the mappings from the main slice/group by
dimension)
- Tag cloud (you can specify the mappings from the tags dimension)

This MVP feature will be released under the Tech Preview flag.
This PR needs to prove the user experience and the ease of use. UI
styles, design improvements and embellishments will be released in
subsequent PRs.

The current MVP-provided palettes are just a placeholder. I'm
coordinating with @gvnmagni for a final set of palettes.

close https://github.com/elastic/kibana/issues/155037
close https://github.com/elastic/kibana/issues/6480
fix https://github.com/elastic/kibana/issues/28618
fix https://github.com/elastic/kibana/issues/96044
fix https://github.com/elastic/kibana/issues/101942
fix https://github.com/elastic/kibana/issues/112839
fix https://github.com/elastic/kibana/issues/116634


## Release note

This feature introduces the ability to change and map colors to break
down dimensions in Lens. The feature provides an improved way to specify
colors and their association with categories by giving the user a
predefined set of color choices
or customized one that drives the user toward a correct color selection.
It provides ways to pick new colors and generate gradients. 
This feature is in Tech Preview and is enabled by default on every new
visualization but can be turned off at will.

![image](d03e59f8-4a6f-4761-ab4c-c53a57c1723a)
 2023-09-28 14:14:58 +02:00
Davis McPhee
3e1865513d
[Discover] Add resize support to the Discover field list sidebar (#167066) 
## Summary

This PR adds resize support to the Discover field list sidebar, which is
persisted to a user's local storage similar to the resizable chart
height.

Additionally it migrates the resizable layout code from Unified
Histogram to a new package called `kbn-resizable-layout` so it can be
shared between Discover and Unified Histogram, as well as act as a new
platform component that other teams can consume to create their own
resizable layouts.


![resize](71b9a0ae-1795-43c8-acb0-e75fe46e2a8a)

Resolves #9531.

### Checklist

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-09-27 21:52:25 -03:00
Kibana Machine
8838ac1d18 skip failing test suite (#167405) 2023-09-27 18:47:11 -04:00
Yulia Čech
e1b37a6aa3
[Index Management] Implement index details page (#165705) 
## Summary
This PR removes the feature flag and enables the new index details page
by default. The index details page was implemented in following PRs:
- https://github.com/elastic/kibana/pull/163521
- https://github.com/elastic/kibana/pull/163955
- https://github.com/elastic/kibana/pull/164741
- https://github.com/elastic/kibana/pull/165027
- https://github.com/elastic/kibana/pull/165038
- https://github.com/elastic/kibana/pull/165456

In this PR we completely remove now obsolete code for the old index
details flyout: react components and corresponding redux code. All
related tests are updated and cleaned up. The config value for Index
Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is
deprecated as unused and can be removed in v9.0.


### How to test
1. Start ES and Kibana with `yarn es snapshot` and `yarn start`
3. Navigate to Index Management and create an index
4. Click the index name in the table and check the tabs of the details
page
### Screenshots
#### Stateful
Overview 
<img width="1387" alt="Screenshot 2023-09-27 at 14 41 57"
src="e58b15e7-d10c-4473-873c-d0f128392404">


Mappings
<img width="1392" alt="Screenshot 2023-09-27 at 14 42 05"
src="441157cb-5a26-47c3-8da0-b4df51ebec5d">


Settings 
<img width="1385" alt="Screenshot 2023-09-27 at 14 42 13"
src="da66a2eb-1f21-44c1-9356-484c66caab88">


Statistics
<img width="1380" alt="Screenshot 2023-09-27 at 14 42 22"
src="ec93d85c-e754-4c21-88ab-0124dc114fc9">


Error loading data
<img width="1333" alt="Screenshot 2023-09-26 at 19 05 37"
src="fc1804b3-6aa0-4019-bae6-e7bb40113b28">
<img width="1327" alt="Screenshot 2023-09-26 at 19 06 07"
src="ca711697-cc74-4ba8-b17c-ec9b01f3026e">
<img width="1329" alt="Screenshot 2023-09-26 at 19 06 28"
src="0cb46b09-8542-452a-8845-40d060057e95">
<img width="1331" alt="Screenshot 2023-09-26 at 19 06 48"
src="87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8">


Error saving index settings
<img width="1332" alt="Screenshot 2023-09-26 at 19 07 31"
src="e6e4b3d0-c237-4d0a-995a-4562bc78f88e">


### Serverless
Overview 
<img width="1336" alt="Screenshot 2023-09-26 at 19 51 47"
src="6c76c23b-4be6-4ab3-ae1d-c7ae751e100d">


Mappings
<img width="1336" alt="Screenshot 2023-09-26 at 19 23 51"
src="625fa703-506f-4389-9df0-86441a655074">


Settings
<img width="1332" alt="Screenshot 2023-09-26 at 19 24 02"
src="c496ab09-f2db-4c1b-9fb6-1e9b64b1c142">


# Release note
Index details can now be viewed on a new index details page in Index
Management.
<img width="1387" alt="Screenshot 2023-09-27 at 14 41 57"
src="b90c706d-8b15-49e4-8f6a-cb66f3ed1822">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-09-27 11:22:26 -07:00