Commit graph

69601 commits

Author SHA1 Message Date
Tiago Costa
7992ca1673
skip flaky suite (#170052) 2023-11-21 16:17:22 +00:00
Tiago Costa
e9dba60ef9
skip flaky suite (#170985) 2023-11-21 16:11:58 +00:00
Tiago Costa
38f8765e71
skip flaky suite (#171641) 2023-11-21 16:10:44 +00:00
Tiago Costa
7e6bf40e49
skip flaky suite (#171650) 2023-11-21 16:08:03 +00:00
Tiago Costa
c4171beda0
skip flaky suite (#171649) 2023-11-21 16:07:14 +00:00
Tiago Costa
d748bc38e1
skip flaky suite (#171168) 2023-11-21 16:05:42 +00:00
Tiago Costa
c382428a19
skip flaky suite (#171654) 2023-11-21 15:58:55 +00:00
Tiago Costa
663c5f611f
skip flaky suite (#171653) 2023-11-21 15:57:57 +00:00
Tiago Costa
09a389f805
skip flaky suite (#171644) 2023-11-21 15:55:56 +00:00
Tiago Costa
0bc8d3872e
skip flaky suite (#171643) 2023-11-21 15:53:04 +00:00
James Gowdy
5e3b124ae0
[ML] Create categorization job from pattern analysis (#170567)
Adds the ability to quickly create a categorisation anomaly detection
job from the pattern analysis flyout.
Adds a new `created_by` ID `categorization-wizard-from-pattern-analysis`
which can be picked up by telemetry.

Creates a new package for sharing our AIOPs ui actions IDs. I think we
should move the pattern analysis ID to this package too, but that can be
done in a separate PR.


51349f93-f072-4983-85f0-98741902fb5a



6e618581-8916-4e63-930f-945c96c25e6c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 15:52:12 +00:00
Melissa Alvarez
39af788067
[ML] Trained models list: disable 'View training data' action if data frame analytics job no longer exists (#171061)
## Summary

Fixes https://github.com/elastic/kibana/issues/167667, disabling the
'View training data' action for models in the Trained Models list if the
data frame analytics job which created the model no longer exists

Adds `origin_job_exists` property to trained models list model items.
This is set during the models fetch for models with associated data
frame analytics jobs.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 08:50:38 -07:00
Alex Szabo
5256108075
Skip flaky endpoint tests (#171658)
## Summary
Several cases of flakiness on main:

  // https://github.com/elastic/kibana/issues/171655
  // https://github.com/elastic/kibana/issues/171656
  // https://github.com/elastic/kibana/issues/171647
  // https://github.com/elastic/kibana/issues/171648
2023-11-21 16:02:58 +01:00
Christiane (Tina) Heiligers
d8ef2d0fb1
Moves SOR bulkCreate unit tests to dedicated file (#171431) 2023-11-21 07:42:41 -07:00
Pete Hampton
540f2b632e
Remove Kibana Prometheus Exporter from documentation. (#171624)
## Summary

RE: https://github.com/pjhampton/kibana-prometheus-exporter/issues/344

I am sunsetting development on a community Kibana plugin I maintain.
This PR removes it from the official documentation.
2023-11-21 14:24:47 +00:00
Kurt
c5daa370c7
Upgrade chromedriver (#171545)
## Summary

Upgrade `chromedriver`

## Changelog

https://github.com/giggio/node-chromedriver/compare/117.0.3...119.0.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 09:21:37 -05:00
Alejandro Fernández Haro
55aebfdd2e
FullStory: use debounce before updating Page Vars (#171450) 2023-11-21 13:46:13 +00:00
Anton Dosov
f4e0d83598
[Serverless] Increase root breadcrumb width to reduce elipsis (#171515)
## Summary

close https://github.com/elastic/kibana/issues/170758

This PR increases root breadcrumb max width from 160 to 320px to fit
more of project titles. It also slightly adjusts number of visible
breadcrumbs per breakpoint to account for potentially 2x longer root
breadcrumb. Note that responsiveness is still not ideal as the system
doesn't actually calculate the width of each breadcrumb.


Before: 

<img width="1267" alt="Screenshot 2023-11-20 at 11 53 13"
src="6d2ba8d2-5bc0-4f85-a87a-a4185ae901f7">


After: 

<img width="1284" alt="Screenshot 2023-11-20 at 11 52 31"
src="90a57e58-6836-4465-a21e-78f72dc4953e">
2023-11-21 14:39:52 +01:00
Jonathan Budzenski
f51e6cd248 Revert "Upgrade to Node.js 20 (#162696)"
This reverts commit 029b3ba81d.
2023-11-21 07:15:23 -06:00
Pablo Machado
3a58207b53
[Security Solutions] Update new user details flyout to be consistent with Expandable Alerts Flyout (#169514)
## Summary
Update new user details flyout to be consistent with Expandable Alerts
Flyout. The previous user details flyout implementation was hidden
behind a flag and never went live.


![Screenshot 2023-11-09 at 15 42
59](0e4dee8a-0319-4531-8dcf-81cd88526aeb)


### What is included
* Update new user details flyout to use the expandable flyout component
* Update UI components according to the new design
* Keep the feature hidden behind newUserDetailsFlyout flag
* Supporting alert risk inputs

### What is NOT included
* Supporting multiple categories of risk inputs
* Host details flyout
* User and host pages
* Asset integrations (okta and azure)
* Update the flyout on the timeline (It is currently a technical
restriction of the expandable flyout, but the team is working to fix it)

### How to test it?
* Enable experimental flag `newUserDetailsFlyout`
`xpack.securitySolution.enableExperimental: ['newUserDetailsFlyout']`
* Create alerts and open alerts page
* Click on a username

- [x] Test edge cases
  - [x] No cases permissions (it hides cases actions)
  - [x] Basic license (it hides the risk score summary)  
- [x] No risk score data for a user (It hides the risk score summary)
<img width="434" alt="Screenshot 2023-11-13 at 15 56 33"
src="4fc13042-cd3d-487b-9982-bfbf02f003b4">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
2023-11-21 12:54:19 +01:00
Jill Guyonnet
e859b14711
[Fleet] Enable agent upgrade tooltip (#168638)
## Summary

Followup to https://github.com/elastic/kibana/pull/167539.

Closes https://github.com/elastic/ingest-dev/issues/2568.

As the version on which agents will have upgrade details is not known
yet, we decided to defer showing the tooltip for agents that don't until
it is (cf.
https://github.com/elastic/kibana/pull/167539#discussion_r1354346944).

This PR sets the version to 8.12.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 10:53:57 +01:00
Cristina Amico
10ec7132fa
[Fleet] Fix links to Logs view to point to Discover in Serverless (#171525)
Fixes https://github.com/elastic/kibana/issues/168349

## Summary
Fix links to Logs view to point to Discover in Serverless.

As the Logs view UI is not available in serverless, the "Open in logs"
buttons should point to Discover instead. Rather than hardcode the url
in each of the places where is needed, I extracted a small component
that builds the two urls and allows switching in an easier way.
If in the future on of the two links will go away, it will be easier to
find those occurrences.

### Testing
Test for serverless following [these
instructions](https://github.com/elastic/kibana/pull/167976)

**Error logs in agent activity flyout**
- Enroll an agent and try to cause some error - for instance upgrading
an agent that is not upgradeable
- Click on "Agent Activity" and find the error and a button besides it
- On stateful the button says "Open in Logs"

![Screenshot 2023-11-20 at 13 07
08](704cf0e2-c7ee-4751-9e7f-7dcd263a5aa4)

- On serverless is "Open in discover"

![Screenshot 2023-11-20 at 13 08
02](3902f09e-93dc-48d3-867e-1f80d977f437)

- Check that both show the same logs:

![Screenshot 2023-11-16 at 11 49
24](d863d99f-0c70-45e5-9316-a37645464c34)
![Screenshot 2023-11-16 at 11 48
54](7cbd0a5f-3b31-4c4d-a4b7-4eb7390983c8)


**Agent logs**
(Same test as above)
- Enroll an agent
- Click on the agent and go to the "Logs" tab
- On stateful the button says "Open in Logs"

![Screenshot 2023-11-20 at 13 04
41](6a43a062-37db-47ea-819f-acd170439395)

- On serverless is "Open in discover"

![Screenshot 2023-11-20 at 13 04
11](e15fdc8b-8780-4ac6-afc6-bff3d3a96be5)

- Check that both show the same logs

**Custom Logs UI**
There is also a link to logs on custom logs UI but I just linked to
discover for that one:
https://github.com/elastic/kibana/pull/171525/files#diff-e337aa916d60d0d1033e3298c8c9c33c6a6fcd87a8ded971a4a87f5ccfc0981fR20-R22

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 09:14:57 +01:00
Gloria Hornero
3bb16c7dcc
[Security Solution] Modifying the login method (#171383) 2023-11-21 08:08:19 +01:00
Kibana Machine
b8259a698d
[api-docs] 2023-11-21 Daily api_docs build (#171595)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/528
2023-11-21 01:11:28 -05:00
Philippe Oberti
dda4498fee
[Security Solution] improve and add Cypress tests for expandable flyout (#170993) 2023-11-20 16:03:14 -06:00
Thomas Watson
029b3ba81d
Upgrade to Node.js 20 (#162696)
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2023-11-20 21:47:48 +01:00
Tiago Costa
0a09215f0c
skip flaky suite (#169866) 2023-11-20 19:46:04 +00:00
Tiago Costa
b54d00debb
skip flaky suite (#171493) 2023-11-20 19:43:28 +00:00
Tiago Costa
0e565e197c
skip flaky suite (#171475) 2023-11-20 19:42:17 +00:00
Tiago Costa
edf8956053
skip flaky suite (#171481) 2023-11-20 19:41:11 +00:00
Tiago Costa
f045d9d130
skip flaky suite (#171476) 2023-11-20 19:39:57 +00:00
Tiago Costa
e15b5e69af
skip flaky suite (#171489) 2023-11-20 19:38:52 +00:00
Rickyanto Ang
5d8c050826
[Cloud Security][Bug Fix] Dashboard and Findings page now will only show result within retention period (#160313)
## Summary

Currently Findings and Dashboard page kept showing data even if the data
past its retention period. This PR will make it so that, it will only
show data within that retention period, If theres no more data past that
retention period it will show No Agent deployed prompt instead

Our solution/workaround for this will be adding a retention periods for
each kind of posture type:
**KSPM** and **CSPM** : 26 hours
**CNVM** and **all** : 3 days or 72 hours
if posture type doesnt exist : 72 hours (this is to cover the situation
where findings came before CSPM gets implemented back then)

Before when having Findings outside retention period:
<img width="1391" alt="Screenshot 2023-11-07 at 5 03 15 PM"
src="26f74ebf-8002-4da9-b4f1-8238e81cea5e">

After: (27 hours later)
<img width="1452" alt="Screenshot 2023-11-07 at 4 52 09 PM"
src="98a33379-dc21-4edf-97b6-32de584598e9">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-20 11:22:21 -08:00
Maryam Saeidi
8fd18fbb05
[Custom threshold] Add an adHoc data view API integration test (#171508)
Closes #170438

## Summary

This PR adds an ad hoc data view API integration test by changing one of
the existing custom threshold API integration tests.
2023-11-20 20:21:35 +01:00
Gloria Hornero
936a1a40ac
unskipping entity analytics tests (#170712) 2023-11-20 11:39:57 -07:00
Nicolas Chaulet
9be7fb0d87
[Fleet] Fix invalid kuery when updating integration (#171559) 2023-11-20 11:23:39 -07:00
Cee Chen
a723bd0cd7
[Unified Search] Change phrase(s) comboboxes to async patterns (#171427)
## Summary

This PR does NOT address
https://github.com/elastic/kibana/issues/158876, but helps reduce the
confusion/cognitive dissonance of the async search results only matching
on words from the start of the string, vs. `EuiComboBox` showing search
results from anywhere in the string by default.

Please see https://eui.elastic.co/#/forms/combo-box#async for more
documentation on async searching.

### Before

![image](https://user-images.githubusercontent.com/924948/270275373-0d0df8c3-3a03-40e9-bc79-ea353147e419.gif)

### After


![image](https://user-images.githubusercontent.com/549407/280421058-a7476a75-bfbe-49c6-be81-7bd0b46e048c.gif)

### Checklist

- ~[ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~ No tests found
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-11-20 10:01:56 -08:00
Josh Dover
8052f03f61
[Fleet] Cap setup attempts to 50 on Serverless (#171550)
## Summary

If there is a bug in Fleet setup, we can retrigger rollovers on each
attempt, causing shard explosion in Elasticsearch. We need a sane limit
to prevent this from happening, which this PR introduces.

The impact of Fleet setup failing to complete (Agents may not be able to
be enrolled) is much smaller than causing shard explosion, so this seems
like an acceptable tradeoff.

This is only a small part of the overall solution - in the current
incident we have, it's still unclear why we are failing to rollover the
index and getting into this loop.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-11-20 18:47:57 +01:00
Tomasz Ciecierski
d412e57897
[EDR Workflows] Fix Osquery cypress 11 (#171497) 2023-11-20 10:02:20 -07:00
Hannah Mudge
49b52fe76e
[Dashboard Navigation] Fix reference extract method (#171360)
Closes https://github.com/elastic/kibana/issues/164212
Closes https://github.com/elastic/kibana/issues/171328

## Summary

In `extractReferences`, the links in the `links` array attribute is [not
extensible](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_define_property_object_not_extensible)
- this means that we cannot add or delete properties from each
individual link directly. Instead, I've had to create a clone of each
dashboard link via the spread operator so that we aren't modifying the
original link directly.

**How to Test**
1. Create a by-value Links panel
2. Refresh the dashboard
3. Save the Links panel to the library via the panel action
4. The panel should be saved successfully **and** the panel title should
be updated.

[**Flaky Test
Runner**](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4024)


![image](b8949d44-697d-414a-9e98-14b0a6f67b31)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-20 09:40:07 -07:00
jennypavlova
3dbe1e434a
[ObsUX] Add Missing transaction warning if there are Transactions or Spans with a parent.id that doesn't exist in the trace (#171196)
Closes https://github.com/elastic/kibana/issues/25117

## Summary

Add a missing transaction warning if there are Transactions or Spans
with a `parent.id` that doesn't exist in the trace.


## Testing

- Use the `trace_with_orphan_items.ts` scenario: `node
scripts/synthtrace --clean trace_with_orphan_items.ts`
- In APM -> Traces there are 2 traces:
- <img width="1423" alt="image"
src="3548d1dd-d87f-4090-a028-d62cf8ec35c8">
- Check the traces: 
   - Incomplete trace (with warning):
- <img width="1401" alt="image"
src="a75a2112-a425-43d9-bdd1-b3724ccfe6e3">

   - Complete trace (no warning):
- <img width="1387" alt="image"
src="f33614ab-269b-447c-bd0b-bc00f9799092">
- Unit test in
[waterfall_helpers.test.ts](https://github.com/elastic/kibana/pull/171196/files#diff-6cdeaa931c0085a16353ac34f937d442a39e1227621f11b3de0608a39e949fc6)
2023-11-20 17:33:11 +01:00
Marco Antonio Ghiani
b83b4951ca
[ObsInfra][APM] Extract agent utils and custom icons (#170968)
## 📓 Summary

Closes #170728 

This work comes from the need to use agent and cloud provider icons in
the new Log Detail flyout.

Since those icons were already used across the `infra` and `apm`
plugins, this was a good opportunity to extract the shared logic into
packages.
The results of this refactoring are two new packages:
- **@kbn/elastic-agent-utils**: exports small utilities and type
definition used to parse the icon to render and exploits also across the
APM plugin.
- **@kbn/custom-icons**: exports custom icons built on top of EuiIcon,
encapsulating logic related to mapping from data to the relative icon.

Apart from creating the new plugins, this also applies their usage to
the `infra` and `apm` plugins, while the Log Explorer flyout will
benefit from these working on
https://github.com/elastic/kibana/issues/170721.

## 🧪 How to test

### Infra

- Navigate to `Infrastructure -> Hosts`
- Verify the hosts table correctly renders the cloud provider icon for
each table entry.

### APM

- Navigate to `APM -> Services`.
  - Verify each table entry correctly displays the related agent icon.

- Navigate to `APM -> Services`.
- Click on a service where t a cloud provider icon is expected to appear
next to the service name.
  - Verify the icon is correctly displayed.

- Navigate to `APM -> Services -> Service Map`.
  - Create a new group.
- Verify the agent icon is correctly displayed for each entry in the
preview list.

- Navigate to `APM -> Traces`.
  - Verify each table entry correctly displays the related agent icon.

- Navigate to `APM -> Settings -> Agent Explorer`.
  - Verify each table entry correctly displays the related agent icon.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-20 16:39:42 +01:00
amyjtechwriter
a968a2e3f5
[DOCS] Updating screenshot (#171549)
## Summary

Updating the screenshot on the '[Create links to other
dashboards](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)'
page in the 'Make dashboards interactive' section of the Kibana docs.
2023-11-20 15:24:53 +00:00
Yngrid Coello
75dc0c19a5
[Logs onboarding] Using logsSynthtrace in api integration tests (#171510)
This is a follow up PR coming from
https://github.com/elastic/kibana/pull/170124#discussion_r1377413323.

### Changes
- Removed `createLogDoc` in favor of `LogsSynthtraceEsClient`.
- Added `agent.id` as `LogDoc` known property.
2023-11-20 08:08:20 -07:00
Julia Bardi
6e46756132
[Fleet] hide remote es output in serverless (#171378)
## Summary

Relates https://github.com/elastic/kibana/issues/104986

Hide Remote Elasticsearch output in serverless from Create/Edit output
flyout.

Should we also add validation to prevent creating it in API?


Verified locally by starting kibana in serverless mode:
<img width="751" alt="image"
src="061514f3-25fe-4e52-ad85-194cc612bea7">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-11-20 09:57:07 -05:00
Sergi Massaneda
9bf7e38b1d
[Security Solution][Lens] Check filter action type to hide default filter actions in visualizations (#171284)
## Summary

Bug: https://github.com/elastic/kibana/issues/171167

The [previous
implementation](https://github.com/elastic/kibana/pull/170127) solved a
different bug using a new `shouldShowLegendAction` property. This
approach had a limitation on the Security Dashboards page since the
Security app has no control over the properties passed to the
visualization components when they are rendered through portable
Dashboards.

This PR fixes the problem by checking if any of the registered actions
is a "filter" action `type` in the visualizations. If customized filter
actions are found, the default filter actions hardcoded in the
visualizations code are not added, preventing duplication of filter
actions.

The specific action `type` used for the check is the
`FILTER_CELL_ACTION_TYPE = 'cellAction-filter'` constant exported by the
`@kbn/cell-actions` package.

This new approach uses a property stored in the registered actions
themselves, so we don't need to pass any extra property to the
visualization components, it works transparently. So the
`shouldShowLegendAction` property has also been cleaned.

## Demos

Timeline using `showTopN` visualization:


491c08e8-0740-4c9e-9cb7-81267b9ba040


Alerts page using `Counts` table visualization and `showTopN`
visualization


683eec6c-382e-4ae9-9400-c1022922e488


Portable Dashboard visualizations:


50f09a65-488d-41f2-a5b8-3882d9c80678


Security actions are "compatible" only inside the Security app, in the
Lens app the default filter actions are displayed:

<img width="1682" alt="lens-actions-screenshot"
src="1e7ce929-129d-45a9-ba71-8d28e3726454">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-20 15:33:31 +01:00
Thomas Watson
48711622bd
Upgrade handlebars from v4.7.7 to v4.7.8 (#171511) 2023-11-20 07:26:16 -07:00
Thomas Watson
4f9094caf3
Always throw error objects - never strings (#171498) 2023-11-20 09:23:16 -05:00
Søren Louv-Jansen
9523a78e7a
[APM] Make data view space aware (#170857)
Closes https://github.com/elastic/kibana/issues/169924
Related SDH: https://github.com/elastic/sdh-apm/issues/1080 (_internal_)

The APM data view is automatically created when opening the APM UI app
via a request to `POST /internal/apm/data_view/static`. This creates a
data view which is made available to all spaces. The problem with this
approach is that users can change index settings (apm index patterns)
per space, which means that there should be a data view per space as
well.

This PR ensures that a data view is created per space and that any links
to the data view uses the spaace specific dataview

---------

Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2023-11-20 08:15:13 -05:00
Alex Szabo
2a8a68c1f8
[Ops] Security Solution Endpoint: don't skip the whole suite, only on serverless (#171521)
## Summary
Correction from @gergoabraham - these tests are only failing in
serverless, so let's not skip the whole suite
2023-11-20 07:55:17 -05:00