## Summary
This PR removes the api call for ILM on the Reporting management page
for serverless. SInce ILM is not used by reporting in serverless, this
api get call does not need to execute.
### BEFORE
fetch.ts:123 GET
https://localhost:5601/ugz/internal/reporting/ilm_policy_status 404 (Not
Found)
<img width="1444" alt="Screenshot 2023-09-14 at 11 12 48 AM"
src="b695df38-7e3d-451e-8245-7753dd89039f">
This error in the console disappears after these changes.
---------
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Closes https://github.com/elastic/kibana/issues/170656
PR adds exists filter to ensure geo field exists
### Test instructions
1. In console, run:
```
PUT geo1
{}
PUT geo1/_mapping
{
"properties": {
"location": {
"type": "geo_point"
}
}
}
PUT geo1/_doc/1
{
"location": "25,25"
}
PUT geo2
{}
PUT geo2/_doc/1
{}
```
2. Create `geo*` data view
3. create new map
4. add documents layer from `geo*` data view.
5. Add heatmap layer from `geo*` data view.
6. Verify geo1 data is displayed and warning is not displayed fro geo2
shard failures
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
- ✅ Same height on both sides
- ✅ Maximize feature
- ❌ ~~Highlight the corresponding item on the other side~~
- ✅ Details of the corresponding item on the other side
dd81664e-b5ae-403d-847c-b56ca8881277
## Summary
Instead of using `useListsConfig` this PR uses `useListPrivileges` to
verify access to `.lists-*` index pattern.
follow up of elastic/kibana/pull/165613
related elastic/kibana/pull/170671 (closed in favour of this)
fixes elastic/kibana/issues/169268
### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes https://github.com/elastic/kibana/issues/162840
## Summary
This PR adds a visualization alias for the new Links embeddable so that
all Links library items can be managed/edited from the Visualization
library, like so:
8541506b-cfdd-4a2f-8bc2-841220def7a3
However, in order to get the above working, it was unfortunately not as
simple as just adding a visualization alias. Because the Links
embeddable does not have a dedicated editing app (all editing/creation
is done through a flyout), the usual `aliasPath` + `aliasApp` redirect
that happens for editing an alias did not work in this case.
To get around this, I've had to make changes to how aliases are
registered, as well as both the Visualization `VisualizeListing`
component and the generic `TableListViewTableComp` content management
component:
- **Summary of visualization alias changes:**
First off, I made changes to the typing of aliases - specifically,
rather than taking two independent `aliasPath` and `aliasApp` props,
I've combined them into a singular `alias` prop which will either be of
type `{ alias: string; path: string; }` or `{ embeddableType: string;
}`. This makes it easier to determine (a) whether a visualization is of
type `BaseVisType` or `VisTypeAlias` and (b) if it **is** of type
`VisTypeAlias`, how the editing of that vis should be handled.
Specifically, if `alias` is of type `{ alias: string; path: string; }`,
then it is a normal visualization and behaviour should be the same as it
was previously; however, if it is of type `{ embeddableType: string; }`,
then this is an **inline** alias - i.e. editing should be done inline
via the embeddable factory's edit method.
- **Summary of `VisualizeListing` changes**
The primary changes here were made to the `editItem` callback -
specifically, if the fetched saved object has neither an `editApp` nor
an `editUrl`, then it will now try to fetch the embeddable factory for
the given saved object type and, if this factory exists, it will call
the `getExplicitInput` method in order to handle editing.
- **Summary of `TableListViewTableComp` changes**
Previously, an error would be thrown if both a `getDetailViewLink` and
an `onClickTitle` prop were provided - while I understand the original
reasoning for adding this catch, this no longer works if we want to
support inline editing like this. In this case, I needed **only** the
Link embeddable items to have an `onClick` while keeping the behaviour
for other visualizations the same (i.e. all other visualization types
should continue to link off to their specific editor apps) - however,
since this method is not provided **per item**, I had no way of making
an exception for just one specific item type.
Therefore, to get around this, it is now considered to be valid for
**both** the `getDetailViewLink` and `onClickTitle` props to be defined
for the `TableListViewTableComp` component. In order to prevent conflict
between the two props, I have made it so that, if both are provided,
`getDetailViewLink` **always takes precedence** over `onClickTitle` - in
this case, `onClickTitle` will **only** be called if `getDetailViewLink`
returns `undefined` for a given item. I have added a comment to
hopefully make this clear for consumers.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Summary
Updates the openapi specs that I could find to correctly use the
`Authorization` header when using API Key authentication. Currently,
generated clients are specifying the incorrect (`ApiKey`) header and
failing to auth using and API Key.
## Summary
Adds GitHub integration fields to prebuilt rules filterlist.
Issue backrefed from private repo.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
It seems these tests were facing issues when running in Firefox but I
don't think it's critical that they run in both browsers so I'm
excluding Firefox and only running them in Chrome from now on.
Closes#171580Closes#171544Closes#171539Closes#171493Closes#171490
## Summary
This PR changes the KPI colors to a more neutral color scheme.
| Before | After |
| ------ | ------ |
| <img width="1898" alt="image"
src="51bb78e1-cf17-4652-8c77-a3b5e28dbdbe">
|
|
## Testing
- Go to host view:
- Check the KPI tiles' colors
- Open the host flyout and check them again
- Go to inventory and click on a host in the waffle map
- Check the KPI tiles' colors inside the flyout
- Click on open as page and check the kpi tiles there:
- <img width="1658" alt="image"
src="a61126ca-9eaf-493e-9d48-bc34ce7843fd">
Support to restore baseline/deviation time ranges from url state on full
page refresh. Also updates functional tests to include a full page refresh after the
first analysis run for each dataset.
## Summary
Currently, the diagnostic task is enqueueing alerts onto the production
queue. This is problematic and likely causes a lot of EP alert telemetry
loss in busy clusters. There is also a 100/1m cap on the queue which is
also a bottleneck for the diagnostic feed. I'm following up with a
bigger PR to move this query to a
[PIT](https://www.elastic.co/guide/en/elasticsearch/reference/current/point-in-time-api.html)
query.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
## Summary
Security Data Analytics would like to know when these files are updated.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## 📓 Summary
Closes#171485
This fix guarantees the JSON doc view will always get a minimum space
independently of the available space, to avoid the current scenario
where a scrollable flyout does not reserve enough space for the JSON tab
content tobe displayed (see recording in the related issue).
2c539047-32cd-4213-bc6f-3062de151426
---------
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
### Summary
Address https://github.com/elastic/kibana/issues/82002 and
https://github.com/elastic/kibana/issues/75440
I think I found a breakthrough for this flaky behavior. I run the
integration test 800x locally, with different settings:
Adjusting both the delayed emission (send 1 char at a time), and the
socket idle timeout to have exacly the same value (e.g. `10 millis`), I
managed to get the `ECONNRESET` 100% of the times.
Thus, IIUC the ECONNRESET happens when the client tries to send a
character over the socket and at the same time the server responds with
the idle timeout.
Adjusting the values so that the delay between character emissions is
significantly larger than the idle timeout, e.g. 20 vs 5, I get `socket
hang up` 100% of the times.
Flaky Test Runner Pipeline - 300x 🟢https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4030
This PR updates the URL to the Elastic Support Portal registered by the
Cloud plugin, to include the configured deployment ID as a querystring
parameter.
1. On serverless deployments, we set the projects unique identifier with
`?serverless_project_id=123ABC`
2. On stateful cloud deployments, we set the deployment's unique
identifier with `?cloud_deployment_id=123ABC`
3. On on-prem deployments functionality shall remain unchanged.
Where this link can be found in the UI:
I pushed this revert up initially via
e79ca5e9d6 while debugging an issue with
CI waiting for agents. This was not the root cause and can be
unreverted.
## Summary
Closes#160803
This PR removes the `CI Composite` story because it has been broken
since at least ac23dce29f (and possibly
since b862a6c181). The functionality is
covered by the generated `index.html` in
dda4498fee/.buildkite/scripts/steps/storybooks/build_and_upload.ts (L105-L120)
To fix the composite story requires generating `stories.json` for every
storybook, which requires migrating the repo off the deprecated
`storiesOf` API. That task is quite extensive and would be better
handled alongside an upgrade to Storybook 7.x
## Summary
Currently, Cypress is writing junit XML files that we are trying to map
to the expected CI format, but if the job fails the broken files are
still being uploaded and passed to the Flaky Test Reporter which causes
it to fail.
So the solution is to just delete the broken files before they are sent
to the Flaky Tests Reporter
Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
## Summary
Fixes https://github.com/elastic/kibana/issues/168194
Under some circumstance, when navigating to the timelines page, we would
get a runtime exception for `state.tableById[action.id]` not being
defined. When that happened, the redux store would be in a broken state.
This PR makes the responsible destructuring assignment more save.
Closes https://github.com/elastic/kibana/issues/167577
## Summary
Previously, the Link embeddable used the whole redux embeddable package
- however, the overall state that needs to be managed for this panel is
very simple, so this ended up being overkill. This PR fixes that by
adding a `useLinksAttributes` hook to replace the redux package that
subscribes to changes made to the attributes instead.
I also made two smaller changes in this PR:
1. Called the "Organize imports" command from VSCode on all of the
touched files - this explains all of the seemingly unrelated import
changes.
2. I fixed the React warning that was being thrown due to calling
`setIsSaving` after the component was unmounted.
### How to Test
To test number 2 above, create a by-reference Links panel and refresh
the dashboard. Then,
1. Make some sort of change to the Links panel, such as re-arranging the
links
2. Save the changes - note that, without the mount check, the following
React error will be thrown:
3. Now, with the mount check, this no longer happens 🎉
### Checklist
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
