Commit graph

6604 commits

Author SHA1 Message Date
Ignacio Rivas
d86ce77217
Remove kbn-ace, ace and brace dependencies (#195703) 2024-10-10 14:16:42 +02:00
Tim Sullivan
56e1e68b30
[ES|QL] Present ES|QL as an equal to data views on the "no data views" screen (#194077)
## Summary

Resolves https://github.com/elastic/kibana/issues/176291

### Screenshots

#### Discover/Dashboard/Visualize
<img width="1517" alt="image"
src="https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3">

#### Stack Management > Data view
<img width="1519" alt="image"
src="https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3">

#### If User does not have privilege to create a Data View
<img width="1336" alt="image"
src="https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Use a new SVG resource for the ES|QL illustration
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
2024-10-09 23:44:30 +02:00
Rodney Norris
71fd96ad8b
[Search][FTR] Solution Nav (#195327)
## Summary

Adding `functional_search` suite with a set of test for the search
solution navigation. But this suite will also grow to test search
solution pages that do not require the enterprise search node.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
2024-10-09 08:45:24 -05:00
Marco Antonio Ghiani
9907601dd1
[LogsUI] Add UI setting to hide Logs Stream and dashboard panel option (#194519)
## 📓 Summary

Closes #193319 
Closes #193320 

This work is part of the effort to progressively deprecate the existing
Logs Stream feature.

Changes taken on this PR consist of:
- Create a new uiSettings `observability:enableLogsStream` which
defaults to `false` on the stateful/cloud deployments and is not
available in serverless ones (still, defaults to `false` behind the
scene).
- When `observability:enableLogsStream` is `false`, the Logs Stream page
route is not registered, and neither is its deep link for global search.
- When `observability:enableLogsStream` is `false`, the panels list on
Dashboard won't show anymore the option `Logs Stream (Deprecated)` to
prevent usage of this embeddable in new dashboards. The embeddable is
still registered for retro-compatibility with active dashboards, and it
has now a callout explaining the status of this embeddable
(unmaintained/deprecated).
- Rename logs ML to "Logs Anomalies" and "Logs Categories".

Other minor improvements regard:
- Remove duplicate Xstate utils and use the relative package instead.
- Remove the duplicated `useBoolean` hook used in the deprecation
callout.
- Sync deep links registration with available routes through a single
`getLogsRoutes` util.

## 🎥 Recordings

### Logs Stream app removed


https://github.com/user-attachments/assets/f4173294-8789-4abd-9972-29c9b7c197ed

### Logs Stream dashboard panel entry removed


https://github.com/user-attachments/assets/7f99ca2a-c030-4867-b976-8fdc1df09d29

### Logs Stream app removed from project nav


https://github.com/user-attachments/assets/de51bdd6-820a-4c03-8b64-fb1a6ced0a12

### Embeddable deprecation callout

<img width="949" alt="Screenshot 2024-10-02 at 10 22 09"
src="https://github.com/user-attachments/assets/99fd5554-004b-45e4-81db-cb23947e210e">

### Unavailable setting in serverless


https://github.com/user-attachments/assets/91bf6c37-0845-4918-a485-b6250bbd96bf

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
2024-10-09 10:14:06 +02:00
Davis McPhee
11ff4a9b2e
Fix monaco editor functional test service check (#195154)
## Summary

This PR fixes a monaco editor functional test service check that was
added in #193851. The check validates that the editor updates with the
correct text content, but it looks like it may run a bit too quickly
sometimes before the DOM has a chance to update.

Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.

Flaky test runs:
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7099

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-10-08 12:58:15 -03:00
Tre
3a3f1300a5
Add param to cmn/mgmt/data_views/_edit_field.ts and make stateful test match (#194934)
## Summary

Resolves: https://github.com/elastic/kibana/issues/194917
2024-10-07 13:22:26 +01:00
Rodney Norris
a84b3f841c
[Search][Homepage] Remove usage (#194870)
## Summary

Removing search home usage from serverless search and enterprise search.
The search home page project is on hold while we re-assess requirements.
Until we know when we are starting that back up I'm removing the feature
flagged usage to simplify other work. When we spin this back up usage
will likely be different anyway with other projects like onboarding and
the updating navigation refactor in enterprise_search.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-10-04 13:30:37 -05:00
Panagiota Mitsopoulou
ab715099b0
Implement new nav hierarchy for stateful/cloud (#192805)
<strike>Depends on https://github.com/elastic/kibana/issues/193526,
WON'T FIX</strike>

Fixes https://github.com/elastic/kibana/issues/192803
Fixes https://github.com/elastic/kibana/issues/191509

This PR updates the nav hierarchy for stateful/cloud and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the Figma file and the discussions happening in this
[issue](https://github.com/elastic/kibana/issues/192050). I took a video
below of how the new navigation looks like with the new changes



https://github.com/user-attachments/assets/e73c8dd9-b674-4146-bcde-443490569502

## What was changed
- AI & ML menu is removed and split into
  - `AI Assistant`
- `Machine learning`: this menu was already present in the footer, it
was moved in the body (after Infrastucture)
- `Applications` now opens a `panelOpener` instead of an `accordion`
  - Synthetics was moved to a new section
  - “User Experience” was renamed to “User experience”  
- `Infrastucture` now opens a `panelOpener` instead of an `accordion`
  - Universal Profiling was moved to a separate section below
  - Metrics Explorer was renamed to Metrics explorer
- `Machine learning` now opens a `panelOpener` instead of an `accordion`
- `Supplied Configurations` was added under the Machine learning >
Anomaly Detection section.
- The machine learning `link:
'securitySolutionUI:machine_learning-landing'` was completely removed.
Clicking on the `Machine learning` link will slide out the panel instead
(same behavior with clicking on the icon). More details about why I
removed this
[here](https://github.com/elastic/kibana/pull/192805#issuecomment-2359368851)
  - Use sentence/case for the menu items
- `Other tools` now opens a `panelOpener` instead of an `accordion`
  - Logs anomalies was added here
  - Logs categories was added here
  - Visualize library was added
- Clicking on the 1st level menu items (Applications, Infrastructure,
Machine learning, Other tools) toggles the panel on the right
(arrowRight).
- The icon was changed from the four small squares to the right-facing
caret
- The sub-nav menu slides out to the right whenever the label OR the
icon are clicked
- `Getting started` in the footer was renamed to `Add data`
- `Data Set Quality` was added under `Stack Management > Data` section
below `Index Management`


## Functional Tests
Some tests have been added that test:
- toggling of the panel when clicking on the link button
- `AI assistant` changes
- `Infrastructure` changes
- `Other Tools` changes
- `Machine Learning` changes


## What this PR doesn't do
I faced some issues with the footer, so footer will be separately
handled in this [issue](https://github.com/elastic/kibana/issues/192865)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
2024-10-04 11:02:57 +03:00
Davis McPhee
2653000d63
[Discover] Fix test skipped in #193293 (#194889)
## Summary

This PR fixes the test skipped in #193293 after the Chrome 129 upgrade.
The issue was slightly less screen space causing the saved search save
popover to get in the way of the `@timestamp` column header, which we
were trying to click.

Flaky test runs:
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7080

Part of #193354.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-10-04 01:12:07 -03:00
Kylie Meli
c0e2d95050
[Automatic Import] Add experimental features to integration_assistant plugin (#194699)
## Summary

This PR adds experimental features to the integration_assistant plugin.
I used the fleet and security solutions plugins as references, and
implemented them exactly as they have. Currently nothing is actually
using this.

To be able to utilize this, add
`xpack.integration_assistant.enableExperimental: ['testFeature']` to the
config.

Tested by adding to the config and verifying correct output in console
via [test
logs](74ddf3786e (diff-177cfac6e94662a2089f6c56000726e1a1924f9222caaf8bcb1312a7583c110eR60)).
2024-10-03 09:09:52 -04:00
Anton Dosov
568e40acca
Clean up cloud_chat (#194571)
## Summary

Close https://github.com/elastic/kibana-team/issues/1017

This PR removes the unused Cloud Chat functionality from Kibana. The
chat was not used for some time. Moreover, we've seen some issues with
it where users saw it when it wasn't expected. Given the absence of
automated tests and the fact that the feature is no longer needed, we
are removing it to improve the overall maintainability and reliability
of the codebase. This will also decrease the amount of code loaded for
trial users of Kibana in cloud making the app slightly faster.
2024-10-03 13:37:47 +02:00
Tre
620b8bfbf8
[FTR] fix flaky: cmn/mgmt/data_views/_edit_field.ts (#194738)
## Summary

What I tried before pushing

1. Better specificity - Couldn't get it just right (due to the dom
structure)
1. Changing dom structure - Couldn't do that how I would like, due to
the structure of `.tsx` file

So, I went with adding a service method that simply filters down by two
table dropdowns, instead of one.
_Sadly I spend most of my time with the specificity (different css
combinators), so lesson learned there_.
 
Also, cleaned up the test code to simply call the service method and
nothing more.

### Note
~~Will probably drop the other added service method
(`openEditFlyoutByRowNumber`)~~ 


Resolves: https://github.com/elastic/kibana/issues/194662
2024-10-03 11:14:41 +01:00
Tiago Costa
e2ebe2b8a4
skip flaky suite (#193895) 2024-10-02 16:38:09 +01:00
Matthias Wilhelm
b7af143114
Fix flaky test #194043 (#194670)
Fixing `getRowIndicatorProvider should render log.level row indicators on Surrounding documents page` by waiting a bit longer for the table to be rendered.
2024-10-02 15:43:59 +02:00
elastic-renovate-prod[bot]
30ef0ecb3c
Update dependency @elastic/charts to v67 (main) (#193694)
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | major | [`66.1.1` ->
`67.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/66.1.1/67.0.0)
|

---
### Breaking changes

Elastic-charts theme API for line and area charts has changed:
- the `point.visible` type for line and area charts is now a union
between `'always' | 'never' | 'auto'`. Always and Never will replace the
previous boolean configuration, `auto` instead will provide a logic to
show the points only of the distance between consecutive points is
bigger than the `pointVisibilityMinDistance`.
- the isolatedPoint style for line and area doesn't contain the `radius`
parameter anymore. The radius is derived from the `line.strokeWidth`
parameter.

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
2024-10-02 10:52:56 +02:00
Kibana Machine
5da67c71ae skip failing test suite (#194043) 2024-10-02 04:52:20 +10:00
Marco Vettorello
34fb654303
[Lens][LogsDB] Add test suite (#194031)
## Summary

Test suite for LogsDB in Kibana

Adding tests for the following scenarios:
* [x] All Lens operations (aggs) should work fine with a LogsDB stream
* Mixed index scenarios
  * [x] LogsDB stream (upgraded from regular stream)
  * [x] LogsDB stream without `host.name` field in the mapping
  * [x] LogsDB stream (upgraded from regular stream) + regular index
  * [x] LogsDB stream (upgraded from regular stream) + TSDB stream
* [x] LogsDB stream (upgraded from regular stream) + another LogsDB
stream
* [x] LogsDB stream (upgraded from regular stream) + TSDB stream
downsampled
  * [x] Data stream (downgraded from LogsDB stream)
  * [x] Data stream without `host.name` field in the mapping
  * [x] Data stream (downgraded from LogsDB stream) + regular index
  * [x] Data stream (downgraded from LogsDB stream) + TSDB stream
* [x] Data stream (downgraded from LogsDB stream) + another LogsDB
stream
* [x] Data stream (downgraded from LogsDB stream) + TSDB stream
downsampled

For the mixed scenario suite the following tests are performed:
* Create a date histogram vs `count(bytes)`
  * same test but using the `utc_time` field rather than `@timestamp`
* Create a chart with an annotation layer
* same test but using the `utc_time` for both data and annotation layer
* use the `host.name`, `utc_time`, `@timestamp` as extra field in the
annotation tooltip
* Create a visualization with ES|QL using `STATS`

---------

Co-authored-by: dej611 <dej611@gmail.com>
2024-10-01 14:29:10 +02:00
Stratoula Kalafateli
dfe00f20dd
[ES|QL] Adds the ability to breakdown the histogram in Discover (#193820)
## Summary

Part of https://github.com/elastic/kibana/issues/186369

It enables the users to breakdown the histogram visualization in
Discover.


![meow](https://github.com/user-attachments/assets/d5fdaa41-0a69-4caf-9da2-1221dcfd5ce2)


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-10-01 11:29:32 +02:00
Kibana Machine
cc02343d36 skip failing test suite (#193868) 2024-10-01 10:17:13 +10:00
Kibana Machine
48b2099e0d skip failing test suite (#184600) 2024-10-01 10:15:14 +10:00
Cee Chen
8a89c8576d
Upgrade EUI to v95.12.0 (#193805)
`v95.11.0``v95.12.0-backport.0`

> [!note]
> A few fun highlights from this release:
> - Content within `EuiDataGrid`, `EuiBasicTable`, and
`EuiInMemoryTable`, when manually selected/highlighted by users, should
now more cleanly copy and paste into various spreadsheet apps
> - `EuiProvider` will now detect the user's system-level dark or light
mode and default to that if no `colorMode` prop is passed manually

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0)

- Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content
newlines/tabs when users copy and paste from their tabular data
([#8019](https://github.com/elastic/eui/pull/8019))
- Updated `EuiResizableButton` with a new `accountForScrollbars` prop
([#8021](https://github.com/elastic/eui/pull/8021))
- Updated `EuiProvider` to inherit from the user's OS/system light/dark
mode setting if a `colorMode` prop has not been passed
([#8026](https://github.com/elastic/eui/pull/8026))

**Bug fixes**

- Fixed `EuiDatePicker`'s `onClear` button to not appear when the input
is `disabled` ([#8020](https://github.com/elastic/eui/pull/8020))
- Fixed several `EuiDataGrid` row height bugs:
([#8025](https://github.com/elastic/eui/pull/8025))
- Fixed row heights not recalculating when
`rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or
`gridStyles.cellPadding` changed
- Fixed incorrect height calculations for `rowHeightOptions.rowHeights`
with `lineCount`s
- Fixed control column content to align better with multi-line row
heights, as well as custom line-heights
##
[`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0)

**This is a backport release only intended for use by Kibana.**

**Bug fixes**

- Fixed `EuiProvider`'s system color mode detection causing errors
during server-side rendering
([#8040](https://github.com/elastic/eui/pull/8040))
- Fixed an `EuiDataGrid` rendering bug that was causing bouncing
scrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))
2024-09-30 18:25:47 -05:00
Julia Rechkunova
7aa64b6ed5
[OneDiscover] Add EBT event to track field usage (#193996)
- Closes https://github.com/elastic/kibana/issues/186156
- Closes https://github.com/elastic/kibana/issues/189454

## Summary

This PR adds new EBT event type `discover_field_usage` which we use for
tracking adding and removing grid columns and adding filters via
+/-/exists buttons. Properties of the added events consist of:

`eventType`: `dataTableSelection`, `dataTableRemoval`, or
`filterAddition`
`fieldName`: name of the field if it's from ECS schema
`filterOperation`: `+`, `-`, or `_exists_`


<img width="1002" alt="Screenshot 2024-09-25 at 17 51 27"
src="https://github.com/user-attachments/assets/b3f3fb69-55e1-43b2-9683-a6d8884f56fe">

## Testing

Enable "Usage collection" global setting.

Navigate to Discover and observe `kibana-browser` requests in Network
tab.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-09-30 11:20:21 -05:00
Marco Antonio Ghiani
36a73ce52e
[One Discover] Add summary column for logs contextual experience (#192567)
## 📓 Summary

Closes https://github.com/elastic/logs-dev/issues/165

This work introduces a Summary column as a replacement for the Document
one for the Discover logs contextual experience.
> We also decided to port this change as a replacement for the
**resource** and **content** virtual columns in Logs Explorer to have a
better alignment between the 2 apps.

## 🎥 Demo


https://github.com/user-attachments/assets/3dfca483-768e-471c-8735-d5fc8bbd5d00

## 💡 Reviewer hints

I left notes through the changes to help answer some questions.

The notable changes on this PR are:
- Rename `Document` column to `Summary`.
- Refactor `resource` and `content` virtual columns into a single
`Summary` column, which replaces the default Summary content for the
logs' contextual experience.
- Provide support for the plugin services to the context awareness
profiles.
- Disable virtual columns (clean up will go in a follow-up work) in Logs
Explorer and rely on the Summary column as the default selection.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2024-09-30 11:08:03 +02:00
Davis McPhee
0ac69658bf
[Discover] [Unified Doc Viewer] Fix doc viewer not receiving focus on open (#191039)
## Summary

This PR fixes an issue where the new resizable doc viewer push flyout
was not receiving focus on open, resulting in the flyout having to be
manually focused in before users can navigate between docs using the
arrow keys. It also re-adds support for closing the flyout when pressing
the escape key, improves overall focus management, ensures the proper
a11y attributes are used when the push flyout is shown, and introduces a
new set of functional tests for doc viewer keyboard navigation and a11y.

Fixes #190946.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-09-30 00:25:26 -03:00
Lukas Olson
a9fa11e7da
Fix search session filter functional test (#193812)
## Summary

Fixes https://github.com/elastic/kibana/issues/192510.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2024-09-27 13:28:53 -07:00
Ignacio Rivas
8af23349e1
[Console] Fix small UX bugs (#193887) 2024-09-27 15:09:46 +02:00
Charis Kalpakis
e41b38b634
Add functional tests for painless lab flyout 2024-09-27 13:07:38 +03:00
Julia Rechkunova
6fc017a597
[Discover] Dismiss flyouts when opening another one (#193865)
- Closes https://github.com/elastic/kibana/issues/193452

## Summary

This PR makes sure that only one flyout is open at a time and
automatically dismisses all others.


### Checklist


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2024-09-27 02:35:31 -05:00
Kibana Machine
de8c5999e8 skip failing test suite (#194043) 2024-09-27 03:29:02 +10:00
Julia Rechkunova
e1f90cc393
[Discover] Unskip vis tests (#194020)
- Closees https://github.com/elastic/kibana/issues/184600
2024-09-26 13:36:41 +02:00
Julia Rechkunova
7b76160d68
[UnifiedDocViewer] Filter on field name and value in expanded document view (#192299)
- Closes https://github.com/elastic/kibana/issues/163275

## Summary

With this PR users can search by field value (raw and formatted) in
DocViewer flyout.

<img width="569" alt="Screenshot 2024-09-06 at 20 49 57"
src="https://github.com/user-attachments/assets/27e89017-4b8f-437b-9e00-b9a24eb88184">
<img width="544" alt="Screenshot 2024-09-06 at 20 50 09"
src="https://github.com/user-attachments/assets/5086af87-df97-4fdb-84c3-f30c547678e0">
<img width="536" alt="Screenshot 2024-09-12 at 18 45 11"
src="https://github.com/user-attachments/assets/abdfe31d-85a5-41de-bf05-88ecf0ac2b18">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-09-26 02:11:34 -05:00
Julia Rechkunova
6808f82662
[Discover] Add "Shift + Select" functionality to Discover grid (#193619)
- Closes https://github.com/elastic/kibana/issues/192366

## Summary

This PR allows to select/deselect multiple rows by holding SHIFT key
when toggling row checkboxes.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2024-09-25 04:38:49 -05:00
Kibana Machine
ed9c3b5e41 skip failing test suite (#193868) 2024-09-25 08:31:39 +10:00
Julia Rechkunova
c28af871d2
[Discover] Extend EBT context with a list of activated context-aware profiles (#192908)
- Closes https://github.com/elastic/kibana/issues/186109

## Summary

This PR extends EBT context with `dscProfiles` - a list of active
context-aware profiles.

<img width="981" alt="Screenshot 2024-09-16 at 17 30 47"
src="https://github.com/user-attachments/assets/64d49abc-3ee0-4d5a-8283-cdca5d78f963">


## Testing

Enable "Usage collection" global setting.

Navigate to Discover and observe `kibana-browser` requests in Network
tab.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-09-24 16:08:21 -05:00
Cee Chen
9bbb296078
Upgrade EUI to v95.11.0 (#192756)
`v95.10.1``v95.11.0`

> [!note]
> The bulk of this release is **EuiDataGrid**. The component has been
fully converted to Emotion, and several UX changes have been made to
data cell actions. We recommend QA testing any data grid(s) that have
custom styles applied to them.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.11.0`](https://github.com/elastic/eui/releases/v95.11.0)

- Updated `EuiText`, `EuiTextColor`, and `EuiTextAlign` with a new
`component` prop that allows changing the default rendered `<div>`
wrapper to a `<span>` or `<p>` tag.
([#7993](https://github.com/elastic/eui/pull/7993))
- Updated `EuiDataGrid`'s cell actions to always consistently be
left-aligned, regardless of text content alignment
([#8011](https://github.com/elastic/eui/pull/8011))
- Increased `EuiDataGrid`'s cell actions hover zone to reduce UX
friction when mousing over from the grid cell to its actions
([#8011](https://github.com/elastic/eui/pull/8011))

**Bug fixes**

- Fixed `EuiPopover` to correctly inherit from `EuiProvider`'s
`componentDefaults.EuiPortal.insert`
([#8003](https://github.com/elastic/eui/pull/8003))
- Fixed push `EuiFlyoutResizable`s to not potentially block scrollbars
on outside content ([#8010](https://github.com/elastic/eui/pull/8010))
- Fixed an `EuiDataGrid` bug where the `setCellProps` callback passed by
`renderCellValue` was not correctly applying custom `data-test-subj`s
([#8011](https://github.com/elastic/eui/pull/8011))

**Accessibility**

- Updated the `EuiBasicTable` actions button's `aria-label` by adding a
reference to the current row
([#7994](https://github.com/elastic/eui/pull/7994))

**CSS-in-JS conversions**

- Converted `EuiDataGrid`'s toolbar controls to Emotion
([#7997](https://github.com/elastic/eui/pull/7997))
  - Removed `$euiDataGridPopoverMaxHeight`
- Converted `EuiDataGrid` to Emotion
([#7998](https://github.com/elastic/eui/pull/7998))
  - Removed `$euiZDataGrid`
  - Removed `$euiZHeaderBelowDataGrid`
- Converted `EuiDataGrid`'s `gridStyle`s to Emotion; Removed the
following Sass variables and mixins:
([#8006](https://github.com/elastic/eui/pull/8006))
  - `$euiDataGridCellPaddingS`
  - `$euiDataGridCellPaddingM`
  - `$euiDataGridCellPaddingL`
  - `$euiDataGridVerticalBorder`
  - `$euiDataGridPrefix`
  - `$euiDataGridStyles`
  - `@euiDataGridSelector`
  - `@euiDataGridStyles`
- Converted `EuiDataGrid`'s cell popover, actions, and focus outline to
Emotion; Removed the following Sass variables and mixins:
([#8011](https://github.com/elastic/eui/pull/8011))
  - `$euiZDataGridCellPopover`
  - `@euiDataGridCellFocus`
- Converted `EuiDataGrid`'s row, header, and footer cells to Emotion;
Removed the following Sass variables and mixins:
([#8013](https://github.com/elastic/eui/pull/8013))
  - `$euiDataGridColumnResizerWidth`
  - `@euiDataGridRowCell`
  - `@euiDataGridHeaderCell`
  - `@euiDataGridFooterCell`
2024-09-23 15:45:19 -07:00
Stratoula Kalafateli
d56a1bbbba
[ES|QL] Renames the textbased editor to esql editor (#193521)
## Summary

Renames the text-based-editor to esql-editor

I tried to also rename components, data-test-subj, classNames and files.
My focus is mostly on the plugin and package of the esql editor

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-09-23 12:06:53 +02:00
Kibana Machine
3dbf11e00b skip failing test suite (#165745) 2024-09-21 03:23:09 +10:00
Yulia Čech
52aa453003
[Console] Allow mixed case methods (#193445)
## Summary

Fixes https://github.com//elastic/kibana/issues/186774
This PR is re-opened from https://github.com/elastic/kibana/pull/190527
after too many merge conflicts.

This PR adds a new function to the parser to allow mixed case methods
like GeT, posT etc





### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-09-20 15:28:02 +02:00
Ignacio Rivas
5ea37fb470
[Console] Fix and skip flaky tests (#193508) 2024-09-20 11:45:55 +02:00
Rachel Shen
6030231246
[Dashboard] Sharing via link to an expanded panel (#190086)
## Summary

Closes https://github.com/elastic/kibana/issues/145454

This PR allows users with a dashboard with an expanded (maximized) panel
to be shared to other users via url or the share modal link. To
implement this, the expanded panel Id is added to the url:

`/app/dashboard/{dashboardID}/{expandedPanelID}_g()_a()`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Hannah Mudge <hannah.wright@elastic.co>
2024-09-19 11:38:21 -06:00
Kibana Machine
e524ed6a1a skip failing test suite (#193309) 2024-09-19 23:37:40 +10:00
Alex Szabo
f47987f540
[ci] skip FTRs that fail on chrome 129 (#193293)
## Summary
`google-chrome-stable` is now on version 129. Another set of tests
started to fail when running against a VM with unpinned chrome version:
https://buildkite.com/elastic/kibana-pull-request/builds/235162

This PR skips another 3 tests and adjusts all messages to point to the
central issue.

Relates to: https://github.com/elastic/kibana-operations/issues/199
2024-09-19 17:53:15 +10:00
Alejandro Fernández Haro
02ce1b9101
[Feature Flags Service] Hello world 👋 (#188562)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
2024-09-18 11:02:55 -05:00
Kibana Machine
b3b776fb99 skip failing test suite (#192510) 2024-09-18 23:39:08 +10:00
Kibana Machine
6f9262ab1b skip failing test suite (#165745) 2024-09-18 23:30:18 +10:00
Kibana Machine
aa4bce0b9a skip failing test suite (#157776) 2024-09-18 23:25:52 +10:00
Ignacio Rivas
36bd641ad7
[Console] Skip test that is still flaky (#193288)
## Summary

This test seems to pass in flaky test runner and in CI, but after its
merged it becomes flaky.
2024-09-18 14:47:58 +02:00
Ignacio Rivas
7549c11eb7
[Console] Fix flaky tests and unskip the ones that now work (#193237) 2024-09-18 11:45:46 +03:00
Julia Rechkunova
6b2bdf93f0
[Discover] Remove callout "Get the best look at your search results" and the grid tour (#192698)
- Closes https://github.com/elastic/kibana/issues/191940

This PR removes the callout and the tour which could be accessed only
from it.
2024-09-18 03:36:17 -05:00
Elena Stoeva
61d0b7f0d6
[Console] Improve status code highlighting (#192888)
Closes https://github.com/elastic/kibana/issues/190731

## Summary

This PR improves the status code highlighting when multiple requests are
sent.


https://github.com/user-attachments/assets/a0e8ba07-534d-4a48-aa7a-3964adc0e540


Dark mode:
<img width="1495" alt="Screenshot 2024-09-17 at 12 02 36"
src="https://github.com/user-attachments/assets/140e211d-57c2-48b7-abb8-09cfb4e24366">

All code statuses:
<img width="860" alt="Screenshot 2024-09-17 at 11 42 22"
src="https://github.com/user-attachments/assets/9509f9cd-ec60-44e2-b700-afaea595ad13">
2024-09-18 09:28:15 +01:00