Commit graph

69269 commits

Author SHA1 Message Date
Pierre Gayvallet
423e094659
Disable rison parsing error logs in production (#171660)
## Summary

Similar to https://github.com/elastic/kibana/pull/170827

Disable noisy 3rd party lib warning in production mode.
2023-11-22 10:46:55 +01:00
Marco Antonio Ghiani
dc29fb7cb5
[Log Explorer] Update minimum height for JSON doc view (#171553)
## 📓 Summary

Closes #171485 

This fix guarantees the JSON doc view will always get a minimum space
independently of the available space, to avoid the current scenario
where a scrollable flyout does not reserve enough space for the JSON tab
content tobe displayed (see recording in the related issue).


2c539047-32cd-4213-bc6f-3062de151426

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
2023-11-22 10:14:11 +01:00
Gerard Soldevila
721d68a890
Avoid ECONNRESET errors on idle timeout (#162947)
### Summary

Address https://github.com/elastic/kibana/issues/82002 and
https://github.com/elastic/kibana/issues/75440

I think I found a breakthrough for this flaky behavior. I run the
integration test 800x locally, with different settings:

Adjusting both the delayed emission (send 1 char at a time), and the
socket idle timeout to have exacly the same value (e.g. `10 millis`), I
managed to get the `ECONNRESET` 100% of the times.

Thus, IIUC the ECONNRESET happens when the client tries to send a
character over the socket and at the same time the server responds with
the idle timeout.

Adjusting the values so that the delay between character emissions is
significantly larger than the idle timeout, e.g. 20 vs 5, I get `socket
hang up` 100% of the times.

Flaky Test Runner Pipeline - 300x 🟢
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4030
2023-11-22 08:53:35 +01:00
Gloria Hornero
0e904b8c5d
[Security Solution] [Serverless] Making more robust the parallel serverless script (#171390) 2023-11-22 00:14:26 -07:00
Kibana Machine
325518095a
[api-docs] 2023-11-22 Daily api_docs build (#171707)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/529
2023-11-22 00:59:25 -05:00
Tiago Costa
03cbe7aa48
skip flaky suite (#171575) 2023-11-22 04:30:06 +00:00
Tim Sullivan
641983ff8d
Append serverless project ID to Support URL (#171448)
This PR updates the URL to the Elastic Support Portal registered by the
Cloud plugin, to include the configured deployment ID as a querystring
parameter.

1. On serverless deployments, we set the projects unique identifier with
`?serverless_project_id=123ABC`
2. On stateful cloud deployments, we set the deployment's unique
identifier with `?cloud_deployment_id=123ABC`
3. On on-prem deployments functionality shall remain unchanged.

Where this link can be found in the UI:

![image](a00f0dad-5aa2-40ab-9667-746ebe774762)
2023-11-21 18:38:05 -07:00
Florian Bernd
5cbc93c533
[Serverless Search] Getting Started - Fix .NET code snippet (#171388)
Fixes the "Getting Started" code snippet for the .NET serverless client.
2023-11-21 16:17:08 -06:00
Jon
07df5966b2
Revert "Revert "re-enable kme pipeline for testing (#171451)"" (#171694)
I pushed this revert up initially via
e79ca5e9d6 while debugging an issue with
CI waiting for agents. This was not the root cause and can be
unreverted.
2023-11-21 22:13:27 +00:00
Brad White
1919c87b90
Remove CI Composite Storybook (#171258)
## Summary
Closes #160803

This PR removes the `CI Composite` story because it has been broken
since at least ac23dce29f (and possibly
since b862a6c181). The functionality is
covered by the generated `index.html` in
dda4498fee/.buildkite/scripts/steps/storybooks/build_and_upload.ts (L105-L120)

To fix the composite story requires generating `stories.json` for every
storybook, which requires migrating the repo off the deprecated
`storiesOf` API. That task is quite extensive and would be better
handled alongside an upgrade to Storybook 7.x
2023-11-21 14:59:39 -07:00
Patryk Kopyciński
043f050187
[security_solution] Fix junit_transformer (#171669)
## Summary

Currently, Cypress is writing junit XML files that we are trying to map
to the expected CI format, but if the job fails the broken files are
still being uploaded and passed to the Flaky Test Reporter which causes
it to fail.

So the solution is to just delete the broken files before they are sent
to the Flaky Tests Reporter

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2023-11-21 21:50:37 +00:00
Brad White
d392473d90
[chore] Restrict Storybook version for Renovate (#171453)
Renovate bot keeps updating Storybook in #169655 to 7.x which has
[significant breaking
changes](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-65x-to-700),
CI failures, and requires Webpack 5. This upgrade will require a human
due to how our SB is setup.

[Renovate
Docs](https://docs.renovatebot.com/configuration-options/#allowedversions)
2023-11-21 14:43:15 -07:00
Jan Monschke
10f422836b
[SecuritySolution] Fix timeline saving / prevent epic from crashing (#171674)
## Summary

Fixes https://github.com/elastic/kibana/issues/168194

Under some circumstance, when navigating to the timelines page, we would
get a runtime exception for `state.tableById[action.id]` not being
defined. When that happened, the redux store would be in a broken state.

This PR makes the responsible destructuring assignment more save.
2023-11-21 14:42:00 -07:00
Jonathan Budzenski
e79ca5e9d6 Revert "re-enable kme pipeline for testing (#171451)"
This reverts commit c0978dbe1b.
2023-11-21 13:13:55 -06:00
Hannah Mudge
be46cceaa9
[Dashboard Navigation] Simplify state management (#171581)
Closes https://github.com/elastic/kibana/issues/167577

## Summary

Previously, the Link embeddable used the whole redux embeddable package
- however, the overall state that needs to be managed for this panel is
very simple, so this ended up being overkill. This PR fixes that by
adding a `useLinksAttributes` hook to replace the redux package that
subscribes to changes made to the attributes instead.

I also made two smaller changes in this PR:
1. Called the "Organize imports" command from VSCode on all of the
touched files - this explains all of the seemingly unrelated import
changes.
2. I fixed the React warning that was being thrown due to calling
`setIsSaving` after the component was unmounted.

### How to Test

To test number 2 above, create a by-reference Links panel and refresh
the dashboard. Then,
1. Make some sort of change to the Links panel, such as re-arranging the
links
2. Save the changes - note that, without the mount check, the following
React error will be thrown:

![image](88573c7b-8469-490d-83dd-5e335573aa75)
3. Now, with the mount check, this no longer happens 🎉 

### Checklist

- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 11:00:32 -07:00
Konrad Szwarc
a5d181089a
[EDR Workflows] Remove optional label from timeout input (#171632)
https://github.com/elastic/kibana/issues/171617

![Screenshot 2023-11-21 at 13 21
09](404b948b-33bf-468b-8552-ec2062287c0c)
2023-11-21 10:29:51 -07:00
Tiago Costa
d40855765e
skip flaky suite (#171666) 2023-11-21 16:27:46 +00:00
Tiago Costa
532799fd63
skip flaky suite (#171667) 2023-11-21 16:26:39 +00:00
Tiago Costa
7992ca1673
skip flaky suite (#170052) 2023-11-21 16:17:22 +00:00
Tiago Costa
e9dba60ef9
skip flaky suite (#170985) 2023-11-21 16:11:58 +00:00
Tiago Costa
38f8765e71
skip flaky suite (#171641) 2023-11-21 16:10:44 +00:00
Tiago Costa
7e6bf40e49
skip flaky suite (#171650) 2023-11-21 16:08:03 +00:00
Tiago Costa
c4171beda0
skip flaky suite (#171649) 2023-11-21 16:07:14 +00:00
Tiago Costa
d748bc38e1
skip flaky suite (#171168) 2023-11-21 16:05:42 +00:00
Tiago Costa
c382428a19
skip flaky suite (#171654) 2023-11-21 15:58:55 +00:00
Tiago Costa
663c5f611f
skip flaky suite (#171653) 2023-11-21 15:57:57 +00:00
Tiago Costa
09a389f805
skip flaky suite (#171644) 2023-11-21 15:55:56 +00:00
Tiago Costa
0bc8d3872e
skip flaky suite (#171643) 2023-11-21 15:53:04 +00:00
James Gowdy
5e3b124ae0
[ML] Create categorization job from pattern analysis (#170567)
Adds the ability to quickly create a categorisation anomaly detection
job from the pattern analysis flyout.
Adds a new `created_by` ID `categorization-wizard-from-pattern-analysis`
which can be picked up by telemetry.

Creates a new package for sharing our AIOPs ui actions IDs. I think we
should move the pattern analysis ID to this package too, but that can be
done in a separate PR.


51349f93-f072-4983-85f0-98741902fb5a



6e618581-8916-4e63-930f-945c96c25e6c

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 15:52:12 +00:00
Melissa Alvarez
39af788067
[ML] Trained models list: disable 'View training data' action if data frame analytics job no longer exists (#171061)
## Summary

Fixes https://github.com/elastic/kibana/issues/167667, disabling the
'View training data' action for models in the Trained Models list if the
data frame analytics job which created the model no longer exists

Adds `origin_job_exists` property to trained models list model items.
This is set during the models fetch for models with associated data
frame analytics jobs.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 08:50:38 -07:00
Alex Szabo
5256108075
Skip flaky endpoint tests (#171658)
## Summary
Several cases of flakiness on main:

  // https://github.com/elastic/kibana/issues/171655
  // https://github.com/elastic/kibana/issues/171656
  // https://github.com/elastic/kibana/issues/171647
  // https://github.com/elastic/kibana/issues/171648
2023-11-21 16:02:58 +01:00
Christiane (Tina) Heiligers
d8ef2d0fb1
Moves SOR bulkCreate unit tests to dedicated file (#171431) 2023-11-21 07:42:41 -07:00
Pete Hampton
540f2b632e
Remove Kibana Prometheus Exporter from documentation. (#171624)
## Summary

RE: https://github.com/pjhampton/kibana-prometheus-exporter/issues/344

I am sunsetting development on a community Kibana plugin I maintain.
This PR removes it from the official documentation.
2023-11-21 14:24:47 +00:00
Kurt
c5daa370c7
Upgrade chromedriver (#171545)
## Summary

Upgrade `chromedriver`

## Changelog

https://github.com/giggio/node-chromedriver/compare/117.0.3...119.0.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 09:21:37 -05:00
Alejandro Fernández Haro
55aebfdd2e
FullStory: use debounce before updating Page Vars (#171450) 2023-11-21 13:46:13 +00:00
Anton Dosov
f4e0d83598
[Serverless] Increase root breadcrumb width to reduce elipsis (#171515)
## Summary

close https://github.com/elastic/kibana/issues/170758

This PR increases root breadcrumb max width from 160 to 320px to fit
more of project titles. It also slightly adjusts number of visible
breadcrumbs per breakpoint to account for potentially 2x longer root
breadcrumb. Note that responsiveness is still not ideal as the system
doesn't actually calculate the width of each breadcrumb.


Before: 

<img width="1267" alt="Screenshot 2023-11-20 at 11 53 13"
src="6d2ba8d2-5bc0-4f85-a87a-a4185ae901f7">


After: 

<img width="1284" alt="Screenshot 2023-11-20 at 11 52 31"
src="90a57e58-6836-4465-a21e-78f72dc4953e">
2023-11-21 14:39:52 +01:00
Jonathan Budzenski
f51e6cd248 Revert "Upgrade to Node.js 20 (#162696)"
This reverts commit 029b3ba81d.
2023-11-21 07:15:23 -06:00
Pablo Machado
3a58207b53
[Security Solutions] Update new user details flyout to be consistent with Expandable Alerts Flyout (#169514)
## Summary
Update new user details flyout to be consistent with Expandable Alerts
Flyout. The previous user details flyout implementation was hidden
behind a flag and never went live.


![Screenshot 2023-11-09 at 15 42
59](0e4dee8a-0319-4531-8dcf-81cd88526aeb)


### What is included
* Update new user details flyout to use the expandable flyout component
* Update UI components according to the new design
* Keep the feature hidden behind newUserDetailsFlyout flag
* Supporting alert risk inputs

### What is NOT included
* Supporting multiple categories of risk inputs
* Host details flyout
* User and host pages
* Asset integrations (okta and azure)
* Update the flyout on the timeline (It is currently a technical
restriction of the expandable flyout, but the team is working to fix it)

### How to test it?
* Enable experimental flag `newUserDetailsFlyout`
`xpack.securitySolution.enableExperimental: ['newUserDetailsFlyout']`
* Create alerts and open alerts page
* Click on a username

- [x] Test edge cases
  - [x] No cases permissions (it hides cases actions)
  - [x] Basic license (it hides the risk score summary)  
- [x] No risk score data for a user (It hides the risk score summary)
<img width="434" alt="Screenshot 2023-11-13 at 15 56 33"
src="4fc13042-cd3d-487b-9982-bfbf02f003b4">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
2023-11-21 12:54:19 +01:00
Jill Guyonnet
e859b14711
[Fleet] Enable agent upgrade tooltip (#168638)
## Summary

Followup to https://github.com/elastic/kibana/pull/167539.

Closes https://github.com/elastic/ingest-dev/issues/2568.

As the version on which agents will have upgrade details is not known
yet, we decided to defer showing the tooltip for agents that don't until
it is (cf.
https://github.com/elastic/kibana/pull/167539#discussion_r1354346944).

This PR sets the version to 8.12.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 10:53:57 +01:00
Cristina Amico
10ec7132fa
[Fleet] Fix links to Logs view to point to Discover in Serverless (#171525)
Fixes https://github.com/elastic/kibana/issues/168349

## Summary
Fix links to Logs view to point to Discover in Serverless.

As the Logs view UI is not available in serverless, the "Open in logs"
buttons should point to Discover instead. Rather than hardcode the url
in each of the places where is needed, I extracted a small component
that builds the two urls and allows switching in an easier way.
If in the future on of the two links will go away, it will be easier to
find those occurrences.

### Testing
Test for serverless following [these
instructions](https://github.com/elastic/kibana/pull/167976)

**Error logs in agent activity flyout**
- Enroll an agent and try to cause some error - for instance upgrading
an agent that is not upgradeable
- Click on "Agent Activity" and find the error and a button besides it
- On stateful the button says "Open in Logs"

![Screenshot 2023-11-20 at 13 07
08](704cf0e2-c7ee-4751-9e7f-7dcd263a5aa4)

- On serverless is "Open in discover"

![Screenshot 2023-11-20 at 13 08
02](3902f09e-93dc-48d3-867e-1f80d977f437)

- Check that both show the same logs:

![Screenshot 2023-11-16 at 11 49
24](d863d99f-0c70-45e5-9316-a37645464c34)
![Screenshot 2023-11-16 at 11 48
54](7cbd0a5f-3b31-4c4d-a4b7-4eb7390983c8)


**Agent logs**
(Same test as above)
- Enroll an agent
- Click on the agent and go to the "Logs" tab
- On stateful the button says "Open in Logs"

![Screenshot 2023-11-20 at 13 04
41](6a43a062-37db-47ea-819f-acd170439395)

- On serverless is "Open in discover"

![Screenshot 2023-11-20 at 13 04
11](e15fdc8b-8780-4ac6-afc6-bff3d3a96be5)

- Check that both show the same logs

**Custom Logs UI**
There is also a link to logs on custom logs UI but I just linked to
discover for that one:
https://github.com/elastic/kibana/pull/171525/files#diff-e337aa916d60d0d1033e3298c8c9c33c6a6fcd87a8ded971a4a87f5ccfc0981fR20-R22

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-11-21 09:14:57 +01:00
Gloria Hornero
3bb16c7dcc
[Security Solution] Modifying the login method (#171383) 2023-11-21 08:08:19 +01:00
Kibana Machine
b8259a698d
[api-docs] 2023-11-21 Daily api_docs build (#171595)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/528
2023-11-21 01:11:28 -05:00
Philippe Oberti
dda4498fee
[Security Solution] improve and add Cypress tests for expandable flyout (#170993) 2023-11-20 16:03:14 -06:00
Thomas Watson
029b3ba81d
Upgrade to Node.js 20 (#162696)
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2023-11-20 21:47:48 +01:00
Tiago Costa
0a09215f0c
skip flaky suite (#169866) 2023-11-20 19:46:04 +00:00
Tiago Costa
b54d00debb
skip flaky suite (#171493) 2023-11-20 19:43:28 +00:00
Tiago Costa
0e565e197c
skip flaky suite (#171475) 2023-11-20 19:42:17 +00:00
Tiago Costa
edf8956053
skip flaky suite (#171481) 2023-11-20 19:41:11 +00:00
Tiago Costa
f045d9d130
skip flaky suite (#171476) 2023-11-20 19:39:57 +00:00
Tiago Costa
e15b5e69af
skip flaky suite (#171489) 2023-11-20 19:38:52 +00:00