Commit graph

71988 commits

Author SHA1 Message Date
Jon
42c0e28036
[npmrc] Fix puppeteer_skip_download configuration (#177673)
This was a breaking change introduced in puppeteer 20 See
df4d60c187
2024-02-22 18:59:01 -07:00
Kevin Qualters
7745d36703
[Security Solution] [Sourcerer] Make use of reselect in sourcerer selectors (#176916)
## Summary
This pr should change nothing functionally, but changes the selectors
used in components for sourcerer to make use of createSelector and
benefit from memoization at all times,
2024-02-22 20:56:52 -05:00
Davis McPhee
b207ff4534
[Unified Search] Hide ES|QL ad hoc data views from the data view picker (#177109)
## Summary

This PR uses the new `esql` data view `type` to hide ES|QL ad hoc data
views from the Unified Search data view picker since they are an
implementation detail and should not be visible to users.

Resolves #170098.
Resolves #166911.
Partially addresses #176873.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 20:40:23 -04:00
Tiago Costa
f006fc1a5e
chore(NA): update versions after v8.12.3 bump (#177627)
This PR is a simple update of our versions file after the recent bumps.
2024-02-22 22:26:49 +00:00
Jonathan Budzenski
242344e273 [bazel_cache] Fix puppeteer skip download environment variable 2024-02-22 16:17:52 -06:00
Jon
9580617d89
[bazel_cache] PUPPETEER_SKIP_CHROME_DOWNLOAD=true (#177646) 2024-02-22 14:35:50 -06:00
Davis Plumlee
3c34b535ce
[Security Solution] Per-field diffs test coverage (#177399)
## Summary

Addresses test coverage acceptance criteria for
https://github.com/elastic/kibana/issues/166489

Adds test coverage in accordance to the recently merged [test
plan](https://github.com/elastic/kibana/pull/176474)

[Flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)
2024-02-22 14:57:41 -05:00
Jonathan Budzenski
cf942f25e4 Revert "[Cases] Fix cases flaky tests (#176863)"
This reverts commit 0dd21e5b63.
2024-02-22 13:24:08 -06:00
christineweng
250c42712a
[Security Solution] Expandably flyout - Enable expandable flyout for generic events (#176332)
## Summary

This PR enables the overview tab and left section insights for a generic
event. When user to go `host` or `user` page and expand details for an
event, in addition to table and json tab, they now have access to:

- Overview tab on the right section, which provide description of the
event kind or event category (detail logic linked in comment), key
insights such as highlighted fields, entities, prevalence and
visualization previews (if available)
- Expanded details that includes entities details and prevalence details

Many sections are shared by the alert details flyout, which we are
hoping to provide a unified experience when user opens the details
flyout.

#### When overview and expanded sections are enabled ####
- Ideally `event.kind` and `event.category` should be ecs compliant,
meaning the field values are of `allowed_values` within [ecs
definition](https://www.elastic.co/guide/en/ecs/current/ecs-event.html).
- If the field is not ecs compliant, and it does not fit the criteria to
generate an event renderer, the overview tab and expanded sections are
hidden
 
#### Variations depending on event kind ####
There is a variation of the about section depending on `event.kind`:
- `event.kind == 'event'`
- This is the most general and common event document, hence we provide
details at the `event.category` level.
- The title is also dynamic based on the category type (i.e if
`event.category` is process, the `process.name` is displayed)
- `event.kind != 'event'`
- These are events that not as common/general as `event` so we are
providing description at the `event.kind` level
   - The title matches the `event.kind` field
- `event.category` is included as a list of categories present for the
document
<img width="1006" alt="image"
src="bb540c62-4346-4dc6-8c11-3ad6cdd1e7c9">

#### How to test ####
- Enable feature flag `expandableEventFlyoutEnabled`
- Generate some event data (the resolver generate data script is
sufficient to the test main logic, to get the event renderer to show up,
see comment on feeding additional data), alternatively, auditbeat and
filebeat also feed event data.
- Go to Explore -> Host -> Events table -> expand event details

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-02-22 13:15:12 -06:00
Coen Warmer
6d75e87673
[Moving] Move Uptime folder into /x-pack/observability_solution (#177466)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [x] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
- [x] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440)
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [x] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458)
- [x] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463)
- [x] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
- [x] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466) <--
you are here
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 12:03:16 -07:00
Alexey Antonov
3db4a8fa98
fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text (#177273)
Closes: https://github.com/elastic/security-team/issues/8566
Closes: https://github.com/elastic/security-team/issues/8569

## Description
The `<RuleSwitch />` component is currently flagged by the axe browser
plugin for lacking text or an accessible label in its button switch.
This pull request introduces support for the addition of the
`aria-label` attribute to address this issue. Additionally, adjustments
are made in two instances where this component is utilized within the
codebase.

## Screens 

### Axe report 

![image](36287d4f-fd98-4b26-b313-a39a72aefb81)

### A11y label 

![image](c61c9d0d-dd6e-4af2-9d43-04e86ad21954)
2024-02-22 19:33:10 +01:00
Paul Tavares
bd311f3644
[Security Solution][Endpoint] Revert Badges for SentinelOne functionality back to Tech Preview (from Beta) (#177488)
## Summary

This PR reverts most of the changes done in #176228 : 

- Reverts changes to Connectors so that the Badge displayed for
SentinelOne is again showing "Technical Preview"
- Changes the badge displayed on the Host Isolation flyout and Responder
for SentinelOne host to "Technical Preview"
- Fixes #177337 

IN addition, the following issue was also addressed:

- Corrected `i18n` definition for response action log history ( Fixes
#177185 )


_____________

### Host isolation flyout

<img width="1283" alt="image"
src="dc1f104a-9792-4aee-ae12-140489562d96">



### Responder

<img width="1272" alt="image"
src="6361008a-182f-4163-b754-92619b6c9ee1">


### Connector

<img width="638" alt="image"
src="338d03d9-b74d-479d-bfe2-d1796d1f2103">


<img width="1283" alt="image"
src="4eeeeccb-e966-4897-b97f-17696e0bd5ef">
2024-02-22 10:52:59 -07:00
Luke G
3ab8e45949
fixed field data sourcing (#177472)
## Summary

This fixes:
SDH issue **882**
https://github.com/elastic/kibana/issues/173627

### Before the fix
Note how the field actually displays an alias instead of the value. This
is due some fallback behavior I think.

![highlighted_before](c66ef18f-d0f9-4964-b69f-94bba6d31c60)

### After the fix

![highlighted_after](ee730392-7617-4654-87bc-a8addb7342e2)


The missing bit was the actual value to display as it was not passed
down correctly from the parent conext

### How to test this?

1. create custom index and populate it with data

```
PUT test

POST test/_doc
{
  "user.id": "888",
  "@timestamp": "2024-02-21T15:20:10.084Z"
}
```

2. create threshold rule looking like this:


![image](07089ba8-e0b9-40f1-8372-15cb8a94e043)

3. actual value that triggered the alert should be rendered in the
highlighted fields panel in the flyout
2024-02-22 18:35:46 +01:00
Coen Warmer
3ef768aa45
[Moving] Move Synthetics folder into /x-pack/observability_solution (#177464) 2024-02-22 18:28:18 +01:00
jennypavlova
7658bafed2
[Infra UI] Show only hosts with metrics collected by system module in the hosts view (#177239)
Closes #176403

## Summary

This PR adds a filter for the `event.module` to be `system` because the
Hosts View is only compatible with the metrics-system indices - I added
a
[comment](https://github.com/elastic/kibana/issues/176403#issuecomment-1954232722)
to explain the change in the query. It adds infra client as part of the
synthtrace and a scenario to test the change

## Testing 
- Use the new synthtrace scenario: `node scripts/synthtrace --clean
infra_hosts_with_apm_hosts.ts`
- By default there should be `10` host visible on the host view and 3
separate services in APM (the APM hosts should not be visible)
- The scenario can be used with different numbers of services/hosts for
example:
`node scripts/synthtrace --clean --scenarioOpts.numServices=5
--scenarioOpts.numHosts=5 infra_hosts_with_apm_hosts.ts`
- 5 hosts shown on Infrastructure > Hosts (the APM hosts should not be
visible)

![image](d8763a24-95c2-43cd-991b-23edd102f47a)
       - 5 services shown on APM > Services

![image](0638cfdb-3d6f-4f72-915d-d67764bc9349)
- Use remote cluster (with APM)
   - The hosts with `0` metrics coming from APM should not be visible:
<img width="1920" alt="image"
src="af69efc0-bbd9-47ae-8431-2a56fa0626c4">
2024-02-22 18:23:11 +01:00
Sander Philipse
0dcd8f331c
[Search] Fix connector config bug and add config details to more places (#177493)
## Summary

This fixes a serverless connector configuration bug where it move too
quickly, and adds an API key and config yml panel to the connector
config page that exists after it's been configured.
2024-02-22 10:19:51 -07:00
Antonio
7ad7aff52c
[Cases] Unskip severity flaky test (#177597)
## Summary
As a follow-up to #176863 I am unskipping these severity tests to check
if the changes on that PR stabilized them.

Fixes #176336
2024-02-22 17:58:15 +01:00
Janki Salvi
9bdea881f8
[Cases] Unskip filter popover, property actions flaky tests (#177611)
## Summary

As a follow-up to https://github.com/elastic/kibana/pull/176863
unskipping filterPopOver and propertyActions tests

Fixes https://github.com/elastic/kibana/issues/176679
Fixes https://github.com/elastic/kibana/issues/176680
Fixes https://github.com/elastic/kibana/issues/176681
Fixes https://github.com/elastic/kibana/issues/176682
Fixes https://github.com/elastic/kibana/issues/176683
Fixes https://github.com/elastic/kibana/issues/176684
Fixes https://github.com/elastic/kibana/issues/176685
Fixes https://github.com/elastic/kibana/issues/176686
Fixes https://github.com/elastic/kibana/issues/174384
Fixes #174667
Fixes #175310
2024-02-22 17:56:50 +01:00
Christos Nasikas
2a8d29bc2a
[Cases] Unskip flyout and custom fields flaky tests (#177590)
## Summary

PR https://github.com/elastic/kibana/pull/176863 improved the cases
context provided which we assumed caused some flakiness in our tests. I
am unskipping a couple of tests to test if the changes on that PR
stabilized the tests.

Fixes https://github.com/elastic/kibana/issues/176805
Fixes https://github.com/elastic/kibana/issues/174528
Fixes https://github.com/elastic/kibana/issues/174527
Fixes https://github.com/elastic/kibana/issues/174526
Fixes https://github.com/elastic/kibana/issues/174525
Fixes https://github.com/elastic/kibana/issues/176600
Fixes https://github.com/elastic/kibana/issues/146394


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-02-22 17:39:00 +01:00
Maryam Saeidi
637de1dff5
[Custom threshold] Add group by filters to the custom threshold view in app URL (#177016)
Resolves #173713

## Summary

This PR adds group by filters to the view in the app URL for the custom
threshold rule:


![image](c84eecfc-b196-4268-acdd-57bae86ac4c4)

I also moved some types to the common folder and adjusted them to match
the reality.

## 🧪 How to test
- Create a custom threshold rule with group by
   - One with persisted data view
   - One with an ad-hoc data view
- Check the view in app link in the alerts table, you should also see
the group filters there.
- Check the view in app URL from the actions, it should also include the
group filters.
2024-02-22 17:24:43 +01:00
Christiane (Tina) Heiligers
bf4b70ceb4
Prevent so type registration if schema declared directly (#177246)
Fix https://github.com/elastic/kibana/issues/176668

## Summary

After a switch to model versions, saved object registrations are blocked
if any schema for a higher version is declared when not coupled with a
model version.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 09:21:00 -07:00
Rodney Norris
6d44340e52
[Console] Update console to provide cloud es url if available with cURL (#176944)
## Summary

Updated the console route `/api/console/es_config` to default to the
`cloud.elasticsearchUrl` if it's available vs reading the first host
value from the legacy config. This will ensure that when a user use the
"copy as cURL" in the console the host will default to the cloud URL.

### Checklist

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-02-22 09:20:32 -07:00
Rachel Shen
f43fecc1cd
[Shared UX] Separate share reporting and reporting api client into packages from central reporting plugin (#176104)
## Summary
This PR separates the reporting api client and the reporting share
plugin out of the reporting plugin. As a result, Jobs had to be taken
out of the plugin as well. This is work that will benefit the share
modal redesign epic by isolating the reporting share plugin code.

The share code is added to the @kbn/reporting-public package.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
2024-02-22 09:03:03 -07:00
Paul Tavares
36359b2636
[Security Solution][Endpoint] Update Response Actions API clients to support Automated Response Actions (#174691)
## Summary

PR implements changes to the new Response Actions Client (server side)
so that it is also supports use of these clients for Automated Response
actions. Changes include:

- Change base class for response action clients sot hat it accepts a new
constructor argument: `isAutomated`
- Adds an additional (optional) argument to each of the response action
methods for allowing use from automated response actions
- Additional validations are now performed when
`writeActionRequestToEndpointIndex()` is called
- Endpoint Response Actions Client: Remove use of `createAction()`
(prior service - which will be deleted) and handle creation of response
actions in the class itself
- Changed detection engine processing of automated response actions so
that it uses the new Response Actions Client classes


> [!NOTE]
> There will be a subsequent PR created to remove modules that are no
longer needed now that all response actions are being processed by the
new Response Actions Client framework.




### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-02-22 08:49:31 -07:00
Davis McPhee
36365bd911
[Discover] Prevent showing the ES|QL transition modal when a saved search without unsaved changes is open (#177107)
## Summary

This PR prevents the ES|QL transition modal from showing when switching
to a data view from a saved search that has no unsaved changes.

Resolves #176772.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-02-22 11:47:13 -04:00
Coen Warmer
cc915bd4d9
[Moving] Move Observability Onboarding folder into /x-pack/observability_solution (#177458)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [x] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
- [x] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440)
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [ ] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458) <-- you are
here
- [x] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463)
- [x] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
- [ ] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466)
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 16:37:21 +01:00
Nathan Reese
c747a3b35d
[dashboard] fix Inspect panel action displays untitled instead of panel title (#177516)
Fixes https://github.com/elastic/kibana/issues/176870

PR provides a utility method for fetching title that falls back to
default title when title is not provided.
2024-02-22 08:27:12 -07:00
Rodney Norris
dd0e95725b
[Console] rename docked console to persistent (#177376)
## Summary

Renamed the UI setting for the embedded console from Docked to
Persistent per Product's request.
2024-02-22 09:05:19 -06:00
Drew Tate
880f793ccc
[Visualizations] legacy vis behavior on serverless (#176935)
## Summary

Close https://github.com/elastic/kibana/issues/176536
Close https://github.com/elastic/kibana/issues/176742

### Links to legacy visualization editors are once again disabled
<img width="208" alt="Screenshot 2024-02-14 at 10 19 52 AM"
src="711f5372-d7f6-4f0d-88c6-605e528d6f13">

### A better message in the inspector
<img width="685" alt="Screenshot 2024-02-14 at 10 23 25 AM"
src="734a8f6a-0f00-46c7-8d27-2a86a24cf7ab">


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2024-02-22 08:44:14 -06:00
Carlos Crespo
5a3f0a0da9
[Infra] Refactor routes context providers and inventory alert flyout (#177189)
closes [144387](https://github.com/elastic/kibana/issues/144387)

## Summary

This PR changes the context Waffle context providers usage, so that they
are only used in the Inventory UI page. Therefore, removes the
`waffleTime`, `waffleOptions` and `waffleFilters` query parameters from
other Infrastructure pages:

Hosts View route example:

**Before**
```
https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/app/metrics/hosts?
  waffleFilter=(expression:%27%27,kind:kuery)&
  waffleTime=(currentTime:1708347453400,isAutoReloading:!f)&
  waffleOptions=(accountId:%27%27,autoBounds:!t,boundsOverride:(max:1,min:0),customMetrics:!(),customOptions:!(),groupBy:!(),legend:(palette:cool,reverseColors:!f,steps:10),metric:(type:cpu),nodeType:host,region:%27%27,sort:(by:name,direction:desc),source:default,timelineOpen:!f,view:map)&
  _a=(dateRange:(from:now-15m,to:now),filters:!(),limit:500,panelFilters:!(),query:(language:kuery,query:%27%27))&
  controlPanels=(cloud.provider:(explicitInput:(fieldName:cloud.provider,id:cloud.provider,title:%27Cloud%20Provider%27),grow:!f,order:1,type:optionsListControl,width:medium),host.os.name:(explicitInput:(fieldName:host.os.name,id:host.os.name,title:%27Operating%20System%27),grow:!f,order:0,type:optionsListControl,width:medium),service.name:(explicitInput:(fieldName:service.name,id:service.name,title:%27Service%20Name%27),grow:!f,order:2,type:optionsListControl,width:medium))
```


**Now**
```
http://localhost:5601/ftw/app/metrics/hosts?
  _a=(dateRange:(from:now-15m,to:now),filters:!(),limit:100,panelFilters:!(),query:(language:kuery,query:%27%27))&
  controlPanels=(cloud.provider:(explicitInput:(fieldName:cloud.provider,id:cloud.provider,title:%27Cloud%20Provider%27),grow:!f,order:1,type:optionsListControl,width:medium),host.os.name:(explicitInput:(fieldName:host.os.name,id:host.os.name,title:%27Operating%20System%27),grow:!f,order:0,type:optionsListControl,width:medium),service.name:(explicitInput:(fieldName:service.name,id:service.name,title:%27Service%20Name%27),grow:!f,order:2,type:optionsListControl,width:medium))
```

**NOTE**: I had to refactor some alerting components because they were
depending on the `WaffleOptions` context to retrieve some properties
that are only relevant within the Inventory UI context

### How to test

- Start a local Kibana instance
- Navigate to the pages below and confirm that they work. `waffle` query
variables only exist in the Inventory UI
  - Inventory
    - Navigate to Pod details 
    - Create and load Saved Views
    - Create Inventory and Metrics alerts
  - Metrics
    - Create and load Saved Views
    - Create Inventory and Metrics alerts
  - Hosts View
    - Navigate Hosts Details

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 15:32:03 +01:00
Coen Warmer
bc488fb93e
[Moving] Move Dataset Quality folder into /x-pack/observability_solution (#177456)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [ ] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
<-- you are here
- [x] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440)
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [ ] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458)
- [x] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463)
- [x] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
- [ ] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466)
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
2024-02-22 15:17:05 +01:00
Christos Nasikas
0dd21e5b63
[Cases] Fix cases flaky tests (#176863)
## Summary

With the help of @umbopepato, @js-jankisalvi, and @adcoelho, we realized
that one possible source of flakiness is the `CasesContextProvider` that
every test uses under the hood. In this PR I refactor the
`CasesContextProvider` to render immediately its children and not wait
for the `appId` and `appTitle` to be defined. I make them optional and
make all changes needed in the code to accommodate the presence of an
optional `appId`. Also, I refactored some components that I believed
could introduce flakiness.

## Issues

Fixes https://github.com/elastic/kibana/issues/175570
Fixes https://github.com/elastic/kibana/issues/175956
Fixes https://github.com/elastic/kibana/issues/175935
Fixes https://github.com/elastic/kibana/issues/175934
Fixes https://github.com/elastic/kibana/issues/175655
Fixes https://github.com/elastic/kibana/issues/176643
Fixes https://github.com/elastic/kibana/issues/175204

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5255,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5261,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5264,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5267

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenario

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Umberto Pepato <umberto.pepato@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 06:24:49 -07:00
Jean-Louis Leysens
162426c8ad
[HTTP] Move plugins static dir registration to CoreApp service (#177571)
## Summary

Close https://github.com/elastic/kibana/issues/176201
2024-02-22 13:41:54 +01:00
Alexey Antonov
4e30d4bb36
fix: [Rules][AXE-CORE]: Links must have discernible text (#177198)
Closes: https://github.com/elastic/security-team/issues/8565

## Summary

The [axe browser plugin](https://deque.com/axe) has identified four
links without clear text. Upon inspecting the page, it was found that
the SVG icons associated with each rule type are labeled as <a> but with
a negative tabindex, rendering them inaccessible for keyboard
navigation. Additionally, these icons lack an accessible label.

To address this issue, the <a> tag for the SVG icons has been removed.
SVGs inherently possess the appropriate role and aria-hidden attributes,
designating them as decorative elements for assistive technology.

### Screen


![image](32ae0237-9b89-40e6-8201-416a1f2d4f17)

### AXE Report

#### Before


![image](8e51168c-2028-422d-af9e-0c4f5aaeb467)


#### After


![image](57b4aa67-84ee-4b46-96c2-d9ccaa49812d)



## For discussion only
Alternatively I recommend to refactor LandingLinkIcon component to use
`EuiCard` to make it more EUI friendly e.g.
<img width="1308" alt="image"
src="ca76191f-bec7-473b-af73-838fcdee76af">

POC: [Alternative fix
for](69c9375192)
2024-02-22 14:30:58 +02:00
Coen Warmer
aecbb9c23b
[Moving] Move Observability Shared folder into /x-pack/observability_solution (#177463)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [ ] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
- [x] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440)
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [ ] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458)
- [ ] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463) <-- you are here
- [x] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
- [ ] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466)
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 13:29:11 +01:00
Shahzad
973b871564
[SLOs] Create flyout (#177552)
## Summary

Create flyout !!

Separate Flyout from the PR
https://github.com/elastic/kibana/pull/176024 to move ahead !!

Example usage [PR](https://github.com/elastic/kibana/pull/176024) 

## Scenarios to test

### Default SLO creation (no UI change)


c7910ef8-9bd9-43f5-ab3b-aac181b8c46b

---------

Co-authored-by: Panagiota Mitsopoulou <giota85@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 13:23:01 +01:00
Bena Kansara
725eb17f57
[APM] Fix indexing of labels in alert document (#177412)
Fixes https://github.com/elastic/kibana/issues/172443,
https://github.com/elastic/kibana/issues/177430

This PR indexes `labels` without flattening in alert documents. Also,
updated `synthtrace` to generate data with `labels` where some documents
have label with string value and others have same label with an array of
string values.

### Alert with single value for the label
<img width="625" alt="Screenshot 2024-02-21 at 14 09 37"
src="a05a1df8-78f4-48f2-9935-21c18d223cb2">

### Alert with an array of values for the label
<img width="635" alt="Screenshot 2024-02-21 at 14 10 14"
src="30115181-fa94-4c8c-8201-3cbc0d51f894">

### All active alerts are displayed in UI
<img width="1325" alt="Screenshot 2024-02-21 at 14 12 06"
src="2aee71fd-639a-4954-a5d9-7136571c6b1f">

### All recovered alerts have a proper reason message and `View in app`
link
<img width="1267" alt="Screenshot 2024-02-21 at 14 14 15"
src="50b5801b-5a4a-4d99-a9e1-037d6a69a661">

### How to test
1. Generate data with `node scripts/synthtrace.js simple_trace --live`
2. Create APM Latency threshold/Failed transaction rate/Error count rule
3. Verify that both types of labels (with string, and with array of
strings) are able to correctly index in alert documents
4. Verify that all active alerts are displayed in UI
5. Verify that recovered alerts have proper reason message and `View in
app` link
2024-02-22 12:34:16 +01:00
Pierre Gayvallet
38a3b9675d
Add http.payloadTimeout config option (#177309)
## Summary

Fix https://github.com/elastic/kibana/issues/177138

- Add a `http.payloadTimeout` configuration option, to control the
payload timeout
- Set the default value for this option to `20s` (was `10s` previously)
2024-02-22 12:33:49 +01:00
mohamedhamed-ahmed
9a473879af
[Dataset Quality] Added Dataset Quality Locator (#177000)
closes https://github.com/elastic/kibana/issues/170611

## 📝  Summary

This PR adds the infrastructure work for the locators needed to create
the navigation link from the Logs Explorer to the Dataset Quality Page,
but the links themselves are to be added with a later ticket.

## 💡For Reviewers

To be abled to test this PR you can add the below code
[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150)
to make the link visible in the Logs Explorer Page.

`<ConnectedDatasetQualityLink />
  <VerticalRule />`

## 🎥 Demo



1f3ce10a-3b8c-4027-b72d-1ed71b782fa5
2024-02-22 12:28:17 +01:00
Marco Liberati
03e8e9c5f0
[Graph] Rename block list into hidden list (#177457)
## Summary

Fix #162297

<img width="443" alt="Screenshot 2024-02-21 at 15 33 39"
src="164f5d8b-a5ae-4262-92b4-f4066fb66b4b">
2024-02-22 12:13:04 +01:00
Coen Warmer
c646e673ee
[Moving] Move Exploratory View folders into /x-pack/observability_solution (#177440)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [ ] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
- [ ] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440) <-- you are here
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [ ] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458)
- [ ] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463)
- [x] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
- [ ] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466)
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 12:03:38 +01:00
Mykola Harmash
b50f5387fc
[Infra] Add endpoints to manage Custom Dashboards (#176612)
Closes https://github.com/elastic/kibana/issues/176069

## Summary

This adds the logic to register a new Saved Object type to store custom
dashboards for Asset Details and adds endpoints to fetch and save custom
dashboards.

Changes highlights:
* Renamed the `enableInfrastructureHostsCustomDashboards` to
`enableInfrastructureAssetCustomDashboards` to make it more generic and
support additional asset types in the future
* Added a new Saved Object type
* Moved initialization of all Infra endpoints to plugin's `start`. This
one one of the points on [the BE tech debt
ticket](https://github.com/elastic/kibana/issues/175975). Having
endpoint initialization in `start` makes it more convenient to access
start dependencies which almost all endpoints require.
* Added `savedObjectClient` and `uiSettingsClient` to the custom request
context (also one of the ideas for endpoints improvement). Right now
infra endpoints use custom `libs` object with all dependencies required
for routes, the idea is to rely on the request context instead because
it automatically available for every route handler and by default
includes some useful things like scoped service clients.
* Added a wrapper `handleRouteErrors` to avoid error handling
duplication which we now have in a few routes. In the future we could do
something similar right within `registerRoutes` framework function, but
this would require a bit of refactoring.

## Hot to Test

1. Toggle the UI setting off in Advanced Settings
![CleanShot 2024-02-13 at 16 01
36@2x](fc3772a1-a075-42bd-bdc3-2c7e83278844)
2. Go to the Dev Tools and try the endpoints, both should respond with
403
```
GET kbn:api/infra/custom-dashboards/host

POST kbn:api/infra/custom-dashboards
{
  "assetType": "host",
  "dashboardIdList": ["0", "1"]
}
```
3. Toggle the UI setting on
4. Try the endpoints again, now they should work as expected

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 11:56:33 +01:00
Dima Arnautov
af86fc3d80
[ML] AIOps: Enable Change point detection tests (#177324)
## Summary

Closes #172984 

Enables Change point detection functional tests 


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
2024-02-22 03:54:51 -07:00
Dima Arnautov
84889d0399
[ML] Enable function tests for imported trained models (#177407)
## Summary

Closes https://github.com/elastic/kibana/issues/175443

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
2024-02-22 03:54:35 -07:00
Panagiota Mitsopoulou
8f11edc616
[SLO] error budget burn down chart embeddable (#176798)
Fixes https://github.com/elastic/kibana/issues/167572

- A new `SLO Error budget burn down` embeddable is added to the
Dashboard app
- A new `Attach to Dashboard` action is added to the Error budget burn
down chart in the SLO details page
- The selected SLO name is clickable and opens the SLO details page in a
Flyout
- The `Attach to Dashboard` action is hidden while on Dashboard app


9a1d257a-0122-415f-ac5c-94c4aa0dff91

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 03:49:02 -07:00
Stratoula Kalafateli
40d57754c8
[Lens] Move region map to GA (#177549)
## Summary

Closes https://github.com/elastic/kibana/issues/175418

This is as simple as removing the Tech Preview badge from the chart
switcher. Region maps were already part of our suggestions.

<img width="463" alt="image"
src="4fd4d868-bbcb-4803-a020-c1592e3d1c37">

Although region map usage in Lens is quite low, we decided to move it to
GA. I have discussed it with @nreese asynchronously.
2024-02-22 12:47:48 +02:00
Cauê Marcondes
2cc16875a0
[APM] unskipping api tests (#177428)
I ran the flaky test and they all passed. 

There are still many tests skipped though. But I'll deal with them on
another PR.

<img width="1331" alt="Screenshot 2024-02-21 at 14 29 32"
src="9b307e2a-2bb8-40cf-b2c7-d18772f4b9cc">
2024-02-22 03:40:15 -07:00
Alexey Antonov
872cca9c94
fix: [Cases > Case Detail][AXE-CORE]: Select element must have an acc… (#177449)
Closes: https://github.com/elastic/security-team/issues/8578

## Description 

The [axe browser plugin](https://deque.com/axe) is reporting the `Case
Detail` view has a custom select without an accessible name. This PR
address that issue adds `aria-label` attribute for `Sort By` combobox

## Screens


![image](2aee644b-3404-4590-8803-2cd6441f0a5f)
2024-02-22 03:33:38 -07:00
Coen Warmer
72a377d5b2
[Moving] Move Profiling folder into /x-pack/observability_solution (#177453)
## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](https://github.com/elastic/kibana/pull/177433)
- [ ] [Move Data Quality](https://github.com/elastic/kibana/pull/177456)
- [ ] [Move Exploratory
View](https://github.com/elastic/kibana/pull/177440)
- [ ] [Move Infra](https://github.com/elastic/kibana/pull/177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](https://github.com/elastic/kibana/pull/177427)
- [ ] [Move Observability
App](https://github.com/elastic/kibana/pull/177437)
- [ ] [Move Observability
Onboarding](https://github.com/elastic/kibana/pull/177458)
- [ ] [Move Observability
Shared](https://github.com/elastic/kibana/pull/177463)
- [ ] [Move Profiling](https://github.com/elastic/kibana/pull/177453)
<-- you are here
- [ ] [Move Synthetics](https://github.com/elastic/kibana/pull/177464) 
- [ ] [Move Uptime](https://github.com/elastic/kibana/pull/177466)
- [x] [Move UX](https://github.com/elastic/kibana/pull/177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 11:25:09 +01:00
Abdul Wahab Zahid
e610f09b2b
[Dataset quality] Degraded docs insights in flyout (#176912)
The PR adds the Degraded Docs insights panel which shows the percentage
of degraded docs over time using Lens Embeddable.

<img width="621" alt="Screenshot 2024-02-14 at 13 25 19"
src="2ae421b1-bfae-44e2-8da5-a2063061d761">

<img width="981" alt="Screenshot 2024-02-14 at 13 15 33"
src="7d70cb6b-0d5a-4c7c-84f6-509eb12886d3">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-02-22 11:20:47 +01:00