## Summary
This PR updates the Policy List (used to be unit but now) integration
tests with the modifications that have been implemented since the test
was skipped, and tried to fix the flakiness.
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes an issue introduced in 1b85815402
Currently during builds chromium is installed to the `x-pack/reporting`
directory. Under the new package management system plugins are installed
in node_modules, and the reporting plugin is not able to find the path
of chromium. This patches the path.
Ideally we could install chromium before the plugin is installed as a
package, but plugin installation is run once for all platforms, and
later reporting is run for each platform.
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/1222
## Summary
closes#151273
This PR fixes a bug when the Kubernetes Dashboards link is displayed. It
will only show when Kubernetes Pods is selected
### How to test it
- Connect your local kibana to an oblt cluster
- Go to Observability > Inventory UI
- Change "Show" and select Kubernetes Pods to see the link and any other
option to hide it.
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Part of https://github.com/elastic/kibana/pull/146284 it looks like the
`HttpEndpointDefinition` interface was accidentally deleted. Due to the
transient/cross file nature of `.d.ts` file this was not marked as an
issue by TS.
## Summary
After merging https://github.com/elastic/kibana/pull/148979 there are a
few interfaces in the server-side code that export a reference to a
deprecated SO type.
In this PR we fix them by updating a few imports to use the
non-deprecated SO type. Additionally, we resolve a potential circular
reference issue between `core-saved-objects-server` and
`core-saved-objects-api-server` by "moving" saved objects and related
types exports to `core-saved-objects-api-server`
## Summary
Closes#149423
Turns out no code changes needed after
https://github.com/elastic/kibana/pull/150199🥳
Add tests for the `/api/fleet/package_policies/upgrade` and
`/api/fleet/package_policies/upgrade/dryrun` endpoints to verify they
create the package policy assets when upgrading from an integration of
type integration to type input.
## Summary
When initially implementing the updates side nav with the feature
flagged Engines feature, we did not include Search Experiences in the
nav.
Upon learning more about this page I think its best we keep it included
in the nav as long as it's still included in the shortcut nav and has a
guided onboarding step. We may still remove this before engines is
released in 8.8, but we can remove it with those other usages as well
then.
### Screenshots
Closes#147049Closes#149897
Migrates authorization and audit logic from the Saved Objects Repository
to the Saved Objects Security Extension. This is achieved by
implementing action-specific authorization methods within the security
extension. The SO repository is no longer responsible for making any
authorization decisions, but It is still responsible to know how to call
the extension methods. I've tried to make this as straightforward as
possible such that there is a clear ownership delineation between the
repository and the extension, by keeping the interface simple and
(hopefully) obvious.
### Security Extension Interface
New Public Extension Methods:
- authorizeCreate
- authorizeBulkCreate
- authorizeUpdate
- authorizeBulkUpdate
- authorizeDelete
- authorizeBulkDelete
- authorizeGet
- authorizeBulkGet
- authorizeCheckConflicts
- authorizeRemoveReferences
- authorizeOpenPointInTime
- auditClosePointInTime
- authorizeAndRedactMultiNamespaceReferences
- authorizeAndRedactInternalBulkResolve
- authorizeUpdateSpaces
- authorizeFind
- getFindRedactTypeMap
- authorizeDisableLegacyUrlAliases (for secure spaces client)
- auditObjectsForSpaceDeletion (for secure spaces client)
Removed from public interface:
- authorize
- enforceAuthorization
- addAuditEvent
### Tests
- Most test coverage moved from `repository.security_extension.test.ts`
to `saved_objects_security_extension.test.ts`
- `repository.security_extension.test.ts` tests extension call,
parameters, and return
- Updates repository unit tests to check that all security extension
calls are made with the current space when the spaces extension is also
enabled
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
I went through every usage of `CellActions` and added the `aggregatable`
prop back to fields that previously had it.
### Why?
When I created CellActions I removed `isAgreggatable` from some fields
because every field with an aggregatable type would automatically
display `showTopN`. But later, I discovered that this approach didn't
work for some edge cases. I reintroduced the `isAgreggatable` prop but
forgot to add `isAgreggatable` back to those fields I had previously
removed it.
### Extra
It also fixes the network page country flag type from`geo_point` to
`keyword` to fix a bug.
It also adds an extra check to add_to_timeline `isCompatible` function
so it doesn't show for `geo_point` and `message` fields.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Fixes https://github.com/elastic/kibana/issues/151121
There were 2 issues
1) user could delete right field, putting layer in non-working state. To
fix this, update handler is not called when selected value is undefined
2) createJoinTermSource guard was not working for `{ term: undefined }`.
PR updated guard to properly handle this case.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes#149973
# Summary
This PR makes `spaces` an optional plugin. In Logs UI we use only the
space id and there we want to fallback to the default space id when the
space plugin is disabled. The difference to the changes in the other PRs
is that we will consider the default space as "active" space if the
space plugin is disabled: so in this case we will return the default
space id as this is the only property we need from the `getActiveSpace`
response.
# Testing
1. In the `kibana.dev.yaml` add `xpack.spaces.enabled: false`
2. Before we have this
[PR](https://github.com/elastic/kibana/pull/151147) merged you should do
[this
change](https://github.com/elastic/kibana/pull/151147/files#diff-1b17eae66f358505fae8d86df37e155a25e8db996fce93ee6016582fb341092e)
on the branch while testing
3. Inside Logs the `Anomalies` and `Categories` pages should load the
default space
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
The shared module setup function is not passing across the
`applyToAllSpaces` parameter.
This only affects plugins calling `setup` via the server side shared
function, not the ML plugin itself or any plugins calling the kibana
endpoint.
`service.name` was not being passed to `AnnotationsContextProvider` in
the `TransactionCharts`. The result of this change is that annotations will show up on
transaction charts (they didn't show up before)
Nothing to write home about - just a bit more boilerplate setup code.
Method signatures and RPC related interfaces are expected to be changed
later with an initial RPC layer implementation.
- Follow-up to https://github.com/elastic/kibana/pull/150171, adding a
dummy setup for `update` `delete` and `search` methods. **The `IN` and
`OUT` args will be changes when we glue these to the rpc service and its
types**
- Also clean up unit tests a bit to have setup logic contained in a
helper instead of scattered in global scope
## Summary
issue https://github.com/elastic/kibana/issues/145657
General actions refactor to complete the CellActions package
architecture.
These changes won't cause any noticeable change in the application
behavior. They include:
*kbn-cell-actions*
- Generic actions (filterIn/Out & copyToClipboard) migrated to the
package.
- `factory` implemented to export actions from the package.
- `CellAction` types generics.
*SecuritySolution*
- `SecurityCellAction` type encapsulated in new _actions/types.ts_ file.
- Actions changes to use new generic actions and also to be exported
using the package `factory`.
- Actions registration simplified to more declarative.
- Triggers and types moved to owned constants.ts enums.
- FilterIn/Out default actions unified timeline in a single
implementation using `metadata.scopeId`.
- Timeline Trigger removed, no longer needed.
- `SecurityCellActions` component to get the proper metadata typings and
code suggestions inside Security.
- Security CellActions metadata TSDoc expanded
### Factory
The action `factory` is necessary because we need a different action
`id`s for every action in the _uiActions_ registry, meaning that if
different triggers/solutions need different `order`, `type`,
`isCompatible` function, or any customization, they will need to
register an action with a different id, before attaching it.
The `CellActionFactory` implementation simplifies this workflow by
allowing action creation (only `id` param is required but any other
action property can be assigned) and also allows to `combine` factories,
returning a new factory with some properties overridden. This is useful
for extending generic actions into more specific implementations.
### SecurityCellActions
They are Security typed generic `CellActions` components, just for
convenience when using CellActions, they show the proper TSDoc
information about `metadata` contents, `triggerId`, and so on. It was
not possible when using the package exports directly.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
