Commit graph

22950 commits

Author SHA1 Message Date
Spencer
6e834cb722
[7.0] Refactor ES-related environment variables (#33036) (#33170)
Backports the following commits to 7.0:
 - Refactor ES-related environment variables  (#33036)
2019-03-13 13:19:10 -07:00
Joe Fleming
18f39fa14c
[7.0] Fix: set react version to string, not semver object (#33079) (#33158)
Backports the following commits to 7.0:
 - Fix: set react version to string, not semver object  (#33079)
2019-03-13 11:57:57 -07:00
Caroline Horn
1ad7c3f8de
[Code editor] Fixed Brace indent guide (#33019) (#33126)
Changed the border to linear gradient background
2019-03-13 11:32:16 -04:00
Thomas Neirynck
decdbeec3e
[Maps] Do not fill line geometries (#33072) (#33134) 2019-03-13 11:29:05 -04:00
Jason Rhodes
3aa00fa470
[APM] Removes call to disable the angular encoding fix (#33113) (#33128)
* Removes call to disable the angular encoding fix because we want that fix turned on for us

* Time range should be updated on every location change and not just when from/to values change

This was done in a previous commit but may have been lost in a merge somewhere...

This allows relative range refreshes to work so that 'now-24h' is re-calculated even though the string value didn't change. Redux handles the case where an absolute date is refreshed, and the chart requests are not re-made.
2019-03-13 10:54:53 -04:00
Spencer
67043db238 [chrome] strip # from hash before updating $location (#32732)
* add functional test to prove regression

* [chrome] strip # from hash before updating $location

* add opt-out level for disabling auto fix, disable in APM

(cherry picked from commit 319921ebfc)
2019-03-13 07:17:48 -07:00
Liza Katz
922eb1ee48 Back button navigation fix 31238 (#32372)
* initial fix for navigation issue + Spencer
* added navigation test for issue #31238 
* added more validations to the navigate back test

(cherry picked from commit ace80d1b59)
2019-03-13 07:17:43 -07:00
Peter Pisljar
f2b3bd1945
fixing brush for histogram agg (#32981) (#33117) 2019-03-13 14:57:01 +01:00
Nicolas Ruflin
9ca7fc055d
[7.0] Nats Metrics Kibana Tutorial (#30609) #33108
Backports the following commits to 7.0:
 - Nats Metrics Kibana Tutorial  (#30609)
2019-03-13 12:26:43 +01:00
Philipp B
5615363908
Export workpad: Copy to clipboard should read "To generate a PDF from a script..." (#32880) (#33104)
* Copy POST URL for generating PDF outside of Kibana ScreenReader compability
2019-03-13 12:35:21 +03:00
Walter Rafelsberger
2a6d5e01b3
[7.0] [ML] Adds missing error handling to annotations request. (#32384) (#32489)
- This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases.
- Disables annotations feature in Single Metric Viewer if annotations fail to load.
- Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.
2019-03-13 09:30:19 +01:00
Philipp B
687f0387b5
Color Auto button inside Chart style should read "Color: Auto" (#32633) (#33016) 2019-03-13 10:48:25 +03:00
Catherine Liu
8b4ad50c5d
Fix mapColumn and staticColumn to work with empty tables (#33078) (#33095) 2019-03-13 00:10:44 -07:00
Josh Dover
a79399e662 [UA] Add searching by index and node to UI, fixes #32075 (#33065) (#33085) 2019-03-12 23:35:09 -07:00
Josh Dover
b68ba34bec Add reindex warning for mapping type changes (#32081) (#33088) 2019-03-12 23:34:35 -07:00
Tyler Smalley
43352cb07f
[UA] Make reindex error handle more robust (#33060) (#33091) 2019-03-12 23:33:14 -07:00
Joe Fleming
9176f9690c
Fix: correctly access types from "to" function (#32691) (#33067)
* fix: correctly access types

they are not exposed on the handlers object, they must be imported from @kbn/interpreter

* chore: move to function to browser

types can be accessed in the browser now, and a common function makes no sense right now. also https://github.com/elastic/kibana/issues/33039 prevents having the same function in both places anyway
2019-03-12 17:50:18 -06:00
Josh Dover
803d5636b7
[7.0] Add button for adding index.query.default_field setting to metricbeat indices #32829 (#33057)
* Add button for adding `index.query.default_field` setting to metricbeat indices (#32829)

* Add button for adding `index.query.default_field` setting to metricbeat indices

* Add button to 'group by index' view

* Refactor to more generic API

* Remove comment

* Update functional tests

* Use typeless API in 7.0
2019-03-12 18:46:19 -05:00
Catherine Liu
c5b6da5174
[Canvas] Disables progress bar in fullscreen mode (#32942) (#33050)
* Added check for fullscreen mode before showing loading indicator

* Reverted fullscreen check. Added CSS to hide loading indicator in fullscreen mode
2019-03-12 14:45:48 -07:00
spalger
35e2b80ff3 Revert "correctly passing saved filters and query to all response handlers (#32749) (#32964)"
This reverts commit 46801c33db.
2019-03-12 11:41:09 -07:00
Silvia Mitter
8b15d42e39
[APM] update index pattern (#33008) 2019-03-12 19:04:17 +01:00
Felix Stürmer
145d27ac67
[7.0] [Infra UI] Strictly pick fields sent upon source config creation (#32897) (#32989)
Backports the following commits to 7.0:
 - [Infra UI] Strictly pick fields sent upon source config creation  (#32897)
2019-03-12 18:58:14 +01:00
Chris Roberson
2e832799b8
Add in explicit mappings (#33004) (#33013) 2019-03-12 13:38:30 -04:00
Tim Sullivan
239fc52f82
[Reporting] Fix browser extraction logging (#31608) (#31645) (#32941)
This change to the logging helps clarify to the reader what is going on,
the build ID of our Chromium, and where things are laid out in the system.
2019-03-12 10:33:47 -07:00
Pete Harverson
3612a7ae4b
[ML] Announce no forecasts or annotations for job list screen reader text (#32911) (#32983)
* [ML] Announce no forecasts or annotations for job list screen reader text

* [ML] Update annotations table snapshot for a11y change
2019-03-12 11:37:05 +00:00
Tim Roes
ffa79b02df
[7.0] Change vis save dialog when adding to dashboard (#32883) (#32972)
* Change vis save dialog when adding to dashboard (#32883)

* Change vis save dialog when adding to dashboard

* Update src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

Co-Authored-By: timroes <mail@timroes.de>

* Fix jest text for older EUI version
2019-03-12 11:48:30 +01:00
Andrew Cholakian
35d3304b9f
[Uptime] Add i18n to plugin name in sidebar (#32586) (#32816)
Fixes https://github.com/elastic/kibana/issues/32052
2019-03-12 05:47:03 -05:00
Peter Pisljar
46801c33db
correctly passing saved filters and query to all response handlers (#32749) (#32964) 2019-03-12 11:46:35 +01:00
Tim Roes
a6af76b81d
Add check for extraMetric in point server tooltip hovers (#32641) (#32969)
* add check for extraMetric in point server tooltip hovers

* format extra metrics

* put z axis format information into series to format tooltip correctly

* fix failing tests

* extend tooltip formatter test

* add test
2019-03-12 10:44:04 +01:00
Hamid
3e1277d8bf
[APM] Use correct agent name in instructions (#32896) (#32902) 2019-03-12 08:46:42 +01:00
Luke Elmers
d842fe6069
Ensure extra columns are not shown in table vis when showPartialRows:true (#27154) (#32962) 2019-03-11 23:20:08 -06:00
spalger
a297d9cb5c [x-pack/jest/integration] Jest runs setup hook when tests are skipped...
(cherry picked from commit 33dc8e6cfd)
2019-03-11 22:06:21 -07:00
Luke Elmers
b5243bea92
Remove deep clone from courier request handler. (#32806) (#32952)
We have been deeply cloning the `searchSource.rawResponse` in the courier request handler, in an effort to prevent downstream applications from mutating the response and causing unintended side effects (for example, response data in the inspector will change if rawResponse is mutated).

While this was a sensible preventative measure, it unfortunately created some severe performance problems, particularly when dealing with deeply nested aggregations with a large amount of buckets.

This does the following:

* Stop deeply cloning response data in courier, which earns us some significant performance gains.
* Remove the following cache keys from index patterns which were mutating `searchSource`: $$_flattened, $$_formatted, $$_partialFormatted. They have been replaced with a WeakMap cache that doesn't rely on mutating the source data.
2019-03-11 19:01:38 -06:00
Nathan Reese
b05028e763
Add link to Maps docs in Kibana getting started with sample data (#32848) (#32948)
* Add link to Maps docs in Kibana getting started with sample data

* Update docs/getting-started/add-sample-data.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>
2019-03-11 18:13:26 -06:00
gchaps
e2c9f73d07 [Maps][Docs] Updates for Maps Getting Started (#32809)
* [Maps] getting started documentation

* [DOCS] Edits for Maps Getting Started

* [DOCS] Incorporates review comments

* [DOCS] Rewrite section on sample data

* [DOCS] Adds link to add sample data page
2019-03-11 16:43:25 -07:00
Jason Rhodes
7c23166efb
[APM] Fixes various bugs with date picker implementation (#32755) (#32916)
* Makes sure fromQuery helper properly handles undefined values, adds test

* Adds APM default fallback values to every Kibana link, if no time picker values are currently set

* Changes date picker url updates to push instead of replace in stack

* Fixes bug with chart selection, dragging on charts now updates the URL which triggers all of the date picker updates

* Reverts query param encoding hacks due to fixes in #32732

* Removes unnecessary moment dep in SyncChartGroup

* Updates tests for url changes
2019-03-11 17:54:53 -04:00
Nathan Reese
68ae3685a9
Remove Dashboard dark theme setion from docs (#32863) (#32927) 2019-03-11 15:12:16 -06:00
Spencer
46a35c334f
[7.0] temporarily skip flaky test (#32922) (#32930)
Backports the following commits to 7.0:
 - temporarily skip flaky test  (#32922)
2019-03-11 13:30:33 -07:00
Jason Rhodes
5940203c8b
[APM] [7.0] Moving the date picker into APM (#31311) (#32729)
* [APM] Moving the date picker into APM (#31311)

* WIP moving the date picker into APM

* Stable version of EUI date picker controls, still needs layout

* Flex layout for kuery bar and date picker

* Removes angular time picker logic and layout

* Fixes snapshot test

* Adds integration tests for date picker

* Simplifies refresh cycle with setTimeout over requestAnimationFrame

* Removes rison and local state from APM date picker flow

* Adds refresh tests, fixes some refresh logic

* Moves temporary EUI types out of component

* Moves toBoolean helper and fixes TS error

* Removes unused Link import

* Types for datepicker (WIP)

* Updates default date picker values after merging in Søren's type changes

* Streamlines new APM query types to prevent duplication

* Uses jest fake timers for refresh tests

* Updates url handling to remove Rison from APM URLs, keeps Rison in outgoing Kibana links

* Move filter bar up and out from within a react-redux-request to avoid catch-22 circular dependency

* Separates rison encoding from regular url handling

* Sets start and end defaults in urlParams reducer

* Adds IUrlParams type to initial state with correct typing

* Updated rison-related snapshots

* Resolves failing tests related to query param management

* Adds more tests for Kibana Link and Kibana Rison Link components

* Re-enables the update button for the EUI super date picker

* Adds more Discover link tests

* Moved getRenderedHref to testHelpers, switched Discover Links integration tests to TS, and added ML link integration test

* Changes how getRenderedHref works to make it clearer where location state is coming from

* Updates obsolete snapshot

* Fixes typescript-discovered errors and type errors

* Finishes up url_helpers tests, removes dead commented tests

* Removes temporary date picker types from APM

* Fixes common case for an existing URL bug by not encoding range params

* Fixes x-pack tests

* Fixes type errors in x-pack
2019-03-11 15:26:34 -04:00
Luke Elmers
5cfe49553b
Add unit tests for embedded_visualize_handler (#32657) (#32910) 2019-03-11 12:11:50 -06:00
Chris Roberson
86364f1fc2
Read from api version 7 indices (#32654) (#32890) 2019-03-11 10:28:33 -04:00
Pete Harverson
738886f652
[ML] Adds anomaly time to aria label for anomalies table actions button (#32777) (#32878)
* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
2019-03-11 11:02:19 +00:00
Tim Roes
986c302eb5
fix missing axis labels when changing vertical bar chart to horizontal bar chart (#32628) (#32875) 2019-03-11 10:45:22 +01:00
Daniil Suleiman
f80db64979
Fix table vis format date string when grouping by date field (#31783) (#32636)
* Fix table vis format date string when grouping by date field

* Use DateFormat instead of moment directly

* Add a pivot_type while selecting a pivot value in table

* Move fetchFields into a separate function

* Move setDefaultIndexPattern to ReactEditorControllerProvider
2019-03-10 23:29:28 +03:00
Daniil Suleiman
b2e2a2b372
Add max, min, placeholder to percentile in TSVB (#32389) (#32638)
* Add max, min, placeholder to percentile

* Fix adding new percentile with empty value
2019-03-10 23:28:45 +03:00
spalger
3b8cca3350 [mgmt/scriptFields] use better assertions to help debug #32862
(cherry picked from commit bbe106aea1)
2019-03-10 12:21:34 -07:00
Dmitry Lemeshko
737b544418
Improving way to check if pipelines list is loaded (#32370) (#32861)
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077c2c.
2019-03-10 12:36:52 +01:00
Dmitry Lemeshko
1e416cafb1
Improve logstash pipeline tests (#32198) (#32295)
* [services/pipeline_list] optimize getRows function

* run ciGroup2 x16 times

* [services/pipeline_list] wait for table body loaded

* Revert "run ciGroup2 x16 times"

This reverts commit 4e45a5eaf1.

* removed unused browser_exec_scripts
2019-03-10 11:18:50 +01:00
Clint Andrew Hall
33dd40b52c
[7.0] [canvas] Fix resolved_args sync issue when deleting a page (#32835) (#32855)
Backports the following commits to 7.0:
 - [canvas] Fix resolved_args sync issue when deleting a page  (#32835)
2019-03-09 23:31:24 -08:00
Catherine Liu
cba0f8f111
[Canvas] Fixes workpad update error for read only users (#32831) (#32837)
* waits for write permission test before loading workpad

* Adds setRefreshInterval to list of skipped actions in es_persist
2019-03-09 22:18:08 -07:00