Commit graph

62804 commits

Author SHA1 Message Date
Kibana Machine
7cc4100409
[8.8] [Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478) (#156411)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] [Fix] Alert Table re-render + column width reset
+ TopN Not rendering
(#155478)](https://github.com/elastic/kibana/pull/155478)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:22:26Z","message":"[Security
Solution] [Fix] Alert Table re-render + column width reset + TopN Not
rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column
width is reset when alert table re-renders #154796 \r\n- [Response Ops]
Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when
clicking on checkbox. #155229\r\n- [Security Solution] TopN does not
work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before
| After |\r\n|---|---|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n
|","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":155478,"url":"https://github.com/elastic/kibana/pull/155478","mergeCommit":{"message":"[Security
Solution] [Fix] Alert Table re-render + column width reset + TopN Not
rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column
width is reset when alert table re-renders #154796 \r\n- [Response Ops]
Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when
clicking on checkbox. #155229\r\n- [Security Solution] TopN does not
work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before
| After |\r\n|---|---|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n
|","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155478","number":155478,"mergeCommit":{"message":"[Security
Solution] [Fix] Alert Table re-render + column width reset + TopN Not
rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column
width is reset when alert table re-renders #154796 \r\n- [Response Ops]
Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when
clicking on checkbox. #155229\r\n- [Security Solution] TopN does not
work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before
| After |\r\n|---|---|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n
|","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}}]}] BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
2023-05-02 10:09:25 -07:00
Kibana Machine
536e778ce6
[8.8] [Enterprise Search] Copyedit: remove redundant link, simplify wording (#156391) (#156416)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Copyedit: remove redundant link, simplify wording
(#156391)](https://github.com/elastic/kibana/pull/156391)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T15:40:53Z","message":"[Enterprise
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156391,"url":"https://github.com/elastic/kibana/pull/156391","mergeCommit":{"message":"[Enterprise
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156391","number":156391,"mergeCommit":{"message":"[Enterprise
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77"}}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
2023-05-02 09:54:50 -07:00
Kibana Machine
5fe472df64
[8.8] [Fleet] Use react testing libray instead of TestBed (#156301) (#156412)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] Use react testing libray instead of TestBed
(#156301)](https://github.com/elastic/kibana/pull/156301)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:23:55Z","message":"[Fleet]
Use react testing libray instead of TestBed
(#156301)","sha":"d41da8245e122176912341a274ebe77bc8b60ebf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":156301,"url":"https://github.com/elastic/kibana/pull/156301","mergeCommit":{"message":"[Fleet]
Use react testing libray instead of TestBed
(#156301)","sha":"d41da8245e122176912341a274ebe77bc8b60ebf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156301","number":156301,"mergeCommit":{"message":"[Fleet]
Use react testing libray instead of TestBed
(#156301)","sha":"d41da8245e122176912341a274ebe77bc8b60ebf"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2023-05-02 09:33:07 -07:00
Kibana Machine
5f595756fa
[8.8] [RAM] Edit maintenance window feature privilege label (#156295) (#156398)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Edit maintenance window feature privilege label
(#156295)](https://github.com/elastic/kibana/pull/156295)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:24:38Z","message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ui-copy","backport:prev-minor","v8.8.0","v8.9.0"],"number":156295,"url":"https://github.com/elastic/kibana/pull/156295","mergeCommit":{"message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156295","number":156295,"mergeCommit":{"message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2023-05-02 09:25:09 -07:00
Kibana Machine
1e2fc15eb7
[8.8] [Fleet] Fix package install with older version (#156257) (#156408)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] Fix package install with older version
(#156257)](https://github.com/elastic/kibana/pull/156257)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jill
Guyonnet","email":"jill.guyonnet@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:02:51Z","message":"[Fleet]
Fix package install with older version (#156257)\n\n##
Summary\r\n\r\nThis PR fixes a bug where an older version of a package
cannot be\r\ninstalled when creating a new agent policy.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/152095\r\n\r\n### Reproducing
the bug\r\n\r\n1. Run Kibana off the `main` branch.\r\n2. Install a
package of your choice for the first time (it should not\r\nalready be
installed) on a version lower than the latest (cf. screenshot\r\n1). In
the configuration page under `Where to add this integration?`,\r\nleave
`New hosts` selected to ensure a new agent policy is created
(cf.\r\nscreenshot 2).\r\n3. After the package is installed, go to the
package settings: notice\r\nthat the installed version is actually the
latest (cf. screenshot 3).\r\n4. Note: if you go to the `Integration
policies` tab of the package, you\r\nwill notice that the integration
policy has the version number you\r\nintended to install (cf. screenshot
4).\r\n\r\n### Cause of the bug\r\n\r\nThe `onSubmit` hook used by the
package install form [makes use the of\r\nthe
`epm/packages/_bulk`\r\nendpoint](e62581f8bf/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/form.tsx (L272))\r\nto
bulk install multiple packages if a new agent policy is to
be\r\ncreated. The `epm/packages/_bulk` endpoint accepts an array of
packages\r\nwhich are either specified by a package name (string) or
name and\r\nversion (object). In the current implementation, this hook
only provides\r\nthe package names, which resolves to the latest version
of the package\r\nbeing installed.\r\n\r\n### How this PR fixes the
bug\r\n\r\nThis PR make the following changes:\r\n* Make the
`BulkInstallPackagesFromRegistryRequestSchema` validation\r\naccepts an
array of either strings or objects of shape `{ name: string,\r\nversion:
string }` for packages.\r\n* Modify the `sendBulkInstallPackages`
request hook to do the same.\r\n* Make the `onSubmit` hook used by the
package install form pass the\r\npackage name and version to the
`epm/packages/_bulk` endpoint.\r\n\r\n### Additional changes\r\n\r\n*
Add API integration test for bulk package install\r\n* Amend OpenAPI
definition:
[Swagger\r\nlink](a4a3209905/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-install-packages)\r\n(cf.
screenshot 7)\r\n\r\n### Testing steps\r\n\r\n1. (Optional) Test that
the `epm/packages/_bulk` endpoint accepts\r\npackage name as strings or
package name and version as objects, or even\r\na mix of both (cf.
screenshot 6).\r\n2. Same steps as `Reproducing the bug` above on this
branch. The correct\r\nversion of the package should be installed (cf
screenshot 5).\r\n\r\n### Screenshots\r\n\r\nScreenshot 1: preparing to
install an older version of a package:\r\n<img width=\"1917\"
alt=\"Screenshot 2023-05-02 at 11 21
12\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631501-aa03d2b0-6fe8-4e9a-8e0c-5547f8fccea0.png\">\r\n\r\n\r\nScreenshot
2: creating a new agent policy when installing the package:\r\n<img
width=\"1917\" alt=\"Screenshot 2023-05-02 at 11 21
33\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631650-3d9bfc19-ace3-4488-a7c7-48078aae3e7c.png\">\r\n\r\nScreenshot
3: integration settings after installing an older version\r\nonto a new
agent policy, showing that the installed version is actually\r\nthe
latest version:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
29
07\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631920-3ca8f606-d225-464e-8094-46aeee4869df.png\">\r\n\r\n\r\nScreenshot
4: `Integration policies` tab, showing that the integration\r\npolicy
has the older version:\r\n<img width=\"1917\" alt=\"Screenshot
2023-05-02 at 11 28
43\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632212-c82a3ddd-cb33-4179-a4ab-b57e33e7490d.png\">\r\n\r\n\r\nScreenshot
5: integration settings after installing an older version\r\nonto a new
agent policy **with the bug fix**, showing that the correct\r\nversion
was installed:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
23
09\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632590-bb26183d-ce60-439c-9bee-eadb9fdb9654.png\">\r\n\r\n\r\nScreenshot
6: API call showing the two ways of specifying a package\r\nusing the
`epm/packages/_bulk` endpoint (package name only, or name
and\r\nversion):\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at
11 59
11\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235637532-ae32072b-ca84-48bb-9760-120a2149f0e5.png\">\r\n\r\n\r\nScreenshot
7: `epm/packages/_bulk` endpoint reference on Swagger:\r\n<img
width=\"1429\" alt=\"Screenshot 2023-05-02 at 15 13
14\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235677504-e8ba1329-1a70-44f8-92c5-0f32e5da7e46.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d71f6f3d0337a66aab755ab576fa6f4f85652a5c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.9.0"],"number":156257,"url":"https://github.com/elastic/kibana/pull/156257","mergeCommit":{"message":"[Fleet]
Fix package install with older version (#156257)\n\n##
Summary\r\n\r\nThis PR fixes a bug where an older version of a package
cannot be\r\ninstalled when creating a new agent policy.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/152095\r\n\r\n### Reproducing
the bug\r\n\r\n1. Run Kibana off the `main` branch.\r\n2. Install a
package of your choice for the first time (it should not\r\nalready be
installed) on a version lower than the latest (cf. screenshot\r\n1). In
the configuration page under `Where to add this integration?`,\r\nleave
`New hosts` selected to ensure a new agent policy is created
(cf.\r\nscreenshot 2).\r\n3. After the package is installed, go to the
package settings: notice\r\nthat the installed version is actually the
latest (cf. screenshot 3).\r\n4. Note: if you go to the `Integration
policies` tab of the package, you\r\nwill notice that the integration
policy has the version number you\r\nintended to install (cf. screenshot
4).\r\n\r\n### Cause of the bug\r\n\r\nThe `onSubmit` hook used by the
package install form [makes use the of\r\nthe
`epm/packages/_bulk`\r\nendpoint](e62581f8bf/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/form.tsx (L272))\r\nto
bulk install multiple packages if a new agent policy is to
be\r\ncreated. The `epm/packages/_bulk` endpoint accepts an array of
packages\r\nwhich are either specified by a package name (string) or
name and\r\nversion (object). In the current implementation, this hook
only provides\r\nthe package names, which resolves to the latest version
of the package\r\nbeing installed.\r\n\r\n### How this PR fixes the
bug\r\n\r\nThis PR make the following changes:\r\n* Make the
`BulkInstallPackagesFromRegistryRequestSchema` validation\r\naccepts an
array of either strings or objects of shape `{ name: string,\r\nversion:
string }` for packages.\r\n* Modify the `sendBulkInstallPackages`
request hook to do the same.\r\n* Make the `onSubmit` hook used by the
package install form pass the\r\npackage name and version to the
`epm/packages/_bulk` endpoint.\r\n\r\n### Additional changes\r\n\r\n*
Add API integration test for bulk package install\r\n* Amend OpenAPI
definition:
[Swagger\r\nlink](a4a3209905/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-install-packages)\r\n(cf.
screenshot 7)\r\n\r\n### Testing steps\r\n\r\n1. (Optional) Test that
the `epm/packages/_bulk` endpoint accepts\r\npackage name as strings or
package name and version as objects, or even\r\na mix of both (cf.
screenshot 6).\r\n2. Same steps as `Reproducing the bug` above on this
branch. The correct\r\nversion of the package should be installed (cf
screenshot 5).\r\n\r\n### Screenshots\r\n\r\nScreenshot 1: preparing to
install an older version of a package:\r\n<img width=\"1917\"
alt=\"Screenshot 2023-05-02 at 11 21
12\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631501-aa03d2b0-6fe8-4e9a-8e0c-5547f8fccea0.png\">\r\n\r\n\r\nScreenshot
2: creating a new agent policy when installing the package:\r\n<img
width=\"1917\" alt=\"Screenshot 2023-05-02 at 11 21
33\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631650-3d9bfc19-ace3-4488-a7c7-48078aae3e7c.png\">\r\n\r\nScreenshot
3: integration settings after installing an older version\r\nonto a new
agent policy, showing that the installed version is actually\r\nthe
latest version:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
29
07\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631920-3ca8f606-d225-464e-8094-46aeee4869df.png\">\r\n\r\n\r\nScreenshot
4: `Integration policies` tab, showing that the integration\r\npolicy
has the older version:\r\n<img width=\"1917\" alt=\"Screenshot
2023-05-02 at 11 28
43\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632212-c82a3ddd-cb33-4179-a4ab-b57e33e7490d.png\">\r\n\r\n\r\nScreenshot
5: integration settings after installing an older version\r\nonto a new
agent policy **with the bug fix**, showing that the correct\r\nversion
was installed:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
23
09\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632590-bb26183d-ce60-439c-9bee-eadb9fdb9654.png\">\r\n\r\n\r\nScreenshot
6: API call showing the two ways of specifying a package\r\nusing the
`epm/packages/_bulk` endpoint (package name only, or name
and\r\nversion):\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at
11 59
11\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235637532-ae32072b-ca84-48bb-9760-120a2149f0e5.png\">\r\n\r\n\r\nScreenshot
7: `epm/packages/_bulk` endpoint reference on Swagger:\r\n<img
width=\"1429\" alt=\"Screenshot 2023-05-02 at 15 13
14\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235677504-e8ba1329-1a70-44f8-92c5-0f32e5da7e46.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d71f6f3d0337a66aab755ab576fa6f4f85652a5c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156257","number":156257,"mergeCommit":{"message":"[Fleet]
Fix package install with older version (#156257)\n\n##
Summary\r\n\r\nThis PR fixes a bug where an older version of a package
cannot be\r\ninstalled when creating a new agent policy.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/152095\r\n\r\n### Reproducing
the bug\r\n\r\n1. Run Kibana off the `main` branch.\r\n2. Install a
package of your choice for the first time (it should not\r\nalready be
installed) on a version lower than the latest (cf. screenshot\r\n1). In
the configuration page under `Where to add this integration?`,\r\nleave
`New hosts` selected to ensure a new agent policy is created
(cf.\r\nscreenshot 2).\r\n3. After the package is installed, go to the
package settings: notice\r\nthat the installed version is actually the
latest (cf. screenshot 3).\r\n4. Note: if you go to the `Integration
policies` tab of the package, you\r\nwill notice that the integration
policy has the version number you\r\nintended to install (cf. screenshot
4).\r\n\r\n### Cause of the bug\r\n\r\nThe `onSubmit` hook used by the
package install form [makes use the of\r\nthe
`epm/packages/_bulk`\r\nendpoint](e62581f8bf/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/form.tsx (L272))\r\nto
bulk install multiple packages if a new agent policy is to
be\r\ncreated. The `epm/packages/_bulk` endpoint accepts an array of
packages\r\nwhich are either specified by a package name (string) or
name and\r\nversion (object). In the current implementation, this hook
only provides\r\nthe package names, which resolves to the latest version
of the package\r\nbeing installed.\r\n\r\n### How this PR fixes the
bug\r\n\r\nThis PR make the following changes:\r\n* Make the
`BulkInstallPackagesFromRegistryRequestSchema` validation\r\naccepts an
array of either strings or objects of shape `{ name: string,\r\nversion:
string }` for packages.\r\n* Modify the `sendBulkInstallPackages`
request hook to do the same.\r\n* Make the `onSubmit` hook used by the
package install form pass the\r\npackage name and version to the
`epm/packages/_bulk` endpoint.\r\n\r\n### Additional changes\r\n\r\n*
Add API integration test for bulk package install\r\n* Amend OpenAPI
definition:
[Swagger\r\nlink](a4a3209905/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-install-packages)\r\n(cf.
screenshot 7)\r\n\r\n### Testing steps\r\n\r\n1. (Optional) Test that
the `epm/packages/_bulk` endpoint accepts\r\npackage name as strings or
package name and version as objects, or even\r\na mix of both (cf.
screenshot 6).\r\n2. Same steps as `Reproducing the bug` above on this
branch. The correct\r\nversion of the package should be installed (cf
screenshot 5).\r\n\r\n### Screenshots\r\n\r\nScreenshot 1: preparing to
install an older version of a package:\r\n<img width=\"1917\"
alt=\"Screenshot 2023-05-02 at 11 21
12\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631501-aa03d2b0-6fe8-4e9a-8e0c-5547f8fccea0.png\">\r\n\r\n\r\nScreenshot
2: creating a new agent policy when installing the package:\r\n<img
width=\"1917\" alt=\"Screenshot 2023-05-02 at 11 21
33\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631650-3d9bfc19-ace3-4488-a7c7-48078aae3e7c.png\">\r\n\r\nScreenshot
3: integration settings after installing an older version\r\nonto a new
agent policy, showing that the installed version is actually\r\nthe
latest version:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
29
07\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235631920-3ca8f606-d225-464e-8094-46aeee4869df.png\">\r\n\r\n\r\nScreenshot
4: `Integration policies` tab, showing that the integration\r\npolicy
has the older version:\r\n<img width=\"1917\" alt=\"Screenshot
2023-05-02 at 11 28
43\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632212-c82a3ddd-cb33-4179-a4ab-b57e33e7490d.png\">\r\n\r\n\r\nScreenshot
5: integration settings after installing an older version\r\nonto a new
agent policy **with the bug fix**, showing that the correct\r\nversion
was installed:\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at 11
23
09\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235632590-bb26183d-ce60-439c-9bee-eadb9fdb9654.png\">\r\n\r\n\r\nScreenshot
6: API call showing the two ways of specifying a package\r\nusing the
`epm/packages/_bulk` endpoint (package name only, or name
and\r\nversion):\r\n<img width=\"1917\" alt=\"Screenshot 2023-05-02 at
11 59
11\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235637532-ae32072b-ca84-48bb-9760-120a2149f0e5.png\">\r\n\r\n\r\nScreenshot
7: `epm/packages/_bulk` endpoint reference on Swagger:\r\n<img
width=\"1429\" alt=\"Screenshot 2023-05-02 at 15 13
14\"\r\nsrc=\"https://user-images.githubusercontent.com/23701614/235677504-e8ba1329-1a70-44f8-92c5-0f32e5da7e46.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d71f6f3d0337a66aab755ab576fa6f4f85652a5c"}}]}]
BACKPORT-->

Co-authored-by: Jill Guyonnet <jill.guyonnet@elastic.co>
2023-05-02 09:11:40 -07:00
Kibana Machine
3d84be9844
[8.8] [Cases] Edit labels for file attachments (#156026) (#156406)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Edit labels for file attachments
(#156026)](https://github.com/elastic/kibana/pull/156026)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:49:53Z","message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","ui-copy","v8.8.0","v8.9.0"],"number":156026,"url":"https://github.com/elastic/kibana/pull/156026","mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156026","number":156026,"mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2023-05-02 09:02:02 -07:00
Lisa Cawley
ab2372476c
[8.8] [Cases] Edit labels for file attachments (#156026) (#156405)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Edit labels for file attachments
(#156026)](https://github.com/elastic/kibana/pull/156026)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:49:53Z","message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","ui-copy","v8.8.0","v8.9.0"],"number":156026,"url":"https://github.com/elastic/kibana/pull/156026","mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156026","number":156026,"mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}}]}]
BACKPORT-->
2023-05-02 09:00:48 -07:00
Kibana Machine
c7be05786b
[8.8] [Fleet] Removes messageSigningService api definition from openApi spec (#156376) (#156401)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] Removes messageSigningService api definition from openApi
spec (#156376)](https://github.com/elastic/kibana/pull/156376)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"David
Sánchez","email":"david.sanchezsoler@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:28:11Z","message":"[Fleet]
Removes messageSigningService api definition from openApi spec
(#156376)\n\n## Summary\r\n\r\n- Removes message signing service api
definition from openAPI spec.\r\n- Updates warning message when
`acknowledge` param is missing or set
to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":156376,"url":"https://github.com/elastic/kibana/pull/156376","mergeCommit":{"message":"[Fleet]
Removes messageSigningService api definition from openApi spec
(#156376)\n\n## Summary\r\n\r\n- Removes message signing service api
definition from openAPI spec.\r\n- Updates warning message when
`acknowledge` param is missing or set
to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156376","number":156376,"mergeCommit":{"message":"[Fleet]
Removes messageSigningService api definition from openApi spec
(#156376)\n\n## Summary\r\n\r\n- Removes message signing service api
definition from openAPI spec.\r\n- Updates warning message when
`acknowledge` param is missing or set
to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93"}}]}]
BACKPORT-->

Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co>
2023-05-02 08:41:19 -07:00
Kibana Machine
2cd6d1bd24
[8.8] [Security Solution] [Fix] Alert Page Controls do not take Alert Table "Additional Filters" into account. (#155861) (#156388)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] [Fix] Alert Page Controls do not take Alert Table
"Additional Filters" into account.
(#155861)](https://github.com/elastic/kibana/pull/155861)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:47:12Z","message":"[Security
Solution] [Fix] Alert Page Controls do not take Alert Table \"Additional
Filters\" into account. (#155861)\n\n## Summary\r\n\r\nThis PR handles :
[Security Solution] New alert filters are not taking\r\ninto
consideration alert table filters #155173 and #156252\r\n\r\nCurrently,
Alert Page Controls do not take Alert Table Checkboxes (\r\nBuilding
block + Threat indicator alerts only ) into account. This PR\r\nenables
the effect of Alert Table Checkboxes on Alert Page controls\r\n\r\n|
Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234568673-b05ffc32-09bc-4378-aecb-bb64dbc5cbb6.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234562759-6309d6a0-f7db-48fd-bd9e-62788a1c89fe.mov\"/>\r\n|\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"aeded80d8625833a3dee83bb723732631b32c6a9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":155861,"url":"https://github.com/elastic/kibana/pull/155861","mergeCommit":{"message":"[Security
Solution] [Fix] Alert Page Controls do not take Alert Table \"Additional
Filters\" into account. (#155861)\n\n## Summary\r\n\r\nThis PR handles :
[Security Solution] New alert filters are not taking\r\ninto
consideration alert table filters #155173 and #156252\r\n\r\nCurrently,
Alert Page Controls do not take Alert Table Checkboxes (\r\nBuilding
block + Threat indicator alerts only ) into account. This PR\r\nenables
the effect of Alert Table Checkboxes on Alert Page controls\r\n\r\n|
Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234568673-b05ffc32-09bc-4378-aecb-bb64dbc5cbb6.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234562759-6309d6a0-f7db-48fd-bd9e-62788a1c89fe.mov\"/>\r\n|\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"aeded80d8625833a3dee83bb723732631b32c6a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155861","number":155861,"mergeCommit":{"message":"[Security
Solution] [Fix] Alert Page Controls do not take Alert Table \"Additional
Filters\" into account. (#155861)\n\n## Summary\r\n\r\nThis PR handles :
[Security Solution] New alert filters are not taking\r\ninto
consideration alert table filters #155173 and #156252\r\n\r\nCurrently,
Alert Page Controls do not take Alert Table Checkboxes (\r\nBuilding
block + Threat indicator alerts only ) into account. This PR\r\nenables
the effect of Alert Table Checkboxes on Alert Page controls\r\n\r\n|
Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234568673-b05ffc32-09bc-4378-aecb-bb64dbc5cbb6.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234562759-6309d6a0-f7db-48fd-bd9e-62788a1c89fe.mov\"/>\r\n|\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios.","sha":"aeded80d8625833a3dee83bb723732631b32c6a9"}}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
2023-05-02 08:33:31 -07:00
Kibana Machine
100c832661
[8.8] Fix throughput chart on APM alert details page (#156348) (#156389)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix throughput chart on APM alert details page
(#156348)](https://github.com/elastic/kibana/pull/156348)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:52:46Z","message":"Fix
throughput chart on APM alert details page (#156348)\n\nFixes
#154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and
tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\"
/>\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold
alert\r\n- Go to the alert details page and check the throughput chart
for the\r\ncorrect label and
tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156348,"url":"https://github.com/elastic/kibana/pull/156348","mergeCommit":{"message":"Fix
throughput chart on APM alert details page (#156348)\n\nFixes
#154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and
tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\"
/>\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold
alert\r\n- Go to the alert details page and check the throughput chart
for the\r\ncorrect label and
tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156348","number":156348,"mergeCommit":{"message":"Fix
throughput chart on APM alert details page (#156348)\n\nFixes
#154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and
tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\"
/>\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold
alert\r\n- Go to the alert details page and check the throughput chart
for the\r\ncorrect label and
tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
2023-05-02 08:29:29 -07:00
Kibana Machine
ad65768a1b
[8.8] [RAM] Apply maintenance windows privilege to UI (#156191) (#156387)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Apply maintenance windows privilege to UI
(#156191)](https://github.com/elastic/kibana/pull/156191)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:47:29Z","message":"[RAM]
Apply maintenance windows privilege to UI (#156191)\n\n##
Summary\r\n\r\nWe will have three scenarios with kibana
privileges\r\n\r\n### NONE\r\nKibana privileges form maintenance
window:\r\n<img width=\"680\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188523-acaff7de-54d4-4991-a014-05c0f449738c.png\">\r\n\r\n`The
expected result is to not see maintenance window at all`\r\n\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188658-6a53b463-4856-42c7-916e-aa8e6d7e326b.png\">\r\n\r\n###
READ\r\nKibana privileges form maintenance window:\r\n<img width=\"677\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188908-623d32ac-39a7-484e-bd5c-f858e04d16b2.png\">\r\n\r\n`The
expected result is to only see the table with window maintenance\r\nand
you can not edit them`\r\n\r\n<img width=\"1487\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189169-f71422bf-6394-4574-87fb-14c653ca1e79.png\">\r\n<img
width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192048-149519ba-0505-46e3-b737-2703560eb3d6.png\">\r\n\r\n\r\n###
ALL\r\nKibana privileges form maintenance window:\r\n<img width=\"668\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189384-e71d9138-221c-4024-91bb-2ae32da1bd3b.png\">\r\n\r\n`The
expected result is to be able to create/edit/etc on any
maintenance\r\nwindows`\r\n\r\n<img width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189974-e36c1e65-0586-4840-ace5-32caf06455c6.png\">\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192269-0f8d1922-d48f-494c-9979-2288bf142286.png\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3c9da2cd296f9e23b5052e8bf624ddd062bcbcd0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:high","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156191,"url":"https://github.com/elastic/kibana/pull/156191","mergeCommit":{"message":"[RAM]
Apply maintenance windows privilege to UI (#156191)\n\n##
Summary\r\n\r\nWe will have three scenarios with kibana
privileges\r\n\r\n### NONE\r\nKibana privileges form maintenance
window:\r\n<img width=\"680\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188523-acaff7de-54d4-4991-a014-05c0f449738c.png\">\r\n\r\n`The
expected result is to not see maintenance window at all`\r\n\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188658-6a53b463-4856-42c7-916e-aa8e6d7e326b.png\">\r\n\r\n###
READ\r\nKibana privileges form maintenance window:\r\n<img width=\"677\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188908-623d32ac-39a7-484e-bd5c-f858e04d16b2.png\">\r\n\r\n`The
expected result is to only see the table with window maintenance\r\nand
you can not edit them`\r\n\r\n<img width=\"1487\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189169-f71422bf-6394-4574-87fb-14c653ca1e79.png\">\r\n<img
width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192048-149519ba-0505-46e3-b737-2703560eb3d6.png\">\r\n\r\n\r\n###
ALL\r\nKibana privileges form maintenance window:\r\n<img width=\"668\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189384-e71d9138-221c-4024-91bb-2ae32da1bd3b.png\">\r\n\r\n`The
expected result is to be able to create/edit/etc on any
maintenance\r\nwindows`\r\n\r\n<img width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189974-e36c1e65-0586-4840-ace5-32caf06455c6.png\">\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192269-0f8d1922-d48f-494c-9979-2288bf142286.png\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3c9da2cd296f9e23b5052e8bf624ddd062bcbcd0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156191","number":156191,"mergeCommit":{"message":"[RAM]
Apply maintenance windows privilege to UI (#156191)\n\n##
Summary\r\n\r\nWe will have three scenarios with kibana
privileges\r\n\r\n### NONE\r\nKibana privileges form maintenance
window:\r\n<img width=\"680\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188523-acaff7de-54d4-4991-a014-05c0f449738c.png\">\r\n\r\n`The
expected result is to not see maintenance window at all`\r\n\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188658-6a53b463-4856-42c7-916e-aa8e6d7e326b.png\">\r\n\r\n###
READ\r\nKibana privileges form maintenance window:\r\n<img width=\"677\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235188908-623d32ac-39a7-484e-bd5c-f858e04d16b2.png\">\r\n\r\n`The
expected result is to only see the table with window maintenance\r\nand
you can not edit them`\r\n\r\n<img width=\"1487\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189169-f71422bf-6394-4574-87fb-14c653ca1e79.png\">\r\n<img
width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192048-149519ba-0505-46e3-b737-2703560eb3d6.png\">\r\n\r\n\r\n###
ALL\r\nKibana privileges form maintenance window:\r\n<img width=\"668\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189384-e71d9138-221c-4024-91bb-2ae32da1bd3b.png\">\r\n\r\n`The
expected result is to be able to create/edit/etc on any
maintenance\r\nwindows`\r\n\r\n<img width=\"1484\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235189974-e36c1e65-0586-4840-ace5-32caf06455c6.png\">\r\n<img
width=\"1481\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/189600/235192269-0f8d1922-d48f-494c-9979-2288bf142286.png\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3c9da2cd296f9e23b5052e8bf624ddd062bcbcd0"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
2023-05-02 08:26:07 -07:00
Kibana Machine
7f7062543f
[8.8] [AO] Fix APM latency expected value (#156269) (#156394)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[AO] Fix APM latency expected value
(#156269)](https://github.com/elastic/kibana/pull/156269)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:09:49Z","message":"[AO]
Fix APM latency expected value (#156269)\n\nFixes #154801\r\n\r\n## 📝
Summary \r\nThis PR fixes the expected value of the APM latency rule
both in the\r\nflyout and alert details page.\r\n\r\n|Before|After
1|After
2|\r\n|---|---|---|\r\n\r\n|![image](235477667-438ebd69-3e4d-4e95-88f1-5fc8febf9125.png)|\r\n\r\n\r\n##
🧪 How to test\r\n- Create an APM Latency alert\r\n- Click on the reason
to open the flyout and check the expected value\r\nthere\r\n- From the
action menu of that alert, go to alert details page and check\r\nthe
expected
value","sha":"b5914f4342659abbe168ca4d849d94b6ee24cbf4","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:APM","release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156269,"url":"https://github.com/elastic/kibana/pull/156269","mergeCommit":{"message":"[AO]
Fix APM latency expected value (#156269)\n\nFixes #154801\r\n\r\n## 📝
Summary \r\nThis PR fixes the expected value of the APM latency rule
both in the\r\nflyout and alert details page.\r\n\r\n|Before|After
1|After
2|\r\n|---|---|---|\r\n\r\n|![image](235477667-438ebd69-3e4d-4e95-88f1-5fc8febf9125.png)|\r\n\r\n\r\n##
🧪 How to test\r\n- Create an APM Latency alert\r\n- Click on the reason
to open the flyout and check the expected value\r\nthere\r\n- From the
action menu of that alert, go to alert details page and check\r\nthe
expected
value","sha":"b5914f4342659abbe168ca4d849d94b6ee24cbf4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156269","number":156269,"mergeCommit":{"message":"[AO]
Fix APM latency expected value (#156269)\n\nFixes #154801\r\n\r\n## 📝
Summary \r\nThis PR fixes the expected value of the APM latency rule
both in the\r\nflyout and alert details page.\r\n\r\n|Before|After
1|After
2|\r\n|---|---|---|\r\n\r\n|![image](235477667-438ebd69-3e4d-4e95-88f1-5fc8febf9125.png)|\r\n\r\n\r\n##
🧪 How to test\r\n- Create an APM Latency alert\r\n- Click on the reason
to open the flyout and check the expected value\r\nthere\r\n- From the
action menu of that alert, go to alert details page and check\r\nthe
expected value","sha":"b5914f4342659abbe168ca4d849d94b6ee24cbf4"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
2023-05-02 08:21:38 -07:00
Kibana Machine
251123c4bb
[8.8] [Infrastructure UI] Fix Lens charts for APM hosts (#156372) (#156390)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Infrastructure UI] Fix Lens charts for APM hosts
(#156372)](https://github.com/elastic/kibana/pull/156372)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T13:56:06Z","message":"[Infrastructure
UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter
the implementation of the new API and host limit, all charts now\r\nload
only after the table is loaded. This PR changes the filters the\r\npage
currently passes to Lens, to pass only a list of host names, the\r\nsame
way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where
filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n###
How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n-
Go to Hosts view\r\n- Filter by `service.name:
\"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics
UI","Team:Infra Monitoring
UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0"],"number":156372,"url":"https://github.com/elastic/kibana/pull/156372","mergeCommit":{"message":"[Infrastructure
UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter
the implementation of the new API and host limit, all charts now\r\nload
only after the table is loaded. This PR changes the filters the\r\npage
currently passes to Lens, to pass only a list of host names, the\r\nsame
way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where
filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n###
How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n-
Go to Hosts view\r\n- Filter by `service.name:
\"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156372","number":156372,"mergeCommit":{"message":"[Infrastructure
UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter
the implementation of the new API and host limit, all charts now\r\nload
only after the table is loaded. This PR changes the filters the\r\npage
currently passes to Lens, to pass only a list of host names, the\r\nsame
way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where
filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img
width=\"772\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n###
How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n-
Go to Hosts view\r\n- Filter by `service.name:
\"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
2023-05-02 08:04:07 -07:00
Kibana Machine
ecad0513f6
[8.8] feat(slo): delete associated rules when deleting an SLO (#156307) (#156386)
# Backport

This will backport the following commits from `main` to `8.8`:
- [feat(slo): delete associated rules when deleting an SLO
(#156307)](https://github.com/elastic/kibana/pull/156307)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:42:32Z","message":"feat(slo):
delete associated rules when deleting an SLO
(#156307)","sha":"dbedd53b481439a0c24c99fc11249caa50e78272","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156307,"url":"https://github.com/elastic/kibana/pull/156307","mergeCommit":{"message":"feat(slo):
delete associated rules when deleting an SLO
(#156307)","sha":"dbedd53b481439a0c24c99fc11249caa50e78272"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156307","number":156307,"mergeCommit":{"message":"feat(slo):
delete associated rules when deleting an SLO
(#156307)","sha":"dbedd53b481439a0c24c99fc11249caa50e78272"}}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
2023-05-02 07:55:37 -07:00
Kibana Machine
efef8531ed
[8.8] Fix alert details page name (#156370) (#156384)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix alert details page name
(#156370)](https://github.com/elastic/kibana/pull/156370)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:18:50Z","message":"Fix
alert details page name (#156370)\n\nFixes #156163\r\n\r\n##
Summary\r\n\r\nThis PR fixes the alert details page
name:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235664034-4038bf82-387d-4dfb-ad03-0cf0e5e3b1a6.png\"\r\nwidth=\"500\"/>","sha":"bf0920d324155d4f66f98725b2ce4b5285d84886","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156370,"url":"https://github.com/elastic/kibana/pull/156370","mergeCommit":{"message":"Fix
alert details page name (#156370)\n\nFixes #156163\r\n\r\n##
Summary\r\n\r\nThis PR fixes the alert details page
name:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235664034-4038bf82-387d-4dfb-ad03-0cf0e5e3b1a6.png\"\r\nwidth=\"500\"/>","sha":"bf0920d324155d4f66f98725b2ce4b5285d84886"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156370","number":156370,"mergeCommit":{"message":"Fix
alert details page name (#156370)\n\nFixes #156163\r\n\r\n##
Summary\r\n\r\nThis PR fixes the alert details page
name:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235664034-4038bf82-387d-4dfb-ad03-0cf0e5e3b1a6.png\"\r\nwidth=\"500\"/>","sha":"bf0920d324155d4f66f98725b2ce4b5285d84886"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
2023-05-02 07:33:26 -07:00
Kibana Machine
595cc3fbd0
[8.8] [Infarstructure UI] Fix hosts view functional test (#155772) (#156360)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Infarstructure UI] Fix hosts view functional test
(#155772)](https://github.com/elastic/kibana/pull/155772)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T11:40:48Z","message":"[Infarstructure
UI] Fix hosts view functional test (#155772)\n\ncloses
https://github.com/elastic/kibana/issues/155429\r\ncloses
https://github.com/elastic/kibana/issues/155293\r\n\r\n##
Summary\r\n\r\n\r\nThis PR fixes the hosts view functional test,
stabilizing the flaky test\r\ncases that started to fail after changes
were made to the page\r\n\r\n\r\n### How to test\r\n\r\n- `yarn
test:ftr:server
--config\r\nx-pack/test/functional/apps/infra/config.ts`\r\n- `yarn
test:ftr:runner --config\r\nx-pack/test/functional/apps/infra/config.ts
--include\r\nx-pack/test/functional/apps/infra/hosts_view.ts`\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c4669323f7a1a781eaa2eaddab74971c480c80e8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics
UI","Team:Infra Monitoring
UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0"],"number":155772,"url":"https://github.com/elastic/kibana/pull/155772","mergeCommit":{"message":"[Infarstructure
UI] Fix hosts view functional test (#155772)\n\ncloses
https://github.com/elastic/kibana/issues/155429\r\ncloses
https://github.com/elastic/kibana/issues/155293\r\n\r\n##
Summary\r\n\r\n\r\nThis PR fixes the hosts view functional test,
stabilizing the flaky test\r\ncases that started to fail after changes
were made to the page\r\n\r\n\r\n### How to test\r\n\r\n- `yarn
test:ftr:server
--config\r\nx-pack/test/functional/apps/infra/config.ts`\r\n- `yarn
test:ftr:runner --config\r\nx-pack/test/functional/apps/infra/config.ts
--include\r\nx-pack/test/functional/apps/infra/hosts_view.ts`\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c4669323f7a1a781eaa2eaddab74971c480c80e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155772","number":155772,"mergeCommit":{"message":"[Infarstructure
UI] Fix hosts view functional test (#155772)\n\ncloses
https://github.com/elastic/kibana/issues/155429\r\ncloses
https://github.com/elastic/kibana/issues/155293\r\n\r\n##
Summary\r\n\r\n\r\nThis PR fixes the hosts view functional test,
stabilizing the flaky test\r\ncases that started to fail after changes
were made to the page\r\n\r\n\r\n### How to test\r\n\r\n- `yarn
test:ftr:server
--config\r\nx-pack/test/functional/apps/infra/config.ts`\r\n- `yarn
test:ftr:runner --config\r\nx-pack/test/functional/apps/infra/config.ts
--include\r\nx-pack/test/functional/apps/infra/hosts_view.ts`\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c4669323f7a1a781eaa2eaddab74971c480c80e8"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
2023-05-02 05:52:38 -07:00
Kibana Machine
99887680e2
[8.8] [Security Solutions] Fix install azure integration URL and loading state (#155706) (#156262)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solutions] Fix install azure integration URL and loading
state (#155706)](https://github.com/elastic/kibana/pull/155706)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T14:09:25Z","message":"[Security
Solutions] Fix install azure integration URL and loading state
(#155706)\n\n## Summary\r\n\r\n* Generate Azure integration URL instead
of hardcoding it
\r\n\r\n![Apr-26-2023\r\n14-32-40](https://user-images.githubusercontent.com/1490444/234575705-6ff288c3-5691-4b66-af6c-cf1383f3399b.gif)\r\n\r\n*
Fix flyout showing callout when
loading\r\n\r\n![Apr-26-2023\r\n14-25-10](https://user-images.githubusercontent.com/1490444/234574219-ed25f37b-0206-49d6-bc81-8d75cf023e64.gif)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"23d47b7d105ee285c58dda20958984e5a3030515","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","v8.0.0","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.9.0"],"number":155706,"url":"https://github.com/elastic/kibana/pull/155706","mergeCommit":{"message":"[Security
Solutions] Fix install azure integration URL and loading state
(#155706)\n\n## Summary\r\n\r\n* Generate Azure integration URL instead
of hardcoding it
\r\n\r\n![Apr-26-2023\r\n14-32-40](https://user-images.githubusercontent.com/1490444/234575705-6ff288c3-5691-4b66-af6c-cf1383f3399b.gif)\r\n\r\n*
Fix flyout showing callout when
loading\r\n\r\n![Apr-26-2023\r\n14-25-10](https://user-images.githubusercontent.com/1490444/234574219-ed25f37b-0206-49d6-bc81-8d75cf023e64.gif)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"23d47b7d105ee285c58dda20958984e5a3030515"}},"sourceBranch":"main","suggestedTargetBranches":["8.0"],"targetPullRequestStates":[{"branch":"8.0","label":"v8.0.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155706","number":155706,"mergeCommit":{"message":"[Security
Solutions] Fix install azure integration URL and loading state
(#155706)\n\n## Summary\r\n\r\n* Generate Azure integration URL instead
of hardcoding it
\r\n\r\n![Apr-26-2023\r\n14-32-40](https://user-images.githubusercontent.com/1490444/234575705-6ff288c3-5691-4b66-af6c-cf1383f3399b.gif)\r\n\r\n*
Fix flyout showing callout when
loading\r\n\r\n![Apr-26-2023\r\n14-25-10](https://user-images.githubusercontent.com/1490444/234574219-ed25f37b-0206-49d6-bc81-8d75cf023e64.gif)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"23d47b7d105ee285c58dda20958984e5a3030515"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
2023-05-02 05:42:10 -07:00
Kibana Machine
b8073f5b73
[8.8] [SecuritySolution] Fix building block alert highlighting (#155497) (#156137)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix building block alert highlighting
(#155497)](https://github.com/elastic/kibana/pull/155497)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2023-04-28T07:50:21Z","message":"[SecuritySolution]
Fix building block alert highlighting (#155497)\n\n## Summary\r\n\r\nAs
described in https://github.com/elastic/kibana/issues/152318,
we\r\nnoticed that building block alerts were not highlighted anymore
after\r\nthe migration to the new alerts table.\r\n\r\nA preferred
implementation of building block alert highlighting would\r\nfollow the
[`EUIDataGrid` approach of
row\r\nhighlighting](https://eui.elastic.co/#/tabular-content/data-grid-style-display#grid-row-classes).\r\nThe
`DataGrid` allows you to pass custom CSS class names for each
row\r\n(`gridStyle.rowClasses`). That would allow us to highlight table
rows\r\nwith building block alerts.\r\n\r\nHowever, without access to
the underlying data, we would not be able\r\ngenerate the correct
`rowClasses` for rows with building block alerts.\r\nSo simply passing
`gridStyle.rowClasses` to the `AlertsStateTable` was\r\nnot an
option.\r\n\r\nTherefore in this PR we're introducing a new prop on the
`AlertsTable`,\r\nthe `highlightedRowMapper`. It's a callback function
that receives the\r\nalert data and when it returns true, that row will
be highlighted.\r\n\r\nThis allows for highlighting of rows from the
outside without exposing\r\ntoo many details about the underlying data
structures.\r\n\r\n**Screenshot of the alerts table with a
highlightedRowMapper that\r\nhighlights building block
alerts**\r\n\r\n<img width=\"1259\" alt=\"Screenshot 2023-04-21 at 13 03
54\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620704-a56204c0-e285-4289-897a-58481f440446.png\">\r\n\r\n###
Additional notes\r\n\r\n- Since the alerts table has default grid
styles, it allows to pass\r\n`gridStyle` and it computes its own
`rowClasses` for \"active row\"\r\nhighlighting, the logic for merging
all those styles looks intimidating.\r\nI tried my best to comment that
part of code to make it clear why the\r\nmerges are necessary and how
they work.\r\n- While working on the issue, I noticed that active rows
are not\r\nhighlighted anymore (related
bug:\r\nhttps://github.com/elastic/kibana/issues/155487). The changes in
this PR\r\nfix that behaviour as well as you can see in the screenshot
below:\r\n\r\n<img width=\"936\" alt=\"Screenshot 2023-04-21 at 13 04
15\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620752-d752dada-9c97-4f00-933a-5425e19a5793.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ce71264d88c46c45ed8ac00dc6c74bcbd05809c7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Team:Threat
Hunting:Investigations","backport:prev-minor","v8.8.0","v8.9.0"],"number":155497,"url":"https://github.com/elastic/kibana/pull/155497","mergeCommit":{"message":"[SecuritySolution]
Fix building block alert highlighting (#155497)\n\n## Summary\r\n\r\nAs
described in https://github.com/elastic/kibana/issues/152318,
we\r\nnoticed that building block alerts were not highlighted anymore
after\r\nthe migration to the new alerts table.\r\n\r\nA preferred
implementation of building block alert highlighting would\r\nfollow the
[`EUIDataGrid` approach of
row\r\nhighlighting](https://eui.elastic.co/#/tabular-content/data-grid-style-display#grid-row-classes).\r\nThe
`DataGrid` allows you to pass custom CSS class names for each
row\r\n(`gridStyle.rowClasses`). That would allow us to highlight table
rows\r\nwith building block alerts.\r\n\r\nHowever, without access to
the underlying data, we would not be able\r\ngenerate the correct
`rowClasses` for rows with building block alerts.\r\nSo simply passing
`gridStyle.rowClasses` to the `AlertsStateTable` was\r\nnot an
option.\r\n\r\nTherefore in this PR we're introducing a new prop on the
`AlertsTable`,\r\nthe `highlightedRowMapper`. It's a callback function
that receives the\r\nalert data and when it returns true, that row will
be highlighted.\r\n\r\nThis allows for highlighting of rows from the
outside without exposing\r\ntoo many details about the underlying data
structures.\r\n\r\n**Screenshot of the alerts table with a
highlightedRowMapper that\r\nhighlights building block
alerts**\r\n\r\n<img width=\"1259\" alt=\"Screenshot 2023-04-21 at 13 03
54\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620704-a56204c0-e285-4289-897a-58481f440446.png\">\r\n\r\n###
Additional notes\r\n\r\n- Since the alerts table has default grid
styles, it allows to pass\r\n`gridStyle` and it computes its own
`rowClasses` for \"active row\"\r\nhighlighting, the logic for merging
all those styles looks intimidating.\r\nI tried my best to comment that
part of code to make it clear why the\r\nmerges are necessary and how
they work.\r\n- While working on the issue, I noticed that active rows
are not\r\nhighlighted anymore (related
bug:\r\nhttps://github.com/elastic/kibana/issues/155487). The changes in
this PR\r\nfix that behaviour as well as you can see in the screenshot
below:\r\n\r\n<img width=\"936\" alt=\"Screenshot 2023-04-21 at 13 04
15\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620752-d752dada-9c97-4f00-933a-5425e19a5793.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ce71264d88c46c45ed8ac00dc6c74bcbd05809c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155497","number":155497,"mergeCommit":{"message":"[SecuritySolution]
Fix building block alert highlighting (#155497)\n\n## Summary\r\n\r\nAs
described in https://github.com/elastic/kibana/issues/152318,
we\r\nnoticed that building block alerts were not highlighted anymore
after\r\nthe migration to the new alerts table.\r\n\r\nA preferred
implementation of building block alert highlighting would\r\nfollow the
[`EUIDataGrid` approach of
row\r\nhighlighting](https://eui.elastic.co/#/tabular-content/data-grid-style-display#grid-row-classes).\r\nThe
`DataGrid` allows you to pass custom CSS class names for each
row\r\n(`gridStyle.rowClasses`). That would allow us to highlight table
rows\r\nwith building block alerts.\r\n\r\nHowever, without access to
the underlying data, we would not be able\r\ngenerate the correct
`rowClasses` for rows with building block alerts.\r\nSo simply passing
`gridStyle.rowClasses` to the `AlertsStateTable` was\r\nnot an
option.\r\n\r\nTherefore in this PR we're introducing a new prop on the
`AlertsTable`,\r\nthe `highlightedRowMapper`. It's a callback function
that receives the\r\nalert data and when it returns true, that row will
be highlighted.\r\n\r\nThis allows for highlighting of rows from the
outside without exposing\r\ntoo many details about the underlying data
structures.\r\n\r\n**Screenshot of the alerts table with a
highlightedRowMapper that\r\nhighlights building block
alerts**\r\n\r\n<img width=\"1259\" alt=\"Screenshot 2023-04-21 at 13 03
54\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620704-a56204c0-e285-4289-897a-58481f440446.png\">\r\n\r\n###
Additional notes\r\n\r\n- Since the alerts table has default grid
styles, it allows to pass\r\n`gridStyle` and it computes its own
`rowClasses` for \"active row\"\r\nhighlighting, the logic for merging
all those styles looks intimidating.\r\nI tried my best to comment that
part of code to make it clear why the\r\nmerges are necessary and how
they work.\r\n- While working on the issue, I noticed that active rows
are not\r\nhighlighted anymore (related
bug:\r\nhttps://github.com/elastic/kibana/issues/155487). The changes in
this PR\r\nfix that behaviour as well as you can see in the screenshot
below:\r\n\r\n<img width=\"936\" alt=\"Screenshot 2023-04-21 at 13 04
15\"\r\nsrc=\"https://user-images.githubusercontent.com/68591/233620752-d752dada-9c97-4f00-933a-5425e19a5793.png\">\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ce71264d88c46c45ed8ac00dc6c74bcbd05809c7"}}]}]
BACKPORT-->

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
2023-05-02 05:19:58 -07:00
Kibana Machine
4c055e01d7
[8.8] [SecuritySolution] Fix edit dashboard url (#156160) (#156339)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix edit dashboard url
(#156160)](https://github.com/elastic/kibana/pull/156160)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T09:26:32Z","message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","fixed","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Security
Dashboards","v8.9.0"],"number":156160,"url":"https://github.com/elastic/kibana/pull/156160","mergeCommit":{"message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156160","number":156160,"mergeCommit":{"message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
2023-05-02 04:12:47 -07:00
Kibana Machine
fb29dfd61a
[8.8] [RAM] Slack Web API Connector Channels List Error Message Not Showing Up (#155996) (#156342)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Slack Web API Connector Channels List Error Message Not Showing
Up (#155996)](https://github.com/elastic/kibana/pull/155996)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T09:28:56Z","message":"[RAM]
Slack Web API Connector Channels List Error Message Not Showing Up
(#155996)\n\nFixes
https://github.com/elastic/kibana/issues/155722\r\n\r\nAdds an
integration test that loads the ActionForm using SlackApi\r\nconnector
so we can check that the right error message is
shown\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"e62581f8bf6098f2813768af2f31647c592645a2","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.8.0","v8.9.0"],"number":155996,"url":"https://github.com/elastic/kibana/pull/155996","mergeCommit":{"message":"[RAM]
Slack Web API Connector Channels List Error Message Not Showing Up
(#155996)\n\nFixes
https://github.com/elastic/kibana/issues/155722\r\n\r\nAdds an
integration test that loads the ActionForm using SlackApi\r\nconnector
so we can check that the right error message is
shown\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"e62581f8bf6098f2813768af2f31647c592645a2"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155996","number":155996,"mergeCommit":{"message":"[RAM]
Slack Web API Connector Channels List Error Message Not Showing Up
(#155996)\n\nFixes
https://github.com/elastic/kibana/issues/155722\r\n\r\nAdds an
integration test that loads the ActionForm using SlackApi\r\nconnector
so we can check that the right error message is
shown\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"e62581f8bf6098f2813768af2f31647c592645a2"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
2023-05-02 03:44:58 -07:00
Kibana Machine
742d261787
[8.8] [Defend Workflows][E2E]Endpoint e2e response console multipass (#155519) (#155975)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Defend Workflows][E2E]Endpoint e2e response console multipass
(#155519)](https://github.com/elastic/kibana/pull/155519)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-04-27T08:27:21Z","message":"[Defend
Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis
PR adds e2e test run on real endpoint for coverage of
isolate,\r\nprocesses, kill-process and suspend-process commands from
respond\r\nconsole.\r\n\r\nDepends on
https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":155519,"url":"https://github.com/elastic/kibana/pull/155519","mergeCommit":{"message":"[Defend
Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis
PR adds e2e test run on real endpoint for coverage of
isolate,\r\nprocesses, kill-process and suspend-process commands from
respond\r\nconsole.\r\n\r\nDepends on
https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155519","number":155519,"mergeCommit":{"message":"[Defend
Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis
PR adds e2e test run on real endpoint for coverage of
isolate,\r\nprocesses, kill-process and suspend-process commands from
respond\r\nconsole.\r\n\r\nDepends on
https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3"}}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
2023-05-02 02:37:03 -07:00
Kibana Machine
a675560774
[8.8] [Lens][TSVB] Add TSDB field checks functional tests (#156165) (#156333)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Lens][TSVB] Add TSDB field checks functional tests
(#156165)](https://github.com/elastic/kibana/pull/156165)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T07:58:07Z","message":"[Lens][TSVB]
Add TSDB field checks functional tests (#156165)\n\n##
Summary\r\n\r\nFix #155830 \r\n\r\nAdd basic checks for both Lens and
TSVB editors.\r\nIn Lens more advanced tests are performed to check for
compatible and\r\nuncompatible operations for specific TSDB field
types.\r\nIn TSVB the check is only performed to verify that the editor
and\r\nvisualization doesn't crash and when unsupported the right error
message\r\nis shown.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3c261237b07450ceee4877705bd8f843f0a51eca","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","release_note:skip","Feature:Lens","v8.8.0","v8.9.0"],"number":156165,"url":"https://github.com/elastic/kibana/pull/156165","mergeCommit":{"message":"[Lens][TSVB]
Add TSDB field checks functional tests (#156165)\n\n##
Summary\r\n\r\nFix #155830 \r\n\r\nAdd basic checks for both Lens and
TSVB editors.\r\nIn Lens more advanced tests are performed to check for
compatible and\r\nuncompatible operations for specific TSDB field
types.\r\nIn TSVB the check is only performed to verify that the editor
and\r\nvisualization doesn't crash and when unsupported the right error
message\r\nis shown.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3c261237b07450ceee4877705bd8f843f0a51eca"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156165","number":156165,"mergeCommit":{"message":"[Lens][TSVB]
Add TSDB field checks functional tests (#156165)\n\n##
Summary\r\n\r\nFix #155830 \r\n\r\nAdd basic checks for both Lens and
TSVB editors.\r\nIn Lens more advanced tests are performed to check for
compatible and\r\nuncompatible operations for specific TSDB field
types.\r\nIn TSVB the check is only performed to verify that the editor
and\r\nvisualization doesn't crash and when unsupported the right error
message\r\nis shown.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3c261237b07450ceee4877705bd8f843f0a51eca"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2023-05-02 01:57:23 -07:00
Kibana Machine
eaee327266
[8.8] [ML] Explain Log Rate Spikes: Fix key attribute for grouped analysis results table (#156038) (#156328)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Explain Log Rate Spikes: Fix `key` attribute for grouped
analysis results table
(#156038)](https://github.com/elastic/kibana/pull/156038)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T07:07:04Z","message":"[ML]
Explain Log Rate Spikes: Fix `key` attribute for grouped analysis
results table (#156038)\n\nFixes the React dev mode warning \"Warning:
Each child in a list should\r\nhave a unique \"key\" prop. Check the
render method of EuiBasicTable\" by\r\nputting the `key` attribute for a
group item on the outer
level.","sha":"a3f5a340ce71a714307bb831e125dffeff82f118","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","Feature:ML/AIOps","v8.8.0","v8.9.0"],"number":156038,"url":"https://github.com/elastic/kibana/pull/156038","mergeCommit":{"message":"[ML]
Explain Log Rate Spikes: Fix `key` attribute for grouped analysis
results table (#156038)\n\nFixes the React dev mode warning \"Warning:
Each child in a list should\r\nhave a unique \"key\" prop. Check the
render method of EuiBasicTable\" by\r\nputting the `key` attribute for a
group item on the outer
level.","sha":"a3f5a340ce71a714307bb831e125dffeff82f118"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156038","number":156038,"mergeCommit":{"message":"[ML]
Explain Log Rate Spikes: Fix `key` attribute for grouped analysis
results table (#156038)\n\nFixes the React dev mode warning \"Warning:
Each child in a list should\r\nhave a unique \"key\" prop. Check the
render method of EuiBasicTable\" by\r\nputting the `key` attribute for a
group item on the outer
level.","sha":"a3f5a340ce71a714307bb831e125dffeff82f118"}}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
2023-05-02 01:42:20 -07:00
Kibana Machine
b7c7f71078
[8.8] [Synthetics] Do not re-render embeddable visualizations on detail/history page onLoad (#156219) (#156327)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] Do not re-render embeddable visualizations on
detail/history page `onLoad`
(#156219)](https://github.com/elastic/kibana/pull/156219)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T06:50:02Z","message":"[Synthetics]
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156219,"url":"https://github.com/elastic/kibana/pull/156219","mergeCommit":{"message":"[Synthetics]
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156219","number":156219,"mergeCommit":{"message":"[Synthetics]
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
2023-05-02 01:02:38 -07:00
Kibana Machine
52c79188e3
[8.8] [Cases] Fix lens visualization in comment and description markdown (#155897) (#156189)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Fix lens visualization in comment and description markdown
(#155897)](https://github.com/elastic/kibana/pull/155897)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"117571355+js-jankisalvi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-28T15:21:00Z","message":"[Cases]
Fix lens visualization in comment and description markdown
(#155897)\n\n## Summary\r\n\r\nThis PR fixes issues with lens
visualization in case view page for\r\ncomment and
description.\r\n\r\nFixes:
#155631\r\n\r\n**Description:**\r\n\r\n\r\n234858215-feaac6c7-5579-4a00-bb97-00e0b23f5cfe.mov\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n**Flakey Test
runner:**\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2182\r\n\r\nNext
one after
update:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2183\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c0e02277f6c0d52dd4906e7421edcbd4c0dd962","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.7.0","v8.8.0","v8.9.0"],"number":155897,"url":"https://github.com/elastic/kibana/pull/155897","mergeCommit":{"message":"[Cases]
Fix lens visualization in comment and description markdown
(#155897)\n\n## Summary\r\n\r\nThis PR fixes issues with lens
visualization in case view page for\r\ncomment and
description.\r\n\r\nFixes:
#155631\r\n\r\n**Description:**\r\n\r\n\r\n234858215-feaac6c7-5579-4a00-bb97-00e0b23f5cfe.mov\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n**Flakey Test
runner:**\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2182\r\n\r\nNext
one after
update:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2183\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c0e02277f6c0d52dd4906e7421edcbd4c0dd962"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155897","number":155897,"mergeCommit":{"message":"[Cases]
Fix lens visualization in comment and description markdown
(#155897)\n\n## Summary\r\n\r\nThis PR fixes issues with lens
visualization in case view page for\r\ncomment and
description.\r\n\r\nFixes:
#155631\r\n\r\n**Description:**\r\n\r\n\r\n234858215-feaac6c7-5579-4a00-bb97-00e0b23f5cfe.mov\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n**Flakey Test
runner:**\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2182\r\n\r\nNext
one after
update:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2183\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0c0e02277f6c0d52dd4906e7421edcbd4c0dd962"}}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2023-05-01 18:13:54 -07:00
Kibana Machine
edd78ba55e
[8.8] [Security Solution] Advanced policy options for Endpoint 8.8 (#156308) (#156319)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Advanced policy options for Endpoint 8.8
(#156308)](https://github.com/elastic/kibana/pull/156308)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Logan","email":"56395104+kevinlog@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-01T22:44:35Z","message":"[Security
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":156308,"url":"https://github.com/elastic/kibana/pull/156308","mergeCommit":{"message":"[Security
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156308","number":156308,"mergeCommit":{"message":"[Security
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf"}}]}]
BACKPORT-->

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
2023-05-01 17:11:27 -07:00
Kibana Machine
390d50f0d2
[8.8] [Security solution] Fix network map time range (#156193) (#156317)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security solution] Fix network map time range
(#156193)](https://github.com/elastic/kibana/pull/156193)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T22:35:56Z","message":"[Security
solution] Fix network map time range
(#156193)","sha":"10bb8e9e6ac3b2543787a0d9450ec5e34d4f111a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:
SecuritySolution","Feature:Network","sdh-linked","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156193,"url":"https://github.com/elastic/kibana/pull/156193","mergeCommit":{"message":"[Security
solution] Fix network map time range
(#156193)","sha":"10bb8e9e6ac3b2543787a0d9450ec5e34d4f111a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156193","number":156193,"mergeCommit":{"message":"[Security
solution] Fix network map time range
(#156193)","sha":"10bb8e9e6ac3b2543787a0d9450ec5e34d4f111a"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2023-05-01 17:04:04 -07:00
Kibana Machine
105cb8fe17
[8.8] feat(slo): Add burn rate rule documentation link (#156283) (#156313)
# Backport

This will backport the following commits from `main` to `8.8`:
- [feat(slo): Add burn rate rule documentation link
(#156283)](https://github.com/elastic/kibana/pull/156283)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T22:13:14Z","message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156283,"url":"https://github.com/elastic/kibana/pull/156283","mergeCommit":{"message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156283","number":156283,"mergeCommit":{"message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79"}}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
2023-05-01 16:31:54 -07:00
Kibana Machine
064a1413d9
[8.8] [Security solution] Grouping count bug (#156206) (#156310)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security solution] Grouping count bug
(#156206)](https://github.com/elastic/kibana/pull/156206)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T21:58:23Z","message":"[Security
solution] Grouping count bug
(#156206)","sha":"7a0620f132fe34c03c5ffe70cc118d52b5ec4dbd","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Alerts
Grouping","v8.9.0"],"number":156206,"url":"https://github.com/elastic/kibana/pull/156206","mergeCommit":{"message":"[Security
solution] Grouping count bug
(#156206)","sha":"7a0620f132fe34c03c5ffe70cc118d52b5ec4dbd"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156206","number":156206,"mergeCommit":{"message":"[Security
solution] Grouping count bug
(#156206)","sha":"7a0620f132fe34c03c5ffe70cc118d52b5ec4dbd"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
2023-05-01 16:28:47 -07:00
Kibana Machine
775569b720
[8.8] [APM] Avoid re-mounting the entire application on every url change (#156171) (#156309)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[APM] Avoid re-mounting the entire application on every url change
(#156171)](https://github.com/elastic/kibana/pull/156171)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T21:46:17Z","message":"[APM]
Avoid re-mounting the entire application on every url change
(#156171)\n\n## Problem\r\nThe `ErrorBoundary` component that
encapsulates the APM application uses\r\nthe url path as the `key`,
causing the application to be unmounted and\r\nre-mounted on every page
change:\r\n\r\n```ts\r\n<ErrorBoundary
key={location.pathname}>{children}</ErrorBoundary>\r\n```\r\n\r\n##
Solution\r\n\r\nWhile applying a fix to the `ErrorBoundary` component I
noticed that it\r\nis no longer used. Errors are captured by
the\r\n`ObservabilityPageTemplate` (introduced a few weeks back
in\r\nhttps://github.com/elastic/kibana/pull/154716) which makes
our\r\nErrorBoundary useless.\r\n\r\nThe `ErrorBoundary` in
`ObservabilityPageTemplate` does not have the\r\nsame problem our had.
However, it also does not reset the ErrorBoundary\r\non page change
(like ours did). This means that once an error is caught,\r\nit is not
possible to remove the Error Boundary ui without manually\r\nperforming
a full page refresh. I've mentioned this to @CoenWarmer and\r\ncreated a
follow-up
issue:\r\nhttps://github.com/elastic/kibana/issues/156172\r\n\r\n##
Before\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135444-d691b481-5441-449b-8555-77760877c3ba.mp4\r\n\r\n##
After\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135459-cc3d4318-d553-44ad-890b-c15bdeac9292.mp4\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ab6b7464076126ee49c03a37f234280d8205a5","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.8.0","v8.9.0"],"number":156171,"url":"https://github.com/elastic/kibana/pull/156171","mergeCommit":{"message":"[APM]
Avoid re-mounting the entire application on every url change
(#156171)\n\n## Problem\r\nThe `ErrorBoundary` component that
encapsulates the APM application uses\r\nthe url path as the `key`,
causing the application to be unmounted and\r\nre-mounted on every page
change:\r\n\r\n```ts\r\n<ErrorBoundary
key={location.pathname}>{children}</ErrorBoundary>\r\n```\r\n\r\n##
Solution\r\n\r\nWhile applying a fix to the `ErrorBoundary` component I
noticed that it\r\nis no longer used. Errors are captured by
the\r\n`ObservabilityPageTemplate` (introduced a few weeks back
in\r\nhttps://github.com/elastic/kibana/pull/154716) which makes
our\r\nErrorBoundary useless.\r\n\r\nThe `ErrorBoundary` in
`ObservabilityPageTemplate` does not have the\r\nsame problem our had.
However, it also does not reset the ErrorBoundary\r\non page change
(like ours did). This means that once an error is caught,\r\nit is not
possible to remove the Error Boundary ui without manually\r\nperforming
a full page refresh. I've mentioned this to @CoenWarmer and\r\ncreated a
follow-up
issue:\r\nhttps://github.com/elastic/kibana/issues/156172\r\n\r\n##
Before\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135444-d691b481-5441-449b-8555-77760877c3ba.mp4\r\n\r\n##
After\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135459-cc3d4318-d553-44ad-890b-c15bdeac9292.mp4\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ab6b7464076126ee49c03a37f234280d8205a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156171","number":156171,"mergeCommit":{"message":"[APM]
Avoid re-mounting the entire application on every url change
(#156171)\n\n## Problem\r\nThe `ErrorBoundary` component that
encapsulates the APM application uses\r\nthe url path as the `key`,
causing the application to be unmounted and\r\nre-mounted on every page
change:\r\n\r\n```ts\r\n<ErrorBoundary
key={location.pathname}>{children}</ErrorBoundary>\r\n```\r\n\r\n##
Solution\r\n\r\nWhile applying a fix to the `ErrorBoundary` component I
noticed that it\r\nis no longer used. Errors are captured by
the\r\n`ObservabilityPageTemplate` (introduced a few weeks back
in\r\nhttps://github.com/elastic/kibana/pull/154716) which makes
our\r\nErrorBoundary useless.\r\n\r\nThe `ErrorBoundary` in
`ObservabilityPageTemplate` does not have the\r\nsame problem our had.
However, it also does not reset the ErrorBoundary\r\non page change
(like ours did). This means that once an error is caught,\r\nit is not
possible to remove the Error Boundary ui without manually\r\nperforming
a full page refresh. I've mentioned this to @CoenWarmer and\r\ncreated a
follow-up
issue:\r\nhttps://github.com/elastic/kibana/issues/156172\r\n\r\n##
Before\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135444-d691b481-5441-449b-8555-77760877c3ba.mp4\r\n\r\n##
After\r\n\r\nhttps://user-images.githubusercontent.com/209966/235135459-cc3d4318-d553-44ad-890b-c15bdeac9292.mp4\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ab6b7464076126ee49c03a37f234280d8205a5"}}]}]
BACKPORT-->

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
2023-05-01 16:25:21 -07:00
Kibana Machine
8d5b222f7b
[8.8] Fix error removing Environment value in APM rules (#156212) (#156300)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix error removing Environment value in APM rules
(#156212)](https://github.com/elastic/kibana/pull/156212)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-01T20:26:28Z","message":"Fix
error removing Environment value in APM rules (#156212)\n\nFixes
https://github.com/elastic/kibana/issues/153085\r\n\r\nFixes the error
shown when removing selected Environment value in the\r\nfollowing APM
rules:\r\n- Latency threshold\r\n- Error count threshold\r\n- Failed
transaction rate
threshold","sha":"61dad95501ad179a80ba54cf43cb02ec9e8cad72","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:APM","release_note:skip","Team:
Actionable
Observability","v8.8.0","v8.9.0"],"number":156212,"url":"https://github.com/elastic/kibana/pull/156212","mergeCommit":{"message":"Fix
error removing Environment value in APM rules (#156212)\n\nFixes
https://github.com/elastic/kibana/issues/153085\r\n\r\nFixes the error
shown when removing selected Environment value in the\r\nfollowing APM
rules:\r\n- Latency threshold\r\n- Error count threshold\r\n- Failed
transaction rate
threshold","sha":"61dad95501ad179a80ba54cf43cb02ec9e8cad72"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156212","number":156212,"mergeCommit":{"message":"Fix
error removing Environment value in APM rules (#156212)\n\nFixes
https://github.com/elastic/kibana/issues/153085\r\n\r\nFixes the error
shown when removing selected Environment value in the\r\nfollowing APM
rules:\r\n- Latency threshold\r\n- Error count threshold\r\n- Failed
transaction rate
threshold","sha":"61dad95501ad179a80ba54cf43cb02ec9e8cad72"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
2023-05-01 15:12:23 -07:00
Kevin Qualters
80ee6b3e70
[8.8] [Security Solution] [Timeline] Fix timeline draft collision with concurrent users (#155663) (#156298)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] [Timeline] Fix timeline draft collision with
concurrent users
(#155663)](https://github.com/elastic/kibana/pull/155663)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-01T20:08:03Z","message":"[Security
Solution] [Timeline] Fix timeline draft collision with concurrent users
(#155663)\n\n## Summary\r\n\r\nThis pr fixes an issue where two users
who both have draft timelines\r\nopen will actually be using the same
underlying saved object, which\r\nwould cause a host of issues. Adds
attributes.createdBy and\r\nattributes.updatedBy to the
savedObjectsClient.find filter used to\r\nretrieve drafts, so that each
user has their own draft. This should\r\nallow the reaping of unused
drafts to function as before.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a7936e192086f9697a73fd393679422fe59dcaa","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":155663,"url":"https://github.com/elastic/kibana/pull/155663","mergeCommit":{"message":"[Security
Solution] [Timeline] Fix timeline draft collision with concurrent users
(#155663)\n\n## Summary\r\n\r\nThis pr fixes an issue where two users
who both have draft timelines\r\nopen will actually be using the same
underlying saved object, which\r\nwould cause a host of issues. Adds
attributes.createdBy and\r\nattributes.updatedBy to the
savedObjectsClient.find filter used to\r\nretrieve drafts, so that each
user has their own draft. This should\r\nallow the reaping of unused
drafts to function as before.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a7936e192086f9697a73fd393679422fe59dcaa"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155663","number":155663,"mergeCommit":{"message":"[Security
Solution] [Timeline] Fix timeline draft collision with concurrent users
(#155663)\n\n## Summary\r\n\r\nThis pr fixes an issue where two users
who both have draft timelines\r\nopen will actually be using the same
underlying saved object, which\r\nwould cause a host of issues. Adds
attributes.createdBy and\r\nattributes.updatedBy to the
savedObjectsClient.find filter used to\r\nretrieve drafts, so that each
user has their own draft. This should\r\nallow the reaping of unused
drafts to function as before.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a7936e192086f9697a73fd393679422fe59dcaa"}}]}]
BACKPORT-->
2023-05-01 14:33:12 -07:00
Kibana Machine
5a93cdf4f5
[8.8] [Discover] Fix flaky Discover security functional test (#156221) (#156292)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Discover] Fix flaky Discover security functional test
(#156221)](https://github.com/elastic/kibana/pull/156221)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T18:23:30Z","message":"[Discover]
Fix flaky Discover security functional test (#156221)\n\n##
Summary\r\n\r\nFixes #153796.\r\n\r\nFlaky test runner x
100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2196\r\n\r\n###
Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5035be85060df015eaeb75ef9d5f8a43f6727498","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","v8.8.0","v8.9.0"],"number":156221,"url":"https://github.com/elastic/kibana/pull/156221","mergeCommit":{"message":"[Discover]
Fix flaky Discover security functional test (#156221)\n\n##
Summary\r\n\r\nFixes #153796.\r\n\r\nFlaky test runner x
100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2196\r\n\r\n###
Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5035be85060df015eaeb75ef9d5f8a43f6727498"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156221","number":156221,"mergeCommit":{"message":"[Discover]
Fix flaky Discover security functional test (#156221)\n\n##
Summary\r\n\r\nFixes #153796.\r\n\r\nFlaky test runner x
100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2196\r\n\r\n###
Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"5035be85060df015eaeb75ef9d5f8a43f6727498"}}]}]
BACKPORT-->

---------

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2023-05-01 13:06:31 -07:00
Kibana Machine
f2ada86485
[8.8] [Security Solution][Investigations] - remove flaky cypress test (#156258) (#156289)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Investigations] - remove flaky cypress test
(#156258)](https://github.com/elastic/kibana/pull/156258)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Olorunnisola","email":"michael.olorunnisola@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T17:54:04Z","message":"[Security
Solution][Investigations] - remove flaky cypress test (#156258)\n\nThis
PR removes a flaky test which fails when trying to visit a
url.\r\nFurther investigation is needed to determine why the test
sometimes\r\nvisits the login screen when trying to visit the given url,
but for the\r\ntime being should be removed to unblock future
PRs.","sha":"a8269ea7bd34dbf29fad591c58d6f318e8d73cde","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":156258,"url":"https://github.com/elastic/kibana/pull/156258","mergeCommit":{"message":"[Security
Solution][Investigations] - remove flaky cypress test (#156258)\n\nThis
PR removes a flaky test which fails when trying to visit a
url.\r\nFurther investigation is needed to determine why the test
sometimes\r\nvisits the login screen when trying to visit the given url,
but for the\r\ntime being should be removed to unblock future
PRs.","sha":"a8269ea7bd34dbf29fad591c58d6f318e8d73cde"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156258","number":156258,"mergeCommit":{"message":"[Security
Solution][Investigations] - remove flaky cypress test (#156258)\n\nThis
PR removes a flaky test which fails when trying to visit a
url.\r\nFurther investigation is needed to determine why the test
sometimes\r\nvisits the login screen when trying to visit the given url,
but for the\r\ntime being should be removed to unblock future
PRs.","sha":"a8269ea7bd34dbf29fad591c58d6f318e8d73cde"}}]}] BACKPORT-->

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
2023-05-01 12:54:32 -07:00
Kibana Machine
ccc95b57c0
[8.8] Upgrade EUI to v77.1.2 (#156232) (#156284)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Upgrade EUI to v77.1.2
(#156232)](https://github.com/elastic/kibana/pull/156232)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-01T17:05:11Z","message":"Upgrade
EUI to v77.1.2 (#156232)\n\n## Summary\r\n\r\n`eui@77.1.1` 
`eui@77.1.2`\r\n\r\nThis upgrade consists of a backport release intended
to fix a major bug\r\nwhere portals within `EuiFlyout`s and `EuiModal`s
are not scrollable.\r\nfixes
https://github.com/elastic/kibana/issues/156161\r\n\r\nThis release also
adds functionality that resolves the need for a TODO\r\nworkaround added
in https://github.com/elastic/kibana/pull/153227\r\n\r\n---\r\n\r\n##
[`77.1.2`](https://github.com/elastic/eui/tree/v77.1.2)\r\n\r\n- Updated
`EuiFocusTrap` to support the `gapMode` prop configuration\r\n(now
defaults to
`padding`)\r\n([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed the `scrollLock` property on `EuiFocusTrap` (and
other\r\ncomponents using `EuiFocusTrap`, such as `EuiFlyout` and
`EuiModal`) to\r\nno longer block scrolling on nested portalled content,
such as combobox\r\ndropdowns
([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0564e5434e56ca24c7cbb3fbf4a58d6242714e71","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","EUI","v8.8.0","v8.9.0"],"number":156232,"url":"https://github.com/elastic/kibana/pull/156232","mergeCommit":{"message":"Upgrade
EUI to v77.1.2 (#156232)\n\n## Summary\r\n\r\n`eui@77.1.1` 
`eui@77.1.2`\r\n\r\nThis upgrade consists of a backport release intended
to fix a major bug\r\nwhere portals within `EuiFlyout`s and `EuiModal`s
are not scrollable.\r\nfixes
https://github.com/elastic/kibana/issues/156161\r\n\r\nThis release also
adds functionality that resolves the need for a TODO\r\nworkaround added
in https://github.com/elastic/kibana/pull/153227\r\n\r\n---\r\n\r\n##
[`77.1.2`](https://github.com/elastic/eui/tree/v77.1.2)\r\n\r\n- Updated
`EuiFocusTrap` to support the `gapMode` prop configuration\r\n(now
defaults to
`padding`)\r\n([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed the `scrollLock` property on `EuiFocusTrap` (and
other\r\ncomponents using `EuiFocusTrap`, such as `EuiFlyout` and
`EuiModal`) to\r\nno longer block scrolling on nested portalled content,
such as combobox\r\ndropdowns
([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0564e5434e56ca24c7cbb3fbf4a58d6242714e71"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156232","number":156232,"mergeCommit":{"message":"Upgrade
EUI to v77.1.2 (#156232)\n\n## Summary\r\n\r\n`eui@77.1.1` 
`eui@77.1.2`\r\n\r\nThis upgrade consists of a backport release intended
to fix a major bug\r\nwhere portals within `EuiFlyout`s and `EuiModal`s
are not scrollable.\r\nfixes
https://github.com/elastic/kibana/issues/156161\r\n\r\nThis release also
adds functionality that resolves the need for a TODO\r\nworkaround added
in https://github.com/elastic/kibana/pull/153227\r\n\r\n---\r\n\r\n##
[`77.1.2`](https://github.com/elastic/eui/tree/v77.1.2)\r\n\r\n- Updated
`EuiFocusTrap` to support the `gapMode` prop configuration\r\n(now
defaults to
`padding`)\r\n([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed the `scrollLock` property on `EuiFocusTrap` (and
other\r\ncomponents using `EuiFocusTrap`, such as `EuiFlyout` and
`EuiModal`) to\r\nno longer block scrolling on nested portalled content,
such as combobox\r\ndropdowns
([#6744](https://github.com/elastic/eui/pull/6744))\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0564e5434e56ca24c7cbb3fbf4a58d6242714e71"}}]}]
BACKPORT-->

Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
2023-05-01 12:37:07 -07:00
Sander Philipse
8af3ab8e35
[8.8] [Enterprise Search] Fix minor text issues in create index (#155892) (#156264)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Fix minor text issues in create index
(#155892)](https://github.com/elastic/kibana/pull/155892)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-26T19:09:08Z","message":"[Enterprise
Search] Fix minor text issues in create index (#155892)\n\n##
Summary\r\n\r\nThis fixes some minor issues and adds a few enhancements
in the create\r\nsearch index
flow.","sha":"a5b51f82c66e33f2c39e5a04ae3e592aad67fff8","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","auto-backport","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":155892,"url":"https://github.com/elastic/kibana/pull/155892","mergeCommit":{"message":"[Enterprise
Search] Fix minor text issues in create index (#155892)\n\n##
Summary\r\n\r\nThis fixes some minor issues and adds a few enhancements
in the create\r\nsearch index
flow.","sha":"a5b51f82c66e33f2c39e5a04ae3e592aad67fff8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155892","number":155892,"mergeCommit":{"message":"[Enterprise
Search] Fix minor text issues in create index (#155892)\n\n##
Summary\r\n\r\nThis fixes some minor issues and adds a few enhancements
in the create\r\nsearch index
flow.","sha":"a5b51f82c66e33f2c39e5a04ae3e592aad67fff8"}},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-05-01 11:26:57 -07:00
Kibana Machine
ab48fa7586
[8.8] [Enterprise Search] Support for starting ELSER model deployment (#156080) (#156266)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Support for starting ELSER model deployment
(#156080)](https://github.com/elastic/kibana/pull/156080)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Adam
Demjen","email":"demjened@gmail.com"},"sourceCommit":{"committedDate":"2023-05-01T14:56:18Z","message":"[Enterprise
Search] Support for starting ELSER model deployment (#156080)\n\n##
Summary\r\n\r\nWe're adding action buttons to the ELSER model deployment
panel,\r\nspecifically to the state where the trained model has been
downloaded\r\nbut not started yet. The user has two options here:\r\n-
Start the model (synchronously) with a basic configuration using
the\r\n\"Start single-threaded\" button\r\n- Navigate to the Trained
Models page and fine-tune the model deployment\r\nwith the \"Fine-tune
performance\" button\r\n\r\nIn addition a 4th state of the panel is
being introduced: the ELSER\r\nmodel has
started.\r\n\r\n\r\n![ELSER_start](https://user-images.githubusercontent.com/14224983/234971172-a99917dd-ec55-4df3-acd1-a6b390262104.gif)\r\n\r\n\r\n###
Checklist\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"589770885e87c3209a48a1b5d2b4e30576dc8c2e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156080,"url":"https://github.com/elastic/kibana/pull/156080","mergeCommit":{"message":"[Enterprise
Search] Support for starting ELSER model deployment (#156080)\n\n##
Summary\r\n\r\nWe're adding action buttons to the ELSER model deployment
panel,\r\nspecifically to the state where the trained model has been
downloaded\r\nbut not started yet. The user has two options here:\r\n-
Start the model (synchronously) with a basic configuration using
the\r\n\"Start single-threaded\" button\r\n- Navigate to the Trained
Models page and fine-tune the model deployment\r\nwith the \"Fine-tune
performance\" button\r\n\r\nIn addition a 4th state of the panel is
being introduced: the ELSER\r\nmodel has
started.\r\n\r\n\r\n![ELSER_start](https://user-images.githubusercontent.com/14224983/234971172-a99917dd-ec55-4df3-acd1-a6b390262104.gif)\r\n\r\n\r\n###
Checklist\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"589770885e87c3209a48a1b5d2b4e30576dc8c2e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156080","number":156080,"mergeCommit":{"message":"[Enterprise
Search] Support for starting ELSER model deployment (#156080)\n\n##
Summary\r\n\r\nWe're adding action buttons to the ELSER model deployment
panel,\r\nspecifically to the state where the trained model has been
downloaded\r\nbut not started yet. The user has two options here:\r\n-
Start the model (synchronously) with a basic configuration using
the\r\n\"Start single-threaded\" button\r\n- Navigate to the Trained
Models page and fine-tune the model deployment\r\nwith the \"Fine-tune
performance\" button\r\n\r\nIn addition a 4th state of the panel is
being introduced: the ELSER\r\nmodel has
started.\r\n\r\n\r\n![ELSER_start](https://user-images.githubusercontent.com/14224983/234971172-a99917dd-ec55-4df3-acd1-a6b390262104.gif)\r\n\r\n\r\n###
Checklist\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"589770885e87c3209a48a1b5d2b4e30576dc8c2e"}}]}]
BACKPORT-->

Co-authored-by: Adam Demjen <demjened@gmail.com>
2023-05-01 09:03:33 -07:00
Sander Philipse
5ff76d3ef6
[8.8] [Enterprise Search] Add XPath selector as option to extraction rules (#155877) (#156265)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Add XPath selector as option to extraction rules
(#155877)](https://github.com/elastic/kibana/pull/155877)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-26T19:15:08Z","message":"[Enterprise
Search] Add XPath selector as option to extraction rules (#155877)\n\n##
Summary\r\n\r\nThis adds some text to clarify that you can use XPath
expressions for\r\nextraction rules.\r\n\r\n<img width=\"1459\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/234588960-5127f1b1-9c97-4aa8-a2f7-6066a7fb9d67.png\">","sha":"0a119b63bdbae6b5996f9a981df8dea103fa6319","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:EnterpriseSearch","v8.8.0"],"number":155877,"url":"https://github.com/elastic/kibana/pull/155877","mergeCommit":{"message":"[Enterprise
Search] Add XPath selector as option to extraction rules (#155877)\n\n##
Summary\r\n\r\nThis adds some text to clarify that you can use XPath
expressions for\r\nextraction rules.\r\n\r\n<img width=\"1459\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/234588960-5127f1b1-9c97-4aa8-a2f7-6066a7fb9d67.png\">","sha":"0a119b63bdbae6b5996f9a981df8dea103fa6319"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155877","number":155877,"mergeCommit":{"message":"[Enterprise
Search] Add XPath selector as option to extraction rules (#155877)\n\n##
Summary\r\n\r\nThis adds some text to clarify that you can use XPath
expressions for\r\nextraction rules.\r\n\r\n<img width=\"1459\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/234588960-5127f1b1-9c97-4aa8-a2f7-6066a7fb9d67.png\">","sha":"0a119b63bdbae6b5996f9a981df8dea103fa6319"}}]}]
BACKPORT-->
2023-05-01 08:55:22 -07:00
Kibana Machine
ea6473e685
[8.8] [Discover] [Unified Histogram] Fix reset search button not fully resetting Unified Histogram state (#155967) (#156239)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Discover] [Unified Histogram] Fix reset search button not fully
resetting Unified Histogram state
(#155967)](https://github.com/elastic/kibana/pull/155967)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-04-30T22:50:58Z","message":"[Discover]
[Unified Histogram] Fix reset search button not fully resetting Unified
Histogram state (#155967)\n\n## Summary\r\n\r\nThis PR fixes an issue
where resetting a saved search would not fully\r\nreset the Unified
Histogram state. The issue was caused by multiple\r\nstate values
changing in quick succession which resulted in some state\r\ngetting
overwritten, so I've updated `use_discover_state` to batch
state\r\nupdates and improve diffing when state changes.\r\n\r\nFixes
#151395.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9d023f6a42059d272dcc422cc9296e21d68a0a1f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","Feature:UnifiedHistogram","v8.8.0","v8.9.0"],"number":155967,"url":"https://github.com/elastic/kibana/pull/155967","mergeCommit":{"message":"[Discover]
[Unified Histogram] Fix reset search button not fully resetting Unified
Histogram state (#155967)\n\n## Summary\r\n\r\nThis PR fixes an issue
where resetting a saved search would not fully\r\nreset the Unified
Histogram state. The issue was caused by multiple\r\nstate values
changing in quick succession which resulted in some state\r\ngetting
overwritten, so I've updated `use_discover_state` to batch
state\r\nupdates and improve diffing when state changes.\r\n\r\nFixes
#151395.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9d023f6a42059d272dcc422cc9296e21d68a0a1f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155967","number":155967,"mergeCommit":{"message":"[Discover]
[Unified Histogram] Fix reset search button not fully resetting Unified
Histogram state (#155967)\n\n## Summary\r\n\r\nThis PR fixes an issue
where resetting a saved search would not fully\r\nreset the Unified
Histogram state. The issue was caused by multiple\r\nstate values
changing in quick succession which resulted in some state\r\ngetting
overwritten, so I've updated `use_discover_state` to batch
state\r\nupdates and improve diffing when state changes.\r\n\r\nFixes
#151395.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[ ] ~This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9d023f6a42059d272dcc422cc9296e21d68a0a1f"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2023-04-30 17:06:24 -07:00
Kibana Machine
d0327fc757
[8.8] [drift] Changed default trial offset from 60 to 90 days per PM request. (#156186) (#156229)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[drift] Changed default trial offset from 60 to 90 days per PM
request. (#156186)](https://github.com/elastic/kibana/pull/156186)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Petr
Klapka","email":"79424117+petrklapka@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-29T00:07:19Z","message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","loe:hours","release_note:skip","impact:medium","Team:SharedUX","Team:Journey/Onboarding","v8.8.0","Feature:Chat","v8.9.0"],"number":156186,"url":"https://github.com/elastic/kibana/pull/156186","mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156186","number":156186,"mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}}]}]
BACKPORT-->

Co-authored-by: Petr Klapka <79424117+petrklapka@users.noreply.github.com>
2023-04-28 19:39:34 -07:00
Kibana Machine
58d212c559
[8.8] [drift] Changed default trial offset from 60 to 90 days per PM request. (#156186) (#156230)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[drift] Changed default trial offset from 60 to 90 days per PM
request. (#156186)](https://github.com/elastic/kibana/pull/156186)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Petr
Klapka","email":"79424117+petrklapka@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-29T00:07:19Z","message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","loe:hours","release_note:skip","impact:medium","auto-backport","Team:SharedUX","Team:Journey/Onboarding","v8.8.0","Feature:Chat","v8.9.0"],"number":156186,"url":"https://github.com/elastic/kibana/pull/156186","mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156186","number":156186,"mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}}]}]
BACKPORT-->

Co-authored-by: Petr Klapka <79424117+petrklapka@users.noreply.github.com>
2023-04-28 18:22:49 -07:00
Kibana Machine
d25736caac
[8.8] [Cases] Fix attachment's renderer memoization (#156179) (#156201)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Fix attachment's renderer memoization
(#156179)](https://github.com/elastic/kibana/pull/156179)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christos
Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2023-04-28T16:14:41Z","message":"[Cases]
Fix attachment's renderer memoization (#156179)\n\n## Summary\r\n\r\nPR
https://github.com/elastic/kibana/pull/154436 changed the
memoization\r\nfunction (my fault 🙂) and that caused the attachments to
rerender each\r\ntime a user does an action in cases. This PR fixes this
issue.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n235171429-5e06f9c4-9c0a-4148-8580-bde2360169af.mov\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"60e3d98ba837d31130bf104681381ebe5a2df5c2","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.8.0","v8.9.0"],"number":156179,"url":"https://github.com/elastic/kibana/pull/156179","mergeCommit":{"message":"[Cases]
Fix attachment's renderer memoization (#156179)\n\n## Summary\r\n\r\nPR
https://github.com/elastic/kibana/pull/154436 changed the
memoization\r\nfunction (my fault 🙂) and that caused the attachments to
rerender each\r\ntime a user does an action in cases. This PR fixes this
issue.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n235171429-5e06f9c4-9c0a-4148-8580-bde2360169af.mov\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"60e3d98ba837d31130bf104681381ebe5a2df5c2"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156179","number":156179,"mergeCommit":{"message":"[Cases]
Fix attachment's renderer memoization (#156179)\n\n## Summary\r\n\r\nPR
https://github.com/elastic/kibana/pull/154436 changed the
memoization\r\nfunction (my fault 🙂) and that caused the attachments to
rerender each\r\ntime a user does an action in cases. This PR fixes this
issue.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n235171429-5e06f9c4-9c0a-4148-8580-bde2360169af.mov\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"60e3d98ba837d31130bf104681381ebe5a2df5c2"}}]}]
BACKPORT-->

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2023-04-28 10:29:42 -07:00
Kibana Machine
a5b007191f
[8.8] Minor copy edit in Create Search Application Flyout (#156116) (#156200)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Minor copy edit in Create Search Application Flyout
(#156116)](https://github.com/elastic/kibana/pull/156116)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kathleen
DeRusso","email":"kathleen.derusso@elastic.co"},"sourceCommit":{"committedDate":"2023-04-28T16:03:40Z","message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.8.0","v8.9.0"],"number":156116,"url":"https://github.com/elastic/kibana/pull/156116","mergeCommit":{"message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156116","number":156116,"mergeCommit":{"message":"Minor
copy edit in Create Search Application Flyout (#156116)\n\n##
Summary\r\n\r\nA minor copy edit to the Create Search Application
flyout, as
requested\r\n[here](https://github.com/elastic/kibana/pull/155649/files#r1177950465).\r\n\r\nPer
the thread in the request, the popover is changed but the
callout\r\nremains the same.\r\n<img width=\"457\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235157710-6463ca4c-fa92-4d1a-af22-9e2a507f3176.png\">\r\n<img
width=\"631\" alt=\"Screenshot 2023-04-28 at 8 53 55
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/63422879/235153128-e49933a8-91a5-4365-bbd5-f0a1d4b52579.png\">","sha":"53e7cd943ec78aa2e620d1b3933a75359f49c47f"}}]}]
BACKPORT-->

Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co>
2023-04-28 10:13:33 -07:00
Hannah Mudge
1d581aad6a
[8.8] [Controls] Fix sorting of numeric keyword fields (#155207) (#156197)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Controls] Fix sorting of numeric keyword fields
(#155207)](https://github.com/elastic/kibana/pull/155207)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-26T18:19:46Z","message":"[Controls]
Fix sorting of numeric keyword fields (#155207)\n\nCloses
https://github.com/elastic/kibana/issues/155073\r\n\r\n##
Summary\r\n\r\n### Before\r\n\r\nPreviously, the options list
suggestions were stored as a dictionary\r\n(i.e. an object of key+value
pairs) - while this worked for most fields,\r\nunbeknownst to us,
Javascript tries to sort numeric keys (regardless of\r\nif they are of
type `string` or `number`) based on their value.\r\n\r\nThis meant that,
as part of the parsing process when using an options\r\nlist control for
a numeric `keyword` field, the results returned by the\r\nES query were
**always** sorted in ascending numeric order regardless of\r\nthe
sorting method that was picked (note that this is especially
obvious\r\nonce you \"load more\", which is what I did for the
following\r\nscreenshots):\r\n\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391308-6d3a23ee-3495-4eff-810f-216f758b3a58.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391375-0ccdf72f-83c0-4a87-951e-c2e1e3223006.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\"/>\r\n|\r\n\r\n\r\n###
After\r\n\r\nThis PR converts the options list suggestions to be stored
as an\r\n**array** of key/value pairs in order to preserve the order
returned\r\nfrom Elasticsearch - now, you get the expected string-sorted
ordering\r\nwhen using numeric `keyword` fields in an options list
control:\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394182-aa2bfdf4-fe41-441d-bdbf-917173c17627.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394599-dda01056-5446-497e-abe4-f3839aeb4dd0.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\"/>\r\n|\r\n\r\n\r\nNotice
in the above that we are now using **string sorting** for the\r\nnumeric
values when alphabetical sorting is selected, which means you\r\naren't
getting the expected \"numeric\" sorting - so for example,
when\r\nsorted ascending, `\"6\" > \"52\"` because it is only comparing
the first\r\ncharacter and `\"6\" > \"5\"`. This will be handled much
better once\r\n[numeric field
support](https://github.com/elastic/kibana/issues/126795)\r\nis added to
options lists.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Input
Control","Team:Presentation","loe:days","impact:medium","backport:prev-minor","v8.8.0","v8.7.1","v8.9.0"],"number":155207,"url":"https://github.com/elastic/kibana/pull/155207","mergeCommit":{"message":"[Controls]
Fix sorting of numeric keyword fields (#155207)\n\nCloses
https://github.com/elastic/kibana/issues/155073\r\n\r\n##
Summary\r\n\r\n### Before\r\n\r\nPreviously, the options list
suggestions were stored as a dictionary\r\n(i.e. an object of key+value
pairs) - while this worked for most fields,\r\nunbeknownst to us,
Javascript tries to sort numeric keys (regardless of\r\nif they are of
type `string` or `number`) based on their value.\r\n\r\nThis meant that,
as part of the parsing process when using an options\r\nlist control for
a numeric `keyword` field, the results returned by the\r\nES query were
**always** sorted in ascending numeric order regardless of\r\nthe
sorting method that was picked (note that this is especially
obvious\r\nonce you \"load more\", which is what I did for the
following\r\nscreenshots):\r\n\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391308-6d3a23ee-3495-4eff-810f-216f758b3a58.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391375-0ccdf72f-83c0-4a87-951e-c2e1e3223006.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\"/>\r\n|\r\n\r\n\r\n###
After\r\n\r\nThis PR converts the options list suggestions to be stored
as an\r\n**array** of key/value pairs in order to preserve the order
returned\r\nfrom Elasticsearch - now, you get the expected string-sorted
ordering\r\nwhen using numeric `keyword` fields in an options list
control:\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394182-aa2bfdf4-fe41-441d-bdbf-917173c17627.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394599-dda01056-5446-497e-abe4-f3839aeb4dd0.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\"/>\r\n|\r\n\r\n\r\nNotice
in the above that we are now using **string sorting** for the\r\nnumeric
values when alphabetical sorting is selected, which means you\r\naren't
getting the expected \"numeric\" sorting - so for example,
when\r\nsorted ascending, `\"6\" > \"52\"` because it is only comparing
the first\r\ncharacter and `\"6\" > \"5\"`. This will be handled much
better once\r\n[numeric field
support](https://github.com/elastic/kibana/issues/126795)\r\nis added to
options lists.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155207","number":155207,"mergeCommit":{"message":"[Controls]
Fix sorting of numeric keyword fields (#155207)\n\nCloses
https://github.com/elastic/kibana/issues/155073\r\n\r\n##
Summary\r\n\r\n### Before\r\n\r\nPreviously, the options list
suggestions were stored as a dictionary\r\n(i.e. an object of key+value
pairs) - while this worked for most fields,\r\nunbeknownst to us,
Javascript tries to sort numeric keys (regardless of\r\nif they are of
type `string` or `number`) based on their value.\r\n\r\nThis meant that,
as part of the parsing process when using an options\r\nlist control for
a numeric `keyword` field, the results returned by the\r\nES query were
**always** sorted in ascending numeric order regardless of\r\nthe
sorting method that was picked (note that this is especially
obvious\r\nonce you \"load more\", which is what I did for the
following\r\nscreenshots):\r\n\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391308-6d3a23ee-3495-4eff-810f-216f758b3a58.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234391375-0ccdf72f-83c0-4a87-951e-c2e1e3223006.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\"/>\r\n|\r\n\r\n\r\n###
After\r\n\r\nThis PR converts the options list suggestions to be stored
as an\r\n**array** of key/value pairs in order to preserve the order
returned\r\nfrom Elasticsearch - now, you get the expected string-sorted
ordering\r\nwhen using numeric `keyword` fields in an options list
control:\r\n\r\n| | Ascending | Descending
|\r\n|--------------|-----------|------------|\r\n| Alphabetical | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394182-aa2bfdf4-fe41-441d-bdbf-917173c17627.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\"/>\r\n|\r\n|
Doc count | <img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394599-dda01056-5446-497e-abe4-f3839aeb4dd0.png\"/>\r\n|
<img
width=\"320px\"\r\nsrc=\"https://user-images.githubusercontent.com/8698078/234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\"/>\r\n|\r\n\r\n\r\nNotice
in the above that we are now using **string sorting** for the\r\nnumeric
values when alphabetical sorting is selected, which means you\r\naren't
getting the expected \"numeric\" sorting - so for example,
when\r\nsorted ascending, `\"6\" > \"52\"` because it is only comparing
the first\r\ncharacter and `\"6\" > \"5\"`. This will be handled much
better once\r\n[numeric field
support](https://github.com/elastic/kibana/issues/126795)\r\nis added to
options lists.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/155934","number":155934,"state":"MERGED","mergeCommit":{"sha":"167c3285d8a94bfce14a7e5e0d89825e38ccef3a","message":"[8.7]
[Controls] Fix sorting of numeric keyword fields (#155207)
(#155934)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.7`:\n- [[Controls] Fix sorting of numeric keyword
fields\n(#155207)](https://github.com/elastic/kibana/pull/155207)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Hannah\nMudge\",\"email\":\"Heenawter@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2023-04-26T18:19:46Z\",\"message\":\"[Controls]\nFix
sorting of numeric keyword fields
(#155207)\\n\\nCloses\nhttps://github.com/elastic/kibana/issues/155073\\r\\n\\r\\n##\nSummary\\r\\n\\r\\n###
Before\\r\\n\\r\\nPreviously, the options list\nsuggestions were stored
as a dictionary\\r\\n(i.e. an object of key+value\npairs) - while this
worked for most fields,\\r\\nunbeknownst to us,\nJavascript tries to
sort numeric keys (regardless of\\r\\nif they are of\ntype `string` or
`number`) based on their value.\\r\\n\\r\\nThis meant that,\nas part of
the parsing process when using an options\\r\\nlist control for\na
numeric `keyword` field, the results returned by the\\r\\nES query
were\n**always** sorted in ascending numeric order regardless
of\\r\\nthe\nsorting method that was picked (note that this is
especially\nobvious\\r\\nonce you \\\"load more\\\", which is what I did
for the\nfollowing\\r\\nscreenshots):\\r\\n\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nThis
PR converts the options list suggestions to be stored\nas
an\\r\\n**array** of key/value pairs in order to preserve the
order\nreturned\\r\\nfrom Elasticsearch - now, you get the expected
string-sorted\nordering\\r\\nwhen using numeric `keyword` fields in an
options list\ncontrol:\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\nNotice\nin
the above that we are now using **string sorting** for
the\\r\\nnumeric\nvalues when alphabetical sorting is selected, which
means you\\r\\naren't\ngetting the expected \\\"numeric\\\" sorting - so
for example,\nwhen\\r\\nsorted ascending, `\\\"6\\\" > \\\"52\\\"`
because it is only comparing\nthe first\\r\\ncharacter and `\\\"6\\\" >
\\\"5\\\"`. This will be handled much\nbetter once\\r\\n[numeric
field\nsupport](https://github.com/elastic/kibana/issues/126795)\\r\\nis
added to\noptions lists.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [x] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [x] This was\nchecked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n\\r\\n###\nFor
maintainers\\r\\n\\r\\n- [ ] This was checked for breaking API
changes\nand
was\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\",\"sha\":\"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138\",\"branchLabelMapping\":{\"^v8.8.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"Feature:Input\nControl\",\"Team:Presentation\",\"loe:days\",\"impact:medium\",\"backport:prev-minor\",\"v8.8.0\",\"v8.9.0\"],\"number\":155207,\"url\":\"https://github.com/elastic/kibana/pull/155207\",\"mergeCommit\":{\"message\":\"[Controls]\nFix
sorting of numeric keyword fields
(#155207)\\n\\nCloses\nhttps://github.com/elastic/kibana/issues/155073\\r\\n\\r\\n##\nSummary\\r\\n\\r\\n###
Before\\r\\n\\r\\nPreviously, the options list\nsuggestions were stored
as a dictionary\\r\\n(i.e. an object of key+value\npairs) - while this
worked for most fields,\\r\\nunbeknownst to us,\nJavascript tries to
sort numeric keys (regardless of\\r\\nif they are of\ntype `string` or
`number`) based on their value.\\r\\n\\r\\nThis meant that,\nas part of
the parsing process when using an options\\r\\nlist control for\na
numeric `keyword` field, the results returned by the\\r\\nES query
were\n**always** sorted in ascending numeric order regardless
of\\r\\nthe\nsorting method that was picked (note that this is
especially\nobvious\\r\\nonce you \\\"load more\\\", which is what I did
for the\nfollowing\\r\\nscreenshots):\\r\\n\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nThis
PR converts the options list suggestions to be stored\nas
an\\r\\n**array** of key/value pairs in order to preserve the
order\nreturned\\r\\nfrom Elasticsearch - now, you get the expected
string-sorted\nordering\\r\\nwhen using numeric `keyword` fields in an
options list\ncontrol:\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\nNotice\nin
the above that we are now using **string sorting** for
the\\r\\nnumeric\nvalues when alphabetical sorting is selected, which
means you\\r\\naren't\ngetting the expected \\\"numeric\\\" sorting - so
for example,\nwhen\\r\\nsorted ascending, `\\\"6\\\" > \\\"52\\\"`
because it is only comparing\nthe first\\r\\ncharacter and `\\\"6\\\" >
\\\"5\\\"`. This will be handled much\nbetter once\\r\\n[numeric
field\nsupport](https://github.com/elastic/kibana/issues/126795)\\r\\nis
added to\noptions lists.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [x] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [x] This was\nchecked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n\\r\\n###\nFor
maintainers\\r\\n\\r\\n- [ ] This was checked for breaking API
changes\nand
was\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\",\"sha\":\"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.9\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.8.0\",\"labelRegex\":\"^v8.8.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/155207\",\"number\":155207,\"mergeCommit\":{\"message\":\"[Controls]\nFix
sorting of numeric keyword fields
(#155207)\\n\\nCloses\nhttps://github.com/elastic/kibana/issues/155073\\r\\n\\r\\n##\nSummary\\r\\n\\r\\n###
Before\\r\\n\\r\\nPreviously, the options list\nsuggestions were stored
as a dictionary\\r\\n(i.e. an object of key+value\npairs) - while this
worked for most fields,\\r\\nunbeknownst to us,\nJavascript tries to
sort numeric keys (regardless of\\r\\nif they are of\ntype `string` or
`number`) based on their value.\\r\\n\\r\\nThis meant that,\nas part of
the parsing process when using an options\\r\\nlist control for\na
numeric `keyword` field, the results returned by the\\r\\nES query
were\n**always** sorted in ascending numeric order regardless
of\\r\\nthe\nsorting method that was picked (note that this is
especially\nobvious\\r\\nonce you \\\"load more\\\", which is what I did
for the\nfollowing\\r\\nscreenshots):\\r\\n\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234391213-117163e2-ee97-4f9d-87fa-a63c8cc5459e.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234392997-fea42ffe-5d9d-4a11-968f-e1503f2c0e4f.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nThis
PR converts the options list suggestions to be stored\nas
an\\r\\n**array** of key/value pairs in order to preserve the
order\nreturned\\r\\nfrom Elasticsearch - now, you get the expected
string-sorted\nordering\\r\\nwhen using numeric `keyword` fields in an
options list\ncontrol:\\r\\n\\r\\n| | Ascending |
Descending\n|\\r\\n|--------------|-----------|------------|\\r\\n|
Alphabetical |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234393421-24cca3e3-0249-4607-9e16-daa274399bdd.png\\\"/>\\r\\n|\\r\\n|\nDoc
count |
<img\nwidth=\\\"320px\\\"\\r\\nsrc=\\\"234394693-42544ef1-eb2b-4d52-8a78-c2ca7d2d7cfa.png\\\"/>\\r\\n|\\r\\n\\r\\n\\r\\nNotice\nin
the above that we are now using **string sorting** for
the\\r\\nnumeric\nvalues when alphabetical sorting is selected, which
means you\\r\\naren't\ngetting the expected \\\"numeric\\\" sorting - so
for example,\nwhen\\r\\nsorted ascending, `\\\"6\\\" > \\\"52\\\"`
because it is only comparing\nthe first\\r\\ncharacter and `\\\"6\\\" >
\\\"5\\\"`. This will be handled much\nbetter once\\r\\n[numeric
field\nsupport](https://github.com/elastic/kibana/issues/126795)\\r\\nis
added to\noptions lists.\\r\\n\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [x] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [x] This was\nchecked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n\\r\\n###\nFor
maintainers\\r\\n\\r\\n- [ ] This was checked for breaking API
changes\nand
was\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\",\"sha\":\"b3f65f79e5017b70fe26e5aa1c2ee1085e68c138\"}},{\"branch\":\"8.9\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->"}},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
2023-04-28 10:01:25 -07:00
Lisa Cawley
971a1449b5
[8.8] [ML] Edit insufficient license message (#155963) (#156194)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Edit insufficient license message
(#155963)](https://github.com/elastic/kibana/pull/155963)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-04-28T15:39:07Z","message":"[ML]
Edit insufficient license message
(#155963)","sha":"af1825369eb152a80d50f65a3235e6d0399d6c57","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport:skip","ui-copy","v8.9.0"],"number":155963,"url":"https://github.com/elastic/kibana/pull/155963","mergeCommit":{"message":"[ML]
Edit insufficient license message
(#155963)","sha":"af1825369eb152a80d50f65a3235e6d0399d6c57"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155963","number":155963,"mergeCommit":{"message":"[ML]
Edit insufficient license message
(#155963)","sha":"af1825369eb152a80d50f65a3235e6d0399d6c57"}}]}]
BACKPORT-->
2023-04-28 09:51:36 -07:00
Kibana Machine
dc43b87a3e
[8.8] [Fleet] [Message Signing] Respond with a generic error when rotate key pair fails (#156144) (#156188)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] [Message Signing] Respond with a generic error when rotate
key pair fails (#156144)](https://github.com/elastic/kibana/pull/156144)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ashokaditya","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-28T15:17:06Z","message":"[Fleet]
[Message Signing] Respond with a generic error when rotate key pair
fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error
message for the rotate key pair API,\r\ninstead of a trace message of
where the error was generated.\r\n\r\nWe log the detailed errors and
this is to avoid a chance of any\r\nsensitive data (key generation
details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of
elastic/kibana/pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend
Workflows","OLM
Sprint","v8.8.0","v8.9.0"],"number":156144,"url":"https://github.com/elastic/kibana/pull/156144","mergeCommit":{"message":"[Fleet]
[Message Signing] Respond with a generic error when rotate key pair
fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error
message for the rotate key pair API,\r\ninstead of a trace message of
where the error was generated.\r\n\r\nWe log the detailed errors and
this is to avoid a chance of any\r\nsensitive data (key generation
details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of
elastic/kibana/pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156144","number":156144,"mergeCommit":{"message":"[Fleet]
[Message Signing] Respond with a generic error when rotate key pair
fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error
message for the rotate key pair API,\r\ninstead of a trace message of
where the error was generated.\r\n\r\nWe log the detailed errors and
this is to avoid a chance of any\r\nsensitive data (key generation
details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of
elastic/kibana/pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040"}}]}]
BACKPORT-->

Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
2023-04-28 09:27:48 -07:00
Kibana Machine
e2c108cd03
[8.8] [Dashboard] Fix flaky Dashboard create tests (#156085) (#156180)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix flaky Dashboard create tests
(#156085)](https://github.com/elastic/kibana/pull/156085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-28T14:14:12Z","message":"[Dashboard]
Fix flaky Dashboard create tests (#156085)\n\nCloses
https://github.com/elastic/kibana/issues/155777\r\n\r\n##
Summary\r\n\r\nThe `\"replaces panel with incoming embeddable if id
matches existing\r\npanel\"` test was **not** the flaky one, even though
it was the one that\r\nshowed the failure; it was actually one of the
previous `\"pulls state\r\n<...>\"` tests that was failing, which was
pretty confusing to catch 🤦\r\n\r\nBasically, because we are [running
the unsaved changes check on
load\r\nnow](https://github.com/elastic/kibana/pull/155648), depending
on the\r\ntiming of the `debounce` on the
`checkForUnsavedChangesSubject# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix flaky Dashboard create tests
(#156085)](https://github.com/elastic/kibana/pull/156085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT \r\nsubscription it would sometimes run for the `\"pulls
state <...>\"` tests\r\n(but not always) - so whenever it **would** run,
because the mocked\r\n`loadDashboardStateFromSavedObject` was only
returning a partial\r\nDashboard input, this would result in trying to
get the property of\r\n`undefined` when checking for filter changes,
panel changes, etc.\r\n\r\nThis is fixed by ensuring that the
`loadDashboardStateFromSavedObject`\r\nreturns a complete Dashboard
input, with all the required keys, for all\r\nof the relevant tests.
Note that, since you can't test Jest unit tests\r\nusing the flaky test
runner, I was able to run it multiple times by\r\nsurrounding all the
tests with the following in order to ensure that it\r\nwas no longer
flaky:\r\n\r\n```typescript\r\nfor (const i of Array(x)\r\n
.fill(null)\r\n .map((_, i) => i)) {\r\n describe(`test run ${i}`, () =>
{\r\n <...> // all the tests go here\r\n });\r\n};\r\n```\r\n\r\nI did
this with `x = 200`, and the entire test suite passed 200 times in\r\na
row 👍\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"57797731905b0303eec9059e398388826c88fa5f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:days","release_note:skip","impact:critical","v8.8.0","v8.9.0"],"number":156085,"url":"https://github.com/elastic/kibana/pull/156085","mergeCommit":{"message":"[Dashboard]
Fix flaky Dashboard create tests (#156085)\n\nCloses
https://github.com/elastic/kibana/issues/155777\r\n\r\n##
Summary\r\n\r\nThe `\"replaces panel with incoming embeddable if id
matches existing\r\npanel\"` test was **not** the flaky one, even though
it was the one that\r\nshowed the failure; it was actually one of the
previous `\"pulls state\r\n<...>\"` tests that was failing, which was
pretty confusing to catch 🤦\r\n\r\nBasically, because we are [running
the unsaved changes check on
load\r\nnow](https://github.com/elastic/kibana/pull/155648), depending
on the\r\ntiming of the `debounce` on the
`checkForUnsavedChangesSubject# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix flaky Dashboard create tests
(#156085)](https://github.com/elastic/kibana/pull/156085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT \r\nsubscription it would sometimes run for the `\"pulls
state <...>\"` tests\r\n(but not always) - so whenever it **would** run,
because the mocked\r\n`loadDashboardStateFromSavedObject` was only
returning a partial\r\nDashboard input, this would result in trying to
get the property of\r\n`undefined` when checking for filter changes,
panel changes, etc.\r\n\r\nThis is fixed by ensuring that the
`loadDashboardStateFromSavedObject`\r\nreturns a complete Dashboard
input, with all the required keys, for all\r\nof the relevant tests.
Note that, since you can't test Jest unit tests\r\nusing the flaky test
runner, I was able to run it multiple times by\r\nsurrounding all the
tests with the following in order to ensure that it\r\nwas no longer
flaky:\r\n\r\n```typescript\r\nfor (const i of Array(x)\r\n
.fill(null)\r\n .map((_, i) => i)) {\r\n describe(`test run ${i}`, () =>
{\r\n <...> // all the tests go here\r\n });\r\n};\r\n```\r\n\r\nI did
this with `x = 200`, and the entire test suite passed 200 times in\r\na
row 👍\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"57797731905b0303eec9059e398388826c88fa5f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156085","number":156085,"mergeCommit":{"message":"[Dashboard]
Fix flaky Dashboard create tests (#156085)\n\nCloses
https://github.com/elastic/kibana/issues/155777\r\n\r\n##
Summary\r\n\r\nThe `\"replaces panel with incoming embeddable if id
matches existing\r\npanel\"` test was **not** the flaky one, even though
it was the one that\r\nshowed the failure; it was actually one of the
previous `\"pulls state\r\n<...>\"` tests that was failing, which was
pretty confusing to catch 🤦\r\n\r\nBasically, because we are [running
the unsaved changes check on
load\r\nnow](https://github.com/elastic/kibana/pull/155648), depending
on the\r\ntiming of the `debounce` on the
`checkForUnsavedChangesSubject# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix flaky Dashboard create tests
(#156085)](https://github.com/elastic/kibana/pull/156085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT \r\nsubscription it would sometimes run for the `\"pulls
state <...>\"` tests\r\n(but not always) - so whenever it **would** run,
because the mocked\r\n`loadDashboardStateFromSavedObject` was only
returning a partial\r\nDashboard input, this would result in trying to
get the property of\r\n`undefined` when checking for filter changes,
panel changes, etc.\r\n\r\nThis is fixed by ensuring that the
`loadDashboardStateFromSavedObject`\r\nreturns a complete Dashboard
input, with all the required keys, for all\r\nof the relevant tests.
Note that, since you can't test Jest unit tests\r\nusing the flaky test
runner, I was able to run it multiple times by\r\nsurrounding all the
tests with the following in order to ensure that it\r\nwas no longer
flaky:\r\n\r\n```typescript\r\nfor (const i of Array(x)\r\n
.fill(null)\r\n .map((_, i) => i)) {\r\n describe(`test run ${i}`, () =>
{\r\n <...> // all the tests go here\r\n });\r\n};\r\n```\r\n\r\nI did
this with `x = 200`, and the entire test suite passed 200 times in\r\na
row 👍\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"57797731905b0303eec9059e398388826c88fa5f"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
2023-04-28 08:14:10 -07:00
Nathan Reese
cdfbb2d2fb
[8.8] [maps] fix layer error in map embeddable error makes map unusable (#155885) (#155940)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[maps] fix layer error in map embeddable error makes map unusable
(#155885)](https://github.com/elastic/kibana/pull/155885)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T19:29:37Z","message":"[maps]
fix layer error in map embeddable error makes map unusable
(#155885)\n\nFixes
https://github.com/elastic/kibana/issues/155773\r\n\r\nhttps://github.com/elastic/kibana/pull/134243
surfaced layer errors as\r\n`output.error`. This was a mistake and
caused map embeddable to render\r\nonly the layer error instead of the
map\r\n<img width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 27 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234602920-4d063a4b-bc02-4fac-9037-0774a790b471.png\">\r\n\r\nPR
resolves issue by no longer surfacing layer errors as
`output.error`.\r\nThe map legend does a great job of surfacing
individual layer errors and\r\nstill keeps the map usable.\r\n<img
width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 26 42
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234603008-8c24674f-21ca-4046-88ed-b1f7b5a06b5b.png\">\r\n\r\nTo
test\r\n* install web log sample data\r\n* Add runtime geo point field
to data view\r\n* create and save map with runtime geo point field.\r\n*
remove runtime field from data view\r\n* add map to dashboard. Verify
map is displayed and error is surfaced in\r\nmap
legend\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b64cfa64169c4ac58df69001cfea455f09e831f","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.8.0","v8.9.0"],"number":155885,"url":"https://github.com/elastic/kibana/pull/155885","mergeCommit":{"message":"[maps]
fix layer error in map embeddable error makes map unusable
(#155885)\n\nFixes
https://github.com/elastic/kibana/issues/155773\r\n\r\nhttps://github.com/elastic/kibana/pull/134243
surfaced layer errors as\r\n`output.error`. This was a mistake and
caused map embeddable to render\r\nonly the layer error instead of the
map\r\n<img width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 27 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234602920-4d063a4b-bc02-4fac-9037-0774a790b471.png\">\r\n\r\nPR
resolves issue by no longer surfacing layer errors as
`output.error`.\r\nThe map legend does a great job of surfacing
individual layer errors and\r\nstill keeps the map usable.\r\n<img
width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 26 42
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234603008-8c24674f-21ca-4046-88ed-b1f7b5a06b5b.png\">\r\n\r\nTo
test\r\n* install web log sample data\r\n* Add runtime geo point field
to data view\r\n* create and save map with runtime geo point field.\r\n*
remove runtime field from data view\r\n* add map to dashboard. Verify
map is displayed and error is surfaced in\r\nmap
legend\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b64cfa64169c4ac58df69001cfea455f09e831f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155885","number":155885,"mergeCommit":{"message":"[maps]
fix layer error in map embeddable error makes map unusable
(#155885)\n\nFixes
https://github.com/elastic/kibana/issues/155773\r\n\r\nhttps://github.com/elastic/kibana/pull/134243
surfaced layer errors as\r\n`output.error`. This was a mistake and
caused map embeddable to render\r\nonly the layer error instead of the
map\r\n<img width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 27 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234602920-4d063a4b-bc02-4fac-9037-0774a790b471.png\">\r\n\r\nPR
resolves issue by no longer surfacing layer errors as
`output.error`.\r\nThe map legend does a great job of surfacing
individual layer errors and\r\nstill keeps the map usable.\r\n<img
width=\"500\" alt=\"Screen Shot 2023-04-26 at 7 26 42
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/234603008-8c24674f-21ca-4046-88ed-b1f7b5a06b5b.png\">\r\n\r\nTo
test\r\n* install web log sample data\r\n* Add runtime geo point field
to data view\r\n* create and save map with runtime geo point field.\r\n*
remove runtime field from data view\r\n* add map to dashboard. Verify
map is displayed and error is surfaced in\r\nmap
legend\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b64cfa64169c4ac58df69001cfea455f09e831f"}},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-04-28 07:32:03 -07:00
Navarone Feekery
8742ba0a2a
[8.8] [Enterprise Search] Fix configurable field inputs and ensure correct typing (#156002) (#156175)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Fix configurable field inputs and ensure correct
typing (#156002)](https://github.com/elastic/kibana/pull/156002)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Navarone
Feekery","email":"13634519+navarone-feekery@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-28T12:12:55Z","message":"[Enterprise
Search] Fix configurable field inputs and ensure correct typing
(#156002)\n\nFixes some misc bugs with the new configurable fields
inputs\r\n\r\n- `EuiFieldNumber` inputs could not be `null`, but we
sometimes want\r\n`null`. I switched these back to `EuiFieldText` and
added integer\r\nvalidations.\r\n- Fields were still being saved as
strings even if they should be\r\nintegers, so enforced a type check to
make sure the expected type is\r\nsaved.\r\n\r\nThe new function
`validateConnectorConfiguration` can also easily be\r\nexpanded to use
the new
validations.","sha":"c3afeb067ec4b7d7784bbe940bad26e0a9b23aeb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:EnterpriseSearch","v8.8.0"],"number":156002,"url":"https://github.com/elastic/kibana/pull/156002","mergeCommit":{"message":"[Enterprise
Search] Fix configurable field inputs and ensure correct typing
(#156002)\n\nFixes some misc bugs with the new configurable fields
inputs\r\n\r\n- `EuiFieldNumber` inputs could not be `null`, but we
sometimes want\r\n`null`. I switched these back to `EuiFieldText` and
added integer\r\nvalidations.\r\n- Fields were still being saved as
strings even if they should be\r\nintegers, so enforced a type check to
make sure the expected type is\r\nsaved.\r\n\r\nThe new function
`validateConnectorConfiguration` can also easily be\r\nexpanded to use
the new
validations.","sha":"c3afeb067ec4b7d7784bbe940bad26e0a9b23aeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
2023-04-28 06:56:18 -07:00
Elastic Machine
efb9d6bd99
[8.8] Sync bundled packages with Package Storage (#156084)
Automated by
https://internal-ci.elastic.co/job/package_storage/job/sync-bundled-packages-job/job/main/3389/

Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>
2023-04-28 09:35:39 -04:00