Commit graph

16157 commits

Author SHA1 Message Date
Lukas Olson
a132bc6d39
Create documentation link directive to avoid cluttering scope (#14630)
* Create documentation links directive to avoid cluttering scope

* Rename to documentationHref
2017-10-30 09:22:07 -07:00
Court Ewing
72afeaec2b
Revert "Add whitelist for urls (#14613)" (#14666)
This reverts commit c464b752a0.
2017-10-30 07:46:39 -04:00
Chris Roberson
677742ee06
[Management] [7.0] Handle saved search import better (#14637)
* Port fixes from #14625 to 7.0

* Fix linting issue
2017-10-27 11:46:45 -04:00
François Prunayre
a1af8ee5f3 Add tooltip to long title. (#14167)
On visualization title ellipsis() is applied and full title is not readable. Display tooltip title.
Past versions were displaying tooltips (cf. https://github.com/elastic/kibana/pull/2401#issuecomment-67576939).
2017-10-27 10:45:24 -04:00
Peter Pisljar
a844f0875b Visualize loader updates (#14528)
* allow loading visualization list thru loader

* visualize should monitor uiState if appState does not exist

* filterBar click handler should check if appScope actualy exist before writing to it

* updating based on review

* update based on review
2017-10-27 16:38:18 +02:00
Kim Joar Bekkelund
146c6aa05b Import Babel polyfill when running Jest tests (#14508) 2017-10-27 16:25:54 +02:00
Matt Apperson
834cb178f2 fix issue of duplicate chart creation (#14626) 2017-10-27 08:05:00 -04:00
Peter Pisljar
fb406a271c extending and updating documentation for visualize (#14441)
* extending and updating documentation for visualize

* updating based on review
2017-10-27 09:30:04 +02:00
CJ Cenizal
7a81638561 [UI Framework] Fix Popover and ContextMenu bugs (#14617)
* Rename KuiPopover isFocusable prop to ownFocus. Focus on first focusable element by default.
* Fix bug where ContextMenuPanel keyboard navigation broke if the user was using tab instead of arrow keys.
2017-10-26 17:00:32 -07:00
Chris Cowan
bb859d93b9 [TSVB] Fix bugs with the new split gauge/metric behavior (#13823)
* Adding a check to make sure everything is available to render

* Adding some safety

* Fixing a bug with the label

* Adding an additional sleep to wait for the new data to arrive.
2017-10-26 15:47:57 -07:00
Chris Roberson
c464b752a0 Add whitelist for urls (#14613)
* Add url whitelist

* Use .some

* Add/fix tests

* Add browser tests
2017-10-26 14:03:19 -04:00
CJ Cenizal
63c6d3f5a2 Port KuiModal K7 improvements. (#14557)
* Port KuiModal K7 improvements.
- Add FocusTrap to KuiModal.
- Delete KuiModalBodyText.
- Add support for dark theme to KuiModal and typographic components.
- Update Kibana Angular confirm modal and Clone Dashboard modal.
* Remove KuiModalBodyText reference from ChangeIndexModal.
* Improve color contrast of hollow Button in dark theme.
* Fix bug with ShowCloneModal not being unmounted when it's closed.
* Fix bug with ShowChangeIndexModal not being unmounted when it's closed.
2017-10-26 11:02:32 -07:00
Nathan Reese
e70f9c356b Timelion .fit() - avoid removing values that are zero (#14560)
* do not filter out values that are not zero

* do not call fit function when series is all null

* simplify filter code

* add another test case
2017-10-26 11:45:34 -06:00
Stacey Gammon
fc27d2abe6 wrap the check in a retry so we know it's not just taking a little long for the css changes to take affect in the UI (#14575) 2017-10-26 09:55:09 -04:00
Tim Roes
00bbee354c [Accessibility] Improve visualization legends accessibility (#14505)
* Make legend toggle button accessible, fix #11843

* Make legend filter buttons accessible

* Highlight chart segments when focusing legend, fix #11845

* Make legend color picker accessible

* Remove aria-hidden from legend

* Use proper indentation

* Remove bluring color button again

* Close legend details on pressing escape

* Add hint about the action

* Only capture escape press when details are opened
2017-10-26 14:15:04 +02:00
Tim Roes
315da4e74b Fix linting issues due to space checks (#14599) 2017-10-26 11:57:29 +02:00
Tim Roes
8ac1d7399c Fix tagcloud sync issues, fix #14565 (#14566)
* Fix tagcloud sync issues, fix #14565

* Remove console.log statement
2017-10-26 08:13:33 +02:00
Tim Sullivan
515e3f913a [UI] allow search toolbar input to be updated from state change (#14588) 2017-10-25 16:15:49 -07:00
CJ Cenizal
8a9266f811 Improve logic for tabbing through a ContextMenuPanel's form elements. (#14572)
- Support left arrow going back when the panel itself is focused.
2017-10-25 15:20:36 -07:00
CJ Cenizal
05cbb92965 [eslint-config-kibana] Apply AirBnB spacing rules (#14522)
* Add AirBnB key-spacing rule.
* Add AirBnB comma-spacing rule.
2017-10-25 15:08:05 -07:00
Matt Apperson
417a650cb3 Hide only TSVB controls, not charts (#14545)
* hide only TSVB controls, not charts

* revert format changes

* Update vis_editor_visualization.js

* walk back more style changes

* fix regression

* fix more regressions

* add new lines back
2017-10-25 17:17:19 -04:00
Chris Cowan
83ed42744b Fixes #14124 - removes the 1w label (#14577) 2017-10-25 11:17:50 -07:00
Court Ewing
c8d71a1fb2 scripts: bump backport tool to 1.0.1 (#14581) 2017-10-25 13:28:03 -04:00
Chris Cowan
ef608dc2b6 [TSVB] Remove console.log from Resize PR (#14555) 2017-10-25 09:45:57 -07:00
Thomas Neirynck
f1f5b892cb use proper SVG APIs to readout contents (#14458) 2017-10-25 12:16:52 -04:00
Jonathan Budzenski
092f46bbde Bump node to 6.11.5 (#14568) 2017-10-25 09:26:00 -05:00
Nathan Reese
6d01b35cd4 Set configurable to true so AggConfig decorated properties can be deleted (#14569)
* make decorated property configurable so it can be deleted

* same for histogram aggregation
2017-10-25 08:24:01 -06:00
Tim Roes
7025c32c02 [Accessibility] Improve filter bar accessibility (#14474)
* Prefix negative filters with "NOT"

* Make filters tabable and add ARIA
2017-10-25 08:38:07 +02:00
Tim Roes
8c798d231a [TSVB] Allow negative time offsets (#14494)
* Allow negative offsets in TSVB

* Fix linting issue
2017-10-25 08:25:36 +02:00
CJ Cenizal
d58ffe43da Fix broken kuiInputBackgroundColor reference. (#14558) 2017-10-24 17:53:34 -07:00
CJ Cenizal
ec38367b70 [UI Framework] Improve KuiContextMenu keyboard navigation UX (#14434)
* Refactor focus state logic to use the React lifecycle correctly.
* Update KuiPopover snapshots.
* Remove unnecessary isVisible prop from KuiContextMenu.
* Allow user to both tab AND use the arrow keys for navigation.
* Reinstate ability to tab and shift-tab to the title of KuiContextMenuPanel.
* Release focus from Dashboard panel options KuiContextMenu by closing it when you select an option.
* Update KuiContextMenu example to demonstrate best practice of closing the menu when an item is clicked.
* Replace native transitionend event handler with onAnimationEnd React event handler.
2017-10-24 17:37:51 -07:00
CJ Cenizal
97e393d52e [11532] Improve local nav accessibility (#14365)
* Use h2 elements for titles in Sharing dropdown.
* Override inherited typographic styles in kuiLocalDropdownTitle.
* Use h2 elements for titles in Console dropdowns.
* Update kuiLocalDropdownHeader__label class to be applicable to legend elements.
* Update Console settings menu with aria labeling and UI Framework styles.
* Remove unused config-close styles.
* Update Dashboard local nav dropdowns with form labels and h2 elements.
* Add support for dark theme to kuiCheckBox.
* Update Dashboard local nav dropdowns and saved-object-save-as-check-box directive with kuiCheckBoxLabel styles.
* Update Discover local nav with h2 elements.
* Update Visualize local nav with h2 element.
* Add aria-label to unlabeled inputs in Discover, Visualuze, and Timelion inputs.
* Update Timelion local nav with h2 elements.
* Update timepicker with tab roles, h2 elements, and UI Framework styles.
* Improve labeling and add aria-selected to timepicker tabs.
- Refactor timepicker tabs to adhere to tablist structure correctly.
* Add tablist role.
2017-10-24 16:01:25 -07:00
Chris Cowan
9c9fb17fef Math Aggregation to support Sibling Aggs for TSVB (#13681)
* Math Aggregation to support Sibling Aggs

* Fixing tests

* Deal with ResultSets

* including all var under params; updating docs

* Fixing bugs asscociated with blank Math aggs

* Adding aria props to elements

* Fixing aria labels; changing calculation label to bucket sript

* changing input to textarea

* Add compatability with percentiles; fix vars to be compatible with percentiles

* Adding comments

* Fixing typo in note
2017-10-24 15:54:45 -07:00
Chris Cowan
d891623fac Table Visualization for TSVB (#12813)
* Adding table vis

* Making linter happy

* Getting the data api inline

* Fixing aggs for table vis

* Fixing aggs for table vis

* Adding table vis

* Adding uiState and sorting

* Adding sorting

* Adding sorting and removing display fields

* fixing color picker in timeseries and gauge; thresholds for trend arrows

* Removing thresholds from trends

* removing background color

* remvoing obsolete tests

* Fixing terminology... pivot doesn't make sense

* updating error message

* making the sort icons match the rest of the app

* Fixing eslint bullshit

* Fixing a few bugs from merges

* Fixing linting issues

* Adding a falsy check

* Adding aria labels

* Changing toggle to use a button

* Adding focus-ring back in

* Adding check for model and visData; they should never be null

* Changing ids to use new htmlIdGenerator function

* Switching to htmlIdGenerator

* Fixing the way sorting works; fixing the error handling

* making no data compatible with vis

* Fixing defaults bug; Adding missing css rule

* Fixing sorting bug
2017-10-24 15:45:57 -07:00
Nathan Reese
e279e41075 input controls icon (#14517) 2017-10-24 15:06:54 -06:00
Chris Cowan
bd0cf5c963 [TSVB] Adding predict option to moving average (#14268) 2017-10-24 14:02:26 -07:00
Chris Cowan
340f0dde15 Fixes #14367 - Add courier's migrateFilters to dashboard context (#14481) 2017-10-24 13:59:52 -07:00
Stacey Gammon
9c8887ab74 Fix flaky test (#14543)
Doesn’t fix the underlying issue (which hasn’t been determined yet) but
it should get the build passing consistently again.
2017-10-24 16:55:16 -04:00
Søren Louv-Jansen
7dbb01552e Add Backport to toolchain (#14525) 2017-10-24 16:38:18 -04:00
Thomas Neirynck
147c6c2832 Re-enable the tilemap test (#14532)
Enables the tile-map test. this was disabled due to CORS-issues on the server end. These are now resolved.

This reverts commit e7fb1b0d8f.
2017-10-24 11:08:21 -04:00
Nathan Reese
88f3af406d Scale histogram aggregation interval to avoid crashing browser (#14157)
* update histogram agg to fetch min and max when search request started

* scale interval when too many buckets are created

* move min and max params into autoBounds param, remove typo in help text

* use decorated property instead of params to avoid changing agg state, add functional test

* remove sleep from functional test

* make args for onSearchRequest functions specific. Add getters and setters for autoBounds to AggConfig. Protect against divide by zero

* add unused arguments with eslint comment
2017-10-24 06:53:19 -06:00
Kim Joar Bekkelund
371b6bcc23 Use Array.isArray instead of _.isArray (#14501) 2017-10-24 14:02:39 +02:00
Stacey Gammon
e5a3ba7802 Introduce redux into dashboard (#14518)
* Initial check in of introducing redux in dashboard

* Use redux-actions and redux-thunks to reduce boilerplate

* Make sure all panels are minimized from the start when a dashboard is loaded - we don't want a panel id from a different dashboard in the state tree on a fresh open.

* Remove unused file

* use classnames dependency instead of manual logic

* First pass on selectors, handleActions, and more segmented reducers.

* Fix bugs with selectors and reducers and add tests that would have caught them.

* Fix issue plus tests

discover was not returning a promise

* Make expanding a panel purely a css modification which avoids all re-renders

* Found another bug with initial state not being set correctly on a hard refresh

* Remove check for change handlers now that the event handler bug is fixed

* rename dashboardState => dashboard for reducers and redux state tree

* Remove unnecessary top level describe in jest tests

* Navigate back to landing page at the end of the newly added test suite

* Fix lint errors

* Stabilize flaky tests by waiting until saved object search is finished loading results

* Don't leak subscriptions to the store.

* use selectors to grab dashboard panel off state.

* Remove use of getState in dispatcher to avoid circular reference and still use selectors

* use spread over object.assign

* No need to pass second param in when the input is simply returned as-is.
2017-10-23 16:39:23 -04:00
Stacey Gammon
e7fb1b0d8f Comment out tile map tests to get the build passing again (#14519) 2017-10-23 15:29:38 -04:00
Tim Roes
f3e2750136 Fix crash when hitting shift+return in Dev Tools Console, fix #14468 (#14478) 2017-10-23 11:34:50 +02:00
Stacey Gammon
73058c67b1 Use spread operator over Object.assign (#14496) 2017-10-22 08:16:31 -04:00
Chris Cowan
e49eab2df0 Fixing css to nowrap value; removed duplication; removed comments (#14254) 2017-10-18 10:30:31 -04:00
Chris Cowan
645c9c273a [TSVB] Adding the ability to sort terms split by terms; Adding ability to change sort direction (#14213) 2017-10-18 10:25:10 -04:00
Chris Cowan
8c363362dc [TSVB] UI Tweaks for data format picker (#14313) 2017-10-18 10:21:22 -04:00
Chris Cowan
63d885ee9e Fixes #14470 - Remove field restriction on cardinality agg (#14483) 2017-10-18 09:53:34 -04:00