Commit graph

42727 commits

Author SHA1 Message Date
John Dorlus
a1954b4334
Changed Upgrade Assistant test to reflect hiding the UI (#96714)
* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 12:59:59 -04:00
Matthias Wilhelm
33892741c3
[Discover] Rename Legacy table to Classic table and Data grid to New table (#99336)
* Rename "Legacy table" to "Classic table"

* Rename "Data grid" to "New table"
2021-05-06 18:54:57 +02:00
Jonathan Budzenski
79be58ee1b Revert "[App Search] Remove reset mappings button from Role mappings (#99414)"
This reverts commit 1d4bdc554c.
2021-05-06 11:14:31 -05:00
David Sánchez
35f4be4387
[Security Solution][Endpoint] User can edit existing event filters from the list (#98898)
* Makes width 100% to allow multilang

* Removes state/index types and move those types into the parent types file

* Allows fill form from existing exception by id. Adds unit tests. Fixes wrong comments display when there is more than one comment.

* Allows user update an existing event filter. Adds unit tests. Fixes some wrong behaviours when opening the flyout after create/update action

* Fixes typo

* Fixes wrong entry type

* Uses selectors when it's possible instead of accessing directly to state object

* Fixes typechecks

* Allows edit from the card edit button. Removes unused imports and fixes some types

* Reverts type name

* Changes reducer to don't add entry to the list manually after creation, list will be reloaded with api call. Also check always if data exists to display the add new entry button at the first time
2021-05-06 18:13:55 +02:00
Robert Oskamp
beaa4e78fb
[ML] Functional tests - reenable clone and edit tests for transform latest (#99306)
This PR fixes the data grid parsing and re-enables the clone and edit tests for transform latest.
2021-05-06 17:54:24 +02:00
Lisa Cawley
fa13af90be
[ML] Add popover help for swim lanes (#98855)
Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
Co-authored-by: Michael Marcialis <michael@marcial.is>
2021-05-06 08:41:08 -07:00
Scotty Bollinger
1d4bdc554c
[App Search] Remove reset mappings button from Role mappings (#99414)
* Move toolTip type to shared

This is used by Workplace Search as well

* Remove reset mappings button

Will not be used as a part of the User transition

* Remove server route

* Remove unused import
2021-05-06 10:37:16 -05:00
Diana Derevyankina
40bc95b3fd
[TSVB] Removal of validation schema (#99063)
* [TSVB] Removal of validation schema

* Move types to a separate folder and rename some of them

* Remove nulls from types and move enums to a separate folder

* Rename common to panel_model

* Remove nulls from optional color_rules types, replace QueryObject with Query type from data plugin and remove empty strings from some types and corresponding default values

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 18:33:17 +03:00
Kyle Pollich
baf149fdc3
[Fleet] Update no results content for integrations (#99415)
* Update no results content for integrations

- Update content when no results returned from search on integrations
screen
- Add links to custom integrations and discuss forums to bottom of
results grid, even when results are returned

Closes #87015

* Don't show missing integration message for installed integrations

* Remove unneeded history.push
2021-05-06 11:27:58 -04:00
Frank Hassanabad
0d56a59582
[Security Solutions] Fixes more Cypress flakes by adding abilities to do refresh on timelines (#99413)
## Summary

This should fix the flakes by adding the ability to do refreshes when timelines aren't being shown.

* Fixes the missing data subjects and tests in our code base
* Fixes the flakes in each of the tests we were seeing
* Cleans up some of the .then() and additional checks we were using
* Returns more chainables from Cypress so we can use more then() logic to keep things cleaner
* Removes 1 dead duplicated function found 

You can replicate the flake by adding this code below in any before code of this pull request. This is how I was able to replicate it and then fix it within the utils.

```ts
export const waitForTimelinesPanelToBeLoaded = (): Cypress.Chainable<JQuery<HTMLElement>> => {
  cy.get(TIMELINES_TABLE).should('exist');
  cy.wait(5000); // <--- Do a wait for 5 seconds to ensure the table is fully loaded with zero hits to replicate the flake this fixees
  return cy.get(TIMELINES_TABLE).should('exist');
};
```

A secondary issue is that when you do fast refreshes the click handlers are not on the timelines in the timeline table. However, we cannot do fast pipe/re-clicking on those because that causes a different type of flake. The flake that can cause is multiple clicks are registered and then we end up with multiple URL/route reloads.

So instead, we have to unfortunately rely on one `cy.wait(1000)` Cypress wait of 1 second.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-05-06 08:42:10 -06:00
Stratoula Kalafateli
fe9029cef3
[Rollup] Fixes telemetry (#98639)
* [Rollup] Fix telemetry and also add lens visualizations

* Different lens stats for rollup visualizations

* Add unit test

* Implement pagination

* Fix telemetry schema

* Fix test

* Add unit tests

* Change docs per page size to 1000

* Add meta description for our rollup telemetry

* Fix telemetry schema

* Fix unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 17:41:54 +03:00
Spencer
7740e06b0b
[sec/actions] move constants to a separate file to avoid circular deps (#99439)
* [sec/actions] move constants to a separate file to avoid circular deps

* split out setupSavedObjects import

* remove unused import

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-05-06 06:54:20 -07:00
David Sánchez
ddc640731d
Fixes special characters and quotes on trusted apps search (#99377)
* Escapes special chars and backslashes and colons. Updates test.

* Uses regexp to escape all non alphanumeric chars

* Skips whitespaces

* Skips slashes

* Fixes regex and adds more test cases
2021-05-06 15:25:07 +02:00
Kevin Logan
f2bb74e996
[Security Solution][Detections] Add linux artifact for exception lists (#99104) 2021-05-06 09:13:37 -04:00
ymao1
86ea803168
[Task Manager] Using track_total_hits in workload agg (#99360)
* Using track_total_hits in workload agg

* Increasing size of terms aggregation
2021-05-06 09:02:24 -04:00
Ahmad Bamieh
81fed18b0b
[i18n] Integrate 7.13.0 Translations (#99370) 2021-05-06 15:56:12 +03:00
Dmitry Tomashevich
a5eb98d0e4
[Discover] Migrate remaining context files from js to ts (#99019)
* [Discover] migrate remaining context files from js to ts

* [Discover] get rid of any types

* [Discover] replace constants with enums, update imports

* [Discover] use unknown instead of any, correct types

* [Discover] skip any type for tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 13:57:27 +03:00
Vadim Dalecky
308596d51b
RFC template (#98501)
* docs: ✏️ adjust rfc tpl as suggested by stacey

* docs: ✏️ add double newline before first level headings

* docs: ✏️ add "who is affected" section

* docs: ✏️ add stakeholders

* docs: ✏️ specify rfc and issue fields

* Update rfcs/0000_template.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update rfcs/0000_template.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update rfcs/0000_template.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update rfcs/0000_template.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* docs: ✏️ adjust PR links as per review request

* docs: ✏️ move architectural diagrams as sentence into design

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
2021-05-06 10:44:38 +02:00
Ester Martí Vilaseca
5cb990628e
[Metrics UI] Don't mount NodeContextMenu when is not visible (#99207)
* Avoid render NodeContextMenu when mounting node

* Fix popover on inventory table view

* Remove unnecessary condition

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-06 10:41:05 +02:00
Vadim Dalecky
154d26a991
docs: ✏️ remove mentions of core team (#98503)
* docs: ✏️ remove mentions of core team

* Update rfcs/README.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
2021-05-06 09:14:06 +02:00
Yuliia Naumenko
9009efaf91
[Connectors][UI] Updated connectors list UI for connectors that need to be updated after import. (#98565)
* [Connectors][UI] Updated connectors list UI for connectors that need to be updated after import

* added ui property isMissingSecrets

* added info for medit form

* fixed tests

* fixed due to comments

* fixed due to comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 19:13:43 -07:00
Cauê Marcondes
02d537313e
[APM] transaction type is not persisted from service inventory (#99407) 2021-05-05 19:37:30 -04:00
Vadim Dalecky
aa94214fc7
feat: 🎸 close drilldown manager on view mode switch (#99309) 2021-05-06 00:26:13 +02:00
Spencer
61eb3f0685
[ftr] validate that suites are not in multiple ciGroups (#99398)
* [ftr] validate that suites are not in multiple ciGroups

* remove unused import

* include filename in error message

* remove redundant ciGroup tags

* fix more duplicate ciGroups

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-05-05 14:50:07 -07:00
igoristic
b46a90e8de
Fixed aggs parsing error (#99159) 2021-05-05 17:29:54 -04:00
igoristic
8c968322b0
[Monitoring] Checking source node and aggregations before accessing its properties (#98255)
* checking source node

* Fixed types

* Added aggregations check

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 17:28:17 -04:00
Tiago Costa
43d3a97f5b
chore(NA): moving @kbn/es into bazel (#99371)
* chore(NA): moving @kbn/es into bazel

* chore(NA): remove build scripts from pkg json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 20:52:01 +01:00
Dmitry Shevchenko
24734a39d1
Implement missing privileges callout component (#98125) 2021-05-05 19:45:20 +02:00
Constance
1322eee98e
[App Search] Create Engine UI polish (#99281)
* Remove incorrect external icon indicator

davey pls

* Add isLoading state to the Create Engine button

* Add isLoading state to the Create Meta Engine button
2021-05-05 09:58:06 -07:00
Scotty Bollinger
e0d4acb1b1
[Workplace Search] Refactor RoleMappingsLogic (#99284)
* Reorder methods

* Reorder actions interface

* Reorder values interface

* Reorder server details interface

* Add path

* Refactor handleDeleteMapping logic

* REorder and refactor actions

Also changes functions with no return values to properties to match app search

// Before:
foo: () => true

// After
foo: true

* Reorder reducers

* Reorder JSON body props

* Change JSON order in test

Passes locally but fails on CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 11:41:36 -05:00
Jonathan Budzenski
ae6109e15a
[packages] Move @kbn/crypto to Bazel (#99233) 2021-05-05 11:33:23 -05:00
Melissa Alvarez
96da390e6f
[ML] Anomaly Detection Explorer: adds choropleth map (#98847)
* adds choropleth map to explorer

* improve suggestions check

* improve state management in anomalies map

* fix translation

* ensure map updates correctly when filtering by entity

* update import from maps
2021-05-05 11:59:42 -04:00
James Rodewig
bdf6e9fe53
[DOCS] Update Docker run instructions (#99340)
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2021-05-05 11:42:56 -04:00
Andrea Del Rio
2f80b5cf68
Remove margin from KQL textarea (#99248) 2021-05-05 08:41:53 -07:00
ymao1
4ab86c77d4
[Alerting] Export rules and connectors (#98802)
* Adding importableAndExportable but hidden saved object types to saved object feature privilege

* Adding helper function for transforming rule for export. Added audit logging

* Adding helper function for transforming rule for export. Added audit logging

* Adding unit test for transforming rules for export

* Exporting connectors

* Removing auditing during export

* Adding import/export to docs

* PR fixes

* Using action type validation onExport

* Fixing logic for connectors with optional secrets

* Fixing logic for connectors with optional secrets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 11:33:01 -04:00
Gloria Hornero
0d7a5826a4
completes unmapped field test (#99227) 2021-05-05 16:58:58 +02:00
Larry Gregory
aab29cdbb0
Document plugin API for spaces and spacesOss (#98966)
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 10:50:59 -04:00
Larry Gregory
c238a9708b
Use vega-interpreter to safely evaluate Vega expressions (#98832)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 10:46:50 -04:00
Tim Roes
792845fd75
Enable custom time ranges for saved searches (#99180)
* Enable custom time ranges for saved searches

* Add functional test

* Fix Typing

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 16:35:39 +02:00
Larry Gregory
656206cd2d
Load FLS suggestions on-demand (#98681)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 10:22:18 -04:00
Nathan Reese
9a3c508184
[file upload] use index exists API for /internal/file_upload/index_exists route (#98471)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 07:59:29 -06:00
Diana Derevyankina
86b688934a
[Vega] Supports runtime fields (#98707)
* [Vega] Support of Runtime Fields

* Refactor es_query_parser

* Refactor es_query_parser

* Remove unnecessary object creation

* Revert tests and move changes related to runtime fields into search_api

* Remove unnecessary code
2021-05-05 16:33:44 +03:00
Dmitry Tomashevich
203c40c945
[TSVB] Adds ignore DST switch for timeseries (#98484)
* [TSVB] add ignore DST switch

* [TSVB] move YesNo component to timeseries panel, get rid of getTimezone call

* [TSVB] reduce formatter creation number

* [TSVB] add usage EuFormRow, remove redundant translations

* [TSVB] use boolean instead of number

* [TSVB] use number for YesNo

* [TSVB] resolve YesNo value type

* [TSVB] replace number with boolean

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 16:32:55 +03:00
Ashokaditya
7f57eb39a6
Update agent status labels and colors (#99314)
fixes elastic/kibana/issues/97457
2021-05-05 14:49:49 +02:00
Mikhail Shustov
2eb700be92
do not crash when es client throws any type of error (#99175) 2021-05-05 14:39:55 +02:00
igoristic
47cebf0ee1
Merged local branch (#99157) 2021-05-05 08:34:40 -04:00
David Sánchez
02608696ea
[Security Solution][Endpoint] Trusted apps search throws an error when searching special chars (#99185)
* Escapes special chars and backslashes and colons. Updates test.

* Uses regexp to escape all non alphanumeric chars

* Skips whitespaces

* Skips slashes
2021-05-05 14:25:56 +02:00
Dima Arnautov
5ce926b9f7
[ML] Support trained model aliases (#99174)
* [ML] use toString to make sure boolean values are rendered

* [ML] extract metadata

* [ML] retrieve pipelines associated with model alias

* [ML] fix ts issues

* [ML] functional tests

* [ML] remove unused models definitions
2021-05-05 07:34:07 -04:00
Yulia Čech
8ce3ea0238
[Remote clusters] Fixed skipped test for search bar (#97472)
* Fixed skipped search test

* Fixed eslint error

* Added setSearchBarValue helper to testbed and unskipped search tests in CCR

* Fixed eslint errors and added a comment to the setSearchBarValue method

* Added a mock for EuiSearchBox

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-05 13:05:35 +02:00
Tim Roes
349b7e9f8e
Add more strict eslint rules for discover (#99241) 2021-05-05 10:54:15 +02:00