Commit graph

30591 commits

Author SHA1 Message Date
Spencer
baf3e059c5
[7.7] [kbn/ui-shared-deps] expand and split (#62364) (#62523)
* [kbn/ui-shared-deps] expand and split (#62364)

* [kbn/ui-shared-deps] expand and split

* add two import styles for eui/react-dom that are new

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* downgrade elasticsearch-browser and updated yarn.lock

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 22:56:12 -07:00
Angela Chuang
c95f39f6e2
fix persisting note (#62444) (#62471) 2020-04-04 19:09:39 +01:00
Spencer
3aea932857
[7.7] [jenkins] refer to sizes in most pipeline code (#62082) (#62550)
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 10:24:12 -07:00
Devin W. Hurley
868cf864c0
[7.7] [SIEM] [Detection Engine] Remove has manage api keys req… (#62535)
Alerting no longer requires the manage_api_keys privilege, so we are removing it from the detection engine code. Fixes #62387

* removes hasManageApiKeys since alerting is using the internal user api calls, manage_api_keys privilege is no longer necessary

* linting error

* fixes types and removes a test for manage api keys

* removes manage api key reducer and updates leftover tests

* moves userHasNoPermissions repeated code into a function in helpers, adds a few test cases, updated references to new function

* fix test title

* remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD

* Revert "remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD"

This reverts commit 93912e7e22.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 11:15:18 -04:00
MadameSheema
22cb4e7835
fixes flakiness (#62406) (#62504)
* fixes flakiness

* updates 'number of signals' selector

* changes the way we are asserting the text
2020-04-04 16:50:52 +02:00
CJ Cenizal
3f7704fada
Fix bug that coerced empty scaled float value to 0 (#62251) (#62537) 2020-04-04 07:21:27 -07:00
CJ Cenizal
b291b8b47d
[7.7] Update ILM node attributes blacklist. (#62093) (#62192)
- Remove 'testattr' because this doesn't seem to be used in production by ES.
- Add 'transform.node' (added via https://github.com/elastic/elasticsearch/pull/52712/files#diff-225cc2c1291b4c60a8c3412a619094e1R147).

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 17:40:53 -07:00
Ryland Herrick
ef649b859c
[SIEM] Prevent undefined behavior in our ML popover (#62498) (#62525)
* Moves enableDataFeed outside of MLPopover

If we accept our dispatch functions, enableDatafeed can be abstracted as
a pure function. The version bound to popover's dispatch functions is
now named 'handleJobStateChange', as that is the callback it's used for.

* Remove unused component state

We no longer deal with jobs in our local state; that's the
responsibility of the useSiemJobs hook

* Prevent user from initiating multiple job installations

When attempting to run a job from the ML Popover, if the job needs to
first be installed, we set the rest of the jobs to be "loading" while
installation is performed.

Without this change, if users are fast enough they can potentially
trigger multiple rule installations, which is undefined behavior and
leads to failures and bad state in our component.

* Remove unused import
2020-04-03 18:53:39 -05:00
Melissa Alvarez
5e0d36881e
[ML] DF Analytics - ensure destination index pattern created (#62450) (#62518)
* ensure destinationIndex name is defined

* set array for destIndex as invalid

* update type

* reset destIndex already exists error when updating advanced editor
2020-04-03 19:25:56 -04:00
Frank Hassanabad
e1b2f32332
[SIEM][Detection Engine] Fixes export of single rule and the icons (#62506)
## Summary

Fixes export of single rule and the icons.
* https://github.com/elastic/kibana/issues/62378
* Single export of rules was using the `rule.id` instead of the `rule.rule_id` where now it flips it and works as expected.
* This adds data-test-subj for testing
* This adds jest unit tests to the menu component

Icons Before:
<img width="396" alt="Screen Shot 2020-04-02 at 5 12 43 PM" src="https://user-images.githubusercontent.com/1151048/78315482-5b533280-751a-11ea-8378-d5e106ebd36f.png">

Icons After:
<img width="407" alt="Screen Shot 2020-04-02 at 7 40 28 PM" src="https://user-images.githubusercontent.com/1151048/78315449-3fe82780-751a-11ea-9d16-2f8c2ea22a78.png">

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-03 16:46:17 -06:00
Ryland Herrick
d3d8ea8c87
Mark rule run as failure if there was an error (#62383) (#62514)
While we still let the rule execute in the case of gap errors and
stopped ML jobs, we now mark that execution as a failure instead of a
success.
2020-04-03 17:14:12 -05:00
Nathan L Smith
b602bed491
[7.7] Instrument Kibana with APM RUM agent (#44281) (#62484)
* Instrument Kibana with APM RUM agent (#44281)

* Instrument Kibana with APM RUM agent

* make route-change transaction work with properl url

* extract page-load transaction url from app link

* check if app is hidden and set active:false

* make distributed tracing work and merge config

* remove config/apm.js and address review

* address review comments

* add apm.js to build tassks

* move apm from dev to src

* add @types/hoist-non-react-statics which is required by react rum

* apply changes correctly from master

* Remove unneded changes

* fix apminit

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
2020-04-03 16:46:34 -05:00
Jean-Louis Leysens
cd60282794
[7.7][Mappings Editor] Support unknown types (#62149) (#62495)
* First iteration of supporting unknown types e2e

* Add missing files

* Fix types issues

* When creating a new field, we check if we actually know the type

If we do know the type, convert the new field to it and throw away
the customTypeJson.

* Fix i18n

* Updated naming to be more consistent

customType -> otherType

* Clean up of custom type in comments and validation feedback

* Codre review suggestions

* Add missing serializer

* Add Array validator to json

* Fix types issues

Do not use otherTypeName in call to getConfig rather wrap it
in it's own component also add some comments.

* Remove otherTypeJson from parameters

* Move fieldConfig to variable outside of the UseField

* Copy update

Change the instruction from "Manually specify" to something more
declarative. Also, manually may sound misleading (suggests there
is an automatic alternative).

Also change the JSON parameter label to something more accurate.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sabee77@gmail.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sabee77@gmail.com>
2020-04-03 23:38:44 +02:00
Kaarina Tungseth
325c5ce3d5
Updates dashboard images (#62011) (#62354) 2020-04-03 15:29:15 -05:00
Ryland Herrick
f467b99fa0
Ensure rule message do not span multiple lines (#62391) (#62481)
Because these messages are used for logging, we should ensure they do
not span multiple lines and confuse log parsers. Since the frontend does
not currently display these newlines, anyway, there is no impact to the
UI.
2020-04-03 14:08:53 -05:00
Zacqary Adam Xeper
824050ee50
[7.7] [Metrics Alerts] Set default aggregator to "average" ins… (#62474)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 13:39:54 -05:00
Matthias Wilhelm
37cb61989c
[Discover] Fix legacy url invalid conversion (#62324) (#62436)
* Migrate legacy queries when initial state is built with URL params

* Add tests
2020-04-03 18:42:11 +02:00
Mikhail Shustov
d4bb09f9cb
async assets laoding for advances settings management section (#62434) (#62457) 2020-04-03 18:36:52 +02:00
Mikhail Shustov
ce7c609682
lazy loading for infra assets (#62363) (#62448) 2020-04-03 18:36:41 +02:00
Mikhail Shustov
7ce32ccdcd
ml async assets loading (#62403) (#62426) 2020-04-03 15:27:47 +02:00
Mikhail Shustov
7a0f7d0644
tranform management section lazy loading (#62408) (#62423) 2020-04-03 15:26:55 +02:00
Anton Dosov
233e309343
[Drilldowns] Dashboard state fixes for drilldowns (#61457) (#62421)
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g

2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.

3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard

4. Fix initial panel state migration causing redundant browser history records

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 14:52:16 +02:00
Cauê Marcondes
7f95fd8535
removing configuration from agents (#62290) (#62398) 2020-04-03 13:28:04 +02:00
Dima Arnautov
912b8407d1
[ML] call job validation endpoint with complete payload (#62331) (#62405) 2020-04-03 12:47:49 +02:00
Angela Chuang
ddc1a1b4d4
allow null for filterQuery (#62310) (#62411) 2020-04-03 11:41:05 +01:00
Joe Reuter
a651b23d61
Make d3 place nicely with object values (#62004) (#62340) 2020-04-03 11:08:31 +02:00
Jean-Louis Leysens
4973ddd780
[7.7] [Mappings Editor] Add logic for including type name in e… (#62341) 2020-04-03 10:29:02 +02:00
Shahzad
671b444320
[7.7] [Uptime] Convert anomaly Jobs name to lowercase to compl… (#62348)
* converted ml job name to lower case

* update type
2020-04-03 09:19:55 +02:00
Mikhail Shustov
c0cc32a440
move crypto to server utils (#62344) (#62369)
* move crypto to server utils

* fix mocks
2020-04-03 09:02:44 +02:00
Nathan L Smith
02565fc890
Use docLinks API for APM doc links (#61880) (#61909)
* Use docLinks API for APM doc links

Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component.

Fixes #56453
Fixes #60945

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 16:02:23 -05:00
Peter Schretlen
b7881fb659
fix text error in diagrams (#62101) 2020-04-02 14:47:06 -04:00
Andrew Cholakian
a577374c86
[Uptime] Remove static constant for index name completely (#62256) (#62323)
Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 13:04:04 -05:00
CJ Cenizal
a025f59ed2
[7.7] Show server name in Remote Cluster detail panel (#62250) (#62305)
* Fix text size for connection status and seeds.
2020-04-02 07:42:29 -07:00
Nathan L Smith
061248f629
Remove border around popover service map popover trigger (#62257)
Fixes #62139.
2020-04-02 08:50:52 -05:00
Mike Côté
90efa68c69
Rename some alert types (#61693) (#62299)
* Rename some alert types

* Use sentence case for remaining changes + fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 09:42:10 -04:00
Xavier Mouligneau
954c3679e6
[SIEM] CASES Bugs BC2 (#62170) (#62232)
* fix persistence between filter

* Fix API filtering bug

* Show username if full name is empty

* fix user in avatar

* do not allow push to service now when connector is none

* fix types

* Show errors from actions

* update connector name in configure

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2020-04-02 08:55:01 -04:00
Cauê Marcondes
c029bb6ab4
changing duration type to ms, s, m (#62265) (#62292) 2020-04-02 14:53:34 +02:00
Devin W. Hurley
71d99d4174
[7.7] [SIEM] [Detection Engine] Fixes all rules sorting (#6203… (#62235)
* fixes sorting to what it was in 7.6.1

* removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 08:47:36 -04:00
Dario Gieselaar
e3da020150
[7.7] [APM] Ensure telemetry data matches SO/telemetry mapping… (#62272)
* [APM] Ensure telemetry data matches SO/telemetry mapping

Closes #61802.

* Correct mapping for dotnet data

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 14:42:33 +02:00
Nicolas Chaulet
09badb9e60
[IngestManager] Remove ingest manager and endpoint from 7.7 (#61911) 2020-04-02 08:29:42 -04:00
Walter Rafelsberger
2bc83b1cf4
[ML] Clear Kibana index pattern cache on creation or form reset. (#62184) (#62284)
Clears the Kibana index pattern cache ...
- when reopening the "Create Analytics job" flyout
- after creating a transform or analyticsjob (this fixes moving from transforms to discover after creating a transform)
2020-04-02 13:53:28 +02:00
Mike Côté
24fbd5534b
Use new grantAPIKeyAsInternalUser and invalidateAPIKeyAsInternalUser APIs from the security plugin (#60967) (#61449)
* Use new grantAPIKeyAsInternalUser and invalidateAPIKeyAsInternalUser APIs from the security plugin

* Update x-pack/plugins/alerting/server/alerts_client_factory.ts

Co-Authored-By: Patrick Mueller <pmuellr@gmail.com>

* ESLint fixes

* Temp test using unverified snapshot

* Revert "Temp test using unverified snapshot"

This reverts commit a39499bed3.

Co-authored-by: Patrick Mueller <pmuellr@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Patrick Mueller <pmuellr@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-02 07:31:46 -04:00
Marta Bondyra
eebde26bd1
[7.7] [HomeApp] Set breadcrumbs when coming back from add data… (#62275) 2020-04-02 13:18:54 +02:00
Marta Bondyra
ca882344a6
[7.7] [Lens] fix error for minInterval>computedInterval for XY… (#62261) 2020-04-02 11:08:55 +02:00
Shahzad
866dc65d85
[Uptime] Update heartbeat index name for 7.7 (#62172)
* update index name

* update test
2020-04-02 08:25:03 +02:00
Lukas Olson
ba395d3382
Remove polling delay (#62248) 2020-04-01 17:48:18 -07:00
Tyler Smalley
294c8d74f5
[ML] Functional API test - disable mml value check (#61446) (#62233)
This PR re-activates the model memory estimation endpoint test and disabled the response value check.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2020-04-01 15:40:03 -07:00
Lukas Olson
5e73654858
[7.7] Rename async search params (#61641) (#61917)
* Rename async search params (#61641)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Remove polling delay

* Fix merge issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza Katz <lizka.k@gmail.com>
2020-04-01 15:26:55 -07:00
Oliver Gupte
878a69d984
Closes #60173 by turning off client caching for the main service map API call (#62111) (#62213) 2020-04-01 14:06:38 -07:00
Aleh Zasypkin
5ec514d194
[7.7] Document new xpack.security.authc.* settings and related 8.0.0 breaking changes. (#62179) 2020-04-01 22:57:52 +02:00