Commit graph

67408 commits

Author SHA1 Message Date
Lisa Cawley
82024c240a
[OAS] Add defaultModel to generative AI connector (#166394) 2023-09-20 11:39:08 -07:00
Paul Tavares
807856abd2
[Security Solution][Endpoint] Combine the Endpoint management cypress test suites into a single configuration/run (#166757)
## Summary

- Combines the `endpoint` and `mocked_data` tests suites so that they
run from the same cypress configuration/run buildkite setup
- Moved test files from the `endpoint/` and `mocked_data/` directories
into new sub-directories that more closely describe the set of tests
they contain
- The `security_solution/package.json` file was updated so that the
following `scripts` will now output a warning indicating that command is
no longer valid:
    - `cypress:dw:endpoint`
    - `cypress:dw:endpoint:run`
    - `cypress:dw:endpoint:open`


The following npm/yarn commands remain available for running tests
locally:

```shell
yarn --cwd=x-pack/plugins/security_solution cypress:dw:open
``` 

```shell
yarn --cwd=x-pack/plugins/security_solution cypress:dw:run
```


New test file struncture:

<img width="415" alt="image"
src="0cb4bc76-b434-4219-b73e-508645201a81">
2023-09-20 14:38:29 -04:00
Jeramy Soucy
61bad62aaa
Upgrade graphql 16.6.0→16.8.1 (#166779)
## Summary

Upgrades `graphql` from v16.6.1 to v16.8.1
2023-09-20 13:54:08 -04:00
mohamedhamed-ahmed
3d58a1da64
[Log Explorer] Add Explorer app locator (#165962)
closes https://github.com/elastic/kibana/issues/164995
closes https://github.com/elastic/kibana/issues/165618
closes https://github.com/elastic/kibana/issues/166596

## 📝  Summary

### Observability Log Explorer Locators:

This PR adds 2 new customized locators to the Observability log explorer
profile. At the moment we implemented:

       1- Single dataset selector locator
       2- All dataset selector locator

With more locators to come in the future depending on the use cases.

### Log Explorer Locators:

We also added a log explorer locator that navigates to discover, this
can be used in case the **Observability Log Explorer** plugin is
disabled.

### Logs Onboarding:

The PR also replaces the temp navigation to the default discover we
implemented for[ 8.10
here](https://github.com/elastic/kibana/pull/163218) with the above new
Observability Log Explorer locators.

### APM:

After [disabling infra plugin in serverless
projects](https://github.com/elastic/kibana/pull/165289), APM links to
infra locators in serverless have been replaced to use the above
locators.

### Observability Landing Page:

The landing page now redirects to the Log Explorer if `logs-*-*` has
data in it, otherwise the flow continues as before.

### Necessary Refactoring:

To avoid the circular dependency between `ObservabilityLogExplorer` &
`ObservabilityOnboarding` after each one using the other's locator and
importing the necessary types, I moved the type definition for all
locators in the `deeplinks` package.

##   Testing

- Onboarding Wizard in Serverless and Stateful

    1. Navigate to the onboarding flow `/app/observabilityOnboarding/`
    2. Choose either System logs or Stream log files
    3. Go through the onboarding wizard
    4. Click the Explore logs button at the end
5. You should be redirected to observability log explorer with the
integration and dataset preselected.

- APM links in Serverless

1. Navigate to APM and click on the logs links as shown in the Demos
below
2. All links should navigate to Observability Log Explorer with the
queries set in the search bar.

## 🎥 Demos

- APM Serverless


7161364e-333f-4ac4-87d5-7f1ffec699b3


- APM Stateful


058c9587-b766-4d4f-a73d-50fd381be4bb


- Onboarding Serverless



ee1cab42-f91c-4558-aa5f-4fa7e8963427

- Onboarding Stateful



a376a12b-499b-4488-a75a-d06e81f8e21d

- Observability Landing Page 



c1c084ca-b1b1-4c4b-a4e6-ae8e157dcf57

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
2023-09-20 19:49:57 +02:00
Kibana Machine
f6084a5d1b skip failing test suite (#166838) 2023-09-20 13:23:57 -04:00
James Rodewig
72c06cf505
[DOCS] Fix title casing in release notes (#166661)
**Problem:** Several headings in the release notes use title case (Example: "Bug Fixes"). Elastic uses sentence case for headings.

**Solution:** Update release note headings to use sentence case.
2023-09-20 13:16:16 -04:00
Kibana Machine
ed0aadd14e skip failing test suite (#75963) 2023-09-20 13:00:43 -04:00
Joey F. Poon
4bb8f1b903
[Security Solution] add usage record lookback limit (#166711) 2023-09-20 09:56:18 -07:00
Kibana Machine
99bcccea87 skip failing test suite (#60194) 2023-09-20 12:43:38 -04:00
Paul Tavares
23b2f3b080
[Security Solution][Endpoint] Move endpoint management serverless specific tests (#166669)
## Summary


- Moves the Serverless Endpoint Management tests from
`x-pack/test_serverless/functional/test_suites/security/cypress` to
`x-pack/plugins/security_solution/public/management/cypress` along with
its set of supporting `screens` and `task`'s
- This work is in preparation for enabling tests to be run in a
serverless environment

>   NOTE
> Tests for serverless are not currently running. The kibana core team
is working on providing serverless users that have serverless security
roles assigned to them for testing. Also, an effort in underway to also
use a tagging approach to define which existing tests should run in
serverless.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-09-20 09:28:10 -07:00
Lisa Cawley
3f3a27b20a
[DOCS] Move preconfigured generative AI connector details (#165418) 2023-09-20 09:22:28 -07:00
Shahzad
010f585996
[Synthetics] Update package to 1.0.7 (#166822) 2023-09-20 18:15:18 +02:00
Dzmitry Lemechko
a31cc1fee0
[ftr] load the minimum required scope of services in serverless (#165887)
## Summary

We try to reuse existing FTR services for serverless test as much as
possible. Most of the services are deployment agnostic, however some
won't work on serverless and we add its own serverless implementation.

Currently we import all the services from api integration tests directly
into the serverless services. The same with functional ones. This PR
loads the minimum required services for api integration and functional
tests respectively.
This way we can control which services are deployment agnostic and
explicitly remove any of it when we decide to have its own
implementation for serverless.
2023-09-20 17:37:50 +02:00
Cauê Marcondes
7e25900bc5
[Profiling-APM] Service Profiling Top 10 Functions (#166226)
- Move logic to fetch the TopN functions to
'profiling-data-access-plugin'
- Create new TopN functions embeddable
- Refactor Universal profiling page on APM adding Tabs (Flamegraph | Top
10 functions)
- Create a new API on APM to fetch Top functions

<img width="1605" alt="Screenshot 2023-09-08 at 11 14 13"
src="76fc7bf3-094b-438b-99b8-3cab01539eb4">
<img width="1615" alt="Screenshot 2023-09-08 at 11 14 20"
src="c4d3e97a-eee0-4829-8d6f-545f9c844b18">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joseph Crail <joseph.crail@elastic.co>
2023-09-20 08:35:19 -07:00
Carlos Crespo
d0b759a47a
[Infra UI] Reorganize lens related types (#166285)
part of: https://github.com/elastic/kibana/issues/165825

## Summary

While working on https://github.com/elastic/kibana/pull/166276 I noticed
that some lens types could be reorganized. This PR is for that.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-09-20 17:12:52 +02:00
Ignacio Rivas
d1608f070d
[Index Management] Add support for enrich policies (#164080) 2023-09-20 17:03:42 +02:00
Nicolas Chaulet
e02c8740ec
[Fleet] Support registry filtering with spec.min and spec.max (#166733) 2023-09-20 10:59:19 -04:00
Kibana Machine
82306ea110 skip failing test suite (#166677) 2023-09-20 10:23:42 -04:00
Aurélien FOUCRET
c12276d836
Renaming the esre application into ai_search (#166632) 2023-09-20 16:22:49 +02:00
Maxim Palenov
bd5e15c22c
[Security Solution] Extend Flaky runner 's config to run Serverless Cypress tests (#166783)
## Summary

This PR extends Flaky test runner's config to be able to run Serverless Cypress tests.

[Serverless Security Solution Flaky test run](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3189)
2023-09-20 07:09:32 -07:00
Ying Mao
d3a289a607
[Response Ops][Alerting] SLIs Phase 2 - Histogram for task overdue by (#166643)
Towards https://github.com/elastic/response-ops-team/issues/130

## Summary

This implements the third of 3 SLIs described in
https://github.com/elastic/response-ops-team/issues/130 - the histogram
for tracking task overdue time in seconds. We bucket up to 30 minutes.
This implementation is slightly different than what was originally
described for this SLI, which was number of overdue tasks. We changed to
track a histogram of number of seconds overdue because this will provide
a better metric against which to set an SLO.

## To Verify

Run Kibana and create some alerting rules. Navigate to
https://localhost:5601/api/task_manager/metrics?reset=false and you
should see that the new metric under `task_overdue.value`. There should
be an overall task delay histogram and a histogram for each task type,
with groupings for the alerting and action task types

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-09-20 09:42:45 -04:00
mohamedhamed-ahmed
27056ca66c
[Log Explorer] Show only dataset name in dataset selector (#166703)
closes https://github.com/elastic/kibana/issues/166247

## 📝  Summary

This PR changes the display of datasets in the dataset selector so that
we only show the dataset name and not the whole index pattern.

ex: 

- `logs-foo-*` ➡️ `foo`
- `logs-bar-*` ➡️ `bar`

##   Testing
1. Navigate to the observability log explorer
2. Click the dataset selector and choose Uncategorized
3. Observe how the datasets are represented

## 🎥 Demo


8a6a1212-46d5-4ceb-bf38-cf13d1b3e555
2023-09-20 15:34:53 +02:00
Yngrid Coello
50bef40a1f
[Logs onboarding] landing page title (#166791)
changing the title from `Get started with observability` to `Collect and
analyze logs`.
2023-09-20 06:31:19 -07:00
Sander Philipse
af9271557f
[Search] Fix user name in welcome banner (#166814)
## Summary

This fixes an issue with the welcome banner in Search.
2023-09-20 06:25:45 -07:00
Tomasz Ciecierski
4327248030
[EDR Workflows] Fix osquery test (#166819) 2023-09-20 06:20:24 -07:00
Kibana Machine
ddfc066856 skip failing test suite (#157589) 2023-09-20 09:08:49 -04:00
Cee Chen
102dbe209f
Upgrade EUI to v88.3.0 (#166676)
⚠️ NOTE: This PR is a copy of #166292 (which was reverted due to failing
Storybook builds). This is the same exact PR but with Storybook building
fixed.

---

EUI `88.2.0` ➡️ `88.3.0`

## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0)

- `EuiGlobalToastList` now shows a "Clear all" button by default once
above a certain number of toasts (defaults to 3). This threshold is
configurable with the `showClearAllButtonAt` prop
([#7111](https://github.com/elastic/eui/pull/7111))
- Added an optional `onClearAllToasts` callback to `EuiGlobalToastList`
([#7111](https://github.com/elastic/eui/pull/7111))
- Added the `value`, `onChange`, and `onCancel` props that allow
`EuiInlineEdit` to be used as a controlled component
([#7157](https://github.com/elastic/eui/pull/7157))
- Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`,
`transitionTopIn`, and `transitionTopOut` icon glyphs.
([#7168](https://github.com/elastic/eui/pull/7168))

**Bug fixes**

- Fixed `EuiInlineEdit` components to correctly spread `...rest`
attributes to the parent wrapper
([#7157](https://github.com/elastic/eui/pull/7157))
- Fixed `EuiListGroupItem` to correctly render the `extraAction` button
when `showToolTip` is also passed
([#7159](https://github.com/elastic/eui/pull/7159))

**Dependency updates**

- Updated `@hello-pangea/dnd` to v16.3.0
([#7125](https://github.com/elastic/eui/pull/7125))
- Updated `@types/lodash` to v4.14.198
([#7126](https://github.com/elastic/eui/pull/7126))

**Accessibility**

- `EuiAccordion` now correctly respects reduced motion settings
([#7161](https://github.com/elastic/eui/pull/7161))
- `EuiAccordion` now shows a focus outline to keyboard users around its
revealed children on open
([#7161](https://github.com/elastic/eui/pull/7161))

**CSS-in-JS conversions**

- Converted `EuiSplitPanel` to Emotion
([#7172](https://github.com/elastic/eui/pull/7172))

---------

Co-authored-by: Bree Hall <briannajdhall@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
2023-09-20 08:03:02 -05:00
jennypavlova
0d18be6356
[Infra] Reset error state in useHTTPRequest hook (#166752)
Closes #166748 
## Summary

This PR fixes an issue with the error state - when there is a successful
request after a failed request the error state was still visible.

### Before

0cb15cab-dc7c-48ad-b080-179f0444284d

### After


e765b5e9-d213-45da-968f-257955b1f4b0
2023-09-20 14:56:04 +02:00
Ignacio Rivas
0ba75eec8a
[Index Management] Fix flaky tests (#166221) 2023-09-20 14:40:10 +02:00
Mykola Harmash
8dd4323d6c
[Flaky test] Add missing await in infrastructure_security test suite (#166721)
Fixes #164250 

[Successful pipeline in the flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3191).

@crespocarlos spotted the missing `await` that might cause the
`infrastructure_security` suite to still be running along
`infrastructure_spaces` and cause race conditions.
2023-09-20 14:26:26 +02:00
Stratoula Kalafateli
8b215485f9
[Lens] Fixes edit configuration flyout display (#165675)
## Summary


Fixes a problem on the flyout ui (the black line on the right). I dont
think that this line is useful. Vertical scrolling works fine.

**Before**

<img width="1435" alt="image"
src="56868893-2aad-4118-a5c6-245b1111b735">


**Now**

<img width="1356" alt="image"
src="0f2d0e87-d60d-4507-8d68-accc0ba840ed">
2023-09-20 04:34:37 -07:00
David Sánchez
8f89c405df
[Fleet][Agent tamper] Adds test case for uninstall tokens when policies are removed (#166701)
## Summary

- Adds Cypress test case for uninstall tokens when policies are removed.
2023-09-20 13:16:10 +02:00
Sander Philipse
72b1d3236a
[Serverless Search] Adds icons and category for Serverless Search pages (#166726)
## Summary

This fixes the icon and category being missing for top level search
results for Serverless Search pages.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-09-20 03:45:48 -07:00
Gergő Ábrahám
aa36fe67ae
[Defend Workflows] Add tags for mocked and real Endpoint Cypress tests for Serverless (#165094)
## Summary

- introduces tags for [Defend Workflows] cypress tests (similarly to
https://github.com/elastic/kibana/pull/162698)
- adds scripts to Security Solution:
  - `cypress:dw:serverless:open` and `:run`
  - `cypress:dw:endpoint:serverless:open` and `:run`
- adds CI jobs to run these scripts
- so far most of the expected tests got both `@serverless` and
`@brokenInServerless` tests, because of other issues to be solved,
- one test is able to run against serverless:
`x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/policy_details.cy.ts`
2023-09-20 10:36:11 +02:00
jennypavlova
4270c5e031
[Infra UI] Only refresh the metadata section not the whole page when retrying metadata fetch (#166351)
Closes #161367
## Summary

This PR changes the metadata error callout to re-fetch the metadata
instead of reloading the whole page. As the components are now used also
in the asset details view refreshing the flyout won't be needed - as
also it won't help the user if we fetch other data again when the
metadata is missing. The current logic will make the request to the
metadata again in case of an error. This way the other content will stay
the same as we don't need to reload the whole flyout/tab in case the
metadata request fails

## Testing
I couldn't find a good way to 'fake' the error happening only once ( and
getting a result after the refetch) I did 2 things trying to simulate
the behavior (not ideal but it's fine for checking the cases)

1. Change the [metadata endpoint
name](https://github.com/elastic/kibana/blob/main/x-pack/plugins/infra/public/components/asset_details/hooks/use_metadata.ts/#L32C8-L32C8)
(to metadataaa for example) to cause 404 error (or comment the parameter
to get 500)
 - Check the error callout
 


fbf833c7-2f94-4027-bf58-3dbc8d95a090

2. Change the metadata hook to send an error initially and to get the
actual metadata error value when the re-fetch is triggered:
 
<img width="808" alt="fake_error"
src="b81c3c98-d957-4c0b-8f2e-676c26a0e916">



d65f5c3e-9d81-4fec-a0bf-338ef50ca7db
2023-09-20 10:21:50 +02:00
Marco Antonio Ghiani
f1ed91431a
[Logs Shared] Disable log view saved object registration for serverless (#165243)
## 📓 Summary

Closes #165222 

This work intends to avoid the registration of the log view saved object
(`type: "infrastructure-monitoring-log-view"`) and the related endpoint
to update a persisted log view.
To achieve it, the `xpack.logs_shared.savedObjects.logView.enabled`
configuration is introduced, which is configurable only in a serverless
environment and defaults to `true` for the stateful Kibana version to
keep the existing behaviour unchanged.

To also guarantee the normal functioning of the consumers of the
`<LogStream />` component in a serverless environment, we now set an
internal view using the default configuration that will be used as a
fallback when skipping the persisted log view lookup.

## 🧪 Testing

### Normal behaviour

When Kibana is used as always, we want to keep the current behaviour and
retrieve the persisted log view if exists or default to an internally
defined one.
- Launch the Kibana dev environment with `yarn start`
- Navigate to APM/Fleet/Enterprise Search logs
- Verify all the usages of the `<LogStream />` component work correctly
retrieving the internal views set during the setup lifecycle of the
related plugin. This means the LogStream should render the appropriate
columns set for the default log view or apply the custom ones defined
with an internal log view.

### Serverless behaviour

When Kibana is used in serverless mode, we want to skip the lookup for
the log view saved object and directly retrieve the log view from the
internally defined ones.
- Launch the Kibana dev environment with `yarn serverless-oblt`
- Navigate to APM/Fleet/Enterprise Search logs
- Verify all the usages of the `<LogStream />` component work correctly
retrieving the internal views set during the setup lifecycle of the
related plugin.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
2023-09-20 10:13:40 +02:00
Chris Cowan
ca1df9ec4f
[AO] Fix custom equations to support repeating the same variable (#166482)
## Summary

This PR fixes #166476 by fixing a bug where you can't repeat a variable
twice in the equation. This PR changes the code that converts the
variables from `A` to `params.A` by changing a `replace` to a
`replaceAll`.

The work around would be to duplicate the aggregation that needs to be
repeated so it has a unique variable name.

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-09-20 10:02:02 +02:00
Drew Tate
172de682c5
[Event annotations] Individual annotation editing from library (#163346)
## Summary

Resolve https://github.com/elastic/kibana/issues/158774
Part of https://github.com/elastic/kibana/issues/159053

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 25 PM"
src="69cfe07e-d442-462b-91c5-395d6040c383">

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 09 PM"
src="260aedbe-31d0-415a-b387-10a9b13bf9a6">

<img width="1920" alt="Screenshot 2023-09-13 at 2 01 07 PM"
src="9672010b-d49b-4041-acf1-33d3baec1e9a">


### Known issues
- [ ] ~Responsive layout~ **Proposal:** don't optimize for mobile
- [x] Recovering embeddable from problematic data view state
- [x] margin around dimension buttons
- [x] Functional test coverage

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2023-09-20 10:09:17 +03:00
Carlos Crespo
f94b4c2755
[Infra UI] Add kubernetes charts to the host detail view (#166383)
closes https://github.com/elastic/kibana/issues/162944
## Summary

This PR adds the Kubernetes Overview section to the Host Detail view.

**Old view**
<img width="778" alt="image"
src="2c6c3341-7aa3-48e4-a5d5-e9580b2e2c13">

**New view**
<img width="778" alt="image"
src="357ef56d-b783-41ed-8d7f-e9a3369d13b0">

There was some reog in the formulas folder too, separating nginx and
kubernetes from hosts formulas.

### How to test

- Start a local Kibana pointing to a oblt cluster
- Navigate to `Infrastructure` > `Hosts`
- Click on a `gke` host to navigate to the detail view
2023-09-20 08:51:15 +02:00
Kibana Machine
1de39176f6
[api-docs] 2023-09-20 Daily api_docs build (#166786)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/466
2023-09-20 01:05:29 -04:00
Garrett Spong
f5b09864b8
[Security Solution][Elastic AI Assistant] Adds Knowledge Base (#166570)
## Summary

Advanced Settings to enable the Knowledge Base is currently behind the
same code toggle introduced in
https://github.com/elastic/kibana/pull/164908, please modify
`assistantLangChain` to be `true` to enable the Advanced Settings and
Knowledge Base options:


1dee16e061/x-pack/plugins/security_solution/public/assistant/provider.tsx (L55)

When the above modification is present, a new `Advanced Settings` UI is
available within the Assistant that enables the ability to turn on and
configure the Knowledge Base, and also add the requisite `ES|QL`
Knowledge Base resources.

<p align="center">
<img width="500"
src="3abab422-9a85-45f6-8b0b-854ed7383d1c"
/>
</p> 

Once enabled, the Assistant will query the Knowledge Base using a
`ConversationalRetrievalQAChain`, by means of the ELSER specific
`ElasticsearchStore` LangChain `VectorStore` abstraction:


<p align="center">
<img width="500"
src="a529faab-948c-40f1-bc11-7a39b1766c7f"
/>
</p> 



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
  * TBD
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-09-19 18:53:41 -06:00
Davis McPhee
8e800eec5a
[Search] Unskip partial results Serverless tests (#166410)
## Summary

This PR unskips the partial results Serverless tests. I ran 100x flaky
test runs against each project type to confirm they should no longer be
flaky.

Flaky test runs:
- x100 (`.only`):
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3114
- x100 Search:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3121
- x100 O11y:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3147
- x100 Security:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3156

Resolves #165563.
Resolves #165612.
Resolves #165763.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-09-19 21:04:27 -03:00
Melissa Alvarez
e5cd6fb493
[ML] Data Frame Analytics Trained models: add ability to reindex after pipeline creation success (#166312)
## Summary

Related issue: https://github.com/elastic/kibana/issues/164997

In the Trained Models list 'Deploy Model' flyout for DFA models:
- adds the ability to reindex in the last step of the flyout after
pipeline creation success

<img width="1343" alt="image"
src="ae76fb04-889c-45da-a9c0-394b5cd039c2">

<img width="1206" alt="image"
src="39bee9b1-338b-4b5b-a295-789363f6d387">

<img width="1107" alt="image"
src="aa98ff65-1b37-46a4-b411-4adb3fe9df17">

<img width="1216" alt="image"
src="2e7c4930-1036-415e-8d27-19f7e6012701">

<img width="1343" alt="image"
src="3654cc6f-4113-44cc-86ab-93dbdf49a9a9">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-09-19 16:55:34 -06:00
Davis McPhee
2234237cd4
[Field Formats] Unskip field formats Serverless tests (#166409)
## Summary

This PR unskips the field formats Serverless tests. I ran 100x flaky
test runs against each project type to confirm they should no longer be
flaky.

Flaky test runs:
- x100 (`.only`):
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3113
- x100 Search:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3120
- x100 O11y:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3146
- x100 Security:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3155

Resolves #165537.
Resolves #165545.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-09-19 19:23:22 -03:00
christineweng
55d9058a04
[Security Solution] Unskip some timeline cypress tests (#165161)
## Summary

This PR unskipped some tests that were skipped in
https://github.com/elastic/kibana/issues/163398.

Some timeline tests began to fail due to chromium crashed after
upgrading to chrome v115. Further upgrades to chrome v116 did not
resolve the crash. I was able to isolate the crash to be note related
actions within timeline. This PR unskipped tests unrelated to notes and
seem to run fine.
2023-09-19 15:52:12 -05:00
Catherine Liu
94587c9a13
[Canvas] Fix flaky test failures when navigating to Canvas app (#164376)
## Summary

Closes https://github.com/elastic/kibana/issues/163303.
Closes https://github.com/elastic/kibana/issues/163368.
Closes #163903.

This fixes a rarely occurring flaky test failure while navigating to the
Canvas app where the `currentURL` check fails. The cause is
`navigateToApp` goes to `app/canvas#/` which includes a hash get
redirected by the Canvas app to `app/canvas/`, and fails when
`app/canvas/` doesn't match `app/canvas#/`. I've chosen to disable this
check when navigating to Canvas to avoid this flakiness because I
couldn't remove the hash from the URL while using `navigateToApp` or
`navigateToURL`.

Instead of checking the URLs match, I opted to check that the workpad
listing page loaded correctly.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-09-19 13:10:36 -07:00
Jonathan Budzenski
dc34810aff skip failing test suite (#166770) 2023-09-19 14:26:44 -05:00
Lisa Cawley
a3a2f402fe
[DOCS] Move preconfigured Swimlane connector details (#163547) 2023-09-19 11:31:22 -07:00
Lisa Cawley
fe4c76e326
Update transforms.alertingRules documentation link (#166758) 2023-09-19 11:29:07 -07:00
Jon
b21e7763f0
Update CODEOWNERS (#166462) 2023-09-19 13:38:50 -04:00