Commit graph

64266 commits

Author SHA1 Message Date
Carlos Crespo
e7c7445d0f
[Infrastructure UI] Metrics explanation tooltips (#159941)
## Summary

This PR adds better tooltip content to the KPI tiles and table columns.
It also adds links to hosts metrics documentation


![image](3df60a99-32c0-4e08-9a84-e489db2d53fc)

The formulas displayed on the tooltips/popovers are the same ones used
in the Lens charts. Even though the table content executes a query in
elasticsearch, with pipeline aggregations, they can be translated into
the equivalent Lens formulas.

### How to test this PR

- Start a local kibana instance
- Navigate to `Inventory > Hosts`
- Click on `What are these metrics?` links, they should redirect to
https://www.elastic.co/guide/en/observability/current/host-metrics.html
- Hover over the KPI tiles and verify their content
- Click on `?` icons next to the table column label and verify their
content
  - Clicking on `?` icon must not sort the table
2023-06-20 15:33:18 +02:00
James Gowdy
ca0b7395fb
[ML] File data visualizer moving import buttons (#159722)
Relates to https://github.com/elastic/kibana/issues/112285

Removes the black bar at the bottom of the app which housed the import
and cancel buttons.

Rather than having a button called "Change import settings" I've left
this as the "Back" button. "Change import settings" isn't really a
correct description of the page the button returns you to. Something
like "Rerun analysis of the already selected file" would be accurate,
but that is too long for a button.

@mdefazio Does this look ok? Any other suggestions? Note, I'd like to
keep this PR small, the main aim was just to remove the black bar at the
bottom of the page and change the name of the Cancel button after the
import has already run.


![image](9fc77009-6690-4a6f-9845-800d2486da23)



![image](f986d0dd-1f3a-4cda-b715-e7a1a56e8cb6)



![image](c24c9358-fa36-4e78-b5df-216c0dd3e734)
2023-06-20 14:25:48 +01:00
Tim Grein
610f3a7f49
[Enterprise Search] Prefix target index for access control syncs with "search-acl-filter-" (#159996)
## Summary

Closes https://github.com/elastic/enterprise-search-team/issues/4979

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-06-20 06:16:26 -07:00
Nicolas Chaulet
bd0e09504c
[Fleet] Fix navigation from multi page layout (#159967) 2023-06-20 09:11:56 -04:00
Stratoula Kalafateli
c0e43dbf28
[Lens][Visualize] Removes wrong padding on the dashboard (#159992)
## Summary

Closes https://github.com/elastic/kibana/issues/159942

If the height of a partition chart exceeds 1000px paddings are added,
reducing the chart size.
This is caused due to this piece of code
https://github.com/elastic/kibana/pull/122420

This was added for the aggbased editor to reduce a bit the pie size
(otherwise it was taking the full container size and the pie was huge)

Although we want this, we don't want this to be applied in dashboards or
lens editor. This PR is fixing this by adding the paddings only on the
agg based editor level

In agg based editor
<img width="651" alt="image"
src="48ac6fdd-43e3-46f5-8818-d40334678fce">

Dashboard with very tall treemap, no paddings
<img width="933" alt="image"
src="8787d6ab-887c-4c8d-8419-2c2d5659f2c1">



### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-06-20 16:02:48 +03:00
Gergő Ábrahám
66e87e63e9
[Fleet][Agent Tampering] Remove unused created_at field from uninstall token SO mapping (#159985)
## Summary

`created_at` field was added to the mapping for the uninstall token
Saved Object, but it's not used and causes trouble.
~There is a discussion whether to remove it from the mapping or not,
before the recently added mapping itself is released with v8.9.0, so I
prepared this PR to merge in case we want to remove it.~ The discussion
ended with the decision to remove the field, so the aim is to merge this
PR.
2023-06-20 14:54:26 +02:00
Carlos Crespo
ee6f0f773f
[Infrastructure UI] Propagate Kibana version to hosts view feedback form (#159210)
closes:
[#1053](https://github.com/elastic/obs-infraobs-team/issues/1053)
## Summary

This PR changes the Hosts View feedback button to pass also the current
Kibana version.

<img width="716" alt="image"
src="9089d2c3-590c-46c2-89ce-c6bd7bd42a6b">

The URL is no longer a shortened one, and that's because it wasn't
forwarding query parameters.


### How to test
- Start a local Kibana
- Navigate to `Infrastructure > Hosts`
- Click on "Tell us what you think" button
- On the forms, the question "What version of Elastic are you using?"
should be filled automatically with the Kibana version

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 14:20:18 +02:00
mohamedhamed-ahmed
3a34200afd
[Infra UI] Add 'host.name' field view for 'Logs' tab (#159561)
closes #159560 

## 📝  Summary

This PR adds an inline view for the logs tab in the Hosts view, where
the `host.name` column is statically added to the columns definition.

##   Testing

1. Navigate to Stream page
2. Change the settings to have any Date Source and columns
3. Navigate to the logs tab in the Hosts view
4. Verify that the columns applied in step 2 aren't showing in the logs,
and that `host.name` is showing.
5. Click the open in logs link and make sure that the settings show the
host.name and notes an inline view is being used.



a19f7969-31b3-40af-9e07-784631d6292f
2023-06-20 13:16:39 +01:00
Dima Arnautov
6ac52fb9ec
[ML] Update the Overview page (#159609)
## Summary

Resolves https://github.com/elastic/kibana/issues/154294 and updates the
UI of the Overview page

- Updates panels layout 
- Stores expand/collapsed state of the panels in the local storage 
- Update empty states text and layout 

<img width="1341" alt="image"
src="8833fa2a-b574-44ee-bacb-e974186dd35f">


### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-06-20 13:56:00 +02:00
Kevin Delemme
12a2203d10
chore(slo): improve index selection (#159849)
## 📝  Summary

This PR changes the index selection component behaviours. We are
fetching the Data Views (limit to 10 at a time). The user can select one
of them, or search for other Data Views and index pattern that matches
at least on index.

Therefore the user can choose any Data Views matching a search, or the
index pattern derived from the search, if it matches at least one index.

| Screenshot |
| -- |
|
![image](ae0b1304-d701-4b17-823d-f0a727df65d6)
|
|
![image](187814bd-849e-4164-bb52-517d144507ad)
|
|
![image](3f1a2d3c-e9f2-4490-81ba-5d76e8d1cbb8)
|

## 🧪 Testing

1. **Create 11 data views or more**
Easiest method is to use curl with a POST on `/api/data_views/data_view`
with a random payload:
```
{
  "data_view": {
     "title": "{% uuid 'v4' %}-log*",
     "name": "{% uuid 'v4' %} "
  }
}
```

2. **Go to the SLO form and select custom KQL, then search for a data
view or another index pattern**
2023-06-20 07:43:53 -04:00
Kevin Delemme
3a34e3593d
feat(slo): Support for calendar aligned time window (#159949)
Resolves https://github.com/elastic/kibana/issues/159948

## 📝 Summary

This PR updates the SLO form to support the calendar aligned time
windows for both create and edit flow.
I've also moved the budgeting method selector down, so when selecting
"timeslices", the timeslices related inputs are shown next to it on the
same line.
 

| Screenshot | Screenshot |
|--------|--------| 
|
![screencapture-localhost-5601-kibana-app-observability-slos-edit-c1a51ac0-0eb0-11ee-8f7a-0da90ce06520-2023-06-19-11_53_05](9e786a17-ebce-43b5-b063-090fe89a1821)
|
![screencapture-localhost-5601-kibana-app-observability-slos-edit-c1a51ac0-0eb0-11ee-8f7a-0da90ce06520-2023-06-19-11_52_31](c3e7cab1-31c2-490b-b38f-6f7b01a3fc95)
|
2023-06-20 07:43:17 -04:00
Pierre Gayvallet
27df64c2bc
[EBT] Add page title to browser-side context (#159936)
## Summary

Part of https://github.com/elastic/kibana/issues/149249

Add a new EBT context providing the page_title field to events.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 04:31:25 -07:00
Yngrid Coello
06a00d6b59
[Logs onboarding] design feedback (#159790)
closes https://github.com/elastic/kibana/issues/159655.

- [x] Make sure inputs in configure logs step occupy the whole width
- [x] Fix copy button in apiKey callout, currently is cropped
- [x] Add space bellow action buttons (back and continue)

Apart from the tasks above, we are hiding `Give feedback` button from
plugin root page, since the form is dedicated to logs onboarding.



80872e8a-f239-4584-9b15-7ec8cdd32d5d
2023-06-20 13:23:47 +02:00
Shahzad
8d83f64383
[Synthetics] Add TLS Certificate expiry alert (#159697)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
2023-06-20 03:24:06 -07:00
Pierre Gayvallet
97dc2ecba1
[EBT] Add page url to browser-side context (#159916)
## Summary

Part of https://github.com/elastic/kibana/issues/149249

Add a new EBT context providing the `page_url` field to events.

`page_url` is based on the current url's `pathname` and `hash`
exclusively (no domain, port, query param...)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 03:13:29 -07:00
Maryam Saeidi
403b5d2fd5
[AO] Make spaces plugin optional (#159980)
## Summary

Based on this
[comment](https://github.com/elastic/kibana/pull/158657#discussion_r1233750595),
[spaces](https://github.com/elastic/kibana/issues/149687) should be an
optional plugin.
2023-06-20 12:06:21 +02:00
Antonio
43102291ce
[Cases] Add category field (#159890)
## Summary

This PR adds the category field in the UI. Specifically:

- Adds the ability to select or create a new category when creating a
case
- Adds the ability to select or create a new category when editing a
case
- Adds the ability to filter by multiple categories on the cases table
- Adds validation on the category field on the backend

Closes: https://github.com/elastic/kibana/issues/153835

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Release notes

Add a new field, called `category`, to categorize cases. Users can
create a new category, set or select an existing one on a case, and
filter by multiple categories on the cases table.

---------

Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2023-06-20 11:40:07 +02:00
Marta Bondyra
4a099e1590
[Lens] fix pie suggestions (#159902)
## Summary

Fixes https://github.com/elastic/kibana/issues/159711

When dragging a numeric field to a pie with a metric and a group already
defined, we add another metric even if `allowMultipleMetric` setting is
not set.
I fixed it by making it work the same way as a heatmap when the setting
is off - replacing metric instead. Not sure if that's a correct approach
though (should we block the suggestion whatsover?) but definitely an
improvement.

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2023-06-20 11:07:57 +02:00
Pierre Gayvallet
9e0c9a7ad5
/api/status - always return a consistent status code (#159768)
## Summary

Fix https://github.com/elastic/kibana/issues/158910

Changes the behavior of the `/api/status` endpoint to always returns a
consistent http status code, and in particular:
- during the preboot stage 
- when accessed by unauthenticated users and `status.allowAnonymous` is
`false`.

That way, `/api/status` can properly be used for readiness checks. 

Please refer to https://github.com/elastic/kibana/issues/158910 for more
details.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 02:06:40 -07:00
David Sánchez
cc04704cb5
[Fleet] Split bulk create artifact in small batch to prevent too big requests (#159187)
## Summary
Fixes: https://github.com/elastic/kibana/issues/158577

Introduces batching in the bulk create artifacts to prevent big bulk
requests. It takes artifact `encoded_size` as the artifact size to
determine the batch length.

The input and output of the existing function is the same, only the way
the bulk create operation is done has changed.

Introduces new fleet config value to change the create bulk batch size:
`createArtifactsBulkBatchSize`

It adds new unit test cases for the changes.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 10:51:05 +02:00
Kibana Machine
b88c11d708 skip failing test suite (#159929) 2023-06-20 04:40:47 -04:00
Stratoula Kalafateli
522110d7b9
[Lens] Use correct theme on save annotations modal (#159899)
## Summary

Closes https://github.com/elastic/kibana/issues/159688

It passes the theme on the kibanaThemeProvider to fix the dark mode
problem

<img width="972" alt="image"
src="df5a9fdc-9828-4f69-a712-4806f0a5455f">
2023-06-20 11:10:31 +03:00
Marta Bondyra
2fd8f04abe
[Lens] fix FieldPicker passes the prop to the DOM when it shouldn't (#159930)
## Summary

When opening the field picker, the error in the console appears:
<img width="837" alt="Screenshot 2023-06-19 at 15 45 39"
src="10fbc0e6-ae59-4c3b-ab94-80dd86805ca6">

That's because we pass `exists` props to the `styledOptions` which are
passed to the dom.
The thing is we don't need to pass this prop. We assign the classname
based on `exists` value at the same level and then do the styling but
then don't use it in any level deeper, so no need to pass it. So I
removed it to fix this error.

fixes errors that show in tests too:
<img width="605" alt="Screenshot 2023-06-19 at 20 54 58"
src="1583070f-8e18-4494-9892-585bef584588">
<img width="761" alt="Screenshot 2023-06-19 at 20 55 39"
src="23aab03b-0204-478b-aa01-fab801d02e78">
<img width="730" alt="Screenshot 2023-06-19 at 20 56 49"
src="cae606f5-54a8-4da9-99cf-e5151302acae">
2023-06-20 09:36:09 +02:00
Cristina Amico
58ec0a486f
Replace usage of public SO client with Fleet get Bulk Assets api (#159653)
Closes https://github.com/elastic/kibana/issues/158598

## Summary

Removes usage of deprecated SO client to fetch dashboard assets;
Replaced with a call to the new Fleet endpoint `epm/bulk_assets`
([openapi](https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/master/x-pack/plugins/fleet/common/openapi/bundled.json#/Elastic%20Package%20Manager%20(EPM)/bulk-get-assets))

## Testing

I'm not very familiar with stack monitoring, so I tried to reproduce
what's described in the
[PR](https://github.com/elastic/kibana/pull/149721) that originally
introduced this dashboard; I couldn't trigger the modal but I can see
the endpoint in the network requests:

<img width="3206" alt="Screenshot 2023-06-14 at 09 57 34"
src="b0ff5111-1b1d-42aa-9621-e61c37efedde">

It should be enough to test this change since is very small.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 09:22:40 +02:00
Nicolas Chaulet
2fe276e9cb
[Fleet] Fix usage of AsyncLocalStorage for audit log (#159807)
## Description 

Related to https://github.com/elastic/kibana/issues/158361 
Closes https://github.com/elastic/kibana/issues/158361
Closes https://github.com/elastic/kibana/issues/159762
When we introduced audit logging it seems we introduced a memory leak.

Comparing two heapdump after triggering ~6k request against Fleet we can
see that these AsyncLocalStorage object are never deleted

<img width="1307" alt="Screenshot 2023-06-15 at 9 04 13 AM"
src="7f4b0a7b-75a9-4c87-8fb9-cd539a2029e0">

That PR try fix that by using a single for `AsyncLocalStorage`

The call that create those `AsyncLocalStorage` is not conditional of
audit logging being enabled or not

## Tests

Testing that **PR** on cloud on a 1gb instance with the agent page open
(doing long polling) we can see it seems to improve the memory usage
(compared to the current 8.8.1 with an agent page open too **baseline**)

<img width="810" alt="Screenshot 2023-06-15 at 3 04 35 PM"
src="a392f734-2b91-48ac-a906-3a8e88e2b209">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 09:03:26 +02:00
Jordan
28a4760b92
[Cloud Security] removing created by from telemetry (#159934) 2023-06-20 09:00:59 +02:00
Nikita Indik
6ca5e59cb7
[Security Solution] Filter by rule execution status (last response) on Rule Management page (#159865)
**Resolves**: https://github.com/elastic/kibana/issues/138903

## Summary

Adds a dropdown that allows you to filter rules by their rule execution
status to the Rule Management page.

<img width="1583" alt="Screenshot 2023-06-16 at 16 34 23"
src="abc8234a-4c05-4195-bc15-86b76a108663">



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-06-19 23:40:21 -07:00
Kibana Machine
2312705d97
[api-docs] 2023-06-20 Daily api_docs build (#159973)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/374
2023-06-20 01:08:55 -04:00
Georgii Gorbachev
8fcf47553b
[Security Solution] Implement rule monitoring dashboard (#159875)
**Addresses:** https://github.com/elastic/security-team/issues/6032

## Summary

This PR adds a new `[Elastic Security] Detection rule monitoring` Kibana
dashboard and a new `POST /internal/detection_engine/health/_setup` API
endpoint.

## Dashboard

The dashboard can be helpful for monitoring the health and performance
of Security detection rules. Users of the dashboard must have read
access to the `.kibana-event-log-*` index. The dashboard is
automatically installed into the current Kibana space when a user visits
a page in Security Solution - similar to how we install the Fleet
package with prebuilt detection rules.

<img width="1791" alt="Kibana dashboards page"
src="92cb3c75-39ea-4069-b70f-8f531869edf7">

<img width="1775" alt="Security dashboards page"
src="3b27aeb6-2222-40fd-a453-c204fcee4f31">

![Rule monitoring dashboard
itself](755cc044-5613-4c78-b89f-2a9734ded76d)


## API endpoint

The PR also adds a new endpoint for setting up anything related to
monitoring rules and the health of the Detection Engine. If you call the
endpoint, it will install the new dashboard to the Default Kibana space:

```
POST /internal/detection_engine/health/_setup
```

In order to install the dashboard to a different Kibana space, you will
need to call it like that:

```
POST /s/<space-id>/internal/detection_engine/health/_setup
```

The user calling the endpoint must have access to Security Solution. No
additional privileges are required, because the endpoint installs the
dashboard on behalf of the internal user (`kibana_system`).

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
  - [ ] https://github.com/elastic/security-docs/issues/3478
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-06-19 20:57:21 -07:00
Jordan
03392ddc83
[Cloud Security][BUG] Uneditable policy name field (#159905) 2023-06-19 22:16:16 +03:00
Nikita Indik
c191104ba1
[Security Solution] Show rule actions on Rule Details page (#158189)
**Resolves: https://github.com/elastic/kibana/issues/154879**

## Summary

Adds a list of notification and response actions to the Rule Details
page.
<img width="1582" alt="Screenshot 2023-06-05 at 11 42 24"
src="afb749d4-734e-4049-bbe2-9168186c9863">



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-06-19 18:22:02 +02:00
Faisal Kanout
968d786760
[AO] Set Feature flag of the Log threshold alert detail page to ON by default (#159947)
## Summary

it fixes #159945


## Release note:
Introducing the Log threshold alert detail page, which provides more
information and context about the Logs threshold alert
2023-06-19 09:12:44 -07:00
Giorgos Bamparopoulos
043a1a5050
[Synthetics] Add a guided card for synthetics (#159863)
Adds a guided card for synthetics. Guided onboarding is only available
in cloud, so in order to test it locally you can add `xpack.cloud.id:
test` setting to your `kibana.dev.yml` file. You can find more
information in the [guided onboarding
docs](https://github.com/elastic/kibana/tree/main/src/plugins/guided_onboarding#development).


f146bc08-a1a4-4d4f-891b-574b71584eba

Part of https://github.com/elastic/kibana/issues/159562

---------

Co-authored-by: Casper Hübertz <casper@formgeist.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-19 17:02:57 +01:00
Paulo Henrique
0163bf3c49
[Cloud Security][Vulnerabilities] Resource page (#159873) 2023-06-19 08:44:44 -07:00
Bena Kansara
3849d1486b
Fix preview chart in APM Latency threshold rule (#158439)
Resolves the following for APM Latency threshold rule:
- https://github.com/elastic/kibana/issues/152218
- https://github.com/elastic/kibana/issues/155489

Improvements in the preview chart:
- Showing data grouped by selected group by fields
- Showing 5 groups from each bucket
- Showing last x units (minutes, hours, etc.) data
- Added loading indicator
- Showing tooltip
- Always showing legend
- Max Y is slightly higher than maximum of highest y value or threshold
- Adjusting chart to always show the threshold line
- Fixed
- When removing some fields like transaction type, transaction name,
chart showed no data
- Hiding a particular group (by clicking on legend item), readjusted max
Y value, but same was not reset to original when enabling the group back

### Before


03b77133-a131-4758-805b-2a9287fb7ff9

### After


5900b74e-ee26-4d1d-a3f4-a03333808075
2023-06-19 17:27:24 +02:00
Cauê Marcondes
ef3dba6327
[Profiling] uses apm server host from cloud on add data page (#159926)
Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
2023-06-19 08:19:04 -07:00
Tim Sullivan
acda8cf8b9
[Chrome Project Header] Fix side nav collapsed state toggle (#159850)
## Summary

Closes https://github.com/elastic/kibana/issues/159846

This PR restores this specific code to how it was previous to
09577fa0af

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
2023-06-19 07:47:14 -07:00
Tiago Costa
f4d71c2a5e
skip flaky suite (#148225) 2023-06-19 15:42:56 +01:00
Matthew Kime
9e74fcf896
[data / saved query] BWCA all the routes (#158790)
## Summary

All routes
- Use versioned router
- Moved to internal path
- Validate responses
- All responses are typed with response types, separate from internal
api types. This is to help prevent unacknowledged changes to the api.
- Version is included in all requests

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-06-19 07:34:57 -07:00
Maryam Saeidi
229e8ca808
[AO] Handle buildEsQuery error (such as leading wildcard) in status change (#159891)
Fixes #159079

## Summary

In the case of providing a wildcard in the search query, an error might
be generated depending on whether the related setting is enabled or not.
This PR tries to handle this error on the Alerts page for a better user
experience.

|Before|After|
|---|---|

|![image](cf74577e-10ab-4543-8135-f498dcc7cabf)|
2023-06-19 16:22:28 +02:00
Juan Pablo Djeredjian
2f0c12a00c
[Security Solution] Replace EUI filtering with custom in-memory filtering in Add Rules and Rule Upgrade tables (#159700)
## Summary

**1.** Replaces the EUI out-of-the-box filtering by rule name and tags
[used in the initial
implementation](https://github.com/elastic/kibana/pull/158450) with
custom in-memory filtering.

This aligns the look-and-feel of the Rules Management table with the new
Add Elastic Rules and Rule Upgrades table


![image](e4b01221-74c1-40e5-abf4-87344a080e5d)


![image](9684cee2-a2bf-4850-82e0-1d3679c55c99)


**2.** Adds a CTA in the Add Elastic RUles table when all rules have
been installed, that navigates the user back to the Rules Management
table.


![image](15825af2-005d-47c8-a2a6-97603ea32646)



### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)




### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-06-19 16:20:20 +02:00
Bena Kansara
6dbf5483cf
Fix preview chart in APM error rate and error count rules (#159544)
Resolves the following for APM Failed transaction rate and APM Error
count rules:
- https://github.com/elastic/kibana/issues/152218
- https://github.com/elastic/kibana/issues/155489

Improvements in the preview chart:
- Showing data grouped by selected group by fields
- Showing 5 groups from each bucket
- Showing last x units (minutes, hours, etc.) data
- Added loading indicator
- Showing tooltip
- Always showing legend
- Max Y is slightly higher than maximum of highest y value or threshold
- Adjusting chart to always show the threshold line
- Fixed
- When removing some fields like transaction type, transaction name,
chart showed no data
- Hiding a particular group (by clicking on legend item), readjusted max
Y value, but same was not reset to original when enabling the group back
2023-06-19 15:56:38 +02:00
Anton Dosov
cfa46e473a
[Drift] Revert adding Chat to Management (#159896)
## Summary

Partially revert https://github.com/elastic/kibana/pull/159121
Reverts adding Drift chat to management. Part of
https://github.com/elastic/kibana/issues/158835

We decided to revert to adding to management for now because we realized
that there are a lot of cases in the Management app when Drift Chat can
overlap buttons on the page 😢

Here are some examples: 

<img width="600" alt="Screenshot 2023-06-15 at 16 20 43"
src="980916dc-b463-45f4-b5c1-bdce9f3f8336">
<img width="600" alt="Screenshot 2023-06-15 at 16 20 43"
src="ec74332b-5c91-4175-bde6-8e736d8bb4fa">
<img width="600" alt="Screenshot 2023-06-15 at 16 20 50"
src="5753b05d-7abc-409f-9a06-9f19a910461a">
2023-06-19 06:39:16 -07:00
Cauê Marcondes
c87e4e983d
[Profiling] Making plugin Production ready (#159738)
This PR does:

- checks Kibana.spec file
- Checks server feature.ts
- Adds correct route access to APIs
- Removes unnecessary logs
- Removes collector and symbolized `secret_token` from config schema as
it won't be used
- Add README file

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-19 06:35:59 -07:00
Achyut Jhunjhunwala
88c2f02fca
[APM] Fix other bucket message and sorting (#159919)
## Summary

Related https://github.com/elastic/kibana/issues/157479

## Demo


abf20feb-6b74-4a9f-93d5-2aac7a4f10b1
2023-06-19 15:34:48 +02:00
Cauê Marcondes
101999841c
[Profiling] Fixing flyout value with prepend (#159920)
<img width="846" alt="Screenshot 2023-06-19 at 1 20 41 PM"
src="8953667e-5fba-4d68-9ffd-5e73c1cc22b8">
2023-06-19 06:26:50 -07:00
Lola
08539ce6e4
[Cloud Posture] Installation stats telemetry (#159855)
## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

Add `installations_stats` collector which includes the following fields.

The installation stats collector telemetry we used for cloud security
product adoption funnel.
The `installation stats` collector will identify the following:
- which cloud security integration is being installed ('cnvm', 'cspm,
'kspm')
- what deployment environment for cloud security integration( eks, aws,
gcp, ake, self_managed)
-  how many agents deployed per integration installation


1340eef2-7df3-46ee-8c6d-4e61af33289b



Here is the Telemetry Schema for Installation Stats

| Column | Data Type | Description |

|--------------------|--------------|-----------------------------------------------------------|
| package_policy_id | string | The ID of the package policy of
integration installed |
| feature | string | The feature integration(cnvm, cspm, kspm)
associated with the package policy |
| package_name | string | The name of the package associated with the
policy |
| package_version | string | The version of the package associated with
the policy which is cloud_security_posture |
| agent_policy_id |string | The ID of the agent policy linked to the
package policy |
| deployment_mode | string | The deployment mode for the kspm, cspm or
cvnm(eks, gcp, aws, self-managed) |
| created_at | string | The timestamp when the package policy was
created |
| created_by | string | The username of the creator of the package
policy |
| agent_count        |number |  count of agents          |
2023-06-19 16:03:36 +03:00
Sander Philipse
39494e38b4
[Enterprise Search] Fix spacing for category headers (#159914)
## Summary

Fixes some spacing issues with the category header.
2023-06-19 06:02:13 -07:00
Kevin Logan
3e61769cda
[Security Solution] Adds several new fields to allowed Exceptions for Endpoint (#159835)
## Summary

Adds the following new fields to allowed Exceptions for Endpoint after
customer and internal requests.

We can backport this to `8.8.2` in addition to shipping in `8.9.0`

```
  "process.args",
  "process.parent.args",
  "dns.question.type",
  "file.pe.Ext.dotnet",
  "file.pe.Ext.streams.hash.md5",
  "file.pe.Ext.streams.hash.sha256",
  "file.pe.Ext.sections.hash.sha256",
  "file.pe.Ext.sections.hash.md5",
  "file.pe.Ext.streams.name",
  "Effective_process.entity_id",
  "Effective_process.executable",
  "Effective_process.name",
  "Effective_process.pid"
```

See the Endpoint Exception builder below with the new fields available
for use.


![image](1bafd68b-3b35-4543-92cb-37d379801b92)


![image](ff582e63-f93b-42ce-b95e-13965f75098a)


![image](87e1b214-4a76-459c-800d-eb6877ed3b9a)
2023-06-19 08:58:08 -04:00
Cauê Marcondes
4a827e1142
[Profiling] Make item in the instruction api optional (#159701)
Both `collector` and `symbolizer` settings define these properties
optional, so I'm making then optional in the instruction API too.
2023-06-19 14:57:19 +02:00