Commit graph

16363 commits

Author SHA1 Message Date
Felix Stürmer
f17b1b8f1a
[6.x] Skip flaky discover test (#15412) (#15491) 2017-12-08 15:46:25 +01:00
Søren Louv-Jansen
2926aab61c
Bump backport dependency and add .backportrc.json (#15417) (#15488) 2017-12-08 11:16:29 +01:00
Spencer
4506917e43
[6.x] [dev/mocha/junit] report real skipped test count and errors from hooks (#15465) (#15475)
* [dev/mocha/junit] report real skipped test count and errors from hooks

* typo
2017-12-07 14:50:07 -07:00
Kim Joar Bekkelund
104c5519de
Normalize path separators when writing test entry file (#15473) (#15474) 2017-12-07 21:35:04 +01:00
Kim Joar Bekkelund
b3f76f64a2
Deprecate --plugin-dir option in cli (#15390) (#15467) 2017-12-07 03:56:23 +01:00
Nathan Reese
62576a7d52
Visualize listing page - show which column is currently sorted (#15435) (#15456)
* this.state.sortedColumn was getting set to an object instead of the sorted column name

* remove unused state field sortedColumnDirection
2017-12-06 10:00:35 -07:00
jimgoodwin
2268054953 6.0.1 release notes 2017-12-06 11:42:53 -05:00
jimgoodwin
ae724c886f Release notes for 6.0.1 2017-12-06 11:42:53 -05:00
Stacey Gammon
c40066ca35
Skip flaky dashboard panel tests (#15430) (#15433) 2017-12-06 10:20:14 -05:00
Peter Pisljar
da7772d760
fixing gauge update logic so it wont break tsvb (#15076) (#15449) 2017-12-06 16:05:30 +01:00
Brandon Kobel
7a998f4ab8
Hiding the experimental warning when we're being shared (#15431) (#15451) 2017-12-06 08:57:06 -05:00
Tim Roes
1eebb8daf6
Remove params from loader docs (#15445) (#15446) 2017-12-06 14:22:25 +01:00
Spencer
ea0139b56a
[6.x] [optimizer] extract plugin discovery (#14745) (#15443)
* [optimizer] extract plugin discovery (#14745)

* [plugins] extract plugin discover from the kibana server

* integrate plugin discovery module with server

* [pluginDiscovery] fully extend config before checking enabled status

* [pluginDiscovery] limit arbitrary defaults in PluginSpec

* [ui/navLink] fix tests

* [ui/injectedVars] fix tests

* [ui/app] fix tests

* [server/plugins] convert init to callPluginHook tests

* [build/verifyTranslations] update verify logic

* [pluginDiscovery] remove rx utils

* fix i18n transaltion key name

* [pluginDiscovery] do kibana version checks as a part of discovery

* [pluginDiscovery/createPacksInDirectory$] clarify error handling

* [eslint] fix lint errors

* [uiApp/modules] ensure load order matches master

* [uiBundle] use known uiExport type for providers

* [uiExports] use the `home` export type

* [uiExports] validate that all uiExport types are known

* [timelion] remove archaic/broken bwc check

* revert some stragler changes

* [pluginSpecs] reformat comments

* [uiBundle] rebel and use more fcb 😬

* correct comment

* [server/waitForPluginsInit] describe queues var

* [server/plugins] prevent multiple calls to next() by using single then()

* [uiApp] remove archaic deprecation warning

* [uiApp] tighten up tests

* [pluginDiscovery/errors] remove $ from symbol var

* [pluginDiscovery/reduceExportSpecs] update docs

* [pluginDiscovery/findPluginSpecs] rightVersion -> isRightVersion

* [pluginDiscovery/findPluginSpecs] fix typos

* [uiApps/getById] use Map() rather than memoize

* save

* [savedObjects/mappings] use uiExports.savedObjectMappings

* [server/mapping/indexMapping] update tests, addRootProperties method removed

* [uiExports] "embeddableHandlers" -> "embeddableFactories"

* [pluginDiscovery] fix pluralization of invalidVersionSpec$

* [pluginDiscover] add README

* [pluginDiscovery/reduceExportSpecs] don't ignore fasly spec values, just undefined

* [ui/exportTypes] use better reducer names

* [ui/uiExports] add README

* fix links

* [pluginDiscovery/readme] expand examples

* [pluginDiscovery/readme] clean up reduceExportSpecs() doc

* [ui/uiExports/readme] cleanup example

* [pluginDiscovery] remove needless use of lodash

* [pluginDiscovery/waitForComplete] use better name

* [pluginDiscovery/findPluginSpecs] use fixtures rather than core_plugins

* [pluginDiscovery/stubSchema] use deafult: false

* [plguinDiscovery/pluginConfig] add tests

* typo

* [uiExports/readme] fix link

* [pluginDiscovery/packAtPath] fail with InvalidPackError if path is not a string

* [pluginDiscovery/packAtPath] rely on error.code to detect missing package.json file

* [pluginDiscovery/packAtPath] only attempt to get pack when observable is subscribed

* [pluginDiscovery/packAtPath] add tests

* [pluginDiscovery/pluginPack] move absolute path checks into fs lib

* [pluginDiscovery/packsInDirectory] fix error type check

* [pluginDiscovery/pluginPack/tests] share some utils

* [pluginDiscovery/packsInDirectory] add tests

* [pluginDiscovery/pluginPack] only cast undefined to array

* [pluginDiscovery/pluginPack] add tests

* [pluginDiscovery/pluginSpec/isVersionCompatible] add tests

* [pluginDiscovery/InvalidPluginError] be less redundant

* [pluginDiscovery/pluginSpec] verify config service is passed to isEnabled()

* [pluginDiscovery/pluginSpec] add tests

* fix "existent" spelling

* [server/rootRedirect] fix root_redirect view location
2017-12-05 19:40:24 -07:00
Spencer
b4bd640a17
[6.x] [CI] Produce junit test reports (#15281) (#15437)
* [mocha] use custom reporter for legible results in jenkins

* [jest] use custom result processor for legible results in jenkins

* [karma] enable junit output on CI

* [mocha/junitReporter] accept rootDirectory as configuration

* [jest/reporter] use reporters option added in jest 20

* [toolingLog] remove black/white specific colors

* [dev/mocha/junit] no reason for junit to be a "reporter"

* typos

* [dev/mocha/junit] use else if

* [karma/junit] use string#replace for explicitness

* [junit] use test file path as "classname"

* [ftr/mocha] no longer a "console" specific reporter
2017-12-05 18:21:38 -07:00
Thomas Neirynck
1e2a8300f3
Region map settings clarifications (#14893) (#15421) (#15428)
* Region map settings clarifications (#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all parameter names.
2017-12-05 16:08:34 -05:00
Stacey Gammon
b489f469f9
Update getDashboardIdFromCurrentUrl to handle a url with no query params (#15323) (#15414)
* add some retries, waiting for the loading indicator to be hidden once is not enough

* test to see if looping over the flaky test 25 times will trigger it on jenkins

* Try again to semi-reliably report on jenkins

* Attempt to fix invalid id coming out of getDashboardIdFromCurrentUrl

* Clean up to submit attempted flaky test failure fix

clean up
2017-12-05 14:52:30 -05:00
Peter Pisljar
a2bfdb78d5
fixes pie label conflict resolution (#15410) (#15419)
* fixes pie label conflict resolution
2017-12-05 18:46:04 +01:00
Matt Bargar
22cb168679
Solidify context app filter test (#15203) (#15403)
* Solidify context filter test
2017-12-05 11:33:58 -05:00
Nathan Reese
724df60f03
[timelion] allow sum, subtract, multiply, divide functions to accept seriesList with multiple series (#14891) (#15413)
* allow seriesList with multiple series

* remove junk file

* fix promise bug in precision.js

* remove another junk file

* throw error outside of async function so it is properly handled

* compare split label and not entire series label which includes metric and query strings

* reduce seriesList by label field when both seriesList do not contain splitKey field

* use clearer variable names

* move pairwiseReduce to its own function

* fix es.js test
2017-12-05 09:32:00 -07:00
Brandon Kobel
90f8e8f4a6
Visualization resizeInit (#15321) (#15408)
* Removing resizeInit check from visualize/visualization

* Ignoring the initialization, not missing a resize within the first
debounce window
2017-12-05 10:59:58 -05:00
Stacey Gammon
89554f1b04
Add more test stability and helpful debug output to try to catch issue with panel controls (#15392) (#15399) 2017-12-05 08:48:11 -05:00
Tim Roes
b24ac9c814
Refactor and improve Visualize Loader (#15157) (#15362)
* Simplify promise setup logic

* Import template from own file

* Use angular.element instead of jquery

* Add documentation for loader methods

* Add params.append

* Remove params.editorMode

* Clarify when returned promise resolves

* Add element to handler

* Allow setting CSS class via loader

* Use render-counter on visualize

* Use Angular run method to get access to Private service

* Allow adding data-attributes to the vis element

* Refactor loader to return an EmbeddedVisualizeHandler instance

* Use this.destroy for previous API

* Remove fallback then method, due to bugs

* Reject promise from withId when id not found

* Add tests

* Change developer documentation

* Revert "Use Angular run method to get access to Private service"

This reverts commit 160e47d7709484c0478415436b3c2e8a8fc8aed3.

* Rename parameter for more clarity

* Add more documentation about appState

* Fix broken test utils

* Use chrome to get access to Angular

* Move loader to its own folder

* Use a method instead of getter for element

* Add listeners for renderComplete events

* Use typedef to document params

* Fix documentation
2017-12-05 12:56:19 +01:00
Chris Roberson
f4afba33eb
Disable flaky test (#15385) (#15396) 2017-12-04 16:52:08 -05:00
Chris Roberson
df0d679ea8
[Management] Ensure we do not perform an empty ccs query (#15372) (#15394)
* Ensure we do not peform an empty ccs query

* Trim in case there is extra whitespace
2017-12-04 16:51:35 -05:00
Joe Fleming
cb3336f990 Feat: Add config provider to disable state management (#15275)
* feat: add a state management config provider

the only thing to configure right now is the enabled/disabled state of state management

* feat: use state management config to disable state management

* test: add disabled checks for state management functions

* test: add tests for the state management config provider

* chore: consistently use arrow functions in state tests

* chore: be clearer about config value being private

* chore: clean up state config test code

* chore: style stuff that should be caught by the linter

>:( >:( >:(

* test: check url param for persisted state

instead of spying on a private method, create a persistent mock state and check the url's state value, as well as the public save method
2017-12-04 13:57:16 -07:00
Stacey Gammon
b0e5bd6d19
add extra test for more info (#15326) (#15381) 2017-12-04 15:54:55 -05:00
Nathan Reese
8e5eb46536
pass showSpyPanel to Editor (#15283) (#15382) 2017-12-04 13:17:00 -07:00
Kim Joar Bekkelund
da5b9ef0f8
Deprecate --plugin-dir option in plugin installer (#15371) (#15378) 2017-12-04 20:42:34 +01:00
Stacey Gammon
c70760821c
Attempt to stabilize filterVizNames failures (#15316) (#15388)
* Attempt to stabilize filterVizNames failures

* Remove duplicate function name
2017-12-04 14:42:23 -05:00
Kim Joar Bekkelund
60fd3d417b
No longer recommend manual plugin installs (#15366) (#15373) 2017-12-04 18:40:00 +01:00
Tim Sullivan
67262b0c4e
[Timepicker] Fix alignment, consistency in error msg (#15343) (#15349)
Fixes https://github.com/elastic/kibana/issues/15333
2017-12-04 10:24:25 -07:00
Chris Roberson
21bcc93aa5
Add parsedUrl to the code driving viz/dashboards (#15335) (#15345) 2017-12-04 10:14:46 -05:00
Brandon Kobel
40a5701ed5
Courier - $state in searchSource (#15166) (#15367)
* Modifying courier to exclude filter properties that start with $

* Removing the $state property directly when building the filters
2017-12-04 08:07:19 -05:00
Brandon Kobel
6101b8445a
Modifying anuglar-bootstrap tooltip to use scope.$evalAsync to fix bug (#15262) (#15370) 2017-12-04 07:06:24 -05:00
Court Ewing
fa3c2d5e83 Revert "Refactor and improve Visualize Loader (#15157) (#15359)"
This reverts commit bead35811f.

This backport was botched, so a bunch of inline diffs were committed.
2017-12-02 14:13:41 -05:00
Tim Roes
bead35811f
Refactor and improve Visualize Loader (#15157) (#15359)
* Simplify promise setup logic

* Import template from own file

* Use angular.element instead of jquery

* Add documentation for loader methods

* Add params.append

* Remove params.editorMode

* Clarify when returned promise resolves

* Add element to handler

* Allow setting CSS class via loader

* Use render-counter on visualize

* Use Angular run method to get access to Private service

* Allow adding data-attributes to the vis element

* Refactor loader to return an EmbeddedVisualizeHandler instance

* Use this.destroy for previous API

* Remove fallback then method, due to bugs

* Reject promise from withId when id not found

* Add tests

* Change developer documentation

* Revert "Use Angular run method to get access to Private service"

This reverts commit 160e47d7709484c0478415436b3c2e8a8fc8aed3.

* Rename parameter for more clarity

* Add more documentation about appState

* Fix broken test utils

* Use chrome to get access to Angular

* Move loader to its own folder

* Use a method instead of getter for element

* Add listeners for renderComplete events

* Use typedef to document params

* Fix documentation
2017-12-02 11:36:01 +01:00
Thomas Neirynck
03fe715b6d
Fix maps for reporting (#15272) (#15357)
This fix ensures the render-complete event does not fire before rendering is actually completed. 

- This ensures that the ChoroplethLayer is fully loaded, by explicitly waiting until all geojson files are loaded.
- It also removes the special init() code-path for coordinate-maps.This was the cause of coordinate-maps not showing on reports.
2017-12-01 19:48:29 -05:00
Chris Cowan
51cb853d1c Fixes for PR 14731 (#15352)
* Remove dependency on UI code in server

* Fixing tests
2017-12-01 14:38:15 -07:00
Tyler Smalley
4ae2610765
Uses inline script for re-index (#14982)
While still working in 6.0, this has improved backwards compatibility with ES 5.x.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-12-01 12:59:09 -08:00
Shaunak Kashyap
e11c7bb7db Make time picker enable/disable more granular (#15189)
* Make time picker enable/disable more granular

This makes the timefilter API more granular by removing the timefilter.enabled boolean property and introducing timefilter.enableTimeRange(), timefilter.disableTimeRange(), timefilter.enableAutoRefresh(), and timefilter.disableAutoRefresh() methods to toggle the enabled/disabled state of the time range selector and auto-refresh selector, respectively. Further, the current state of these two selectors can be read via timefilter.isTimeRangeEnabled and timefilter.isAutoRefreshEnabled.

* Clearer naming of API methods

* Reverting to !! instead of Boolean cast

* Wrapping the consequent in {} per style guide

* Removing outdated comment
2017-12-01 11:26:57 -08:00
Shahar Mor
799c80ef8e pass bucket size as _interval param to calculation metric script (#14731) 2017-12-01 10:30:24 -07:00
Nathan Reese
b82f34a992
[input controls] use KuiCheckBoxLabel to ensure proper spacing between checkbox and label (#15301) (#15329)
* use KuiCheckBoxLabel to ensure proper spacing between checkbox and label

* upper case Kibana

* fix broken jest test
2017-11-30 16:12:38 -07:00
Nathan Reese
cb5557c671
[6.x] [input controls] Horizontal layout (#14918) (#15307)
* [input controls] Horizontal layout (#14918)

* input controls horizontal layout

* fix controlWidth calculation

* add functional test to ensure panel resizing changes layout

* use all caps for consts, add more comments about where values came from

* replace sleeps in functional tests with retry

* use KuiFlexGroup with wrap option instead of manually calculating widths

* remove no longer used min width constants

* fix dashboard grid function test.
2017-11-30 16:11:38 -07:00
Spencer
91777d20e3
[6.x] add support for number format internationalization (#14019) (#15132) 2017-11-30 15:42:13 -07:00
Stacey Gammon
3c9fef9620
set last saved filters when a dashboard is saved. (#15311) (#15324) 2017-11-30 17:16:38 -05:00
Spencer
920b5ae716
[6.x] [precommit/casingCheck] enhance casing check for less false-positives (#15102) (#15306)
* [precommit/casingCheck] enhance casing check for less false-positives

* [dev/File] add tests
2017-11-30 14:32:19 -07:00
Stacey Gammon
1f25c56ece
attempt to fix flaky edit visualization link (#15265) (#15312) 2017-11-30 16:27:00 -05:00
Aleh Zasypkin
d3eec6c2b7
Expose angularized debounce through provider function. (#15296) 2017-11-30 20:55:48 +01:00
Spencer
7e1709964f
[6.x] [dev/ci_setup] generalize jenkins_setup script for other CI environments (#15178) (#15303)
* [dev/ci_setup] generalize jenkins_setup script for other CI environments

* [dev/ci_setup] accept more general `CACHE_DIR` env arg

* [dev/ci_setup] node.js install might not be invalid
2017-11-30 10:59:22 -07:00
Tim Roes
3cb873f3c0
Give access to angular $injector via chrome (#15267) (#15292)
* Implement getActiveInjector

* Fix typo in comments

* Rename method to sound more frightening

* Move test utils

* Add more documentation

* Fix typo in comment

* Fix name of method in comments
2017-11-30 15:53:48 +01:00