Commit graph

18284 commits

Author SHA1 Message Date
Pete Harverson
f647d6cd5c
[ML] Makefield type icon component keyboard accessible (#22708) 2018-09-05 20:19:00 +01:00
Nathan Reese
865a51de0a
Add instructions for running reporting functional tests to x-pack README (#22683)
* add instructions

* rest of instructions

* pdf-image requirements

* typo

* add Ubutnu commands
2018-09-05 13:02:28 -06:00
James Gowdy
23ed2135bf
[ML] Fixing issue with incorrect timezones in jobs list (#22714)
* [ML] Fixing issue with incorrect timezones in jobs list

* refactoring min and max calculation

* changes based on review

* changing TimeStamp to Timestamp
2018-09-05 17:16:13 +01:00
Thomas Neirynck
b7918690f4
align staging urls with new endpoints (#22691) 2018-09-05 12:14:05 -04:00
Chris Davies
ccf455e9fd
Fix #22581 by introducing an artificial delay (#22601)
Introduce a delay into reports to allow visualizations time to appear in the DOM. This is intended as a temporary (and hacky) workaround until we come up with a more robust way to determine that all of the visualizations on the page are ready for capture.
2018-09-05 11:10:38 -04:00
Tim Roes
d8f907b18a
Fix broken visualize CSS (#22707) 2018-09-05 15:27:24 +02:00
Leanid Shutau
4cf727aa98
Add logging to messages validation (#22296)
* Add logging and parallelization to messages validation

* Refactor dev/i18n

* Resolve comments

* Remove parallelism and fix tests

* Resolve comments
2018-09-05 14:02:15 +03:00
Tim Roes
9c01863c0a
Fix react vis type documentation (#22573) 2018-09-05 09:35:18 +02:00
Tim Roes
5f4a1c58e8
Move timezone settings into autoload file (#22623)
* Move timezone settings into autoload file

* Remove applying setting from timelion

* Remove manual set from ML

* Remove manual set from monitoring

* Remove now obsolete code from embedding test plugin
2018-09-05 08:55:39 +02:00
Chris Davies
cd83db7037
Fix #22510, dashboard-only mode doesn't display saved searches (#22685) 2018-09-04 21:46:59 -04:00
Spencer
5baa6d51c9
[ftr/asyncInstance] fix error thrown for undefined provider instances (#22689)
When a FTR service is created async the promise created by its provider is wrapped in a [`Proxy`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Proxy) that checks before each property access if the instance has finished initializing. This breaks if the service provider returns undefined, which is the case for the `failureDebugging` service, because our truthy check will fail and we throw the error claiming the service is uninitialized, which is probably incorrect.

This PR updates the proxy to use a `Symbol` to indicate when a service instance is not available yet and throws a different error when the proxy receives any request (get, set, etc.) and the service instance is not an object, as required by the Reflect APIs.
2018-09-04 15:48:46 -07:00
Jonathan Budzenski
a64738d277
[docs] fix missing float 2018-09-04 17:09:16 -05:00
Jonathan Budzenski
e89abb3a39
[config] logging.useUTC -> logging.timezone (#21561)
* [config] logging.useUTC -> logging.timezone

* docs

* [env] exit if starting as root

* fix import path

* add link and timezone example

* Revert "[env] exit if starting as root"

This reverts commit f6e9090833a5180fe360a9ff54543c37c0ca3a58.
2018-09-04 16:52:51 -05:00
Rashmi Kulkarni
d874c21eee
added assertion for the email field. 2018-09-04 14:08:25 -07:00
CJ Cenizal
bcb793857b
Extract index pattern validation rules into ui/public (#22606)
* Rename containsInvalidCharacters to containsIllegalCharacters and return a value which accurately reflects the name.
* Move illegal index pattern characters from Management into ui/public/index_patterns.
2018-09-04 11:26:58 -07:00
James Gowdy
6c896134ed
[ML] Removing calendars from job when cloning (#22667) 2018-09-04 19:07:07 +01:00
James Gowdy
85bee360c7
[ML] Adding milliseconds to watch start and end times (#22659) 2018-09-04 18:09:47 +01:00
James Gowdy
005be474a2
[ML] Fixing links to results for obs with no results (#22650) 2018-09-04 18:08:20 +01:00
Brian Gaddis
1464741e54 TypeScript Reporting Layouts (#22454)
* wip

WIP

* Changed any ypes to actual types

Made sure all types are set on the new layout classes.

* Changes recommended from code review

Changed location of type interfaces and fixed naming errors

* Latest Code Review Changes

Fix naming on properties and methods as well as a few other fixes

* Name Changes and spacing

Name Changes and spacing

* Name Change

Name Change

* Changes for typescript import and direct reference to layout_factory

Changes for typescript import and direct reference to layout_factory

* Move types locally

* Evaluate function changes for puppeteer

* Removed String as a type and renamed index.d.ts to types.d.ts for consistency

Removed String as a type and renamed index.d.ts to types.d.ts for consistency

* Changed layout_factoy to create_layout
2018-09-04 12:32:03 -04:00
Larry Gregory
785a1a97c0
Fix missing email address on account screen (#22652)
This PR fixes #22531, where the current user's email address was not displaying in the UI
2018-09-04 10:28:39 -04:00
Walter Rafelsberger
dcb65ba536
[ML] Migrates Anomaly Explorer Swimlanes to React (#22641)
- This PR migrates the Anomaly Explorer Swimlanes from angularjs to React.
- The approach is similar to the one from #22622: Try to refactor as little of the actual logic as possible, just make sure everything works inside the React component lifecycle. So as a guide for the review: No actual code within all the functions/methods changed, only the bits and pieces which needed to be tied into the React component lifecycle.
- The remaining wrapping angular directive is now only listening for data changes and passes its scope and other necessary data on as props to the React component.
2018-09-04 13:51:39 +02:00
Tim Roes
6fa2b04aef
Add functional tests for visualize loader API (#22595)
* Initial visualize loader functional tests

* Extend plugin test README

* Add temporary tz work around

* Switch to Australia/North timezone

* Add filtering tests

* Add all tests

* Remove unneeded uiExports

* Improve explanation

* Add saved object test, add retry
2018-09-04 12:53:18 +02:00
Maryia Lapata
58dbd0beb1
Update Guideline (#22450)
* Update Guideline

* Update Unit tests section

* Updated Guideline
2018-09-04 13:11:39 +03:00
Walter Rafelsberger
3667040091
[ML] Migrate Explorer Charts to React. (#22622)
This migrates the Anomaly Explorer charts to React. The PR aims to change as little of the actual logic to create and render the charts.
2018-09-03 18:14:51 +02:00
James Gowdy
d5ea684150
[ML] Adding string type check to jobs list search (#22627) 2018-09-03 16:59:39 +01:00
Jason Rhodes
f95b008d88
Refactors properties table, implements typescript (#22402)
* Refactors properties table, implements typescript

* Adds type info for imported variables file

* Small fixes based on code review

* Adds tests for new nested key/value table components

* Removes variable reassignment

* Fixes up styled component snapshots, uses mount instead of shallow

* Small review fixes, adds typings to PropertiesTable index file

* Small review fixes, changes method name

* Fixes test after moving back to JSON file
2018-09-03 08:53:16 -04:00
spalger
e5d33cc665 [kbn-pm] fix arg syntax 2018-09-02 18:21:35 -07:00
Thomas Neirynck
83c2695686
skip flaky test (#22494) 2018-09-01 17:19:29 -04:00
Marius Dragomir
5a65e384ea
Delete option[value=url] (#22585)
Delete extra file added by mistake
2018-09-01 16:45:59 +03:00
CJ Cenizal
e28eb6c5b7
Improve test coverage for CallClient error cases. (#22599) 2018-08-31 15:13:01 -07:00
Tim Sullivan
f2e4282aad
[ESLint] Turn off no-multi-str rule in eslint config (#22525)
* remove inline rule disabling comments

* turn off no-multi-str
2018-08-31 09:55:23 -07:00
Chris Davies
8a930f24ef
Fix #22579 (#22580) 2018-08-31 12:33:55 -04:00
Chris Davies
5f3c79e3cd
Consolodate Kibana and Elasticsearch launch logic in tests (#22328) 2018-08-31 12:32:27 -04:00
Søren Louv-Jansen
1daa265ff8
[kfetch] Add support for interceptors (#22128) 2018-08-31 15:17:24 +02:00
Tim Roes
8c3f4af8ed
Fix link in embed visualize docs (#22557) 2018-08-31 08:49:31 +02:00
Aaron Zhao
1faaad958f Fix save and cancel buttons mis-aligned in settings (#21898) 2018-08-30 20:40:01 -07:00
CJ Cenizal
03943753eb
Fix regression in CallClient, which caused request errors like timeouts to result in fatal errors. (#22558) 2018-08-30 19:54:11 -07:00
liza-mae
89bb8dc31e
Add windows support to ci_setup/setup script. (#22259)
* Add windows support to ci_setup/setup script.

* Update uname syntax

* Update echo statement to match rest

* Update if statement for node package

* Revert path variable
2018-08-30 18:40:12 -06:00
Josh Dover
2351223b79
Add tip about iTerm 2 settings (#22502)
Changing this setting improved sped up unit tests by about 2x.
2018-08-30 12:33:28 -05:00
Rachel Shen
11d6e53706
updated panel_state to ts gridData i vs id (#22515)
* updated panel state to ts gridData i vs id property

* changed gridData.id to gridData.i
2018-08-30 09:10:14 -07:00
Marco Vettorello
853d321ea2
Fix possible flakiness of saveVisualization action (#22356)
* Updated saveVisualization to wait for toast instead of global indicator

* Fix RBAC tests.

The saveVisualization now fails directly if the visualization is not correctly saved.

* Change editor to use toast for errors

* Change saveVisualization method to new saveVisualizationExpectSuccess

For RBAC tests used also saveVisualizationExpectFail

* Fix wrong exists method call

* Fix missing exist function
2018-08-30 15:58:31 +02:00
Lee Drengenberg
de846117f9
Fix flaky dashboard color legend (#22341)
* Rebuild modulePath correctly if on Windows

* Adding 1 second sleep to fix flaky test

* Wait to find a gear in the visualization after clicking Edit

* Revert "Wait to find a gear in the visualization after clicking Edit"

This reverts commit 8dac3fbd63.

* use waitForRenderComplete and change that to 1s timeout

* Use sleep until TagCloud data-render-complete is fixed

* Different getIsInEditMode courtesy of @chrisdavies

* combine switchToEditMode into one method
2018-08-30 08:43:41 -05:00
Chris Davies
7d8296fc91
Add the new chromium windows path to the CI "CleanExtraBrowsersTask" (#22534) 2018-08-30 09:42:59 -04:00
Peter Pisljar
e5a94e7a10
simplified tabify (#19061) 2018-08-30 14:56:18 +02:00
Guanghao Fan
f6a3f900b1 Fix issue with heatmap showing black tiles (#20753)
* Heatmap metric data points should only be quantized while the data full range is grate than the maxmum allowed color count

* The data cell with metric value 'null' should always be hidden in the heatmap

* Add one variable for max color count and follow the coding style
2018-08-30 14:14:36 +02:00
Brian Frantz
25761fb43a Add option to drop partial buckets from date_histogram visuals (#19979)
* Add Drop Partials option to date histogram agg settings UI

* Add timeRange to aggOpts and parse in _response_writer

* Implement dropPartials method in TabifyBuckets

* Fixed a couple issues

* Fixed issue with undefined timeRange

* Use braces for conditionals
2018-08-30 10:58:43 +02:00
Maryia Lapata
34b5f224d9
Translations for Home page (#22249)
* Translate Home page; add mountWithIntl method into enzyme_helper.js

* Update message ids

* Update component name

* Update message ids

* Fix unit tests

* Remove export from variables that get wrapped by a helper
2018-08-30 10:22:24 +03:00
Peter Pisljar
57e99302e7
fixing bug discovered by bahvya (#22481) 2018-08-30 08:40:47 +02:00
Bhavya RM
fc7e7b4e32
Functional test to surface index version conflicts (#22509) 2018-08-29 23:13:40 -04:00
John Dorlus
c65078eda7
Created separate pr to handle keybinding for mac and other os. (#22521) 2018-08-29 22:38:23 -04:00