mirror of
https://github.com/elastic/kibana.git
synced 2025-04-22 17:04:01 -04:00
f81c0edb27
# Backport This will backport the following commits from `main` to `8.16`: - [[ResponseOps][Rules] Validate timezone in rule routes (#201508)](https://github.com/elastic/kibana/pull/201508) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2025-01-24T17:46:24Z","message":"[ResponseOps][Rules] Validate timezone in rule routes (#201508)\n\n## Summary\r\n\r\nThis PR adds validation only for internal routes that use the `rRule`\r\nschema.\r\n\r\n## Testing\r\n\r\n1. Create a rule in main.\r\n2. Snooze the rule by using the API as\r\n\r\n```\r\nPOST /internal/alerting/rule/<ruleId>/_snooze\r\n{\r\n \"snooze_schedule\": {\r\n \"id\": \"e58e2340-dba6-454c-8308-b2ca66a7cf7b\",\r\n \"duration\": 86400000,\r\n \"rRule\": {\r\n \"dtstart\": \"2024-09-04T09:27:37.011Z\",\r\n \"tzid\": \"invalid\",\r\n \"freq\": 2,\r\n \"interval\": 1,\r\n \"byweekday\": [\r\n \"invalid\"\r\n ]\r\n }\r\n }\r\n}\r\n```\r\n\r\n4. Go to the rules page and verify that the rules are not loaded.\r\n5. Switch to my PR.\r\n6. Go to the rules page and verify that the rules load.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9a3fc89629e1a6cec2f5200bb75099fcab866701","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesFramework","backport:prev-major","v8.18.0","v8.16.4","v8.17.2"],"title":"[ResponseOps][Rules] Validate timezone in rule routes","number":201508,"url":"https://github.com/elastic/kibana/pull/201508","mergeCommit":{"message":"[ResponseOps][Rules] Validate timezone in rule routes (#201508)\n\n## Summary\r\n\r\nThis PR adds validation only for internal routes that use the `rRule`\r\nschema.\r\n\r\n## Testing\r\n\r\n1. Create a rule in main.\r\n2. Snooze the rule by using the API as\r\n\r\n```\r\nPOST /internal/alerting/rule/<ruleId>/_snooze\r\n{\r\n \"snooze_schedule\": {\r\n \"id\": \"e58e2340-dba6-454c-8308-b2ca66a7cf7b\",\r\n \"duration\": 86400000,\r\n \"rRule\": {\r\n \"dtstart\": \"2024-09-04T09:27:37.011Z\",\r\n \"tzid\": \"invalid\",\r\n \"freq\": 2,\r\n \"interval\": 1,\r\n \"byweekday\": [\r\n \"invalid\"\r\n ]\r\n }\r\n }\r\n}\r\n```\r\n\r\n4. Go to the rules page and verify that the rules are not loaded.\r\n5. Switch to my PR.\r\n6. Go to the rules page and verify that the rules load.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9a3fc89629e1a6cec2f5200bb75099fcab866701"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201508","number":201508,"mergeCommit":{"message":"[ResponseOps][Rules] Validate timezone in rule routes (#201508)\n\n## Summary\r\n\r\nThis PR adds validation only for internal routes that use the `rRule`\r\nschema.\r\n\r\n## Testing\r\n\r\n1. Create a rule in main.\r\n2. Snooze the rule by using the API as\r\n\r\n```\r\nPOST /internal/alerting/rule/<ruleId>/_snooze\r\n{\r\n \"snooze_schedule\": {\r\n \"id\": \"e58e2340-dba6-454c-8308-b2ca66a7cf7b\",\r\n \"duration\": 86400000,\r\n \"rRule\": {\r\n \"dtstart\": \"2024-09-04T09:27:37.011Z\",\r\n \"tzid\": \"invalid\",\r\n \"freq\": 2,\r\n \"interval\": 1,\r\n \"byweekday\": [\r\n \"invalid\"\r\n ]\r\n }\r\n }\r\n}\r\n```\r\n\r\n4. Go to the rules page and verify that the rules are not loaded.\r\n5. Switch to my PR.\r\n6. Go to the rules page and verify that the rules load.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"9a3fc89629e1a6cec2f5200bb75099fcab866701"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208252","number":208252,"state":"OPEN"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|---|---|---|
| .. | ||
| alert | ||
| alerts_client | ||
| alerts_service | ||
| application | ||
| authorization | ||
| backfill_client | ||
| connector_adapters | ||
| constants | ||
| data | ||
| health | ||
| integration_tests | ||
| invalidate_pending_api_keys | ||
| lib | ||
| maintenance_window_client | ||
| manual_tests | ||
| monitoring | ||
| routes | ||
| rules_client | ||
| rules_settings | ||
| saved_objects | ||
| task_runner | ||
| test_utils | ||
| usage | ||
| alerting_authorization_client_factory.mock.ts | ||
| alerting_authorization_client_factory.test.ts | ||
| alerting_authorization_client_factory.ts | ||
| config.test.ts | ||
| config.ts | ||
| index.ts | ||
| maintenance_window_client.mock.ts | ||
| maintenance_window_client_factory.test.ts | ||
| maintenance_window_client_factory.ts | ||
| maintenance_window_feature.ts | ||
| mocks.ts | ||
| plugin.test.ts | ||
| plugin.ts | ||
| rule_type_registry.mock.ts | ||
| rule_type_registry.test.ts | ||
| rule_type_registry.ts | ||
| rule_type_registry_deprecated_consumers.test.ts | ||
| rule_type_registry_deprecated_consumers.ts | ||
| rules_client.mock.ts | ||
| rules_client_conflict_retries.test.ts | ||
| rules_client_factory.test.ts | ||
| rules_client_factory.ts | ||
| types.ts | ||