kibana/x-pack/plugins
Kibana Machine 688008c1dd
[8.16] [Security Solution] Fix redux action being fired because of unused react-router value (#217055) (#218452)
# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Fix redux action being fired because of unused
react-router value
(#217055)](https://github.com/elastic/kibana/pull/217055)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-16T14:13:44Z","message":"[Security
Solution] Fix redux action being fired because of unused react-router
value (#217055)\n\n## Summary\n\nThis pr fixes a bug with the
RouteCapture component, used at a high\nlevel in the security solution
component tree, to reflect url changes\ninto redux. The code previously
used the full result of\n'react-router-dom' 's useLocation hook as the
payload, which contains 4\nparameters, pathname, search, hash that we
make use of, and a 4th that\nwas added sometime later by the library
that is essentially a random id\ngenerated every time the hook is
called, called key. We have never used\nthis, and it was being
inadvertently copied into the redux state, and\nalso causing some other
actions or hooks based listeners to run I think\nas well.\n\nBelow is
the contrived example of going from the home page to an empty\nalerts
page, and you can see 4 actions in the after, and 5 in the\nbefore, with
1 updating only the key. May reduce more unneeded actions\nwith more
going on in the page, but exactly how many is not
known.\nBefore:\n\n![image](ebd75055-4e17-497b-bed2-a5fd58c5c92f)\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"c277812ffe3e74eb9bc0733a538bd78ea9b95f58","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","backport:all-open","v9.1.0"],"title":"[Security
Solution] Fix redux action being fired because of unused react-router
value","number":217055,"url":"https://github.com/elastic/kibana/pull/217055","mergeCommit":{"message":"[Security
Solution] Fix redux action being fired because of unused react-router
value (#217055)\n\n## Summary\n\nThis pr fixes a bug with the
RouteCapture component, used at a high\nlevel in the security solution
component tree, to reflect url changes\ninto redux. The code previously
used the full result of\n'react-router-dom' 's useLocation hook as the
payload, which contains 4\nparameters, pathname, search, hash that we
make use of, and a 4th that\nwas added sometime later by the library
that is essentially a random id\ngenerated every time the hook is
called, called key. We have never used\nthis, and it was being
inadvertently copied into the redux state, and\nalso causing some other
actions or hooks based listeners to run I think\nas well.\n\nBelow is
the contrived example of going from the home page to an empty\nalerts
page, and you can see 4 actions in the after, and 5 in the\nbefore, with
1 updating only the key. May reduce more unneeded actions\nwith more
going on in the page, but exactly how many is not
known.\nBefore:\n\n![image](ebd75055-4e17-497b-bed2-a5fd58c5c92f)\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"c277812ffe3e74eb9bc0733a538bd78ea9b95f58"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217055","number":217055,"mergeCommit":{"message":"[Security
Solution] Fix redux action being fired because of unused react-router
value (#217055)\n\n## Summary\n\nThis pr fixes a bug with the
RouteCapture component, used at a high\nlevel in the security solution
component tree, to reflect url changes\ninto redux. The code previously
used the full result of\n'react-router-dom' 's useLocation hook as the
payload, which contains 4\nparameters, pathname, search, hash that we
make use of, and a 4th that\nwas added sometime later by the library
that is essentially a random id\ngenerated every time the hook is
called, called key. We have never used\nthis, and it was being
inadvertently copied into the redux state, and\nalso causing some other
actions or hooks based listeners to run I think\nas well.\n\nBelow is
the contrived example of going from the home page to an empty\nalerts
page, and you can see 4 actions in the after, and 5 in the\nbefore, with
1 updating only the key. May reduce more unneeded actions\nwith more
going on in the page, but exactly how many is not
known.\nBefore:\n\n![image](ebd75055-4e17-497b-bed2-a5fd58c5c92f)\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"c277812ffe3e74eb9bc0733a538bd78ea9b95f58"}}]}]
BACKPORT-->

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
2025-04-16 18:14:00 +02:00
..
actions [8.16] Disable allowAbsoluteUrls for axios (#215138) (#215826) 2025-03-25 18:23:12 +02:00
aiops [8.16] [ML] Fix page header right side items flex responsiveness (#198625) (#198882) 2024-11-05 11:26:59 -07:00
alerting [8.16] [ResponseOps][MW] Use date format from settings in MW UI (#211576) (#214545) 2025-03-14 15:10:06 +02:00
banners
canvas [8.16] chore(NA): upgrade to webpack 5 (#191106) (#211152) 2025-02-19 04:15:36 +00:00
cases [8.16] [Response Ops][Cases] Cases with empty string assignees throwing error (#209973) (#210768) 2025-02-12 17:10:25 +01:00
cloud [8.16] [Stateful sidenav] Update feedback urls (#198143) (#198479) 2024-10-31 05:59:00 -05:00
cloud_defend [8.x] [licensing] Remove unnecessary refresh calls (#194499) (#194855) 2024-10-03 12:30:09 -05:00
cloud_integrations [8.x] Clean up &#x60;cloud_chat&#x60; (#194571) (#194818) 2024-10-03 09:12:16 -05:00
cloud_security_posture [8.16] Fix Chart Trend by Severity Bug (#212357) 2025-02-25 17:08:34 +00:00
cross_cluster_replication [8.x] Remove kbn-ace, ace and brace dependencies (#195703) (#195765) 2024-10-11 11:17:21 +01:00
custom_branding
dashboard_enhanced
data_quality [8.x] [Dataset Quality] Fix project view breadcrumbs (#196281) (#196484) 2024-10-16 03:47:51 -05:00
data_usage [8.16] [Data Usage] use auto ops service (#196312) (#197132) 2024-10-21 18:09:53 -05:00
data_visualizer [8.16] [ML] Fix page header right side items flex responsiveness (#198625) (#198882) 2024-11-05 11:26:59 -07:00
discover_enhanced
drilldowns
ecs_data_quality_dashboard [8.16] [Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248) (#200635) 2024-11-18 16:57:22 -06:00
elastic_assistant [8.16] [Attack discovery] Fix error handling in LM studio (#213855) (#214039) 2025-03-12 05:02:06 +01:00
embeddable_enhanced [8.16] [Dashboard] Fix incorrect actions in edit mode after discarding unsaved changes (#200230) (#200278) 2024-11-14 20:26:50 -06:00
encrypted_saved_objects [8.16] Fixes bulk re-encryption for encrypted objects located in all spaces (#217625) (#218181) 2025-04-15 15:42:59 +02:00
enterprise_search [8.16] [Search][Connectors] Fixing custom connector icon rendering (#212225) (#212485) 2025-02-26 14:30:48 +01:00
entity_manager [8.16] Backport: [eem] rename fields to snake case #195895 (#198501) 2024-10-31 22:22:48 +01:00
event_log
features [8.x] feat: allow plugins to deprecate and replace features and feature privileges (#186800) (#196204) 2024-10-15 10:12:15 +02:00
fields_metadata [8.16] Update lru-cache (main) (#206225) (#213948) 2025-03-11 20:12:36 +01:00
file_upload [8.16] [ML] File upload fixing PDF character count limit (#197333) (#197601) 2024-10-24 07:37:20 -05:00
fleet [8.16] Fix unenroll inactive agent tasks if first set of agents returned is equal to UNENROLLMENT_BATCH_SIZE (#216283) (#216478) 2025-03-31 17:27:08 +01:00
global_search
global_search_bar [8.16] [Sustainable Kibana Architecture] Address &#x60;security&#x60; group dependencies&#x27; issues (#197480) (#197784) 2024-10-25 06:06:33 -05:00
global_search_providers
graph [8.16] fix: [Analytics:Graph page]Dialog modal missing title from announcement (#217827) (#218420) 2025-04-16 16:09:41 +02:00
grokdebugger
index_lifecycle_management [8.x] Update dependency @types/lodash to ^4.17.10 (main) (#194739) (#196234) 2024-10-15 04:11:15 -05:00
index_management [8.16] [Index management] Fix a11y focus order in index mappings page (#203361) (#203626) 2024-12-10 11:45:35 -06:00
inference
ingest_pipelines [8.16] chore(NA): upgrade to webpack 5 (#191106) (#211152) 2025-02-19 04:15:36 +00:00
integration_assistant [8.16] [Automatic Import] Fix chunking of samples in ecs mapping (#214702) (#214734) 2025-03-17 15:03:05 +00:00
kubernetes_security
lens [8.16] [Lens] fix drag and drop ghost after Chrome update to 134 (#213928) (#214123) 2025-03-22 03:16:14 +02:00
license_api_guard
license_management [8.x] Upgrade EUI to v97.0.0 (#195525) (#196116) 2024-10-14 08:31:39 -05:00
licensing [8.x] [licensing] Remove unnecessary refresh calls (#194499) (#194855) 2024-10-03 12:30:09 -05:00
lists [8.16] [Security Solution][Detection Engine] Fix importing rules with multiple types of exception lists (#198868) (#200085) 2024-11-13 15:49:35 -06:00
logstash [8.x] [HTTP] Set explicit access for &#x60;public&#x60; HTTP APIs 2 (#192579) (#193938) 2024-09-25 04:01:15 -05:00
maps [8.x] Update dependency @types/lodash to ^4.17.10 (main) (#194739) (#196234) 2024-10-15 04:11:15 -05:00
ml [8.16] fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (#217831) (#218271) 2025-04-15 17:44:52 +02:00
monitoring [8.16] [Usage collection] Replace agent.type with hard coded value to categorize monitoring type correctly. (#216391) (#216949) 2025-04-03 10:13:18 +01:00
monitoring_collection [8.16] [Monitoring] Make monitoring collection API public again (#205190) (#205198) 2024-12-27 08:21:12 -06:00
notifications
observability_solution [8.16] [Custom threshold rule] Allow group for ip type fields !! (#216062) (#218334) 2025-04-15 22:15:09 +02:00
osquery [8.16] [EDR Workflows][Osquery] OpenApi Missing Content (#212032) (#212639) 2025-02-27 14:47:12 +00:00
painless_lab
remote_clusters [8.x] Display error banner instead of warning (#195913) (#196344) 2024-10-15 12:21:43 -05:00
reporting [8.x] [Reporting] Improvements to reporting diagnostics (#191790) (#195225) 2024-10-07 07:39:30 -05:00
rollup
rule_registry [8.16] Set refresh according to stateful vs stateless when indexing alert documents (#201209) (#202222) 2024-11-29 07:45:23 -06:00
runtime_fields
saved_objects_tagging [8.16] fix: [Analytics:Maps page]Duplication of elements announcement (#215684) (#216182) 2025-03-27 18:44:28 +02:00
screenshotting [8.16] [Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse (#196860) (#197128) 2024-10-21 16:29:45 -05:00
search_assistant [8.16] [Search] Add ML as required plugin to Search Assistant (#204009) (#204035) 2024-12-12 10:23:57 -06:00
search_connectors [8.x] [Search] Update search integrations (#195628) (#196058) 2024-10-14 12:59:15 +02:00
search_homepage [8.x] [Search][Homepage] Remove usage (#194870) (#195137) 2024-10-04 15:16:52 -05:00
search_indices [8.16] [Search] [Onboarding] Fix colors for dark theme (#199331) (#199490) 2024-11-08 10:25:23 -06:00
search_inference_endpoints [8.16] [AI Assistant] Add assistant to Serverless Search (#196832) (#198301) 2024-10-30 07:49:36 -05:00
search_notebooks [8.x] search_notebooks: update notebooks Oct 1, 2024 (8.16) (#194603) (#194747) 2024-10-02 13:36:19 -05:00
search_playground [8.16] [Search] [Playground] [Bug] Add playground index validation (#201032) (#201750) 2024-11-26 13:41:47 +00:00
searchprofiler [8.16] [Search Profiler] Index field no longer resets on query edit (#215420) (#215496) 2025-03-21 17:48:56 +02:00
security [8.16] Log request ID in SAML provider (#211877) (#212217) 2025-02-24 12:57:51 +00:00
security_solution [8.16] [Security Solution] Fix redux action being fired because of unused react-router value (#217055) (#218452) 2025-04-16 18:14:00 +02:00
security_solution_ess [8.16] [Security Solution][Notes] - fix user filter not checking correct license in notes management page (#197149) (#197244) 2024-10-22 10:22:56 -05:00
security_solution_serverless [8.x] Kb settings followup (#195733) (#196477) 2024-10-16 00:21:47 -05:00
serverless [8.16] [Stateful sidenav] Update feedback urls (#198143) (#198479) 2024-10-31 05:59:00 -05:00
serverless_observability [8.16] [AI Assistant] Set scope and rename to Observability and Search (#196322) (#197608) 2024-10-28 12:56:52 -05:00
serverless_search [8.16] [Search] Add ML as required plugin to Search Assistant (#204009) (#204035) 2024-12-12 10:23:57 -06:00
session_view [8.x] Update dependency @types/lodash to ^4.17.10 (main) (#194739) (#196234) 2024-10-15 04:11:15 -05:00
snapshot_restore
spaces [8.16] [CLOUD] Instant deployment (#201688) (#201976) 2024-11-27 09:01:11 -06:00
stack_alerts [8.16] [ResponseOps] Do not change time field when edit (#206858) (#208029) 2025-01-23 13:31:44 +00:00
stack_connectors [8.16] [Attack discovery] Fix error handling in LM studio (#213855) (#214039) 2025-03-12 05:02:06 +01:00
task_manager [8.16] Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - capacity based claiming should claim tasks to full capacity (#201681) (#210232) 2025-02-07 20:25:43 +01:00
telemetry_collection_xpack [8.x] [APM][OTel] Make agent names generic with otel-native mode (#196522) 2024-10-16 14:22:28 +02:00
threat_intelligence [8.16] [Performance][Security Solution][4/4] - General Performance changes (#212488) (#213132) 2025-03-04 13:37:18 -05:00
timelines [8.16] [Security Solution] Fix timeline dynamic batching (#204034) | [ Security Solution ] Fix Refetch logic with new timeline batching (#205893) (#205674) 2025-02-06 11:08:47 -06:00
transform [8.16] [Chore] Isolate CCS check (#195988) (#196868) 2024-10-22 13:12:12 -05:00
translations [8.16] fix: [Analytics:Maps page]Duplication of elements announcement (#215684) (#216182) 2025-03-27 18:44:28 +02:00
triggers_actions_ui [8.16] [ResponseOps] Snooze Scheduler UX for recurring snoozes shows incorrect summary (#214797) (#215463) 2025-03-21 14:47:44 +02:00
upgrade_assistant [8.16] [UA] Update wizard copy to callout "x.last" (#201633) (#202112) 2024-11-28 13:48:04 +01:00
watcher [8.x] [Watcher] Fix code scanning alert (#194564) (#194913) 2024-10-04 05:01:56 -05:00