mirror of
https://github.com/elastic/kibana.git
synced 2025-04-21 16:29:04 -04:00
22e3bc3fa8
# Backport This will backport the following commits from `main` to `8.16`: - [fix: [Analytics:Graph page]Dialog modal missing title from announcement (#217827)](https://github.com/elastic/kibana/pull/217827) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-16T12:03:38Z","message":"fix: [Analytics:Graph page]Dialog modal missing title from announcement (#217827)\n\nCloses: #214760\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Set correct value for` aria-labelledby` attr.","sha":"b91da375a3c965181e2b2ee6f899d42ee6dcc0f0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-major","v9.1.0"],"title":"fix: [Analytics:Graph page]Dialog modal missing title from announcement","number":217827,"url":"https://github.com/elastic/kibana/pull/217827","mergeCommit":{"message":"fix: [Analytics:Graph page]Dialog modal missing title from announcement (#217827)\n\nCloses: #214760\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Set correct value for` aria-labelledby` attr.","sha":"b91da375a3c965181e2b2ee6f899d42ee6dcc0f0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217827","number":217827,"mergeCommit":{"message":"fix: [Analytics:Graph page]Dialog modal missing title from announcement (#217827)\n\nCloses: #214760\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Set correct value for` aria-labelledby` attr.","sha":"b91da375a3c965181e2b2ee6f899d42ee6dcc0f0"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> |
||
|---|---|---|
| .. | ||
| common | ||
| public | ||
| server | ||
| jest.config.js | ||
| kibana.jsonc | ||
| README.md | ||
| tsconfig.json | ||
Graph app
This is the main source folder of the Graph plugin. It contains all of the Kibana server and client source code. x-pack/test/functional/apps/graph contains additional functional tests.
Graph shows only up in the side bar if your server is running on a platinum or trial license. You can activate a trial license in Management > License Management.
Common commands
- Run tests
yarn test:jest x-pack/plugins/graph --watch - Run type check
node scripts/type_check.js --project=x-pack/tsconfig.json - Run linter
node scripts/eslint.js x-pack/plugins/graph - Run functional tests (make sure to stop dev server)
- Server
node ./scripts/functional_tests_server.js --config x-pack/test/functional/apps/graph/config.ts - Tests
node scripts/functional_test_runner.js --config x-pack/test/functional/apps/graph/config.ts
- Server
Folder structure
Client public/
Currently state handled by react/redux/saga and the core mutable GraphWorkspace instance, which managing the nodes and edges state. It should be rewritten in typescript and integrated into redux store.
apps/contains all graph app routescomponents/contains react components for various parts of the interface. Components can hold local UI state (e.g. current form data), everything else should be passed in from the caller. Styles should reside in a component-specific stylesheetservices/contains the core workspace logic and functions that encapsule other parts of Kibana. Stateful dependencies are passed in from the outside. Components should not rely on services directly but have callbacks passed in. Once the migration to redux/saga is complete, only sagas will use serviceshelpers/contains side effect free helper functions that can be imported and used from components and servicesstate_management/contains reducers, action creators, selectors and sagas. It also exports the central store creator- Each file covers one functional area (e.g. handling of fields, handling of url templates...)
- Generally there is no file separation between reducers, action creators, selectors and sagas of the same functional area
- Sagas may contain cross-references between multiple functional areas (e.g. the loading saga sets fields and meta data). Because of this it is possible that circular imports occur. In this case the sagas are moved to a separate file
<functional area>.sagas.ts.
types/contains type definitions for unmigratedGraphWorkspacemethodsrouter.tsxis the central entrypoint of the app
Server server/
The Graph server is only forwarding requests to Elasticsearch API and contains very little logic. It will be rewritten soon.