kibana/.github/PULL_REQUEST_TEMPLATE.md at 8.18

mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00

Michael Dokolin 861c2de3e5

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-core (#201653 ) (#205563 )

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/kibana-core`
(#201653)](https://github.com/elastic/kibana/pull/201653)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-01-04T18:47:24Z","message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/kibana-core`
(#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and
plugins) to the new folder\nstructure, according to the _Kibana
Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to
be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/cloud-chat-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n|
`@kbn/cloud-experiments-plugin`
|\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments`
|\n| `@kbn/cloud-full-story-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story`
|\n| `@kbn/cloud-links-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n|
`@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n|
`@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n|
`@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n|
`@kbn/kibana-usage-collection-plugin`
|\n`src/platform/plugins/private/kibana_usage_collection` |\n|
`@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing`
|\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed`
|\n| `@kbn/saved-objects-management-plugin`
|\n`src/platform/plugins/shared/saved_objects_management` |\n|
`@kbn/telemetry-collection-manager-plugin`
|\n`src/platform/plugins/shared/telemetry_collection_manager` |\n|
`@kbn/telemetry-collection-xpack-plugin`
|\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n|
`@kbn/telemetry-management-section-plugin`
|\n`src/platform/plugins/shared/telemetry_management_section` |\n|
`@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n|
`@kbn/usage-collection-plugin`
|\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22
package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- |
------------- |\n| `@kbn/analytics` |
`src/platform/packages/shared/kbn-analytics` |\n|
`@kbn/analytics-collection-utils`
|\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n|
`@kbn/apm-config-loader`
|\n`src/platform/packages/private/kbn-apm-config-loader` |\n|
`@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` |
`src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` |
`src/platform/packages/private/kbn-config-mocks`\n|\n|
`@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema`
|\n| `@kbn/crypto-browser`
|\n`src/platform/packages/shared/kbn-crypto-browser` |\n|
`@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n|
`@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n|
`@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n|
`@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n|
`@kbn/health-gateway-server`
|\n`src/platform/packages/private/kbn-health-gateway-server` |\n|
`@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n|
`@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n|
`@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n|
`@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks`
|\n| `@kbn/router-to-openapispec`
|\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n|
`@kbn/server-http-tools`
|\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std`
| `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types`
|\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` |
`src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by:
Alejandro Fernández Haro <alejandro.haro@elastic.co>\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","plugin
groups"],"number":201653,"url":"https://github.com/elastic/kibana/pull/201653","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/kibana-core`
(#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and
plugins) to the new folder\nstructure, according to the _Kibana
Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to
be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/cloud-chat-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n|
`@kbn/cloud-experiments-plugin`
|\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments`
|\n| `@kbn/cloud-full-story-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story`
|\n| `@kbn/cloud-links-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n|
`@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n|
`@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n|
`@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n|
`@kbn/kibana-usage-collection-plugin`
|\n`src/platform/plugins/private/kibana_usage_collection` |\n|
`@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing`
|\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed`
|\n| `@kbn/saved-objects-management-plugin`
|\n`src/platform/plugins/shared/saved_objects_management` |\n|
`@kbn/telemetry-collection-manager-plugin`
|\n`src/platform/plugins/shared/telemetry_collection_manager` |\n|
`@kbn/telemetry-collection-xpack-plugin`
|\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n|
`@kbn/telemetry-management-section-plugin`
|\n`src/platform/plugins/shared/telemetry_management_section` |\n|
`@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n|
`@kbn/usage-collection-plugin`
|\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22
package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- |
------------- |\n| `@kbn/analytics` |
`src/platform/packages/shared/kbn-analytics` |\n|
`@kbn/analytics-collection-utils`
|\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n|
`@kbn/apm-config-loader`
|\n`src/platform/packages/private/kbn-apm-config-loader` |\n|
`@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` |
`src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` |
`src/platform/packages/private/kbn-config-mocks`\n|\n|
`@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema`
|\n| `@kbn/crypto-browser`
|\n`src/platform/packages/shared/kbn-crypto-browser` |\n|
`@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n|
`@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n|
`@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n|
`@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n|
`@kbn/health-gateway-server`
|\n`src/platform/packages/private/kbn-health-gateway-server` |\n|
`@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n|
`@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n|
`@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n|
`@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks`
|\n| `@kbn/router-to-openapispec`
|\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n|
`@kbn/server-http-tools`
|\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std`
| `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types`
|\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` |
`src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by:
Alejandro Fernández Haro <alejandro.haro@elastic.co>\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201653","number":201653,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by `@elastic/kibana-core`
(#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and
plugins) to the new folder\nstructure, according to the _Kibana
Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to
be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/cloud-chat-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n|
`@kbn/cloud-experiments-plugin`
|\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments`
|\n| `@kbn/cloud-full-story-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story`
|\n| `@kbn/cloud-links-plugin`
|\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n|
`@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n|
`@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n|
`@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n|
`@kbn/kibana-usage-collection-plugin`
|\n`src/platform/plugins/private/kibana_usage_collection` |\n|
`@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing`
|\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed`
|\n| `@kbn/saved-objects-management-plugin`
|\n`src/platform/plugins/shared/saved_objects_management` |\n|
`@kbn/telemetry-collection-manager-plugin`
|\n`src/platform/plugins/shared/telemetry_collection_manager` |\n|
`@kbn/telemetry-collection-xpack-plugin`
|\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n|
`@kbn/telemetry-management-section-plugin`
|\n`src/platform/plugins/shared/telemetry_management_section` |\n|
`@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n|
`@kbn/usage-collection-plugin`
|\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22
package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- |
------------- |\n| `@kbn/analytics` |
`src/platform/packages/shared/kbn-analytics` |\n|
`@kbn/analytics-collection-utils`
|\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n|
`@kbn/apm-config-loader`
|\n`src/platform/packages/private/kbn-apm-config-loader` |\n|
`@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` |
`src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` |
`src/platform/packages/private/kbn-config-mocks`\n|\n|
`@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema`
|\n| `@kbn/crypto-browser`
|\n`src/platform/packages/shared/kbn-crypto-browser` |\n|
`@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n|
`@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n|
`@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n|
`@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n|
`@kbn/health-gateway-server`
|\n`src/platform/packages/private/kbn-health-gateway-server` |\n|
`@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n|
`@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n|
`@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n|
`@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks`
|\n| `@kbn/router-to-openapispec`
|\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n|
`@kbn/server-http-tools`
|\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std`
| `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types`
|\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` |
`src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by:
Alejandro Fernández Haro <alejandro.haro@elastic.co>\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8"}}]}]
BACKPORT-->

---------

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>

2025-01-05 16:32:00 +01:00

3.3 KiB

Raw Permalink Blame History

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

3.3 KiB Raw Permalink Blame History

Summary

Checklist

Risk Matrix

For maintainers

3.3 KiB

Raw Permalink Blame History