mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
## Summary Pre-req for #182535. We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification. <img width="421" alt="Screenshot 2024-08-20 at 6 34 16 AM" src="https://github.com/user-attachments/assets/9f954a6f-3a70-43c9-a3c3-28f92f1efba8"> <img width="269" alt="Screenshot 2024-08-20 at 6 37 18 AM" src="https://github.com/user-attachments/assets/b6c154d5-0b8c-4c8b-ac72-a190d03f8801"> I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
148 lines
5.5 KiB
TypeScript
148 lines
5.5 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0; you may not use this file except in compliance with the Elastic License
|
|
* 2.0.
|
|
*/
|
|
|
|
import expect from '@kbn/expect';
|
|
|
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
|
|
|
export default function canvasCustomElementTest({
|
|
getService,
|
|
getPageObjects,
|
|
}: FtrProviderContext) {
|
|
const testSubjects = getService('testSubjects');
|
|
const browser = getService('browser');
|
|
const retry = getService('retry');
|
|
const { canvas } = getPageObjects(['canvas']);
|
|
const find = getService('find');
|
|
const kibanaServer = getService('kibanaServer');
|
|
const archive = 'x-pack/test/functional/fixtures/kbn_archiver/canvas/default';
|
|
|
|
describe('custom elements', function () {
|
|
this.tags('skipFirefox');
|
|
|
|
before(async () => {
|
|
await kibanaServer.importExport.load(archive);
|
|
// load test workpad
|
|
await canvas.goToListingPage();
|
|
await canvas.loadFirstWorkpad('Test Workpad');
|
|
});
|
|
|
|
after(async () => {
|
|
await kibanaServer.importExport.unload(archive);
|
|
});
|
|
|
|
it('creates a custom element from an element when prompted', async () => {
|
|
// find the first workpad element (a markdown element) and click it to select it
|
|
await testSubjects.click('canvasWorkpadPage > canvasWorkpadPageElementContent', 20000);
|
|
|
|
// click "Edit" menu
|
|
await testSubjects.click('canvasWorkpadEditMenuButton', 20000);
|
|
|
|
// click the "Save as new element" button
|
|
await testSubjects.click('canvasWorkpadEditMenu__saveElementButton', 20000);
|
|
|
|
// fill out the custom element form and submit it
|
|
await canvas.fillOutCustomElementForm('My New Element', 'An excellent new element');
|
|
|
|
// wait for the custom element success toast notif
|
|
await testSubjects.exists('canvasCustomElementCreate-success', {
|
|
timeout: 30000,
|
|
});
|
|
});
|
|
|
|
it('adds the custom element to the workpad when prompted', async () => {
|
|
// open the saved elements modal
|
|
await canvas.openSavedElementsModal();
|
|
|
|
// ensure the custom element is the one expected and click it to add to the workpad
|
|
const customElement = await find.byCssSelector('.canvasElementCard__wrapper');
|
|
const elementName = await customElement.findByCssSelector('.euiCard__title');
|
|
|
|
expect(await elementName.getVisibleText()).to.contain('My New Element');
|
|
await customElement.click();
|
|
|
|
await retry.try(async () => {
|
|
// ensure the new element is on the workpad
|
|
const elements = await testSubjects.findAll(
|
|
'canvasWorkpadPage > canvasWorkpadPageElementContent'
|
|
);
|
|
expect(elements).to.have.length(5);
|
|
|
|
// ensure the new element has the expected content
|
|
const newElem = elements[4];
|
|
const md = await newElem.findByCssSelector('.canvasMarkdown');
|
|
expect(await md.getVisibleText()).to.contain('Welcome to Canvas');
|
|
|
|
// delete the element off the workpad
|
|
await newElem.click();
|
|
await browser.pressKeys(browser.keys.DELETE);
|
|
|
|
// ensure the new element has been removed
|
|
const elementsAgain = await testSubjects.findAll(
|
|
'canvasWorkpadPage > canvasWorkpadPageElementContent'
|
|
);
|
|
expect(elementsAgain).to.have.length(4);
|
|
});
|
|
});
|
|
|
|
it('saves custom element modifications', async () => {
|
|
// open the saved elements modal
|
|
await canvas.openSavedElementsModal();
|
|
|
|
// ensure the correct amount of custom elements exist
|
|
const customElements = await find.allByCssSelector('.canvasElementCard__wrapper');
|
|
expect(customElements).to.have.length(1);
|
|
|
|
// hover over the custom element to bring up the edit and delete icons
|
|
const customElement = customElements[0];
|
|
await customElement.moveMouseTo();
|
|
|
|
// click the edit element button
|
|
await testSubjects.click('canvasElementCard__editButton', 20000);
|
|
|
|
// fill out the custom element form and submit it
|
|
await canvas.fillOutCustomElementForm('My Edited New Element', 'An excellent edited element');
|
|
|
|
// ensure the custom element in the modal shows the updated text
|
|
await retry.try(async () => {
|
|
const elementName = await find.byCssSelector('.canvasElementCard__wrapper .euiCard__title');
|
|
|
|
expect(await elementName.getVisibleText()).to.contain('My Edited New Element');
|
|
});
|
|
|
|
// Close the modal
|
|
await canvas.closeSavedElementsModal();
|
|
});
|
|
|
|
it('deletes custom element when prompted', async () => {
|
|
// open the saved elements modal
|
|
await canvas.openSavedElementsModal();
|
|
|
|
// ensure the correct amount of custom elements exist
|
|
const customElements = await find.allByCssSelector('.canvasElementCard__wrapper');
|
|
expect(customElements).to.have.length(1);
|
|
|
|
// hover over the custom element to bring up the edit and delete icons
|
|
const customElement = customElements[0];
|
|
await customElement.moveMouseTo();
|
|
|
|
// click the delete element button
|
|
await testSubjects.click('canvasElementCard__deleteButton', 20000);
|
|
|
|
await testSubjects.click('confirmModalConfirmButton', 20000);
|
|
|
|
// ensure the custom element was deleted
|
|
await retry.try(async () => {
|
|
const customElementsAgain = await find.allByCssSelector('.canvasElementCard__wrapper');
|
|
expect(customElementsAgain).to.have.length(0);
|
|
});
|
|
|
|
// Close the modal
|
|
await canvas.closeSavedElementsModal();
|
|
});
|
|
});
|
|
}
|