mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00

History

Kibana Machine 33bc977a8a [8.6] [Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390 ) (#147424 ) # Backport This will backport the following commits from `main` to `8.6`: - [[Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390)](https://github.com/elastic/kibana/pull/147390) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2022-12-13T09:43:15Z","message":"[Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390)\n\nCloses #146581 \r\n\r\n## Summary\r\n\r\nThis PR fixes the initial `from` date range calculation. The idea is to\r\nconvert first the initial range of minutes to milliseconds. Then in\r\norder to get the date of `CALCULATED_DATE_RANGE_TO` - (the calculated\r\ninitial range in milliseconds) and call `getTime()` to receive the\r\ncalculated `from` date as timestamp.\r\n\r\nTo test that you can open the host page without the time range in the\r\nURL. Then check the `from` value as in the screenshot attached to the\r\nstory and you can use an [Unix timestamp\r\nconverter](https://www.unixtimestamp.com/) to verify that the\r\ncalculation is correct","sha":"29841da10b140d8bb0e24d5af4c55e64b6f473c9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Infra Monitoring UI","backport:prev-minor","v8.7.0"],"number":147390,"url":"https://github.com/elastic/kibana/pull/147390","mergeCommit":{"message":"[Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390)\n\nCloses #146581 \r\n\r\n## Summary\r\n\r\nThis PR fixes the initial `from` date range calculation. The idea is to\r\nconvert first the initial range of minutes to milliseconds. Then in\r\norder to get the date of `CALCULATED_DATE_RANGE_TO` - (the calculated\r\ninitial range in milliseconds) and call `getTime()` to receive the\r\ncalculated `from` date as timestamp.\r\n\r\nTo test that you can open the host page without the time range in the\r\nURL. Then check the `from` value as in the screenshot attached to the\r\nstory and you can use an [Unix timestamp\r\nconverter](https://www.unixtimestamp.com/) to verify that the\r\ncalculation is correct","sha":"29841da10b140d8bb0e24d5af4c55e64b6f473c9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147390","number":147390,"mergeCommit":{"message":"[Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390)\n\nCloses #146581 \r\n\r\n## Summary\r\n\r\nThis PR fixes the initial `from` date range calculation. The idea is to\r\nconvert first the initial range of minutes to milliseconds. Then in\r\norder to get the date of `CALCULATED_DATE_RANGE_TO` - (the calculated\r\ninitial range in milliseconds) and call `getTime()` to receive the\r\ncalculated `from` date as timestamp.\r\n\r\nTo test that you can open the host page without the time range in the\r\nURL. Then check the `from` value as in the screenshot attached to the\r\nstory and you can use an [Unix timestamp\r\nconverter](https://www.unixtimestamp.com/) to verify that the\r\ncalculation is correct","sha":"29841da10b140d8bb0e24d5af4c55e64b6f473c9"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>		2022-12-13 04:12:13 -07:00
..
.storybook	[Logs UI] Store Logs UI settings in a dedicated `infrastructure-monitoring-log-view` saved object (#125014 )	2022-03-31 16:08:01 +02:00
common	[8.6] [Infrastructure UI] Improve metrics settings error handling (#146272 ) (#146675 )	2022-11-30 05:00:48 -07:00
docs	[Metrics UI][Logs UI] Completely remove GraphQL and Apollo (#89036 )	2021-02-02 16:56:40 -07:00
public	[8.6] [Fix][Infrastructure UI] Incorrect payload in time range when landing on the Hosts View (#147390 ) (#147424 )	2022-12-13 04:12:13 -07:00
scripts	[Metrics UI][Logs UI] Completely remove GraphQL and Apollo (#89036 )	2021-02-02 16:56:40 -07:00
server	[8.6] [Infrastructure UI] Improve metrics settings error handling (#146272 ) (#146675 )	2022-11-30 05:00:48 -07:00
types	[eslint] add rule for auto-fixing unused imports (#131772 )	2022-05-11 11:16:48 -05:00
jest.config.js	[jest] update config files to get coverage per plugin (#111299 )	2021-09-09 08:14:56 +02:00
kibana.json	[Infrastructure UI] Replace Lens table with EUI table and own api (#142871 )	2022-10-24 10:38:25 +02:00
README.md	update readme of logs-metrics-ui (#101968 )	2021-06-17 08:28:34 +02:00
tsconfig.json	[auto] migrate existing plugin/package configs	2022-10-28 14:06:46 -05:00

README.md

The `infra` plugin

This is the home of the infra plugin, which aims to provide a solution for the infrastructure monitoring use-case within Kibana.

UI Structure

The plugin provides two main apps in Kibana - the Metrics UI and the Logs UI. Both are reachable via their own main navigation items and via links from other parts of Kibana.

The Metrics UI consists of three main screens, which are the Inventory, the Node details and the Metrics explorer.

The Logs UI provides one log viewer screen.

Communicating

In order to address the whole infrastructure monitoring team, the @elastic/infra-logs-ui team alias can be used as a mention or in review requests.

The Infrastructure forum and Logs forum on Discuss are frequented by the team as well.

Contributing

Since the infra plugin lives within the Kibana repository, Kibana's contribution procedures apply. In addition to that, this section details a few plugin-specific aspects.

Ingesting metrics for development

The Metrics UI displays ECS-compatible metric data from indices matching the metricbeat-* pattern by default. The primary way to ingest these is by running Metricbeat to deliver metrics to the development Elasticsearch cluster. It can be used to ingest development host metrics using the system module.

A setup that ingests docker and nginx metrics is described in [./docs/test_setups/infra_metricbeat_docker_nginx.md].

Ingesting logs for development

Similarly, the Logs UI assumes ECS-compatible log data to be present in indices matching the filebeat-* pattern. At the time of writing the minimum required fields are @timestamp and message, but the presence of other ECS fields enable additional functionality such as linking to and from other solutions.

The primary way to ingest such log data is via Filebeat. A convenient source of log entries are the Kibana and Elasticsearch log files produced by the development environment itself. These can easily be consumed by enabling the modules

$ filebeat modules enable elasticsearch
$ filebeat modules enable kibana

and then editing the modules.d/elasticsearch.yml and modules.d/kibana.yml to change the var.paths settings to contain paths to the development environment's log files, e.g.:

- module: elasticsearch
  server:
    enabled: true
    var.paths:
      - "${WORK_ENVIRONMENT}/kibana/.es/8.0.0/logs/elasticsearch_server.json"
    var.convert_timezone: true

Creating PRs

As with all of Kibana, we welcome contributions from everyone. The usual life-cycle of a PR looks like the following:

Create draft PR: To make ongoing work visible, we recommend creating draft PRs as soon as possible. PRs are usually targetted at master and backported later. The checklist in the PR description template can be used to guide the progress of the PR.
Label the PR: To ensure that a newly created PR gets the attention of the @elastic/logs-metrics-ui team, the following label should be applied to PRs:
- Team:logs-metrics-ui
- Feature:Metrics UI if it relates to the Metrics UI
- Feature:Logs UI if it relates to the Logs UI
- Version labels for merge and backport targets (see Kibana's contribution procedures), usually:
  - the version that master currently represents
  - the version of the next minor release
- Release note labels (see Kibana's contribution procedures)
  - release_note:enhancement if the PR contains a new feature or enhancement
  - release_note:fix if the PR contains an external-facing fix
  - release_note:breaking if the PR contains a breaking change
  - release_note:deprecation if the PR contains deprecations of publicly documented features.
  - release_note:skip if the PR contains only house-keeping changes, fixes to unreleased code or documentation changes
Satisfy CI: The PR will automatically be picked up by the CI system, which will run the full test suite as well as some additional checks. A comment containing @elasticmachine merge upstream or retest can be used to manually trigger a CI run. The result will be reported on the PR itself. Out of courtesy for the reviewers the checks should pass before requesting reviews.
Request reviews: Once the PR is ready for reviews it can be marked as such by changing the PR state to ready. If the GitHub automation doesn't automatically request a review from @elastic/logs-metrics-ui it should be requested manually.
Incorporate review feedback: Usually one reviewer's approval is sufficient. Particularly complicated or cross-cutting concerns might warrant multiple reviewers.
Merge: Once CI is green and the reviewers are approve, PRs in the Kibana repo are "squash-merged" to master to keep the history clean.
Backport: After merging to master, the PR is backported to the branches that represent the versions indicated by the labels. The yarn backport command can be used to automate most of the process.

There are always exceptions to the rule, so seeking guidance about any of the steps is highly recommended.