github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/docs/developer/contributing
History
Exact
Tre 69665cecd0
[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* (#191805) 
## Summary

Moving common services to respective new homes.

This PR is revived from a previously
[merged](09a365850e)
and [reverted PR](https://github.com/elastic/kibana/pull/191765) as
[detailed
here](https://github.com/elastic/kibana/pull/189051#issuecomment-2318999361).
- This was due to "extra" tests being applied to
https://github.com/elastic/kibana/pull/191708
- These "extra" tests were applied as
https://github.com/elastic/kibana/pull/191708 changes files within
`x-pack/plugins/observability_solution/` as configured
[here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129)

### Why these failures were not caught in the original
[PR](https://github.com/elastic/kibana/pull/189051)
The pipeline is generated at runtime, and the original
[PR](https://github.com/elastic/kibana/pull/189051) had zero changes
under `x-pack/plugins/observability_solution/`
 
 ## Changes on top of original PR
 - Add `ci:all-cypress-suites` label to run extra tests
- Add `services` stanza to which contains the missing references by
spreading the services from `@kbn/ftr-common-functional-services` &&
`@kbn/ftr-common-functional-ui-services` into the stanza, for the
following:
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` 
-
`x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/uptime/e2e/config.ts`
 

 
 
Blocked by: https://github.com/elastic/kibana/issues/191961
Resolves: https://github.com/elastic/kibana/issues/188541

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-09-05 10:00:55 +01:00
..
development-accessibility-tests.asciidoc [ftr] split x-pack accessibility config in 3 groups (#171186) 2023-11-28 05:35:43 -07:00
development-ci-metrics.asciidoc Fix broken link to CiStatsReporter (#138407) 2022-08-10 00:33:38 +09:30
development-documentation.asciidoc Add more details on developer documentation (#126674) 2022-03-03 11:44:05 -07:00
development-functional-tests.asciidoc [FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* (#191805) 2024-09-05 10:00:55 +01:00
development-github.asciidoc Update docs on branching. (#139057) 2022-08-24 17:28:48 +00:00
development-package-tests.asciidoc [package testing] Update networking profile to account for virtualbox update (#127298) 2022-03-09 11:47:11 -06:00
development-pull-request.asciidoc Clean up the developer guide (#71631) 2020-07-16 10:13:51 -04:00
development-tests.asciidoc Fix typos in docs & dev_docs (#113746) 2021-10-07 14:30:32 -04:00
development-unit-tests.asciidoc [docs] Use inspect-brk instead of debug-brk (#118108) 2021-11-09 13:56:06 -08:00
index.asciidoc [i18n] a few docs updates (#127964) 2022-03-17 18:18:49 +02:00
interpreting-ci-failures.asciidoc [ftr] split x-pack accessibility config in 3 groups (#171186) 2023-11-28 05:35:43 -07:00
kibana-issue-reporting.asciidoc Clean up the developer guide (#71631) 2020-07-16 10:13:51 -04:00
linting.asciidoc [DOCS] Update GitHub links in dev docs (#164503) 2023-08-29 14:43:41 -04:00
pr-review.asciidoc [ci] Remove jenkins config (#173745) 2023-12-21 12:09:43 -06:00