mirror of
https://github.com/elastic/kibana.git
synced 2025-06-28 19:13:14 -04:00
## Summary Pre-req for #182535. We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification. <img width="421" alt="Screenshot 2024-08-20 at 6 34 16 AM" src="https://github.com/user-attachments/assets/9f954a6f-3a70-43c9-a3c3-28f92f1efba8"> <img width="269" alt="Screenshot 2024-08-20 at 6 37 18 AM" src="https://github.com/user-attachments/assets/b6c154d5-0b8c-4c8b-ac72-a190d03f8801"> I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
150 lines
5.9 KiB
TypeScript
150 lines
5.9 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the "Elastic License
|
|
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
|
|
* Public License v 1"; you may not use this file except in compliance with, at
|
|
* your election, the "Elastic License 2.0", the "GNU Affero General Public
|
|
* License v3.0 only", or the "Server Side Public License, v 1".
|
|
*/
|
|
|
|
import { FtrService } from '../ftr_provider_context';
|
|
|
|
interface SaveModalArgs {
|
|
addToDashboard?: 'new' | 'existing' | null;
|
|
saveToLibrary?: boolean;
|
|
dashboardId?: string;
|
|
saveAsNew?: boolean;
|
|
redirectToOrigin?: boolean;
|
|
description?: string;
|
|
}
|
|
|
|
type DashboardPickerOption =
|
|
| 'add-to-library-option'
|
|
| 'existing-dashboard-option'
|
|
| 'new-dashboard-option';
|
|
|
|
export class TimeToVisualizePageObject extends FtrService {
|
|
private readonly testSubjects = this.ctx.getService('testSubjects');
|
|
private readonly log = this.ctx.getService('log');
|
|
private readonly find = this.ctx.getService('find');
|
|
private readonly common = this.ctx.getPageObject('common');
|
|
private readonly dashboard = this.ctx.getPageObject('dashboard');
|
|
private readonly retry = this.ctx.getService('retry');
|
|
|
|
public async ensureSaveModalIsOpen() {
|
|
await this.testSubjects.exists('savedObjectSaveModal', { timeout: 5000 });
|
|
}
|
|
|
|
public async ensureDashboardOptionsAreDisabled() {
|
|
const dashboardSelector = await this.testSubjects.find('add-to-dashboard-options');
|
|
await dashboardSelector.findByCssSelector(`input[id="new-dashboard-option"]:disabled`);
|
|
await dashboardSelector.findByCssSelector(`input[id="existing-dashboard-option"]:disabled`);
|
|
|
|
const librarySelector = await this.testSubjects.find('add-to-library-checkbox');
|
|
await librarySelector.findByCssSelector(`input[id="add-to-library-checkbox"]:disabled`);
|
|
}
|
|
|
|
public async resetNewDashboard() {
|
|
await this.dashboard.navigateToApp();
|
|
await this.dashboard.gotoDashboardLandingPage();
|
|
await this.dashboard.clickNewDashboard();
|
|
}
|
|
|
|
private async selectDashboard(dashboardId: string) {
|
|
await this.retry.try(async () => {
|
|
await this.testSubjects.waitForEnabled('open-dashboard-picker');
|
|
await this.testSubjects.click('open-dashboard-picker');
|
|
await this.testSubjects.setValue('dashboard-picker-search', dashboardId);
|
|
await this.common.sleep(150); // wait for input debounce so loading starts
|
|
await this.testSubjects.waitForEnabled('open-dashboard-picker');
|
|
await this.testSubjects.click(`dashboard-picker-option-${dashboardId.replaceAll(' ', '-')}`);
|
|
const dashboardPickerLabel = await this.testSubjects.getVisibleText('open-dashboard-picker');
|
|
if (dashboardPickerLabel === 'Select dashboard') {
|
|
throw new Error(`Dashboard not selected`);
|
|
}
|
|
});
|
|
}
|
|
|
|
public async setSaveModalValues(
|
|
vizName: string,
|
|
{
|
|
saveAsNew,
|
|
redirectToOrigin,
|
|
addToDashboard,
|
|
dashboardId,
|
|
saveToLibrary,
|
|
description,
|
|
}: SaveModalArgs = {}
|
|
) {
|
|
await this.testSubjects.setValue('savedObjectTitle', vizName, {
|
|
typeCharByChar: true,
|
|
clearWithKeyboard: true,
|
|
});
|
|
|
|
if (description !== undefined) {
|
|
await this.testSubjects.setValue('savedObjectDescription', description, {
|
|
typeCharByChar: true,
|
|
clearWithKeyboard: true,
|
|
});
|
|
}
|
|
|
|
const hasSaveAsNew = await this.testSubjects.exists('saveAsNewCheckbox');
|
|
if (hasSaveAsNew && saveAsNew !== undefined) {
|
|
const state = saveAsNew ? 'check' : 'uncheck';
|
|
this.log.debug('save as new checkbox exists. Setting its state to', state);
|
|
await this.testSubjects.setEuiSwitch('saveAsNewCheckbox', state);
|
|
}
|
|
|
|
const hasDashboardSelector = await this.testSubjects.exists('add-to-dashboard-options');
|
|
if (hasDashboardSelector && addToDashboard !== undefined) {
|
|
let option: DashboardPickerOption = 'add-to-library-option';
|
|
if (addToDashboard) {
|
|
option = dashboardId ? 'existing-dashboard-option' : 'new-dashboard-option';
|
|
}
|
|
this.log.debug('save modal dashboard selector, choosing option:', option);
|
|
const dashboardSelector = await this.testSubjects.find('add-to-dashboard-options');
|
|
const label = await dashboardSelector.findByCssSelector(`label[for="${option}"]`);
|
|
await label.click();
|
|
|
|
if (dashboardId) {
|
|
await this.selectDashboard(dashboardId);
|
|
}
|
|
}
|
|
|
|
const hasSaveToLibrary = await this.testSubjects.exists('add-to-library-checkbox');
|
|
if (hasSaveToLibrary && saveToLibrary !== undefined) {
|
|
const libraryCheckbox = await this.find.byCssSelector('#add-to-library-checkbox');
|
|
const isChecked = await libraryCheckbox.isSelected();
|
|
const needsClick = isChecked !== saveToLibrary;
|
|
const state = saveToLibrary ? 'check' : 'uncheck';
|
|
|
|
this.log.debug('save to library checkbox exists. Setting its state to', state);
|
|
if (needsClick) {
|
|
const selector = await this.testSubjects.find('add-to-library-checkbox');
|
|
const label = await selector.findByCssSelector(`label[for="add-to-library-checkbox"]`);
|
|
await label.click();
|
|
}
|
|
}
|
|
|
|
const hasRedirectToOrigin = await this.testSubjects.exists('returnToOriginModeSwitch');
|
|
if (hasRedirectToOrigin && redirectToOrigin !== undefined) {
|
|
const state = redirectToOrigin ? 'check' : 'uncheck';
|
|
this.log.debug('redirect to origin checkbox exists. Setting its state to', state);
|
|
await this.testSubjects.setEuiSwitch('returnToOriginModeSwitch', state);
|
|
}
|
|
}
|
|
|
|
public async saveFromModal(
|
|
vizName: string,
|
|
saveModalArgs: SaveModalArgs = { addToDashboard: null }
|
|
) {
|
|
await this.ensureSaveModalIsOpen();
|
|
|
|
await this.setSaveModalValues(vizName, saveModalArgs);
|
|
this.log.debug('Click Save Visualization button');
|
|
|
|
await this.testSubjects.click('confirmSaveSavedObjectButton');
|
|
|
|
await this.common.waitForSaveModalToClose();
|
|
}
|
|
}
|