mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
6cc9855495
**Addresses:** https://github.com/elastic/kibana/issues/130966 **Based on:** https://github.com/elastic/kibana/issues/135127 ## Summary This PR deprecates the Sidecar SO of type `siem-detection-engine-rule-execution-info` in favour of storing Rule Execution Logging data within the rule itself, making use of the work previously done in the Alerting Framework: - https://github.com/elastic/kibana/pull/140882 - https://github.com/elastic/kibana/pull/147278 Work done: - **Pass execution statuses and metrics from rule executors to the Framework:** through the use of `RuleMonitoringService` and `RuleResultService` from within the rule execution log client for executor. `x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/client_for_executors/client.ts` - **Fetch execution statuses and metrics from rules themselves instead of the sidecar `siem-detection-engine-rule-execution-info` saved objects**: through the use of the new function `createRuleExecutionSummary` in `x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/create_rule_execution_summary.ts`, which extracts last execution information from the rule itself. - **Remove the siem-detection-engine-rule-execution-info saved objects type from the codebase. Mark it as deleted in Kibana Core:** added `siem-detection-engine-rule-execution-info` to `packages/core/saved-objects/core-saved-objects-migration-server-internal/src/core/unused_types.ts`; and got rid of the related Saved Object client. - **Make sure to keep backward compatibility in the Detection API endpoints and rule execution events we write into the Event Log**: API compatibility is maintained. No breaking changes. ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios |
||
|---|---|---|
| .. | ||
| core-saved-objects-api-browser | ||
| core-saved-objects-api-server | ||
| core-saved-objects-api-server-internal | ||
| core-saved-objects-api-server-mocks | ||
| core-saved-objects-base-server-internal | ||
| core-saved-objects-base-server-mocks | ||
| core-saved-objects-browser | ||
| core-saved-objects-browser-internal | ||
| core-saved-objects-browser-mocks | ||
| core-saved-objects-common | ||
| core-saved-objects-import-export-server-internal | ||
| core-saved-objects-import-export-server-mocks | ||
| core-saved-objects-migration-server-internal | ||
| core-saved-objects-migration-server-mocks | ||
| core-saved-objects-server | ||
| core-saved-objects-server-internal | ||
| core-saved-objects-server-mocks | ||
| core-saved-objects-utils-server | ||