github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 03:01:21 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/packages/core/saved-objects/core-saved-objects-common
History
Jean-Louis Leysens 631675ba39
[Saved Objects] Import SO types from server rather than common to avoid deprecation (#149289) 
## Summary

After merging https://github.com/elastic/kibana/pull/148979 there are a
number of imports that can be fixed immediately to address our new
deprecation notice.

## To Core reviewers

The package `core-saved-objects-server` is using types from
`core-saved-objects-api-server` which creates a circular dependency when
using `SavedObject` type from it's new home in
`core-saved-object-server`:

`core-saved-objects-server` -> `core-saved-objects-api-server` ->
`core-saved-objects-server`

One solution is that we can create a new package
`packages/core/saved-objects/core-saved-objects-server-shared` that will
only hold the `SavedObject` type and a select few others. I'm not sure
what the best approach here is. I have left
`core-saved-objects-api-server` unchanged for now (i.e., it is still
importing `SavedObject` from `common` which is deprecated).

Any input would be greatly appreciated!

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-25 05:38:05 -07:00
..
src [Saved Objects] Import SO types from server rather than common to avoid deprecation (#149289) 2023-01-25 05:38:05 -07:00
index.ts chore(NA): remove src folder requirement from packages (part 2) (#138476) 2022-08-30 15:57:35 +01:00
jest.config.js Create common and api types packages for the savedObjects domain (#136722) 2022-07-26 04:01:33 -07:00
kibana.jsonc Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
package.json Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
README.md Create common and api types packages for the savedObjects domain (#136722) 2022-07-26 04:01:33 -07:00
tsconfig.json Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00

README.md

@kbn/core-saved-objects-common

This package contains the common types shared between the browser and server-side savedObjects APIs.