# Backport
This will backport the following commits from `main` to `8.6`:
- [[data view field editor] Fix runtime field format editor
(#148497)](https://github.com/elastic/kibana/pull/148497)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-01-09T15:33:12Z","message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Feature:Kibana
Management","backport:prev-minor","v8.7.0"],"number":148497,"url":"https://github.com/elastic/kibana/pull/148497","mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148497","number":148497,"mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}}]}]
BACKPORT-->
Co-authored-by: Matthew Kime <matt@mattki.me>
# Backport
This will backport the following commits from `main` to `8.6`:
- [[Dashboard] [Controls] Allow control changes to be discarded
(#147482)](https://github.com/elastic/kibana/pull/147482)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-19T21:55:31Z","message":"[Dashboard]
[Controls] Allow control changes to be discarded (#147482)\n\nCloses
https://github.com/elastic/kibana/issues/147293\r\n\r\n##
Summary\r\n\r\nBefore this change, the Redux state `explicitInput` was
getting out of\r\nsync with the embeddable `explicitInput` in scenarios
where the new\r\n`explicitInput` was missing a key that the old
`explicitInput` had -\r\ntherefore, because they were out of sync, the
changes that **should**\r\nhave been discarded kept getting injected
back into the embeddable\r\n`explicitInput`, which made it impossible to
actually discard anything\r\nunless the key existed in both the before
and after state.\r\n\r\nThis PR fixes this by replacing the entire Redux
state `explicitInput`\r\nwith the embeddable `explicitInput` rather than
spreading the new value.\r\nIt also fixes a bug with the time slider
control where changes to the\r\nembeddable's input were not reflected
properly in the control's state,\r\nso nothing could be discarded even
after the initial bug was fixed.\r\n\r\n#### Further Explanation
\r\n\r\nWhen a control is first created, all the optional properties of
the\r\nexplicit input do not yet exist - for example, when creating an
options\r\nlist control, the `selections` key does not exist in the
`explicitInput`\r\nuntil a selection is made. Therefore, imagine the
following scenario:\r\n\r\n1. You create an options list control (where
the `selections` key does\r\nnot exist) and save the dashboard\r\n2. You
make some selections, which causes `unsaved changes` because
the\r\n`selections` key now exists and is equal to an array\r\n3. You
switch to view mode and choose to discard your changes,
thus\r\n(supposedly) removing the `selections` key from the
`explicitInput`\r\nobject once again\r\n\r\nUnfortunately, the Redux
embeddable state for each control was **not**\r\naccurately removing the
`selections` key as expected - this was because,\r\nwhen trying to
update the `explicitInput` via the old\r\n`updateEmbeddableReduxInput`,
the new value was **spread** on top of the\r\nolder value rather than
replacing it. In a simplified scenario, this\r\nresulted in something
like this:\r\n\r\n```typescript\r\nconst oldExplicitInput = { id:
'test_id', selections: ['test selection'] };\r\nconst newExplicitInput =
{ id: 'test_id' }\r\nconst result = { ...oldExplicitInput,
...newExplicitInput };\r\n```\r\n\r\nIn this code, because
`newExplicitInput` does not have the `selections`\r\nkey, `result` will
equal `{ id: 'test_id', selections: ['test\r\nselection'] }` - this is
not the behaviour we want! Instead, we wanted\r\nto replace the entire
old `explicitInput` with the new `explicitInput`.\r\nEffectively, that
is what this PR does.\r\n\r\nThanks to @ThomThomson for helping out with
finding the root cause of\r\nthis after I got lost :)\r\n\r\n### How to
Test\r\nFor both options list and range slider controls, \r\n1. Create a
control of the desired type\r\n2. Save the dashboard \r\n3. Make some
sort of change that causes unsaved changes - for example,\r\nmake a
selection or, if an options list control, set `exclude` to `true`\r\n4.
Switch to view mode, discarding the changes\r\n5. Ensure that the
changes made in step 3 are no longer applied ✅ \r\n6. Switch back to
edit mode\r\n7. Ensure that there are no `unsaved changes` ✅
\r\n\r\n#### Flaky Test
Runner\r\n\r\n<a\r\nhref=\"207701101-69cdfada-77c6-4510-b254-1fd1fa13af5c.png\"/></a>\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7a6eac8d1bfe492b8dce83c7a0f47dc26706e388","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Feature:Input
Control","Team:Presentation","loe:days","impact:high","Project:Controls","backport:prev-minor","v8.7.0"],"number":147482,"url":"https://github.com/elastic/kibana/pull/147482","mergeCommit":{"message":"[Dashboard]
[Controls] Allow control changes to be discarded (#147482)\n\nCloses
https://github.com/elastic/kibana/issues/147293\r\n\r\n##
Summary\r\n\r\nBefore this change, the Redux state `explicitInput` was
getting out of\r\nsync with the embeddable `explicitInput` in scenarios
where the new\r\n`explicitInput` was missing a key that the old
`explicitInput` had -\r\ntherefore, because they were out of sync, the
changes that **should**\r\nhave been discarded kept getting injected
back into the embeddable\r\n`explicitInput`, which made it impossible to
actually discard anything\r\nunless the key existed in both the before
and after state.\r\n\r\nThis PR fixes this by replacing the entire Redux
state `explicitInput`\r\nwith the embeddable `explicitInput` rather than
spreading the new value.\r\nIt also fixes a bug with the time slider
control where changes to the\r\nembeddable's input were not reflected
properly in the control's state,\r\nso nothing could be discarded even
after the initial bug was fixed.\r\n\r\n#### Further Explanation
\r\n\r\nWhen a control is first created, all the optional properties of
the\r\nexplicit input do not yet exist - for example, when creating an
options\r\nlist control, the `selections` key does not exist in the
`explicitInput`\r\nuntil a selection is made. Therefore, imagine the
following scenario:\r\n\r\n1. You create an options list control (where
the `selections` key does\r\nnot exist) and save the dashboard\r\n2. You
make some selections, which causes `unsaved changes` because
the\r\n`selections` key now exists and is equal to an array\r\n3. You
switch to view mode and choose to discard your changes,
thus\r\n(supposedly) removing the `selections` key from the
`explicitInput`\r\nobject once again\r\n\r\nUnfortunately, the Redux
embeddable state for each control was **not**\r\naccurately removing the
`selections` key as expected - this was because,\r\nwhen trying to
update the `explicitInput` via the old\r\n`updateEmbeddableReduxInput`,
the new value was **spread** on top of the\r\nolder value rather than
replacing it. In a simplified scenario, this\r\nresulted in something
like this:\r\n\r\n```typescript\r\nconst oldExplicitInput = { id:
'test_id', selections: ['test selection'] };\r\nconst newExplicitInput =
{ id: 'test_id' }\r\nconst result = { ...oldExplicitInput,
...newExplicitInput };\r\n```\r\n\r\nIn this code, because
`newExplicitInput` does not have the `selections`\r\nkey, `result` will
equal `{ id: 'test_id', selections: ['test\r\nselection'] }` - this is
not the behaviour we want! Instead, we wanted\r\nto replace the entire
old `explicitInput` with the new `explicitInput`.\r\nEffectively, that
is what this PR does.\r\n\r\nThanks to @ThomThomson for helping out with
finding the root cause of\r\nthis after I got lost :)\r\n\r\n### How to
Test\r\nFor both options list and range slider controls, \r\n1. Create a
control of the desired type\r\n2. Save the dashboard \r\n3. Make some
sort of change that causes unsaved changes - for example,\r\nmake a
selection or, if an options list control, set `exclude` to `true`\r\n4.
Switch to view mode, discarding the changes\r\n5. Ensure that the
changes made in step 3 are no longer applied ✅ \r\n6. Switch back to
edit mode\r\n7. Ensure that there are no `unsaved changes` ✅
\r\n\r\n#### Flaky Test
Runner\r\n\r\n<a\r\nhref=\"207701101-69cdfada-77c6-4510-b254-1fd1fa13af5c.png\"/></a>\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7a6eac8d1bfe492b8dce83c7a0f47dc26706e388"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147482","number":147482,"mergeCommit":{"message":"[Dashboard]
[Controls] Allow control changes to be discarded (#147482)\n\nCloses
https://github.com/elastic/kibana/issues/147293\r\n\r\n##
Summary\r\n\r\nBefore this change, the Redux state `explicitInput` was
getting out of\r\nsync with the embeddable `explicitInput` in scenarios
where the new\r\n`explicitInput` was missing a key that the old
`explicitInput` had -\r\ntherefore, because they were out of sync, the
changes that **should**\r\nhave been discarded kept getting injected
back into the embeddable\r\n`explicitInput`, which made it impossible to
actually discard anything\r\nunless the key existed in both the before
and after state.\r\n\r\nThis PR fixes this by replacing the entire Redux
state `explicitInput`\r\nwith the embeddable `explicitInput` rather than
spreading the new value.\r\nIt also fixes a bug with the time slider
control where changes to the\r\nembeddable's input were not reflected
properly in the control's state,\r\nso nothing could be discarded even
after the initial bug was fixed.\r\n\r\n#### Further Explanation
\r\n\r\nWhen a control is first created, all the optional properties of
the\r\nexplicit input do not yet exist - for example, when creating an
options\r\nlist control, the `selections` key does not exist in the
`explicitInput`\r\nuntil a selection is made. Therefore, imagine the
following scenario:\r\n\r\n1. You create an options list control (where
the `selections` key does\r\nnot exist) and save the dashboard\r\n2. You
make some selections, which causes `unsaved changes` because
the\r\n`selections` key now exists and is equal to an array\r\n3. You
switch to view mode and choose to discard your changes,
thus\r\n(supposedly) removing the `selections` key from the
`explicitInput`\r\nobject once again\r\n\r\nUnfortunately, the Redux
embeddable state for each control was **not**\r\naccurately removing the
`selections` key as expected - this was because,\r\nwhen trying to
update the `explicitInput` via the old\r\n`updateEmbeddableReduxInput`,
the new value was **spread** on top of the\r\nolder value rather than
replacing it. In a simplified scenario, this\r\nresulted in something
like this:\r\n\r\n```typescript\r\nconst oldExplicitInput = { id:
'test_id', selections: ['test selection'] };\r\nconst newExplicitInput =
{ id: 'test_id' }\r\nconst result = { ...oldExplicitInput,
...newExplicitInput };\r\n```\r\n\r\nIn this code, because
`newExplicitInput` does not have the `selections`\r\nkey, `result` will
equal `{ id: 'test_id', selections: ['test\r\nselection'] }` - this is
not the behaviour we want! Instead, we wanted\r\nto replace the entire
old `explicitInput` with the new `explicitInput`.\r\nEffectively, that
is what this PR does.\r\n\r\nThanks to @ThomThomson for helping out with
finding the root cause of\r\nthis after I got lost :)\r\n\r\n### How to
Test\r\nFor both options list and range slider controls, \r\n1. Create a
control of the desired type\r\n2. Save the dashboard \r\n3. Make some
sort of change that causes unsaved changes - for example,\r\nmake a
selection or, if an options list control, set `exclude` to `true`\r\n4.
Switch to view mode, discarding the changes\r\n5. Ensure that the
changes made in step 3 are no longer applied ✅ \r\n6. Switch back to
edit mode\r\n7. Ensure that there are no `unsaved changes` ✅
\r\n\r\n#### Flaky Test
Runner\r\n\r\n<a\r\nhref=\"207701101-69cdfada-77c6-4510-b254-1fd1fa13af5c.png\"/></a>\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7a6eac8d1bfe492b8dce83c7a0f47dc26706e388"}}]}]
BACKPORT-->
# Backport
This will backport the following commits from `main` to `8.6`:
- [[Discover] Fix Discover navigation from Lens embeddable
(#147000)](https://github.com/elastic/kibana/pull/147000)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Dmitry
Tomashevich","email":"39378793+dimaanj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-14T13:17:17Z","message":"[Discover]
Fix Discover navigation from Lens embeddable (#147000)\n\n##
Summary\r\n\r\nFixes #146761\r\n\r\nThis PR fixes navigation to Discover
from Lens embeddable.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"1f04bf89a3df377c79dba225dd47c9a96dc3e395","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","auto-backport","Team:DataDiscovery","v8.7.0","v8.6.1"],"number":147000,"url":"https://github.com/elastic/kibana/pull/147000","mergeCommit":{"message":"[Discover]
Fix Discover navigation from Lens embeddable (#147000)\n\n##
Summary\r\n\r\nFixes #146761\r\n\r\nThis PR fixes navigation to Discover
from Lens embeddable.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"1f04bf89a3df377c79dba225dd47c9a96dc3e395"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147000","number":147000,"mergeCommit":{"message":"[Discover]
Fix Discover navigation from Lens embeddable (#147000)\n\n##
Summary\r\n\r\nFixes #146761\r\n\r\nThis PR fixes navigation to Discover
from Lens embeddable.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"1f04bf89a3df377c79dba225dd47c9a96dc3e395"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
# Backport
This will backport the following commits from `main` to `8.6`:
- [Unskip dashboard_unsaved_state.ts test
(#147215)](https://github.com/elastic/kibana/pull/147215)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Bhavya
RM","email":"bhavya@elastic.co"},"sourceCommit":{"committedDate":"2022-12-08T14:37:02Z","message":"Unskip
dashboard_unsaved_state.ts test
(#147215)","sha":"22e5040a9bafbccfb4f4c53a6115acdd822e3e18","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.6.0","v8.7.0"],"number":147215,"url":"https://github.com/elastic/kibana/pull/147215","mergeCommit":{"message":"Unskip
dashboard_unsaved_state.ts test
(#147215)","sha":"22e5040a9bafbccfb4f4c53a6115acdd822e3e18"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147215","number":147215,"mergeCommit":{"message":"Unskip
dashboard_unsaved_state.ts test
(#147215)","sha":"22e5040a9bafbccfb4f4c53a6115acdd822e3e18"}}]}]
BACKPORT-->
Co-authored-by: Bhavya RM <bhavya@elastic.co>
# Backport
This will backport the following commits from `main` to `8.6`:
- [quick check of current URL to skip timepicker
(#146462)](https://github.com/elastic/kibana/pull/146462)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Lee
Drengenberg","email":"lee.drengenberg@elastic.co"},"sourceCommit":{"committedDate":"2022-12-04T20:50:50Z","message":"quick
check of current URL to skip timepicker (#146462)\n\n##
Summary\r\n\r\nWe have some tests which set the default time but then
also call\r\nsetAbsoluteTime in every test. This PR adds code in
setAbsoluteTime to\r\nquickly check if the desired start and end (from
and to) times are\r\nalready set, and if so, just return. The end result
should be less time\r\nspent on functional tests. It could also reduce
occasional flakiness\r\nsetting the time.\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"1734b0e5db897453bcd532f2896234aa15db8139","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","test_ui_functional","test_xpack_functional","release_note:skip","backport:prev-minor","v8.7.0"],"number":146462,"url":"https://github.com/elastic/kibana/pull/146462","mergeCommit":{"message":"quick
check of current URL to skip timepicker (#146462)\n\n##
Summary\r\n\r\nWe have some tests which set the default time but then
also call\r\nsetAbsoluteTime in every test. This PR adds code in
setAbsoluteTime to\r\nquickly check if the desired start and end (from
and to) times are\r\nalready set, and if so, just return. The end result
should be less time\r\nspent on functional tests. It could also reduce
occasional flakiness\r\nsetting the time.\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"1734b0e5db897453bcd532f2896234aa15db8139"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146462","number":146462,"mergeCommit":{"message":"quick
check of current URL to skip timepicker (#146462)\n\n##
Summary\r\n\r\nWe have some tests which set the default time but then
also call\r\nsetAbsoluteTime in every test. This PR adds code in
setAbsoluteTime to\r\nquickly check if the desired start and end (from
and to) times are\r\nalready set, and if so, just return. The end result
should be less time\r\nspent on functional tests. It could also reduce
occasional flakiness\r\nsetting the time.\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"1734b0e5db897453bcd532f2896234aa15db8139"}}]}]
BACKPORT-->
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
# Backport
This will backport the following commits from `main` to `8.6`:
- [fix timepicker default start day
(#145947)](https://github.com/elastic/kibana/pull/145947)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Lee
Drengenberg","email":"lee.drengenberg@elastic.co"},"sourceCommit":{"committedDate":"2022-11-28T14:59:09Z","message":"fix
timepicker default start day (#145947)\n\n## Summary\r\n\r\nThis PR is
mainly some cleanup before another PR I have in the works to\r\nshortcut
timepicker.setAbsoluteTime() by checking if we already have
the\r\ndesired time set.\r\n\r\nThis PR changes the timePicker
defaultStartTimeUTC value from September\r\n18th to September 19th to
match the value of defaultStartTimeUTC.\r\nThe variable name
defaultStartTimeUTC implies it's a different timezone\r\nbut actually
it's the same date time but in a different ISO format.\r\nIt seems there
was only 1 place in tests which expected that Sep
18th\r\ndate.\r\n\r\nAnother small change
in\r\n`x-pack/test/functional/apps/lens/group1/text_based_languages.ts`
is to\r\nuse uiSettings.update insteda of uiSettings.replace. `replace`
wipes out\r\nthe default UTC timezone and the defaultTime
settings.\r\n\r\nI added a few calls to cleanStandardList to make sure
any saved objects\r\ncreated by the tests are cleaned up, and to get a
clean run if other\r\ntests left something.\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9c9c66cd0b16f7514b407912d1b0bbcb0cab00ac","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","test_ui_functional","release_note:skip","backport:prev-minor","v8.7.0"],"number":145947,"url":"https://github.com/elastic/kibana/pull/145947","mergeCommit":{"message":"fix
timepicker default start day (#145947)\n\n## Summary\r\n\r\nThis PR is
mainly some cleanup before another PR I have in the works to\r\nshortcut
timepicker.setAbsoluteTime() by checking if we already have
the\r\ndesired time set.\r\n\r\nThis PR changes the timePicker
defaultStartTimeUTC value from September\r\n18th to September 19th to
match the value of defaultStartTimeUTC.\r\nThe variable name
defaultStartTimeUTC implies it's a different timezone\r\nbut actually
it's the same date time but in a different ISO format.\r\nIt seems there
was only 1 place in tests which expected that Sep
18th\r\ndate.\r\n\r\nAnother small change
in\r\n`x-pack/test/functional/apps/lens/group1/text_based_languages.ts`
is to\r\nuse uiSettings.update insteda of uiSettings.replace. `replace`
wipes out\r\nthe default UTC timezone and the defaultTime
settings.\r\n\r\nI added a few calls to cleanStandardList to make sure
any saved objects\r\ncreated by the tests are cleaned up, and to get a
clean run if other\r\ntests left something.\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9c9c66cd0b16f7514b407912d1b0bbcb0cab00ac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145947","number":145947,"mergeCommit":{"message":"fix
timepicker default start day (#145947)\n\n## Summary\r\n\r\nThis PR is
mainly some cleanup before another PR I have in the works to\r\nshortcut
timepicker.setAbsoluteTime() by checking if we already have
the\r\ndesired time set.\r\n\r\nThis PR changes the timePicker
defaultStartTimeUTC value from September\r\n18th to September 19th to
match the value of defaultStartTimeUTC.\r\nThe variable name
defaultStartTimeUTC implies it's a different timezone\r\nbut actually
it's the same date time but in a different ISO format.\r\nIt seems there
was only 1 place in tests which expected that Sep
18th\r\ndate.\r\n\r\nAnother small change
in\r\n`x-pack/test/functional/apps/lens/group1/text_based_languages.ts`
is to\r\nuse uiSettings.update insteda of uiSettings.replace. `replace`
wipes out\r\nthe default UTC timezone and the defaultTime
settings.\r\n\r\nI added a few calls to cleanStandardList to make sure
any saved objects\r\ncreated by the tests are cleaned up, and to get a
clean run if other\r\ntests left something.\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9c9c66cd0b16f7514b407912d1b0bbcb0cab00ac"}}]}]
BACKPORT-->
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
# Backport
This will backport the following commits from `main` to `8.6`:
- [[Guided onboarding] Fix home redirect when on Cloud
(#145539)](https://github.com/elastic/kibana/pull/145539)
<!--- Backport version: 8.9.7 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Yulia
Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-22T17:11:46Z","message":"[Guided
onboarding] Fix home redirect when on Cloud
(#145539)","sha":"f0670b0a0ed5860397921002022e9650c387c648","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["loe:hours","release_note:skip","impact:critical","backport:prev-minor","Team:Journey/Onboarding","ci:cloud-deploy","v8.6.0","v8.7.0"],"number":145539,"url":"https://github.com/elastic/kibana/pull/145539","mergeCommit":{"message":"[Guided
onboarding] Fix home redirect when on Cloud
(#145539)","sha":"f0670b0a0ed5860397921002022e9650c387c648"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145539","number":145539,"mergeCommit":{"message":"[Guided
onboarding] Fix home redirect when on Cloud
(#145539)","sha":"f0670b0a0ed5860397921002022e9650c387c648"}}]}]
BACKPORT-->
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
https://github.com/elastic/kibana/pull/140739 caused a regression with
timeslider control where `ControlGroupContainer` was not not firing
`updateOutput` on `output.timeslice` changes.
This PR resolves the regression and adds functional tests to ensure
interactions with timeslider properly flow to dashboard saved search
panel
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* Removed comment of the issue that was referenced for the skip. But the tests were already skipped.
* Added a describe block for the tests that involve space b. There is an accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped.
* Added CCS Test for integration test.
* Added CCS config for getting started shakespeare tests.
* Removed unused reference.
* Restored tests.
Co-authored-by: cuffs <cuffs@cuffss-Office-MacBook-Pro.local>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Updated EUI to version 67.1.2. Updated instaces of ButtonColor from EUI to EuiButtonColor.
* Updated to EuiCard instances that utilize the betaBadgeProps object to return an empty string instead of undefined when the label is unavailable
* Removed two instances of the deprecated internetExplorerOnly() mixin
* Updated two instances of the ButtonColor import to EuiButtonColor as is was renamed in PR #6150
* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles
* Updated snapshots in Jest Test Suite #2 to account forEuiButton, EuiDescriptionList, EuiButtonIcon, and EuiBadge Emotion conversions.
* Updated snapshots in Jest Test Suite #3 to account for EuiDescriptionList, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles
* Updated snapshots in Jest Test Suite #4 to account for EuiButton Emotion conversion.
* Updated snapshots in Jest Test Suite #5 to account for EuiButton Emotion conversion.
* Updated snapshots in Jest Test Suite #8 to account for EuiButtonIcon and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
* Updated snapshots in Jest Test Suite #9 to account for EuiFlyout and EuiButton Emotion conversions.
* Updated snapshots in Jest Test Suite #10 to account for EuiButton, EuiBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles
* Updated instances of EuiButtonIconColor to use EuiButtonIconProps['color'] as it was removed in PR #6150
* Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions
* Added the EuiFlyout mixins and variables to Lens Sass file as EuiFlyout has been converted to Emotion and the Sass styles are no longer available in EUI
* Added the EuiCallOutTypes variable to Step Progress Sass file as EuiCallOut has been converted to Emotion and the Sass styles are no longer available in EUI
* Updated snapshots in Jest Test Suite #2 to account for recent Emotion conversions.
Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion.
Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Added imports for the added flyout mixin. Removed references to EuiCallOut mixin as the component has been converted to Emotion and is no longer available for use.
* Updated unit tests and snapshots in Jest Test Suite #10.
Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #11 that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #12 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #1 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #2 by updating tests that use EuiButton to simulate click events. Instead, these test have been updated to target a button element to prevent undefined click event errors.
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Updated reference to mixins Sass file.
Updated snapshots for Jest Test Suite #5 to account for EuiButton Emotion conversion. Updated unit tests that target EuiButton to simulate click events. These tests have been updated to target a button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suites 3, 7, 8, 13, and 14.
Updated snapshot to account for EuiButton Emotion conversion.
Updated tests that target EuiButton to simulate click events. These tests now target a generic button element to prevent undefined click event errors.
Updated a few snapshots by adding .render() before checking the snapshot. This will prevent large snapshots coming from recent Emotion conversions
* Updated snapshots in Jest Test Suite #10 to account for the recent EuiButton Emotion conversion
* Updated unit tests in Jest Test Suite #2 by editing tests that target EuiButton to simulate click events. These tests now target a button element in order to prevent undefinde click event errors
* Updated snapshots in Jest Test Suite #10 to account for EuiButton and EuiDescriptionList Emotion conversions
* Updated test cases in Jest Test Suites 3, 7, and 8. Updated snapshots to account for EuiButton and EuiPagination Emotion conversions.
Updated tests that target EuiButton to simulate click events. These tests now target a button element to prevent undefined click errors
* Updated test cases in Jest Test Suite 14. Updated snapshots to account for EuiButton Emotion conversion. Opted to use .render() when updating a few snapshots to reduce the large length of snapshots caused by Emotion
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Revised a change to betaBadgeProps to ensure that the label is available. If not, the value for the badge with be set to undefined.
* Resolved two linting errors
* Resolved two linting errors
* Updated Jest unit tests in various suites.
Updated snapshots to account for EuiButton Emotion conversion. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
* Updated EuiFlyout in query_flyout.tsx to remove the onClick function from maskProps as it is no longer available. Updated this flyout to use ownFocus and not to close when the overlay mask is clicked.
* Removed the use of EuiButtonIconColor in favor of EuiButtonIconProps['color']
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Updated Cypress test looking for strict equality on EuiPaginationButton class names to match a substring of the Emotion generated class name
* Removed unneeded debugging code. Updated snapshots for various test suites to account for the recent EuiButton Emotion conversion
* Updated a few EuiButton, EuiButtonEmpty, and EuiText components that set the color as ghost. The ghost color mode has been deprecated as of PR #6150. These components now are wrapped in EuiThemeProvider with a dark colorMode to create the previous ghost color.
* Resolved TS error with EuiCard betaBadgeProps
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Remove references to now-removed EuiFlyout CSS classes/vars
* Remove now-removed euiBadge className references
- Convert directly to EuiBadge instead of using CSS
- Remove confusing and now-possibly-irrelevant CSS badge overrides - left/right icons are now set via JSX and not via flex-direction
* Pre-emptively fix various euiOverlayMask CSS overrides
- this data attr isn't technically in yet but will be once https://github.com/elastic/eui/pull/6289 merges
- at the very least this isn't breaking any more than it currently already is!
* Update to v67.1.3
* v67.1.4
* Resolved test failing test case in Security/Manage/Blocklist. The test did not remove focus from the last combo box in the form, which didn't allow the disbaled attribute to be removed from the flyout submit button. I've updated the mock file for Blocklist to return focus to the first form element in the flyout to allow the disabled attribute to be removed.
* Updated snapshots to account for the recent EuiText Emotion conversion
* Fix Log's custom tooltips relying on EuiTooltip classNames that no longer exist
* Fix Vega vis custom tooltips relying on EuiTooltip classNames that no longer exist
- this one is trickier than Log's as it's not using React, so we need to use Emotion's Global to set a static className
* Convert remaining vega_vis.scss to Emotion
- as an example of how other global + non global styles could be handled in the future
* Fix references to removed `euiPaginationButton-isActive` className
- use aria-current attribute instead
* Added missing EuiFlyoutAnimation keyframes for EuiFlyout. This resolved test that failed because they used onAnimationEnd because the FlyoutAnimation could not be found.
* Reolved Jest Tests in suites 1 and 5. Updated snapshots to account for the recent EuiButton Emotion conversion. Updated snapshots for EuiToolTip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles.
* iterate on rules_list.test.tsx
* bump eui to v67.1.5
* Updatde snapshots for jest test suites to account for the recent EuiButton, EuiOverlayMask, EuiTooltip, and EuiBadge Emotion conversions
* Resolved failing security test by updating the target element for CONNECTOR_TITLE. EuiCard has recently been converted to Emotion and the card title is no longer wrapper in a span.
* Resolved failing test case in Runtime Fields. The modify runtime field test was failing because the combobox responsbible for adding and updating scripts was not appearing. The textbox did not appear because the shared setFieldScript function targets and toggles the script textbox when opening the flyout. When a runtime field is being modified, the toggle is already active and using the shared function will trigger the toggle again (losing access to the script textbox).
Also resolved an issue that prevented the warning EuiCallout to appear when changing the type of a runtime field from its original type. Resolved this by adding an enter keypress at the end of setFieldType function to confirm the type selection, thus triggering the EuiCallout
* Resolved two tests that were failing in Lens. These test were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name
* Quick fix in test case failing because of misspelling in data-test-sub
* Updated snapshot for Jest test case as EuiButton as recently been converted to Emotion
* Removed console.log statement. Oops!
* Resolved a failing test case in Lens. They were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name.
Updated a Security test case by giving a target button the data-test-subj attribute for easier querying
* Removed reference to EuiFlyout mixin as it has been converted to Emotion. Updated the reference to an interal copy of EuiFlyout styles
* Corrected spelling error in EuiFlyout animation in Lens app
* Update EUI with latest backport
* Update button snapshots
* fix another button snapshot
* More snapshot fixes
* [EuiButton][Security] Fix button relying on now-removed `euiButton__text` CSS
- replace removed CSS with `eui-textTruncate` util instead
- combine/DRY out unnecessary span - was affecting min-width of truncation util
+ increase screenshot diff limit - this was smaller than updating the actual baseline screenshots for whatever reason (likely render diff between local and CI)
* Fix remaining Jest tests affected by Emotion conversions
- because Emotion creates its own wrapper, `.first()` can no longer be used - prefer `.last()` instead
* Fix Jest test affected by EuiButton Emotion conversion + removed modifier class
- targeting the native DOM node + filtering by disabled true/false gets us back to the 'correct' lengths
* Fix + improve flyout test
- `.last()` changes to account for EuiButton Emotion conversion is needed, but the last onClose assertion still fails due to us having modified inputs, and the confirm modal being displayed
- split test into two separate tests - one testing the onClose call, and the other testing the confirm modal
* derpin
* Skip rules_list Jest suite
* Update new EuiButton snapshot
* Upgraded EUI version to 67.1.7
* [EuiCard] Update snapshots
* [EuiPopover] Update snapshots
* [QA] Fix missing Vega warn/error message colors
;_;
* [CI] Auto-commit changed files from 'node scripts/generate codeowners'
* Fix Lens kbnToolbarButton regressions
- Caused by flattening of EUI button CSS specificity
- background-color was previously relying on isDisabled CSS specificity to override its #fff color
- `text` color modifier & `!important` is no longer needed and overrides Emotion CSS flatly
- isDisabled class is no longer needed - euiButton no longer sets `pointer-events: none` on disabled buttons (fixes tooltip bug in webkit as well)
* Backport EUI 67.1.8 fixes
* Update EuiCard snapshots
* Fix EuiModal form wrapper causing overflow issues
- see https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal
* Workaround for `.kbnOverlayMountWrapper` mount point causing overflow issues
- not sure what all is using this modal service to be honest, but the wrapper is causing issues with the modal layout, this fixes overflow issues but will not fix any mask-image issues as a result
* more snapshot updates
* EuiButton - added textProps to EuiButton to prevent very long button names from spilling over outside of the container
* EuiButton - Update EuiButton related snapshots. Updated tests that target EuiButton directly to use a data-telementary-id for more specific element querying required by Emotion
* QA - Removed unnecessary comment in code
* Temporary fix for EuiCard[selectable][layout=horizontal] instances on security solutions' rule page
* Temporary fix for EuiCard[selectable][layout=horizontal] instances on osquery live query and canvas's datasource selector
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Fix CSS specificity, where canvas's solutionToolbarButton's background-color now takes precedence over EuiButton's primary styles
* Removed update to search_marker_tooltip that removed the euiTooltip styles and replaced then with Emotion styling. Added EuiTooltip Sass styles for the component to rely on to test for a styling bug that is causing the tooltip and the tooltip arrow to be out of sync with each other.
* Lint Sass file
* Lint Sass file
* Removed overflow:hidden style from .vgaVis_view as it was causing euiScrollStyles not to present the scroll bars in Vega Vis
* Remove typo from EuiButton textProps object. 'className' should not have been included in the actual class name
* Revert tooltip Sass
This reverts commit 20e6ead571, a5cd2de901, and c605cbd7b9
* Fix Emotion tooltip arrows
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Chandler Prall <chandler.prall@elastic.co>
* Mock first attempt at UI
* Add `exists` filter functionality
* Make `exists` selection change button
* Overwrite selections instead of disabling them
* Add support for negate to exists
* Add to diffing system
* Add toggle to disable `exists` query
* Clear `exists` selection when toggle is disabled + fix mocks
* Switch to tooltip instead of docs link
* Clean up popover logic
* Fix rendering through memoization
* Auto focus on search when popover opens
* Added Jest unit tests
* Beef up mock and add more Jest unit tests
* Add functional tests
* Split up popover in to smaller components
* Fix unit tests + functional test flakiness
* Fix flakiness a second time + add chaining tests
* Clean up code
* Add `exists` selection to validation
* Fix invalid bug
* Fix failing unit test
* More code clean up
* Add another functional test
* Apply styling changes
* Fix tests
* Fix a11y issues
* Remove validation
* Fix types
* Clean up `a11y` fix
* Fix jest test
* Address feedback
* Fix wording of tooltip
* [ts] set allowJs to true by default
* fix scripts/check_ts_projects, original implementation is now wildly inefficient
* produce stats in check_ts_projects to make sure it's actually working
* fix imports
* Added convert to lens support for tsvb table
* Added unit tests
* Added functional tests
* Some refactoring of table metric option config
* Fixed imports
* Some small refactoring
* Fix flaky test
* Fixed test
* Some small fixes
* Fixed test
* Add buttons with no functionality
* Added basic negate functionality
* Add `NOT` text when negated
* Clean up
* Add jest and functional tests
* Fix merge conflicts
* Rename `negate` to `exclude`
* Fix `unsaved changes` bug
* Move erase button back to beside search
* Clean up
* Add chaining functional tests
* Fix other unsaved changes bug
* Fix mobile view of popover
* Add option to disable exclude/include toggle
* Prevent unsaved changes bug for options list settings
* Add tooltip to run past timeout setting
* Address review comments
* Rename variable
* Set `exclude` to `false` when footer is hidden
* [Discover] Create unifiedHistogram plugin
* [Discover] Move discover resizable panels to unifiedHistogram
* [Discover] Replace DiscoverPanels with unifiedHistogram Panels
* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'
* [Discover] Fix types and limtis.yml for unifiedHistogram
* [Discover] Begin migrating layout and chart to unified_histogram
* [Discover] Update i18n keys from discover to unifiedHistogram
* [Discover] Update data-test-subj tags from discover to unifiedHistogram
* [Discover] Update classNames, ids, and scss to change discover to unifiedHistogram
* [Discover] Remove more references to discover from unifiedHistogram
* [Discover] Replace DiscoverServices with UnifiedHistogramServices
* [Discover] Replacing CHART_HIDDEN_KEY with chartHiddenKey prop
* [Discover] Add missing tsconfig references
* [Discover] Remove remaining references to discover from unifiedHistogram
* [Discover] Migrate HitsCounter to unifiedHistogram
* [Discover] Continue removing discover dependencies from unifiedHistogram
* [Discover] Replace SCSS with emotion
* [Discover] Changing PANELS_MODE to be internal
* [Discover] Clean up types
* [Discover] Clean up props and types
* [Discover] Update layout to use Chart component
* [Discover] Update discover_main_content
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* [Discover] Update discover_main_content to use UnifiedHistogramLayout, clean up unifiedHistogram implementation and props, add missing bundles
* [Discover] Fix missing styles in unifiedHistogram
* [Discover] Fix issue where mouse can get out of sync with the resize handle with the Discover resizable layout
* [Discover] Fix some Jest tests
* [Discover] Update discoverQueryHits to unifiedHistogramQueryHits in tests
* [Discover] Finish decoupling discover_main_content from unified histogram layout
* [Discover] Create useDiscoverHistogram hook and remove old histogram dependencies from Discover
* [Discover] Move functions to create chart data from discover to unifiedHistogram
* [Discover] Continue fixing broken Jest tests
* Revert unifiedHistogram.reloadSavedSearchButton removal
* [Discover] Add missing type export and a better suspense fallback
* [Discover] Make callback names consistent
* [Discover] Continue cleanup and add documentation to unifiedHistogram
* [Discover] Update genChartAggConfigs to take object
* [Discover] Update UnifiedHistogramHitsContext.number to total
* [Discover] Cleanup imports
* [Discover] Add support for hiding the entire top panel in the unified histogram by leaving all context props undefined
* [Discover] Fix broken discover_layout unit tests
* [Discover] Clean up naming in discover_main_content
* [Discover] Continue fixing Jest tests and adding new tests
* [Discover] Finish writing Jest tests
* [Discover] Fix conflicts with getVisualizeInformation and triggerVisualizeActions after merge
* [Discover] Fix hiding reset chart height button when default chart height
* [Discover] Update CODEOWNER file
* [Discover] Removed types for @link comments
* [Discover] Fix broken discover_layout.test.tsx file
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* Remove unnecessary global state from share URL
* Clean up
* Add functional tests
* Fix functional tests
* Undo removal of time range from global state in URL
* Clean up code
* Clean up functional tests
* Add warning when snapshot sharing with unsaved panel changes
* Modify how error is passed down
* Fix flakiness of new functional test suite
* Update snapshots + clean up imports
* Change wording of warning + colour of text
* Address first round of feedback
* Switch error state to button
* Added functional tests for convert to lens top n
* Updated tests to check metric with source field
* Improved test for last value mode
* Added test for static value
* Fixed nits
* Updated test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Added tests for converting metric with params, unsupported metrics and not valid panels.
* Added tests for color ranges.
* Added tests for gauge.
* Fixed tests.
* Added test for metric with params.
* Added test for invalid model.
* Added test for unsupported aggregation.
* Added test for sibling pipeline agg.
* Added parent pipeline agg tests.
* Added functional tests for static value.
* Added tests for converting metric with params, unsupported metrics and not valid panels.
* Added tests for color ranges.
