Commit graph

270 commits

Author SHA1 Message Date
Kibana Machine
6fd64ee078
[8.6] [data view field editor] Fix runtime field format editor (#148497) (#148554)
# Backport

This will backport the following commits from `main` to `8.6`:
- [[data view field editor] Fix runtime field format editor
(#148497)](https://github.com/elastic/kibana/pull/148497)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-01-09T15:33:12Z","message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Feature:Kibana
Management","backport:prev-minor","v8.7.0"],"number":148497,"url":"https://github.com/elastic/kibana/pull/148497","mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148497","number":148497,"mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
2023-01-09 10:09:18 -07:00
Bree Hall
4e9f1c0d04
Bumping EUI to version 67.1.8 (#141279)
* Updated EUI to version 67.1.2. Updated instaces of ButtonColor from EUI to EuiButtonColor.

* Updated to EuiCard instances that utilize the betaBadgeProps object to return an empty string instead of undefined when the label is unavailable

* Removed two instances of the deprecated internetExplorerOnly() mixin

* Updated two instances of the ButtonColor import to EuiButtonColor as is was renamed in PR #6150

* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles

* Updated snapshots in Jest Test Suite #2 to account forEuiButton, EuiDescriptionList, EuiButtonIcon, and EuiBadge Emotion conversions.

* Updated snapshots in Jest Test Suite #3 to account for EuiDescriptionList, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles

* Updated snapshots in Jest Test Suite #4 to account for EuiButton Emotion conversion.

* Updated snapshots in Jest Test Suite #5 to account for EuiButton Emotion conversion.

* Updated snapshots in Jest Test Suite #8 to account for EuiButtonIcon and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.

* Updated snapshots in Jest Test Suite #9 to account for EuiFlyout and EuiButton Emotion conversions.

* Updated snapshots in Jest Test Suite #10 to account for EuiButton, EuiBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles

* Updated instances of EuiButtonIconColor to use EuiButtonIconProps['color'] as it was removed in PR #6150

* Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions

* Added the EuiFlyout mixins and variables to Lens Sass file as EuiFlyout has been converted to Emotion and the Sass styles are no longer available in EUI

* Added the EuiCallOutTypes variable to Step Progress Sass file as EuiCallOut has been converted to Emotion and the Sass styles are no longer available in EUI

* Updated snapshots in Jest Test Suite #2 to account for recent Emotion conversions.
Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion.
Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Added imports for the added flyout mixin. Removed references to EuiCallOut mixin as the component has been converted to Emotion and is no longer available for use.

* Updated unit tests and snapshots in Jest Test Suite #10.
Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #11 that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #12 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #1 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #2 by updating tests that use EuiButton to simulate click events. Instead, these test have been updated to target a button element to prevent undefined click event errors.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Updated reference to mixins Sass file.
Updated snapshots for Jest Test Suite #5 to account for EuiButton Emotion conversion. Updated unit tests that target EuiButton to simulate click events. These tests have been updated to target a button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suites 3, 7, 8, 13, and 14.
Updated snapshot to account for EuiButton Emotion conversion.
Updated tests that target EuiButton to simulate click events. These tests now target a generic button element to prevent undefined click event errors.
Updated a few snapshots by adding .render() before checking the snapshot. This will prevent large snapshots coming from recent Emotion conversions

* Updated snapshots in Jest Test Suite #10 to account for the recent EuiButton Emotion conversion

* Updated unit tests in Jest Test Suite #2 by editing tests that target EuiButton to simulate click events. These tests now target a button element in order to prevent undefinde click event errors

* Updated snapshots in Jest Test Suite #10 to account for EuiButton and EuiDescriptionList Emotion conversions

* Updated test cases in Jest Test Suites 3, 7, and 8. Updated snapshots to account for EuiButton and EuiPagination Emotion conversions.
Updated tests that target EuiButton to simulate click events. These tests now target a button element to prevent undefined click errors

* Updated test cases in Jest Test Suite 14. Updated snapshots to account for EuiButton Emotion conversion. Opted to use .render() when updating a few snapshots to reduce the large length of snapshots caused by Emotion

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Revised a change to betaBadgeProps to ensure that the label is available. If not, the value for the badge with be set to undefined.

* Resolved two linting errors

* Resolved two linting errors

* Updated Jest unit tests in various suites.
Updated snapshots to account for EuiButton Emotion conversion. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.

* Updated EuiFlyout in query_flyout.tsx to remove the onClick function from maskProps as it is no longer available. Updated this flyout to use ownFocus and not to close when the overlay mask is clicked.

* Removed the use of EuiButtonIconColor in favor of EuiButtonIconProps['color']

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Updated Cypress test looking for strict equality on EuiPaginationButton class names to match a substring of the Emotion generated class name

* Removed unneeded debugging code. Updated snapshots for various test suites to account for the recent EuiButton Emotion conversion

* Updated a few EuiButton, EuiButtonEmpty, and EuiText components that set the color as ghost. The ghost color mode has been deprecated as of PR #6150. These components now are wrapped in EuiThemeProvider with a dark colorMode to create the previous ghost color.

* Resolved  TS error with EuiCard betaBadgeProps

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Remove references to now-removed EuiFlyout CSS classes/vars

* Remove now-removed euiBadge className references

- Convert directly to EuiBadge instead of using CSS

- Remove confusing and now-possibly-irrelevant CSS badge overrides - left/right icons are now set via JSX and not via flex-direction

* Pre-emptively fix various euiOverlayMask CSS overrides

- this data attr isn't technically in yet but will be once https://github.com/elastic/eui/pull/6289 merges

- at the very least this isn't breaking any more than it currently already is!

* Update to v67.1.3

* v67.1.4

* Resolved test failing test case in Security/Manage/Blocklist. The test did not remove focus from the last combo box in the form, which didn't allow the disbaled attribute to be removed from the flyout submit button. I've updated the mock file for Blocklist to return focus to the first form element in the flyout to allow the disabled attribute to be removed.

* Updated snapshots to account for the recent EuiText Emotion conversion

* Fix Log's custom tooltips relying on EuiTooltip classNames that no longer exist

* Fix Vega vis custom tooltips relying on EuiTooltip classNames that no longer exist

- this one is trickier than Log's as it's not using React, so we need to use Emotion's Global to set a static className

* Convert remaining vega_vis.scss to Emotion

- as an example of how other global + non global styles could be handled in the future

* Fix references to removed `euiPaginationButton-isActive` className

- use aria-current attribute instead

* Added missing EuiFlyoutAnimation keyframes for EuiFlyout. This resolved test that failed because they used onAnimationEnd because the FlyoutAnimation could not be found.

* Reolved Jest Tests in suites 1 and 5. Updated snapshots to account for the recent EuiButton Emotion conversion. Updated snapshots for EuiToolTip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles.

* iterate on rules_list.test.tsx

* bump eui to v67.1.5

* Updatde snapshots for jest test suites to account for the recent EuiButton, EuiOverlayMask, EuiTooltip, and EuiBadge Emotion conversions

* Resolved failing security test by updating the target element for CONNECTOR_TITLE. EuiCard has recently been converted to Emotion and the card title is no longer wrapper in a span.

* Resolved failing test case in Runtime Fields. The modify runtime field test was failing because the combobox responsbible for adding and updating scripts was not appearing. The textbox did not appear because the shared setFieldScript function targets and toggles the script textbox when opening the flyout. When a runtime field is being modified, the toggle is already active and using the shared function will trigger the toggle again (losing access to the script textbox).
Also resolved an issue that prevented the warning EuiCallout to appear when changing the type of a runtime field from its original type. Resolved this by adding an enter keypress at the end of setFieldType function to confirm the type selection, thus triggering the EuiCallout

* Resolved two tests that were failing in Lens. These test were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name

* Quick fix in test case failing because of misspelling in data-test-sub

* Updated snapshot for Jest test case as EuiButton as recently been converted to Emotion

* Removed console.log statement. Oops!

* Resolved a failing test case in Lens. They were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name.
Updated a Security test case by giving a target button the data-test-subj attribute for easier querying

* Removed reference to EuiFlyout mixin as it has been converted to Emotion. Updated the reference to an interal copy of EuiFlyout styles

* Corrected spelling error in EuiFlyout animation in Lens app

* Update EUI with latest backport

* Update button snapshots

* fix another button snapshot

* More snapshot fixes

* [EuiButton][Security] Fix button relying on now-removed `euiButton__text` CSS

- replace removed CSS with `eui-textTruncate` util instead

- combine/DRY out unnecessary span - was affecting min-width of truncation util

+ increase screenshot diff limit - this was smaller than updating the actual baseline screenshots for whatever reason (likely render diff between local and CI)

* Fix remaining Jest tests affected by Emotion conversions

- because Emotion creates its own wrapper, `.first()` can no longer be used - prefer `.last()` instead

* Fix Jest test affected by EuiButton Emotion conversion + removed modifier class

- targeting the native DOM node + filtering by disabled true/false gets us back to the 'correct' lengths

* Fix + improve flyout test

- `.last()` changes to account for EuiButton Emotion conversion is needed, but the last onClose assertion still fails due to us having modified inputs, and the confirm modal being displayed

- split test into two separate tests - one testing the onClose call, and the other testing the confirm modal

* derpin

* Skip rules_list Jest suite

* Update new EuiButton snapshot

* Upgraded EUI version to 67.1.7

* [EuiCard] Update snapshots

* [EuiPopover] Update snapshots

* [QA] Fix missing Vega warn/error message colors

;_;

* [CI] Auto-commit changed files from 'node scripts/generate codeowners'

* Fix Lens kbnToolbarButton regressions

- Caused by flattening of EUI button CSS specificity

- background-color was previously relying on isDisabled CSS specificity to override its #fff color

- `text` color modifier & `!important` is no longer needed and overrides Emotion CSS flatly

- isDisabled class is no longer needed - euiButton no longer sets `pointer-events: none` on disabled buttons (fixes tooltip bug in webkit as well)

* Backport EUI 67.1.8 fixes

* Update EuiCard snapshots

* Fix EuiModal form wrapper causing overflow issues

- see https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal

* Workaround for `.kbnOverlayMountWrapper` mount point causing overflow issues

- not sure what all is using this modal service to be honest, but the wrapper is causing issues with the modal layout, this fixes overflow issues but will not fix any mask-image issues as a result

* more snapshot updates

* EuiButton - added textProps to EuiButton to prevent very long button names from spilling over outside of the container

* EuiButton - Update EuiButton related snapshots. Updated tests that target EuiButton directly to use a data-telementary-id for more specific element querying required by Emotion

* QA - Removed unnecessary comment in code

* Temporary fix for EuiCard[selectable][layout=horizontal] instances on security solutions' rule page

* Temporary fix for EuiCard[selectable][layout=horizontal] instances on osquery live query and canvas's datasource selector

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix CSS specificity, where canvas's solutionToolbarButton's background-color now takes precedence over EuiButton's primary styles

* Removed update to search_marker_tooltip that removed the euiTooltip styles and replaced then with Emotion styling. Added EuiTooltip Sass styles for the component to rely on to test for a styling bug that is causing the tooltip and the tooltip arrow to be out of sync with each other.

* Lint Sass file

* Lint Sass file

* Removed overflow:hidden style from .vgaVis_view as it was causing euiScrollStyles not to present the scroll bars in Vega Vis

* Remove typo from EuiButton textProps object. 'className' should not have been included in the actual class name

* Revert tooltip Sass

This reverts commit 20e6ead571, a5cd2de901, and c605cbd7b9

* Fix Emotion tooltip arrows

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Chandler Prall <chandler.prall@elastic.co>
2022-11-07 21:45:50 +00:00
Rashmi Kulkarni
e92b38415d
checking for flakiness of index pattern filter test (#144180)
* checking for flakiness of index pattern filter test

* added a small code change to check if the popover is open
2022-10-31 11:25:02 -07:00
Kibana Machine
293b2f852e skip failing test suite (#143109) 2022-10-25 08:04:02 -04:00
Matthew Kime
74595dee9b
[data view editor] Form state refactor - create service, replace useEffect with observables (#142421)
* replace useEffect with observables as much as possible

* cleanup, fix timestamp field / allow hidden bug
2022-10-18 07:22:35 -05:00
Matthew Kime
5319d66c97
reenable flakey test (#131397)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-10 07:45:46 -05:00
Julia Rechkunova
e35a7310e5
[Discover] Fix management flaky test (#141650)
* [Discover] Tmp commit

* [Discover] Update deprecated class

* [Discover] Wait for lens page to load
2022-09-26 18:49:21 +02:00
Anton Dosov
411fd13769
Unskip field format editor tests (#140822) 2022-09-22 04:43:04 -07:00
Julia Rechkunova
cae3a33de3
[Discover] New field stats in Discover sidebar popover (#139072)
* [UnifiedFieldList] Bootstrap a new unifiedFieldList plugin

* [UnifiedFieldList] Move backend API for field stats from Lens to UnifiedFieldList plugin

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* [Discover] Address CI checks

* [UnifiedFieldList] Move field stats UI from Lens to UnifiedFieldList plugin

* [Discover] Integrate FieldStats into Discover field popover

* [Discover] Show both views side to side

* [Discover] Allow for some customization

* [Discover] Allow for more customization

* [UnifiedFieldList] Remove temporary code

* [UnifiedFieldList] Extract styles

* [UnifiedFieldList] Fix after merge

* [UnifiedFieldList] Extend i18n

* [UnifiedFieldList] Migrate stats API from server to public

* [UnifiedFieldList] Update types

* [UnifiedFieldList] Update Lens tests

* [UnifiedFieldList] Update Lens tests

* [UnifiedFieldList] Before merging

* [UnifiedFieldList] After merging

* [UnifiedFieldList] Refactor localization keys

* [UnifiedFieldList] Update types

* [UnifiedFieldList] Reintroduce server API for field stats and refactor integration tests

* [UnifiedFieldList] Update limits

* [UnifiedFieldList] Rename the component

* [UnifiedFieldList] Improve types

* [UnifiedFieldList] Add AbortController

* [UnifiedFieldList] Render counts in PopoverFooter in Lens

* [UnifiedFieldList] Hide new stats from Discover for now

* [UnifiedFieldList] Fix tests

* [UnifiedFieldList] Rename to loadFieldStats

* [UnifiedFieldList] Rearrange utils

* [UnifiedFieldList] Fix types

* [UnifiedFieldList] Fix references

* [UnifiedFieldList] Use emotion css

* [UnifiedFieldList] Increase limits

* [UnifiedFieldList] Add first tests

* [UnifiedFieldList] Add more tests

* [UnifiedFieldList] Refactor interface to accept services object

* [UnifiedFieldList] Update types

* [UnifiedFieldList] Add docs

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* [UnifiedFieldList] Add missing references

* [UnifiedFieldList] Tmp

* [UnifiedFieldList] Revert changes from Discover for now

* Revert "[UnifiedFieldList] Revert changes from Discover for now"

This reverts commit 3f4ae6e395.

* [Discover] Extract top values UI into a separate component. Update colors.

* [Discover] Extract bucket UI into a separate component. Update colors.

* [Discover] Update styling

* [Discover] Fix empty values

* [Discover] Allow to customize colors

* [Discover] Add filter buttons

* [Discover] Rename props

* [Discover] Improve format

* [Discover] Add a switch in Settings. Move Visualize button into PopoverFooter.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* [Discover] Fix props

* [Discover] Hide filter buttons for Other section

* [Discover] Simplify default messages when analysis is not available

* [Discover] Small update

* [Discover] Remove translations

* [Discover] Update some tests

* [Discover] Fallback to old Discover logic and show examples for non-aggregatable fields

* [Discover] Exclude vector fields

* [Discover] Don't call details unless for legacy code

* [Discover] Fix types

* [Discover] Small update for stories

* [Discover] Adapt tests

* [Discover] Update tests

* [Discover] Update tests

* [Discover] Update tests

* [Discover] Update tests

* [Discover] Update tests

* [Discover] Add tooltips. Update examples sample values. Update tests.

* [Discover] Close the popover when filter is pressed

* [Discover] Add functional tests for non-aggregatable fields

* [Discover] Fix query

* [Discover] Add more tests

* [Discover] Add more tests

* [Discover] Add more tests

* [Discover] Add more tests

* [Discover] Fix time range for field stats

* [Discover] Remove sort param from examples query

* [Discover] Prevent reduntant requests

* [Discover] Increase examples size

* [Discover] Add exist filter to Discover popover

* [Discover] Update label

* [Discover] Update logic for picking a multifield

* [Discover] Fix how percentage is calculated for Examples view (non-aggregatable fields)

* [Discover] Update copy and uncomment console error

* [Discover] Add "no data" message and update field type check in examples

* [Discover] Update type checks and no-data copy

* [Discover] Update copy

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-09-15 14:26:41 +02:00
Matthew Kime
bcf8c79bb3
[data view field editor] Composite runtime field editor (#136954)
* Initial commit

* [Runtime field editor] Composite runtime in Kibana Data Views (#110226)

* Apply updates from feature branch

* Fix TS issues

* Fix TS issue

* Fix TS issue

* Fix jest tests

* fix jest tests

* fix integration test

* fix delete error test

* partial progress

* partial progress

* remove mistaken change

* fix import

* remove unused translation

* partial progress

* merge

* use preview api

* cleanup

* use specific index instead of index pattern

* fix jest test

* one less any

* setting type on composite subfields is roughly working

* partial progress

* setState not working

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* partial progress

* working but a bit wonky

* merge

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix handing of field types, remove some console.log statements

* fix initial type for subfields

* fix subfield type updates, rename some vars

* fix breakage from bad merge

* fix types

* type fixes

* cleanup

* i18n fix

* i18n fix

* i18n fix

* comment cleanup

* remove unused var

* add code comment

* remove comments

* fix jest test

* add start of functional test

* functional test:

* composite subfield preview

* add functional test

* functional tests

* functional tests

* rendering improvements

* functional tests

* functional tests

* add jest test

* add jest test

* move to observables

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* cleanup

* better use of form lib

* type fixes

* cleanup

* add refresh button

* remove ts ignore

* improve dev docs

* internationalize text

* type fix

* delete should warn regarding subfields

* typescript fix

* redraws of FieldEditor would reset diff state. This fixes it.

* add placeholder text to code editor

* hook cleanup

* add getFieldPreviewChanges jest test

* add getFieldPreviewChanges jest test

* keep parent name in sync with preview when changed during script update

* fix test

* move subfields to observables

* fix jest tests

* fix jest tests

* fix save after field type change to composite

* previewFields to behaviorSubject

* fix test

Co-authored-by: Sébastien Loix <sabee77@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
2022-09-12 08:43:22 -05:00
Lee Drengenberg
a029e68e56
[Archive Migration] batch 5 of removing empty_kibana (#139410)
* remove use of empty_kibana es_archive

* remove empty_kibana archives again

* replace es_archiver/empty_kibana with cleanStandardList

* remove more empty_kibana uses

* add cleanup of a package

* remove comment

* move fleet_setup before epm, something not cleaning packages

* revert fleet_api_integration changes and restore empty_kibana
2022-08-27 11:24:39 +03:00
spalger
2576403be4 Revert "replace es_archiver/empty_kibana with cleanStandardList (#139324)"
This reverts commit 220578bf48.
2022-08-24 09:44:52 -07:00
Tim Sullivan
348d59c92d
[DataViews] fix behavior for loading a missing data view (#139044)
* [DataViews] fix behavior for loading a missing data view

* remove link text from error message

* add functional test

* update error toast notification title

* cleanups

* update content and add toastMessage

* revert change to error message params

* update content per feedback

* error might be null-ish

* fix bug
2022-08-24 09:12:28 -07:00
Lee Drengenberg
220578bf48
replace es_archiver/empty_kibana with cleanStandardList (#139324) 2022-08-24 09:53:31 -06:00
liza-mae
6e87b01f85
Fix cloud test failures for 8.4 (#139155)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-22 17:52:13 -06:00
John Dorlus
ba4f11f7e9
Add CCS Tests For Data Views (#138861)
* Updated test to use uiSettings.

* Added ccs tests for data views.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Added more tests.

* Removed exclusive suites

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Reenabled all other CCS tests.

* Fixed merge conflict.

* Removed this from beforeeach and aftereach calls.

* Removed erroneous comment.

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-17 18:36:34 -04:00
liza-mae
94b51c4da5
Fix management test to run against cloud (#138656)
* Fix test to run against cloud

* Keep original names
2022-08-11 13:02:41 -06:00
John Dorlus
380a8b8705
Switched _handle_alias and _scripted_fields to use UI settings to change date and time instead of time picker. (#135866)
* Switched _handle_alias and _scripted_fields to use UI settings to change time.

* Removed commented code.
2022-07-06 21:52:47 -04:00
Kibana Machine
a530305204 skip failing test suite (#135110) 2022-06-28 10:00:20 -04:00
Shivindera Singh
c8520f941a
show empty prompts in page and don't auto-open flyout in DataViews (#134469)
* show empty prompts in page and don't auto-open flyout in DataViews

* changed flow based on comments

* fix for namespace issues

* fix for failed checks

* fixes for failed checks and tests

* fix failing tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-06-28 02:12:19 -07:00
Dmitry Tomashevich
88c25a9373
[Discover] Cleanup uses of legacy table in functional tests (#134638)
* [Discover] extract doc table tests into a new folder

* [Discover] switch to data grid

* [Discover] apply suggestions

* [Discover] adapt scripted fields tests for data grid

* [Discover] apply suggestions

* [Discover] apply for another part
2022-06-23 12:54:28 +03:00
Matthias Wilhelm
961b47a08b
[Discover] Remove _type of uiSettings metaFields (#134453)
Remove the deprecated _type of metaFields to prevent from showing up in Discover's sidebar
2022-06-17 20:09:25 +02:00
Shivindera Singh
5731d1aa58
ability to set human readable title of data view & ability to edit data view (#124191)
* ability to set human readable title of data view & ability to edit data view

* add readable data view title to discover

* fix for failing API test

* fix and add functional tests

* add missing lens support

* update snapshots after name change

* fix for broken test and type checks

* fix condition check

* remove description, rename readableTitle to name and fixes

* revert kibana.yaml change

* fixes for failed tests

* fixes for broken tests

* fix functional tests 2

* add confirm modal for edit

* update header to match figma

* fix data views with index pattern

* fix for badge breaking in test due to index change

* remove unused translations

* comment fixes and add name to sample data

* fix test for adding names to sample data

* some ui changes

* fix for failing tests for removing Actions

* comment fixes, change edit modal, fix breadcrumbs

* change copy and fix for failing tests

* change text to have unique key

* update jest snapshots

* fixes for unified_search and some ui changes

* add test fixes and disabled editing data view id when in edit mode

* fix for translation bug

* fix for failing tests

* review comment changes

* some nit fixes

* revert the operation change check

* fixed name not showing in dashboard with visualizations from different dataviews

* added a comment for the management breadcrumb
2022-06-08 09:59:41 -07:00
Lee Drengenberg
47f299421b
[Archive Migration] Kbn archiver management (#133675)
* remove kibana saved object from the esArchive

* migrate management from esArchive to kbnArchive

* migrate management from esArchive to kbnArchive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-06-07 19:41:48 +02:00
Matthew Kime
606d9c2649
[data view mgmt] add saved object relationships to data view management (#132385)
* add saved object relationships to data view management
2022-05-24 05:01:39 -05:00
Spencer
542b381fa5
[ftr] automatically determine config run order (#130983)
* [ftr] automatically determine config run order

* split lens config into two groups

* support ftr configs always running against CI

* Split detection_engine_api_integration rule exception list tests

* Add configs from previous commit

* [ftr] remove testMetadata and maintain a unique lifecycle instance per run

* Revert "[ftr] remove testMetadata and maintain a unique lifecycle instance per run"

This reverts commit d2b4fdb824.

* Split alerting_api_integration/security_and_spaces tests

* Add groups to yaml

* Revert "Revert "[ftr] remove testMetadata and maintain a unique lifecycle instance per run""

This reverts commit 56232eea68.

* stop ES more forcefully and fix timeout

* only cleanup lifecycle phases when the cleanup is totally complete

* only use kill when cleaning up an esTestInstance

* fix broken import

* fix runOptions.alwaysUseSource implementation

* fix config access

* fix x-pack/ccs config

* fix ml import file paths

* update kibana build id

* revert array.concat() change

* fix baseConfig usage

* fix pie chart data

* split up maps tests

* pull in all of group5 so that es archives are loaded correctly

* add to ftr configs.yml

* fix pie chart data without breaking legacy version

* fix more pie_chart stuff in new vis lib

* restore normal PR tasks

* bump kibana-buildkite-library

* remove ciGroup validation

* remove the script which is no longer called from checks.sh

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* adapt flaky test runner scripts to handle ftrConfig paths

* fix types in alerting_api_integration

* improve flaky config parsing and use non-local var name for passing explicit configs to ftr_configs.sh

* Split xpack dashboard tests

* Add configs

* [flaky] remove key from ftr-config steps

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* restore cypress builds

* remove ciGroups from FTR config files

* fixup some docs

* add temporary script to hunt for FTR config files

* use config.base.js naming for clarity

* use script to power ftr_configs.yml

* remove usage of removed x-pack/scripts/functional_tests

* fix test names in dashboard snapshots

* bump kibana-buildkite-library

* Try retrying only failed configs

* be a little quieter about trying to get testStats from configs with testRunners defined

* Remove test code

* bump kibana-buildkite-library

* update es_snapshot and on_merge jobs too

* track duration and exit code for each config and print it at the end of the script

* store results in order, rather than by key, in case there are duplicates in $config

* bash is hard

* fix env source and use +e rather than disabling e for whole file

* bash sucks

* print config summary in jest jobs too

* define results in jest_parallel.sh

* simplify config summary print, format times a little better

* fix reference to unbound time variable, use better variable name

* skip the newline between each result

* finish with the nitpicking

* sync changes with ftr_configs.sh

* refuse to execute config files which aren't listed in the .buildkite/ftr_configs.yml

* fix config.edge.js base config import paths

* fix some readmes

* resolve paths from ftr_configs manifest

* fix readConfigFile tests

* just allow __fixtures__ configs

* list a few more cypress config files

* install the main branch of kibana-buildkite-library

* split up lens group1

* move ml data_visualizer tests to their own config

* fix import paths

* fix more imports

* install specific commit of buildkite-pipeline-library

* sort configs in ftr_configs.yml

* bump kibana-buildkite-library

* remove temporary script

* fix env var for limiting config types

* Update docs/developer/contributing/development-functional-tests.asciidoc

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>

* produce a JUnit report for saved objects field count

* apply standard concurrency limits from flaky test runner

* support customizing FTR concurrency via the env

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
2022-05-04 17:05:58 -05:00
spalger
3730dd0779 fix all violations 2022-04-16 01:37:30 -05:00
Matthew Kime
9c360f537b
[data view mgmt] fix flaky scripted fields test (#126992)
* more debugging

* more debugging

* more debugging

* add a couple of retries

* no reason to reset filter

* Update tabs.tsx

* Update _scripted_fields_filter.ts
2022-04-14 09:38:58 -05:00
Kibana Machine
f9dd12937b skip failing test suite (#130190) 2022-04-14 08:41:16 -05:00
Matthew Kime
716a3a02e9
[data view mgmt] Fix flaky functional test (#129971)
* restore index pattern filter test

* add retries

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-04-13 08:30:26 -05:00
Jonathan Budzenski
48783a0837 skip flaky suite. #128558 2022-03-27 12:47:25 -05:00
Nathan Reese
d7e17d78eb
[lens] include number of values in default terms field label (#127222)
* [lens] include number of values in default terms field label

* remove size from rare values

* revert changes to label with secondary terms

* fix jest tests

* i18n cleanup, fix lens smokescreen functional test

* functional test expects

* funcational test expect

* handle single value

* eslint

* revert changes to expect

* update functional test expect

* functional test expect update

* test expects

* expects

* expects

* expects

* expects

* expects

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-03-23 08:20:45 -06:00
Tiago Costa
629e0f3995
skip flaky suite (#126027) 2022-03-07 18:24:55 +00:00
Matthew Kime
8b82657d46
[data views] functional tests to typescript (#126977)
js => ts
2022-03-07 07:24:39 -06:00
Matthew Kime
0adb328a9a
[data views] Reenable data view validation functional test (#125892)
* reenable test
2022-03-07 07:24:14 -06:00
Rashmi Kulkarni
f8586a87d0
fix for a skipped test _scripted_fields_filter (#126866)
* fix for a skipped test

* cleanup
2022-03-04 14:02:09 -08:00
Matthew Kime
d89249852b
[data view management] Make data views sharable (#123991)
Make data views sharable
2022-02-24 07:31:37 -06:00
Tiago Costa
c257ea05be
skip flaky suite (#126027) 2022-02-21 13:38:26 +00:00
Christiane (Tina) Heiligers
ea9255342e
Disabled import button while no file is attached (#125180) 2022-02-10 10:43:30 -07:00
Tiago Costa
560ca276b3
skip flaky suite (#124663) 2022-02-10 02:43:29 +00:00
Shivindera Singh
01d479108b
allow filtering index pattern UI for runtime fields (#124114)
* allow filtering index pattern UI for runtime fields

* fix namespace error

* add multi select filters

* add fix for failing tests

* test fixes
2022-02-09 10:13:59 +01:00
Jean-Louis Leysens
ee9f01e925
Unskip test scripted fields preview (#124358)
* unskip test and change we how assert for expected states

* REVERT - added .only for flaky test runner

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-02-08 15:12:25 +01:00
Mikhail Shustov
38feafad72
Update ES client to canary.37 (#119791)
* upgrade es client to canary 37

* fix error in core

* mute error in test/

* mute incompatible errors

* unskip request_entity_too_large_exception test

* commit autofix

* unskip batch_size_bytes_exceeds_es_content_length test

* fix errors in Core code

* fix or mute errors in data plugin

* fix data_view_management

* fix error index_management

* fix x-pack/test errors

* fix watcher

* fix event_log

* fix data_enhanced

* fix uptime

* fix triggers_actions_ui

* fix transform

* fix reporting

* fix rule_registry

* fix timeline

* fix task_manager

* fix security_solution

* fix rule_registry

* fix fleet

* fix index_management

* fix lens

* fix maps

* fix ml

* fix observability

* bump to canary 8.1-2

* fix error in packages

* fix errors in core

* fix errors in data

* fix errors in discover

* fix some discover tests

* fix errors in telemetry

* fix alerting

* fix errors in apm

* fix errors in event_log

* fix errors in fleet

* fix errors in infra

* fix errors in lists

* mute errors in maps

* fix errors in ml

* fix errors in osquery

* fix errors in security_solution

* fix errors in stack_alerts

* fix errors in task_manager

* fix errors in timelines

* fix errors in transform

* fix errors in watcher

* fix errors in tests

* update docs

* adjust fleet code

* fix problem in fleet

* remove outdated _type from data plugin tests

* fix packages tests

* update type

* fix tests part 2

* Adds product header back to elasticsearch

* Updates API docs

* Fix Discover tests

* update alerting typings

* Fix type errors

* Import Sort type

* Update x-pack/plugins/security_solution/common/endpoint/data_loaders/index_fleet_server.ts

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>

* Remove double negation

* Fix snapshot conflict issues after merge from "main"

Co-authored-by: Christiane Heiligers <christiane.heiligers@elastic.co>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2021-12-24 14:43:53 +01:00
Matthew Kime
9a43472751
add negation index pattern functional test (#121594)
* add negation index pattern functional test
2021-12-20 06:24:34 -06:00
Tiago Costa
a949989af8
skip flaky suite (#118981) 2021-11-25 19:53:24 +00:00
Kyle Pollich
ec504d6dd1
[Fleet] Move Fleet Setup to start lifecycle (#117552)
* Call setup on fleet start, remove API calls

* Fix unused import

* Revert removal of setup API call

* Restructor fleetSetupCompleted promise

* Add logging + handle setup failures

* Restructure logging to mix of debug/info

* Maybe fix failing tests

* Try fixing tests again

* Fix another dashboard test

* Re-add output logs after merge

* Log non-fatal errors during Fleet setup on boot

* Don't rely on fleetSetupCompleted to be called

* Fix failing test

* Track fleet setup status to avoid double calls

* Use IIFE in place of Promise ctor

* Remove unnecessary fleetSetupStatus value

* Move non-error logs into setupFleet method

* Remove unused formatNonFatalErrors import

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-15 10:33:15 -05:00
Anton Dosov
a906706da8
Unskip add runtime field test (#118303) 2021-11-11 19:57:14 +01:00
Anton Dosov
822178a789
Unskip scripted field preview (#118323) 2021-11-11 18:12:19 +01:00
Anton Dosov
c53cccbe32
Unskip dataview validation test (#118318) 2021-11-11 18:12:05 +01:00
Brian Seeders
8ba9ebf592
[CI] Rebalance/split cigroups and speed up overall CI time (#118191) 2021-11-10 12:01:03 -05:00