Commit graph

213 commits

Author SHA1 Message Date
Yulia Čech
7ae7eecbcc
[8.8] [Ingest Pipelines] Unskip functional and a11y tests (#157173) (#157257)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Ingest Pipelines] Unskip functional and a11y tests
(#157173)](https://github.com/elastic/kibana/pull/157173)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yulia
Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-09T16:08:15Z","message":"[Ingest
Pipelines] Unskip functional and a11y tests (#157173)\n\n##
Summary\r\nFixes
https://github.com/elastic/kibana/issues/156015\r\nFixes
https://github.com/elastic/kibana/issues/156014\r\nFixes
https://github.com/elastic/kibana/issues/155924 \r\nFixes
https://github.com/elastic/kibana/issues/155914\r\n\r\nThe Ingest
Pipelines tests were broken because of a new pipeline\r\nintroduced in
https://github.com/elastic/elasticsearch/pull/95198 but\r\nthere was a
fix added in\r\nhttps://github.com/elastic/elasticsearch/pull/95621. The
last PR fixes\r\nthe error where it was not possible to delete the
pipeline in the tests.\r\nThis PR unskips the tests since they should
now work as
expected.","sha":"32bc5c77bbe5b17215715ea56c4a13593855323c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Deployment
Management","release_note:skip","Feature:Ingest Node
Pipelines","v8.8.0","v8.9.0"],"number":157173,"url":"https://github.com/elastic/kibana/pull/157173","mergeCommit":{"message":"[Ingest
Pipelines] Unskip functional and a11y tests (#157173)\n\n##
Summary\r\nFixes
https://github.com/elastic/kibana/issues/156015\r\nFixes
https://github.com/elastic/kibana/issues/156014\r\nFixes
https://github.com/elastic/kibana/issues/155924 \r\nFixes
https://github.com/elastic/kibana/issues/155914\r\n\r\nThe Ingest
Pipelines tests were broken because of a new pipeline\r\nintroduced in
https://github.com/elastic/elasticsearch/pull/95198 but\r\nthere was a
fix added in\r\nhttps://github.com/elastic/elasticsearch/pull/95621. The
last PR fixes\r\nthe error where it was not possible to delete the
pipeline in the tests.\r\nThis PR unskips the tests since they should
now work as
expected.","sha":"32bc5c77bbe5b17215715ea56c4a13593855323c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157173","number":157173,"mergeCommit":{"message":"[Ingest
Pipelines] Unskip functional and a11y tests (#157173)\n\n##
Summary\r\nFixes
https://github.com/elastic/kibana/issues/156015\r\nFixes
https://github.com/elastic/kibana/issues/156014\r\nFixes
https://github.com/elastic/kibana/issues/155924 \r\nFixes
https://github.com/elastic/kibana/issues/155914\r\n\r\nThe Ingest
Pipelines tests were broken because of a new pipeline\r\nintroduced in
https://github.com/elastic/elasticsearch/pull/95198 but\r\nthere was a
fix added in\r\nhttps://github.com/elastic/elasticsearch/pull/95621. The
last PR fixes\r\nthe error where it was not possible to delete the
pipeline in the tests.\r\nThis PR unskips the tests since they should
now work as
expected.","sha":"32bc5c77bbe5b17215715ea56c4a13593855323c"}}]}]
BACKPORT-->
2023-05-10 05:59:49 -07:00
Kibana Machine
075debc686 skip failing test suite (#155928) 2023-04-27 09:55:54 -04:00
Nick Peihl
98843eeef4
[Maps] Use PageObject service methods to fix flaky test (#155161)
Fixes #154913 

## Summary

Changes functional test to use the maps PageObject methods for entering
and exiting fullscreen. These methods provide better retry handling.
2023-04-18 16:22:49 -04:00
Kibana Machine
6259bb9098 skip failing test suite (#154913) 2023-04-17 12:03:49 -04:00
Devon Thomson
eb9cc11a7c
[Controls] Use EUI Selectable for Field search (#151231)
## Summary
Replaces Control field selection list with EUISelectable.
2023-02-24 09:39:15 -06:00
Nick Peihl
ace2c30c29
[Dashboard Usability] Unified panel options pane (#148301) 2023-02-02 16:30:31 -05:00
Walter Rafelsberger
0085aaea00
[ML] Transforms: Adds date picker to transform wizard for data view with time fields. (#149049)
Adds a date picker to the transform wizard for data views with time
fields. The time range will be applied to previews only.
2023-02-01 09:23:03 +01:00
Nick Peihl
ff5101d3c1
[Discover] Fix data-title attribute in savedsearch embeddable (#149078)
## Summary

Fixes an error where the `data-title` attribute in the `DiscoverGrid`
component was not getting updated when using a custom panel title via
the saved search embeddable `searchTitle` prop.

[This functional test was returning a false
positive](https://github.com/elastic/kibana/blob/main/test/functional/apps/dashboard/group5/data_shared_attributes.ts#L110-L124).
The previous test left a context menu open so the test was changing the
panel title of the first embeddable (a Lens embeddable) rather than the
saved search embeddable. As a result the bug in the saved search
embeddable was unnoticed.
2023-01-19 09:22:22 -05:00
Elena Stoeva
b0deb036e6
Fix a11y issues with cross cluster replication flyouts (#149069)
Fixes https://github.com/elastic/kibana/issues/135503, fixes
https://github.com/elastic/kibana/issues/135506

## Summary

This PR fixes the a11y issues in the Follower index flyout and the Auto
follower index flyout from the Cross cluster replication plugin.

Screenshots:
<img height="500" alt="Screenshot 2023-01-17 at 17 46 08"
src="https://user-images.githubusercontent.com/59341489/212985332-794a2b7e-3e12-4303-bcbd-ad63552f211c.png">
<img height="500" alt="Screenshot 2023-01-17 at 13 26 51"
src="https://user-images.githubusercontent.com/59341489/212987803-40062d53-3b34-4286-98fc-736264491b08.png">


Followed [these
instructions](https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-getting-started-tutorial.html#ccr-getting-started-tutorial)
to set up the cross cluster replication and the follower and
auto-follower indices.


### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-01-18 18:32:57 +00:00
Elena Stoeva
0ce1452bb0
Fix a11y for snapshot policy flyout (#148972)
## Summary

This PR fixes the a11y issue with the snapshot policy flyout described
in https://github.com/elastic/kibana/issues/134514.

Screenshot:
<img width="300" alt="Screenshot 2023-01-16 at 12 13 01"
src="https://user-images.githubusercontent.com/59341489/212687990-c601932c-26b4-484a-88c9-0cce968633f2.png">



### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-01-16 16:42:43 +00:00
Kibana Machine
c38aa618c5 skip failing test suite (#147667) 2022-12-20 12:38:38 -05:00
Spencer
2763af3a4e
[ftr] remove @types/mocha, define custom ambient-ftr-types (#147284)
After moving away from composite projects in the IDE we now have an
issue where projects like security solutions are getting `@types/jest`
and `@types/mocha` loaded up, even though the "types" compiler option in
security solutions focuses on jest. To fix this I've removed the
`@types/mocha` package, implemented/copied a portion of the mocha types
into a new `@kbn/ambient-ftr-types` package which can be used in ftr
packages to define the describe/it/etc. globals.

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-12-19 10:42:12 -07:00
Uladzislau Lasitsa
a068b2ec53
[Dashboard][Lens] Add "convert to lens" action to dashboard (#146363)
## Summary

Closes https://github.com/elastic/kibana/issues/147032
Completes part of: https://github.com/elastic/kibana/issues/144605

Added `convert to lens` action for panel in dashboards.

If legacy visualization can be converted, the notification 'dot' will
shown on context menu.
<img width="828" alt="Снимок экрана 2022-12-02 в 10 50 58"
src="https://user-images.githubusercontent.com/16915480/205253599-3f3f102e-8fdc-497c-9e81-a9e1a146687c.png">

New action looks like this:
<img width="781" alt="Снимок экрана 2022-12-02 в 10 52 42"
src="https://user-images.githubusercontent.com/16915480/205253909-79d65fd8-81d8-4cce-a61a-234d3996cf84.png">

After clicking by that action user will be navigate to lens page and see
the following, where user can replace legacy visualization to lens on
dashboard:
<img width="1347" alt="Снимок экрана 2022-12-02 в 10 53 23"
src="https://user-images.githubusercontent.com/16915480/205254013-6e26b54d-6b92-4da5-be64-01b2876ea847.png">

On save user also can replace panel on dashboard:
<img width="506" alt="Снимок экрана 2022-12-02 в 10 55 22"
src="https://user-images.githubusercontent.com/16915480/205254409-163ebf51-c075-4c9a-a070-cebc7001636d.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2022-12-13 15:36:38 +02:00
Quynh Nguyen (Quinn)
83bf248540
[ML] Add accessibility test for population and advanced job wizards (#146052) 2022-11-23 09:48:38 -07:00
Kibana Machine
5fc2cd8781 skip failing test suite (#145452) 2022-11-16 20:42:38 -05:00
Bhavya RM
d84a36dedc
A11y test for rules and connectors (#140665) 2022-11-16 14:11:36 -05:00
John Dorlus
f5acf76351
CCS Smoke Test for Remote Clusters and Index Management (#142423)
* Removed comment of the issue that was referenced for the skip. But the tests were already skipped.

* Added initial tests and page objects for remtoe clusters.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fixed the test and test names.

* removed exclusive suite.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fixed i18n issue.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Added more testing stuff.

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Added more testing stuff.

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Added test and stuff.

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fixed the tests. The only things to update now are the permissions so we stop using super user and also need to fix the cleanup.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fixed accessibility test to use new ccr page function.

* Fixed an error in checks.

* Restored original settings.

* Adjusted cleanup.

* Removed exclusive suite.

* Removed unused variable.

* Removed unused variable.

* Working with perms.

* Fixes per comments in PR.

* added follower index user.

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Added comment about super user issue.

* Removed the console.log.

* Fixed nits per PR.

* Removed extra assertion.

Co-authored-by: cuffs <cuffs@cuffss-Office-MacBook-Pro.local>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-01 01:14:21 -04:00
John Dorlus
dc5fd06a73
Added a describe block for the tests that involve space b. There is an accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped. (#144156) 2022-10-28 14:42:07 -04:00
Pierre Gayvallet
e9ae5700af
Bump elastic/elasticsearch to 8.4.0-canary.1 (#142816)
* Bump `elastic/elasticsearch` to `8.4.0-canary.1`

* fixing package violations

* some xpack violations

* remove more unused ts-expect-error

* started muting errors

* start adapting watcher

* fix more usages

* fix more usages

* fixing more usages

* just one more

* more usages

* infra usages

* moar types

* fix unit test

* adapt more usages

* fixes in FTR tests

* try to fix kbn/es-types

* last fixes?
2022-10-19 02:37:51 -07:00
Pete Harverson
640592a56a
[ML] Adds extra a11y tests for anomaly detection and DFA jobs (#142589) 2022-10-05 10:47:09 +01:00
Matthias Wilhelm
384ecc4b7b
[Graph] Unskip a11y functional test (#141798) 2022-09-29 12:43:47 +02:00
Dmitry Tomashevich
2b4f5d9a64
[Graph] Align Inspect requests experience with common approach (#141222)
* [Graph] hide inspect button when there is no relevant request content

* [Graph] fix functional

* [Graph] add common inspector

* [Discover] fix checks

* [Discover] apply suggestion
2022-09-29 11:19:58 +03:00
John Dorlus
16589af4ca
Observability a11y tests (#141266)
* Updated test to use uiSettings.

* Added initial files for observability a11y tests.

* Observability test for the guided setup.

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fixed dashboard merge conflict.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Changed the wait condition to reduce flakiness.

* Removed .only().

* Skipped a11y test after finding violation.

Co-authored-by: cuffs <cuffs@cuffss-Office-MacBook-Pro.local>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-26 15:01:20 -04:00
Marco Liberati
c8db4f2b6a
[Lens] Add accessibility and some functional tests for annotations (#140417)
*  Add accessibility tests for more layer types

* ♻️ Add index number to layer removal button test id

*  Add more missing dataviews tests

*  Add annotation helpers + refactor combobox option selection code

*  Re-align test id using lens prefix

*  Add basic functional test for query annotation

* ♻️ Always use index for remove layer test id

* ♻️ Small refactor

* 🐛 Fix new queryinput changes
2022-09-15 17:51:26 +02:00
Bhavya RM
275e319406
Dashboard panel a11y tests refactoring and addition of missing tests (#139597) 2022-08-30 14:24:54 -04:00
Andrew Tate
54a5ed586a
[Lens] migrate metric visualization IDs (#139251) 2022-08-24 11:38:55 +02:00
Rashmi Kulkarni
23d3ba2ff2
trying to unskip accessibility- dashboard_controls test - also tried on Flaky test runner ( *100) (#138859)
* trying on FTR

* removed the comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-23 15:55:36 -07:00
Bhavya RM
321e06a963
adding a note about skipped upgrade test (#139241) 2022-08-22 17:01:45 -04:00
Constance
7b11420ee9
Upgrade EUI to v62.0.3 (#138351)
* Upgrade to v62.0.3

* Update EUI i18n tokens

* Update html string snapshots

- Emotion CSS hash changed

* [EuiIcon] Update instances of `keyboardShortcut` icons to `keyboard`

* [EuiErrorBoundary] Update snapshots from Emotion conversion

* [EuiImage] Update snapshots, tests, and CSS to account for Emotion conversion

* [EuiImage][RTL] Fix test failures caused by EuiImage changes

* [EuiCommentList] Deprecate EuiCommentProps.type

* [EuiCommentList] Rename `timelineIcon` prop to `timelineAvatar`

- see https://github.com/elastic/eui/pull/6071

* [EuiCommentList] Fix selectors deprecated by Emotion conversion

* [EuiPopover][EuiCommentEvent][Enzyme] Fix mounted test failures caused by Emotion conversions

- Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct

* [EuiPopover] Deprecate `initialFocus={false}` as an option

see https://github.com/elastic/eui/pull/6044

* [EuiPopover] Rename `display=inlineBlock` to `inline-block`

- see https://github.com/elastic/eui/pull/5977

* [EuiPopover] Update snapshots from Emotion conversion

* [EuiPopover] Replace deprecated `.euiPopover__panel-isOpen` class with new `[data-popover-open]` attribute

* [EuiPopover][RTL] Fix test failures caused by not waiting for EuiPopover animation/transition

* Skip failing a11y tests

- test w/ similar error already skipped in another test above
- requires closing the popover for next test to pass
- not sure why delete action is no longer available

* Fix failing Security Cypress tests

* Attempt to squash flaky FTR tests around Add Filter popover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2022-08-12 16:40:58 -07:00
Tiago Costa
6cd06600f1
skip flaky suite #(135508) 2022-08-09 15:38:23 +01:00
Bhavya RM
3b0fc945aa
adding retry loop for stack_monitoring kibana_overview a11y test (#137997) 2022-08-04 10:48:24 -04:00
Bhavya RM
879029d6bd
Unskip stack_monitoring a11y test (#137542) 2022-08-01 18:05:45 -04:00
Bhavya RM
78da900fd4
Fixing skipped saved tags test along with adding a missing aria-label (#137234) 2022-07-27 15:55:56 -04:00
Tiago Costa
710432aa0a
skip flaky suite (#137136) 2022-07-26 02:54:45 +01:00
Tiago Costa
bf12ac2e6c
skip flaky suite (#135341) 2022-07-26 00:52:57 +01:00
Davey Holler
4b52441a53
[Enterprise Search] New overview page (#136586) 2022-07-22 11:15:05 -07:00
Byron Hulcher
f7d9705115
Add a11y test for Content and Elasticsearch apps (#136785) 2022-07-21 08:19:46 -04:00
Cavit Baturalp Gurdin
36ace3059b skip flaky suite (#136033) 2022-07-19 14:56:59 +02:00
Bhavya RM
ece51f2b94
unskipping tags test to skip a specific test (#136550) 2022-07-19 05:31:12 -04:00
Kibana Machine
a5b638680a skip failing test suite (#135339) 2022-07-14 17:41:49 -04:00
Rashmi Kulkarni
4e043fb903
trying to unskip a flaky test (#136353) 2022-07-14 10:03:32 -07:00
Tiago Costa
8f8db6da73
skip flaky suite (#136033) 2022-07-13 13:50:09 +01:00
Kibana Machine
f80c90b40b skip failing test suite (#136242) 2022-07-12 18:50:15 -04:00
Tiago Costa
dde4fd5fc9
skip flaky suite (#135196) 2022-07-12 22:15:24 +01:00
Bhavya RM
ae64bcf555
skipping one test in a11y tests for tags instead of all of them (#135986) 2022-07-08 06:18:38 -04:00
Bhavya RM
15190e2c82
unskipping tags a11y test (#135821) 2022-07-07 05:29:07 -04:00
Bhavya RM
bce1836e54
Replacing empty_kibana in xpack a11y tests with Kibana server's cleanStandardList function to fix test failures (#135657) 2022-07-06 09:23:18 -04:00
John Dorlus
b52ff2a10d
Cross cluster replication a11y tests (#135514)
* Added CCR a11y tests covering all screens.

* Fixed test that broke after update. Returned a method that was removed.

* Switched order of remote clusters a11y and ccr.

* Switched orders of ccr, snapshot and restore and remote cluster tets. They need to be ran in a certain order.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Bhavya RM <bhavya@elastic.co>
2022-07-04 15:56:39 -04:00
Bhavya RM
f1d8a370bc
Fixing the flakiness in openInspectorView method in inspector service (#135488) 2022-06-30 19:43:59 -04:00
Kibana Machine
54d5cc48ea skip failing test suite (#135339) 2022-06-28 12:16:47 -04:00