mirror of
https://github.com/elastic/kibana.git
synced 2025-04-20 16:03:20 -04:00
63338 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
|
9b343b4a78
|
[8.8] [Profiling]Fixing hardcoded version (#159021) (#159027)
# Backport This will backport the following commits from `main` to `8.8`: - [[Profiling]Fixing hardcoded version (#159021)](https://github.com/elastic/kibana/pull/159021) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-05T13:33:46Z","message":"[Profiling]Fixing hardcoded version (#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.1"],"number":159021,"url":"https://github.com/elastic/kibana/pull/159021","mergeCommit":{"message":"[Profiling]Fixing hardcoded version (#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159021","number":159021,"mergeCommit":{"message":"[Profiling]Fixing hardcoded version (#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> |
||
|
c8c026454b
|
[8.8] [APM] Display size for hidden indices in storage explorer (#158746) (#159019)
# Backport This will backport the following commits from `main` to `8.8`: - [[APM] Display size for hidden indices in storage explorer (#158746)](https://github.com/elastic/kibana/pull/158746) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2023-06-05T12:16:16Z","message":"[APM] Display size for hidden indices in storage explorer (#158746)\n\n- Adds `expand_wildcards: 'all'` to the Index stats API call to fix an\r\nissue with missing statistics for hidden data streams in storage\r\nexplorer\r\n- Fixes an issue with number of replicas not being displayed","sha":"16b9614de268eedc35c418b602ce16b8019c0a8e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","backport:prev-minor","v8.9.0"],"number":158746,"url":"https://github.com/elastic/kibana/pull/158746","mergeCommit":{"message":"[APM] Display size for hidden indices in storage explorer (#158746)\n\n- Adds `expand_wildcards: 'all'` to the Index stats API call to fix an\r\nissue with missing statistics for hidden data streams in storage\r\nexplorer\r\n- Fixes an issue with number of replicas not being displayed","sha":"16b9614de268eedc35c418b602ce16b8019c0a8e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158746","number":158746,"mergeCommit":{"message":"[APM] Display size for hidden indices in storage explorer (#158746)\n\n- Adds `expand_wildcards: 'all'` to the Index stats API call to fix an\r\nissue with missing statistics for hidden data streams in storage\r\nexplorer\r\n- Fixes an issue with number of replicas not being displayed","sha":"16b9614de268eedc35c418b602ce16b8019c0a8e"}}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co> |
||
|
cd27f98a73
|
[8.8] Change kibana.alert.evaluation.threshold unit to microseconds (#158703) (#159013)
# Backport This will backport the following commits from `main` to `8.8`: - [Change kibana.alert.evaluation.threshold unit to microseconds (#158703)](https://github.com/elastic/kibana/pull/158703) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T11:12:21Z","message":"Change kibana.alert.evaluation.threshold unit to microseconds (#158703)\n\nResolves #156255\r\nFixes #158204\r\nPartially reverts #154801\r\n\r\n[RFC\r\nDocument](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing)\r\n\r\n## Summary\r\n\r\nThis PR changes kibana.alert.evaluation.threshold unit to microseconds\r\nin AAD.\r\n\r\n|Case|Screenshot|\r\n|----|---|\r\n|Saved value in\r\nAAD| (#159007)
# Backport This will backport the following commits from `main` to `8.8`: - [Test for a failed clone during split migration (#158998)](https://github.com/elastic/kibana/pull/158998) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-06-05T09:24:28Z","message":"Test for a failed clone during split migration (#158998)\n\n## Summary\r\n\r\nAdds a test for #158733. This is based on the un-merged #158940, so see\r\nthe last commit\r\n[#6eafe910424414b5670e5f325accc59d87dd6dc4]( |
||
|
ab7bcb8846
|
[8.8] [RAM][SecuritySolution] Simplify rules list notify badge (#155500) (#157036)
# Backport This will backport the following commits from `main` to `8.8`: - [[RAM][SecuritySolution] Simplify rules list notify badge (#155500)](https://github.com/elastic/kibana/pull/155500) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T17:23:59Z","message":"[RAM][SecuritySolution] Simplify rules list notify badge (#155500)\n\n**Relates to:** https://github.com/elastic/security-team/issues/5308\r\n\r\n## Summary\r\n\r\nThis PR make improvements and simplifications to `RulesListNotifyBadge` component exported by `triggers_actions_ui` plugin spotted during [adoption](https://github.com/elastic/security-team/issues/5308) of this component in Security Solution.\r\n\r\n## Details\r\n\r\nThe list of the changes\r\n\r\n- Mixed controlled and uncontrolled state has been resolved in favour of controlled state. It means an external code is responsible to fetch and provide rule snooze settings to the component.\r\n- Loading state management has been moved inside the component. The only way to to set the component in loading state it to provide `undefined` for `snoozeSettings` input prop.\r\n- Popover's open/close state management has been moved inside the component. I haven't noticed any problems in tables (Stack Management Rules and Security Solution Rules) if there are multiple rules are shown with `RulesListNotifyBadge` rendered. In attempt to open another snooze popover a previous one closes automatically.\r\n- `rule` input prop has been renamed to `snoozeSettings`.\r\n- `isEditable` field has been moved to a separate `disabled` prop. `disabled` can accept a string which is considered as a disabled reason and displayed in a tooltip. It's quite helpful to display for example fetching errors.\r\n- `onRuleChanged` handler can return a promise so internal loading state persists until this promise resolved.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"a61c63dc07bd027ab93c20cd0bf4b7b1039072ea","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["refactoring","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rules","v8.8.0","v8.9.0"],"number":155500,"url":"https://github.com/elastic/kibana/pull/155500","mergeCommit":{"message":"[RAM][SecuritySolution] Simplify rules list notify badge (#155500)\n\n**Relates to:** https://github.com/elastic/security-team/issues/5308\r\n\r\n## Summary\r\n\r\nThis PR make improvements and simplifications to `RulesListNotifyBadge` component exported by `triggers_actions_ui` plugin spotted during [adoption](https://github.com/elastic/security-team/issues/5308) of this component in Security Solution.\r\n\r\n## Details\r\n\r\nThe list of the changes\r\n\r\n- Mixed controlled and uncontrolled state has been resolved in favour of controlled state. It means an external code is responsible to fetch and provide rule snooze settings to the component.\r\n- Loading state management has been moved inside the component. The only way to to set the component in loading state it to provide `undefined` for `snoozeSettings` input prop.\r\n- Popover's open/close state management has been moved inside the component. I haven't noticed any problems in tables (Stack Management Rules and Security Solution Rules) if there are multiple rules are shown with `RulesListNotifyBadge` rendered. In attempt to open another snooze popover a previous one closes automatically.\r\n- `rule` input prop has been renamed to `snoozeSettings`.\r\n- `isEditable` field has been moved to a separate `disabled` prop. `disabled` can accept a string which is considered as a disabled reason and displayed in a tooltip. It's quite helpful to display for example fetching errors.\r\n- `onRuleChanged` handler can return a promise so internal loading state persists until this promise resolved.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"a61c63dc07bd027ab93c20cd0bf4b7b1039072ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155500","number":155500,"mergeCommit":{"message":"[RAM][SecuritySolution] Simplify rules list notify badge (#155500)\n\n**Relates to:** https://github.com/elastic/security-team/issues/5308\r\n\r\n## Summary\r\n\r\nThis PR make improvements and simplifications to `RulesListNotifyBadge` component exported by `triggers_actions_ui` plugin spotted during [adoption](https://github.com/elastic/security-team/issues/5308) of this component in Security Solution.\r\n\r\n## Details\r\n\r\nThe list of the changes\r\n\r\n- Mixed controlled and uncontrolled state has been resolved in favour of controlled state. It means an external code is responsible to fetch and provide rule snooze settings to the component.\r\n- Loading state management has been moved inside the component. The only way to to set the component in loading state it to provide `undefined` for `snoozeSettings` input prop.\r\n- Popover's open/close state management has been moved inside the component. I haven't noticed any problems in tables (Stack Management Rules and Security Solution Rules) if there are multiple rules are shown with `RulesListNotifyBadge` rendered. In attempt to open another snooze popover a previous one closes automatically.\r\n- `rule` input prop has been renamed to `snoozeSettings`.\r\n- `isEditable` field has been moved to a separate `disabled` prop. `disabled` can accept a string which is considered as a disabled reason and displayed in a tooltip. It's quite helpful to display for example fetching errors.\r\n- `onRuleChanged` handler can return a promise so internal loading state persists until this promise resolved.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"a61c63dc07bd027ab93c20cd0bf4b7b1039072ea"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co> |
||
|
16f8c566ef
|
[8.8] [Migrations] Update all aliases with a single updateAliases() when relocating SO documents #158940 (#158992)
# Backport This will backport the following commits from `main` to `8.8`: - [[Migrations] Update all aliases with a single updateAliases() when relocating SO documents (#158940)](https://github.com/elastic/kibana/pull/158940) <!--- Backport version: Manual! --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) |
||
|
46217b9129
|
[8.8] Migrations: Don't auto-create temp index (#158182) (#158996)
# Backport This will backport the following commits from `main` to `8.8`: - [Migrations: Don't auto-create temp index (#158182)](https://github.com/elastic/kibana/pull/158182) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-06-04T22:34:08Z","message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:fix","Feature:Migrations","backport:prev-minor","v8.9.0"],"number":158182,"url":"https://github.com/elastic/kibana/pull/158182","mergeCommit":{"message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158182","number":158182,"mergeCommit":{"message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b"}}]}] BACKPORT--> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> |
||
|
a82751c745
|
[8.8] Refactor KibanaMigrator, improve readability, maintainability and UT (#155693) (#158953)
# Backport This will backport the following commits from `main` to `8.8`: - [Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)](https://github.com/elastic/kibana/pull/155693) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T12:47:40Z","message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","enhancement","technical debt","release_note:skip","backport:skip","Feature:Migrations","Epic:KBNA-7838","v8.9.0"],"number":155693,"url":"https://github.com/elastic/kibana/pull/155693","mergeCommit":{"message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155693","number":155693,"mergeCommit":{"message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
320433050b
|
[8.8] Upgrade EUI to v77.1.5 (#158976)
This is a backport EUI upgrade to Kibana v8.8.1 containing an `EuiCodeBlock` bugfix requested by the Observability team: https://github.com/elastic/kibana/issues/158644#issuecomment-1573397864 ## [`77.1.5`](https://github.com/elastic/eui/tree/v77.1.5) **Bug fixes** - Fixed `EuiCodeBlock` potentially incorrectly ignoring lines ending with a question mark when using the Copy button. ([#6794](https://github.com/elastic/eui/pull/6794)) - Fixed `EuiCodeBlock` to not include line numbers when copying content ([#6824](https://github.com/elastic/eui/pull/6824)) - Fixed the expanded row animation on `EuiBasicTable` causing cross-browser Safari issues ([#6826](https://github.com/elastic/eui/pull/6826)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
|
0773c44958
|
[8.8] [Security Solution] Elastic Security Assistant (#156933) (#158974)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Elastic Security Assistant (#156933)](https://github.com/elastic/kibana/pull/156933) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"spong@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T21:19:10Z","message":"[Security Solution] Elastic Security Assistant (#156933)\n\n## [Security Solution] Elastic Security Assistant\r\n\r\nThe _Elastic Security Assistant_ has entered the chat, integrating generative AI and large language models (LLMs) into the workflows of Elastic Security users.\r\n\r\nBring your alerts, events, rules, and data quality checks into the conversation.\r\n\r\n< |
||
|
7224b92a05
|
[8.8] [Telemetry] Log opt-in status at the INFO level (#158830) (#158971)
# Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Log opt-in status at the INFO level (#158830)](https://github.com/elastic/kibana/pull/158830) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T20:59:04Z","message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.9.0"],"number":158830,"url":"https://github.com/elastic/kibana/pull/158830","mergeCommit":{"message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158830","number":158830,"mergeCommit":{"message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> |
||
|
836308b411
|
Update reporting-settings.asciidoc (#158975)
Fixing space in the previous update ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) |
||
|
736a873571
|
Update reporting-settings.asciidoc (#158973)
adding {ess-icon} to the end of xpack.reporting.roles.enabled as this is a setting that is configurable through ESS admin console by the deployment adimin ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) |
||
|
d7df21aada
|
[Security solution] Second attempt at 8.8.1 GenAi Connector Feature Flag :) (#158939) | ||
|
b7064bd537
|
[8.8] [Profling] Adding Elastic agent instructions (#158936) (#158949)
# Backport This will backport the following commits from `main` to `8.8`: - [[Profling] Adding Elastic agent instructions (#158936)](https://github.com/elastic/kibana/pull/158936) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T16:13:29Z","message":"[Profling] Adding Elastic agent instructions (#158936)\n\n<img width=\"1249\" alt=\"Screenshot 2023-06-02 at 3 51 04 PM\"\r\nsrc=\" |
||
|
17559fa778
|
[8.8] [Guided onboarding] Fix Kibana crashing on Safari (#158825) (#158952)
# Backport This will backport the following commits from `main` to `8.8`: - [[Guided onboarding] Fix Kibana crashing on Safari (#158825)](https://github.com/elastic/kibana/pull/158825) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yulia Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T16:50:27Z","message":"[Guided onboarding] Fix Kibana crashing on Safari (#158825)","sha":"e2e03cac3b52fc590a93c3abb346d71af0b5eb6d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","Team:Journey/Onboarding","v8.9.0","v8.8.1"],"number":158825,"url":"https://github.com/elastic/kibana/pull/158825","mergeCommit":{"message":"[Guided onboarding] Fix Kibana crashing on Safari (#158825)","sha":"e2e03cac3b52fc590a93c3abb346d71af0b5eb6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158825","number":158825,"mergeCommit":{"message":"[Guided onboarding] Fix Kibana crashing on Safari (#158825)","sha":"e2e03cac3b52fc590a93c3abb346d71af0b5eb6d"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com> |
||
|
cb3763e935
|
[8.8] [Fleet] Fix bulk action selection error (#158914) (#158943)
# Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] Fix bulk action selection error (#158914)](https://github.com/elastic/kibana/pull/158914) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T15:18:07Z","message":"[Fleet] Fix bulk action selection error (#158914)","sha":"39a67ec337c9ea68a464023dcb9550ff7b0d1747","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.9.0","v8.8.1"],"number":158914,"url":"https://github.com/elastic/kibana/pull/158914","mergeCommit":{"message":"[Fleet] Fix bulk action selection error (#158914)","sha":"39a67ec337c9ea68a464023dcb9550ff7b0d1747"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158914","number":158914,"mergeCommit":{"message":"[Fleet] Fix bulk action selection error (#158914)","sha":"39a67ec337c9ea68a464023dcb9550ff7b0d1747"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> |
||
|
21beb7d50e
|
[8.8] [Enterprise Search] Fix broken indices page when an index with alias is closed (#158871) (#158938)
# Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Fix broken indices page when an index with alias is closed (#158871)](https://github.com/elastic/kibana/pull/158871) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T14:57:42Z","message":"[Enterprise Search] Fix broken indices page when an index with alias is closed (#158871)\n\n## Summary\r\n\r\nFix indices page when an index is closed. Added a check to see if the\r\nindex is closed by checking the flag\r\n`index.settings.index.verified_before_close` is set to true\r\n\r\n### Screen Recording\r\n\r\n\r\n |
||
|
b3a45ca88c
|
[8.8] [Synthetics] Update nav for app (#158535) (#158933)
# Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Update nav for app (#158535)](https://github.com/elastic/kibana/pull/158535) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-06-02T14:33:42Z","message":"[Synthetics] Update nav for app (#158535)","sha":"48c8aa64195b00e5f309dddc7c90e0653e308f23","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.9.0","v8.8.1"],"number":158535,"url":"https://github.com/elastic/kibana/pull/158535","mergeCommit":{"message":"[Synthetics] Update nav for app (#158535)","sha":"48c8aa64195b00e5f309dddc7c90e0653e308f23"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158535","number":158535,"mergeCommit":{"message":"[Synthetics] Update nav for app (#158535)","sha":"48c8aa64195b00e5f309dddc7c90e0653e308f23"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com> |
||
|
f4375f6c22
|
[8.8] [Data Views] Fix data view field update paths in documentation (#158900) (#158923)
# Backport This will backport the following commits from `main` to `8.8`: - [[Data Views] Fix data view field update paths in documentation (#158900)](https://github.com/elastic/kibana/pull/158900) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T14:02:54Z","message":"[Data Views] Fix data view field update paths in documentation (#158900)\n\n## Summary\r\n\r\nThis PR fixes the documentation for the \"update data view fields\" API which used an incorrect route in the provided examples (data-view instead of data_view)","sha":"40c75ed1a2f8f3d8a6ae91ee5dce4fd4bb7ef3da","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data Views","release_note:skip","docs","Team:DataDiscovery","backport:prev-minor","v8.9.0"],"number":158900,"url":"https://github.com/elastic/kibana/pull/158900","mergeCommit":{"message":"[Data Views] Fix data view field update paths in documentation (#158900)\n\n## Summary\r\n\r\nThis PR fixes the documentation for the \"update data view fields\" API which used an incorrect route in the provided examples (data-view instead of data_view)","sha":"40c75ed1a2f8f3d8a6ae91ee5dce4fd4bb7ef3da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158900","number":158900,"mergeCommit":{"message":"[Data Views] Fix data view field update paths in documentation (#158900)\n\n## Summary\r\n\r\nThis PR fixes the documentation for the \"update data view fields\" API which used an incorrect route in the provided examples (data-view instead of data_view)","sha":"40c75ed1a2f8f3d8a6ae91ee5dce4fd4bb7ef3da"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> |
||
|
1eda8460c8
|
[APM] Use transaction.duration.histogram for percentile aggs (#158909)
Closes #158364. |
||
|
8c954da6e3
|
[8.8] [Security Solution] [Controls] [Fix] Move fieldFilterPredicate function out of redux (#157004) (#158906)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Controls] [Fix] Move fieldFilterPredicate function out of redux (#157004)](https://github.com/elastic/kibana/pull/157004) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T15:09:08Z","message":"[Security Solution] [Controls] [Fix] Move fieldFilterPredicate function out of redux (#157004)\n\n## Summary\r\n\r\nThis PR handles: #156996\r\n\r\n@elastic/kibana-presentation team: Currently, this PR moves,\r\n`fieldFilterPredicate` out of settings. Now it is being used as the prop\r\nof the `ControlGroupRenderer`. Below video demonstrates the difference\r\nbetween both:\r\n\r\n|Before|After|\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236853473-343c4da6-ebe2-43d2-ae43-84d46dedae7c.mov\"/>\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236851603-45aed5da-f185-4c43-9b93-571aa44709c5.mov\"\r\n/> |\r\n\r\n\r\nPlease let me know if there could be a better approach for achieving the\r\nsame objective.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2fb381350064a5aacdf1fe5fde8a08b642e2e74","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:skip","Team:Security Solution Platform","v8.9.0"],"number":157004,"url":"https://github.com/elastic/kibana/pull/157004","mergeCommit":{"message":"[Security Solution] [Controls] [Fix] Move fieldFilterPredicate function out of redux (#157004)\n\n## Summary\r\n\r\nThis PR handles: #156996\r\n\r\n@elastic/kibana-presentation team: Currently, this PR moves,\r\n`fieldFilterPredicate` out of settings. Now it is being used as the prop\r\nof the `ControlGroupRenderer`. Below video demonstrates the difference\r\nbetween both:\r\n\r\n|Before|After|\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236853473-343c4da6-ebe2-43d2-ae43-84d46dedae7c.mov\"/>\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236851603-45aed5da-f185-4c43-9b93-571aa44709c5.mov\"\r\n/> |\r\n\r\n\r\nPlease let me know if there could be a better approach for achieving the\r\nsame objective.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2fb381350064a5aacdf1fe5fde8a08b642e2e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157004","number":157004,"mergeCommit":{"message":"[Security Solution] [Controls] [Fix] Move fieldFilterPredicate function out of redux (#157004)\n\n## Summary\r\n\r\nThis PR handles: #156996\r\n\r\n@elastic/kibana-presentation team: Currently, this PR moves,\r\n`fieldFilterPredicate` out of settings. Now it is being used as the prop\r\nof the `ControlGroupRenderer`. Below video demonstrates the difference\r\nbetween both:\r\n\r\n|Before|After|\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236853473-343c4da6-ebe2-43d2-ae43-84d46dedae7c.mov\"/>\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236851603-45aed5da-f185-4c43-9b93-571aa44709c5.mov\"\r\n/> |\r\n\r\n\r\nPlease let me know if there could be a better approach for achieving the\r\nsame objective.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2fb381350064a5aacdf1fe5fde8a08b642e2e74"}}]}] BACKPORT--> |
||
|
80d17c6788
|
[8.8] [Security Solution][Response Ops] Alert Table column metadata does not have the columns data type (#157653) (#158907)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution][Response Ops] Alert Table column metadata does not have the columns data type (#157653)](https://github.com/elastic/kibana/pull/157653) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T09:59:57Z","message":"[Security Solution][Response Ops] Alert Table column metadata does not have the columns data type (#157653)\n\n## Summary\r\n\r\nHandles : #157463 \r\n\r\n- `@timestamp` Sorting is working functionally instead of `A-Z` it\r\nshould be `Old - New`\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n| (#158899)
# Backport This will backport the following commits from `main` to `8.8`: - [[Cases] Fix bugs when in dark mode in the Cases UI (#158741)](https://github.com/elastic/kibana/pull/158741) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T07:15:55Z","message":"[Cases] Fix bugs when in dark mode in the Cases UI (#158741)\n\n## Summary\r\n\r\nSee https://github.com/elastic/kibana/issues/158592 for testing\r\ninstructions and information about the bug.\r\n\r\n## Screenshots\r\n\r\n**Removal of \"Closed\" subtitle on the cases table**\r\n\r\n<img width=\"1636\" alt=\"Screenshot 2023-05-31 at 6 10 33 PM\"\r\nsrc=\" |
||
|
d2aab8fc2a
|
[8.8] Kubernetes dashboard fixes/improvements (#158605) (#158885)
# Backport This will backport the following commits from `main` to `8.8`: - [Kubernetes dashboard fixes/improvements (#158605)](https://github.com/elastic/kibana/pull/158605) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karl Godard","email":"karl.godard@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T20:53:52Z","message":"Kubernetes dashboard fixes/improvements (#158605)\n\n## Summary\r\n\r\nFixes a number of issues on the Kubernetes dashboard in Security.\r\n\r\n**Bug fixes:**\r\n- Fixed an issue where a default query was being added in a useMemo\r\nwhich would override the global query causing all charts to never be\r\nfiltered by the search bar above.\r\n- The empty state would sometimes prevent new search requests from\r\nrunning which would force the user to do a full page refresh\r\n- i18n formatting fix ups\r\n- Includes an update to the cloud_defend regex validation patterns for\r\ncontainerImageName and containerImageFullName\r\n\r\n**Enhancements:**\r\n- Tree view selection remembered (via useLocalStorage)\r\n\r\n**Deprecations**\r\n- Removed \"responder console\" code from k8s dashboard. The k8smd service\r\nis slated to be deprecated from Endpoint.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: sec_cloudnative_integrations <sec-cloudnative-integrations@elastic.co>","sha":"432a5d7734f127c321f75679be913a87bc3c71a6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","Team: Cloud Native Integrations","v8.9.0","v8.8.1"],"number":158605,"url":"https://github.com/elastic/kibana/pull/158605","mergeCommit":{"message":"Kubernetes dashboard fixes/improvements (#158605)\n\n## Summary\r\n\r\nFixes a number of issues on the Kubernetes dashboard in Security.\r\n\r\n**Bug fixes:**\r\n- Fixed an issue where a default query was being added in a useMemo\r\nwhich would override the global query causing all charts to never be\r\nfiltered by the search bar above.\r\n- The empty state would sometimes prevent new search requests from\r\nrunning which would force the user to do a full page refresh\r\n- i18n formatting fix ups\r\n- Includes an update to the cloud_defend regex validation patterns for\r\ncontainerImageName and containerImageFullName\r\n\r\n**Enhancements:**\r\n- Tree view selection remembered (via useLocalStorage)\r\n\r\n**Deprecations**\r\n- Removed \"responder console\" code from k8s dashboard. The k8smd service\r\nis slated to be deprecated from Endpoint.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: sec_cloudnative_integrations <sec-cloudnative-integrations@elastic.co>","sha":"432a5d7734f127c321f75679be913a87bc3c71a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158605","number":158605,"mergeCommit":{"message":"Kubernetes dashboard fixes/improvements (#158605)\n\n## Summary\r\n\r\nFixes a number of issues on the Kubernetes dashboard in Security.\r\n\r\n**Bug fixes:**\r\n- Fixed an issue where a default query was being added in a useMemo\r\nwhich would override the global query causing all charts to never be\r\nfiltered by the search bar above.\r\n- The empty state would sometimes prevent new search requests from\r\nrunning which would force the user to do a full page refresh\r\n- i18n formatting fix ups\r\n- Includes an update to the cloud_defend regex validation patterns for\r\ncontainerImageName and containerImageFullName\r\n\r\n**Enhancements:**\r\n- Tree view selection remembered (via useLocalStorage)\r\n\r\n**Deprecations**\r\n- Removed \"responder console\" code from k8s dashboard. The k8smd service\r\nis slated to be deprecated from Endpoint.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: sec_cloudnative_integrations <sec-cloudnative-integrations@elastic.co>","sha":"432a5d7734f127c321f75679be913a87bc3c71a6"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
958823469a
|
[8.8] [Security solution] Generative AI Connector (#157228) (#158886)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security solution] Generative AI Connector (#157228)](https://github.com/elastic/kibana/pull/157228) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-24T22:47:35Z","message":"[Security solution] Generative AI Connector (#157228)","sha":"029eb3104ae878f8178bb1d936183f7488a8f1f2","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","ui-copy","v8.9.0"],"number":157228,"url":"https://github.com/elastic/kibana/pull/157228","mergeCommit":{"message":"[Security solution] Generative AI Connector (#157228)","sha":"029eb3104ae878f8178bb1d936183f7488a8f1f2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157228","number":157228,"mergeCommit":{"message":"[Security solution] Generative AI Connector (#157228)","sha":"029eb3104ae878f8178bb1d936183f7488a8f1f2"}}]}] BACKPORT--> |
||
|
10ec99a515
|
[8.8] chore(NA): update caniuse-lite into v1.0.30001492 (#158791) (#158889)
# Backport This will backport the following commits from `main` to `8.8`: - [chore(NA): update caniuse-lite into v1.0.30001492 (#158791)](https://github.com/elastic/kibana/pull/158791) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T23:42:53Z","message":"chore(NA): update caniuse-lite into v1.0.30001492 (#158791)\n\nSimple PR to bump version on this dependency that is throwing on older\r\nbranches.","sha":"f9f035fe9c1d59997c2b44534cb79a0c417e5a1d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.9.0"],"number":158791,"url":"https://github.com/elastic/kibana/pull/158791","mergeCommit":{"message":"chore(NA): update caniuse-lite into v1.0.30001492 (#158791)\n\nSimple PR to bump version on this dependency that is throwing on older\r\nbranches.","sha":"f9f035fe9c1d59997c2b44534cb79a0c417e5a1d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158791","number":158791,"mergeCommit":{"message":"chore(NA): update caniuse-lite into v1.0.30001492 (#158791)\n\nSimple PR to bump version on this dependency that is throwing on older\r\nbranches.","sha":"f9f035fe9c1d59997c2b44534cb79a0c417e5a1d"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <tiago.costa@elastic.co> |
||
|
9f41d789b8
|
[8.8] Upgrade proxy to 2.1.1 (#158764) (#158848)
# Backport This will backport the following commits from `main` to `8.8`: - [Upgrade `proxy` to 2.1.1 (#158764)](https://github.com/elastic/kibana/pull/158764) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Larry Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T16:36:31Z","message":"Upgrade `proxy` to 2.1.1 (#158764)\n\n## Summary\r\n\r\nBumps the `proxy` dev dependency to `2.1.1`.","sha":"248a1346afbb34f709731ce5fd234215ac359e8c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-MAJOR","v8.9.0"],"number":158764,"url":"https://github.com/elastic/kibana/pull/158764","mergeCommit":{"message":"Upgrade `proxy` to 2.1.1 (#158764)\n\n## Summary\r\n\r\nBumps the `proxy` dev dependency to `2.1.1`.","sha":"248a1346afbb34f709731ce5fd234215ac359e8c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158764","number":158764,"mergeCommit":{"message":"Upgrade `proxy` to 2.1.1 (#158764)\n\n## Summary\r\n\r\nBumps the `proxy` dev dependency to `2.1.1`.","sha":"248a1346afbb34f709731ce5fd234215ac359e8c"}}]}] BACKPORT--> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> |
||
|
045c4bcb10
|
[8.8] [Telemetry] Update notice message (#158669) (#158842)
# Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Update notice message (#158669)](https://github.com/elastic/kibana/pull/158669) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T15:53:02Z","message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.9.0"],"number":158669,"url":"https://github.com/elastic/kibana/pull/158669","mergeCommit":{"message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158669","number":158669,"mergeCommit":{"message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> |
||
|
d841880951
|
[8.8] [ML] Reenable data visualizer tests (#158568) (#158839)
# Backport This will backport the following commits from `main` to `8.8`: - [[ML] Reenable data visualizer tests (#158568)](https://github.com/elastic/kibana/pull/158568) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"robert.oskamp@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T15:25:11Z","message":"[ML] Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR stabilizes the data visualizer tests by making sure global\r\nloading is done around time picker and sampler selections. It also\r\nre-enables the index data visualizer test suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:prev-minor","v8.9.0","v8.8.1"],"number":158568,"url":"https://github.com/elastic/kibana/pull/158568","mergeCommit":{"message":"[ML] Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR stabilizes the data visualizer tests by making sure global\r\nloading is done around time picker and sampler selections. It also\r\nre-enables the index data visualizer test suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158568","number":158568,"mergeCommit":{"message":"[ML] Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR stabilizes the data visualizer tests by making sure global\r\nloading is done around time picker and sampler selections. It also\r\nre-enables the index data visualizer test suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> |
||
|
c2e616a1ee
|
[8.8] [Docs] Add new Fleet preconfiguration settings (#158771) (#158836)
# Backport This will backport the following commits from `main` to `8.8`: - [[Docs] Add new Fleet preconfiguration settings (#158771)](https://github.com/elastic/kibana/pull/158771) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Kilfoyle","email":"41695641+kilfoyle@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-01T14:51:55Z","message":"[Docs] Add new Fleet preconfiguration settings (#158771)\n\nThis adds new Fleet preconfiguration settings to the Kibana [Fleet\r\nsettings](https://www.elastic.co/guide/en/kibana/master/fleet-settings-kb.html)\r\npage. I also moved the \"example configuration\" to right below the\r\n`xpack.fleet.agentPolicies` setting, since that's what's shown in the\r\nexample.\r\n\r\n[Preview\r\npage](https://kibana_158771.docs-preview.app.elstc.co/guide/en/kibana/master/fleet-settings-kb.html)\r\n\r\nCloses: https://github.com/elastic/ingest-docs/issues/191","sha":"3ac1666c1d5f8a9c1e9c8272d5baed56142b639a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":158771,"url":"https://github.com/elastic/kibana/pull/158771","mergeCommit":{"message":"[Docs] Add new Fleet preconfiguration settings (#158771)\n\nThis adds new Fleet preconfiguration settings to the Kibana [Fleet\r\nsettings](https://www.elastic.co/guide/en/kibana/master/fleet-settings-kb.html)\r\npage. I also moved the \"example configuration\" to right below the\r\n`xpack.fleet.agentPolicies` setting, since that's what's shown in the\r\nexample.\r\n\r\n[Preview\r\npage](https://kibana_158771.docs-preview.app.elstc.co/guide/en/kibana/master/fleet-settings-kb.html)\r\n\r\nCloses: https://github.com/elastic/ingest-docs/issues/191","sha":"3ac1666c1d5f8a9c1e9c8272d5baed56142b639a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158771","number":158771,"mergeCommit":{"message":"[Docs] Add new Fleet preconfiguration settings (#158771)\n\nThis adds new Fleet preconfiguration settings to the Kibana [Fleet\r\nsettings](https://www.elastic.co/guide/en/kibana/master/fleet-settings-kb.html)\r\npage. I also moved the \"example configuration\" to right below the\r\n`xpack.fleet.agentPolicies` setting, since that's what's shown in the\r\nexample.\r\n\r\n[Preview\r\npage](https://kibana_158771.docs-preview.app.elstc.co/guide/en/kibana/master/fleet-settings-kb.html)\r\n\r\nCloses: https://github.com/elastic/ingest-docs/issues/191","sha":"3ac1666c1d5f8a9c1e9c8272d5baed56142b639a"}}]}] BACKPORT--> Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> |
||
|
13603f08a7
|
[8.8] [Response Ops][Alerting] Adding null checks when iterating through index template list (#158742) (#158820)
# Backport This will backport the following commits from `main` to `8.8`: - [[Response Ops][Alerting] Adding null checks when iterating through index template list (#158742)](https://github.com/elastic/kibana/pull/158742) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T11:56:51Z","message":"[Response Ops][Alerting] Adding null checks when iterating through index template list (#158742)\n\n## Summary\r\n\r\nWhen updating common component templates during AAD resource\r\ninstallation, we occassionally run into errors where the index templates\r\nusing the common component template has a total field limit that is less\r\nthan the new total number of fields with the updated component template.\r\nWhen this occurs, we query the ES index template API to get the list of\r\nindex templates in order to check their `composed_of` field to see if\r\nthey reference the specific component template and act accordingly. In\r\ntheory, `composed_of` is (and is typed as) a required array. In\r\npractice, it seems that this field can be missing from the response.\r\nSince we're doing a `.includes` check on this array, this can lead to\r\nnull dereference errors that can halt alerts as data resource\r\ninstallation.\r\n\r\nThis PR adds a check to make sure the `composed_of` field exists before\r\nusing it.\r\n\r\n## To Verify\r\n1. Run Kibana 8.6 locally and create a metric threshold rule & detection\r\nrule that generates alerts. Make sure the alert index templates for\r\nthese rule types have been created and the rule runs successfully.\r\n2. Update to Kibana 8.7. Make sure the rules run successfully and\r\ngenerate alerts. Create a data view with no component templates. To do\r\nthis, go to `Stack Management > Index Management > Index Templates` and\r\nclick `Create template`. Fill in a name and index pattern (`test*` is\r\nfine) and make sure the `Create data stream` switch is checked. Click\r\nthrough all the remaining options without setting anything else. Use\r\n`GET /_index_template/<name>` to verify that this index template has no\r\n`composed_of` field\r\n3. Update to this branch. All alert resources should be installed\r\nsuccessfully and there should be no errors on startup.","sha":"0f02b9e968f43bdae1c26c0149f47e6266e85827","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Alerting","Team:ResponseOps","v8.9.0","v8.8.1"],"number":158742,"url":"https://github.com/elastic/kibana/pull/158742","mergeCommit":{"message":"[Response Ops][Alerting] Adding null checks when iterating through index template list (#158742)\n\n## Summary\r\n\r\nWhen updating common component templates during AAD resource\r\ninstallation, we occassionally run into errors where the index templates\r\nusing the common component template has a total field limit that is less\r\nthan the new total number of fields with the updated component template.\r\nWhen this occurs, we query the ES index template API to get the list of\r\nindex templates in order to check their `composed_of` field to see if\r\nthey reference the specific component template and act accordingly. In\r\ntheory, `composed_of` is (and is typed as) a required array. In\r\npractice, it seems that this field can be missing from the response.\r\nSince we're doing a `.includes` check on this array, this can lead to\r\nnull dereference errors that can halt alerts as data resource\r\ninstallation.\r\n\r\nThis PR adds a check to make sure the `composed_of` field exists before\r\nusing it.\r\n\r\n## To Verify\r\n1. Run Kibana 8.6 locally and create a metric threshold rule & detection\r\nrule that generates alerts. Make sure the alert index templates for\r\nthese rule types have been created and the rule runs successfully.\r\n2. Update to Kibana 8.7. Make sure the rules run successfully and\r\ngenerate alerts. Create a data view with no component templates. To do\r\nthis, go to `Stack Management > Index Management > Index Templates` and\r\nclick `Create template`. Fill in a name and index pattern (`test*` is\r\nfine) and make sure the `Create data stream` switch is checked. Click\r\nthrough all the remaining options without setting anything else. Use\r\n`GET /_index_template/<name>` to verify that this index template has no\r\n`composed_of` field\r\n3. Update to this branch. All alert resources should be installed\r\nsuccessfully and there should be no errors on startup.","sha":"0f02b9e968f43bdae1c26c0149f47e6266e85827"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158742","number":158742,"mergeCommit":{"message":"[Response Ops][Alerting] Adding null checks when iterating through index template list (#158742)\n\n## Summary\r\n\r\nWhen updating common component templates during AAD resource\r\ninstallation, we occassionally run into errors where the index templates\r\nusing the common component template has a total field limit that is less\r\nthan the new total number of fields with the updated component template.\r\nWhen this occurs, we query the ES index template API to get the list of\r\nindex templates in order to check their `composed_of` field to see if\r\nthey reference the specific component template and act accordingly. In\r\ntheory, `composed_of` is (and is typed as) a required array. In\r\npractice, it seems that this field can be missing from the response.\r\nSince we're doing a `.includes` check on this array, this can lead to\r\nnull dereference errors that can halt alerts as data resource\r\ninstallation.\r\n\r\nThis PR adds a check to make sure the `composed_of` field exists before\r\nusing it.\r\n\r\n## To Verify\r\n1. Run Kibana 8.6 locally and create a metric threshold rule & detection\r\nrule that generates alerts. Make sure the alert index templates for\r\nthese rule types have been created and the rule runs successfully.\r\n2. Update to Kibana 8.7. Make sure the rules run successfully and\r\ngenerate alerts. Create a data view with no component templates. To do\r\nthis, go to `Stack Management > Index Management > Index Templates` and\r\nclick `Create template`. Fill in a name and index pattern (`test*` is\r\nfine) and make sure the `Create data stream` switch is checked. Click\r\nthrough all the remaining options without setting anything else. Use\r\n`GET /_index_template/<name>` to verify that this index template has no\r\n`composed_of` field\r\n3. Update to this branch. All alert resources should be installed\r\nsuccessfully and there should be no errors on startup.","sha":"0f02b9e968f43bdae1c26c0149f47e6266e85827"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co> |
||
|
542d449286
|
[8.8] [Infrastructure UI] Hosts View flaky test - Remove async from describe (#158752) (#158816)
# Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Hosts View flaky test - Remove async from describe (#158752)](https://github.com/elastic/kibana/pull/158752) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-01T10:47:37Z","message":"[Infrastructure UI] Hosts View flaky test - Remove async from describe (#158752)\n\nfixes: [#157721](https://github.com/elastic/kibana/issues/157721)\r\n## Summary\r\n\r\nThis PR aims to fix a flaky, my main suspicion is the existence of an\r\nasync `describe`, that could influence the execution of other tests. The\r\ntest `describe` itself contained a test that wasn't really relevant for\r\nthe Host View test suite because it validated the Processes tab summary\r\nfield titles. I decided to remove it altogether","sha":"81b9bd2d906ac4db3c156f21a7696764c016e1a6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0"],"number":158752,"url":"https://github.com/elastic/kibana/pull/158752","mergeCommit":{"message":"[Infrastructure UI] Hosts View flaky test - Remove async from describe (#158752)\n\nfixes: [#157721](https://github.com/elastic/kibana/issues/157721)\r\n## Summary\r\n\r\nThis PR aims to fix a flaky, my main suspicion is the existence of an\r\nasync `describe`, that could influence the execution of other tests. The\r\ntest `describe` itself contained a test that wasn't really relevant for\r\nthe Host View test suite because it validated the Processes tab summary\r\nfield titles. I decided to remove it altogether","sha":"81b9bd2d906ac4db3c156f21a7696764c016e1a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158752","number":158752,"mergeCommit":{"message":"[Infrastructure UI] Hosts View flaky test - Remove async from describe (#158752)\n\nfixes: [#157721](https://github.com/elastic/kibana/issues/157721)\r\n## Summary\r\n\r\nThis PR aims to fix a flaky, my main suspicion is the existence of an\r\nasync `describe`, that could influence the execution of other tests. The\r\ntest `describe` itself contained a test that wasn't really relevant for\r\nthe Host View test suite because it validated the Processes tab summary\r\nfield titles. I decided to remove it altogether","sha":"81b9bd2d906ac4db3c156f21a7696764c016e1a6"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> |
||
|
458be9f229
|
[8.8] [ML] Increasing calendar events request limit (#158726) (#158812)
# Backport This will backport the following commits from `main` to `8.8`: - [[ML] Increasing calendar events request limit (#158726)](https://github.com/elastic/kibana/pull/158726) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T10:24:59Z","message":"[ML] Increasing calendar events request limit (#158726)\n\nFixes https://github.com/elastic/kibana/issues/158712\r\n\r\nIncreasing the limit for getting all events, the default is `100`, which\r\ncan easily be passed.\r\nAlso increasing the size for getting all calendars, for consistency.","sha":"e4be75943757c382fb42bf11c974cc6f260fb902","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Anomaly Detection","v8.9.0","v8.8.1"],"number":158726,"url":"https://github.com/elastic/kibana/pull/158726","mergeCommit":{"message":"[ML] Increasing calendar events request limit (#158726)\n\nFixes https://github.com/elastic/kibana/issues/158712\r\n\r\nIncreasing the limit for getting all events, the default is `100`, which\r\ncan easily be passed.\r\nAlso increasing the size for getting all calendars, for consistency.","sha":"e4be75943757c382fb42bf11c974cc6f260fb902"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158726","number":158726,"mergeCommit":{"message":"[ML] Increasing calendar events request limit (#158726)\n\nFixes https://github.com/elastic/kibana/issues/158712\r\n\r\nIncreasing the limit for getting all events, the default is `100`, which\r\ncan easily be passed.\r\nAlso increasing the size for getting all calendars, for consistency.","sha":"e4be75943757c382fb42bf11c974cc6f260fb902"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co> |
||
|
cc69e5ba15
|
[8.8] [Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594) (#158784)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594)](https://github.com/elastic/kibana/pull/158594) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T21:13:36Z","message":"[Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594)\n\n## Summary\r\n\r\nFixes an issue with the field browser where all types currently display\r\nas unkown, this was because in a code path where a type cast happens, we\r\nwere using the wrong type. To see this, remove the as unknown from the\r\ncast, and the typescript compiler will show the problem:\r\n```\r\n'BrowserField' is deprecated.ts(6385)\r\nindex.ts(70, 4): The declaration was marked as deprecated here.\r\nConversion of type 'DataViewField' to type 'BrowserField' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.\r\n Type 'DataViewField' is missing the following properties from type 'BrowserField': category, description, example, fields, and 2 more.ts(2352)\r\n```\r\nDataViewField actually only has spec and kbnFieldType properties, spec\r\nis of type FieldSpec which is basically the same type as BrowserField,\r\nand has sufficient overlap for the (still unsafe, but more safe than as\r\nunknown) cast to occur.\r\n\r\nBefore:\r\n<img width=\"338\" alt=\"image\"\r\nsrc=\" |
||
|
06ee73f0ed
|
[8.8] [ResponseOps] Throwing a mustache error when validating action message for warnings (#158668) (#158776)
# Backport This will backport the following commits from `main` to `8.8`: - [[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)](https://github.com/elastic/kibana/pull/158668) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"109488926+doakalexi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T20:26:24Z","message":"[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves https://github.com/elastic/kibana/issues/158666\r\n\r\n## Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:ResponseOps","v8.9.0","v8.8.1"],"number":158668,"url":"https://github.com/elastic/kibana/pull/158668","mergeCommit":{"message":"[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves https://github.com/elastic/kibana/issues/158666\r\n\r\n## Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158668","number":158668,"mergeCommit":{"message":"[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves https://github.com/elastic/kibana/issues/158666\r\n\r\n## Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexi Doak <109488926+doakalexi@users.noreply.github.com> |
||
|
564ff934e3
|
[8.8] Upgrade EUI to v77.1.4 (#158770)
This is a backport EUI upgrade to Kibana v8.8.1 containing an EuiDataGrid bugfix requested by the Discover team: https://github.com/elastic/eui/issues/6804#issuecomment-1564903858 ## [`77.1.4`](https://github.com/elastic/eui/tree/v77.1.4) - Updated `EuiDataGrid` to only render screen reader text announcing cell position if the cell is currently focused. This should improve the ability to copy and paste multiple cells without SR text. ([#6817](https://github.com/elastic/eui/pull/6817)) |
||
|
52d85bcca1
|
[8.8] [Maps] Update asset tracking tutorial with production consideration for rule check interval (#158664) (#158760)
# Backport This will backport the following commits from `main` to `8.8`: - [[Maps] Update asset tracking tutorial with production consideration for rule check interval (#158664)](https://github.com/elastic/kibana/pull/158664) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T17:38:41Z","message":"[Maps] Update asset tracking tutorial with production consideration for rule check interval (#158664)\n\nFixes #127289\r\n\r\n## Summary\r\n\r\nUpdates the asset tracking tutorial docs with considerations for running\r\nin production.\r\n\r\nFor a better demo experience the tutorial uses a 5 second interval for\r\nrule checking, but a very low interval can be problematic for running in\r\nproduction.\r\n\r\nI'm suggesting backporting these doc changes to 8.3 which the first\r\nrelease to have a **Circuit breakers** section in\r\nhttps://www.elastic.co/guide/en/kibana/8.3/alerting-production-considerations.html\r\nthat is most relevant to the added note in this PR.\r\n\r\n---------\r\n\r\nCo-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>","sha":"9d7d6f92133d100efee9eefd80fed9e097427f8d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","docs","Feature:Maps","v8.3.4","v8.4.4","v8.5.4","v8.6.3","v8.7.2","v8.9.0","v8.8.1"],"number":158664,"url":"https://github.com/elastic/kibana/pull/158664","mergeCommit":{"message":"[Maps] Update asset tracking tutorial with production consideration for rule check interval (#158664)\n\nFixes #127289\r\n\r\n## Summary\r\n\r\nUpdates the asset tracking tutorial docs with considerations for running\r\nin production.\r\n\r\nFor a better demo experience the tutorial uses a 5 second interval for\r\nrule checking, but a very low interval can be problematic for running in\r\nproduction.\r\n\r\nI'm suggesting backporting these doc changes to 8.3 which the first\r\nrelease to have a **Circuit breakers** section in\r\nhttps://www.elastic.co/guide/en/kibana/8.3/alerting-production-considerations.html\r\nthat is most relevant to the added note in this PR.\r\n\r\n---------\r\n\r\nCo-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>","sha":"9d7d6f92133d100efee9eefd80fed9e097427f8d"}},"sourceBranch":"main","suggestedTargetBranches":["8.3","8.4","8.5","8.6","8.7","8.8"],"targetPullRequestStates":[{"branch":"8.3","label":"v8.3.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.4","label":"v8.4.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.6","label":"v8.6.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158664","number":158664,"mergeCommit":{"message":"[Maps] Update asset tracking tutorial with production consideration for rule check interval (#158664)\n\nFixes #127289\r\n\r\n## Summary\r\n\r\nUpdates the asset tracking tutorial docs with considerations for running\r\nin production.\r\n\r\nFor a better demo experience the tutorial uses a 5 second interval for\r\nrule checking, but a very low interval can be problematic for running in\r\nproduction.\r\n\r\nI'm suggesting backporting these doc changes to 8.3 which the first\r\nrelease to have a **Circuit breakers** section in\r\nhttps://www.elastic.co/guide/en/kibana/8.3/alerting-production-considerations.html\r\nthat is most relevant to the added note in this PR.\r\n\r\n---------\r\n\r\nCo-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>","sha":"9d7d6f92133d100efee9eefd80fed9e097427f8d"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co> |
||
|
e7f919889d
|
[8.8] Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700) (#158740)
# Backport This will backport the following commits from `main` to `8.8`: - [Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700)](https://github.com/elastic/kibana/pull/158700) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T15:20:45Z","message":"Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has resulted in slower test execution time\r\nand ultimately some timeout failures. Auto-skip functionality skips the\r\ntest suite completely. This PR removes Firefox testing for the spaces\r\nselection suite and unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.9.0","v8.8.1"],"number":158700,"url":"https://github.com/elastic/kibana/pull/158700","mergeCommit":{"message":"Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has resulted in slower test execution time\r\nand ultimately some timeout failures. Auto-skip functionality skips the\r\ntest suite completely. This PR removes Firefox testing for the spaces\r\nselection suite and unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158700","number":158700,"mergeCommit":{"message":"Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has resulted in slower test execution time\r\nand ultimately some timeout failures. Auto-skip functionality skips the\r\ntest suite completely. This PR removes Firefox testing for the spaces\r\nselection suite and unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> |
||
|
f006d49dd1
|
[8.8] Prevent rollback for failed upgrades from write_blocking SO indices (#158725) (#158738)
# Backport This will backport the following commits from `main` to `8.8`: - [Prevent rollback for failed upgrades from write_blocking SO indices (#158725)](https://github.com/elastic/kibana/pull/158725) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T15:09:47Z","message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","Feature:Migrations","backport:prev-minor","v8.9.0","v8.8.1"],"number":158725,"url":"https://github.com/elastic/kibana/pull/158725","mergeCommit":{"message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158725","number":158725,"mergeCommit":{"message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
f7c4269fec
|
[8.8] [Infrastructure UI] Fix hosts view flaky funcional test (#157913) (#158735)
# Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Fix hosts view flaky funcional test (#157913)](https://github.com/elastic/kibana/pull/157913) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T14:17:08Z","message":"[Infrastructure UI] Fix hosts view flaky funcional test (#157913)\n\nfixes: https://github.com/elastic/kibana/issues/157718\r\nfixes: https://github.com/elastic/kibana/issues/157719\r\nfixes: https://github.com/elastic/kibana/issues/157720\r\nfixes: https://github.com/elastic/kibana/issues/157721 \r\nfixes: https://github.com/elastic/kibana/issues/157733\r\nfixes: https://github.com/elastic/kibana/issues/157734\r\n\r\n## Summary\r\n\r\nFixes hosts view flaky tests\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2258\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"051ac85c07bd883550236e6ebca763ef64801507","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics UI","Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0"],"number":157913,"url":"https://github.com/elastic/kibana/pull/157913","mergeCommit":{"message":"[Infrastructure UI] Fix hosts view flaky funcional test (#157913)\n\nfixes: https://github.com/elastic/kibana/issues/157718\r\nfixes: https://github.com/elastic/kibana/issues/157719\r\nfixes: https://github.com/elastic/kibana/issues/157720\r\nfixes: https://github.com/elastic/kibana/issues/157721 \r\nfixes: https://github.com/elastic/kibana/issues/157733\r\nfixes: https://github.com/elastic/kibana/issues/157734\r\n\r\n## Summary\r\n\r\nFixes hosts view flaky tests\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2258\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"051ac85c07bd883550236e6ebca763ef64801507"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157913","number":157913,"mergeCommit":{"message":"[Infrastructure UI] Fix hosts view flaky funcional test (#157913)\n\nfixes: https://github.com/elastic/kibana/issues/157718\r\nfixes: https://github.com/elastic/kibana/issues/157719\r\nfixes: https://github.com/elastic/kibana/issues/157720\r\nfixes: https://github.com/elastic/kibana/issues/157721 \r\nfixes: https://github.com/elastic/kibana/issues/157733\r\nfixes: https://github.com/elastic/kibana/issues/157734\r\n\r\n## Summary\r\n\r\nFixes hosts view flaky tests\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2258\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"051ac85c07bd883550236e6ebca763ef64801507"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> |
||
|
caa8e8e695
|
[8.8] [Security Solution] Failed getFieldsForIndexPattern calls can result in Exception Flyout getting stuck in loading state (#158371) (#158681)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Failed getFieldsForIndexPattern calls can result in Exception Flyout getting stuck in loading state (#158371)](https://github.com/elastic/kibana/pull/158371) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-05-30T20:23:17Z","message":"[Security Solution] Failed getFieldsForIndexPattern calls can result in Exception Flyout getting stuck in loading state (#158371)\n\n## Summary\r\n\r\nOriginal ticket https://github.com/elastic/kibana/issues/158110\r\n\r\nThese changes fixes the issue with the exception flyout which can be\r\nstuck in loading state in case `getFieldsForIndexPattern` throws an\r\nexception.\r\n\r\nFixed by putting the `getFieldsForIndexPattern` call in try/catch. We\r\nuse this call to fetch extended information about the fields [to show\r\nwarning to the user in case there are some index\r\nissues](https://github.com/elastic/kibana/pull/149149). If\r\n`getFieldsForIndexPattern` fails and throws an exception we will\r\ncontinue using fields without conflicts/unmapped information.\r\n\r\nI also, noticed that we do not fetch extended information for the case\r\nwhere user uses index patterns instead of data views. Fixed this issue\r\nin `useFetchIndex`.\r\n\r\ncc @dhurley14 We will need to adjust either of our PRs depending whose\r\nchanges will go in first :-)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1a3cad1b2744a2fb4be070bc5e60754bc183682c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","ci:cloud-deploy","v8.9.0","v8.8.1","Team:Detection Engine"],"number":158371,"url":"https://github.com/elastic/kibana/pull/158371","mergeCommit":{"message":"[Security Solution] Failed getFieldsForIndexPattern calls can result in Exception Flyout getting stuck in loading state (#158371)\n\n## Summary\r\n\r\nOriginal ticket https://github.com/elastic/kibana/issues/158110\r\n\r\nThese changes fixes the issue with the exception flyout which can be\r\nstuck in loading state in case `getFieldsForIndexPattern` throws an\r\nexception.\r\n\r\nFixed by putting the `getFieldsForIndexPattern` call in try/catch. We\r\nuse this call to fetch extended information about the fields [to show\r\nwarning to the user in case there are some index\r\nissues](https://github.com/elastic/kibana/pull/149149). If\r\n`getFieldsForIndexPattern` fails and throws an exception we will\r\ncontinue using fields without conflicts/unmapped information.\r\n\r\nI also, noticed that we do not fetch extended information for the case\r\nwhere user uses index patterns instead of data views. Fixed this issue\r\nin `useFetchIndex`.\r\n\r\ncc @dhurley14 We will need to adjust either of our PRs depending whose\r\nchanges will go in first :-)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1a3cad1b2744a2fb4be070bc5e60754bc183682c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158371","number":158371,"mergeCommit":{"message":"[Security Solution] Failed getFieldsForIndexPattern calls can result in Exception Flyout getting stuck in loading state (#158371)\n\n## Summary\r\n\r\nOriginal ticket https://github.com/elastic/kibana/issues/158110\r\n\r\nThese changes fixes the issue with the exception flyout which can be\r\nstuck in loading state in case `getFieldsForIndexPattern` throws an\r\nexception.\r\n\r\nFixed by putting the `getFieldsForIndexPattern` call in try/catch. We\r\nuse this call to fetch extended information about the fields [to show\r\nwarning to the user in case there are some index\r\nissues](https://github.com/elastic/kibana/pull/149149). If\r\n`getFieldsForIndexPattern` fails and throws an exception we will\r\ncontinue using fields without conflicts/unmapped information.\r\n\r\nI also, noticed that we do not fetch extended information for the case\r\nwhere user uses index patterns instead of data views. Fixed this issue\r\nin `useFetchIndex`.\r\n\r\ncc @dhurley14 We will need to adjust either of our PRs depending whose\r\nchanges will go in first :-)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1a3cad1b2744a2fb4be070bc5e60754bc183682c"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co> |
||
|
cf1a516130
|
[8.8] [Fleet] Include hidden data streams in package upgrade (#158654) (#158698)
# Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] Include hidden data streams in package upgrade (#158654)](https://github.com/elastic/kibana/pull/158654) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T07:50:42Z","message":"[Fleet] Include hidden data streams in package upgrade (#158654)\n\n## Summary\r\n\r\nAPM team reported an issue in 8.8 where some of their newer data streams\r\nwere not rolled over as expected.\r\nIt turned out these are hidden data streams and those were not updated\r\nin Fleet when a new version of a package is installed.\r\n\r\nTo test:\r\n- Start up a kibana\r\n- Install apm 8.7.0 package\r\n[apm-8.7.0.zip]( |
||
|
9240a6ee79
|
[8.8] [Security Solution][Endpoint] Fix error on security solution UI (#157843) (#158709)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution][Endpoint] Fix error on security solution UI (#157843)](https://github.com/elastic/kibana/pull/157843) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"david.sanchezsoler@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T09:49:47Z","message":"[Security Solution][Endpoint] Fix error on security solution UI (#157843)\n\n## Summary\r\nFixes: https://github.com/elastic/kibana/issues/149807\r\n\r\n- Check for current user before getting privileges, if no user, it uses\r\nthe initial state (everything set to false), else if there is an\r\nauthenticated user, then it gets privileges from capabilities.\r\n- Adds unit test cases.\r\n\r\nSee comments in file changes for more info.\r\n\r\nIn order to test that, you have to disable the `security` flag:\r\n`xpack.security.enabled=false` in elasticsearch.\r\n- You shouldn't see any JS UI error when navigating through security\r\nsolution plugin.\r\n- You shouldn't see any endpoint link (Endpoint list, Trusted apps,\r\nEvent filters, etc.).\r\n- When accessing to any of the above directly by url, you should see the\r\nmissing privileges page instead.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e0d0f98dfe40dee4179cbf7bb0ecc4d46978a197","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.9.0","v8.8.1"],"number":157843,"url":"https://github.com/elastic/kibana/pull/157843","mergeCommit":{"message":"[Security Solution][Endpoint] Fix error on security solution UI (#157843)\n\n## Summary\r\nFixes: https://github.com/elastic/kibana/issues/149807\r\n\r\n- Check for current user before getting privileges, if no user, it uses\r\nthe initial state (everything set to false), else if there is an\r\nauthenticated user, then it gets privileges from capabilities.\r\n- Adds unit test cases.\r\n\r\nSee comments in file changes for more info.\r\n\r\nIn order to test that, you have to disable the `security` flag:\r\n`xpack.security.enabled=false` in elasticsearch.\r\n- You shouldn't see any JS UI error when navigating through security\r\nsolution plugin.\r\n- You shouldn't see any endpoint link (Endpoint list, Trusted apps,\r\nEvent filters, etc.).\r\n- When accessing to any of the above directly by url, you should see the\r\nmissing privileges page instead.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e0d0f98dfe40dee4179cbf7bb0ecc4d46978a197"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157843","number":157843,"mergeCommit":{"message":"[Security Solution][Endpoint] Fix error on security solution UI (#157843)\n\n## Summary\r\nFixes: https://github.com/elastic/kibana/issues/149807\r\n\r\n- Check for current user before getting privileges, if no user, it uses\r\nthe initial state (everything set to false), else if there is an\r\nauthenticated user, then it gets privileges from capabilities.\r\n- Adds unit test cases.\r\n\r\nSee comments in file changes for more info.\r\n\r\nIn order to test that, you have to disable the `security` flag:\r\n`xpack.security.enabled=false` in elasticsearch.\r\n- You shouldn't see any JS UI error when navigating through security\r\nsolution plugin.\r\n- You shouldn't see any endpoint link (Endpoint list, Trusted apps,\r\nEvent filters, etc.).\r\n- When accessing to any of the above directly by url, you should see the\r\nmissing privileges page instead.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e0d0f98dfe40dee4179cbf7bb0ecc4d46978a197"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co> |
||
|
c26fcf79cd
|
[8.8] Migrations: dynamically adjust batchSize when reading (#157494) (#158660)
# Backport This will backport the following commits from `main` to `8.8`: - [Migrations: dynamically adjust batchSize when reading (#157494)](https://github.com/elastic/kibana/pull/157494) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-05-30T13:25:07Z","message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:fix","Feature:Migrations","backport:prev-minor","v8.9.0","v8.8.1"],"number":157494,"url":"https://github.com/elastic/kibana/pull/157494","mergeCommit":{"message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157494","number":157494,"mergeCommit":{"message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> |
||
|
a4a3562091
|
[8.8] [Discover][Alerts] Make alert links shorter (#158582) (#158693)
# Backport This will backport the following commits from `main` to `8.8`: - [[Discover][Alerts] Make alert links shorter (#158582)](https://github.com/elastic/kibana/pull/158582) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T05:28:35Z","message":"[Discover][Alerts] Make alert links shorter (#158582)\n\n- Addresses https://github.com/elastic/kibana/issues/158262\r\n\r\n## Summary\r\n\r\nThis PR makes alert links shorter by removing redundant props from the\r\nencoded state. We should trim it down more in the future. Backporting a\r\nsmall fix for now.\r\n\r\nFor testing:\r\nPlease follow instructions from this PR description\r\nhttps://github.com/elastic/kibana/pull/146403","sha":"ef07c978689872d2ae3037aa06a0f2f7b23c3582","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.9.0"],"number":158582,"url":"https://github.com/elastic/kibana/pull/158582","mergeCommit":{"message":"[Discover][Alerts] Make alert links shorter (#158582)\n\n- Addresses https://github.com/elastic/kibana/issues/158262\r\n\r\n## Summary\r\n\r\nThis PR makes alert links shorter by removing redundant props from the\r\nencoded state. We should trim it down more in the future. Backporting a\r\nsmall fix for now.\r\n\r\nFor testing:\r\nPlease follow instructions from this PR description\r\nhttps://github.com/elastic/kibana/pull/146403","sha":"ef07c978689872d2ae3037aa06a0f2f7b23c3582"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158582","number":158582,"mergeCommit":{"message":"[Discover][Alerts] Make alert links shorter (#158582)\n\n- Addresses https://github.com/elastic/kibana/issues/158262\r\n\r\n## Summary\r\n\r\nThis PR makes alert links shorter by removing redundant props from the\r\nencoded state. We should trim it down more in the future. Backporting a\r\nsmall fix for now.\r\n\r\nFor testing:\r\nPlease follow instructions from this PR description\r\nhttps://github.com/elastic/kibana/pull/146403","sha":"ef07c978689872d2ae3037aa06a0f2f7b23c3582"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> |
||
|
19194f9daf
|
[8.8] [Discover] Update single doc view locator to URL encode rowId (#158635) (#158684)
# Backport This will backport the following commits from `main` to `8.8`: - [[Discover] Update single doc view locator to URL encode `rowId` (#158635)](https://github.com/elastic/kibana/pull/158635) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-05-30T21:57:45Z","message":"[Discover] Update single doc view locator to URL encode `rowId` (#158635)\n\n## Summary\r\n\r\nFixes #158525.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n- [ ]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n- [ ] ~Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n- [ ] ~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n- [ ] ~This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n- [ ] ~This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"097666f1a0f4394d68fb0f2a8e7581d5898d0a97","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","v8.9.0","v8.8.1"],"number":158635,"url":"https://github.com/elastic/kibana/pull/158635","mergeCommit":{"message":"[Discover] Update single doc view locator to URL encode `rowId` (#158635)\n\n## Summary\r\n\r\nFixes #158525.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n- [ ]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n- [ ] ~Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n- [ ] ~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n- [ ] ~This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n- [ ] ~This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"097666f1a0f4394d68fb0f2a8e7581d5898d0a97"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158635","number":158635,"mergeCommit":{"message":"[Discover] Update single doc view locator to URL encode `rowId` (#158635)\n\n## Summary\r\n\r\nFixes #158525.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n- [ ]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials~\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n- [ ] ~Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n- [ ] ~If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n- [ ] ~This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n- [ ] ~This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)~\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"097666f1a0f4394d68fb0f2a8e7581d5898d0a97"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> |
||
|
0841742ec8
|
[8.8] [cli] Adjust CLI to treat extra options consistently (#158257) (#158670)
# Backport This will backport the following commits from `main` to `8.8`: - [[cli] Adjust CLI to treat extra options consistently (#158257)](https://github.com/elastic/kibana/pull/158257) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-05-30T16:09:16Z","message":"[cli] Adjust CLI to treat extra options consistently (#158257)\n\n## Summary\r\n\r\nAddresses: #105371 \r\nOne can use `--elasticsearch.password ---my-password---`,\r\n`--elasticsearch.password=---mypassword---` or `--elasticsearch.password\r\n\\\"---mypassword\\\"` both in these cases. Commander is splitting\r\nsingle-dash inputs, it can't be prevented, so for those cases, use\r\nquotes or compound options.\r\n\r\nThe original problem can be reproduced like this:\r\n```shell\r\nyarn start --elasticsearch.password \"-some-password\"\r\n```\r\n\r\nWe were using some extra argument parsing prototype extension in\r\n(command.js)[./src/cli/command.js] - this allows for collecting extra\r\noptions, but the proprietary logic had a few incorrect assumptions.\r\n(e.g.: extra opts will be already split by `=` by the time we get them,\r\nshorthands will be split to individual flags).\r\n\r\n(1) This change makes it explicit in the code, that the single-letter\r\nflags (`-fcz`) are not supported in the extra options.\r\n\r\nThe core of the problem is now how we treat an ambiguous expression like\r\nthis:\r\n```\r\nkibana --password \"--kebabs--are--my--favourite--\" --somethingElse 283\r\n```\r\nIs the `\"--kebabs--are--my--favourite--\"` another flag, or is it a value\r\nfor the previous option?\r\n\r\nUnfortunately, both interpretations will have shortcomings. \r\n- if we treat it as a boolean flag, then values starting with \"--\" will\r\nbe incorrectly treated as flags, and an error will be displayed (in the\r\ncase of a very unfortunate random generated string)\r\n- if we treat it as a value always, then incorrectly ordered\r\noptions/flags will be consumed in place of values\r\n\r\nMaybe the latter one will happen less often. For that, people would have\r\nto incorrectly assume that `--booleanOn` type flags exist, especially\r\namong the non-listed options. Or they'd have to incorrectly parameterize\r\nthe command, for that they can review their own usage locally, and see\r\ntheir error in the ordering.\r\n\r\n(2) This change makes it explicit, that extra options will come in\r\npairs.\r\n\r\nAlso, added tests for the base use case, and the _dash_ edge case.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Checked and works on 7.17/7.13 (it was originally reported on\r\n7.13).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5ee40a9094c84f58c25000d70a32126f57b7839a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:fix","backport:prev-MAJOR","v8.9.0"],"number":158257,"url":"https://github.com/elastic/kibana/pull/158257","mergeCommit":{"message":"[cli] Adjust CLI to treat extra options consistently (#158257)\n\n## Summary\r\n\r\nAddresses: #105371 \r\nOne can use `--elasticsearch.password ---my-password---`,\r\n`--elasticsearch.password=---mypassword---` or `--elasticsearch.password\r\n\\\"---mypassword\\\"` both in these cases. Commander is splitting\r\nsingle-dash inputs, it can't be prevented, so for those cases, use\r\nquotes or compound options.\r\n\r\nThe original problem can be reproduced like this:\r\n```shell\r\nyarn start --elasticsearch.password \"-some-password\"\r\n```\r\n\r\nWe were using some extra argument parsing prototype extension in\r\n(command.js)[./src/cli/command.js] - this allows for collecting extra\r\noptions, but the proprietary logic had a few incorrect assumptions.\r\n(e.g.: extra opts will be already split by `=` by the time we get them,\r\nshorthands will be split to individual flags).\r\n\r\n(1) This change makes it explicit in the code, that the single-letter\r\nflags (`-fcz`) are not supported in the extra options.\r\n\r\nThe core of the problem is now how we treat an ambiguous expression like\r\nthis:\r\n```\r\nkibana --password \"--kebabs--are--my--favourite--\" --somethingElse 283\r\n```\r\nIs the `\"--kebabs--are--my--favourite--\"` another flag, or is it a value\r\nfor the previous option?\r\n\r\nUnfortunately, both interpretations will have shortcomings. \r\n- if we treat it as a boolean flag, then values starting with \"--\" will\r\nbe incorrectly treated as flags, and an error will be displayed (in the\r\ncase of a very unfortunate random generated string)\r\n- if we treat it as a value always, then incorrectly ordered\r\noptions/flags will be consumed in place of values\r\n\r\nMaybe the latter one will happen less often. For that, people would have\r\nto incorrectly assume that `--booleanOn` type flags exist, especially\r\namong the non-listed options. Or they'd have to incorrectly parameterize\r\nthe command, for that they can review their own usage locally, and see\r\ntheir error in the ordering.\r\n\r\n(2) This change makes it explicit, that extra options will come in\r\npairs.\r\n\r\nAlso, added tests for the base use case, and the _dash_ edge case.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Checked and works on 7.17/7.13 (it was originally reported on\r\n7.13).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5ee40a9094c84f58c25000d70a32126f57b7839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158257","number":158257,"mergeCommit":{"message":"[cli] Adjust CLI to treat extra options consistently (#158257)\n\n## Summary\r\n\r\nAddresses: #105371 \r\nOne can use `--elasticsearch.password ---my-password---`,\r\n`--elasticsearch.password=---mypassword---` or `--elasticsearch.password\r\n\\\"---mypassword\\\"` both in these cases. Commander is splitting\r\nsingle-dash inputs, it can't be prevented, so for those cases, use\r\nquotes or compound options.\r\n\r\nThe original problem can be reproduced like this:\r\n```shell\r\nyarn start --elasticsearch.password \"-some-password\"\r\n```\r\n\r\nWe were using some extra argument parsing prototype extension in\r\n(command.js)[./src/cli/command.js] - this allows for collecting extra\r\noptions, but the proprietary logic had a few incorrect assumptions.\r\n(e.g.: extra opts will be already split by `=` by the time we get them,\r\nshorthands will be split to individual flags).\r\n\r\n(1) This change makes it explicit in the code, that the single-letter\r\nflags (`-fcz`) are not supported in the extra options.\r\n\r\nThe core of the problem is now how we treat an ambiguous expression like\r\nthis:\r\n```\r\nkibana --password \"--kebabs--are--my--favourite--\" --somethingElse 283\r\n```\r\nIs the `\"--kebabs--are--my--favourite--\"` another flag, or is it a value\r\nfor the previous option?\r\n\r\nUnfortunately, both interpretations will have shortcomings. \r\n- if we treat it as a boolean flag, then values starting with \"--\" will\r\nbe incorrectly treated as flags, and an error will be displayed (in the\r\ncase of a very unfortunate random generated string)\r\n- if we treat it as a value always, then incorrectly ordered\r\noptions/flags will be consumed in place of values\r\n\r\nMaybe the latter one will happen less often. For that, people would have\r\nto incorrectly assume that `--booleanOn` type flags exist, especially\r\namong the non-listed options. Or they'd have to incorrectly parameterize\r\nthe command, for that they can review their own usage locally, and see\r\ntheir error in the ordering.\r\n\r\n(2) This change makes it explicit, that extra options will come in\r\npairs.\r\n\r\nAlso, added tests for the base use case, and the _dash_ edge case.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Checked and works on 7.17/7.13 (it was originally reported on\r\n7.13).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5ee40a9094c84f58c25000d70a32126f57b7839a"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co> |
||
|
aee0c5dea9
|
[8.8] [DOCS] Adds #158338 breaking change to 8.6 release notes (#158397) (#158663)
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Adds #158338 breaking change to 8.6 release notes (#158397)](https://github.com/elastic/kibana/pull/158397) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kaarina Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2023-05-30T14:55:55Z","message":"[DOCS] Adds #158338 breaking change to 8.6 release notes (#158397)\n\n## Summary\r\n\r\nCloses #158338.","sha":"c12e17c6dce5cccac7936ef3d7c3de39b29bbc02","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.6.0","v8.9.0"],"number":158397,"url":"https://github.com/elastic/kibana/pull/158397","mergeCommit":{"message":"[DOCS] Adds #158338 breaking change to 8.6 release notes (#158397)\n\n## Summary\r\n\r\nCloses #158338.","sha":"c12e17c6dce5cccac7936ef3d7c3de39b29bbc02"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158397","number":158397,"mergeCommit":{"message":"[DOCS] Adds #158338 breaking change to 8.6 release notes (#158397)\n\n## Summary\r\n\r\nCloses #158338.","sha":"c12e17c6dce5cccac7936ef3d7c3de39b29bbc02"}}]}] BACKPORT--> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> |
||
|
f07569be62
|
skip flaky suite (#157760) |