Julia Rechkunova
ff11323011
[Discover] Unskip context filters tests ( #154562 )
...
Closes https://github.com/elastic/kibana/issues/154387
250x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2147
2023-04-19 08:45:26 +02:00
Alejandro Fernández Haro
613619bee2
[Telemetry] Use soClient in FTRs ( #155175 )
2023-04-18 12:38:18 -07:00
Nick Peihl
61f212f75c
[Dashboard] Unskip functional test related to webdriver ( #154767 )
...
## Summary
Fix flaky functional test where clicking a Url formatted link opens a
new tab, but the tab isn't available before verifying the url of the new
tab.
2023-04-13 14:59:05 -04:00
Michael Dokolin
768fe1af31
[Migrations] Add migrationVersion property to the Saved Objects API output ( #154364 )
2023-04-13 12:05:58 +02:00
Hannah Mudge
b8f490a728
[Dashboard] [Controls] Prevent control group reload on output change ( #154763 )
...
Closes https://github.com/elastic/kibana/issues/154146
## Summary
This PR fixes a race condition for chained options list controls where
making changes to the output of the first control in the chain would
sometimes cause the chained controls to be stuck in an infinite loading
state. (Thanks to @ThomThomson for helping me narrow this down).
Basically, before this, **any** change to the control group output (for
example, by making a selection in an options list control) would cause
the dashboard to `forceRefresh` the entire control group:
682e2ed6ae/src/plugins/dashboard/public/dashboard_container/embeddable/integrations/controls/dashboard_control_group_integration.ts (L174-L185)682e2ed6ae/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx (L417-L421)682e2ed6ae/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx (L329-L337)💃
### Flaky Test Runner
<a
href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2114 "><img
src="https://user-images.githubusercontent.com/8698078/231301760-a0c16e9b-fa7e-426c-9483-077527d39faa.png "/></a>
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-12 11:08:51 -06:00
Yngrid Coello
628db34d8a
[APM] Display latest agent version in agent explorer ( #153643 )
...
Closes https://github.com/elastic/kibana/issues/152326 .
### Changes
- `fetchWithTimeout` function was added, so we can fetch the external
bucket where the versions are with a timeout. This is mostly useful for
air-gapped environments.
- `fetchAgentsLatestVersion` was introduced an it's in charge of
fetching the bucket and handling the errors accordingly.
- `getAgentsItems` now returns `latestVersion` property for each agent.
- New column was created in the UI to list the latestVersion per agent.
When no timing out
https://user-images.githubusercontent.com/1313018/227519796-e5569475-451d-4c04-8243-d18c8e7126c3.mov
When timing out
https://user-images.githubusercontent.com/1313018/227520011-ae616a07-e87b-4d0f-bd29-4b3338aa5df2.mov
### Pending
- [ ] Replace bucket URL with production bucket url
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-11 14:31:13 +02:00
Nathan Reese
2a4415f1a4
[maps] unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group4/lens/choropleth_chart·ts ( #154474 )
...
Fixes https://github.com/elastic/kibana/issues/154065
flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2092
Tests failing because of lack of EMS access. The test requires EMS
access. Fix is to add check for EMS so failure message points to failure
cause. This data can be used to help track faulty CI environments where
EMS is not available.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-06 09:44:36 -06:00
Kibana Machine
a4c97f50bb
skip failing test suite ( #154367 )
2023-04-06 09:29:59 -04:00
Yulia Čech
b2812f3278
[Guided onboarding] Fix the value of data-test-subj for telemetry ( #154462 )
...
## Summary
This PR changes the value of `data-test-subj` on the landing page to fix
the telemetry for guided onboarding. In the code, this attribute is only
used for testing.
More details in https://github.com/elastic/telemetry/issues/2155 .
2023-04-06 11:35:12 +02:00
Julia Rechkunova
bb8bb361b4
[Discover] Unskip flaky alerts tests ( #154308 )
...
Closes https://github.com/elastic/kibana/issues/152477
Closes https://github.com/elastic/kibana/issues/152478
Closes https://github.com/elastic/kibana/issues/152479
250x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2070
2023-04-06 11:21:24 +02:00
Tiago Costa
625966da23
skip flaky suite ( #154387 )
2023-04-05 22:46:38 +01:00
Stratoula Kalafateli
5436d6d007
[Unified search] Fixes wrong negation label on the filter builder ( #154216 )
...
## Summary
Closes https://github.com/elastic/kibana/issues/153608
Fixes the problem mentioned on the issue. When you edit a filter with
negation to add another combined filter, then the negation was inherited
by the first filter, which was not correct.
### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
2023-04-05 14:56:17 +03:00
Tiago Costa
4d01dd8ba3
skip flaky suite ( #154146 )
2023-04-04 16:43:05 +01:00
Robert Oskamp
98df0c25d3
[FTR] Switch to new browser headless mode ( #153828 )
...
## Summary
This PR updates the way how we start the headless browser for testing.
The current way of starting in headless mode is eventually going away
and the new headless mode offers more capabilities and stability, see
https://www.selenium.dev/blog/2023/headless-is-going-away/ and
https://developer.chrome.com/articles/new-headless/ .
### Test adjustments
All the adjusted discover, dashboard, maps and infra tests showed the
same pattern during failure investigation that's around the fact that
the new headless mode is closer to the regular / non-headless mode:
* Tests passed with the old headless mode
* Tests failed in regular / non-headless mode the same way they failed
in new headless mode
* The failure reasons were mostly around slightly different font
rendering and slightly different browser sizes
2023-04-04 15:53:56 +02:00
Jonathan Buttner
234d48d9bc
[Cases] Adding files configuration fields ( #154013 )
...
Fixes: https://github.com/elastic/kibana/issues/151935
This PR allows the mime types and max file size for the files
functionality within cases to be configured through the kibana.yml. We
set the defaults maxSize to be 100 mb and if it is not set by the user
we also restrict images to be 10 mb. If the `maxSize` is set by the user
we use it for all mime types including images (or whatever the user has
specified in `allowedMimeTypes`).
The file service changes are just mocks to help with testing some of the
configuration options.
New fields
```
{
files: {
allowedMimeTypes: string[]
maxSize: positive number (minimum 0) <-- exposed to the browser
}
}
```
## Release Notes
Cases added two configuration options to allow users to control which
files mime types are allowed to be attached to cases and the approved
max size of a file being upload.
`xpack.cases.files.allowedMimeTypes` - An array of strings representing
the allowed mime types to be attached to a case.
`xpack.cases.files.maxSize` - A number representing the file size limit
for files being attached to a case (in bytes).
2023-04-03 15:01:01 -04:00
Nick Peihl
b692e347f4
[Dashboard Usability] Unified dashboard settings ( #153862 )
...
## Summary
Adds flyout for changing individual dashboard settings such as title,
description, tags, and save time with dashboard. This also moves the
existing dashboard options (show panel titles, sync colors, use margins,
sync cursor, and sync tooltips) into the flyout.
Fixes #144532
[Flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2055 )
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-31 09:52:51 -04:00
Davis McPhee
1126da53d5
[Discover] [Embeddable] Fix aborted request handling in saved search embeddable ( #153822 )
...
## Summary
This PR fixes how aborted requests are handled in saved search
embeddables. Previously all failed requests after the first request were
considered aborted by the embeddable which resulted in at least two
incorrect behaviours:
- Any failed requests after the first request we're being swallowed by
the embeddable since it considered them aborted, meaning no error state
was ever shown. Now the embeddable correctly changes to an error state
on failed (non-aborted) requests.
- Replacing a Dashboard with a saved search panel previously resulted in
an aborted error state. This no longer happens and the saved search
panel successfully loads.
The issue was originally introduced in #137690 with work aimed at
eliminating aborted error states in the saved search embeddable.
Fixes #151067 .
Fixes #153797 .
### Checklist
- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/ ))~
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )~
- [ ] ~This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))~
- [ ] ~This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )~
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-30 10:41:04 -03:00
Stratoula Kalafateli
c48098d8da
[Unified search] Fixes the comma delimeter copy paste on multifields ( #153772 )
...
## Summary
It fixes the problem with copying pasting comma delimeter values on the
unified search fiters.
2023-03-29 11:00:15 +03:00
Jen Huang
4fbc83493a
[Fleet] Sync integration categories and update tutorials and custom integrations ( #153216 )
...
## Summary
Part of https://github.com/elastic/integrations/pull/5123 . This PR:
1) Syncs hardcoded list of integration categories against the latest
list from [package
spec](24557251ec/categories/categories.yml
2023-03-28 20:59:13 -07:00
Bhavya RM
23b7137904
Updating axe-core to latest ( #144940 )
2023-03-29 00:06:25 +05:30
Stratoula Kalafateli
dec52ef09d
[Textbased languages] Render Lens suggestions in Discover ( #151581 )
...
## Summary
Part of https://github.com/elastic/kibana/issues/147472
This PR adds the unified histogram on the text based mode in Discover
and depicts Lens suggestions to the users. The users can navigate from
it to Lens for further exploration and adding the viz into a dashboard.
Some notes:
- Lens now exposes a new api to fetch the suggestions from a text based
query. Later it can also be used to return suggestions for the dataview
mode (the other part of the aforementioned issue)
- Lens visualizations have been updated to return the correct
previewIcon (the majority of them were using the empty icon and not the
icon that represents them). This icon appears on the visualization
selection dropdown
- When Lens suggests a table, then the chart is not displayed (Discover
already offers a table view)
- The legacy metric is excluded from the suggestions as it is not
compatible with the text based languages.
- The text based languages are treated a bit differently on the unified
histogram as they do not work with search sessions.
- This feature is on technical preview, so we can iterate more on that
on later esql milestones. This is the first iteration required for the
milestone 1.
- The ESQL search strategy has a default size of 1000
https://github.com/elastic/kibana/blob/main/src/plugins/data/common/search/expressions/essql.ts#L113
which means that this is the max rows that we retrieve. I am keeping the
default as is irrelevant from the PR. In ESQL this limitation doesn't
exist so I think we are fine.
**Flaky test runner**:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1972
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
---------
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2023-03-27 18:32:15 +03:00
Stratoula Kalafateli
e01f29e8a6
[Sample data][Flights] Use Lens by value panels where possible ( #153634 )
...
## Summary
This PR migrates the flights sample dataset to work with Lens by value
panels instead of legacy visualizations (TSVB, agg based)
Changes:
- Changed the legacy Lens metrics to the new metric
- Changed the tagcloud with a horizontal bar
- Removed the legacy SOs
- Removed the library visualizations and use by value panels instead
Note: The TSVB goal was not converted to Lens as it is not possible atm
to divide with the bucket interval
### How to test
Remove the flights dataset and reinstall it
<img width="1655" alt="image"
src="https://user-images.githubusercontent.com/17003240/227503741-2af87636-12bb-4a95-85ac-a82d8fa94e9d.png ">
<img width="1657" alt="image"
src="https://user-images.githubusercontent.com/17003240/227511662-1d4604ba-a82c-478e-bda1-47aea6cc01ba.png ">
2023-03-27 13:49:52 +03:00
Matthew Kime
29f038071e
[data views] Remove partial index pattern validation ( #153350 )
...
## Summary
https://github.com/elastic/kibana/pull/151788 established that data
views would no longer error when they failed to retrieve a field list.
This index pattern validation code exists since previously ALL index
pattern segments needed to match in order to avoid an error response
from field caps, rather than just one. Now we can remove the validation
code and simply pass the index pattern to field caps directly.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
---------
Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-03-27 05:34:47 -05:00
Hannah Mudge
adb0bb58d3
[Dashboard] Add better debugging to error embeddable checks ( #153457 )
...
Closes https://github.com/elastic/kibana/issues/97701
## Summary
This PR replaces all instances of `await
testSubjects.missingOrFail('embeddableError');` with a call to the new
`noErrorEmbeddablesPresent()` method from the `dashboardExpect` service.
This `noErrorEmbeddablesPresent()` method adds some extra debugging
logic to the error embeddable check where, if at least one error
embeddable is present, then both the panel title(s) and the relevant
error message(s) will be printed as part of the error that is thrown.
With these changes, if the attached flaky test fails again, we should at
least have some more information on **why** it failed.
### Flaky Test Runner
This was specifically only running the flaky
`save_search_session_relative_time.ts` test suite:
<a
href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2024 "><img
src="https://user-images.githubusercontent.com/8698078/227240095-a336b03b-6499-4d80-8b60-5e325d54a4ae.png "/></a>
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-24 08:49:57 -06:00
Matthew Kime
9f8b44df26
[data views] Automatic loading of field lists will no longer error on empty field list ( #152059 )
...
## Summary
Part of https://github.com/elastic/kibana/issues/151670
and follow up to https://github.com/elastic/kibana/pull/151788
When a data view is loaded, it automatically loads its field list.
Previously, it would error if the index pattern failed to match an
index. Going forward, this will be treated as a valid empty state -
`allowNoIndices` is being passed to the field_caps requests. When
`allowNoIndices` is set to true, ES will return a valid empty set rather
than a 404 error.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-03-24 06:41:05 -07:00
Michael Dokolin
17876df41a
[Saved Objects] Update the migrationVersion property to hold a plain string value ( #150075 )
...
* Update document migrator to rely on `typeMigrationVersion` instead of `migrationVersion`.
* Refactor document migrator to extract migration pipeline logic.
* Add `core` migration type.
2023-03-24 13:45:30 +01:00
Tre
1a0cab832d
[FTR] drop unused tag ( #152586 )
...
## Summary
We no longer run coverage on FTR tests.
2023-03-24 10:20:44 +00:00
Trevor Pierce
6d55dd9fdd
Upgrade EUI to v76.3.0 ( #153341 )
...
## Summary
eui@76.0.2 ⏩ eui@76.3.0
## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0 )
- Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array
of query selector strings
([#6646 ](https://github.com/elastic/eui/pull/6646 ))
**Bug fixes**
- Fixed `EuiFlyout` to preserve body scrollbar width on open
([#6645 ](https://github.com/elastic/eui/pull/6645 ))
- Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve
body scrollbar width on open
([#6645 ](https://github.com/elastic/eui/pull/6645 ))
- Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to
preserve body scrollbar width on open
([#6645 ](https://github.com/elastic/eui/pull/6645 ))
## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0 )
- Added new `renderCustomGridBody` escape hatch rendering prop to
`EuiDataGrid` ([#6624 ](https://github.com/elastic/eui/pull/6624 ))
**Bug fixes**
- Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s
([#6637 ](https://github.com/elastic/eui/pull/6637 ))
- Added a legacy `alert` alias for the `warning` `EuiIcon` type
([#6640 ](https://github.com/elastic/eui/pull/6640 ))
- Fixed a type definition incorrectly coming from a dev dependency,
which was causing issues for some consuming projects
([#6643 ](https://github.com/elastic/eui/pull/6643 ))
## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0 )
- Added more detailed screen reader instructions to `EuiSelectable`,
`EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and
`EuiDualRange`. ([#6589 ](https://github.com/elastic/eui/pull/6589 ))
- Added new `placeholder` prop to `EuiSuperSelect`
([#6630 ](https://github.com/elastic/eui/pull/6630 ))
- Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s
`renderCellPopover` prop
([#6632 ](https://github.com/elastic/eui/pull/6632 ))
**Bug fixes**
- Fixed an ARIA attribute in `EuiSelectableList`
([#6589 ](https://github.com/elastic/eui/pull/6589 ))
- Fixed `EuiSelectable` to no longer show active selection state or
respond to the Up/Down arrow keys when focus is inside the selectable
container, but not on the searchbox or listbox.
([#6631 ](https://github.com/elastic/eui/pull/6631 ))
---------
Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2023-03-23 14:25:12 -07:00
Julia Rechkunova
b0b50f2978
[Discover] Unskip flaky sidebar tests ( #153525 )
...
Closes https://github.com/elastic/kibana/issues/146996
250x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2029
2023-03-23 14:47:16 +01:00
Tiago Costa
8fcd2958bd
skip flaky suite ( #146996 )
2023-03-22 15:18:22 +00:00
Anton Dosov
3872fd66cf
[CM] Fix flaky test in the example app ( #153310 )
...
## Summary
close https://github.com/elastic/kibana/issues/152852
🤞
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2010
2023-03-21 09:59:00 +01:00
Davis McPhee
26f0f522b2
[Discover] Inline data fetching errors ( #152311 )
...
## Summary
**Note: If your team's review is requested on this PR related to
notification service changes, it's likely because somewhere in your
codebase `NotificationsSetup` was being passed to a function/component
requiring `NotificationsStart` or vice versa. The interfaces were
previously identical so it didn't matter, but an additional function was
added to `NotificationsStart` in this PR that created type errors which
needed to be resolved.**
This PR updates Discover to use inline error messages for data fetching
errors instead of toasts.
For most error messages, the title and full message will be displayed
inline as well as a "Show details" button which opens the standard error
dialog. For errors which have special handling and render custom content
instead of just the error message, the custom content will be rendered
in the callout body for the "No results" state, or rendered in a popover
when clicking the "Show details" button for the banner-style error
display.
No results with regular error message:
<img width="1825" alt="no_results"
src="https://user-images.githubusercontent.com/25592674/224198715-a9131e5c-4bc6-436f-a40a-b1596d44a60c.png ">
Banner-style with regular error message:
<img width="1820" alt="inline"
src="https://user-images.githubusercontent.com/25592674/223456957-20690161-3df6-4954-9a49-96a71c01b74b.png ">
Banner-style with regular error message in mobile:
<img width="404" alt="inline_mobile"
src="https://user-images.githubusercontent.com/25592674/223457106-a09c3d1e-2f66-4060-9888-21edb8504d70.png ">
Standard error dialog:
<img width="1363" alt="error_dialog"
src="https://user-images.githubusercontent.com/25592674/223457178-ec9c2280-4df1-444a-94c7-a8d0580a8f9e.png ">
No results with overridden content:
<img width="1705" alt="no_results_override"
src="https://user-images.githubusercontent.com/25592674/224198770-fea0ed31-ce15-4c77-bcb4-4f14c696c4d4.png ">
Banner-style with overridden content modal:
<img width="1368" alt="modal"
src="https://user-images.githubusercontent.com/25592674/224198816-cbbe8765-a665-472f-8542-1ac108f2c100.png ">
Resolves #149488 .
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )~
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-03-20 20:48:43 -03:00
Chris Cowan
2bd3e8dd20
Remove feature flag for APM Alert Details page ( #150475 )
...
## Summary
This PR removes the
`xpack.observability.unsafe.alertDetails.apm.enabled` feature flag to
enable the Alert Detail page for the APM Latency Threshold Rule. I've
also removed the`alertDetailsAppSection` options along with the
`alertDetailsUrl` action context variable for the remaining APM rules
since the APM Alert Detail page should only be available for the APM
Latency Threshold rule.
I also changed`isAlertDetailsEnabledPerApp()` method to allow the
`apm.transaction_duration` rule type to work but not `apm.error_rate`,
`apm.transaction_error_rate`, or `apm.anomaly` rule types. This change
was necessary because the granularity of the feature flag was set to the
solution level and didn't allow to set the flag per rule type.
### Testing
To test this PR you will need to have some APM data in your cluster.
1. Create an APM Latency Threshold Rule with a low threshold so it will
trigger
2. Create an APM Error Count Rule with a low threshold so it will
trigger
3. Click on the "Action Menu" (the ellipses) in the alert (in the Alert
Table) for the latency threshold alert
4. Click on the "View alert details" menu item for the latency threshold
alert
5. Verify it takes you to the new "alert details" page for APM
6. Repeat steps 3 & 4 for the error count alert BUT it should open the
"alert flyout" instead.
---------
Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-03-20 16:32:55 -07:00
Tiago Costa
4831d1791a
skip flaky suite ( #152852 )
2023-03-20 15:07:24 +00:00
GitStart
49c20b4beb
[Saved Search Embeddable] Add formatting to saved search embeddable document count ( #151989 )
...
[Saved Search Embeddable] Add formatting to saved search embeddable
document count
Resolves https://github.com/elastic/kibana/issues/151545
## Screenshot
### Before
<img width="1432" alt="Screenshot 2023-02-23 at 13 06 50"
src="https://user-images.githubusercontent.com/54555805/220901414-f87eace6-8a94-4459-8a31-1c0914931852.png ">
### After
<img width="1429" alt="Screenshot 2023-02-23 at 13 06 07"
src="https://user-images.githubusercontent.com/54555805/220901380-deb3c89c-9359-4d08-8809-24313e3dcee8.png ">
---
This code was written and reviewed by GitStart Community. Growing future
engineers, one PR at a time.
---------
Co-authored-by: LuisChiej <54555805+LuisChiej@users.noreply.github.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
2023-03-14 15:48:04 -06:00
Rodney Norris
425c236962
[Enterprise Search] Support pages without ent-search ( #152969 )
...
## Summary
Introduces new config properties related to running `enterprise_search`
plugin without the `ent-search` service running. All three default to
`true` and retain the current behavior when they are set to `true`.
`canDeployEntSearch` - Setting to false will result in not showing the
Setup Guide for content pages when `config.host` is not set. Essentially
ungating indices, engines etc. pages.
`hasConnectors` - setting to `false` will result in hiding the connector
ingestion method when creating a new index.
`hasDefaultIngestPipeline` - setting to `false` will result in hiding
the index Pipelines and Content Settings page, until we can migrate
management of default ingest pipeline to the ES module
`hasNativeConnectors` - setting to `false` will result in hiding the
native connector ingestion method when creating a new index.
`hasWebCrawler` - setting to `false` will result in hiding the web
crawler ingestion method when creating a new index.
`hasNativeConnectors` & `hasWebCrawler` are intended to be temporary and
can be removed once we are sure the connectors service and web crawler
will be available in serverless.
2023-03-14 12:09:27 -04:00
Sergi Massaneda
2fa877b172
[Security Solution] Side navigation package ( #152924 )
...
## Summary
Security navigation moved to its own package.
This migration is needed in order to reuse the same component for the
navigation in the Serverless Security plugin
[PoC](https://github.com/elastic/kibana/pull/152172 )
previous location:
`x-pack/plugins/security_solution/public/common/components/navigation/solution_grouped_nav`
new location: `packages/kbn-security-solution-side-nav`
Implementation changes:
- Custom icons removed in favor of new EUI `iconType`.
- Custom `SideNavItem` (for "Get Started" item) removed in favor of more
configuration properties.
- Generic nomenclature.
- Header banner offset special case logic extracted from the navigation
component, new `panelTopOffset` prop added to customize the top position
of the floating panel.
### Screenshot
## Test
`yarn storybook security_solution_side_nav`
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
2023-03-10 18:14:56 +01:00
Devon Thomson
6d0e600ca1
[Unskip] Refactor Create & Add Drilldowns Test ( #152927 )
...
Unskip and refactor create and add drilldown tests
2023-03-09 10:46:28 -05:00
Nathan Reese
edf3a83624
[dashboard] fix Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts ( #152964 )
...
Fixes https://github.com/elastic/kibana/issues/148557
flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000
Image from failed test shows query autosuggest menu is blocking "create
visualize" button. PR fixes issue be pressing escape to close
autosuggest menu if its open.
2023-03-08 14:54:05 -07:00
Kevin Delemme
a04c420569
feat(slo): remove feature flag ( #152834 )
2023-03-08 12:45:05 -07:00
Kibana Machine
a6a03feb06
skip failing test suite ( #152938 )
2023-03-08 13:03:12 -05:00
Hannah Mudge
3270aff474
[Dashboard] [Controls] Fix flaky runtime field test ( #152843 )
...
Closes https://github.com/elastic/kibana/issues/152827
## Summary
This PR potentially fixes the above flaky test or, at the very least, it
will create a more informative failure screenshot if it continues to be
flaky.
The test is failing because, for one reason or another, the scripted
field is not created. I've added a check to ensure that the field is
created **before** navigating back to Dashboard so that, if something is
going wrong in the creation process, we should have a better
understanding of why this has failed (for example, any error toasts).
It's possible, however, that we simply weren't waiting long enough for
the field to actually be added before navigating away - if this is the
case, then my changes **should** also fix this.
### Flaky Test Runner
<a
href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1994 "><img
src="https://user-images.githubusercontent.com/8698078/223538599-126a24a1-5319-4c8e-bb7f-11dfec5b3ed6.png "/></a>
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-07 14:29:51 -07:00
Hannah Mudge
8fec139c78
[Dashboard] [Controls] Make floating actions keyboard accessible ( #152155 )
...
Closes https://github.com/elastic/kibana/issues/135458
Unblocks https://github.com/elastic/kibana/issues/151233
## Summary
This PR adds the floating actions back into the regular HTML tree by
removing the `EuiPortal` that surrounded them, thus making them keyboard
accessible via some added CSS.
In order to do this, however, there were a few changes that had to be
made to the overall Dashboard HTML structure. Previously, as part of
[relocating the Dashboard
scrollbar](https://github.com/elastic/kibana/pull/145628 ), the
scrollable section of the app was moved to the Dashboard viewport, like
so:
https://user-images.githubusercontent.com/8698078/222511861-8707917c-9edc-4292-a182-58924bb00c8a.mov
<br>
While this had a lot of visual appeal, because of the structure of the
HTML tree, the floating actions had to be moved to an `EuiPortal` as
part of this change so that they would continue to float above the top
navigation bar rather than clipping behind it alongside the other
contents of the viewport - this made it impossible to add native
keyboard accessibility since they were removed from the natural HTML
structure.
Unfortunately, by removing the `EuiPortal` in order to allow for
keyboard accessibility, this meant that the scrollable section could
**no longer** be constrained to the viewport - this is because the
`z-index` of child of a given scrollable `div` is **always relative** to
its parent, which means that the floating actions would clip behind the
top nav bar regardless of how high you set their `z-index`:
<p align="center"><img
src="https://user-images.githubusercontent.com/8698078/222518354-80f1df75-69e5-4433-a256-d0b7dc57cd97.gif "/></p>
Therefore, in order to avoid this clipping, the scrollable section had
to remain at the top of the app, like so:
https://user-images.githubusercontent.com/8698078/222512203-60a88fc5-dd68-47ba-aeab-2425afc60a67.mov
<br>
In order to keep the benefit of the top query bar remaining in place,
the top nav bar was added to a **fixed position** `div` that floats
above the contents of the viewport as the user scrolls - this ensures
that the floating actions, which are now also positioned via a `fixed`
container, can still float above the nav bar while remaining part of the
natural order of the HTML tree.
As a follow up, we should also address
https://github.com/elastic/kibana/issues/152609 .
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-06 16:31:50 -07:00
Yulia Čech
b3807ba0b9
[Console] Fix an error with folds in the editor ( #152366 )
...
## Summary
Fixes https://github.com/elastic/kibana/issues/151563
There is a combination of the folds in the editor (collapsed lines) and
the text that can cause the editor to fail. This PR adds a try/catch
clause to the editor, so that the UI can still be used.
### How to use
1. Open Kibana and in your browser's Dev Tools, delete everything from
local storage.
2. Add following 2 items back to the local storage:
```
sense:folds [{"start":{"row":1,"column":1},"end":{"row":82,"column":4}}]
sense:console_local_text-object_e69f508c-3342-45cf-ae7c-2753548ce8e7 {"id":"e69f508c-3342-45cf-ae7c-2753548ce8e7","createdAt":1675332935410,"updatedAt":1676630754720,"text":"GET _cat/indices"}
```
3. Navigate to Console in Kibana, make sure the editor works.
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
2023-03-06 05:33:36 -07:00
Julia Rechkunova
d8f9b1dc03
[Discover] Address flaky filters modal in alerting tests ( #152548 )
...
Closes https://github.com/elastic/kibana/issues/152477
Closes https://github.com/elastic/kibana/issues/152478
Closes https://github.com/elastic/kibana/issues/152479
150x (alert tests)
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1978
100x (context tests)
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1979
2023-03-06 09:11:49 +01:00
Kibana Machine
fe0fd37498
skip failing test suite ( #138160 )
2023-03-02 14:38:26 -05:00
Marco Liberati
7c71786ff9
[Lens][Embeddable] Reset removable error list on search/context update ( #152489 )
...
## Summary
Fixes #152405
This PR tracks search/context updates and resets the "removable" error
list generated on first evaluation.
While fixing the bug I've noticed that Discover (via unified histogram)
and Dashboard update the search context with two different approaches.
The fix acts at two distinct level and I've added functional tests to
verify it is working in both scenarios.
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx ) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-03-02 18:39:19 +01:00
Maja Grubic
d4abfa28a8
[Saved Object Finder] Move to the component in saved_objects_finder plugin ( #151764 )
...
## Summary
This PR replaces the `SavedObjectsFinder` component from `saved_objects`
plugin with the one in `saved_objects_finder` plugin. Code changes are
pretty straightforward; most of the changes are around modifying the
functional tests to work with the selectors from the new component.
### Checklist
Delete any items that are not applicable to this PR.
~- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )~
~- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials~
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
~- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/ ))~
~- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))~
~- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )~
~- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))~
~- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )~!
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-03-01 22:33:18 +01:00
Christiane (Tina) Heiligers
527417590f
Removes FindQueryHTTP['fields'] option in Saved Objects Management ( #152306 )
...
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-02-28 10:46:08 -07:00
Nathan Reese
280b5976b5
unskip Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts ( #152245 )
...
Fixes https://github.com/elastic/kibana/issues/139762
flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965
2 changes where required to get functional tests running
* Switch application state updating from string replace to rison
decode/encode. `_a` is not longer provided in the URL unless there are
unsaved changes to simple string replace did not work in some cases.
Using rison decode/encode was easier then handling a lot of if
statements around whether `_a` exists before attempting string replace,
plus rison decode/encode is a lot more maintainable and robust.
* Fix bug where appending `&_a=(panels:())` to URL would not remove
panels. Updated logic in sync_dashboard_url_state to handle case where
panels has no length.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-02-28 09:23:42 -07:00
