Commit graph

77010 commits

Author SHA1 Message Date
dkirchan
47b06bd894 Fixed comments for PR 2024-08-01 14:48:42 +03:00
dkirchan
7395ff4e71
Merge branch 'main' into security-solution-mki-prod-testing 2024-08-01 14:02:16 +03:00
dkirchan
cb186994f7
Update x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
2024-08-01 14:00:57 +03:00
dkirchan
fb4082cb7b
Update x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
2024-08-01 14:00:45 +03:00
dkirchan
164dd9adad
Update x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
2024-08-01 14:00:34 +03:00
dkirchan
67a490bdef
Update x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
2024-08-01 14:00:21 +03:00
moxarth-elastic
340887d44c
[Sharepoint Server] Add RCF for Authentication type (#189030)
## Summary

Related to https://github.com/elastic/connectors/issues/2112. Adding a
new RCF for authentication type having options as Basic Auth and NTLM
Auth in the Sharepoint server connector.


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-08-01 12:34:57 +02:00
Sid
63a1cbe25e
[Role Mappings] Warn when empty any or all rule role mappings are added (#189340)
Closes https://github.com/elastic/kibana/issues/187752

## Summary

Display a warning to users when a role mapping is created/updated to
include empty `any` or `all` rules

### Screenshots

<img width="1480" alt="image"
src="https://github.com/user-attachments/assets/6cb7e505-95d9-43c6-b8b7-a1f9114cdcda">


### Release notes

Display a warning to users whenever role mappings with empty `any` or
`all` rules are created or updated.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-08-01 05:33:36 -05:00
florent-leborgne
ce8f6ea882
[Docs] 8.15 Kibana What's new (#188767)
## Summary

This PR updates the Kibana What's new page with 8.15 changes, based on
the highlights document produced by PMs.

Closes: https://github.com/elastic/platform-docs-team/issues/441

---------

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: marciw <333176+marciw@users.noreply.github.com>
2024-08-01 12:31:09 +02:00
Joe McElroy
e39c182c06
[Search] [Playground] Fix cloud streaming (#189677)
## Summary

Three major changes:
- Created my own streaming function
- If on cloud, fill up the response so that exceeds the network buffer
that cloud puts into place
  - this buffer entry is ignored on the frontend
- use abortController instead of a variable. Subscribe to changes to the
network request to abort controller signal
- there was a random wait timeout for each chunk. This was introduced
with the error handling though im unsure why its needed. This causes a
big delay in the responses.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-08-01 05:12:48 -05:00
Matthew Kime
afa4313289
[data views] Allow selection of timestamp when some index pattern segments are unmet (#189336)
Currently, if you attempt to create a data view with a index pattern
where some of the segments aren't matched, you can't select a timestamp
field. This is a common use case for security and observability. This PR
allows a timestamp selection as expected.

Closes https://github.com/elastic/kibana/issues/189024
2024-08-01 05:04:41 -05:00
Kibana Machine
3f7d1f226f
[api-docs] 2024-08-01 Daily api_docs build (#189693)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/786
2024-08-01 04:55:20 +00:00
Nathan Reese
817b320584
remove @kbn/presentation-containers from links page load bundle (#189595)
Same as https://github.com/elastic/kibana/pull/189533 but for links
plugin
2024-07-31 17:58:50 -06:00
Jonathan Budzenski
8a60cd4e68 Revert "[ES|QL] Add improved support for Elasticsearch sub-types in AST for both validation and autocomplete (#188600)"
This reverts commit d9282a6e6e.
2024-07-31 18:37:05 -05:00
Jon
d9e1223f28
[build] Update wolfi base image to use digest (#189660)
Migrating from date tags to latest@digest
2024-07-31 17:21:22 -05:00
christineweng
5fd6a486e8
[Security Solution][Alert Details] Remove alert type charts feature flag (#189437)
## Summary

Removing an unused feature flag called `alertTypeEnabled`. The feature
was added in 8.7 (https://github.com/elastic/kibana/pull/152872) but was
never enabled.

This PR removed unused components and renamed directory from
`alert_by_type_panel` to `alerts_by_rule_panel`.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-07-31 17:18:15 -05:00
Quynh Nguyen (Quinn)
d9282a6e6e
[ES|QL] Add improved support for Elasticsearch sub-types in AST for both validation and autocomplete (#188600)
## Summary

This PR addresses https://github.com/elastic/kibana/issues/174710 and
leverages sub-types in AST for both validation and autocomplete. Changes
include:
- Expanded the automatically generated function signatures to not longer
cast to `string` or `number`. Instead, it expands out to `keyword`,
`text`, `double`, `long`, `float`, etc.
- Expanded math function signatures to reflect the true return types
(e.g double + interger => double)
- Expanded function signatures for `bucket`
- Expanded builtin functions to better support types
-  Literal support: 
- Added a `decimal` literal context → Which will be accepted by function
signatures for 'double', 'long', 'float', etc.
- Added and `integer` literal type → Which will be accepted by function
signatures for 'interger'
- Updated tests

After:
<img width="1181" alt="Screenshot 2024-07-24 at 13 06 23"
src="https://github.com/user-attachments/assets/42f32f3b-2e6e-4dff-8b20-dd60f8c45750">
<img width="1726" alt="Screenshot 2024-07-24 at 13 06 47"
src="https://github.com/user-attachments/assets/3c6f1eac-600e-4b2c-9e57-f71f79ad9ce9">
<img width="1726" alt="Screenshot 2024-07-24 at 13 07 09"
src="https://github.com/user-attachments/assets/e8b5817e-d4de-446b-8b41-c6c7b8612420">

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-07-31 17:08:11 -05:00
Patryk Kopyciński
0be8295ed0
[Security Assistant] Fix langgraph issues (#189287)
## Summary

- Fixed `Regenerate` button for Gemini
- Fixed auto title functionality
- Enabled `assistantBedrockChat` by default

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-07-31 15:32:29 -05:00
Philippe Oberti
deb69fb948
[Security Solution][Alert details] - move table tab content to flyout folder (#189140) 2024-07-31 15:26:43 -05:00
renovate[bot]
bdc9a6c98e
Update dependency terser to ^5.31.3 (main) (#188988)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [terser](https://terser.org)
([source](https://togithub.com/terser/terser)) | [`^5.31.2` ->
`^5.31.3`](https://renovatebot.com/diffs/npm/terser/5.31.3/5.31.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/terser/5.31.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/terser/5.31.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/terser/5.31.3/5.31.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/terser/5.31.3/5.31.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/elastic/kibana).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOk9wZXJhdGlvbnMiLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
2024-07-31 14:57:29 -05:00
Jon
5691d536a8
[build] Add Windows ARM64 distribution (#188597)
Only adds the build - this won't be released until Chrome binaries for
reporting have been added, it's been discussed and we have test
coverage. For now this is helpful for testing Windows fixes natively.

For reviewers: I expect most of us don't have a Windows ARM dev
environments. This isn't hooked into anything yet, e.g. enabling uploads
will require another round of review. I've run a smoke test on my end
and am planning on adding incremental support.
2024-07-31 14:26:27 -05:00
Vadim Kibana
e49e89e575
[ES|QL] Implements Visitor pattern for ES|QL AST (#189516)
## Summary

Partially addresses https://github.com/elastic/kibana/issues/182255

- Implements the `Visitor` pattern for ES|QL AST trees. Unlike the
`Walker` (which automatically traverses the whole tree exactly once),
the `Visitor` pattern allows to control the traversal. The developer has
to manually call children "visitor" routines. This manual handling
enables:
  - The AST tree can be traversed any number of times.
  - Only a specific subset of the tree can be travered.
- Each visitor receives a *context* object, which can provide the global
context as well as a linked list to all parent nodes.
- The context object also provides node-specific read/write
functionality.
  - Each visitor can receive *input* from its parent node.
  - Each visitor can return *output* to its parent node.
- The visitor nodes are strictly typed: the context object as well as
inputs and outputs have specific types. Also the inputs and outputs
TypeScript types are inferred automatically from the callback signature
the developer specifies and then the correct input/output usage is
enforced in other callbacks.
- The "scenarios" test file contains real-world usage scenarios, like:
- [Changing the
`LIMIT`](https://github.com/elastic/kibana/pull/189516/files#diff-571e21fd50dbdb664e71297e2edd72c1a1b2b96f346248f0360558ef8ceb75f7R20)
- [Removing a "filter", a `WHERE`
command](https://github.com/elastic/kibana/pull/189516/files#diff-571e21fd50dbdb664e71297e2edd72c1a1b2b96f346248f0360558ef8ceb75f7R57)
 


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-07-31 21:03:42 +02:00
Chris Cowan
6de843b37f
[DataForge] Change service.logs to mimic Nginx logs (#189567)
## Summary

This PR modifies the `service.log` dataset to change the message from a
random set of strings to something that mimics `Nginx` logs. It also
includes `log.level`, `url.*`, and `http.*` metadata structures.

Before

<img width="2048" alt="image"
src="https://github.com/user-attachments/assets/6c5e7277-b0de-46f8-825d-f13c8b77d7fd">


After

<img width="2045" alt="image"
src="https://github.com/user-attachments/assets/b74608a9-b1ca-4db8-8228-35bbbac82c0d">
2024-07-31 13:32:59 -05:00
Kyle Pollich
4b701de036
[Fleet] Fix failing/flaky tests (#189559)
## Summary

Closes https://github.com/elastic/kibana/issues/184310
Closes https://github.com/elastic/kibana/issues/180071
Closes https://github.com/elastic/kibana/issues/109017

Fixes several flaky/failing tests that were qualified as 8.15.0
blockers.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-07-31 14:14:30 -04:00
Kyle Pollich
b40beb17a6
[Fleet] Retry transient errors in agent status API (#189563)
## Summary

Use `retryTransientEsErrors` when fetching agent status to avoid flaky
ES errors throwing a 500.

I'd love to add tests for this, but it's a bit challenging as these
methods rely heavily on an ES runtime field to populate the status
values. The amount of mocking necessary to add Jest tests for these was
getting a bit ridiculous, so maybe FTR is a better way to go?
2024-07-31 14:13:59 -04:00
Stratoula Kalafateli
cf3c4056a3
[ES|QL][Lens] Sends the dashboard filters in the request (#189611)
## Summary

Passes the dashboard context (query, filters, timerange) to the ES|QL
query in order to calculate the results correctly
2024-07-31 19:56:23 +02:00
Maxim Palenov
f5aec5de29
[Security Solution] Reapply Auto-bundle Timeline API OpenAPI specs (#189315)
**Addresses**: https://github.com/elastic/kibana/issues/184428
**Relates to:** https://github.com/elastic/kibana/pull/188844

## Summary

The original [PR](https://github.com/elastic/kibana/pull/188844) was
rolled back by @Ikuni17 due to CI failures in `main` branch. It turned
the problem was caused by a bug in `check_for_changed_files()` which is
fixed in https://github.com/elastic/kibana/pull/189316.

This PR reapplies https://github.com/elastic/kibana/pull/188844 and it
also includes changes to reduce CI reruns (has to be rerun manually in
draft PRs) caused by changes to generated files. It's achieved by
reducing a number of `check_for_changed_files()` invocations.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-07-31 11:48:44 -05:00
Brad White
3d352549e3
[CI] Fix check_for_changed_files from committing to main (#189316)
## Summary

This `if` statement is failing in the on-merge pipeline where
`BUILDKITE_PULL_REQUEST="false"` (See `Environment` tab in
https://buildkite.com/elastic/kibana-on-merge/builds/48189#0190efb6-fae2-415a-85dc-1508717e6e5c).
This cause the function to try to commit changes to a non-existent PR
and fail (see logs in same linked build).
2024-07-31 11:24:12 -05:00
florent-leborgne
5a9913ebdb
[Docs] Add legend statistics info to Lens docs (#189416)
## Summary

This PR adds information about the latest changes brought to legends for
Lens visualizations, with the ability to add statistics and get faster
value when looking at a dashboard. Screenshots, values, and ordering of
these values are based on what I could find on staging. Let me know if
this needs further updating.

We will address the ES|QL visualization bit along with
https://github.com/elastic/platform-docs-team/issues/408#issuecomment-2256114443
as some types of visualizations need to be properly documented,
including this one.

Note that this is also mentioned in the release highlights in a
dedicated paragraph that covers both Lens and ES|QL.

Note: also changing the title level for the section coming after, which
seemed to be behaving strangely and acted like a lvl 6.

Closes: https://github.com/elastic/platform-docs-team/issues/411

- Edited existing paragraph about **legends** on Lens page
<img width="1394" alt="image"
src="https://github.com/user-attachments/assets/8d9d84a9-81c4-40be-adbf-26b971d39502">

- Just under that section, added a new section to describe the various
existing ways to edit a legend (including existing ways)
<img width="1408" alt="image"
src="https://github.com/user-attachments/assets/f5d77305-fd47-4986-91e9-8fb47f950302">
<img width="1360" alt="image"
src="https://github.com/user-attachments/assets/c1c7fe6b-2dc9-4325-a67a-e69109841fb8">
2024-07-31 18:02:30 +02:00
Agustina Nahir Ruidiaz
8d4f579466
[Security Solution] Create new feature flag - dataIngestionHubEnabled (#189620)
## Summary

New feature flag added: `dataIngestionHubEnabled` and implemented in
`onboarding` page.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2024-07-31 18:00:10 +02:00
Quynh Nguyen (Quinn)
204db75e89
[ES|QL] Improve stats BY suggestion to include pipe and comma operators (#189458)
## Summary

This PR improves BY suggestion to include pipe and comma operator for
cases where there's a variable in the group by column.

Before:

![image](https://github.com/user-attachments/assets/ba4dfbc7-6ff4-4cd8-b00f-97cc878d9638)

After:
<img width="1140" alt="Screenshot 2024-07-30 at 11 03 08"
src="https://github.com/user-attachments/assets/aaa08b2e-ae38-4ed7-b227-fe3ebe56746e">

Before:
<img width="890" alt="Screenshot 2024-07-30 at 11 05 54"
src="https://github.com/user-attachments/assets/0f7d8ab4-64ab-46b7-b19e-731085615b6c">


After: 
<img width="1140" alt="Screenshot 2024-07-30 at 11 03 38"
src="https://github.com/user-attachments/assets/a6cb5821-406b-43a1-aef0-939339b5dbc5">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-07-31 10:22:22 -05:00
Cauê Marcondes
305d7f4586
[APM][ECO] Hide feedback modal/remove search bar (#189526)
closes https://github.com/elastic/kibana/issues/189385
- [x] Don't show the feedback modal after it has been dismissed.


https://github.com/user-attachments/assets/894430cf-cc3b-407d-8ff6-50a189d31f4b

closes https://github.com/elastic/kibana/issues/189364
- [x] Remove the KQL bar for log-only services.
<img width="1555" alt="Screenshot 2024-07-30 at 15 49 49"
src="https://github.com/user-attachments/assets/deec8956-1e8a-4517-aa5c-ea3f3225f2e6">

- [x] Remove icon from the breadcrumb, it was breaking the page title.
<img width="1402" alt="Screenshot 2024-07-30 at 16 35 58"
src="https://github.com/user-attachments/assets/360ec82b-aef5-463c-9673-54a6c70ee2c0">
2024-07-31 16:11:11 +01:00
Ignacio Rivas
f78b262faf
[Console] Fix tooltip positioning (#189493) 2024-07-31 17:06:43 +02:00
Jiawei Wu
c73bbc99c4
[Response Ops] Remove "Rule" icontypes (#189342)
## Summary
Fixes: https://github.com/elastic/kibana/issues/189212

Removes `rule` icon type, which is invalid, with valid icons

<img width="489" alt="Screenshot 2024-07-29 at 12 41 53 AM"
src="https://github.com/user-attachments/assets/ea5d158b-85ea-4465-83ba-fcb14486dbfa">

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-07-31 08:06:24 -07:00
Tiago Costa
cdf5f5c480
skip flaky suite (#189637) 2024-07-31 16:00:26 +01:00
Alejandro Fernández Haro
03057681a9
[Move @kbn/config-schema to server] dashboard (#189584) 2024-07-31 10:58:52 -04:00
Katerina
263f00c9de
[APM][ECO] Fix splash screen with the custom no data page (#189607)
## Summary

closes https://github.com/elastic/kibana/issues/189479






https://github.com/user-attachments/assets/889a5778-23c1-4e55-9757-b0df29738fc3
2024-07-31 09:32:35 -05:00
Saikat Sarkar
0cc079a50c
Replace 'model_id' with 'inference_id' for inference endpoints (#189545)
This PR resolves https://github.com/elastic/search-team/issues/7993

Recently, a backend https://github.com/elastic/elasticsearch/pull/111366
was merged to elasticsearch which basically replaces 'model_id' with
'inference_id' in the GET inference api. This change was also backported
to v8.15. Due to this change, the frontend works related to
semantic_text UI and Inference Endpoints view are broken.

---------

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
2024-07-31 08:26:16 -06:00
Philippe Oberti
9e4b353897
[Security Solution][Notes] - fix infinite look refresh note with investigation query (#189606) 2024-07-31 09:25:39 -05:00
Alexi Doak
e828f7508d
[ResponseOps] Remove tech preview from ES query ES|QL rule type (#189568)
Resolves https://github.com/elastic/kibana/issues/189566

## Summary

This PR removes tech preview from the ES query ES|QL rule form


### To verify

- Create an ES query ES|QL rule and verify that the tech preview badge
is removed from the ui.
2024-07-31 07:00:01 -07:00
Dominique Clarke
65a99a5115
[Uptime] only check index status on plugin register if the user has uptime privileges (#189540)
## Summary

Resolves https://github.com/elastic/kibana/issues/186838

Prevents checking for Uptime data on plugin register when the user does
not have Uptime privileges

## Background Context
Uptime is hidden by default. However, there are two ways that the Uptime
app can become accessible.
1. Turning on the Uptime app in the advanced settings
2. If you have data in your Uptime indices within the past 7 days.

The data check present in Uptime plugin register is intended to enable
Uptime if there is Uptime data within the past 7 days. However, there's
no need to check this data if the user does not have privileges.

### Testing
1. Create a user without Uptime Kibana privileges
2. Open up the network tab in dev tools
3. Refresh any page in Kibana
4. You should not see a call to `internal/uptime/index_status`
2024-07-31 09:55:37 -04:00
Ahmad Bamieh
8e10d0eff2
[EBT] Use analytics module (#189052)
The EBT pacakge has been moved to a separate NPM package
([@elastic/ebt](https://www.npmjs.com/package/@elastic/ebt))

The npm package is on version `0.0.x` until we finish the reviews then
i'll publish the `1.0.0` version before merging this PR.

The PR is mostly code deletes after moving the code to the public ebt
github repo https://github.com/elastic/ebt

The significant changes are:
1. removed the `packages/analytics/ebt` package from kibana
2. remove @kbn/ebt references in favor of the npm package.
3. Added a util package to provide the package with the telemetry
endpoint and headers
This was previously backed into the package but now i've rewired it be
provided from Kibana, this way we have more control over the URL and
headers we use to send EBT telemetry for our elastic endpoint, which
will probably be different between users of this package and this way
we'll also avoid republishing the package if we ever want to change
these details.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
2024-07-31 08:31:20 -05:00
Maryam Saeidi
5219a1f14d
[Custom threshold] Respect query:allowLeadingWildcards in optional query filter (#189488)
Partially fixes.   #189072

## Summary

In this PR, we pass the `query:allowLeadingWildcards` for the optional
filter to the custom threshold (specifically
`getSearchConfigurationBoolQuery` function that generates the related ES
Query).

|Before|After|
|----|---|

|![image](a0190f81-d137-4b75-95f2-7358ece99468)|

#### Rule

<img
src="https://github.com/user-attachments/assets/70d2de37-2285-450f-88bf-45aa88954019"
width=500 />

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-07-31 15:29:04 +02:00
Yulia Čech
985948a9f3
[Console] Add inspect tokens action (#189203)
## Summary

This PR enables an action to inspect tokens which is very helpful when
working on grammars/highlighting in Monaco. The command palette is
currently disabled in Monaco that is why I decided to use `F1` key for
inspect tokens in Console.

<img width="646" alt="Screenshot 2024-07-25 at 17 33 37"
src="https://github.com/user-attachments/assets/d2d6064b-851d-46cf-9101-52816835ba78">



### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-07-31 15:09:07 +02:00
florent-leborgne
00579530bd
[Docs] Docs for dashboard creator and editor (#189301)
## Summary

This PR adds documentation relative to the dashboard creator and last
editor information added to Kibana 8.15.
The changes here are fairly granular so I decided to add a new page to
describe the various ways to search and filter dashboards to help users
locate the information. Note that this feature will also be described on
its own in the release highlights.

Closes: https://github.com/elastic/platform-docs-team/issues/431

- Add a new page dedicated to sorting and filtering dashboards to
mention the various ways to do it, including the new filter by creator
<img width="1187" alt="image"
src="https://github.com/user-attachments/assets/c0e3924f-ff0a-4bbb-92d2-776baf243197">
<img width="1421" alt="image"
src="https://github.com/user-attachments/assets/c21320bf-ee31-41bb-a0a4-693f7514b462">

- Mention in Save section of the dashboard creation page
<img width="773" alt="image"
src="https://github.com/user-attachments/assets/6373c384-d427-4502-ba4a-e12f28057224">

- Mention in parent page of Dashboard and visualizations section (Open
dashboard section)
<img width="1215" alt="image"
src="https://github.com/user-attachments/assets/da43222c-a28c-46ca-8f0e-d415793487af">

---------

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
2024-07-31 14:57:27 +02:00
Marta Bondyra
06c18d9179
[Unified Search] Display dataviews in the EuiCombobox as a text and not pills (#189474)
Doesn't display dataviews as pills but as a plain text. Before:

<img width="409" alt="Screenshot 2024-07-30 at 10 47 25"
src="https://github.com/user-attachments/assets/067f362d-8c5f-4895-8354-132e973fb2b3">

After:
<img width="403" alt="Screenshot 2024-07-30 at 10 46 52"
src="https://github.com/user-attachments/assets/1c67988f-0259-4345-bab2-f66f7efe194e">
2024-07-31 14:34:56 +02:00
Dzmitry Lemechko
94dca8d650
[CODEOWNERS] fix appex-qa ownership (#189602)
## Summary

I noticed `elastic/appex-qa` is pinged for quite many PRs.

with #188606 some test folders became packages with `"owner":
"@elastic/appex-qa",`, that autmatically updated CODEOWNERS file with
appex-qa listed for basically every test path.


https://github.com/elastic/kibana/pull/188606/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R878-R881

This PR removes `owner` for the following test "packages"
- x-pack/test_serverless 
- test 
- x-pack/test 

and CODEOWNERS file keeps these paths without specific owner.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-07-31 14:20:47 +02:00
Kevin Lacabane
1e23b6dc3d
[eem] add default lookback (#189395)
Closes https://github.com/elastic/kibana/issues/187348

This changes adds an optional `history.settings.lookbackPeriod` property
that will default to `1h` if none is provided. The main point is to
prevent accidental processing of the entire dataset when creating a
definition.

I took the opportunity to do some refactoring:
- `durationSchema` was transforming a literal duration (eg `1h`) into a
`moment.Duration` with overriden `toJSON` property. since we don't use
any of the `moment` functionalities in consuming code the schema now
returns the raw string after regex validation
- split the `generateHistoryTransform` in `generateHistoryTransform` and
`generateBackfillHistoryTransform`
2024-07-31 14:13:39 +02:00
Julia Rechkunova
22de72d022
[Discover] Allow to select/deselect all rows in the grid at once (#184241)
- Closes https://github.com/elastic/kibana/issues/175943

## Summary

This PR adds a checkbox which allows now to select all rows at once (or
deselect all) on the current page.

- [x] A new checkbox was added to the grid header
- [x] "Compare documents" button was moved under "Selected" menu
- [x] "Compare documents" button gets disabled if user selects more than
100 rows
- [x] "Selected" menu button got a new look
- [x] A new "Select all X" button was added next too "Selected" menu
button

<img width="1554" alt="Screenshot 2024-07-18 at 14 45 00"
src="https://github.com/user-attachments/assets/631cd350-be7d-43be-bc07-c0f6a943bacb">
<img width="563" alt="Screenshot 2024-07-18 at 14 45 10"
src="https://github.com/user-attachments/assets/d49d18f2-d255-401f-b157-3892e6f78d7c">
<img width="443" alt="Screenshot 2024-07-18 at 14 47 02"
src="https://github.com/user-attachments/assets/154c8292-c9b3-409d-b9f6-f78ac83527e9">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-07-31 13:25:03 +02:00
Dmitry Gurevich
c0b60fef4c
[Cloud Security] Add test subjects for controls used in UI Sanity tests (#189510) 2024-07-31 14:03:52 +03:00