Commit graph

5599 commits

Author SHA1 Message Date
Lukas Olson
940f108aeb
[Filters] Remove filter validation for ad-hoc data views (#139431)
* No longer disable filters for invalid data views

* Fix failing test

* Fix functional test

* Remove unused translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-13 11:21:38 -07:00
Rudolf Meijering
191bfbc97e
Saved objects: improve typesafety (#140099)
* Remove SavedObjectAttributes from examples

* Remove SavedObjectAttributes from dev_docs

* Deprecate SavedObjectAttributes type

* Remove SavedObjectAttributes from kibana_usage_collection plugin

* Remove low hanging SavedObjectAttributes in security_solution

* Remove low hanging SavedObjectAttributes in upgrade_assistant

* Remove low hanging SavedObjectAttributes in lens

* Stricter types for SavedObjectsServiceSetup.registerType

* Review feedback

* Some more low hanging fruit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-13 09:56:29 +02:00
Tyler Smalley
44ab700f3d
Removes Percy based visual regression tests (#139252)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2022-09-12 13:08:52 -07:00
Matthew Kime
bcf8c79bb3
[data view field editor] Composite runtime field editor (#136954)
* Initial commit

* [Runtime field editor] Composite runtime in Kibana Data Views (#110226)

* Apply updates from feature branch

* Fix TS issues

* Fix TS issue

* Fix TS issue

* Fix jest tests

* fix jest tests

* fix integration test

* fix delete error test

* partial progress

* partial progress

* remove mistaken change

* fix import

* remove unused translation

* partial progress

* merge

* use preview api

* cleanup

* use specific index instead of index pattern

* fix jest test

* one less any

* setting type on composite subfields is roughly working

* partial progress

* setState not working

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* partial progress

* working but a bit wonky

* merge

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix handing of field types, remove some console.log statements

* fix initial type for subfields

* fix subfield type updates, rename some vars

* fix breakage from bad merge

* fix types

* type fixes

* cleanup

* i18n fix

* i18n fix

* i18n fix

* comment cleanup

* remove unused var

* add code comment

* remove comments

* fix jest test

* add start of functional test

* functional test:

* composite subfield preview

* add functional test

* functional tests

* functional tests

* rendering improvements

* functional tests

* functional tests

* add jest test

* add jest test

* move to observables

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* cleanup

* better use of form lib

* type fixes

* cleanup

* add refresh button

* remove ts ignore

* improve dev docs

* internationalize text

* type fix

* delete should warn regarding subfields

* typescript fix

* redraws of FieldEditor would reset diff state. This fixes it.

* add placeholder text to code editor

* hook cleanup

* add getFieldPreviewChanges jest test

* add getFieldPreviewChanges jest test

* keep parent name in sync with preview when changed during script update

* fix test

* move subfields to observables

* fix jest tests

* fix jest tests

* fix save after field type change to composite

* previewFields to behaviorSubject

* fix test

Co-authored-by: Sébastien Loix <sabee77@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
2022-09-12 08:43:22 -05:00
Spencer
d42e0e1166
[ftr/obs/alerts] refactor to avoid stale-element errors (#140427)
* [ftr/obs/alerts] refactor to avoid stale-element errors

* Revert "skip failing test suite (#140248)"

This reverts commit b0b9b585fb.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-12 08:04:51 -05:00
Dmitry Tomashevich
c80de81964
[Discover] Fix saved search embeddable rendering (#140264)
* [Discover] fix rendering issue

* [Discover] add functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-12 12:58:16 +03:00
Julia Rechkunova
6380e4cecb
[Discover] Fix flaky test regarding field actions in a flyout (#140415)
* [Discover] Fix flaky test regarding field actions in a flyout

* [Discover] Update a11y tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-12 11:01:00 +02:00
Rashmi Kulkarni
3f62679852
timepicker change for tsvb_charts (#140230)
* timepicker change

* timepicker change

* remove comments
2022-09-09 16:49:55 -04:00
Tim Sullivan
95c3893e28
[Search] Re-enable test on example search app (#139961)
* [Search] Unskip ex-flaky example app test

* comment out flaky test code

* use es.transport.request to downsample the test index

* uncomment blocked test code

* remove browser refresh in beforeEach

* fix ts
2022-09-09 10:25:36 -07:00
Rashmi Kulkarni
fb157fab77
unskipping a test to check on CI and FTR (#139756) 2022-09-08 17:10:02 -07:00
John Dorlus
5521574db2
unskip Comment console test 139295 (#140234)
* Updated test to use uiSettings.

* Pushing test to run in CI.

* Pushing test to run in CI.

* Fixed issue with merge conflict and removed comment for skipped test.
2022-09-08 13:35:41 -04:00
Joe Reuter
e7a8c875e7
[Lens][TSVB][Agg based] TSDB warning handling support for Lens, Agg based and TSVB (#136833)
* start integrating TSDB into Lens

* current state

* make new type filter work

* fix translations

* handle warnings

* clean up and make warnings better

* split function list for referenced fields too and extend list of unsupported functions

* improve warnings

* fix a bug

* add todo for utc timezone

* adding TSDB support to DataViews

* adding test

* date_histogram: force fixed interval for tsdb rollups

* fixing types

* fixing types

* fixing types

* fixing types

* handling edge cases

* removing undefined entries from FieldSpec

* renaming .meta property

* enforce UTC timezone

* isRolledUpField helper

* updating snapshot

* adjust fixed interval and utc timezone for timelion and tsvb

* fixed interval mapping

* fixing test

* add showWarning to search service

* add comments

* add unit tests

* test foo

* cleanup

* add s to property name in test

* comments for api items

* fixing test

* use the warnings when calling showWarnings

* change showWarning to just show a single warning

* put handleWarnings on the request adapter

* comment

* simplify 1

* fix lens unit test

* fix PR

* remove duplicate identifier

* remove underscoring for unused variables

* revert inspector changes, extract the response warnings in the search service

* fix bug

* remove console.log

* re-apply typescript fixes to app test code

* declutter

* add test, improve comments

* fix some unexported public api items

* include rawResponse in the warning structure

* fix lint

* tweak clean up example app

* SearchResponseWarnings and SearchResponseWarningNotification

* fix export bug

* not include shardStats if there are no warnings

* Update src/plugins/data/common/search/types.ts

* fix duplicated entries

* remove empty line

* simplify SearchResponseWarnings interface

* remove array copying

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* comments for api_docs

* simplify per feedback

* Pass callback to handleResponse in showWarnings

* export more public types

* update example to make possible to show shard failure

* pr cleanup

* eslint fix

* allow example app to not show default warnings

* move extractWarning and related types to inspector plugin

* wip functional test of example app

* fix test references

* finish functional test

* relocate extractWarnings back to search/fetch

* fix test

* remove need for isTimeout, isShardFailure

* ts fix

* improve test

* Change showWarnings to accept the RequestAdapter

* use showWarnings in vis_types/timeseries

* more tests

* use handle_warning name

* fix ts

* add reason field to SearchResponseWarning

* fix component snapshot

* update comments

* test cleanup

* fix test

* ensure notification appears only once

* fix and cleanup

* fix ts

* fix response.json bug

* use top-level type, and lower-level reason.type

* cleanup

* change warning structure

* change warning infrastructure

* fix

* allows to disable automatic handling of shard warnings on expressions

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fix tests

* fix tsconfig json

* allows to disable automatic handling of shard warnings on expressions

* fix tests

* allows to disable automatic handling of shard warnings on expressions

* disable warnings the right way

* fix stuff and clean up

* random cleanup

* fix test

* remove unused function

* review comments

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* style warnings and switch to real error message

Co-authored-by: ppisljar <peter.pisljar@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-08 08:59:38 -07:00
Dmitry Tomashevich
e11bea9178
[Lens] Move field existence from Lens to UnifiedFieldList plugin (#139453)
* [Lens] move field existence from to unified field list plugin

* [Lens] update readme, move integration tests

* [Lens] update wording paths

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* [Discover] fix loader tests, clean up code

* [Discover] update datapanel tests, clean up code

* [Discover] remove comments

* [Discover] fix problem with filters

* [Lens] apply suggestions

* [Discover] remove spread

* [Discover] fix type checks

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-09-08 16:59:33 +03:00
Kibana Machine
4c3d562a73 skip failing test suite (#139762) 2022-09-08 07:28:45 -06:00
Maja Grubic
19293950ae
[Kibana Overview] Fix failing test (#139112)
* [Kibana Overview] Fix failing test

* Remove comment

* Fix regexp

* Add a comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-08 10:38:26 +02:00
Constance
98f73d674a
Upgrade EUI to v63.0.6 - updates to new EuiPageTemplate and deprecates old page components (#139524)
* Update all usages of EuiPageTemplate to EuiPageTemplate_Deprecated

* EuiPageContent_Deprecated as EuiPageContent

* EuiPageContentBody_Deprecated as EuiPageContentBody

* EuiPageContentHeader_Deprecated as EuiPageContentHeader

* EuiPageContentHeaderSection_Deprecated as EuiPageContentHeaderSection

* EuiPageSideBar_Deprecated as EuiPageSideBar

* EuiPageContent__Deprecated to EuiPageContent_Deprecated

* Fix rogue semi-colons

* WIP: NoDataConfigPage & NoDataPage converted to new template

- `withSolutionNav` not yet handled

* WIP: KibanaPageTemplateInner converted to use new template

- Pushes existing `pageHeader` prompts onto created EuiPageTemplate.PageHeader
- Uses `isEmptyState` to push `pageHeader` props to EuiPageTemplate.EmptyPrompt instead (if `children` are not supplied)

* WIP: `withSolutionNav` now renders the sidebar content properly

- Collapsing isn’t working (minWidth isn’t updating)

* Fixing stickiness of sidebar

* [Security] Fixed SecuritySolutionTemplateWrapper’s usage

- Moved `bottomBar` to EuiPageTemplate.BottomBar (now contained in just the page contents)
- Change EuiPanel children wrapper with EuiPageTemplate.Section

* [O11y] Wrap `children` with EuiPageTemplate.Section

* Fix getting_started usage

* WIP: Fixing types

* Removing `template` pass through

* Set EUI to 63.0.0

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* More import fixes

* Sidebar component update

* Expand `KibanaPageTemplate` to all namespaced EUI counterparts

- Updated `docs/tutorials` mdx page
- Fixed SolutionNav prop types

* Updated the tutorial mdx page

* [Stack Management] Updated app layout to new template

- Some temporary props applied for BWC until all other pages can be converted
- Converted `API Keys` page’s layout (and especially prompt usags) to new paradigm

* Fix circular dep

* Fix new circular dependency

- copying and pasting types from KibanaPageTemplateProps, but ah well

* [Security Solution] Remove `template` prop - no longer a prop on Kibana/EuiPageTemplate

* [O11y] Allow customizing EuiPageTemplate.Section wrapper

- converts pageBodyProps
- fixes non-centered loading template

* [Enterprise Search] Update page templates

- fix layouts by auto-wrapping an EuiPageSection for padding, while adding a `customPageSections` prop for more custom sections/layouts

- re-center 404 errors

- update tests

* Update KibanaPageTemplate tests

* Update snapshots

* Fix FTR test with removed EUI classNames

* Fix FTR tests with changed kbn classNames

* Update failing dashboard snapshots

- drop shadow changed slightly in EUI

* Fix failing Security Cypress test

* [O11y] Fix Inventory page using deprecated CSS hooks

* [O11y][Uptime] Fix missing bottom bars

- Modifies ObservabilityPageTemplate to accept a `bottomBar` prop (a la the old EuiPageTemplate behavior)

NOTE: This opinionated page layout structure is starting to feel like it could be potentially limiting / have all the same pitfalls the previous EuiPageTemplate did. If so, consider something closer to the Enterprise Search page template conversion (`customPageSections`).

- Misc cleanup: Use `KibanaPageTemplate` over `EuiPageTemplate`

* [O11y] Fix route template typing

- Since theObservabilityPageTemplate is using the new Eui/KibanaPageTemplate, its child templates and types need to be updated accordingly

* Fix broken minWidth behavior

- was an EUI issue that required a patch release
+ update snapshots

* [Security Solution] Type fixes, restore empty state

- Fix empty state logic removed in a previous commit
- bogarts KibanaPageTemplate's `isEmptyState` prop instead of using `template="noData"`

- extend template wrappers to past ...rest to underlying Kibana/EuiPageTemplate

+ replace EuiPageTemplate with KibanaPageTemplate for consistency

* Fix failing synthetics selector

* Grab EUI v63.0.6

- for deprecation tags and section tag support

* Fix Kibana Overview plugin layout

- needs to use KibanaPageTemplate.Section to get padding back

- use `bottomBorder` prop over horizontal rules

- restore previous page color via panelled=false

* Convert Home plugin to new KibanaPageTemplate

- use KibanaPageTemplate.Section instead to preserve page width/paddings

- use `bottomBorder` instead of `EuiHorizontalRule`

- NOTE: This causes margins to decrease slightly from xxl to xl (largest padding available for EuiPageSection) - this can be restored by CSS overrides if desired

- update CSS to preserve previous looks, + convert to logical properties

* [O11y] Fix non-centered empty/loading states

* [O11y] Restore subdued background on various empty state prompts

* [O11y] Fix all instances of views that require a scrollable full-height child

+ restore comment for inventory view

* [O11y][ux] Fix broken sidebar

- The entire app was missing a wrapping EuiProvider, and as such breakpoint utils were not working, and the sidebar was missing

+ misc cleanup
  - remove unnecessary fragment
  - remove role="main" attr - now that EuiPageTemplate sets a `main` tag, they'll conflict
  - add isEmptyState to center loading component

* [APM Cypress tests] harden flaky test

* [APM Cypress tests] Fix failing Cypress test, again

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-07 15:35:23 -05:00
Nathan Reese
ddcae9cfcf
[Controls] timeslider control (#139228)
* Timeslider plugin boilerplate

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* Spacetime timeslider dash (#138553)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* Wire up timeslice (#138570)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* Spacetime timeslider dash (#138573)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* Notify control group when all panels loaded (#138674)

* get play button working

* play button (#138681)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* get play button working

* cleanup

* clean up

* clean up wrap logic

* Spacetime timeslider dash -clean up wrap logic (#138822)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* get play button working

* cleanup

* clean up wrap logic

* Add waitForPanelsToLoad$ observable (#138950)

* fix import

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* sync range slider width on popover panel resize

* fix styling

* update embeddables to support time slice

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* change file structure

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* disable add button when control group contains timeslider

* hide edit button for timeslider control

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* force timeslider width to be large

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* use timeslice to filter other controls

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* skip timeslider control in control chaining

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* cleanup

* fix initial timeRange

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* clear button

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* render prepend

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* remove unused code

* Container.getAnyChildOutputChange$

* play observable

* tslint

* tslint

* clean up

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix lint

* fix import

* fix plugin size and other clean up

* fix 'unsaved changes' issue

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fix Dragging UI Nit

* fix Label position Above Nit

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* support relative time ranges

* fix issue where clear not propogated to panels

* time slider functional test

* clean up functional test

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* tslint

* fix time_slider functional test

* fix time slider not expanding after creating non-expanding control

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-09-07 11:21:53 -06:00
Kibana Machine
5ebefbb3e5 skip failing test suite (#140113) 2022-09-06 12:49:02 -06:00
Faisal Kanout
d11ee880b1
[Actionable Observability] - Hide the alert details page behind a feature flag (#139806)
* WIP - feature flag alert details page

* Add tests

* Add comment for upcoming tests

* Fix tests

* fix test and add mocks for usePluginContext

* Fix failing test

* Fix wording

* Fix test

* Update readme and kibana-docker

* Fix tests permissions

* Restore tests

* Fix flaky test

* Fix flaky

* Fix flaky

* wait to display the button

* Fix flaky

* Fix flaky

* Add 404 page and skip the flaky test

* re-enable tests

* Put message for the flaky test

* Update comment
2022-09-06 17:36:46 +02:00
Spencer
5adda1f63b
[ftr/testSubjects/clickOnEnabled] retry on stale-element exceptions (#139964)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-06 08:28:09 -07:00
Anton Dosov
96a6d85beb
Unskip significant_text agg test (#139638) 2022-09-05 02:41:24 -07:00
Lee Drengenberg
892e6327d4
[Archive Migrations] remove es_archiver/empty_kibana from Fleet api tests (#139505)
* remove use of empty_kibana es_archive

* remove empty_kibana archives again

* replace es_archiver/empty_kibana with cleanStandardList

* remove more empty_kibana uses

* add cleanup of a package

* remove comment

* add Fleet saved object types to cleanStandardList

Co-authored-by: Spencer <spencer@elastic.co>
2022-09-01 13:57:46 -04:00
Dzmitry Lemechko
7b0033f68c
[scalability testing] store relative path to kbnArchives/esArchives in dataset extractor output file (#139891)
* update journeys, save testData in output json

* fix config inheritance

Co-authored-by: spalger <spencer@elastic.co>
2022-09-01 18:34:40 +02:00
Davis McPhee
cb0a8057c8
[Discover] Enable tags for saved searches (#136162)
* [Discover] Add initial support for tags to saved search modal

* [Discover] Add tags to savedSearch types

* [Discover] Finish initial support for adding tags to saved searches

* [Discover] Start to convert saved object finder to a table in order to support tags

* [Discover] Add support for displaying saved search tags in open search flyout

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [Discover] Continue support for tags in saved object finder

* [Discover] Clean up saved object finder

* [Discover] Finish initial support for tags in saved object finder

* [Discover] Update SimpleSavedObject constructor to SimpleSavedObjectImpl

* [Discover] Remove orig files

* [Discover] Saved search tag type registration and telemetry

* [Discover] Create new saved_objects_finder plugin

* [Discover] Continue work creating saved_objects_finder plugin

* [Discover] Revert some changes in saved_objects

* [Discover] Revert some changes in saved_objects again

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* [Discover] Update saved_objects_finder i18n keys

* [Discover] Update docs

* [Discover] Add plugins to saved_object_finder and fix broken types

* [Discover] Finish creating saved_objects_finder plugin and use it in Discover

* [Discover] Update SavedObjectFinderProps type export, and update x-pack telemetry

* [Discover] Fix broken jest tests

* [Discover] Update saved_objects_finder API

* [Discover] Remove unused translations

* [Discover] Fix issue with initial saved object finder fetch

* [Discover] Fix some of the saved object finder jest tests

* [Discover] Clean up finder after merge

* [Discover] Fixing saved_object_finder.tsx

* [Discover] Add savedObjectsTaggingOss reference to saved_search plugin

* [Discover] Fix broken open_search_panel test

* [Discover] Removed allowed types from saved object finder

* [Discover] Removing type column when there's only one saved object type, and adjusting column widths

* [Discover] Fix issue where visible types were entirely removed, fixed pageSizeOptions

* [Discover] Add showFilter to open_search_panel's saved_objects_finder, fallback to all available types when no type filter is applied to saved_objects_finder, hide type column and filter button when there is only one type in metadata list

* [Discover] Fix remaining saved_object_finder Jest tests

* [Discover] Update snapshot

* [Discover] Fix failing functional tests

* [Discover] Add tagging Jest tests for saved_objects_finder

* [Discover] Fix small bugs in saved_object_finder, update Jest tests, add functional tests for Discover saved search tagging

* [Discover] Removed unused variable in functional test

* [Discover] Update Discover Jest tests with tagging tests

* [Discover] Remove translations

* [Discover] Updating saved_objects_finder to use static export vs preconfigured component, adding lazy load support

* [Discover] Move saved_object_finder service deps to a 'services' prop, fix broken open_search_panel Jest test

* [Discover] Fix broken Jest test

* [Discover] Fix broken Jest test from merge

* [Discover] Fix discover tags integration test description

* - Updated tags prop to be `string | undefined`
- Type imports cleanup
- Added loading indicator for saved object finder
- Changed `savedObjectsPlugin.settings.getListingLimit()` to `uiSettings.get(LISTING_LIMIT_SETTING)`
- Removed old saved object finder comment
- Removed tag changes from transform plugin
- Change code owners of saved_objects_finder to Data Discovery

* [Discover] Fixed LISTING_LIMIT_SETTING import

* [Discover] Revert tags saving change that introduced a bug

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* [Discover] Try again to fix LISTING_LIMIT_SETTINGS import

* [Discover] Fix failing snapshot

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-01 13:14:13 -03:00
Spencer
e620280d87
[docs/ops] write docs about flaky tests (#139866)
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
2022-09-01 16:23:49 +01:00
Constance
f0cf292b4b
Attempt to harden lens flaky filter test (#139861) 2022-09-01 07:34:12 -07:00
Bhavya RM
c2a1f48fd4
Timepicker UI refactoring of x-pack/test/functional/apps/maps/group4/discover.js to use ui settings (#137321) 2022-09-01 09:11:57 -04:00
Kibana Machine
b1db78a0ac skip failing test suite (#139879) 2022-09-01 08:43:49 -04:00
Baturalp Gurdin
07aa6d9586
ingest ciBuildName flag to telemetry along with labels (#139098)
* send isBareMetal flag to telemetry along with labels

* add isBareMetal field to tests

* add ciBuildName

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-31 22:48:41 -07:00
Tim Sullivan
160058a8c1
[search/public] expose showWarnings(inspector) method on search service (#138342)
* add showWarning to search service

* add comments

* add unit tests

* test foo

* cleanup

* add s to property name in test

* comments for api items

* use the warnings when calling showWarnings

* change showWarning to just show a single warning

* put handleWarnings on the request adapter

* comment

* simplify 1

* fix lens unit test

* remove underscoring for unused variables

* revert inspector changes, extract the response warnings in the search service

* fix bug

* remove console.log

* re-apply typescript fixes to app test code

* declutter

* add test, improve comments

* fix some unexported public api items

* include rawResponse in the warning structure

* fix lint

* tweak clean up example app

* SearchResponseWarnings and SearchResponseWarningNotification

* fix export bug

* not include shardStats if there are no warnings

* Update src/plugins/data/common/search/types.ts

* simplify SearchResponseWarnings interface

* remove array copying

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* comments for api_docs

* simplify per feedback

* Pass callback to handleResponse in showWarnings

* export more public types

* update example to make possible to show shard failure

* pr cleanup

* eslint fix

* allow example app to not show default warnings

* move extractWarning and related types to inspector plugin

* wip functional test of example app

* fix test references

* finish functional test

* relocate extractWarnings back to search/fetch

* fix test

* remove need for isTimeout, isShardFailure

* ts fix

* improve test

* Change showWarnings to accept the RequestAdapter

* use showWarnings in vis_types/timeseries

* more tests

* use handle_warning name

* fix ts

* add reason field to SearchResponseWarning

* fix component snapshot

* update comments

* test cleanup

* fix test

* ensure notification appears only once

* fix and cleanup

* fix ts

* fix response.json bug

* use top-level type, and lower-level reason.type

* cleanup

* fix shard failure warning in tsvb per feedback

cc @flash1293

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-08-31 11:22:24 -07:00
Marta Bondyra
dc43193d73
[Lens] fetching annotations: small fixes (#139695)
* [Lens] fetching annotations: don't replace label with textField

* don't pass timezone but read uiSettings

* some params should be required

* passing id from annotations for expressions

* adapt the rendering code to later use datatable structure
2022-08-31 13:01:11 +02:00
Bhavya RM
275e319406
Dashboard panel a11y tests refactoring and addition of missing tests (#139597) 2022-08-30 14:24:54 -04:00
Pierre Gayvallet
383d8fab58
Move client-side application service to packages (#139502)
* deletes unused utils file

* just some fix while I see it

* creating empty packages

* moving all the things

* package build success

* start fixing usages

* fix the scoped history type issue

* export internal utils

* add default for mock

* fix test import

* fix external import

* start fixing external usages

* more usages

* more usages

* more usages

* More usages

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fix integration test imports

* fix more test types

* remove public/utils from the core bundle

* trying to import from the package

* updating README's

* remove unused test types from mock package

* cleanup test types

* use import type

* add author to packages

* more import type

* remove dead path from some config

* remove src/core/utils/index.ts (and pray)

* update tsdoc

* fix new file usage

* fix paths

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-30 10:08:44 -07:00
Tiago Costa
1cbf83f73c
chore(NA): remove src folder requirement from packages (part 2) (#138476)
* refact(NA): apply root_input_dir=src to each already created pkg

* refact(NA): update package generator

* fix(NA): correctly use rootDir

* fix(NA): use root input dir on latest introduced pkgs for jsts_transpiler macro

* chore(NA): merge with main

* chore(NA): first attempt to complete removal of src folder on a small group of pkgs

* Revert "chore(NA): first attempt to complete removal of src folder on a small group of pkgs"

This reverts commit b6f34b7530.

* chore(NA): remove src folder requirement from xpack pkgs

* chore(NA): remove src folder from analytics pkgs

* chore(NA): remove src folder from home pkgs

* chore(NA): remove src folder from shared_ux pkgs

* fix(NA): remove missing src folder inputs on sharedux pkg

* chore(NA): remove src folder from kbn-a* pkgs

* chore(NA): remove src folder from kbn-b* pkgs

* chore(NA): remove src folder from kbn-c* pkgs

* chore(NA): correct exclude pattern for each changed pkg

* chore(NA): remove src folder from kbn-y* pkgs

* chore(NA): remove src folder from kbn-e* pkgs

* chore(NA): remove src folder from kbn-f* and kbn-g* pkgs

* chore(NA): remove src folder from kbn-f* and kbn-g* pkgs

* chore(NA): remove src folder from kbn-h** pkgs

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Revert "chore(NA): remove src folder from kbn-h** pkgs"

This reverts commit dcdf72bcc1.

* fix(NA): grammar location

* test(NA): fix tests for kbn/config-schema

* test(NA): fix tests for kbn/config-schema

* chore(NA): multiple errors fixed

* chore(NA): remove kuery grammar fix

* fix(NA): @kbn/ace imports

* fix(NA): grammar location

* fix(NA): add missing files to tsconfigs

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* chore(NA): complete tsconfigs

* Revert "chore(NA): complete tsconfigs"

This reverts commit f48c616864.

* chore(NA): remove src folder from kbn-core* pkgs

* chore(NA): remove src folder from kbn-u* pkgs

* chore(NA): remove src folder from kbn-ui-shared-deps* pkgs

* chore(NA): fix problems on core pkgs

* chore(NA): fix problems on core pkgs

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix(NA): shared_built_assets correct location'

* test(NA): update @kbn/optimizer integration snapshots

* chore(NA): remove src folder from kbn-t* p1 pkgs

* chore(NA): remove src folder from kbn-t* p2 pkgs

* chore(NA): update rootDir on utility types pkg

* chore(NA): include missing files on @kbn/test

* chore(NA): include missing files on @kbn/test

* fix(NA): new jest preset paths on @kbn/test

* chore(NA): fix eslint

* fix(NA): new jest preset paths on @kbn/test

* chore(NA): remove exclusion for mocks folde on @kbn/test

* fix(NA): several imports from target_node

* fix(NA): @kbn/test mocha and jest types clash

* chore(NA): remove src folder from kbn-storybook pkg

* chore(NA): remove src folder from kbn-stdio-dev-helpers pkg

* chore(NA): remove src folder from kbn-std pkg

* chore(NA): remove src folder from kbn-sort-pkg-json pkg

* chore(NA): remove src folder from kbn-some-dev-log and kbn-shared-ux-utility pkgs

* chore(NA): remove src folder from kbn-ux-storybook pkg

* chore(NA): remove src folder from kbn-shared-ux-services pkg

* chore(NA): remove src folder from kbn-shared-ux-components pkg

* chore(NA): remove src folder from kbn-shared-svg pkg

* chore(NA): remove src folder from kbn-server-http-tools pkg

* chore(NA): remove src folder from kbn-securitysolution-* pkgs

* chore(NA): remove src folder from kbn-r-* pkgs

* chore(NA): remove src folder from kbn-p* pkgs

* chore(NA): remove src folder from kbn-o* pkgs

* chore(NA): remove src folder from kbn-m* pkgs

* chore(NA): remove src folder from kbn-j,k,l* pkgs

* chore(NA): remove src folder from kbn-j,k,l* pkgs

* chore(NA): remove src folder from kbn-io-ts-utils* pkgs

* chore(NA): remove src folder from kbn-* pkgs except a few

* chore(NA): update @kbn/generate

* fix(NA): wrong exclusion on kbn-storybook

* chore(NA): remove src folder from kbn-monaco pkg

* chore(NA): remove src folder from kbn-interpreter pkg

* fix(NA): wrong exclusion on kbn-storybook

* chore(NA): update every require for target_*/src

* chore(NA): remover src folder from @kbn/handlebars

* fix(NA): license for @kbn/handlebars

* chore(NA): copy templates as part of the jsts_transpiler macro for @kbn/storybook

* chore(NA): update handlebars

* fix(NA): @kbn/plugin-generator import paths

* fix(NA): bundle sizes

* fix(NA): web bundle for @kbn/i18n-react

* Revert "fix(NA): bundle sizes"

This reverts commit 8aefe84fbc.

* Revert "Revert "fix(NA): bundle sizes""

This reverts commit e9d87d72a4.

* fix(NA): @kbn/docs-utils index.ts path expectation

* chore(NA): merge and solve conflicts with main

* fix(NA): relative import to index

* chore(NA): merge and solve conflicts with main

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* chore(NA): apply eslint fix

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-30 15:57:35 +01:00
Jonathan Budzenski
04d1ffea7e
set NODE_ENV=production for bin/* (#139649)
* Set NODE_ENV=production for bin/*

* add tests

* Revert "Set NODE_ENV=production for bin/*"

This reverts commit 8012ed6a2e.

* Revert "Revert "Set NODE_ENV=production for bin/*""

This reverts commit 2fd499c112.
2022-08-30 09:01:51 -05:00
Tiago Costa
fdbf1829ce
skip flaky suite (#139659) 2022-08-29 22:08:45 +01:00
Rashmi Kulkarni
e8f9dd99ed
timepicker change (#135478) 2022-08-29 11:32:47 -07:00
Jonathan Budzenski
7919682c07 skip flaky suite. #138652 2022-08-29 10:30:33 -05:00
Marta Bondyra
76dc50cefe
[Event Annotations] Fetching annotations (#138618)
* allow handleEsaggsRequest to be used externally for event_annotation plugin

* fetch annotation expression

* fix skippedCount

* add tests

* added textField

* timezone fix

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* query to query point

* cr

* code review changes

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-29 17:10:26 +02:00
Stratoula Kalafateli
255f24d595
[Lens] Enables ad-hoc dataviews (#138732)
* [Lens] Enables ad-hoc dataviews

* Fix bug in legacy field existence logic

* lift ad hoc state to frame level and rename data view on incompatible change

* fix some tests

* migrate embedded ad hoc data views

* fix tests and inject/extract ad hoc data view references

* fix bugs and add functional tests

* fix unit tests

* do not show geo fields for ad hoc data views

* Fix functional test

* Refactor to use the new metric viz on the functional tests

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-08-29 15:16:47 +03:00
Lee Drengenberg
a029e68e56
[Archive Migration] batch 5 of removing empty_kibana (#139410)
* remove use of empty_kibana es_archive

* remove empty_kibana archives again

* replace es_archiver/empty_kibana with cleanStandardList

* remove more empty_kibana uses

* add cleanup of a package

* remove comment

* move fleet_setup before epm, something not cleaning packages

* revert fleet_api_integration changes and restore empty_kibana
2022-08-27 11:24:39 +03:00
Peter Pisljar
f68751054a
[DataViews] expose list of matched indices (#139067) 2022-08-25 18:32:06 +02:00
Greg Thompson
df6392a97c
Upgrade EUI to v62.2.3 (#138837)
* eui to v62.2.0

* i18n updates

* EuiDescriptionListProps imports

* eui to v62.2.1

* euitoast selector updates

* more EuiDescriptionListProps imports

* eui to v62.2.2

* snapshot updates

* snapshot updates

* toast selector updates

* more snapshot updates

* toast selector

* TRIAL: timeout for loading spinner

* do not assume a popover is closed before attempting to open it again

* Revert "do not assume a popover is closed before attempting to open it again"

This reverts commit 1b231657cb.

* remove wait

* eui to v62.2.3

* Fixx fleet unit test

* eui to v62.2.4

* snapshot updates

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2022-08-24 15:02:47 -05:00
Jeramy Soucy
de9b7c6f48
Remove file-type dependency via jimp (#137214)
* Removed file-type from package.json deps.
Updated jimp to 0.16.1.
Updated light & dark dashboard baseline screenshots to resolve failure due to resize degradation.

* Replaced jimp with sharp and pixelmatch. Eliminates several deps, including file-type.
Eliminates quality degradation from image resizing.

* Fixed copy paste error, which lead to pass positives and errors.

* Integrated updateBaselines flag into dashboards report testing.
Fixed sharp resize to fit and not truncate the original image.

* Removed accidental '.only'

* Reverted area chart baseline.

* Removed explicit declaration of sharp from package.json.

* Adjusted dashboard screenshot size in attempt to eliminate layout scaling issues in CI testing.

* Reverted dashboard screenshot size. Lowered tolerance in dashboard PNG reporting tests to force failure and collect CI screenshots.

* Changed session save location for dashboard report images for better CI reporting.

* Fixed small dashboard baseline screenshot with correct aspect ratio.

* Updated 2 basline screenshots from CI. Lowered PNG match tolerance for dashboard screenshots to 1% for investigation of remaining screens.

* Update of dashboard controls light mode baseline.
Change of forced container width size in large dashboard layout test.

* Updated dashboard controls dark mode baseline screenshot.
Adjusted forced container width in large dashboard layout test for troubleshooting.

* Lowering tolerance of PNG compare tests from 9% to 1% for troubleshooting.
Replaced references to dedundant image service with existing, more adopted reporting service.
Ideally, the PNG functions of the reporting service would be merged with the screenshot service as an image service.

* Reverting tolerance of PNG compares to 0.09. Will create GH issues for specific teams to investigate.

* Implemented PngService to provide an accessible single reference to PNG compare testing.
Removed redundant implementations and references.

* Updated service reference and call to png compare function left out of last commit.

* Updated another missed PNG reference.

* Removed superfluous parameter.

* Update after bootstrap

* Updated area chart baseline to match new render with panel filters.

* Reverted limits in dashboard snapshot tests to original values.

* Merge and rebuild.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-24 11:24:38 -07:00
spalger
2576403be4 Revert "replace es_archiver/empty_kibana with cleanStandardList (#139324)"
This reverts commit 220578bf48.
2022-08-24 09:44:52 -07:00
Tim Sullivan
348d59c92d
[DataViews] fix behavior for loading a missing data view (#139044)
* [DataViews] fix behavior for loading a missing data view

* remove link text from error message

* add functional test

* update error toast notification title

* cleanups

* update content and add toastMessage

* revert change to error message params

* update content per feedback

* error might be null-ish

* fix bug
2022-08-24 09:12:28 -07:00
Lee Drengenberg
220578bf48
replace es_archiver/empty_kibana with cleanStandardList (#139324) 2022-08-24 09:53:31 -06:00
Nathan Reese
6ad1d1da86
Fix Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group2/embeddable/embeddable_library·js (#139233)
* Fix Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group2/embeddable/embeddable_library·js

* check if button exists

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* use action menu

* clean up

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-23 19:19:56 -06:00
Lee Drengenberg
8d412c6ac6
[Archive Migration] batch 3 of removing es_archives/empty_kibana (#139319)
* replace es_archiver/empty_kibana with cleanStandardList

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-23 18:01:31 -05:00
Catherine Liu
239def566c
[Controls] Removes timeslider in favor of new timeslider control (#138931)
* Removed timeslider in favor of new timeslider control

* Removed time slider import

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fixed i18n errors

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-23 12:49:35 -07:00