Commit graph

5599 commits

Author SHA1 Message Date
John Dorlus
c652cb4424
Migrate dashboard tests to use UI settings (#136585)
* Updated test to use uiSettings.

* Unskipped embeddable rendering testg.

* Removed timepicker reference that is unused.

* Removed comment of flaky test.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-20 01:03:34 -04:00
Hannah Mudge
b31b076b07
[Dashboard] Fix z-index of embPanel__header--floater (#136463)
* Remove panel wrapper element

* Fix functional tests to work without wrapper

* Remove duplicated code

* Re-add classes to right-justify in view mode

* Apply high z-index to children of floating header rather than parent
2022-07-19 18:15:31 +02:00
Tiago Costa
302bd423f3
chore(NA): eslint rule for disallowing naked eslint-disable (#136408)
* chore(NA): eslint rule for disallowing naked eslint-disable

* chore(NA): export new rule and update docs

* chore(NA): creation of rule in ts

* chore(NA): new corrected rule in ts

* refact(NA): remove old logic from older plugin

* docs(NA): update documentation

* docs(NA): update documentation

* docs(NA): update documentation

* refact(NA): include edge cases for better locating errors

* chore(NA): changed regex name

* docs(NA): correct name rule on docs

* refact(NA): use dedent in the template literals

* refact(NA): check for undefined

* fix(NA): introduces support for eslint-disable-line

* chore(NA): fix extra space

* test(NA): created more test cases

* chore(NA): rename plugin to eslint-plugin-disable

* docs(NA): update nav and operations landing page ids for eslint rule

* test(NA): use messageIds on test

* chore(NA): complete naked eslint disables with specific rules

* chore(NA): specific rules for a few naked eslint disable

* chore(NA): add focused eslint disable on big reindex_operation_with_large_error_message.ts file

* chore(NA): changes according PR feedback

* chore(NA): include specific eslint rules on latest naked eslint disable

* chore(NA): missing eslint disable specific rule

* fix(NA): remove comment for js annotator

* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts

* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts

* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-19 17:11:04 +01:00
Julia Rechkunova
92a46f5344
[Discover] Allow for custom number of rows in the results and save the specified number with a Saved Search (#135726)
* [Discover] Persist rowsPerPage in app state and URL

* [Discover] Persist rowsPerPage in saved search objects

* [Discover] Make sure that rowsPerPage is persisted in saved search objects

* [Discover] Support rowsPerPage in embeddables

* [Discover] Allow to save a custom rowsPerPage option

* [Discover] Reflect custom size in the grid dropdown

* [Discover] Fix changing rowsPerPage on Dashboard page

* [Discover] Skip saving rowsPerPage for legacy view

* [Discover] Fix sample size for rendering an embeddable

* [Discover] Update tests

* [Discover] Update tests

* [Discover] Update mapping

* [Discover] Revert setting a default state

* [Discover] Remove rowsPerPage input from SaveSearch modal

* [Discover] Update tests

* [Discover] Ignore the setting for legacy view

* [Discover] Add `discover:sampleRowsPerPage` setting to Advaced Settings

* [Discover] Allow to save rowsPerPage on Dashboard for legacy view too

* [Discover] Add tests

* [Discover] Add tests

* [Discover] Extend "select" type to return values as numbers too

* [Discover] Fix values changes

* [Discover] Update types to support also lists with numbers

* [Discover] Fix disclaimer updates

* [Discover] Update setting copy

* [Discover] Simplify saving of rowsPerPage

* [Discover] Extend number of rowsPerPage options for the legacy view too

* [Discover] Move to utils

* [Discover] Fix deps

* [Discover] Add tests

* [Discover] Update settings copy

* [Discover] Limit max number of rows per page for an embedded legacy table

* [Discover] Prevent invalid values for a custom rows per page

* [Discover] Add tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-19 15:54:17 +02:00
Stratoula Kalafateli
004369dd14
[Lens] Supports include and exclude terms (#136179)
* [Lens] Supports include and exclude terms

* Change type

* Fix pattern logic

* Adds unit tests

* Implement it with 2 extra properties on the expression

* Distinguish the regex and exact match bejhavior

* Enables transferring of include/exclude from TSVB

* Fix tests

* Fix tests

* Update all snapshots

* Update texts

* Revers screenshots

* Use debounce value instead

* Placeholder change

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-07-19 15:30:23 +03:00
Bhavya RM
6832a16cf4
Migrating scroll_count esArchiver to kbnArchiver (#136535) 2022-07-19 06:03:40 -04:00
Nodir Latipov
5c237e10ac
[Unified Search] Change reference to dataView in each filter when switching dataView (#133074)
* feat: add new ui action

* refact: update cofig panel

* feat: add execute UI action

* feat: added test and updated onRemoveLayer logic

* push some logic

* feat: update ref when removing layer

* feat: update test

* rename UPDATE_USED_DATA_VIEWS_TRIGGER/ACTION to UPDATE_FILTER_REFERENCES_TRIGGER/ACTION

* add tests

* refact: config panel

* fix: test

* fix: test

* fix: test

* refact: test

* fix: test

* fix: test

* fix: test

* fix test

* update JEST

* fix functional

* feat: added use datasource method for getting used data view

* refact: renamed comment and removed as IndexPatternPrivateState

* refact: moved change ref logic from filter_manger to UI action
2022-07-18 21:59:04 +05:00
Spencer
4f817ad8a0
[kbn/pm] rewrite to avoid needing a build process (#136207)
* [kbn/pm] rewrite to avoid needing a build process

* uncomment timing reporting

* throw in a few missing comments

* Update README.md

* remove extra SomeDevLog interface from ci-stats-core

* remove non-stdio logging from bazel_runner, improve output formatting

* use private fields instead of just ts private props

* promote args to a positional arg

* optionally require the ci-stats-reporter after each command

* allow opt-ing out of vscode config management

* reduce to a single import

* add bit of docs regarding weird imports and package deps of kbn/pm

* clean extraDirs from Kibana's package.json file too

* tweak logging of run-in-packages to use --quiet and not just CI=true

* remove unlazy-loader

* add readme for @kbn/yarn-lock-validator

* convert @kbn/some-dev-logs docs to mdx

* remove missing navigation id and fix id in dev-cli-runner docs

* fix title of some-dev-logs docs page

* typo
2022-07-18 08:46:13 -07:00
Hannah Mudge
11f7ace59f
[Dashboard] Filter out experimental visualizations when labs setting is disabled (#136332)
* Filter out experimental vis if labs disabled

* Remove duplicated file

* Add functional tests
2022-07-18 08:42:36 -07:00
Bhavya RM
1aa3a12e7f
Migrating test/api_integration/fixtures/es_archiver/management/saved_objects/search to kbnArchiver (#135996) 2022-07-18 10:24:51 -04:00
Alejandro Fernández Haro
d217e2cdfd
Flaky test 133800 (#136518) 2022-07-18 14:54:30 +02:00
Muhammad Ibragimov
20edc9b02a
[Console] Support creating variables (#134215)
* Support creating variables

* Fix checks

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix type checks

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Parse input values

* Add case insensitive flag for parsing input

* Parse request in range

* Minor refactor
* Add functional tests
* Reduce bundle size

* Remove unused vars

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Memoize callbacks

* Minor refactor.

* Add unit tests
* Refactor

* Remove unused imports

* Fix functional tests

* Change modal to flyout

* Address comments

* Improve accessibility and usability

* Fix default request test case

* Fix checks

* Address comments

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-07-18 14:45:17 +05:00
Muhammad Ibragimov
b1f33c468d
[Console] Unskip flaky test (#136195)
* [Console] Unskip flaky test

* Wait until loading finishes

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
2022-07-18 13:15:28 +05:00
Dmitry Tomashevich
2dcdf5e2c3
[Discover] Fix should navigate through rows with the same id test on cloud (#135113)
* [Discover] fix functional test on the cloud

* [Discover] apply suggestions

* [Discover] fix names

* [Discover] fix try

* [Discover] fix test

* [Discover] combine the roles all into one command

* [Discover] fix index names

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-16 16:04:18 +03:00
Tiago Costa
d5a66ac763
skip flaky suite (#133800) 2022-07-15 12:20:31 +01:00
Hannah Mudge
4f13ea8435
[Dashboard] [Controls] Hide controls callout when the hideAnnouncements setting is true (#136410)
* Make controls callout dependent on new UI setting

* Add functional test
2022-07-14 14:09:39 -06:00
Jonathan Budzenski
33b743c84e
Revert "Remove percy based visual regression tests (#136359)" (#136437)
* Revert "Remove percy based visual regression tests (#136359)"

This reverts commit a91aeb42ff.

* update codeowners
2022-07-14 14:53:12 -05:00
Jonathan Budzenski
a91aeb42ff
Remove percy based visual regression tests (#136359)
* Remove percy based visual regression tests

These have been disabled for ~3 years, the agent is deprecated, and our
snapshot environment is inactive.

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* update codeowners

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-07-14 10:03:49 -07:00
Alejandro Fernández Haro
9888244e2c
[EBT] Add Telemetry Labels (#135682)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-14 15:58:57 +02:00
Davis McPhee
21a9b24fed
[Discover] Improve support for pinned filters in surrounding documents (#135722)
* [Discover] Update surrounding documents to support global filters

* [Discover] Finish adding support for global filters in surrounding documents

* [Discover] Fix broken jest tests

* [Discover] Fixed null initial global state in surrounding documents

* [Discover] Fix issue with null filters when query param gets cleared, and add functional tests for changes

* [Discover] Remove filterManager from useEffect dependencies

* [Discover] Fix 'cannot read properties of undefined' toast when navigating between surrounding documents while filters are present

* [Discover] Fix typo in createInitialGlobalState, and clear current app filters when leaving surrounding documents so they don't appear on other screens

* [Discover] Fix issue where Discover breadcrumb link breaks in surrounding documents after filters have been added or modified

* [Discover] Add support for syncing the current pinned filters in surrounding documents to the Discover breadcrumb link

* Revert "[Discover] Add support for syncing the current pinned filters in surrounding documents to the Discover breadcrumb link"

This reverts commit 651a0fcb4b.

* [Discover] Undo change to clear local filters when leaving Surrounding documents
2022-07-14 10:48:47 -03:00
Matthew Kime
9a4eca0a14
[data views] Enforce uniqueness by name instead of index pattern (#136071)
* data view uniqueness by name
2022-07-14 06:01:33 -07:00
Carlos Crespo
b58d07e05b
[Stack Monitoring] Add OpenTelemetry metrics to Monitoring Collection plugin (#135999)
* Add otel metrics to alerting plugin

* clean up otel poc

* Bump @opentelemetry/api-metrics and @opentelemetry/exporter-metrics-otlp-grpc versions to 0.30.0

* Add integration test for prometheus endpoint; improve reademe.md

* Fix tsconfig.base.json missing entries

* Bump @opentelemetry/sdk-metrics-base; clean up

* Rename PrometheusExporter properties

* Readme formatting tweaks

* Fix incorrect path

* Remove grpc dependency

* Add grpc back for handling auth headers

* Fix comment positioning

* Include authenticated OTLP in readme

* Extract dynamic route into a new file

* Enable otlp logging and compatibility with env vars

* Enable OTEL_EXPORTER_OTLP_ENDPOINT env var

Co-authored-by: Mat Schaffer <mat@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-14 13:29:09 +02:00
Tre
fce0739d2a
[Archive Migrations] Migrate discover for visual regression (#136222)
* [Archive Migrations] Migrate discover for visual regression

Add archive.
Make the test use the new archive.

* Drop archive.

* Archive was in the wrong place.

* Cr fixup.
2022-07-14 10:36:35 +01:00
Muhammad Ibragimov
65e307086f
[Console] Handle encoded characters in API requests (#135441)
* [Console] Handle encoded characters in API requests

* Add a functional test for requests with query params

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
2022-07-14 08:53:51 +05:00
Spencer
f074c397c5
[ftr] add support for launching a dedicated task runner Kibana node (#135875)
* [ftr] add support for launching a dedicated task runner Kibana node

* Update run_kibana_server.ts

* disable the optimizer in kbn-tasks proc when running locally

* remove paths module

* include decicated task proc in promises array

* add getSupertest() helper to DedicatesTaskRunner service

* avoid caching a supertest instance, just create one on request

* remove surprise dependents on KIBANA_ROOT const

* remove modifications to test/analytics/config.ts
2022-07-13 16:36:39 -05:00
Liza Katz
142661cffb
[EBT] Dashboard data loaded event (#134243)
* timing dashboard data loading

* reporting loading \ error from all embeddables

* report event

* lint

* comment out console

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Update embeddable_child_panel.tsx

* Make analytics optional

* Telemetry report to include both time to load data and time to render

* Measure load time from beginning of mount

* lint

* fix onDataLoadEnd and onDataLoadError event handler callbacks only called for source data requests

* dataLoadEnd

* code review

* imports

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* comment

* Fix dedupe of events!

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Rendered discover
Fix refresh not firing event

* oops

* Code review + DashboardLoadedEvent

* reportsEmbeddableLoad

* type

* isNil

* fix sync unsubscribe

* use store state instead of eventHandlers

* [EBT] Better FTR helper APIs

* dashboard loaded telemetry test

* timestamp

* tests

* tests

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* test

* docs + longer timeout

* fix

* Fix property inheritance and map events

* type error

* reportsEmbeddableLoad

* tests

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: nreese <reese.nathan@elastic.co>
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2022-07-12 15:17:17 +03:00
Alejandro Fernández Haro
6a043110cd
[Flaky tests] Click a more explicit button (#136091) 2022-07-11 19:02:44 +02:00
Tiago Costa
52c9de890a
skip flaky suite (#135914) 2022-07-08 18:18:32 +01:00
Andrew Tate
3891aeb95f
[Chart expressions] new metric vis expression (#135461) 2022-07-08 12:07:43 -05:00
Spencer
f5688a68a5
[ftr] rework kibana arg parsing, extend loggers correctly (#135944) 2022-07-08 08:54:56 -05:00
Spencer
1134d35e03
[jest] refactor config check (#135960) 2022-07-08 08:54:38 -05:00
Hannah Mudge
17516e77ec
[Dashboard] [Controls] Use KibanaThemeProvider (#135662)
* Add theme provider control group container

* Add theme to flyouts

* Add theme to control components

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Mock light theme for storybook

* Rename PresentationUtilProvider to ControlsServicesProvider

* Use getHooks for React components

* Fix wrappers

* Fix stub ControlsServices provider

* Remove unused file

* Add screenshot tests for controls

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-07-07 10:39:23 -07:00
Rudolf Meijering
54f0579f79
Remove application_usage_transactional SO type (#135832)
* Remove application_usage_transactional so type

* Fix tests
2022-07-07 13:32:26 +02:00
Julia Rechkunova
b46763fc2a
[Alerting] Improve creation and editing of "Elasticsearch query" rule in Management (#134763)
* [Alerting][Discover] Add query form type selection for ES query

* [Alerting] Add labels

* [Alerting] Unify common rule expressiosn

* [Alerting] Fix code style

* [Alerting] More refactoring

* [Alerting] Show different UI based on user choice

* [Alerting] Improve validation and reset rule params when view changes

* Resolve conflicts

* [Alerting] Fix button color

* [Alerting] Revert tmp changes

* [Alerting] Fix query input

* [Alerting] Fix thresholdComparator and timeWindowUnit changes

* [Alerting] Unify UI for different query form types

* [Alerting] Clean up translations

* [Alerting] Fix for tests

* [Alerting] Update help tooltips

* [Alerting] Preselect a default data view

* [Alerting] Add validation tests

* [Alerting] Add more tests

* [Alerting] Add the smaller title

* [Alerting] Fix localization bug

* [Alerting] Fix rules editing view

* [Alerting] Fix layout for mobile

* [Alerting] Address PR comments

* [Discover] unify searchType and formType

* [Alerting] Allow to create new data views from Data View Expression

* [Alerting] Fix lint issue

* [Discover] fix management and discover views

* [Discover] remove redundant prop

* [Alerting] Add validation message when query type is not selected yet

* [Alerting] Update validations

* [Alerting] Update tests

* [Alerting] Update tests

* [Alerting] Update tests

* [Alerting] Prioritize index errors

* [Alerting] Fix size validation

* [Alerting] Fix timeWindowSize validation

* [Alerting] Address CI issues

* Address plugins concurrency effect on sample data server API

* [Alerting] Remove deprecated strings

* [Alerting] Update copy and spacing

* [Alerting] Cleanup translations

* [Alerting] Unify labels key

* [Alerting] Update copy

* [Alerting] Update copy key

* [Alerting] Bring back the original label

* [Alerting] Update after the merge

* [Alerting] Update validation message

* [Alerting] Update styles for Create a data view button

* [Alerting] Add message about missing privilieges

* [Alerting] Reduce padding in data view selector

* [Alerting] Update copy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dzmitry Tamashevich <diaamnj@mail.ru>
2022-07-07 11:19:06 +02:00
Muhammad Ibragimov
b809237f84
[Console] Save state of folding/unfolding of commands (#134810)
* Persist fold states and restore it back from storage

* Add tests

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-07 13:49:38 +05:00
John Dorlus
380a8b8705
Switched _handle_alias and _scripted_fields to use UI settings to change date and time instead of time picker. (#135866)
* Switched _handle_alias and _scripted_fields to use UI settings to change time.

* Removed commented code.
2022-07-06 21:52:47 -04:00
Davis McPhee
9c8468eae2
[Discover] Fix flaky accessibility functional tests (#135596)
* Unskip fixed flaky top nav menu alerts button functional test
* Fix flaky functional test for top nav alerts button
* Fix flaky doc accessibility test
2022-07-06 14:51:42 -03:00
Tre
aca93c6d4b
[Archive Migration] Drop test/api_integration/fixtures/es_archiver/search/count (#135649) 2022-07-05 16:01:24 +01:00
Tiago Costa
98e2acdc6d
skip flaky suite (#135305) 2022-07-04 15:02:08 +01:00
Alejandro Fernández Haro
dd43c2d129
[EBT] Validate event&context payloads in dev-mode (#135061)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-07-04 15:42:08 +02:00
Mat Schaffer
35fab1c4a5
Remove/replace uses of "sanity" in comments and test code (#134541) 2022-06-30 19:21:23 -07:00
Bhavya RM
f1d8a370bc
Fixing the flakiness in openInspectorView method in inspector service (#135488) 2022-06-30 19:43:59 -04:00
Jonathan Budzenski
7fd3beee4e
[artifacts] Stabilize package testing (#134854)
* bump ansible logging verbosity

* upgrade base os

* update base images

* add specificity to docker image glob

* limit memory

* bump base vm memory

* more cpu

* decrease verbosity

* less downloads

* disable shared symlinks

* more logging

* bump concurrency to test stability

* add concurrency group

* revert

* parallelism

* Revert "parallelism"

This reverts commit 4cc00f7144.
2022-06-30 16:00:15 -05:00
Rashmi Kulkarni
f43fef1bd3
timepicker_migration for date_nanos_mixed (#135483)
* timepicker_migration

* date_picker_migration

* Revert "date_picker_migration"

This reverts commit 2e0c90b7f4.
2022-06-30 06:05:46 +02:00
Rashmi Kulkarni
d5c591d0f4
refactor uisettings instead of timepicker ui - input_control_options (#135364)
* timepicker change

* timepicker change incorporating review changes
2022-06-29 10:59:32 -07:00
Alejandro Fernández Haro
a2b0927e65
[EBT] Better FTR helper APIs (#135298) 2022-06-29 14:11:13 +02:00
Luke Elmers
cf6ae210ef
Adds node.roles configuration & exposes via PluginInitializerContext (#135272) 2022-06-28 15:22:43 -07:00
Kibana Machine
a530305204 skip failing test suite (#135110) 2022-06-28 10:00:20 -04:00
Davis McPhee
7fd4e6af0e
[Discover] Improve alerts popover accessibility and semantics (#135270) 2022-06-28 10:59:57 -03:00
Pierre Gayvallet
be5f56effd
Fix flaky sample dataset uninstall FTR test (#121733) 2022-06-28 15:29:43 +02:00