Lisa Cawley
1528c6a6f9
[DOCS] Notify assignees when assigned to a case ( #147713 )
2023-01-04 12:50:54 -05:00
Jonathan Buttner
9cbe45c42a
[Cases][Security] Updating audit log ( #147260 )
...
This PR updates the audit logger docs to reflect the cases audit log
messages. We had not added the RBAC authorization messages so I added
those as well as the user action messages from this PR:
https://github.com/elastic/kibana/pull/145632
I also noticed a discrepancy in the `event.type` for the RBAC message
for a case being pushed and the user action one recently. So changed the
user action to match the RBAC `event.type: change`.
The audit log messages come from these files:
- User actions
-
https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/services/user_actions/audit_logger.ts
-
https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/services/user_actions/builders/ *
-
https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/services/user_actions/index.ts
- RBAC
-
https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/authorization/audit_logger.ts
-
https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/authorization/index.ts
2023-01-04 12:47:24 -05:00
Dominique Clarke
0400481b01
synthetics - adjust e2e selectors to reduce flakiness ( #148359 )
...
## Summary
Adjusts synthetics e2e selectors to reduce flakiness.
2023-01-04 12:43:26 -05:00
Janki Salvi
0409e0325b
[Cases] Comments with long unbroken text layout fixed ( #148396 )
...
## Summary
Fixes #147942
**Before:**
**After:**
### Checklist
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
2023-01-04 18:21:45 +01:00
Adam Demjen
cce2547567
Fix typo in "Behavioral Analytics" page title ( #148402 )
...
Fixing typo in "Behavioral Analytics" in the page title.
2023-01-04 10:09:15 -07:00
Nathan Reese
12076cc6ff
[controls] fix pin start text ( #148394 )
...
While working on review feedback for
https://github.com/elastic/kibana/pull/148028 and moving i18n strings to
a separate file, copy paste errors were introduced. This PR fixes the
pinning text to return expected value
2023-01-04 11:28:40 -05:00
Devon Thomson
bce62ce4d9
[Dashboard] Unskip Create and Add Embeddables test ( #148355 )
...
Unskip create and add embeddables test
2023-01-04 11:28:18 -05:00
Tiago Costa
c5ad5aa951
skip flaky suite ( #148391 )
2023-01-04 16:07:18 +00:00
Tiago Costa
d43ef71191
skip flaky suite ( #148390 )
2023-01-04 16:06:44 +00:00
Patryk Kopyciński
c0d2a032f9
[Defend Workflows] Init Cypress ( #147822 )
...
## Summary
Add initial Cypress pipeline for Defend Workflows Team
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
2023-01-04 17:05:13 +01:00
Tiago Costa
c3c168e93c
skip flaky suite ( #148389 )
2023-01-04 16:04:55 +00:00
Tiago Costa
0378fab8f7
skip flaky suite ( #148387 )
2023-01-04 16:03:13 +00:00
Tiago Costa
53e406c403
skip flaky suite ( #148385 )
2023-01-04 16:02:01 +00:00
Tiago Costa
b5bae66abd
skip flaky suite ( #148367 )
2023-01-04 16:00:50 +00:00
Tiago Costa
bd0b50fb6a
skip flaky suite ( #147958 )
2023-01-04 15:59:12 +00:00
Dima Arnautov
bc19656c3c
[Console] Improve check for response size in /autocomplete_entities endpoint ( #148328 )
2023-01-04 10:48:31 -05:00
Anton Dosov
72268e1b0e
[Docs][Image Embeddable] Add user-facing docs for image panel ( #148054 )
...
## Summary
Adding user-facing docs about new image panel -
https://github.com/elastic/kibana/issues/81345
Adding an inline sub-section of the main dashboard doc page similar to
text panel -
https://www.elastic.co/guide/en/kibana/master/dashboard.html#add-text
2023-01-04 16:01:49 +01:00
nastasha-solomon
a89f5cd0b4
[DOCS] Refreshed URL to value list docs ( #146634 )
...
Refreshes the URL to the value list docs so that it matches changes made
in https://github.com/elastic/security-docs/pull/2748 .
Related to https://github.com/elastic/kibana/pull/146602 .
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 09:54:39 -05:00
Kibana Machine
58a9f21fc0
skip failing test suite ( #148386 )
2023-01-04 09:53:47 -05:00
Søren Louv-Jansen
f44316813c
[APM] Use p-retry instead of custom retry logic ( #148293 )
...
Follow-up to https://github.com/elastic/kibana/pull/144484
2023-01-04 07:53:08 -07:00
Kibana Machine
2c36d0d0c2
skip failing test suite ( #148388 )
2023-01-04 09:52:24 -05:00
Nodir Latipov
82057d516f
[Unified search] Sort the dataviews on the picker ( #147328 )
...
Close #137247
## Describe the feature:
This PR adds the ability to sort DataViews in the picker's DataView
list.
## What was done:
1. added sorting before displaying the date view list
2. added popover to show sort selection menu
<img width="342" alt="image"
src="https://user-images.githubusercontent.com/34135714/210533817-1ce745b3-a08b-4e18-9134-bdf1ac12b0f9.png ">
3. tests have been fixed, since now the DataView picker list is
initially shown in sorted form
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
2023-01-04 07:49:39 -07:00
Walter Rafelsberger
41f184d267
[ML] Migrate SCSS use of euiBreakpoint to emotion. ( #148284 )
...
Migrates the use of SCSS use of `euiBreakpoint` to emotion for AIOps
pages and the Data Visualizer's Search Panel component.
2023-01-04 15:45:59 +01:00
Trevor Pierce
9a0a72cc59
Upgrade EUI to v72.1.0. ( #148354 )
...
## Summary
`eui@72.0.0` ⏩ `eui@72.1.0`
---
## [`72.1.0`](https://github.com/elastic/eui/tree/v72.1.0 )
- Changed design of empty ranges in `EuiColorStops` to have diagonal
gray stripes instead of a solid light gray color
([#6489 ](https://github.com/elastic/eui/pull/6489 ))
- Changed popover in `EuiColorStops` to not appear when dragging/moving
a color stop ([#6489 ](https://github.com/elastic/eui/pull/6489 ))
- `EuiPopover` now supports overriding `focusTrapProps.onClickOutside`,
which allows customization of auto-close behavior on outside click.
([#6500 ](https://github.com/elastic/eui/pull/6500 ))
**CSS-in-JS conversions**
- Converted `EuiColorStops` to Emotion
([#6489 ](https://github.com/elastic/eui/pull/6489 ))
- Added `brighten` service to manipulate CSS-in-JS colors
([#6489 ](https://github.com/elastic/eui/pull/6489 ))
2023-01-04 08:30:29 -06:00
Rodney Norris
b991c59d6d
[EnterpriseSearch] engines list proxy endpoint ( #148352 )
...
## Summary
Added a proxy endpoint to list engines from enterprise search.
2023-01-04 08:22:54 -06:00
Kurt
8c7a4260d5
Fix flaky Api Key Update test ( #148155 )
...
## Summary
Wait for the 'Update Api Key' button to be enabled before we make any
assertions since it will be disabled if the flyout is still loading.
## Flaky Test Runner
~~[x50](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1676 )
✅ ~~ (prev. commit)
~~[x50](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1677 )
✅ ~~ (prev. commit)
New
[x50](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1685 )✅
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
2023-01-04 08:44:33 -05:00
Walter Rafelsberger
005517cc2a
[ML] Anomaly Detection: Fix Anomaly Explorer context handling. ( #148231 )
...
The use of `useMemo()` to instantiate `AnomalyTimelineService` didn't
consider React hooks lifecycles. Because `AnomalyTimelineService` does
trigger an observable upon instantiation this could cause unintended
side effects.
This PR changes it to instantiate it within a `useEffect()` instead.
`useAnomalyExplorerContextValue()` has been refactored into an
`AnomalyExplorerContextProvider` component to take care of the
initialisation and handle rendering state until the context value is
set.
2023-01-04 14:43:11 +01:00
Kevin Lacabane
11f6f1b6ef
[Stack Monitoring] Clarify api tests validation ( #148374 )
...
## Summary
Clarified validation of new packages in API tests
2023-01-04 14:34:44 +01:00
Janki Salvi
9226aaab15
[Cases] added unsaved draft message and conflict warning message ( #148073 )
...
## Summary
UX improvements #147994
**Unsaved draft comment message:**
**Version conflict message:**
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
**Flakey Tests passed for `Cases` plugin, but some failed for `Discover`
plugin:**
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 14:33:09 +01:00
Nathan Reese
e66604c674
[controls] anchor time slider to start ( #148028 )
...
Fixes https://github.com/elastic/kibana/issues/136095
<img width="894" alt="Screen Shot 2023-01-03 at 3 19 25 PM"
src="https://user-images.githubusercontent.com/373691/210434955-8e473eee-60e4-4394-9d65-18ea0ddffe91.png ">
<img width="868" alt="Screen Shot 2023-01-03 at 3 19 30 PM"
src="https://user-images.githubusercontent.com/373691/210434958-b8089e5b-bbeb-4530-b396-23dd81b02b44.png ">
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 08:25:51 -05:00
Katerina Patticha
a5351fa20a
[APM] Fix mobile filters to filter out the charts ( #148020 )
...
## Summary
closes https://github.com/elastic/kibana/issues/146870
1. Added the mobile filters at top transactions page
2. Pass mobile filters in kuery to filter all charts in mobile
3. extend `useFallbackToTransactionsFetcher` to check for mobile filter
in order to display the correct badge
4. Refactor LatencyMap to accept kuery for consistency
https://user-images.githubusercontent.com/3369346/209363176-9dbd8977-f922-4729-a086-a1f6161fadf2.mov
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 14:20:50 +01:00
Dario Gieselaar
c3d5b0279d
[APM] Refactor synthtrace ( #147036 )
...
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 13:47:37 +01:00
Dmitry Tomashevich
503b466b72
[Discover][Alerting] Use Discover locator for alert results link ( #146403 )
...
## Summary
Closes #145815 , #134232
- Moves Discover locator to common area
- Builds alerts results link from the server
- Now there are two implementations of `setStateToKbnUrl` which is used
in locator. New one in common are lost `HashedItemStore` support, since
sessions storage are actual only for browser
- Toasts `Alert rule has changed`, `Data View has changed` removed
- link generated per each alert will be unique representation of those
`rule params` and `data view state` which were at the time of invocation
- Restuls link will live even after data view and rule removal
### How to create rule
- Create an output index and data view `test`
<details>
<summary>Query to use</summary>
```
PUT test
{
"settings" : {
"number_of_shards" : 1
},
"mappings" : {
"properties" : {
"rule_id" : { "type" : "text" },
"rule_name" : { "type" : "text" },
"alert_id" : { "type" : "text" },
"context_message": { "type" : "text" }
}
}
}
```
</details>
- Create alerts connector using `test` index
- Open `Elasticsearch query` alert in `KQL or Lucene` mode or just using
Discover `Alerts` button
- Specify the following params: `IS ABOVE: 1`, `FOR THE LAST: 30 min`
- Try execute it by clicking `Test query`. It should match some results
- When choosing connector, use the following config
```
{
"rule_id": "{{rule.id}}",
"rule_name": "{{rule.name}}",
"alert_id": "{{alert.id}}",
"context_message": "{{context.message}}"
}
```
- Create the alert
### How to test
- Create `Elasticsearch query` rule in `KQL or Lucene` mode like
described above
- Wait for some seconds and find the triggered alert document by
browsing `test` data view in Discover. There should be a link to results
in `context_message` field. Save the link somewhere
- Change rule params by adding/removing filters / changing query /
changing data view
- Follow saved link, you should see previous filters, query and data
view state
- Open rule in management and click `View in app`, you should see actual
state of rule
- Try to remove used data view and then follow saved link, you should
still see the results
- Try to remove rule and then follow saved link, you should still see
the results.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2023-01-04 15:46:14 +03:00
Lisa Cawley
4e11ef1b6b
[ResponseOps] Automate screenshots for new rule statuses ( #147492 )
...
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
2023-01-04 07:21:00 -05:00
Matthew Kime
6b1dca2b10
simplify discover grid dependencies ( #148269 )
...
## Summary
The discover grid currently depends upon `useDiscoverServices` but it
only needs a small subset of the services it provides. I think the
discover grid code is simple enough that we can simply pass dependencies
instead of using a service context.
An incremental step in breaking DiscoverGrid out into its own package.
2023-01-04 05:32:02 -06:00
Mark Hopkin
01f74deada
[Fleet] Add deprecation warning to unenrollment timeout agent policy setting ( #147963 )
...
## Summary
Part of https://github.com/elastic/kibana/issues/143455
Now that we have moved to inactivity timeout, we need to inform users
that unenrollment timeout will only be used by fleet servers below 8.7.0
I have also moved the setting to be the last in the settings list.
<img width="1175" alt="Screenshot 2022-12-22 at 13 26 32"
src="https://user-images.githubusercontent.com/3315046/209144249-7167bcc0-169d-4c78-813f-93a069576636.png ">
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 04:09:22 -07:00
Dmitry Tomashevich
9186244167
[Discover] Remove allow js setting ( #148286 )
...
## Summary
Closes #144283
This PR removes `allowJS` setting.
2023-01-04 13:45:46 +03:00
Nicolas Chaulet
c1681d2590
[Fleet] Honor index mode time_serie from the package ( #148292 )
2023-01-04 06:38:29 -04:00
Walter Rafelsberger
b4f7aae411
[ML] Anomaly Detection: Fix button switch issue with unmounted component. ( #148239 )
...
The `AnomalyResultsViewSelector` component occasionally triggered a
React error `Warning: Can't perform a React state update on an unmounted
component. This is a no-op, but it indicates a memory leak in your
application. To fix, cancel all subscriptions and asynchronous tasks in
a useEffect cleanup function.`. This PR adds a check to only call
`navigateToPath` if the component is still mounted.
2023-01-04 10:47:34 +01:00
Yaroslav Kuznietsov
0fd11a0aa4
[Unified search] Filter builder close popup. ( #147777 )
...
## Summary
Closes https://github.com/elastic/kibana/issues/90199
Added the confirmation modal on closing the filter editor because it is
removing all the progress of filling the filters.
### Empty filter:
https://user-images.githubusercontent.com/22456368/208869567-789f47ee-dc04-46bd-ac98-12e6682df0f0.mov
### Add filter:
https://user-images.githubusercontent.com/22456368/210507444-e9b430b3-8df0-4f69-b68a-73a5b0e9275a.mov
### Edit filter:
https://user-images.githubusercontent.com/22456368/210507630-0de6ccde-15ee-4569-b5a6-403e7da886aa.mov
### Open edit filter popup, but don't modify:
https://user-images.githubusercontent.com/22456368/208869816-f5eee85b-996b-4ce5-972e-84c4cc0aa03a.mov
### Open Query DSL editor:
https://user-images.githubusercontent.com/22456368/209352743-7633a560-cc2c-44bd-8196-b64768298a4c.mov
### Open Query DSL editor, modify filter:
https://user-images.githubusercontent.com/22456368/210507833-587d5b5a-d88c-4538-938c-4a273266ca26.mov
Co-authored-by: Lukas Olson <lukas@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nodir Latipov <nodir.latypov@gmail.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
2023-01-04 02:40:07 -07:00
ofiriro3
f2e3c5d480
Remove state from csp rule template ( #147973 )
...
[Cloud-Security-Posture] - Deprecating state from the csp_rule_templates
2023-01-04 11:29:22 +02:00
Stratoula Kalafateli
ff3a599f1c
[Lens] Fixes the scrollbar on small multiples metric ( #148276 )
...
## Summary
For some reason (possibly an EUI update) the scrollbar in Lens metric
(when small multiples is on) didn't look as the rest kibana scrollbars.
This PR fixes it by importing the EUI scrollbar styling
Before
<img width="844" alt="image (2)"
src="https://user-images.githubusercontent.com/17003240/210335795-125709a0-cc6f-45b8-98f2-2a0945860d2a.png ">
After
<img width="1097" alt="image"
src="https://user-images.githubusercontent.com/17003240/210335833-03010aaa-5a41-447d-b6c2-601197f71d80.png ">
2023-01-04 10:27:29 +02:00
Julia Rechkunova
cae0c031c2
[Discover] Unskip a11y flaky test ( #148300 )
...
Closes https://github.com/elastic/kibana/issues/147186
100x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1686
2023-01-04 09:01:34 +01:00
Shahzad
af7dd7fc56
[Synthetics] Custom reporter for e2e testing ( #148251 )
2023-01-04 08:25:44 +01:00
Shahzad
9509c35abd
[Synthetics] Remove usage of @emotion ( #148275 )
2023-01-04 08:24:56 +01:00
Marco Antonio Ghiani
296025b1e7
[Stack Monitoring] Filter CCR list by currently viewed cluster ( #148018 )
...
## 📓 Summary
Closes #147224
The issue was caused by the missing usage of the `clusterUuid` parameter
in the query used to retrieve the cluster followers and stats.
Adding a `term` condition for the cluster_uuid now retrieves only the
followers related to the interested cluster. In case a cluster has no
followers, an empty list will be returned by the endpoint.
This PR also adds stronger typing against the data returned by the
endpoint and adds some minor improvements.
## 🧪 Testing
Testing locally this PR requires some effort since is necessary to
create a multi-cluster locally.
Following [this
guide](https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/dev_docs/how_to/running_components_from_source.md#multi-cluster-tests-for-ccrccs-or-listing )
is possible to locally setup the 2 cluster and make one of them follow
the other.
Also, the new issue
[oblt#3279](https://github.com/elastic/observability-test-environments/issues/3279 )
has been opened to have an easier way to access a multi-cluster setup
with oblt clusters.
### Before bugfix
https://user-images.githubusercontent.com/34506779/209954682-b519fcd3-888b-472a-8a1d-acf57ff5de05.mov
### After bugfix
https://user-images.githubusercontent.com/34506779/209954718-5045c49e-f113-42e5-aabf-81d2c5f53556.mov
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-04 08:16:28 +01:00
Kibana Machine
faa020b89b
[api-docs] 2023-01-04 Daily api_docs build ( #148362 )
...
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/207
2023-01-04 00:49:54 -05:00
Hannah Mudge
37a6636654
[Dashboard] [Controls] Show document count beside options list suggestions ( #146241 )
...
Closes https://github.com/elastic/kibana/issues/145039
## Summary
This PR adds a badge beside each options list suggestion that displays
how many document that value appears in.
https://user-images.githubusercontent.com/8698078/209020139-e0f16eae-6643-432b-9c40-f1a52fc7adf4.mov
Note that, in the above video, clicking `"Show only selected"` removes
the badge regardless of the validity of the selection. As described in
https://github.com/elastic/kibana/pull/144867#issuecomment-1320522731
and the related discussion, it is theoretically possible to still show
this badge, thus allowing sorting even when `"Show only selected"` is
`on`. However, my investigation into this took me on the following
journey:
1. Document count **should not** be stored as part of the
`explicitInput`, so `selections` should remain a string array
2. To get around this, the document count could be stored as part of the
`validSelections` instead, which is part of the component state. That
is, `validSelections` would be an `OptionsListSuggestions` object rather
than a string array
3. To make (2) happen, we would need to add a secondary API endpoint
specifically for translating the `explicitInput` selections array to the
`validSelections` object
After realizing (3), it became obvious that adding sorting support to
`"Show only selected"` was probably not worth the code complexity that
is required - so, at least until we get requests for this feature, I
opted to not include it as part of this PR. After all, `"Show only
selected"` is ultimately meant to make it easier to deselect/manage your
selections, so showing the document count + allowing sorting in this
case doesn't have much of an impact. For the same reasons, searching is
also disabled when `"Show only selected"` is `on`:
<p align="center"><img
src="https://user-images.githubusercontent.com/8698078/209021944-c57ea04f-1278-4b6d-ae65-88b2591ba9d6.gif "/></p>
> **Note**
> The above screenshots and videos are slightly out-of-date. Refer to
https://github.com/elastic/kibana/pull/146241#issuecomment-1370125632 to
see how the design of the document count was changed to reduce visual
clutter.
### Flaky Test Runner
- `control_group_chaining.ts`
<a
href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1669 "><img
src="https://user-images.githubusercontent.com/8698078/209016909-cb2cebf4-b069-4270-977b-a64a320d398d.png "/></a>
- `options_list.ts`
<a
href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1670 "><img
src="https://user-images.githubusercontent.com/8698078/209020916-f322bfdb-799d-4aab-9726-9f46e130e779.png "/></a>
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-03 16:05:21 -07:00
Nathan Reese
36a3d6915c
[controls] Edit and save example ( #147897 )
...
Part of https://github.com/elastic/kibana/issues/145428
PR does the following:
* Removes ControlsCallout
* Cleans up ControlGroupContainer API to avoid leaking Dashboard
implementation details
* Removes getCreateControlButton method
* Removes getCreateTimeSliderControlButton
* Removes getToolbarButtons
* Adds openAddDataControlFlyout
* Add Edit and save example
<img width="600" alt="Screen Shot 2022-12-21 at 9 29 21 AM"
src="https://user-images.githubusercontent.com/373691/208928858-94984880-3fdb-45f4-bb2a-a086bfc440d0.png ">
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-03 16:47:42 -05:00
Mike Côté
750e5e0e95
Use docLinks plugin to generate server side URL ( #147940 )
...
Resolves: https://github.com/elastic/kibana/issues/109937
In this PR, I'm fixing the `Task Manager detected a degradation in
performance` log message to provide the proper versioned link to the
task manager health monitoring docs. Prior to this PR, it would always
point to main / master docs.
## To verify
1. Turn on debug logging in your kibana.yml file
```
logging:
loggers:
- name: plugins.taskManager
level: debug
```
2. Move this code line outside of the `if (logLevel..` statement =>
4c7ce9d249/x-pack/plugins/task_manager/server/lib/log_health_metrics.ts (L99)
2023-01-03 12:38:27 -08:00
