Commit graph

48706 commits

Author SHA1 Message Date
Kibana Machine
43bf13d2ab
fix setup error during test (#120917) (#121029)
Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
2021-12-10 02:16:00 -07:00
Kibana Machine
23d22569de
[Security Solutions] Fixes telemetry to work with rule types (#120809) (#121028)
## Summary

What this does:
* Fixes telemetry to work with the newer rule types
* Updates the queries to the new rule types and rule query names
* Uses constants where I can from cases and the new rule types
* Changes the index to the new index type alias
* Adds e2e backend tests we didn't have before

What this does not do:
* Doesn't add e2e backend tests for alerts added to cases
* Doesn't add e2e backend tests for ML jobs for security_solution

Those two test scenarios have to be manually tested still.

Manual testing:
To see telemetry go to advanced settings -> Usage Data (and click cluster data):
<img width="2193" alt="Screen Shot 2021-12-08 at 4 14 43 PM" src="https://user-images.githubusercontent.com/1151048/145310671-b7350892-d290-4f3d-ab8c-4e9ec86f4120.png">

Create alerts of different types and add them to cases:
<img width="1464" alt="Screen Shot 2021-12-08 at 4 48 21 PM" src="https://user-images.githubusercontent.com/1151048/145310800-2fae6373-5e84-46ec-9e44-f7a140ea9c36.png">

Activate ML_jobs and any alerts that have ML jobs associated:
<img width="754" alt="Screen Shot 2021-12-08 at 5 08 42 PM" src="https://user-images.githubusercontent.com/1151048/145310978-861f4bb7-2575-4a07-a55f-1e4fdfe288e7.png">

When clicking advanced settings -> Usage Data -> Click cluster data

Search for `security_solution` and then ensure that the data looks as expected underneath the different values such as:

`ml_jobs`
<img width="750" alt="Screen Shot 2021-12-08 at 3 08 25 PM" src="https://user-images.githubusercontent.com/1151048/145311124-c3523d4e-b31b-4bab-b14e-267155bf2b92.png">

`detection_rules` and `cases` working again:
<img width="420" alt="Screen Shot 2021-12-08 at 4 43 10 PM" src="https://user-images.githubusercontent.com/1151048/145311192-e062c435-e8c3-4919-b4e9-8a786dc588c6.png">

Note, `detection_rule_detail` will only be filled in if have prepackaged rules installed:
<img width="761" alt="Screen Shot 2021-12-08 at 5 14 50 PM" src="https://user-images.githubusercontent.com/1151048/145311446-1d78541f-1211-4389-b947-7c0939d7c946.png">

Also note that the `detection_rule_detail`'s `rule_id` is its UUID and not its `rule_id`. That's the way it's been in the codebase for a while it looks like so I have not changed that behavior.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-12-09 22:04:22 -07:00
Kibana Machine
4cf5d9de37
Fixes alerts and cases to work with telemetry (#121002) (#121023)
## Summary

One line fix to where we have to expose cases to the saved object client as hidden to work with telemetry. This one liner was broken out from:
https://github.com/elastic/kibana/pull/120809

So we could back-port easier to earlier versions.

Manual testing:
To see telemetry go to advanced settings -> Usage Data (and click cluster data):
<img width="2193" alt="Screen Shot 2021-12-08 at 4 14 43 PM" src="https://user-images.githubusercontent.com/1151048/145477392-8cab122c-cf7a-41c6-bac4-0aa389e9f914.png">


And you will see it like so:
<img width="420" alt="Screen Shot 2021-12-08 at 4 43 10 PM" src="https://user-images.githubusercontent.com/1151048/145477286-5dcdc3ef-1fde-4407-aaa8-2b7b5bece74d.png">

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-12-09 17:39:25 -07:00
Kibana Machine
a739f060ba
[build/docker] Use /tmp to store kibana archive (#120991) (#121018)
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2021-12-09 16:27:23 -07:00
Kibana Machine
19e30dd54e
Support system indices being hidden (#120985) (#121007)
Co-authored-by: Josh Dover <doverfake@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Josh Dover <doverfake@elastic.co>
2021-12-09 15:43:15 -07:00
Kibana Machine
78e74925a6
correct linear regression formula (#120222) (#120654)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: dcolazin <51136913+dcolazin@users.noreply.github.com>
2021-12-09 14:56:04 -07:00
gchaps
4b4b06fe9c
[DOCS] Reformats the telemetry settings tables into defintion lists (#120855) (#121011) 2021-12-09 16:53:21 -05:00
Kibana Machine
7005144be1
[APM] disable fleet depreaction warning (#120988) (#120997)
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-12-09 14:31:09 -07:00
Kibana Machine
0ccfc81707
[Fleet] Add CA fingerprint field to the output form (#120980) (#120994)
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2021-12-09 14:21:07 -07:00
gchaps
0c150ea4db
[DOCS] Reformats Task Manager settings tables into definition lists (#120858) (#121001) 2021-12-09 16:08:29 -05:00
Kibana Machine
a3c9f61bc4
Improve github apps frontend validation (#120983) (#120992)
by disabling the submit button if private key has not been uploaded

Note: the validation will not work if a user removes the file
from the file picker after uploading it, as file picker doesn't call the
onChange callback on that action.

Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
2021-12-09 13:44:25 -07:00
Nicolas Chaulet
ca44293157
[Fleet] Configure ca trusted fingerprint for on prem users (#120549) (#120984) 2021-12-09 12:52:49 -07:00
Kibana Machine
7f57c249ce
[build] Include x-pack example plugins when using example-plugins flag (#120697) (#120978)
* [build] Include x-pack example plugins when using example-plugins flag

* revert test

Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2021-12-09 11:55:57 -07:00
Devon Thomson
9f60d443e2
remove firefox tag from dashboard_filtering test suite. Will research why running with firefox causes failures (#120673) (#120976) 2021-12-09 11:43:12 -07:00
Michael Dokolin
cc6571331b
[Reporting] fix unsupported platform crash (#120659) (#120974)
* [Reporting] fix unsupported platform crash

* revert test code

* improve types and add test

* Apply suggestions from code review

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* updates per feedback - remove the error class member

* add stack trace of error

* revert change to guard a type

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
2021-12-09 11:21:13 -07:00
Nicolas Chaulet
49ea9199f9
[Fleet] Configure fleet default output on prem with ES host and CA fingerprint (#120276) (#120973) 2021-12-09 11:20:03 -07:00
Michael Dokolin
688001bb95
[Data] Fix public API exports (#120793) (#120971)
# Conflicts:
#	src/plugins/data/common/search/search_source/types.ts
2021-12-09 11:19:29 -07:00
Kibana Machine
bc5533b022
[APM] agent keys management improvements (#120765) (#120943)
* Add userCurrentUser hook

* Use EuiFieldText instead of input element

* Display error messages in the UI when creating agent keys

* Remove default agent key name

* Prefix createAgentKeyRoute with /api

* Fix issue where you cannot invalidate API keys when you only have manage_own_api_key privilege

Co-authored-by: Casper Hübertz <casper@formgeist.com>

Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
Co-authored-by: Casper Hübertz <casper@formgeist.com>
2021-12-09 10:44:29 -07:00
Kibana Machine
8da7e923bd
[DOCS] Add kibana-verification-tool and CLI main page (#120836) (#120970)
* [DOCS] Add kibana-verification-tool and CLI main page

* Change wording from generating to retrieving

Co-authored-by: Adam Locke <adam.locke@elastic.co>
2021-12-09 12:12:47 -05:00
Michael Dokolin
1ec14ab03e
[Reporting] Decouple screenshotting plugin from the reporting (#120110) (#120937)
* Add screenshotting plugin
* Move screenshotting plugin configuration options
* Remove unused browser type configuration option
# Conflicts:
#	packages/kbn-optimizer/limits.yml
#	x-pack/plugins/reporting/server/export_types/common/generate_png.ts
#	x-pack/plugins/reporting/server/export_types/png/execute_job/index.ts
#	x-pack/plugins/reporting/server/export_types/png_v2/execute_job.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/tracker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/tracker.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable_handler.ts
2021-12-09 09:49:57 -07:00
Kibana Machine
26e8b37973
[App Search, Crawler] Show validation errors in domain form (#120759) (#120925)
* Show crawler domain creation errors (on overview page)

* Tweak whitespace around crawler domain form errors (in flyout)

Co-authored-by: Orhan Toy <toyorhan@gmail.com>
2021-12-09 09:34:58 -07:00
Michael Dokolin
27e86fde49
[Expressions] Fix execution to forward the same variables context into a subexpression (#120628) (#120922) 2021-12-09 09:31:18 -07:00
Kibana Machine
d9aed2a8de
[Fleet] Fix bug caused by API changes (#120886) (#120919)
* fix endpoint integration

* added test

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
2021-12-09 09:20:58 -07:00
Kibana Machine
b3a3c626c9
Prevent creating saved objects with empty IDs (#120693) (#120914)
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
2021-12-09 08:53:17 -07:00
Kibana Machine
cff37e2917
stop indexing severity value in uptime (#120873) (#120910)
Co-authored-by: mgiota <giota85@gmail.com>
2021-12-09 08:24:58 -07:00
Kibana Machine
661ecaf949
[Infra UI] Replace usage of deprecated filter types (#120762) (#120899)
* Replace usage of deprecated filter types

Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
2021-12-09 07:40:18 -07:00
James Gowdy
4d4d6361ea
[ML] Fixing data view search based on title (#120737) (#120781)
* [ML] Fixing data view search based on title

* removing size argument
# Conflicts:
#	x-pack/plugins/ml/server/lib/alerts/alerting_service.ts
2021-12-09 10:30:26 +00:00
Kibana Machine
2cef5853f5
[Osquery] Fix 7.16.1 issues (#120845) (#120865)
Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
2021-12-09 01:51:13 -07:00
spalger
5aa05f028f skip flaky suite (#120056)
(cherry picked from commit d9f436ccd0)
2021-12-09 01:06:29 -07:00
Tiago Costa
550898f370
[8.0] chore(NA): splits types from code on @kbn/es-query (#120783) (#120861)
* chore(NA): splits types from code on @kbn/es-query (#120783)

* chore(NA): splits types from code on @kbn/es-query

* chore(NA): add missing type exports

* chore(NA): export types as types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* chore(NA): missing export type

* chore(NA): missing export type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-12-08 21:34:54 -07:00
Kibana Machine
d635780a1f
[Stack Monitoring] separate out mb and legacy index patterns from requests (#120841) (#120856)
* seprate out mb and legacy index patterns from requests

* use config for metricbeat index

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
2021-12-08 18:34:17 -07:00
Kibana Machine
5fca173159
[Security Solution][Endpoint, Lists] Enable the ability for creating Exceptions Items that contain wildcard entries (#120679) (#120852)
* Fix parsing of errros in trusted apps creation dialog to support Exceptions API structure
* add Match Wildcard entry to the list of allowed entries for Endpoint exceptions
* Add additional test for wildcard entry and included it in array of entries

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
2021-12-08 17:44:23 -07:00
Tim Sullivan
1038c03bc4
[Reporting] do not pass a deprecated param by default (#120671) (#120847) 2021-12-08 16:14:52 -07:00
Kibana Machine
61e5a692e9
[Cases] Fix remark stringify version to match remark parse (#119995) (#120843)
* match parse and stringify version. try/catch added

* Adding tests and refactoring logError

* Adding relative path to core and kibana utils

* remark curstom serializers adapted to version 8

* add error logging to comments  migration

* Adding tests for mergeMigrationFunctionMap logging

Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
2021-12-08 16:03:45 -07:00
Kibana Machine
74f651f132
Add inject/extract references logic to new security rule type (#120818) (#120838)
Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
2021-12-08 15:40:03 -07:00
Kibana Machine
9e34c53956
[Uptime] get last successful check instead of last successful step (#118883) (#120844)
* get last successful check instead of last successful step

* adjust types

* adjust query

* remove change to get_pings

* adjust imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-12-08 15:38:05 -07:00
Kibana Machine
d9d360c2fe
[Fleet] Use deterministic UUID's for default policies (#120776) (#120842)
* Use deterministic UUID's for default policies

* Alter lookup strategy for preconfigured agent policies

* Fix ID check

* Pass ID even when creating default policies

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
2021-12-08 15:24:55 -07:00
Melissa Alvarez
7c4ff8af82
add timestamp header to rect annotation tooltip (#120702) (#120835) 2021-12-08 14:46:14 -07:00
Kibana Machine
b3b613a1d5
[Fleet] make put component template idempotent for @custom and fleet global (#120819) (#120834)
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2021-12-08 14:42:07 -07:00
Kibana Machine
0e7dccef43
[failedTestReporter] don't search for existing issues unless we're writing to GH (#120820) (#120830)
Co-authored-by: Spencer <email@spalger.com>
2021-12-08 14:24:00 -07:00
Michael Dokolin
c46b52e9c2
Fix ByteSizeValue parser to be consistent with Elasticsearch (#120653) (#120828) 2021-12-08 14:04:16 -07:00
Melissa Alvarez
1c75b10c8d
do not add depvar to includes for outlier job (#120816) (#120827) 2021-12-08 14:02:48 -07:00
Kibana Machine
f1856a9cfe
fix pattern validation (#120703) (#120810)
Co-authored-by: Matthew Kime <matt@mattki.me>
2021-12-08 12:21:19 -07:00
Kibana Machine
363f0c2903
chore(NA): use internal pkg_npm on @kbn/eslint-import-resolver-kibana (#120786) (#120805)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2021-12-08 12:09:15 -07:00
Sébastien Loix
612a3414d8
[Component templates] Unskip form payload component integration test (#120756) (#120801) 2021-12-08 11:54:20 -07:00
Kibana Machine
5b04d2b064
Surfacing deprecations with rich context from ES warning header (#120044) (#120800)
* First stab at surfacing deprecations from warning header

* Log deprecations with error level but disable logger context by default

* Don't filter out error logs from ProcRunner

* Another try at not having messages ignored on CI

* Log deprecation logs with warn not info

* Tests

* Let write() do it's writing

* Commit pre-built @kbn/pm package

* Second try to commit pre-built @kbn/pm package

* Enable deprecation logger for jest_integration even though logs aren't interleaved

* Apply suggestions from code review

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* deprecations logger: warn for kibana and debug for users

* Refactor split query and deprecation logger out of configure_client

* Unit test for tooling_log_text_writer

* Fix TS

* Use event.meta.request.params.headers to include Client constructor headers

* Fix tests

* Ignore deprecation warnings not from Elasticsearch

* Log on info level

* Log in JSON so that entire deprecation message is on one line

* commit built kbn-pm package

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Rudolf Meijering <rudolf.meijering@elastic.co>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
2021-12-08 11:53:17 -07:00
Kibana Machine
24b86085f8
Use kibana_system user for writing to Fleet system indices in Endpoint isolation (#120597) (#120794)
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
2021-12-08 11:49:34 -07:00
Kibana Machine
b200f7865a
[Security Solution] show failed endpoint transform banner on empty state (#120558) (#120790)
Co-authored-by: Joey F. Poon <joey.poon@elastic.co>
2021-12-08 11:29:45 -07:00
Kibana Machine
8e80df9387
chore(NA): remove unused dep @types/elasticsearch (#120784) (#120797)
Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2021-12-08 11:28:34 -07:00
Kibana Machine
f2743521fb
[Enterprise Search] Enhanced cannot connect error messaging (#120532) (#120795)
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
2021-12-08 11:24:24 -07:00